[GitHub] jayakarteek commented on a change in pull request #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events
jayakarteek commented on a change in pull request #2058: CLOUDSTACK-9888:
Duplicate usage while processing usage events
URL: https://github.com/apache/cloudstack/pull/2058#discussion_r143700117
##
File path: usage/src/com/cloud/usage/UsageManagerImpl.java
##
@@ -1054,8 +1054,6 @@ private void createVMHelperEvent(UsageEventVO event) {
if (EventTypes.EVENT_VM_START.equals(event.getType())) {
// create a new usage_VM_instance row for this VM
-try {
Review comment:
@rhtyd
1 We cannot reproduce the scenario directly, as it depends on usage events.
2 Duplicate usage occurs due to in correct database records and we may not
know which scenarios are populating the incorrect values.
Ideally it is good to fix the cases that are generating wrong database
records.
But there may be more then one cases that causes this error, fixing all
dependent systems is time consuming and complicated so better to handle here
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] jayakarteek commented on a change in pull request #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events
jayakarteek commented on a change in pull request #2058: CLOUDSTACK-9888:
Duplicate usage while processing usage events
URL: https://github.com/apache/cloudstack/pull/2058#discussion_r139943969
##
File path: usage/src/com/cloud/usage/UsageManagerImpl.java
##
@@ -1054,8 +1054,6 @@ private void createVMHelperEvent(UsageEventVO event) {
if (EventTypes.EVENT_VM_START.equals(event.getType())) {
// create a new usage_VM_instance row for this VM
-try {
Review comment:
Created duplicate record in cloud.usage_event table
and tested the scenario with out the fix and posted the results in above
comments
Also @niteshsarda tested the fix and gave test LGTM.
Are you looking for marvin test case
I gave full details about the issue in the first 4 comments
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] jayakarteek commented on a change in pull request #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events
jayakarteek commented on a change in pull request #2058: CLOUDSTACK-9888:
Duplicate usage while processing usage events
URL: https://github.com/apache/cloudstack/pull/2058#discussion_r142346952
##
File path: usage/src/com/cloud/usage/UsageManagerImpl.java
##
@@ -1054,8 +1054,6 @@ private void createVMHelperEvent(UsageEventVO event) {
if (EventTypes.EVENT_VM_START.equals(event.getType())) {
// create a new usage_VM_instance row for this VM
-try {
Review comment:
@rhtyd can you reply , so that I can proceed
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] jayakarteek commented on a change in pull request #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events
jayakarteek commented on a change in pull request #2058: CLOUDSTACK-9888:
Duplicate usage while processing usage events
URL: https://github.com/apache/cloudstack/pull/2058#discussion_r139943969
##
File path: usage/src/com/cloud/usage/UsageManagerImpl.java
##
@@ -1054,8 +1054,6 @@ private void createVMHelperEvent(UsageEventVO event) {
if (EventTypes.EVENT_VM_START.equals(event.getType())) {
// create a new usage_VM_instance row for this VM
-try {
Review comment:
Created duplicate record in cloud.usage_event table
and tested the scenario with out the fix and posted the results in above
comments
Also @niteshsarda tested the fix and gave test LGTM.
Are you looking for marvin test case
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] jayakarteek commented on a change in pull request #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events
jayakarteek commented on a change in pull request #2058: CLOUDSTACK-9888:
Duplicate usage while processing usage events
URL: https://github.com/apache/cloudstack/pull/2058#discussion_r139943969
##
File path: usage/src/com/cloud/usage/UsageManagerImpl.java
##
@@ -1054,8 +1054,6 @@ private void createVMHelperEvent(UsageEventVO event) {
if (EventTypes.EVENT_VM_START.equals(event.getType())) {
// create a new usage_VM_instance row for this VM
-try {
Review comment:
I already tested the scenario with out the fix and posted the results in
above comments
Also @niteshsarda tested the fix and gave test LGTM.
Are you looking for marvin test case
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] jayakarteek commented on a change in pull request #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events
jayakarteek commented on a change in pull request #2058: CLOUDSTACK-9888:
Duplicate usage while processing usage events
URL: https://github.com/apache/cloudstack/pull/2058#discussion_r139921404
##
File path: usage/src/com/cloud/usage/UsageManagerImpl.java
##
@@ -1054,8 +1054,6 @@ private void createVMHelperEvent(UsageEventVO event) {
if (EventTypes.EVENT_VM_START.equals(event.getType())) {
// create a new usage_VM_instance row for this VM
-try {
Review comment:
marvin test case is not there.
Manually tested the scenario with and without the fix for duplicate entries.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
