Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2176942197 @vishesh92 a [SL] Trillian-Jenkins test job (alma9 mgmt + vmware-70u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
vishesh92 commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2176940192 @blueorangutan test alma9 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2176816511 [SF] Trillian test result (tid-10483) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a9 Total time taken: 40151 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8508-t10483-vmware-70u3.zip Smoke tests completed. 104 look OK, 8 have errors, 19 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_restore_vm | `Error` | 3614.72 | test_restore_vm.py test_02_restore_vm_allocated_root | `Error` | 7.78 | test_restore_vm.py ContextSuite context=TestRestoreVM>:teardown | `Error` | 15.15 | test_restore_vm.py test_01_prepare_and_cancel_shutdown | `Error` | 2.60 | test_safe_shutdown.py test_02_trigger_shutdown | `Failure` | 301.37 | test_safe_shutdown.py test_01_scale_vm | `Error` | 0.03 | test_scale_vm.py test_02_scale_vm_negative_offering_disable_scaling | `Error` | 0.02 | test_scale_vm.py test_03_scale_vm_negative_vm_disable_scaling | `Error` | 0.02 | test_scale_vm.py test_04_scale_vm_with_user_account | `Error` | 3.76 | test_scale_vm.py test_04_scale_vm_with_user_account | `Error` | 3.77 | test_scale_vm.py test_05_scale_vm_dont_allow_disk_offering_change | `Error` | 0.11 | test_scale_vm.py ContextSuite context=TestScaleVm>:teardown | `Error` | 0.30 | test_scale_vm.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 3.56 | test_service_offerings.py ContextSuite context=TestSetSourceNatIp>:setup | `Error` | 0.00 | test_set_sourcenat.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py ContextSuite context=TestSnapshotStandaloneBackup>:setup | `Error` | 0.00 | test_snapshots.py test_05_stop_ssvm | `Error` | 0.15 | test_ssvm.py test_06_stop_cpvm | `Error` | 0.17 | test_ssvm.py test_07_reboot_ssvm | `Error` | 0.15 | test_ssvm.py test_08_reboot_cpvm | `Error` | 0.16 | test_ssvm.py test_09_reboot_ssvm_forced | `Error` | 0.15 | test_ssvm.py test_10_reboot_cpvm_forced | `Error` | 0.19 | test_ssvm.py test_11_destroy_ssvm | `Error` | 0.13 | test_ssvm.py test_12_destroy_cpvm | `Error` | 0.13 | test_ssvm.py test_01_import_storage_policies | `Error` | 5.94 | test_storage_policy.py ContextSuite context=TestVMWareStoragePolicies>:teardown | `Error` | 5.98 | test_storage_policy.py all_test_templates | `Skipped` | --- | test_templates.py all_test_update_security_group | `Skipped` | --- | test_update_security_group.py all_test_usage_events | `Skipped` | --- | test_usage_events.py all_test_usage | `Skipped` | --- | test_usage.py all_test_vm_autoscaling | `Skipped` | --- | test_vm_autoscaling.py all_test_vm_deployment_planner | `Skipped` | --- | test_vm_deployment_planner.py all_test_vm_life_cycle | `Skipped` | --- | test_vm_life_cycle.py all_test_vm_lifecycle_unmanage_import | `Skipped` | --- | test_vm_lifecycle_unmanage_import.py all_test_vm_schedule | `Skipped` | --- | test_vm_schedule.py all_test_vm_snapshot_kvm | `Skipped` | --- | test_vm_snapshot_kvm.py all_test_vm_snapshots | `Skipped` | --- | test_vm_snapshots.py all_test_vnf_templates | `Skipped` | --- | test_vnf_templates.py all_test_volumes | `Skipped` | --- | test_volumes.py all_test_vpc_ipv6 | `Skipped` | --- | test_vpc_ipv6.py all_test_vpc_redundant | `Skipped` | --- | test_vpc_redundant.py all_test_vpc_router_nics | `Skipped` | --- | test_vpc_router_nics.py all_test_vpc_vpn | `Skipped` | --- | test_vpc_vpn.py all_test_host_maintenance | `Skipped` | --- | test_host_maintenance.py all_test_hostha_kvm | `Skipped` | --- | test_hostha_kvm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
vishesh92 commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2175432036 @blueorangutan test alma9 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2175436385 @vishesh92 a [SL] Trillian-Jenkins test job (alma9 mgmt + vmware-70u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2175422272 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2175227347 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
sureshanaparti commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2175220215 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2165049590 [SF] Trillian test result (tid-10422) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a9 Total time taken: 65623 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8508-t10422-vmware-70u3.zip Smoke tests completed. 130 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_list_vms_metrics_admin | `Error` | 3625.41 | test_metrics_api.py test_list_vms_metrics_history | `Error` | 4.72 | test_metrics_api.py test_list_volumes_metrics_history | `Error` | 3618.26 | test_metrics_api.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2163125571 @DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + vmware-70u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
DaanHoogland commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2163119952 @blueorangutan test alma9 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2163017776 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2162880582 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
vishesh92 commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2162877784 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
vishesh92 commented on code in PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#discussion_r1636366530 ## test/integration/smoke/test_cluster_drs.py: ## @@ -256,12 +294,15 @@ def test_02_balanced_drs_algorithm(self): migration["virtualmachineid"]: migration["destinationhostid"] for migration in migrations } -self.assertEqual(len(vm_to_dest_host_map), 1, msg="DRS plan should have 1 migrations") +# this is one if no svm is considered to be migrated, it might be higher +self.assertTrue(len(vm_to_dest_host_map) >= 1, msg="DRS plan should have at least 1 migrations") executed_plan = self.cluster.executeDrsPlan(self.apiclient, vm_to_dest_host_map) self.wait_for_plan_completion(executed_plan) vm_1_host_id = self.get_vm_host_id(self.virtual_machine_1.id) vm_2_host_id = self.get_vm_host_id(self.virtual_machine_2.id) -self.assertNotEqual(vm_1_host_id, vm_2_host_id, msg="Both VMs should be on different hosts") +self.assertTrue( +vm_1_host_id != self.virtual_machine_1.hostid or vm_2_host_id != self.virtual_machine_1.hostid, Review Comment: ```suggestion vm_1_host_id != self.virtual_machine_1.hostid or vm_2_host_id != self.virtual_machine_2.hostid, ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2162846405 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2162735048 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
vishesh92 commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2162732404 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
vishesh92 commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2160429817 @blueorangutan test alma9 vmware-70u3 keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2153831349 [SF] Trillian test result (tid-10380) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a9 Total time taken: 62616 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8508-t10380-vmware-70u3.zip Smoke tests completed. 129 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_balanced_drs_algorithm | `Failure` | 185.06 | test_cluster_drs.py test_list_vms_metrics_admin | `Error` | 3618.26 | test_metrics_api.py test_list_vms_metrics_history | `Error` | 7.84 | test_metrics_api.py test_list_volumes_metrics_history | `Error` | 3622.53 | test_metrics_api.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2151877080 @DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + vmware-70u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
DaanHoogland commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2151874513 @blueorangutan test alma9 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
DaanHoogland commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2151873287 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2151843388 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
DaanHoogland commented on code in PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#discussion_r1629008188 ## test/integration/smoke/test_cluster_drs.py: ## @@ -256,7 +294,8 @@ def test_02_balanced_drs_algorithm(self): migration["virtualmachineid"]: migration["destinationhostid"] for migration in migrations } -self.assertEqual(len(vm_to_dest_host_map), 1, msg="DRS plan should have 1 migrations") +# this is one if no svm is considered to be migrated, it might be higher +self.assertTrue(len(vm_to_dest_host_map) <= 1, msg="DRS plan should have 1 migrations") Review Comment: ```suggestion self.assertTrue(len(vm_to_dest_host_map) >= 1, msg="DRS plan should have at least 1 migrations") ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2151085893 [SF] Trillian test result (tid-10360) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a8 Total time taken: 48249 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8508-t10360-vmware-70u3.zip Smoke tests completed. 130 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_balanced_drs_algorithm | `Failure` | 132.49 | test_cluster_drs.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2150792650 [SF] Trillian test result (tid-10340) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a8 Total time taken: 108661 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8508-t10340-vmware-70u3.zip Smoke tests completed. 127 look OK, 4 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_balanced_drs_algorithm | `Failure` | 127.19 | test_cluster_drs.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 3613.08 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | `Error` | 3611.57 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 3616.39 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Error` | 3619.47 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 3611.61 | test_vpc_redundant.py test_01_redundant_vpc_site2site_vpn | `Failure` | 3611.19 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | `Error` | 3611.33 | test_vpc_vpn.py test_01_vpc_site2site_vpn_multiple_options | `Failure` | 3611.16 | test_vpc_vpn.py test_01_vpc_site2site_vpn_multiple_options | `Error` | 3611.31 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | `Failure` | 3607.98 | test_vpc_vpn.py test_01_vpc_site2site_vpn | `Failure` | 3665.83 | test_vpc_vpn.py test_01_vpc_site2site_vpn | `Error` | 3666.00 | test_vpc_vpn.py test_01_cancel_host_maintenace_with_no_migration_jobs | `Error` | 1807.13 | test_host_maintenance.py test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 2008.20 | test_host_maintenance.py test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 1907.08 | test_host_maintenance.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2149242144 @shwstppr a [SL] Trillian-Jenkins test job (alma8 mgmt + vmware-70u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
shwstppr commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2149236983 @blueorangutan test alma8 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2146835423 [SF] Trillian Build Failed (tid-10338) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2146820297 @DaanHoogland a [SL] Trillian-Jenkins test job (alma8 mgmt + vmware-70u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
DaanHoogland commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2146817013 @blueorangutan test alma8 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2146799333 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9772 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
DaanHoogland closed pull request #8508: assertion improvement on cluster DRS URL: https://github.com/apache/cloudstack/pull/8508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2145037529 Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
github-actions[bot] commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2144931959 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
vishesh92 commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2144893328 @DaanHoogland Test is in 4.19 as well. So, we need to fix this for 4.19 as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
DaanHoogland commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2144882638 @shwstppr I can rebase if needed, but didn´t think it relevant or 4.19 (might be mistaking) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
shwstppr commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2144483833 @DaanHoogland should this target to 4.19 branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-1899534870 [SF] Trillian test result (tid-8868) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a8 Total time taken: 49254 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8508-t8868-vmware-70u3.zip Smoke tests completed. 119 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_trigger_shutdown | `Failure` | 341.68 | test_safe_shutdown.py test_02_balanced_drs_algorithm | `Failure` | 130.40 | test_cluster_drs.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-1898355331 @DaanHoogland a [SL] Trillian-Jenkins test job (alma8 mgmt + vmware-70u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
DaanHoogland commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-1898352980 @blueorangutan test alma8 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-1898275314 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-1898120355 Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 8357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-1897714991 [SF] Trillian test result (tid-8862) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a8 Total time taken: 50935 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8508-t8862-vmware-70u3.zip Smoke tests completed. 120 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestClusterDRS>:setup | `Error` | 0.00 | test_cluster_drs.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-1895723319 @DaanHoogland a [SL] Trillian-Jenkins test job (alma8 mgmt + vmware-70u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
DaanHoogland commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-1895721060 @blueorangutan test alma8 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-1895600428 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
DaanHoogland commented on code in PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#discussion_r1455143400 ## test/integration/smoke/test_cluster_drs.py: ## @@ -23,6 +23,7 @@ import time Review Comment: ```suggestion from collections.abc import Iterable ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-1894768078 [SF] Trillian test result (tid-8846) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a8 Total time taken: 49687 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8508-t8846-vmware-70u3.zip Smoke tests completed. 120 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestClusterDRS>:setup | `Error` | 0.00 | test_cluster_drs.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-1893497754 @DaanHoogland a [SL] Trillian-Jenkins test job (alma8 mgmt + vmware-70u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
DaanHoogland commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-1893495793 @blueorangutan test alma8 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-1893466506 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-1893344605 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
DaanHoogland commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-1893341208 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-1893095811 [SF] Trillian test result (tid-8841) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a8 Total time taken: 46717 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8508-t8841-vmware-70u3.zip Smoke tests completed. 120 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestClusterDRS>:setup | `Error` | 0.00 | test_cluster_drs.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-1892388829 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-1891790283 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
codecov[bot] commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-1891633650 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8508?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`c3b77cb`)](https://app.codecov.io/gh/apache/cloudstack/commit/c3b77cb7b82bfe8e94b024e81e1721532da51a9c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 15.75% compared to head [(`d83bb07`)](https://app.codecov.io/gh/apache/cloudstack/pull/8508?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 4.39%. Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8508 +/- ## - Coverage 15.75% 4.39% -11.37% Files 4848 361 -4487 Lines324301 28624 -295677 Branches 455614993-40568 - Hits 511001258-49842 + Misses 266047 27227 -238820 + Partials 7154 139 -7015 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8508/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8508/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8508/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.39% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8508?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-1891618437 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] assertion improvement on cluster DRS [cloudstack]
DaanHoogland commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-1891617851 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org