[GitHub] [cloudstack] blueorangutan commented on pull request #5066: CLOUDSTACK-10436:remind users to use correct permission for tmp dir and fixed an NPE

2021-06-14 Thread GitBox 


blueorangutan commented on pull request #5066:
URL: https://github.com/apache/cloudstack/pull/5066#issuecomment-859178430






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4577: [HEALTH] 4.16/master Health Check please don't merge this

2021-06-14 Thread GitBox 


blueorangutan commented on pull request #4577:
URL: https://github.com/apache/cloudstack/pull/4577#issuecomment-859187939






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] nvazquez opened a new pull request #5103: Extend the Annotations framework

2021-06-14 Thread GitBox 


nvazquez opened a new pull request #5103:
URL: https://github.com/apache/cloudstack/pull/5103


   ### Description
   
   This PR extends the current annotations framework
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5034: UI: bulk action support for various resources

2021-06-14 Thread GitBox 


blueorangutan commented on pull request #5034:
URL: https://github.com/apache/cloudstack/pull/5034#issuecomment-859341332






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Humbedooh closed pull request #2099: CLOUDSTACK-8612 [VMware] Make vCenter session timeout configurable for volume snapshot

2021-06-14 Thread GitBox 


Humbedooh closed pull request #2099:
URL: https://github.com/apache/cloudstack/pull/2099


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on issue #5091: VM operation fail after storage drs in VMware datastore cluster

2021-06-14 Thread GitBox 


rhtyd commented on issue #5091:
URL: https://github.com/apache/cloudstack/issues/5091#issuecomment-859626763


   Fixed in https://github.com/apache/cloudstack/pull/5097


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #5095: Failed to scale between Service Offerings with the same root disk size

2021-06-14 Thread GitBox 


rhtyd commented on pull request #5095:
URL: https://github.com/apache/cloudstack/pull/5095#issuecomment-859626996


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Humbedooh closed pull request #4537: CLOUDSTACK-10424:Potential sensitive information disclosure

2021-06-14 Thread GitBox 


Humbedooh closed pull request #4537:
URL: https://github.com/apache/cloudstack/pull/4537


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5024: Health Check PR: 4.15

2021-06-14 Thread GitBox 


blueorangutan commented on pull request #5024:
URL: https://github.com/apache/cloudstack/pull/5024#issuecomment-859274063






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5102: [HEALTH] Default branch 'main' (renamed from 'master') Health Checks - Please don't merge this

2021-06-14 Thread GitBox 


blueorangutan commented on pull request #5102:
URL: https://github.com/apache/cloudstack/pull/5102#issuecomment-859534025






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4958: Improve logs on agent start

2021-06-14 Thread GitBox 


blueorangutan commented on pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958#issuecomment-859479998






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4640: Added disk provisioning type support for VMWare

2021-06-14 Thread GitBox 


blueorangutan commented on pull request #4640:
URL: https://github.com/apache/cloudstack/pull/4640#issuecomment-859482260






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] luhaijiao commented on pull request #4833: novnc: Fix vm console is not working on firefox if language is not English

2021-06-14 Thread GitBox 


luhaijiao commented on pull request #4833:
URL: https://github.com/apache/cloudstack/pull/4833#issuecomment-859415184


   We have hit the same issue.  Shall we have it in 4.15.1 as well since it's 
not released yet. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] andrijapanicsb commented on issue #5100: CloudStack doesn't respect rootDiskController in template settings

2021-06-14 Thread GitBox 


andrijapanicsb commented on issue #5100:
URL: https://github.com/apache/cloudstack/issues/5100#issuecomment-859486587






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5095: Failed to scale between Service Offerings with the same root disk size

2021-06-14 Thread GitBox 


shwstppr commented on pull request #5095:
URL: https://github.com/apache/cloudstack/pull/5095#issuecomment-859259678






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5090: UI: Keyboard shortcuts

2021-06-14 Thread GitBox 


DaanHoogland commented on pull request #5090:
URL: https://github.com/apache/cloudstack/pull/5090#issuecomment-859431613


   code and functionality look promising, your commit list not so much ;) any 
idea what happened there @apurv-1 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] RodrigoDLopez closed pull request #4283: Removes unnecessary validations

2021-06-14 Thread GitBox 


RodrigoDLopez closed pull request #4283:
URL: https://github.com/apache/cloudstack/pull/4283


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4577: [HEALTH] 4.16/master Health Check please don't merge this

2021-06-14 Thread GitBox 


blueorangutan commented on pull request #4577:
URL: https://github.com/apache/cloudstack/pull/4577#issuecomment-859833064






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #5102: [HEALTH] Default branch 'main' (renamed from 'master') Health Checks - Please don't merge this

2021-06-14 Thread GitBox 


sureshanaparti commented on pull request #5102:
URL: https://github.com/apache/cloudstack/pull/5102#issuecomment-859533378


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4958: Improve logs on agent start

2021-06-14 Thread GitBox 


rhtyd commented on pull request #4958:
URL: https://github.com/apache/cloudstack/pull/4958#issuecomment-859624201


   Let me get back to this next week or the week after, sorry I've been busy 
with 4.15 release and PRs related to 4.15 and other work stuff. I hope there's 
no urgency to get these PRs merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5097: Update chain info of the volumes after migrate operations

2021-06-14 Thread GitBox 


blueorangutan commented on pull request #5097:
URL: https://github.com/apache/cloudstack/pull/5097#issuecomment-859214927


   Trillian test result (tid-906)
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 52249 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5097-t906-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Smoke tests completed. 86 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 601.04 | 
test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
`Failure` | 627.55 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 551.77 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 586.83 | test_vpc_redundant.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] RodrigoDLopez commented on pull request #4257: remove the unnecessary check for tags when migrating volumes

2021-06-14 Thread GitBox 


RodrigoDLopez commented on pull request #4257:
URL: https://github.com/apache/cloudstack/pull/4257#issuecomment-859593681


   > I did a highlevel check I hesitate with removing these checks, 
@sureshanaparti - do you want to add some ideas we recently discussed?
   
   could you please explain me why?
   
   @sureshanaparti can you share thos ideas with me?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4585: Externalize kvm agent storage timeout configuration

2021-06-14 Thread GitBox 


blueorangutan commented on pull request #4585:
URL: https://github.com/apache/cloudstack/pull/4585#issuecomment-859942511


   Trillian test result (tid-915)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 46008 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4585-t915-kvm-centos7.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 87 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 3664.49 | 
test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.05 | 
test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | 
test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 77.38 | 
test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5099: server: fix scale for dummy template ingested vm

2021-06-14 Thread GitBox 


shwstppr commented on pull request #5099:
URL: https://github.com/apache/cloudstack/pull/5099#issuecomment-859260094


   Fix added in #5095 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd merged pull request #5097: Update chain info of the volumes after migrate operations

2021-06-14 Thread GitBox 


rhtyd merged pull request #5097:
URL: https://github.com/apache/cloudstack/pull/5097


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] mib1185 edited a comment on pull request #5097: Update chain info of the volumes after migrate operations

2021-06-14 Thread GitBox 


mib1185 edited a comment on pull request #5097:
URL: https://github.com/apache/cloudstack/pull/5097#issuecomment-859381013


   > Ping @mib1185 @DK101010 can you review/test this in your fork?
   
   @rhtyd tests were successful - works like a charm now 👍 
   @harikrishna-patnala many thanks for the fast support and provided fix 👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #5024: Health Check PR: 4.15

2021-06-14 Thread GitBox 


rhtyd commented on pull request #5024:
URL: https://github.com/apache/cloudstack/pull/5024#issuecomment-859730727






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DK101010 commented on a change in pull request #4662: Feat/ram reservation

2021-06-14 Thread GitBox 


DK101010 commented on a change in pull request #4662:
URL: https://github.com/apache/cloudstack/pull/4662#discussion_r649735655



##
File path: 
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/guru/VmwareVmImplementer.java
##
@@ -139,6 +140,9 @@ VirtualMachineTO implement(VirtualMachineProfile vm, 
VirtualMachineTO to, long c
 details.put(VmDetailConstants.NIC_ADAPTER, 
VirtualEthernetCardType.E1000.toString());
 }
 }
+
if(StringUtils.isEmpty(details.get(VmDetailConstants.RAM_RESERVATION))){
+details.put(VmDetailConstants.RAM_RESERVATION, "0.0");

Review comment:
   Hi @GabrielBrascher, sorry for my late answer, I must have missed the 
notification.  I think there are no benefits regards reusable of this code, but 
I agree it's better to use parameter instead of strings. I'm prefer your first 
suggestion and will adapt  it. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Humbedooh closed pull request #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMware

2021-06-14 Thread GitBox 


Humbedooh closed pull request #2340:
URL: https://github.com/apache/cloudstack/pull/2340


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #2850: WIP: Vault Integration

2021-06-14 Thread GitBox 


rhtyd commented on pull request #2850:
URL: https://github.com/apache/cloudstack/pull/2850#issuecomment-859602240






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[cloudstack] branch 4.15 updated (9dd0acf -> bc12833)

2021-06-14 Thread rohit 
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch 4.15
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 9dd0acf  ui: add action syncStoragePool (#5098)
 add bc12833  server: Failed to scale between Service Offerings with the 
same root disk size (#5095)

No new revisions were added by this update.

Summary of changes:
 .../com/cloud/storage/VolumeApiServiceImpl.java| 45 -
 .../cloud/storage/VolumeApiServiceImplTest.java| 56 +-
 2 files changed, 86 insertions(+), 15 deletions(-)

[GitHub] [cloudstack] Humbedooh closed pull request #2090: CLOUDSTACK-8415 [VMware] SSVM shutdown during snapshot operation results in disks to be left behind

2021-06-14 Thread GitBox 


Humbedooh closed pull request #2090:
URL: https://github.com/apache/cloudstack/pull/2090


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4954: Unify SMTP mail sending

2021-06-14 Thread GitBox 


rhtyd commented on pull request #4954:
URL: https://github.com/apache/cloudstack/pull/4954#issuecomment-859624657


   thanks lgtm, @GutoVeronezi can you fix the conflict though?
   @DaanHoogland you may merge this if/when Travis passes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Humbedooh closed pull request #2311: CLOUDSTACK-10134 Optimization of applying port forwarding rules

2021-06-14 Thread GitBox 


Humbedooh closed pull request #2311:
URL: https://github.com/apache/cloudstack/pull/2311


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] apurv-1 commented on pull request #5090: UI: Keyboard shortcuts

2021-06-14 Thread GitBox 


apurv-1 commented on pull request #5090:
URL: https://github.com/apache/cloudstack/pull/5090#issuecomment-859786984


   @DaanHoogland it was multiple attempts to fetch the upstream main branch! 😅
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on pull request #5095: Failed to scale between Service Offerings with the same root disk size

2021-06-14 Thread GitBox 


GabrielBrascher commented on pull request #5095:
URL: https://github.com/apache/cloudstack/pull/5095#issuecomment-859635011






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher opened a new pull request #5101: Enhance docs for changeServiceForVM & scaleVirtualMachine

2021-06-14 Thread GitBox 


GabrielBrascher opened a new pull request #5101:
URL: https://github.com/apache/cloudstack/pull/5101


   ### Description
   
   Over the past years, I have seen some confusion regarding which command to 
use when changing a VM's offering. Users tend to choose always the API command 
`changeServiceForVirtualMachine` and are not aware of `scaleVirtualMachine`. On 
the best case, the user knows that both commands exist but is not sure about 
which one to choose.
   
   This PR proposes some enhancements on the documentation of API commands 
`changeServiceForVirtualMachine` and `scaleVirtualMachine`. One of the major 
differences of both is that `scaleVirtualMachine` takes into account disk 
offerings, and also resizes the volume if necessary while 
`changeServiceForVirtualMachine` focuses only on updating the "compute" 
offering. 
   
   This leads to issues and inconsistencies where a client expects the root 
volume to have its disk offering updated matching the new Service offering; 
however, it is not changed and it gets to a point where VM has an offering and 
the volume another.
   
    1. changeServiceForVirtualMachine
   From:
   ~~~
   Changes the service offering for a virtual machine.
   The virtual machine must be in a "Stopped" state for this command to take 
effect.
   ~~~
   
   To:
   ~~~
   Changes the service offering for a virtual machine.
   The virtual machine must be in a "Stopped" state for this command to take 
effect.
   Note that it only changes the VM's compute offering and it does not update 
the root volume offering.
   If the Service Offering has a root disk size the volume will be resized only 
if using API command 'scaleVirtualMachine'.
   ~~~
   
   
   
    2. Scale Virtual Machine documentation
   From:
   ~~~
   Scales the virtual machine to a new service offering.
   ~~~
   
   To:
   ~~~
   Scales the virtual machine to a new service offering.
   This command also takes into account the Volume and it may resize the root 
disk size according to the service offering.
   ~~~
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [X] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [X] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   N/A
   
   ### How Has This Been Tested?
   
   
   
   N/A
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5103: Extend the Annotations framework

2021-06-14 Thread GitBox 


blueorangutan commented on pull request #5103:
URL: https://github.com/apache/cloudstack/pull/5103#issuecomment-859668578






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd closed issue #5086: Please add UI integration for syncStoragePool api-call

2021-06-14 Thread GitBox 


rhtyd closed issue #5086:
URL: https://github.com/apache/cloudstack/issues/5086


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Humbedooh closed pull request #1897: CLOUDSTACK-9733: Concurrent volume snapshots of a VM are not allowed and are not limited per host as per the global configuration parameter "

2021-06-14 Thread GitBox 


Humbedooh closed pull request #1897:
URL: https://github.com/apache/cloudstack/pull/1897


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] PaulAngus commented on pull request #4283: Removes unnecessary validations

2021-06-14 Thread GitBox 


PaulAngus commented on pull request #4283:
URL: https://github.com/apache/cloudstack/pull/4283#issuecomment-859691225


   
   I don’t know anything about another version of your idea, no one has pinged 
me to comment on it.  I would be sad if the author of the other version hadn’t 
pinged you for your comments.
   
   Certainly nothing should be merged without tests.  If there aren’t tests you 
should bring it up with whoever merged it and if you get no joy there, the 
community.
   
   
   Kind Regards
   
   
   Paul Angus
   
   From: Rodrigo D. Lopez ***@***.***>
   Sent: Friday, June 11, 2021 2:39 PM
   To: apache/cloudstack ***@***.***>
   Cc: Paul Angus ***@***.***>; Mention ***@***.***>
   Subject: Re: [apache/cloudstack] Removes unnecessary validations (#4283)
   
   
   @PaulAngus 
@shwstppr
   This one is not needed anymore.
   Those that made trouble to merge this, has merged another branch that do 
exactly the same result.
   Many thanks to you all, prevents mine ideas to go through. but implements 
those ideas in another way and merge it without testes. you rock
   
   @weizhouapache 
@rafaelweingartner 
@GabrielBrascher
   thanks for the review
   
   —
   You are receiving this because you were mentioned.
   Reply to this email directly, view it on 
GitHub, 
or 
unsubscribe.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] sureshanaparti opened a new pull request #5102: [HEALTH] Default branch 'main' (renamed from 'master') Health Checks - Please don't merge this

2021-06-14 Thread GitBox 


sureshanaparti opened a new pull request #5102:
URL: https://github.com/apache/cloudstack/pull/5102


   ### Description
   
   This is a dummy PR to track the health of default branch 'main' (renamed 
from 'master') branch via smoke tests.
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5083: systemvm with overlayfs

2021-06-14 Thread GitBox 


blueorangutan commented on pull request #5083:
URL: https://github.com/apache/cloudstack/pull/5083#issuecomment-859281957






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] pdion891 commented on pull request #2850: WIP: Vault Integration

2021-06-14 Thread GitBox 


pdion891 commented on pull request #2850:
URL: https://github.com/apache/cloudstack/pull/2850#issuecomment-859522627






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5102: [HEALTH] Default branch 'main' (renamed from 'master') Health Checks - Please don't merge this

2021-06-14 Thread GitBox 


DaanHoogland commented on pull request #5102:
URL: https://github.com/apache/cloudstack/pull/5102#issuecomment-859567970


   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] RodrigoDLopez edited a comment on pull request #4257: remove the unnecessary check for tags when migrating volumes

2021-06-14 Thread GitBox 


RodrigoDLopez edited a comment on pull request #4257:
URL: https://github.com/apache/cloudstack/pull/4257#issuecomment-859593681


   > I did a highlevel check I hesitate with removing these checks, 
@sureshanaparti - do you want to add some ideas we recently discussed?
   
   could you please explain me why?
   
   @sureshanaparti can you share this ideas with me?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on issue #5086: Please add UI integration for syncStoragePool api-call

2021-06-14 Thread GitBox 


rhtyd commented on issue #5086:
URL: https://github.com/apache/cloudstack/issues/5086#issuecomment-859627384


   Fixed in https://github.com/apache/cloudstack/pull/5098


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5066: CLOUDSTACK-10436:remind users to use correct permission for tmp dir and fixed an NPE

2021-06-14 Thread GitBox 


DaanHoogland commented on pull request #5066:
URL: https://github.com/apache/cloudstack/pull/5066#issuecomment-859508193


   @rhtyd do you approve?
   @lujiefsi have you tested? do we need more testing?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #5103: Extend the Annotations framework

2021-06-14 Thread GitBox 


nvazquez commented on pull request #5103:
URL: https://github.com/apache/cloudstack/pull/5103#issuecomment-859668391


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd edited a comment on pull request #4819: Remove meaningless password regeneration on resetSSHKeyForVirtualMachine

2021-06-14 Thread GitBox 


rhtyd edited a comment on pull request #4819:
URL: https://github.com/apache/cloudstack/pull/4819#issuecomment-859625456


   By config drive I mean yes cloud-init but enabling config drive by creating 
a new network offering (in a new network offering you can use config drive for 
user-data etc) @GutoVeronezi and checking with/without cloud-init if the the 
behaviour with this PR matches expectation on say SSH reset operation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Humbedooh closed pull request #2067: CLOUDSTACK-9852: This patch implements the storage lb feature

2021-06-14 Thread GitBox 


Humbedooh closed pull request #2067:
URL: https://github.com/apache/cloudstack/pull/2067


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] aleskxyz commented on issue #5100: CloudStack doesn't respect rootDiskController in template settings

2021-06-14 Thread GitBox 


aleskxyz commented on issue #5100:
URL: https://github.com/apache/cloudstack/issues/5100#issuecomment-859530449






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on issue #4887: Inclusivity: Rename default git branch name from 'master' to 'main', and replace offensive words/terms as appropriate

2021-06-14 Thread GitBox 


sureshanaparti commented on issue #4887:
URL: https://github.com/apache/cloudstack/issues/4887#issuecomment-859534747


   The default branch has been renamed to 'main' (from 'master'), Created 
health checks PR: https://github.com/apache/cloudstack/pull/5102


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] GutoVeronezi commented on pull request #4954: Unify SMTP mail sending

2021-06-14 Thread GitBox 


GutoVeronezi commented on pull request #4954:
URL: https://github.com/apache/cloudstack/pull/4954#issuecomment-859632475






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] mib1185 commented on pull request #5097: Update chain info of the volumes after migrate operations

2021-06-14 Thread GitBox 


mib1185 commented on pull request #5097:
URL: https://github.com/apache/cloudstack/pull/5097#issuecomment-859381013


   > Ping @mib1185 @DK101010 can you review/test this in your fork?
   
   @rhtyd tests were successful - works like a charm now 👍 
   @harikrishna-patnala many thanks for the fast support und provided fix 👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Pearl1594 commented on pull request #5095: Failed to scale between Service Offerings with the same root disk size

2021-06-14 Thread GitBox 


Pearl1594 commented on pull request #5095:
URL: https://github.com/apache/cloudstack/pull/5095#issuecomment-859688487


   @GabrielBrascher Seems like the NPE still persists - when attempting to 
resize the volume of a VM deployed using an ISO:
   ```
   021-06-11 14:57:03,029 ERROR [c.c.a.ApiAsyncJobDispatcher] 
(API-Job-Executor-1:ctx-7cd19915 job-76) (logid:66182097) Unexpected exception 
while executing 
org.apache.cloudstack.api.command.admin.volume.ResizeVolumeCmdByAdmin
   java.lang.NullPointerException
at 
com.cloud.storage.VolumeApiServiceImpl.isNotPossibleToResize(VolumeApiServiceImpl.java:1184)
at 
com.cloud.storage.VolumeApiServiceImpl.resizeVolume(VolumeApiServiceImpl.java:938)
at 
com.cloud.storage.VolumeApiServiceImpl.resizeVolume(VolumeApiServiceImpl.java:194)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
   
   ```
   However, resizing after scaling works fine.
   There needs to be a null check for the serviceOfferingView Object, or 
something around the lines of:
   `return (isNotIso && serviceOfferingView.getRootDiskSize() > 0 && isRoot);`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Humbedooh closed pull request #2440: CLOUDSTACK-10260 : Introducing a new API to collect and list CPU Sockets Metrics information for all Hypervisors.

2021-06-14 Thread GitBox 


Humbedooh closed pull request #2440:
URL: https://github.com/apache/cloudstack/pull/2440


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #5095: Failed to scale between Service Offerings with the same root disk size

2021-06-14 Thread GitBox 


GabrielBrascher commented on a change in pull request #5095:
URL: https://github.com/apache/cloudstack/pull/5095#discussion_r649930628



##
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##
@@ -1167,6 +1165,16 @@ public VolumeVO resizeVolume(ResizeVolumeCmd cmd) throws 
ResourceAllocationExcep
 shrinkOk);
 }
 
+/**
+ * A volume should not be resized if it covers ALL the following 
scenarios: 
+ * 1 - Root volume 
+ * 2 - && Current Disk Offering enforces a root disk size (in this case 
one can resize only by changing the Service Offering) 
+ */
+private boolean isNotPossibleToResize(VolumeVO volume, DiskOfferingVO 
diskOffering) {
+ServiceOfferingJoinVO serviceOfferingView = 
serviceOfferingJoinDao.findById(diskOffering.getId());
+return serviceOfferingView.getRootDiskSize() > 0 && 
volume.getVolumeType().equals(Volume.Type.ROOT);

Review comment:
   @shwstppr thanks for testing it, I really appreciate it. I will get the 
ISO format validation back then.
   
   Regarding the serviceOfferingView, it is used as that table contains the 
root disk size which allows us to diff offerings that enforce the root disk 
size of those that allow resizing the volume.

##
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##
@@ -1167,6 +1165,16 @@ public VolumeVO resizeVolume(ResizeVolumeCmd cmd) throws 
ResourceAllocationExcep
 shrinkOk);
 }
 
+/**
+ * A volume should not be resized if it covers ALL the following 
scenarios: 
+ * 1 - Root volume 
+ * 2 - && Current Disk Offering enforces a root disk size (in this case 
one can resize only by changing the Service Offering) 
+ */
+private boolean isNotPossibleToResize(VolumeVO volume, DiskOfferingVO 
diskOffering) {
+ServiceOfferingJoinVO serviceOfferingView = 
serviceOfferingJoinDao.findById(diskOffering.getId());
+return serviceOfferingView.getRootDiskSize() > 0 && 
volume.getVolumeType().equals(Volume.Type.ROOT);

Review comment:
   @shwstppr thanks for testing it, I really appreciate it. I will get the 
ISO format validation back then.
   
   Regarding the serviceOfferingView, it is used as that "table/view" contains 
the root disk size which allows us to diff offerings that enforce the root disk 
size of those that allow resizing the volume.

##
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##
@@ -1167,6 +1165,27 @@ public VolumeVO resizeVolume(ResizeVolumeCmd cmd) throws 
ResourceAllocationExcep
 shrinkOk);
 }
 
+/**
+ * A volume should not be resized if it covers ALL the following 
scenarios: 
+ * 1 - Root volume 
+ * 2 - && Current Disk Offering enforces a root disk size (in this case 
one can resize only by changing the Service Offering)
+ */
+protected boolean isNotPossibleToResize(VolumeVO volume, DiskOfferingVO 
diskOffering) {
+Long templateId = volume.getTemplateId();
+ImageFormat format = null;
+if (templateId != null) {
+VMTemplateVO template = _templateDao.findById(templateId);

Review comment:
   @shwstppr sounds good; I've added a commit for it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5037: Updated PowerFlex/ScaleIO gateway client with some improvements.

2021-06-14 Thread GitBox 


blueorangutan commented on pull request #5037:
URL: https://github.com/apache/cloudstack/pull/5037#issuecomment-859536862






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4577: [HEALTH] 4.16/master Health Check please don't merge this

2021-06-14 Thread GitBox 


DaanHoogland commented on pull request #4577:
URL: https://github.com/apache/cloudstack/pull/4577#issuecomment-859414909






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] radu-todirica commented on pull request #4205: Integrate Tungsten Fabric with CloudStack

2021-06-14 Thread GitBox 


radu-todirica commented on pull request #4205:
URL: https://github.com/apache/cloudstack/pull/4205#issuecomment-859670570


   @rhtyd i know there are a lot of conflicts but i'm not sure if it's a good 
idea to merge the latest master because there's not the old UI anymore so you 
will not have the UI changes since we did those changes on the old UI. I know 
there is someone working on implementing the UI changes on the new UI but right 
now those changes are not merged yet. So if i will merge the latest master the 
UI changes will not be available anymore.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] shwstppr closed pull request #5099: server: fix scale for dummy template ingested vm

2021-06-14 Thread GitBox 


shwstppr closed pull request #5099:
URL: https://github.com/apache/cloudstack/pull/5099


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] RodrigoDLopez commented on pull request #4283: Removes unnecessary validations

2021-06-14 Thread GitBox 


RodrigoDLopez commented on pull request #4283:
URL: https://github.com/apache/cloudstack/pull/4283#issuecomment-859588534


   @PaulAngus @shwstppr 
   This one is not needed anymore.
   Those that made trouble to merge this, has merged another branch that do 
exactly the same result.
   Many thanks to you all, prevents mine ideas to go through. but implements 
those ideas in another way and merge it without testes. you rock
   
   @weizhouapache @rafaelweingartner @GabrielBrascher 
   thanks for the review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] RodrigoDLopez edited a comment on pull request #4283: Removes unnecessary validations

2021-06-14 Thread GitBox 


RodrigoDLopez edited a comment on pull request #4283:
URL: https://github.com/apache/cloudstack/pull/4283#issuecomment-859588534


   @PaulAngus @shwstppr 
   This one is not needed anymore.
   Those that made the trouble to merge this, has merged another branch that 
does exactly the same result.
   Many thanks to you all, prevents my ideas to go through, but still implement 
those ideas in another way and merge it without tests. You rock
   
   @weizhouapache @rafaelweingartner @GabrielBrascher 
   thanks for the review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] weizhouapache closed pull request #5083: systemvm with overlayfs

2021-06-14 Thread GitBox 


weizhouapache closed pull request #5083:
URL: https://github.com/apache/cloudstack/pull/5083


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #4833: novnc: Fix vm console is not working on firefox if language is not English

2021-06-14 Thread GitBox 


weizhouapache commented on pull request #4833:
URL: https://github.com/apache/cloudstack/pull/4833#issuecomment-859464174


   > We have hit the same issue. Shall we have it in 4.15.1 as well since it's 
not released yet.
   
   @luhaijiao it has been merged into 4.15 branch, it will be released in 
4.15.1.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd merged pull request #5098: ui: add action syncStoragePool

2021-06-14 Thread GitBox 


rhtyd merged pull request #5098:
URL: https://github.com/apache/cloudstack/pull/5098


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd closed issue #5091: VM operation fail after storage drs in VMware datastore cluster

2021-06-14 Thread GitBox 


rhtyd closed issue #5091:
URL: https://github.com/apache/cloudstack/issues/5091


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Humbedooh closed pull request #2234: CLOUDSTACK-10041: Support to use ikev1 for site-to-site VPN connections

2021-06-14 Thread GitBox 


Humbedooh closed pull request #2234:
URL: https://github.com/apache/cloudstack/pull/2234


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] RodrigoDLopez removed a comment on pull request #4283: Removes unnecessary validations

2021-06-14 Thread GitBox 


RodrigoDLopez removed a comment on pull request #4283:
URL: https://github.com/apache/cloudstack/pull/4283#issuecomment-859588534


   @PaulAngus @shwstppr 
   This one is not needed anymore.
   Those that made the trouble to merge this, has merged another branch that 
does exactly the same result.
   Many thanks to you all, prevents my ideas to go through, but still implement 
those ideas in another way and merge it without tests. You rock
   
   @weizhouapache @rafaelweingartner @GabrielBrascher 
   thanks for the review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4585: Externalize kvm agent storage timeout configuration

2021-06-14 Thread GitBox 


DaanHoogland commented on pull request #4585:
URL: https://github.com/apache/cloudstack/pull/4585#issuecomment-859426545


   > There are some errors on Marvin's tests. Not sure if they are related to 
this PR, though.
   
   started a second run, we'll see if the errors are consistent.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on a change in pull request #5095: Failed to scale between Service Offerings with the same root disk size

2021-06-14 Thread GitBox 


shwstppr commented on a change in pull request #5095:
URL: https://github.com/apache/cloudstack/pull/5095#discussion_r649782157



##
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##
@@ -1167,6 +1165,16 @@ public VolumeVO resizeVolume(ResizeVolumeCmd cmd) throws 
ResourceAllocationExcep
 shrinkOk);
 }
 
+/**
+ * A volume should not be resized if it covers ALL the following 
scenarios: 
+ * 1 - Root volume 
+ * 2 - && Current Disk Offering enforces a root disk size (in this case 
one can resize only by changing the Service Offering) 
+ */
+private boolean isNotPossibleToResize(VolumeVO volume, DiskOfferingVO 
diskOffering) {
+ServiceOfferingJoinVO serviceOfferingView = 
serviceOfferingJoinDao.findById(diskOffering.getId());
+return serviceOfferingView.getRootDiskSize() > 0 && 
volume.getVolumeType().equals(Volume.Type.ROOT);

Review comment:
   @GabrielBrascher this gives NPE while resizing volumes of VM deployed 
using ISO,
   ```
   2021-06-11 07:45:54,492 ERROR [c.c.a.ApiAsyncJobDispatcher] 
(API-Job-Executor-15:ctx-d6c38778 job-85) (logid:c6ed7fa6) Unexpected exception 
while executing 
org.apache.cloudstack.api.command.admin.volume.ResizeVolumeCmdByAdmin
   java.lang.NullPointerException
at 
com.cloud.storage.VolumeApiServiceImpl.isNotPossibleToResize(VolumeApiServiceImpl.java:1175)
at 
com.cloud.storage.VolumeApiServiceImpl.resizeVolume(VolumeApiServiceImpl.java:938)
at 
com.cloud.storage.VolumeApiServiceImpl.resizeVolume(VolumeApiServiceImpl.java:194)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at 
org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344)
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198)
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
at 
org.apache.cloudstack.network.contrail.management.EventUtils$EventInterceptor.invoke(EventUtils.java:107)
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:175)
at 
com.cloud.event.ActionEventInterceptor.invoke(ActionEventInterceptor.java:51)
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:175)
at 
org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
at 
org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215)
at com.sun.proxy.$Proxy217.resizeVolume(Unknown Source)
   ```
   Do we need to check serviceOfferingView and not diskOffering itself?

##
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##
@@ -1167,6 +1165,27 @@ public VolumeVO resizeVolume(ResizeVolumeCmd cmd) throws 
ResourceAllocationExcep
 shrinkOk);
 }
 
+/**
+ * A volume should not be resized if it covers ALL the following 
scenarios: 
+ * 1 - Root volume 
+ * 2 - && Current Disk Offering enforces a root disk size (in this case 
one can resize only by changing the Service Offering)
+ */
+protected boolean isNotPossibleToResize(VolumeVO volume, DiskOfferingVO 
diskOffering) {
+Long templateId = volume.getTemplateId();
+ImageFormat format = null;
+if (templateId != null) {
+VMTemplateVO template = _templateDao.findById(templateId);

Review comment:
   @GabrielBrascher is it possible to use findByIdIncludingRemoved else 
will reopen and rebase #5099 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Humbedooh closed pull request #2338: [WIP] CLOUDSTACK-8968: UI icon over VM snapshot to deploy user instance.

2021-06-14 Thread GitBox 


Humbedooh closed pull request #2338:
URL: https://github.com/apache/cloudstack/pull/2338


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #2850: WIP: Vault Integration

2021-06-14 Thread GitBox 


DaanHoogland commented on pull request #2850:
URL: https://github.com/apache/cloudstack/pull/2850#issuecomment-859567136


   @pdion891 there are conflicts and @rhtyd :-1:'d this. nothing else ;)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5095: Failed to scale between Service Offerings with the same root disk size

2021-06-14 Thread GitBox 


blueorangutan commented on pull request #5095:
URL: https://github.com/apache/cloudstack/pull/5095#issuecomment-859260033






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #5037: Updated PowerFlex/ScaleIO gateway client with some improvements.

2021-06-14 Thread GitBox 


sureshanaparti commented on pull request #5037:
URL: https://github.com/apache/cloudstack/pull/5037#issuecomment-859536461






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Pearl1594 commented on pull request #5034: UI: bulk action support for various resources

2021-06-14 Thread GitBox 


Pearl1594 commented on pull request #5034:
URL: https://github.com/apache/cloudstack/pull/5034#issuecomment-859340956


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4819: Remove meaningless password regeneration on resetSSHKeyForVirtualMachine

2021-06-14 Thread GitBox 


rhtyd commented on pull request #4819:
URL: https://github.com/apache/cloudstack/pull/4819#issuecomment-859625456


   By config drive I mean yes cloud-init but enabling config drive by creating 
a new network offering @GutoVeronezi and checking with/without cloud-init if 
the the behaviour with this PR matches expectation on say SSH reset operation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #5083: systemvm with overlayfs

2021-06-14 Thread GitBox 


weizhouapache commented on pull request #5083:
URL: https://github.com/apache/cloudstack/pull/5083#issuecomment-859541566


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #5097: Update chain info of the volumes after migrate operations

2021-06-14 Thread GitBox 


rhtyd commented on pull request #5097:
URL: https://github.com/apache/cloudstack/pull/5097#issuecomment-859626425


   Merging this based on review, manual tests and smoketests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4662: Feat/ram reservation

2021-06-14 Thread GitBox 


blueorangutan commented on pull request #4662:
URL: https://github.com/apache/cloudstack/pull/4662#issuecomment-859583262


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 
:heavy_check_mark: debian. SL-JID 214


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4959: Improve logs on ConsoleProxyManagerImpl and refactor a few process

2021-06-14 Thread GitBox 


blueorangutan commented on pull request #4959:
URL: https://github.com/apache/cloudstack/pull/4959#issuecomment-859890220


   Trillian test result (tid-919)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35467 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4959-t919-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_pvlan.py
   Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
   Smoke tests completed. 87 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_create_pvlan_network | `Error` | 0.03 | test_pvlan.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5080: ui: Show default nic/network in infocard

2021-06-14 Thread GitBox 


DaanHoogland commented on pull request #5080:
URL: https://github.com/apache/cloudstack/pull/5080#issuecomment-859422580


   @GabrielBrascher you are the second lgtm and imply that you tested, any 
reason you didn't merge?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #5095: Failed to scale between Service Offerings with the same root disk size

2021-06-14 Thread GitBox 


rhtyd commented on pull request #5095:
URL: https://github.com/apache/cloudstack/pull/5095#issuecomment-860329875


   @shwstppr @Pearl1594 are we lgtm on it, was it (manually) test for cases? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5024: Health Check PR: 4.15

2021-06-14 Thread GitBox 


blueorangutan commented on pull request #5024:
URL: https://github.com/apache/cloudstack/pull/5024#issuecomment-860448895






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #5024: Health Check PR: 4.15

2021-06-14 Thread GitBox 


rhtyd commented on pull request #5024:
URL: https://github.com/apache/cloudstack/pull/5024#issuecomment-860448101


   @blueorangutan package 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #5078: vxlan: arp does not work between hosts as multicast group is communicated over physical nic instead of linux bridge

2021-06-14 Thread GitBox 


rhtyd commented on pull request #5078:
URL: https://github.com/apache/cloudstack/pull/5078#issuecomment-860330299






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4780: Add SharedMountPoint to KVMs supported storage pool types

2021-06-14 Thread GitBox 


blueorangutan commented on pull request #4780:
URL: https://github.com/apache/cloudstack/pull/4780#issuecomment-859988490


   Trillian test result (tid-920)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 59438 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4780-t920-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 83 look OK, 5 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Error` | 538.65 | 
test_internal_lb.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 280.41 | 
test_internal_lb.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 1041.13 | 
test_privategw_acl.py
   test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3612.99 | 
test_kubernetes_clusters.py
   test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 3607.88 | 
test_kubernetes_clusters.py
   test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.05 | 
test_kubernetes_clusters.py
   test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 0.05 | 
test_kubernetes_clusters.py
   test_05_delete_kubernetes_cluster | `Failure` | 0.05 | 
test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.04 | 
test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | 
test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | 
test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 98.09 | 
test_kubernetes_clusters.py
   test_02_isolate_network_FW_PF_default_routes_egress_false | `Failure` | 
302.18 | test_routers_network_ops.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 525.17 | 
test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
`Failure` | 526.33 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 473.81 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 473.82 | test_vpc_redundant.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd edited a comment on pull request #5078: vxlan: arp does not work between hosts as multicast group is communicated over physical nic instead of linux bridge

2021-06-14 Thread GitBox 


rhtyd edited a comment on pull request #5078:
URL: https://github.com/apache/cloudstack/pull/5078#issuecomment-860330299


   @Pearl1594 @shwstppr has this been tested? (note while testing vxlan based 
env make sure the mtu of host is 40bytes + default mtu, consult with Wei or me 
if that helps). Thanks. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] levindecaro commented on issue #5088: Fail to delete volume left after template removed

2021-06-14 Thread GitBox 


levindecaro commented on issue #5088:
URL: https://github.com/apache/cloudstack/issues/5088#issuecomment-860161349


   @rhtyd 
   
   I restarted ACS management server last night and found the "Destroy" status 
volumes are successfully purged. Afterwards I patch the "Recover->Ready" state 
volume to "Destroy" in DB, and found that it do expunged as well after the 
defined interval. So I do think there maybe stuck thread happening before 
restart, however, I could not found any logs that indicate this situation. I'd 
like to close this issue for now. Thank you for all.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd merged pull request #5095: Failed to scale between Service Offerings with the same root disk size

2021-06-14 Thread GitBox 


rhtyd merged pull request #5095:
URL: https://github.com/apache/cloudstack/pull/5095


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] levindecaro closed issue #5088: Fail to delete volume left after template removed

2021-06-14 Thread GitBox 


levindecaro closed issue #5088:
URL: https://github.com/apache/cloudstack/issues/5088


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on issue #5096: ScaleVMCmd for ingested VMware VMs broken by #4829

2021-06-14 Thread GitBox 


shwstppr commented on issue #5096:
URL: https://github.com/apache/cloudstack/issues/5096#issuecomment-860347195


   @rhtyd yes, with 
https://github.com/apache/cloudstack/pull/5095/commits/c3b412ca862ba6e009ec7cb47b9d73b16aea5791


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd closed issue #5096: ScaleVMCmd for ingested VMware VMs broken by #4829

2021-06-14 Thread GitBox 


rhtyd closed issue #5096:
URL: https://github.com/apache/cloudstack/issues/5096


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on issue #5096: ScaleVMCmd for ingested VMware VMs broken by #4829

2021-06-14 Thread GitBox 


rhtyd commented on issue #5096:
URL: https://github.com/apache/cloudstack/issues/5096#issuecomment-860330063






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #5078: vxlan: arp does not work between hosts as multicast group is communicated over physical nic instead of linux bridge

2021-06-14 Thread GitBox 


weizhouapache commented on pull request #5078:
URL: https://github.com/apache/cloudstack/pull/5078#issuecomment-860501144


   @rhtyd I talked to @Pearl1594 , she can also reproduce the issue that vms in 
other hosts cannot get dhcp IP from VR.
   
   This PR requires the kvm network label to be 'cloudbrX', but in some 
environments the kvm network label is not set (it just "Use default gateway").
   so I think it would be better to fix it in modifyvxlan.sh (in the function 
'addVxlan')
   
https://github.com/apache/cloudstack/blob/main/scripts/vm/network/vnet/modifyvxlan.sh#L47-L63
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4640: Added disk provisioning type support for VMWare

2021-06-14 Thread GitBox 


DaanHoogland commented on a change in pull request #4640:
URL: https://github.com/apache/cloudstack/pull/4640#discussion_r650788060



##
File path: api/src/main/java/org/apache/cloudstack/api/BaseListCmd.java
##
@@ -94,7 +94,7 @@ public Long getPageSizeVal() {
 if (pageSizeInt != null) {
 defaultPageSize = pageSizeInt.longValue();
 }
-if (defaultPageSize.longValue() == s_pageSizeUnlimited) {
+if (defaultPageSize!= null && defaultPageSize.longValue() == 
s_pageSizeUnlimited) {

Review comment:
   ```suggestion
   if (s_pageSizeUnlimited.equals(defaultPageSize) {
   ```
   just being a pain here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #4640: Added disk provisioning type support for VMWare

2021-06-14 Thread GitBox 


Spaceman1984 commented on a change in pull request #4640:
URL: https://github.com/apache/cloudstack/pull/4640#discussion_r650803790



##
File path: api/src/main/java/org/apache/cloudstack/api/BaseListCmd.java
##
@@ -94,7 +94,7 @@ public Long getPageSizeVal() {
 if (pageSizeInt != null) {
 defaultPageSize = pageSizeInt.longValue();
 }
-if (defaultPageSize.longValue() == s_pageSizeUnlimited) {
+if (defaultPageSize!= null && defaultPageSize.longValue() == 
s_pageSizeUnlimited) {

Review comment:
   This is fine Daan, this code came in as part of some unrelated merge.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #4640: Added disk provisioning type support for VMWare

2021-06-14 Thread GitBox 


Spaceman1984 commented on a change in pull request #4640:
URL: https://github.com/apache/cloudstack/pull/4640#discussion_r650803790



##
File path: api/src/main/java/org/apache/cloudstack/api/BaseListCmd.java
##
@@ -94,7 +94,7 @@ public Long getPageSizeVal() {
 if (pageSizeInt != null) {
 defaultPageSize = pageSizeInt.longValue();
 }
-if (defaultPageSize.longValue() == s_pageSizeUnlimited) {
+if (defaultPageSize!= null && defaultPageSize.longValue() == 
s_pageSizeUnlimited) {

Review comment:
   This is fine Daan, this code came in as part of some unrelated merge. 
Not sure if we need something like: 
   
   if(s_pageSizeUnlimited.equals(defaultPageSize.longValue()) {
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #4640: Added disk provisioning type support for VMWare

2021-06-14 Thread GitBox 


Spaceman1984 commented on a change in pull request #4640:
URL: https://github.com/apache/cloudstack/pull/4640#discussion_r650803790



##
File path: api/src/main/java/org/apache/cloudstack/api/BaseListCmd.java
##
@@ -94,7 +94,7 @@ public Long getPageSizeVal() {
 if (pageSizeInt != null) {
 defaultPageSize = pageSizeInt.longValue();
 }
-if (defaultPageSize.longValue() == s_pageSizeUnlimited) {
+if (defaultPageSize!= null && defaultPageSize.longValue() == 
s_pageSizeUnlimited) {

Review comment:
   This is fine Daan, this code came in as part of some unrelated merge. 
Not sure if we need something like: 
   
   if (s_pageSizeUnlimited.equals(defaultPageSize.longValue()) {
   

##
File path: api/src/main/java/org/apache/cloudstack/api/BaseListCmd.java
##
@@ -94,7 +94,7 @@ public Long getPageSizeVal() {
 if (pageSizeInt != null) {
 defaultPageSize = pageSizeInt.longValue();
 }
-if (defaultPageSize.longValue() == s_pageSizeUnlimited) {
+if (defaultPageSize!= null && defaultPageSize.longValue() == 
s_pageSizeUnlimited) {

Review comment:
   This is fine @DaanHoogland, this code came in as part of some unrelated 
merge. Not sure if we need something like: 
   
   if (s_pageSizeUnlimited.equals(defaultPageSize.longValue()) {
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

  1   2   >