[commons-lang] branch master updated: Replace Java 12 and 13 builds with Java 14.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git The following commit(s) were added to refs/heads/master by this push: new 93701c9 Replace Java 12 and 13 builds with Java 14. 93701c9 is described below commit 93701c9ad764e94968d6ae290f935f46b10eb68c Author: pascalschumacher AuthorDate: Sat Mar 21 15:26:48 2020 +0100 Replace Java 12 and 13 builds with Java 14. --- .github/workflows/maven.yml | 2 +- .travis.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml index 7574118..798263d 100644 --- a/.github/workflows/maven.yml +++ b/.github/workflows/maven.yml @@ -23,7 +23,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: -java: [ '1.8', '11.0.4', '12.0.2' ] +java: [ '1.8', '11', '14' ] steps: - uses: actions/checkout@v1 diff --git a/.travis.yml b/.travis.yml index f80bbe8..614d812 100644 --- a/.travis.yml +++ b/.travis.yml @@ -17,7 +17,7 @@ language: java jdk: - openjdk8 - openjdk11 - - openjdk13 + - openjdk14 - openjdk-ea matrix:
[commons-lang] branch master updated: Update Spotbugs Maven Plugin to version 4.0.0.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git The following commit(s) were added to refs/heads/master by this push: new 346f52e Update Spotbugs Maven Plugin to version 4.0.0. 346f52e is described below commit 346f52e2eead9c5ce2d0b76c49c3e6991e5ef050 Author: pascalschumacher AuthorDate: Sat Mar 21 15:23:39 2020 +0100 Update Spotbugs Maven Plugin to version 4.0.0. --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 19472d3..6a56992 100644 --- a/pom.xml +++ b/pom.xml @@ -603,7 +603,7 @@ 8.29 src/site/resources/checkstyle -3.1.12.2 +4.0.0 false
[commons-text] branch master updated: Replace Java 12 and 13 builds with Java 14.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new 700f7db Replace Java 12 and 13 builds with Java 14. 700f7db is described below commit 700f7db01632c667225bee243ba8dc5be5510167 Author: Pascal Schumacher AuthorDate: Sat Mar 21 15:18:39 2020 +0100 Replace Java 12 and 13 builds with Java 14. --- .github/workflows/maven.yml | 2 +- .travis.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml index 7574118..798263d 100644 --- a/.github/workflows/maven.yml +++ b/.github/workflows/maven.yml @@ -23,7 +23,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: -java: [ '1.8', '11.0.4', '12.0.2' ] +java: [ '1.8', '11', '14' ] steps: - uses: actions/checkout@v1 diff --git a/.travis.yml b/.travis.yml index 155fd53..36a99e9 100644 --- a/.travis.yml +++ b/.travis.yml @@ -18,7 +18,7 @@ language: java jdk: - openjdk8 - openjdk11 - - openjdk13 + - openjdk14 - openjdk-ea matrix:
[commons-text] branch master updated: Update Spotbugs Maven Plugin to version 4.0.0.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new 38993c3 Update Spotbugs Maven Plugin to version 4.0.0. 38993c3 is described below commit 38993c3f1652bacb03f6b29e04df5899e4174395 Author: Pascal Schumacher AuthorDate: Sat Mar 21 15:11:48 2020 +0100 Update Spotbugs Maven Plugin to version 4.0.0. --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index e305542..8f356c4 100644 --- a/pom.xml +++ b/pom.xml @@ -50,7 +50,7 @@ 3.1.0 8.27 -3.1.12.2 +4.0.0 0.8.4
[commons-lang] branch master updated (5ac6433 -> b2a0ac7)
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git. from 5ac6433 [LANG-1506] Allow a StopWatch to carry an optional message. new 94b0752 ArrayUtils: Fix checkstyle violation. new b2a0ac7 ArrayUtils: Remove stray comment. The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/main/java/org/apache/commons/lang3/ArrayUtils.java | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-)
[commons-lang] 02/02: ArrayUtils: Remove stray comment.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git commit b2a0ac79b6281e2cf8274548277dbda9a5db6710 Author: pascalschumacher AuthorDate: Mon Dec 30 22:16:26 2019 +0100 ArrayUtils: Remove stray comment. --- src/main/java/org/apache/commons/lang3/ArrayUtils.java | 4 1 file changed, 4 deletions(-) diff --git a/src/main/java/org/apache/commons/lang3/ArrayUtils.java b/src/main/java/org/apache/commons/lang3/ArrayUtils.java index c581389..3cfe46e 100644 --- a/src/main/java/org/apache/commons/lang3/ArrayUtils.java +++ b/src/main/java/org/apache/commons/lang3/ArrayUtils.java @@ -205,10 +205,6 @@ public class ArrayUtils { return newArray; } - -// NOTE: Cannot use {@code} to enclose text which includes {}, but is OK - - /** * Inserts the specified element at the specified position in the array. * Shifts the element currently at that position (if any) and any subsequent
[commons-lang] 01/02: ArrayUtils: Fix checkstyle violation.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git commit 94b0752726efd33f5a20b4240ef09fea52c9624b Author: pascalschumacher AuthorDate: Mon Dec 30 22:14:08 2019 +0100 ArrayUtils: Fix checkstyle violation. --- src/main/java/org/apache/commons/lang3/ArrayUtils.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/apache/commons/lang3/ArrayUtils.java b/src/main/java/org/apache/commons/lang3/ArrayUtils.java index f719644..c581389 100644 --- a/src/main/java/org/apache/commons/lang3/ArrayUtils.java +++ b/src/main/java/org/apache/commons/lang3/ArrayUtils.java @@ -159,14 +159,14 @@ public class ArrayUtils { /** * An empty immutable {@code Throwable} array. - * + * * @since 3.10 */ public static final Throwable[] EMPTY_THROWABLE_ARRAY = new Throwable[0]; /** * An empty immutable {@code Type} array. - * + * * @since 3.10 */ public static final Type[] EMPTY_TYPE_ARRAY = new Type[0];
[commons-lang] branch master updated: Use ArrayUtils#EMPTY_STRING_ARRAY instead of creating new empty String arrays.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git The following commit(s) were added to refs/heads/master by this push: new d5948be Use ArrayUtils#EMPTY_STRING_ARRAY instead of creating new empty String arrays. d5948be is described below commit d5948be13f788fddbf384643ae6fbac6cca87a18 Author: pascalschumacher AuthorDate: Thu Dec 26 23:51:46 2019 +0100 Use ArrayUtils#EMPTY_STRING_ARRAY instead of creating new empty String arrays. --- src/main/java/org/apache/commons/lang3/StringUtils.java| 10 +- .../org/apache/commons/lang3/exception/ExceptionUtils.java | 4 ++-- src/main/java/org/apache/commons/lang3/text/StrTokenizer.java | 4 ++-- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/main/java/org/apache/commons/lang3/StringUtils.java b/src/main/java/org/apache/commons/lang3/StringUtils.java index d629806..44fba32 100644 --- a/src/main/java/org/apache/commons/lang3/StringUtils.java +++ b/src/main/java/org/apache/commons/lang3/StringUtils.java @@ -7507,7 +7507,7 @@ public class StringUtils { currentType = type; } list.add(new String(c, tokenStart, c.length - tokenStart)); -return list.toArray(new String[0]); +return list.toArray(ArrayUtils.EMPTY_STRING_ARRAY); } /** @@ -7735,7 +7735,7 @@ public class StringUtils { } } -return substrings.toArray(new String[0]); +return substrings.toArray(ArrayUtils.EMPTY_STRING_ARRAY); } // --- @@ -7923,7 +7923,7 @@ public class StringUtils { if (match || preserveAllTokens && lastMatch) { list.add(str.substring(start, i)); } -return list.toArray(new String[0]); +return list.toArray(ArrayUtils.EMPTY_STRING_ARRAY); } /** @@ -8022,7 +8022,7 @@ public class StringUtils { if (match || preserveAllTokens && lastMatch) { list.add(str.substring(start, i)); } -return list.toArray(new String[0]); +return list.toArray(ArrayUtils.EMPTY_STRING_ARRAY); } /** @@ -8835,7 +8835,7 @@ public class StringUtils { if (list.isEmpty()) { return null; } -return list.toArray(new String[0]); +return list.toArray(ArrayUtils.EMPTY_STRING_ARRAY); } /** diff --git a/src/main/java/org/apache/commons/lang3/exception/ExceptionUtils.java b/src/main/java/org/apache/commons/lang3/exception/ExceptionUtils.java index dd154e3..6550fd8 100644 --- a/src/main/java/org/apache/commons/lang3/exception/ExceptionUtils.java +++ b/src/main/java/org/apache/commons/lang3/exception/ExceptionUtils.java @@ -274,7 +274,7 @@ public class ExceptionUtils { } frames.addAll(trace); } -return frames.toArray(new String[0]); +return frames.toArray(ArrayUtils.EMPTY_STRING_ARRAY); } /** @@ -325,7 +325,7 @@ public class ExceptionUtils { while (frames.hasMoreTokens()) { list.add(frames.nextToken()); } -return list.toArray(new String[0]); +return list.toArray(ArrayUtils.EMPTY_STRING_ARRAY); } /** diff --git a/src/main/java/org/apache/commons/lang3/text/StrTokenizer.java b/src/main/java/org/apache/commons/lang3/text/StrTokenizer.java index 97fae7d..8a5c33c 100644 --- a/src/main/java/org/apache/commons/lang3/text/StrTokenizer.java +++ b/src/main/java/org/apache/commons/lang3/text/StrTokenizer.java @@ -604,10 +604,10 @@ public class StrTokenizer implements ListIterator, Cloneable { if (chars == null) { // still call tokenize as subclass may do some work final List split = tokenize(null, 0, 0); -tokens = split.toArray(new String[0]); +tokens = split.toArray(ArrayUtils.EMPTY_STRING_ARRAY); } else { final List split = tokenize(chars, 0, chars.length); -tokens = split.toArray(new String[0]); +tokens = split.toArray(ArrayUtils.EMPTY_STRING_ARRAY); } } }
[commons-lang] branch master updated: Use Collection#toArray(new T[0]) instead of a presized array as it is faster on modern JVMs.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git The following commit(s) were added to refs/heads/master by this push: new 84668a2 Use Collection#toArray(new T[0]) instead of a presized array as it is faster on modern JVMs. 84668a2 is described below commit 84668a2d980316a580030fd64764cb072b520b09 Author: pascalschumacher AuthorDate: Thu Dec 26 22:48:12 2019 +0100 Use Collection#toArray(new T[0]) instead of a presized array as it is faster on modern JVMs. --- src/main/java/org/apache/commons/lang3/CharSet.java| 2 +- src/main/java/org/apache/commons/lang3/StringUtils.java| 10 +- .../org/apache/commons/lang3/exception/ExceptionUtils.java | 6 +++--- src/main/java/org/apache/commons/lang3/reflect/FieldUtils.java | 4 ++-- .../java/org/apache/commons/lang3/reflect/MethodUtils.java | 2 +- src/main/java/org/apache/commons/lang3/reflect/TypeUtils.java | 2 +- src/main/java/org/apache/commons/lang3/text/StrTokenizer.java | 4 ++-- .../org/apache/commons/lang3/time/DurationFormatUtils.java | 2 +- .../java/org/apache/commons/lang3/time/FastDatePrinter.java| 2 +- .../commons/lang3/concurrent/EventCountCircuitBreakerTest.java | 2 +- 10 files changed, 18 insertions(+), 18 deletions(-) diff --git a/src/main/java/org/apache/commons/lang3/CharSet.java b/src/main/java/org/apache/commons/lang3/CharSet.java index 3fdfd07..7955115 100644 --- a/src/main/java/org/apache/commons/lang3/CharSet.java +++ b/src/main/java/org/apache/commons/lang3/CharSet.java @@ -225,7 +225,7 @@ public class CharSet implements Serializable { // NOTE: This is no longer public as CharRange is no longer a public class. // It may be replaced when CharSet moves to Range. /*public*/ CharRange[] getCharRanges() { -return set.toArray(new CharRange[set.size()]); +return set.toArray(new CharRange[0]); } //--- diff --git a/src/main/java/org/apache/commons/lang3/StringUtils.java b/src/main/java/org/apache/commons/lang3/StringUtils.java index abde7ec..d629806 100644 --- a/src/main/java/org/apache/commons/lang3/StringUtils.java +++ b/src/main/java/org/apache/commons/lang3/StringUtils.java @@ -7507,7 +7507,7 @@ public class StringUtils { currentType = type; } list.add(new String(c, tokenStart, c.length - tokenStart)); -return list.toArray(new String[list.size()]); +return list.toArray(new String[0]); } /** @@ -7735,7 +7735,7 @@ public class StringUtils { } } -return substrings.toArray(new String[substrings.size()]); +return substrings.toArray(new String[0]); } // --- @@ -7923,7 +7923,7 @@ public class StringUtils { if (match || preserveAllTokens && lastMatch) { list.add(str.substring(start, i)); } -return list.toArray(new String[list.size()]); +return list.toArray(new String[0]); } /** @@ -8022,7 +8022,7 @@ public class StringUtils { if (match || preserveAllTokens && lastMatch) { list.add(str.substring(start, i)); } -return list.toArray(new String[list.size()]); +return list.toArray(new String[0]); } /** @@ -8835,7 +8835,7 @@ public class StringUtils { if (list.isEmpty()) { return null; } -return list.toArray(new String[list.size()]); +return list.toArray(new String[0]); } /** diff --git a/src/main/java/org/apache/commons/lang3/exception/ExceptionUtils.java b/src/main/java/org/apache/commons/lang3/exception/ExceptionUtils.java index 5969614..dd154e3 100644 --- a/src/main/java/org/apache/commons/lang3/exception/ExceptionUtils.java +++ b/src/main/java/org/apache/commons/lang3/exception/ExceptionUtils.java @@ -274,7 +274,7 @@ public class ExceptionUtils { } frames.addAll(trace); } -return frames.toArray(new String[frames.size()]); +return frames.toArray(new String[0]); } /** @@ -325,7 +325,7 @@ public class ExceptionUtils { while (frames.hasMoreTokens()) { list.add(frames.nextToken()); } -return list.toArray(new String[list.size()]); +return list.toArray(new String[0]); } /** @@ -438,7 +438,7 @@ public class ExceptionUtils { */ public static Throwable[] getThrowables(final Throwable throwable) { final List list = getThrowableList(throwable); -return list.toArray(new Throwable[list.size()]); +return list.toArray(new Throwable[0]); } /** diff --git a/src/main/java/org/apache/commons/lang3/reflect/FieldUtils.java
[commons-lang] branch master updated: CompareToBuilder: Fix checkstyle violation.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git The following commit(s) were added to refs/heads/master by this push: new fe44a99 CompareToBuilder: Fix checkstyle violation. fe44a99 is described below commit fe44a99852719ff842ff5ce08b5a37d9b0a0d7fb Author: pascalschumacher AuthorDate: Thu Dec 26 10:25:50 2019 +0100 CompareToBuilder: Fix checkstyle violation. --- src/main/java/org/apache/commons/lang3/builder/CompareToBuilder.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/apache/commons/lang3/builder/CompareToBuilder.java b/src/main/java/org/apache/commons/lang3/builder/CompareToBuilder.java index 03ca984..0988629 100644 --- a/src/main/java/org/apache/commons/lang3/builder/CompareToBuilder.java +++ b/src/main/java/org/apache/commons/lang3/builder/CompareToBuilder.java @@ -285,7 +285,7 @@ public class CompareToBuilder implements Builder { } Objects.requireNonNull(lhs, "lhs"); Objects.requireNonNull(rhs, "rhs"); - + Class lhsClazz = lhs.getClass(); if (!lhsClazz.isInstance(rhs)) { throw new ClassCastException();
[commons-io] branch master updated: Performance Enhancement: Call toArray with Zero Array Size (closes #65)
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-io.git The following commit(s) were added to refs/heads/master by this push: new bcb3604 Performance Enhancement: Call toArray with Zero Array Size (closes #65) bcb3604 is described below commit bcb3604177b7b86d740536138bde8d19e4668cf0 Author: David Georg Reichelt AuthorDate: Wed Oct 10 12:09:03 2018 +0200 Performance Enhancement: Call toArray with Zero Array Size (closes #65) toArray should, at least since Java 7, be used with new T[0] instead of size, since it is "faster, safer, and contractually cleaner" (https://shipilev.net/blog/2016/arrays-wisdom-ancients/#_conclusion) --- src/main/java/org/apache/commons/io/FilenameUtils.java| 4 ++-- .../org/apache/commons/io/comparator/CompositeFileComparator.java | 2 +- src/main/java/org/apache/commons/io/filefilter/FileFilterUtils.java | 4 ++-- src/main/java/org/apache/commons/io/filefilter/NameFileFilter.java| 2 +- src/main/java/org/apache/commons/io/filefilter/PrefixFileFilter.java | 2 +- src/main/java/org/apache/commons/io/filefilter/SuffixFileFilter.java | 2 +- .../java/org/apache/commons/io/filefilter/WildcardFileFilter.java | 2 +- src/main/java/org/apache/commons/io/filefilter/WildcardFilter.java| 2 +- 8 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/main/java/org/apache/commons/io/FilenameUtils.java b/src/main/java/org/apache/commons/io/FilenameUtils.java index cf7c7cf..e77a2db 100644 --- a/src/main/java/org/apache/commons/io/FilenameUtils.java +++ b/src/main/java/org/apache/commons/io/FilenameUtils.java @@ -1494,7 +1494,7 @@ public class FilenameUtils { list.add(buffer.toString()); } -return list.toArray( new String[ list.size() ] ); +return list.toArray( new String[ 0 ] ); } /** @@ -1577,7 +1577,7 @@ public class FilenameUtils { } else if (inet6Address.startsWith("::") && !octetList.isEmpty()) { octetList.remove(0); } -octets = octetList.toArray(new String[octetList.size()]); +octets = octetList.toArray(new String[0]); } if (octets.length > IPV6_MAX_HEX_GROUPS) { return false; diff --git a/src/main/java/org/apache/commons/io/comparator/CompositeFileComparator.java b/src/main/java/org/apache/commons/io/comparator/CompositeFileComparator.java index 7bfaa26..18d3850 100644 --- a/src/main/java/org/apache/commons/io/comparator/CompositeFileComparator.java +++ b/src/main/java/org/apache/commons/io/comparator/CompositeFileComparator.java @@ -76,7 +76,7 @@ public class CompositeFileComparator extends AbstractFileComparator implements S for (final Comparator comparator : delegates) { list.add(comparator); } -this.delegates = (Comparator[]) list.toArray(new Comparator[list.size()]); //2 +this.delegates = (Comparator[]) list.toArray(new Comparator[0]); //2 } } diff --git a/src/main/java/org/apache/commons/io/filefilter/FileFilterUtils.java b/src/main/java/org/apache/commons/io/filefilter/FileFilterUtils.java index 60ffc0e..c654ecd 100644 --- a/src/main/java/org/apache/commons/io/filefilter/FileFilterUtils.java +++ b/src/main/java/org/apache/commons/io/filefilter/FileFilterUtils.java @@ -89,7 +89,7 @@ public class FileFilterUtils { acceptedFiles.add(file); } } -return acceptedFiles.toArray(new File[acceptedFiles.size()]); +return acceptedFiles.toArray(new File[0]); } /** @@ -120,7 +120,7 @@ public class FileFilterUtils { */ public static File[] filter(final IOFileFilter filter, final Iterable files) { final List acceptedFiles = filterList(filter, files); -return acceptedFiles.toArray(new File[acceptedFiles.size()]); +return acceptedFiles.toArray(new File[0]); } /** diff --git a/src/main/java/org/apache/commons/io/filefilter/NameFileFilter.java b/src/main/java/org/apache/commons/io/filefilter/NameFileFilter.java index 8d8bad0..8f5de20 100644 --- a/src/main/java/org/apache/commons/io/filefilter/NameFileFilter.java +++ b/src/main/java/org/apache/commons/io/filefilter/NameFileFilter.java @@ -126,7 +126,7 @@ public class NameFileFilter extends AbstractFileFilter implements Serializable { if (names == null) { throw new IllegalArgumentException("The list of names must not be null"); } -this.names = names.toArray(new String[names.size()]); +this.names = names.toArray(new String[0]); this.caseSensitivity = caseSensitivity == null ? IOCase.SENSITIVE : caseSensitivity; } diff --git a/src/main/java/org/apache/commons/io/filefilter/PrefixFileFilter.ja
[commons-text] branch master updated: AlphabetConverter#decode: Use int instead of Integer for local variable that can never be null.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new a341633 AlphabetConverter#decode: Use int instead of Integer for local variable that can never be null. a341633 is described below commit a341633ac3cac501acef5a944c376285354b2488 Author: Pascal Schumacher AuthorDate: Sun Dec 22 12:55:07 2019 +0100 AlphabetConverter#decode: Use int instead of Integer for local variable that can never be null. --- src/main/java/org/apache/commons/text/AlphabetConverter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/apache/commons/text/AlphabetConverter.java b/src/main/java/org/apache/commons/text/AlphabetConverter.java index b210092..6dd1927 100644 --- a/src/main/java/org/apache/commons/text/AlphabetConverter.java +++ b/src/main/java/org/apache/commons/text/AlphabetConverter.java @@ -161,7 +161,7 @@ public final class AlphabetConverter { final StringBuilder result = new StringBuilder(); for (int j = 0; j < encoded.length();) { -final Integer i = encoded.codePointAt(j); +final int i = encoded.codePointAt(j); final String s = codePointToString(i); if (s.equals(originalToEncoded.get(i))) {
[commons-lang] branch master updated: Conversion#binaryToHexDigit(boolean[], int): Simplify implementation by removing redundant conditions.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git The following commit(s) were added to refs/heads/master by this push: new ff05749 Conversion#binaryToHexDigit(boolean[], int): Simplify implementation by removing redundant conditions. ff05749 is described below commit ff05749cdc68fae72f12fcb6e06d41a4528ea4b6 Author: pascalschumacher AuthorDate: Sun Dec 22 12:42:16 2019 +0100 Conversion#binaryToHexDigit(boolean[], int): Simplify implementation by removing redundant conditions. --- src/main/java/org/apache/commons/lang3/Conversion.java | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/java/org/apache/commons/lang3/Conversion.java b/src/main/java/org/apache/commons/lang3/Conversion.java index de48081..18873d9 100644 --- a/src/main/java/org/apache/commons/lang3/Conversion.java +++ b/src/main/java/org/apache/commons/lang3/Conversion.java @@ -311,19 +311,19 @@ public class Conversion { throw new IllegalArgumentException("Cannot convert an empty array."); } if (src.length > srcPos + 3 && src[srcPos + 3]) { -if (src.length > srcPos + 2 && src[srcPos + 2]) { -if (src.length > srcPos + 1 && src[srcPos + 1]) { +if (src[srcPos + 2]) { +if (src[srcPos + 1]) { return src[srcPos] ? 'f' : 'e'; } return src[srcPos] ? 'd' : 'c'; } -if (src.length > srcPos + 1 && src[srcPos + 1]) { +if (src[srcPos + 1]) { return src[srcPos] ? 'b' : 'a'; } return src[srcPos] ? '9' : '8'; } if (src.length > srcPos + 2 && src[srcPos + 2]) { -if (src.length > srcPos + 1 && src[srcPos + 1]) { +if (src[srcPos + 1]) { return src[srcPos] ? '7' : '6'; } return src[srcPos] ? '5' : '4';
[commons-text] 01/02: UrlStringLookup: Close InputStream even if the InputStreamReader constructor throws an exception.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git commit b7052a259f91e7cc257b7cab26d24dd7f8273fb4 Author: Pascal Schumacher AuthorDate: Fri Dec 20 13:48:12 2019 +0100 UrlStringLookup: Close InputStream even if the InputStreamReader constructor throws an exception. --- src/main/java/org/apache/commons/text/lookup/UrlStringLookup.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/apache/commons/text/lookup/UrlStringLookup.java b/src/main/java/org/apache/commons/text/lookup/UrlStringLookup.java index 1c27736..1d0fb4d 100644 --- a/src/main/java/org/apache/commons/text/lookup/UrlStringLookup.java +++ b/src/main/java/org/apache/commons/text/lookup/UrlStringLookup.java @@ -75,8 +75,8 @@ final class UrlStringLookup extends AbstractStringLookup { final int size = 8192; final StringWriter writer = new StringWriter(size); final char[] buffer = new char[size]; -try (InputStreamReader reader = new InputStreamReader(new BufferedInputStream(url.openStream()), -charsetName)) { +try (BufferedInputStream bis = new BufferedInputStream(url.openStream()); +InputStreamReader reader = new InputStreamReader(bis, charsetName)) { int n; while (-1 != (n = reader.read(buffer))) { writer.write(buffer, 0, n);
[commons-text] branch master updated (a5c2f4d -> 0f58ab2)
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git. from a5c2f4d [TEXT-174] ScriptStringLookup does not accept ":" #126. new b7052a2 UrlStringLookup: Close InputStream even if the InputStreamReader constructor throws an exception. new 0f58ab2 CosineSimilarity#dot: Avoid potential overflow in int multiplication. The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/main/java/org/apache/commons/text/lookup/UrlStringLookup.java | 4 ++-- .../java/org/apache/commons/text/similarity/CosineSimilarity.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
[commons-text] 02/02: CosineSimilarity#dot: Avoid potential overflow in int multiplication.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git commit 0f58ab2b6322e694dcd5c68849b2aad0e30e156b Author: Pascal Schumacher AuthorDate: Fri Dec 20 13:55:52 2019 +0100 CosineSimilarity#dot: Avoid potential overflow in int multiplication. --- src/main/java/org/apache/commons/text/similarity/CosineSimilarity.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/apache/commons/text/similarity/CosineSimilarity.java b/src/main/java/org/apache/commons/text/similarity/CosineSimilarity.java index 7405feb..21550f2 100644 --- a/src/main/java/org/apache/commons/text/similarity/CosineSimilarity.java +++ b/src/main/java/org/apache/commons/text/similarity/CosineSimilarity.java @@ -94,7 +94,7 @@ public class CosineSimilarity { final Set intersection) { long dotProduct = 0; for (final CharSequence key : intersection) { -dotProduct += leftVector.get(key) * rightVector.get(key); +dotProduct += leftVector.get(key) * (long) rightVector.get(key); } return dotProduct; }
[commons-lang] branch master updated (325d9a9 -> c9ca06e)
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git. from 325d9a9 EventListenerSupport: Fix string format of Validate#isTrue call in constructor. new cb2ec37 Replace Character constructor (deprecated on Java 9+) calls in tests with Character#valueOf. new c9ca06e Remove no longer necessary SpotBugs excludes. The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: spotbugs-exclude-filter.xml | 10 -- .../org/apache/commons/lang3/ArrayUtilsTest.java | 18 +- .../java/org/apache/commons/lang3/CharUtilsTest.java | 20 ++-- .../apache/commons/lang3/RandomStringUtilsTest.java | 4 ++-- .../apache/commons/lang3/StringEscapeUtilsTest.java | 4 ++-- 5 files changed, 23 insertions(+), 33 deletions(-)
[commons-lang] 02/02: Remove no longer necessary SpotBugs excludes.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git commit c9ca06e496dee2b22a3753652735c0bca60afc7e Author: pascalschumacher AuthorDate: Fri Dec 20 13:28:20 2019 +0100 Remove no longer necessary SpotBugs excludes. --- spotbugs-exclude-filter.xml | 10 -- 1 file changed, 10 deletions(-) diff --git a/spotbugs-exclude-filter.xml b/spotbugs-exclude-filter.xml index 2dd4c26..f24aa1d 100644 --- a/spotbugs-exclude-filter.xml +++ b/spotbugs-exclude-filter.xml @@ -100,11 +100,6 @@ - - - - - @@ -112,11 +107,6 @@ - - - - -
[commons-lang] 01/02: Replace Character constructor (deprecated on Java 9+) calls in tests with Character#valueOf.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git commit cb2ec37bd393030b58b3aaf3129dcf83c5a0a6c6 Author: pascalschumacher AuthorDate: Fri Dec 20 13:08:50 2019 +0100 Replace Character constructor (deprecated on Java 9+) calls in tests with Character#valueOf. --- .../org/apache/commons/lang3/ArrayUtilsTest.java | 18 +- .../java/org/apache/commons/lang3/CharUtilsTest.java | 20 ++-- .../apache/commons/lang3/RandomStringUtilsTest.java | 4 ++-- .../apache/commons/lang3/StringEscapeUtilsTest.java | 4 ++-- 4 files changed, 23 insertions(+), 23 deletions(-) diff --git a/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java b/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java index 3eb76c5..8dfcbcb 100644 --- a/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java +++ b/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java @@ -4340,11 +4340,11 @@ public class ArrayUtilsTest { assertSame(ArrayUtils.EMPTY_CHAR_ARRAY, ArrayUtils.toPrimitive(new Character[0])); -assertArrayEquals(new char[]{Character.MIN_VALUE, Character.MAX_VALUE, '0'}, ArrayUtils.toPrimitive(new Character[]{new Character(Character.MIN_VALUE), -new Character(Character.MAX_VALUE), new Character('0')})); +assertArrayEquals(new char[]{Character.MIN_VALUE, Character.MAX_VALUE, '0'}, ArrayUtils.toPrimitive(new Character[]{Character.valueOf(Character.MIN_VALUE), +Character.valueOf(Character.MAX_VALUE), Character.valueOf('0')})); assertThrows(NullPointerException.class, -() -> ArrayUtils.toPrimitive(new Character[]{new Character(Character.MIN_VALUE), null})); +() -> ArrayUtils.toPrimitive(new Character[]{Character.valueOf(Character.MIN_VALUE), null})); } @Test @@ -4355,12 +4355,12 @@ public class ArrayUtilsTest { assertSame(ArrayUtils.EMPTY_CHAR_ARRAY, ArrayUtils.toPrimitive(new Character[0], (char) 0)); -assertArrayEquals(new char[]{Character.MIN_VALUE, Character.MAX_VALUE, '0'}, ArrayUtils.toPrimitive(new Character[]{new Character(Character.MIN_VALUE), -new Character(Character.MAX_VALUE), new Character('0')}, +assertArrayEquals(new char[]{Character.MIN_VALUE, Character.MAX_VALUE, '0'}, ArrayUtils.toPrimitive(new Character[]{Character.valueOf(Character.MIN_VALUE), +Character.valueOf(Character.MAX_VALUE), Character.valueOf('0')}, Character.MIN_VALUE)); -assertArrayEquals(new char[]{Character.MIN_VALUE, Character.MAX_VALUE, '0'}, ArrayUtils.toPrimitive(new Character[]{new Character(Character.MIN_VALUE), null, -new Character('0')}, Character.MAX_VALUE)); +assertArrayEquals(new char[]{Character.MIN_VALUE, Character.MAX_VALUE, '0'}, ArrayUtils.toPrimitive(new Character[]{Character.valueOf(Character.MIN_VALUE), null, +Character.valueOf('0')}, Character.MAX_VALUE)); } @Test @@ -4371,8 +4371,8 @@ public class ArrayUtilsTest { assertSame(ArrayUtils.EMPTY_CHARACTER_OBJECT_ARRAY, ArrayUtils.toObject(new char[0])); -assertArrayEquals(new Character[]{new Character(Character.MIN_VALUE), -new Character(Character.MAX_VALUE), new Character('0')}, ArrayUtils.toObject(new char[]{Character.MIN_VALUE, Character.MAX_VALUE, +assertArrayEquals(new Character[]{Character.valueOf(Character.MIN_VALUE), +Character.valueOf(Character.MAX_VALUE), Character.valueOf('0')}, ArrayUtils.toObject(new char[]{Character.MIN_VALUE, Character.MAX_VALUE, '0'})); } diff --git a/src/test/java/org/apache/commons/lang3/CharUtilsTest.java b/src/test/java/org/apache/commons/lang3/CharUtilsTest.java index d4ba3e6..ae6be1c 100644 --- a/src/test/java/org/apache/commons/lang3/CharUtilsTest.java +++ b/src/test/java/org/apache/commons/lang3/CharUtilsTest.java @@ -36,8 +36,8 @@ import org.junit.jupiter.api.Test; public class CharUtilsTest { private static final char CHAR_COPY = '\u00a9'; -private static final Character CHARACTER_A = new Character('A'); -private static final Character CHARACTER_B = new Character('B'); +private static final Character CHARACTER_A = Character.valueOf('A'); +private static final Character CHARACTER_B = Character.valueOf('B'); @Test public void testCompare() { @@ -229,7 +229,7 @@ public class CharUtilsTest { @SuppressWarnings("deprecation") // intentional test of deprecated method @Test publ
[commons-lang] branch master updated: EventListenerSupport: Fix string format of Validate#isTrue call in constructor.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git The following commit(s) were added to refs/heads/master by this push: new 325d9a9 EventListenerSupport: Fix string format of Validate#isTrue call in constructor. 325d9a9 is described below commit 325d9a97d6265722c747f02bcc7b21b2bd6757a0 Author: pascalschumacher AuthorDate: Fri Dec 20 12:45:22 2019 +0100 EventListenerSupport: Fix string format of Validate#isTrue call in constructor. --- src/main/java/org/apache/commons/lang3/event/EventListenerSupport.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/apache/commons/lang3/event/EventListenerSupport.java b/src/main/java/org/apache/commons/lang3/event/EventListenerSupport.java index 42fc68d..1813375 100644 --- a/src/main/java/org/apache/commons/lang3/event/EventListenerSupport.java +++ b/src/main/java/org/apache/commons/lang3/event/EventListenerSupport.java @@ -142,7 +142,7 @@ public class EventListenerSupport implements Serializable { this(); Validate.notNull(listenerInterface, "Listener interface cannot be null."); Validate.notNull(classLoader, "ClassLoader cannot be null."); -Validate.isTrue(listenerInterface.isInterface(), "Class {0} is not an interface", +Validate.isTrue(listenerInterface.isInterface(), "Class %s is not an interface", listenerInterface.getName()); initializeTransientFields(listenerInterface, classLoader); }
[commons-io] branch master updated: Travis CI: Drop Java 12 build (Java 13 is now Generally Available).
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-io.git The following commit(s) were added to refs/heads/master by this push: new 2539fc9 Travis CI: Drop Java 12 build (Java 13 is now Generally Available). 2539fc9 is described below commit 2539fc97dd8db3c30681578fa4e099286e64243a Author: pascalschumacher AuthorDate: Fri Sep 20 10:19:47 2019 +0200 Travis CI: Drop Java 12 build (Java 13 is now Generally Available). --- .travis.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 6fe63c1..3759820 100644 --- a/.travis.yml +++ b/.travis.yml @@ -19,7 +19,6 @@ sudo: false jdk: - openjdk8 - openjdk11 - - openjdk12 - openjdk13 - openjdk-ea - oraclejdk11
[commons-text] branch master updated: Travis CI: Drop Java 12 build (Java 13 is now Generally Available).
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new 9879038 Travis CI: Drop Java 12 build (Java 13 is now Generally Available). 9879038 is described below commit 987903895be2084661d07124ab67daa91b816f4e Author: Pascal Schumacher AuthorDate: Fri Sep 20 10:17:00 2019 +0200 Travis CI: Drop Java 12 build (Java 13 is now Generally Available). --- .travis.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 1e3de86..155fd53 100644 --- a/.travis.yml +++ b/.travis.yml @@ -18,7 +18,6 @@ language: java jdk: - openjdk8 - openjdk11 - - openjdk12 - openjdk13 - openjdk-ea
[commons-lang] branch master updated: Travis CI: Drop Java 12 build (Java 13 is now Generally Available).
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git The following commit(s) were added to refs/heads/master by this push: new 46b381e Travis CI: Drop Java 12 build (Java 13 is now Generally Available). 46b381e is described below commit 46b381eb4bd5b77b7322e73e7076957c2956860e Author: pascalschumacher AuthorDate: Fri Sep 20 10:15:56 2019 +0200 Travis CI: Drop Java 12 build (Java 13 is now Generally Available). --- .travis.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 09ef4cf..f80bbe8 100644 --- a/.travis.yml +++ b/.travis.yml @@ -17,7 +17,6 @@ language: java jdk: - openjdk8 - openjdk11 - - openjdk12 - openjdk13 - openjdk-ea
[commons-collections] branch master updated: Travis CI: Allow builds on openjdk-ea to fail.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-collections.git The following commit(s) were added to refs/heads/master by this push: new b29bae0 Travis CI: Allow builds on openjdk-ea to fail. b29bae0 is described below commit b29bae05ae39d4a960a0b4748e0a87cbfe3ddc88 Author: Pascal Schumacher AuthorDate: Fri Sep 13 10:22:48 2019 +0200 Travis CI: Allow builds on openjdk-ea to fail. --- .travis.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.travis.yml b/.travis.yml index 088466d..d62800a 100644 --- a/.travis.yml +++ b/.travis.yml @@ -20,6 +20,8 @@ matrix: include: - os: linux-ppc64le jdk: openjdk8 + allow_failures: +- jdk: openjdk-ea jdk: - oraclejdk11 - openjdk8
[commons-text] branch master updated: Fix checkstyle violation.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new d81eb76 Fix checkstyle violation. d81eb76 is described below commit d81eb76f68d6797236ec7e95b37abf0bcc96b697 Author: Pascal Schumacher AuthorDate: Fri Sep 13 10:10:20 2019 +0200 Fix checkstyle violation. --- .../commons/text/similarity/ParameterizedSimilarityScoreFromTest.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/test/java/org/apache/commons/text/similarity/ParameterizedSimilarityScoreFromTest.java b/src/test/java/org/apache/commons/text/similarity/ParameterizedSimilarityScoreFromTest.java index 2017097..ab19711 100644 --- a/src/test/java/org/apache/commons/text/similarity/ParameterizedSimilarityScoreFromTest.java +++ b/src/test/java/org/apache/commons/text/similarity/ParameterizedSimilarityScoreFromTest.java @@ -38,7 +38,8 @@ public class ParameterizedSimilarityScoreFromTest { Arguments.of(new LevenshteinDistance(), "hippo", "", 8), Arguments.of( -(SimilarityScore) (left, right) -> left == right || (left != null && left.equals(right)), +(SimilarityScore) (left, right) -> left == right +|| (left != null && left.equals(right)), "Bob's your uncle.", "Every good boy does fine.", false
[commons-text] branch master updated: Do not run spotbugs twice on Travis CI. Spotbugs is already executed in the main build, do not run it again in the "after_success" part.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new b3bffa2 Do not run spotbugs twice on Travis CI. Spotbugs is already executed in the main build, do not run it again in the "after_success" part. b3bffa2 is described below commit b3bffa2b832d5a91a6ec5df1b8f42382cc6c421f Author: Pascal Schumacher AuthorDate: Thu Sep 12 09:21:58 2019 +0200 Do not run spotbugs twice on Travis CI. Spotbugs is already executed in the main build, do not run it again in the "after_success" part. --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index c419c93..1e3de86 100644 --- a/.travis.yml +++ b/.travis.yml @@ -30,4 +30,4 @@ script: - mvn after_success: - - mvn clean test spotbugs:check jacoco:report coveralls:report -Ptravis-jacoco + - mvn clean test jacoco:report coveralls:report -Ptravis-jacoco
[commons-lang] branch master updated: Update spotbugs-maven-plugin to version 3.1.12.2.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git The following commit(s) were added to refs/heads/master by this push: new 4632ad7 Update spotbugs-maven-plugin to version 3.1.12.2. 4632ad7 is described below commit 4632ad7c7cd72228b21d5692662a2f02fd4ca779 Author: pascalschumacher AuthorDate: Sat Aug 31 12:06:29 2019 +0200 Update spotbugs-maven-plugin to version 3.1.12.2. --- pom.xml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index e9727c6..e4d683e 100644 --- a/pom.xml +++ b/pom.xml @@ -602,7 +602,7 @@ 3.0.0 8.23 -3.1.11 +3.1.12.2 false @@ -915,8 +915,6 @@ true - -true
[commons-text] branch master updated: Update spotbugs-maven-plugin to version 3.1.12.2.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new d66f426 Update spotbugs-maven-plugin to version 3.1.12.2. d66f426 is described below commit d66f426793bd87edfbce6837237e91ee3f1c0ebb Author: Pascal Schumacher AuthorDate: Sat Aug 31 11:59:43 2019 +0200 Update spotbugs-maven-plugin to version 3.1.12.2. --- pom.xml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index 582335e..6cddfaa 100644 --- a/pom.xml +++ b/pom.xml @@ -50,7 +50,7 @@ 3.0.0 8.23 -3.1.12 +3.1.12.2 0.8.4 @@ -446,8 +446,6 @@ true - -true
[commons-lang] branch master updated: Range: Remove trailing spaces.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git The following commit(s) were added to refs/heads/master by this push: new b27f6d5 Range: Remove trailing spaces. b27f6d5 is described below commit b27f6d5c1c46c8b0f92c0f262b2989efae18c47e Author: pascalschumacher AuthorDate: Tue Aug 20 07:44:24 2019 +0200 Range: Remove trailing spaces. --- src/main/java/org/apache/commons/lang3/Range.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/apache/commons/lang3/Range.java b/src/main/java/org/apache/commons/lang3/Range.java index b96d367..cbf521d 100644 --- a/src/main/java/org/apache/commons/lang3/Range.java +++ b/src/main/java/org/apache/commons/lang3/Range.java @@ -26,8 +26,8 @@ import java.util.Comparator; * or you need to supply a {@code Comparator}. * * #ThreadSafe# if the objects and comparator are thread-safe - * - * @param The type of range values. + * + * @param The type of range values. * @since 3.0 */ public final class Range implements Serializable {
[commons-text] branch master updated: [TEXT-170] Add String lookup for host names and IP addresses
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new 420ae4f [TEXT-170] Add String lookup for host names and IP addresses 420ae4f is described below commit 420ae4ff04e307d7e82e1db3d5779f153158171d Author: Pascal Schumacher AuthorDate: Sun Aug 4 18:21:45 2019 +0200 [TEXT-170] Add String lookup for host names and IP addresses Fix checkstyle violations. --- src/main/java/org/apache/commons/text/lookup/StringLookupFactory.java | 3 ++- src/test/java/org/apache/commons/text/lookup/DnsStringLookupTest.java | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/apache/commons/text/lookup/StringLookupFactory.java b/src/main/java/org/apache/commons/text/lookup/StringLookupFactory.java index b548503..89b6cb2 100644 --- a/src/main/java/org/apache/commons/text/lookup/StringLookupFactory.java +++ b/src/main/java/org/apache/commons/text/lookup/StringLookupFactory.java @@ -599,7 +599,8 @@ public final class StringLookupFactory { * StringSubstitutor.createInterpolator().replace("... ${java:version} ...")); * * - * The above examples convert {@code "version"} to the current VM version, for example, {@code "Java version 1.8.0_181"}. + * The above examples convert {@code "version"} to the current VM version, for example, + * {@code "Java version 1.8.0_181"}. * * * @return The JavaPlatformStringLookup singleton instance. diff --git a/src/test/java/org/apache/commons/text/lookup/DnsStringLookupTest.java b/src/test/java/org/apache/commons/text/lookup/DnsStringLookupTest.java index fd0e7c0..e3af1ab 100644 --- a/src/test/java/org/apache/commons/text/lookup/DnsStringLookupTest.java +++ b/src/test/java/org/apache/commons/text/lookup/DnsStringLookupTest.java @@ -62,8 +62,9 @@ public class DnsStringLookupTest { final InetAddress[] localHostAll = InetAddress.getAllByName(address); boolean matched = false; for (InetAddress localHost : localHostAll) { -if (localHost.getHostName().equals(DnsStringLookup.INSTANCE.lookup("name|" + address + ""))) +if (localHost.getHostName().equals(DnsStringLookup.INSTANCE.lookup("name|" + address + ""))) { matched = true; +} } Assertions.assertTrue(matched); }
[commons-text] branch master updated: Travis: Allow Java EA builds to fail.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new 79df911 Travis: Allow Java EA builds to fail. 79df911 is described below commit 79df911f038bc701e52d650a54bff355e91bcd53 Author: Pascal Schumacher AuthorDate: Sun Aug 4 12:37:25 2019 +0200 Travis: Allow Java EA builds to fail. --- .travis.yml | 4 1 file changed, 4 insertions(+) diff --git a/.travis.yml b/.travis.yml index 9811140..1e3de86 100644 --- a/.travis.yml +++ b/.travis.yml @@ -22,6 +22,10 @@ jdk: - openjdk13 - openjdk-ea +matrix: + allow_failures: +- jdk: openjdk-ea + script: - mvn
[commons-text] 02/02: Update AssertJ to version 3.13.2.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git commit 9137054229635e9607a6e62588e0368b78e2c820 Author: Pascal Schumacher AuthorDate: Sun Aug 4 12:06:58 2019 +0200 Update AssertJ to version 3.13.2. --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 14b7f30..7b77ab9 100644 --- a/pom.xml +++ b/pom.xml @@ -86,7 +86,7 @@ org.assertj assertj-core - 3.13.0 + 3.13.2 test
[commons-text] 01/02: StringSubstitutorWithInterpolatorStringLookupTest: Fix checkstyle violation.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git commit 9f4fdf0738dee332e691b06b56bbd73fad8ba22d Author: Pascal Schumacher AuthorDate: Sun Aug 4 12:06:02 2019 +0200 StringSubstitutorWithInterpolatorStringLookupTest: Fix checkstyle violation. --- .../commons/text/StringSubstitutorWithInterpolatorStringLookupTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/org/apache/commons/text/StringSubstitutorWithInterpolatorStringLookupTest.java b/src/test/java/org/apache/commons/text/StringSubstitutorWithInterpolatorStringLookupTest.java index 6d52816..e70e953 100644 --- a/src/test/java/org/apache/commons/text/StringSubstitutorWithInterpolatorStringLookupTest.java +++ b/src/test/java/org/apache/commons/text/StringSubstitutorWithInterpolatorStringLookupTest.java @@ -107,7 +107,7 @@ public class StringSubstitutorWithInterpolatorStringLookupTest { Assertions.assertEquals("7", StringSubstitutor.createInterpolator().replace("${script:javascript:3 + 4}")); } - + @Test public void testSystemProperty() { final StringSubstitutor strSubst = StringSubstitutor.createInterpolator();
[commons-text] branch master updated (df619a4 -> 9137054)
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git. from df619a4 - Add missing documentation. - Fix incorrect examples in Javadocs. - Expand Javadocs. - Add test. new 9f4fdf0 StringSubstitutorWithInterpolatorStringLookupTest: Fix checkstyle violation. new 9137054 Update AssertJ to version 3.13.2. The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: pom.xml | 2 +- .../commons/text/StringSubstitutorWithInterpolatorStringLookupTest.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
[commons-io] branch master updated: Change part of "Fix "unexpected heading" Javadoc errors on Java 13+." so that it also works version before Java 13.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-io.git The following commit(s) were added to refs/heads/master by this push: new 1de4a96 Change part of "Fix "unexpected heading" Javadoc errors on Java 13+." so that it also works version before Java 13. 1de4a96 is described below commit 1de4a966ce72393f86b409725371da074697ab8a Author: pascalschumacher AuthorDate: Fri Aug 2 16:57:09 2019 +0200 Change part of "Fix "unexpected heading" Javadoc errors on Java 13+." so that it also works version before Java 13. --- src/main/java/org/apache/commons/io/FileUtils.java | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/java/org/apache/commons/io/FileUtils.java b/src/main/java/org/apache/commons/io/FileUtils.java index cc804ca..6e175e6 100644 --- a/src/main/java/org/apache/commons/io/FileUtils.java +++ b/src/main/java/org/apache/commons/io/FileUtils.java @@ -1309,13 +1309,13 @@ public class FileUtils { * it is not guaranteed that those operations will succeed. * If the modification operation fails, no indication is provided. * - * Example: Copy directories only + * Example: Copy directories only * * // only copy the directory structure * FileUtils.copyDirectory(srcDir, destDir, DirectoryFileFilter.DIRECTORY); * * - * Example: Copy directories and txt files + * Example: Copy directories and txt files * * // Create a filter for ".txt" files * IOFileFilter txtSuffixFilter = FileFilterUtils.suffixFileFilter(".txt"); @@ -1361,13 +1361,13 @@ public class FileUtils { * not guaranteed that those operations will succeed. * If the modification operation fails, no indication is provided. * - * Example: Copy directories only + * Example: Copy directories only * * // only copy the directory structure * FileUtils.copyDirectory(srcDir, destDir, DirectoryFileFilter.DIRECTORY, false); * * - * Example: Copy directories and txt files + * Example: Copy directories and txt files * * // Create a filter for ".txt" files * IOFileFilter txtSuffixFilter = FileFilterUtils.suffixFileFilter(".txt");
[commons-io] branch master updated: Fix "unexpected heading" Javadoc errors on Java 13+.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-io.git The following commit(s) were added to refs/heads/master by this push: new 27fbd9e Fix "unexpected heading" Javadoc errors on Java 13+. 27fbd9e is described below commit 27fbd9e3a383ea3899714e743c34742607b0b73a Author: Pascal Schumacher AuthorDate: Fri Aug 2 16:40:42 2019 +0200 Fix "unexpected heading" Javadoc errors on Java 13+. --- src/main/java/org/apache/commons/io/DirectoryWalker.java | 10 +- src/main/java/org/apache/commons/io/FileUtils.java| 8 src/main/java/org/apache/commons/io/comparator/package.html | 6 +++--- src/main/java/org/apache/commons/io/input/BOMInputStream.java | 6 +++--- src/main/java/org/apache/commons/io/monitor/FileEntry.java| 2 +- 5 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/main/java/org/apache/commons/io/DirectoryWalker.java b/src/main/java/org/apache/commons/io/DirectoryWalker.java index b04a204..24f2885 100644 --- a/src/main/java/org/apache/commons/io/DirectoryWalker.java +++ b/src/main/java/org/apache/commons/io/DirectoryWalker.java @@ -46,7 +46,7 @@ import org.apache.commons.io.filefilter.TrueFileFilter; * behaviour. * * - * 1. Example Implementation + * 1. Example Implementation * * There are many possible extensions, for example, to delete all * files and '.svn' directories, and return a list of deleted files: @@ -82,7 +82,7 @@ import org.apache.commons.io.filefilter.TrueFileFilter; * } * * - * 2. Filter Example + * 2. Filter Example * * * Choosing which directories and files to process can be a key aspect @@ -157,7 +157,7 @@ import org.apache.commons.io.filefilter.TrueFileFilter; * option for filtering. * * - * 3. Cancellation + * 3. Cancellation * * * The DirectoryWalker contains some of the logic required for cancel processing. @@ -195,7 +195,7 @@ import org.apache.commons.io.filefilter.TrueFileFilter; * scenarios. * * - * 3.1 External / Multi-threaded + * 3.1 External / Multi-threaded * * * This example provides a public cancel() method that can be @@ -228,7 +228,7 @@ import org.apache.commons.io.filefilter.TrueFileFilter; * } * * - * 3.2 Internal + * 3.2 Internal * * * This shows an example of how internal cancellation processing could be implemented. diff --git a/src/main/java/org/apache/commons/io/FileUtils.java b/src/main/java/org/apache/commons/io/FileUtils.java index efc1a64..cc804ca 100644 --- a/src/main/java/org/apache/commons/io/FileUtils.java +++ b/src/main/java/org/apache/commons/io/FileUtils.java @@ -1309,13 +1309,13 @@ public class FileUtils { * it is not guaranteed that those operations will succeed. * If the modification operation fails, no indication is provided. * - * Example: Copy directories only + * Example: Copy directories only * * // only copy the directory structure * FileUtils.copyDirectory(srcDir, destDir, DirectoryFileFilter.DIRECTORY); * * - * Example: Copy directories and txt files + * Example: Copy directories and txt files * * // Create a filter for ".txt" files * IOFileFilter txtSuffixFilter = FileFilterUtils.suffixFileFilter(".txt"); @@ -1361,13 +1361,13 @@ public class FileUtils { * not guaranteed that those operations will succeed. * If the modification operation fails, no indication is provided. * - * Example: Copy directories only + * Example: Copy directories only * * // only copy the directory structure * FileUtils.copyDirectory(srcDir, destDir, DirectoryFileFilter.DIRECTORY, false); * * - * Example: Copy directories and txt files + * Example: Copy directories and txt files * * // Create a filter for ".txt" files * IOFileFilter txtSuffixFilter = FileFilterUtils.suffixFileFilter(".txt"); diff --git a/src/main/java/org/apache/commons/io/comparator/package.html b/src/main/java/org/apache/commons/io/comparator/package.html index fa66bb0..bd2d239 100644 --- a/src/main/java/org/apache/commons/io/comparator/package.html +++ b/src/main/java/org/apache/commons/io/comparator/package.html @@ -20,7 +20,7 @@ limitations under the License. This package provides various {@link java.util.Comparator} implementations for {@link java.io.File}s. -Sorting +Sorting All the compartors include convenience utility sort(File...) and sort(List) methods. @@ -39,7 +39,7 @@ for {@link java.io.File}s. File[] files = NameFileComparator.NAME_COMPARATOR.sort(dir.listFiles()); -Composite Comparator +Composite Comparator The CompositeFileComparator can be used to compare (and sort lists or arrays of files) by combining a
[commons-text] branch master updated: Update AssertJ to version 3.13.0 and JUnit to version 5.5.1.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new 4e8197f Update AssertJ to version 3.13.0 and JUnit to version 5.5.1. 4e8197f is described below commit 4e8197fc4f293a0d86103f4da98631080befdb21 Author: Pascal Schumacher AuthorDate: Sun Jul 28 10:46:33 2019 +0200 Update AssertJ to version 3.13.0 and JUnit to version 5.5.1. --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index c47dab7..14b7f30 100644 --- a/pom.xml +++ b/pom.xml @@ -80,13 +80,13 @@ org.junit.jupiter junit-jupiter - 5.5.0 + 5.5.1 test org.assertj assertj-core - 3.12.2 + 3.13.0 test
[commons-text] branch master updated: Fix checkstyle violations in StringSubstitutor#createInterpolator.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new b299b1c Fix checkstyle violations in StringSubstitutor#createInterpolator. b299b1c is described below commit b299b1cac6ffccb7613178e5311995e779a4091a Author: Pascal Schumacher AuthorDate: Sat Jul 27 11:45:07 2019 +0200 Fix checkstyle violations in StringSubstitutor#createInterpolator. --- src/main/java/org/apache/commons/text/StringSubstitutor.java | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/apache/commons/text/StringSubstitutor.java b/src/main/java/org/apache/commons/text/StringSubstitutor.java index fa33d61..6764fe6 100644 --- a/src/main/java/org/apache/commons/text/StringSubstitutor.java +++ b/src/main/java/org/apache/commons/text/StringSubstitutor.java @@ -182,8 +182,9 @@ public class StringSubstitutor { StringMatcherFactory.INSTANCE.stringMatcher(DEFAULT_VAR_DEFAULT); /** - * Creates a new instance using the interpolator string lookup {@link StringLookupFactory#interpolatorStringLookup()}. - * + * Creates a new instance using the interpolator string lookup + * {@link StringLookupFactory#interpolatorStringLookup()}. + * * @return a new instance using the interpolator string lookup. * @see StringLookupFactory#interpolatorStringLookup() * @since 1.8 @@ -191,7 +192,7 @@ public class StringSubstitutor { public static StringSubstitutor createInterpolator() { return new StringSubstitutor(StringLookupFactory.INSTANCE.interpolatorStringLookup()); } - + /** * Replaces all the occurrences of variables in the given source object with their matching values from the map. *
[commons-lang] branch master updated: Update JaCoCo to version 0.8.4.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git The following commit(s) were added to refs/heads/master by this push: new 326f869 Update JaCoCo to version 0.8.4. 326f869 is described below commit 326f86925d32f17af7e02cd81916c97a9e63dcf9 Author: pascalschumacher AuthorDate: Wed Jul 3 23:00:38 2019 +0200 Update JaCoCo to version 0.8.4. --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 8f2f6b4..dac91cb 100644 --- a/pom.xml +++ b/pom.xml @@ -606,7 +606,7 @@ 1.21 benchmarks -0.8.3 +0.8.4 3.0.0-M3 3.1.0
[commons-lang] 02/02: Add Java 13 build on Travis CI (openjdk-ea is now Java 14).
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git commit 456f92cc9b6cea3e8dac43a44780845e145d06b2 Author: pascalschumacher AuthorDate: Mon Jul 1 22:45:08 2019 +0200 Add Java 13 build on Travis CI (openjdk-ea is now Java 14). --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index bc8f156..1e3de86 100644 --- a/.travis.yml +++ b/.travis.yml @@ -19,6 +19,7 @@ jdk: - openjdk8 - openjdk11 - openjdk12 + - openjdk13 - openjdk-ea matrix:
[commons-lang] 01/02: Skip Jacoco and SpotBugs on Java 13+.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git commit f810c8283783650f3a000f8ab9aa7911b2b77ab4 Author: pascalschumacher AuthorDate: Mon Jul 1 22:44:40 2019 +0200 Skip Jacoco and SpotBugs on Java 13+. --- pom.xml | 12 1 file changed, 12 insertions(+) diff --git a/pom.xml b/pom.xml index 6ba59df..8f2f6b4 100644 --- a/pom.xml +++ b/pom.xml @@ -904,6 +904,18 @@ true + + java13+ + +[13,) + + + +true + +true + + benchmark
[commons-lang] branch master updated (9fd7ad2 -> 456f92c)
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git. from 9fd7ad2 Oracle JDK 8 and 11 are no longer available on travis. new f810c82 Skip Jacoco and SpotBugs on Java 13+. new 456f92c Add Java 13 build on Travis CI (openjdk-ea is now Java 14). The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .travis.yml | 1 + pom.xml | 12 2 files changed, 13 insertions(+)
[commons-lang] branch master updated: Oracle JDK 8 and 11 are no longer available on travis.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git The following commit(s) were added to refs/heads/master by this push: new 9fd7ad2 Oracle JDK 8 and 11 are no longer available on travis. 9fd7ad2 is described below commit 9fd7ad2d5b2e86988fadd38eea9889b39857dfe8 Author: pascalschumacher AuthorDate: Sun Jun 30 23:35:40 2019 +0200 Oracle JDK 8 and 11 are no longer available on travis. --- .travis.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index cff0180..bc8f156 100644 --- a/.travis.yml +++ b/.travis.yml @@ -16,8 +16,6 @@ language: java jdk: - - oraclejdk8 - - oraclejdk11 - openjdk8 - openjdk11 - openjdk12
[commons-lang] branch master updated: Update JUnit to version 5.5.0.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git The following commit(s) were added to refs/heads/master by this push: new 88f1d70 Update JUnit to version 5.5.0. 88f1d70 is described below commit 88f1d70c36e3fed812d8c54b46e6fa0ca20a7824 Author: pascalschumacher AuthorDate: Sun Jun 30 23:22:59 2019 +0200 Update JUnit to version 5.5.0. --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 5857196..6ba59df 100644 --- a/pom.xml +++ b/pom.xml @@ -513,7 +513,7 @@ org.junit.jupiter junit-jupiter - 5.4.2 + 5.5.0 test
[commons-text] branch master updated: Update JUnit to version 5.5.0.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new e36fe49 Update JUnit to version 5.5.0. e36fe49 is described below commit e36fe490ab196ee64debad96b4f4d7e3c78200df Author: Pascal Schumacher AuthorDate: Sun Jun 30 22:45:25 2019 +0200 Update JUnit to version 5.5.0. --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index fc9e2dd..965d909 100644 --- a/pom.xml +++ b/pom.xml @@ -81,7 +81,7 @@ org.junit.jupiter junit-jupiter - 5.4.2 + 5.5.0 test
[commons-text] branch master updated: Update JaCoCo to version 0.8.4.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new ab92f2b Update JaCoCo to version 0.8.4. ab92f2b is described below commit ab92f2b6930113b7bb808f5a13994212d6fb72a0 Author: Pascal Schumacher AuthorDate: Sun Jun 30 16:14:00 2019 +0200 Update JaCoCo to version 0.8.4. --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index fda5b9f..fc9e2dd 100644 --- a/pom.xml +++ b/pom.xml @@ -52,7 +52,7 @@ 3.1.12 -0.8.2 +0.8.4 3.1.0
[commons-text] branch master updated: Fix checkstyle violations.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new b94b583 Fix checkstyle violations. b94b583 is described below commit b94b583ead8e5404990bbbd5f6950aaea60d6f16 Author: Pascal Schumacher AuthorDate: Sun Jun 30 16:07:41 2019 +0200 Fix checkstyle violations. --- src/test/java/org/apache/commons/text/StrBuilderTest.java| 6 +++--- src/test/java/org/apache/commons/text/TextStringBuilderTest.java | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/test/java/org/apache/commons/text/StrBuilderTest.java b/src/test/java/org/apache/commons/text/StrBuilderTest.java index ea813cb..a5ae720 100644 --- a/src/test/java/org/apache/commons/text/StrBuilderTest.java +++ b/src/test/java/org/apache/commons/text/StrBuilderTest.java @@ -1721,15 +1721,15 @@ public class StrBuilderTest { @Test public void testAsWriter() throws Exception { final StrBuilder sb = new StrBuilder("base"); -try (final Writer writer = sb.asWriter()) { +try (Writer writer = sb.asWriter()) { writer.write('l'); assertEquals("basel", sb.toString()); -writer.write(new char[] { 'i', 'n' }); +writer.write(new char[] {'i', 'n'}); assertEquals("baselin", sb.toString()); -writer.write(new char[] { 'n', 'e', 'r' }, 1, 2); +writer.write(new char[] {'n', 'e', 'r'}, 1, 2); assertEquals("baseliner", sb.toString()); writer.write(" rout"); diff --git a/src/test/java/org/apache/commons/text/TextStringBuilderTest.java b/src/test/java/org/apache/commons/text/TextStringBuilderTest.java index ec58c8f..ae89d55 100644 --- a/src/test/java/org/apache/commons/text/TextStringBuilderTest.java +++ b/src/test/java/org/apache/commons/text/TextStringBuilderTest.java @@ -1722,15 +1722,15 @@ public class TextStringBuilderTest { @Test public void testAsWriter() throws Exception { final TextStringBuilder sb = new TextStringBuilder("base"); -try (final Writer writer = sb.asWriter()) { +try (Writer writer = sb.asWriter()) { writer.write('l'); assertEquals("basel", sb.toString()); -writer.write(new char[] { 'i', 'n' }); +writer.write(new char[] {'i', 'n'}); assertEquals("baselin", sb.toString()); -writer.write(new char[] { 'n', 'e', 'r' }, 1, 2); +writer.write(new char[] {'n', 'e', 'r'}, 1, 2); assertEquals("baseliner", sb.toString()); writer.write(" rout");
[commons-text] branch master updated: Update spotbugs-maven-plugin to version 3.1.12 (closes #116).
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new e234077 Update spotbugs-maven-plugin to version 3.1.12 (closes #116). e234077 is described below commit e23407720918061fb8c1d30833ff31ea8ea37ffd Author: Pascal Schumacher AuthorDate: Sun Jun 30 11:58:19 2019 +0200 Update spotbugs-maven-plugin to version 3.1.12 (closes #116). --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 250ef11..fda5b9f 100644 --- a/pom.xml +++ b/pom.xml @@ -50,7 +50,7 @@ 3.0.0 8.21 -3.1.10 +3.1.12 0.8.2
[commons-text] branch master updated: Oracle JDK 8 and 11 are no longer available on travis.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new b7666a2 Oracle JDK 8 and 11 are no longer available on travis. b7666a2 is described below commit b7666a298eb87d5060b88391327f037b92c123c9 Author: Pascal Schumacher AuthorDate: Sun Jun 30 12:01:42 2019 +0200 Oracle JDK 8 and 11 are no longer available on travis. --- .travis.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 32678ea..9811140 100644 --- a/.travis.yml +++ b/.travis.yml @@ -16,8 +16,6 @@ language: java jdk: - - oraclejdk8 - - oraclejdk11 - openjdk8 - openjdk11 - openjdk12
[commons-text] branch master updated: Add Java 13 build on Travis CI (openjdk-ea is now Java 14).
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new 276f258 Add Java 13 build on Travis CI (openjdk-ea is now Java 14). 276f258 is described below commit 276f2581663442c9a42dbc5948cc49905c13893b Author: Pascal Schumacher AuthorDate: Sun Jun 30 11:54:02 2019 +0200 Add Java 13 build on Travis CI (openjdk-ea is now Java 14). --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index 7d1ccce..32678ea 100644 --- a/.travis.yml +++ b/.travis.yml @@ -21,6 +21,7 @@ jdk: - openjdk8 - openjdk11 - openjdk12 + - openjdk13 - openjdk-ea script:
[commons-text] branch master updated: Fix checkstyle violations
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new 8b07e17 Fix checkstyle violations 8b07e17 is described below commit 8b07e17402a7ca148aa6442c1c1e25a2f700c713 Author: Pascal Schumacher AuthorDate: Wed May 29 00:49:36 2019 +0200 Fix checkstyle violations --- src/test/java/org/apache/commons/text/FormattableUtilsTest.java | 6 -- .../text/StringSubstitutorWithInterpolatorStringLookupTest.java | 2 +- .../apache/commons/text/similarity/IntersectionSimilarityTest.java | 4 ++-- .../org/apache/commons/text/translate/CodePointTranslatorTest.java | 6 ++ 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/test/java/org/apache/commons/text/FormattableUtilsTest.java b/src/test/java/org/apache/commons/text/FormattableUtilsTest.java index db14eda..6f5c2c3 100644 --- a/src/test/java/org/apache/commons/text/FormattableUtilsTest.java +++ b/src/test/java/org/apache/commons/text/FormattableUtilsTest.java @@ -56,7 +56,8 @@ public class FormattableUtilsTest { assertThat(FormattableUtils.append("foo", createFormatter(), 0, 3, 2).toString()).isEqualTo(" fo"); assertThat(FormattableUtils.append("foo", createFormatter(), 0, 5, 2).toString()).isEqualTo(" fo"); assertThat(FormattableUtils.append("foo", createFormatter(), LEFT_JUSTIFY, 4, -1).toString()).isEqualTo("foo "); -assertThat(FormattableUtils.append("foo", createFormatter(), LEFT_JUSTIFY, 6, -1).toString()).isEqualTo("foo "); +assertThat(FormattableUtils.append("foo", createFormatter(), LEFT_JUSTIFY, 6, -1).toString()) +.isEqualTo("foo "); assertThat(FormattableUtils.append("foo", createFormatter(), LEFT_JUSTIFY, 3, 2).toString()).isEqualTo("fo "); assertThat(FormattableUtils.append("foo", createFormatter(), LEFT_JUSTIFY, 5, 2).toString()).isEqualTo("fo "); } @@ -125,7 +126,8 @@ public class FormattableUtilsTest { assertThat(FormattableUtils.append("foo", createFormatter(), 0, -1, -1, '_', "*").toString()).isEqualTo("foo"); assertThat(FormattableUtils.append("foo", createFormatter(), 0, -1, 2, '_', "*").toString()).isEqualTo("f*"); assertThat(FormattableUtils.append("foo", createFormatter(), 0, 4, -1, '_', "*").toString()).isEqualTo("_foo"); -assertThat(FormattableUtils.append("foo", createFormatter(), 0, 6, -1, '_', "*").toString()).isEqualTo("___foo"); +assertThat(FormattableUtils.append("foo", createFormatter(), 0, 6, -1, '_', "*").toString()) +.isEqualTo("___foo"); assertThat(FormattableUtils.append("foo", createFormatter(), 0, 3, 2, '_', "*").toString()).isEqualTo("_f*"); assertThat(FormattableUtils.append("foo", createFormatter(), 0, 5, 2, '_', "*").toString()).isEqualTo("___f*"); assertThat(FormattableUtils.append("foo", createFormatter(), LEFT_JUSTIFY, 4, -1, '_', "*").toString()) diff --git a/src/test/java/org/apache/commons/text/StringSubstitutorWithInterpolatorStringLookupTest.java b/src/test/java/org/apache/commons/text/StringSubstitutorWithInterpolatorStringLookupTest.java index 9213e51..ec592fb 100644 --- a/src/test/java/org/apache/commons/text/StringSubstitutorWithInterpolatorStringLookupTest.java +++ b/src/test/java/org/apache/commons/text/StringSubstitutorWithInterpolatorStringLookupTest.java @@ -102,7 +102,7 @@ public class StringSubstitutorWithInterpolatorStringLookupTest { Assertions.assertEquals(System.getProperty(spKey), strSubst.replace("${sys:" + spKey + "}")); Assertions.assertEquals(value, strSubst.replace("${" + key + "}")); } - + @Test public void testSystemProperty() { final StringSubstitutor strSubst = new StringSubstitutor( diff --git a/src/test/java/org/apache/commons/text/similarity/IntersectionSimilarityTest.java b/src/test/java/org/apache/commons/text/similarity/IntersectionSimilarityTest.java index 0f891db..8b4364c 100644 --- a/src/test/java/org/apache/commons/text/similarity/IntersectionSimilarityTest.java +++ b/src/test/java/org/apache/commons/text/similarity/IntersectionSimilarityTest.java @@ -229,8 +229,8 @@ public class IntersectionSimilarityTest { return list; } -private static void assertIntersection(final Intersec
[commons-text] branch master updated: Fix Javadoc error on Java 13.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new da897bb Fix Javadoc error on Java 13. da897bb is described below commit da897bbf9a78ceeebd583e0622809d53759682dd Author: Pascal Schumacher AuthorDate: Wed May 22 08:11:43 2019 +0200 Fix Javadoc error on Java 13. --- src/main/java/org/apache/commons/text/AlphabetConverter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/apache/commons/text/AlphabetConverter.java b/src/main/java/org/apache/commons/text/AlphabetConverter.java index 8cc1af6..9449904 100644 --- a/src/main/java/org/apache/commons/text/AlphabetConverter.java +++ b/src/main/java/org/apache/commons/text/AlphabetConverter.java @@ -45,7 +45,7 @@ import java.util.Set; * chars, which will be of length 1 * * - * Sample usage + * Sample usage * * * Character[] originals; // a, b, c, d
[commons-text] branch master updated: Fix Javadoc error on Java 13.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new 6a6faa4 Fix Javadoc error on Java 13. 6a6faa4 is described below commit 6a6faa4154600309b6eaaa5f13a07fd0a0b6872d Author: Pascal Schumacher AuthorDate: Tue May 21 23:22:29 2019 +0200 Fix Javadoc error on Java 13. --- src/main/java/org/apache/commons/text/AlphabetConverter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/apache/commons/text/AlphabetConverter.java b/src/main/java/org/apache/commons/text/AlphabetConverter.java index e122739..8cc1af6 100644 --- a/src/main/java/org/apache/commons/text/AlphabetConverter.java +++ b/src/main/java/org/apache/commons/text/AlphabetConverter.java @@ -45,7 +45,7 @@ import java.util.Set; * chars, which will be of length 1 * * - * Sample usage + * Sample usage * * * Character[] originals; // a, b, c, d
[commons-lang] branch master updated: Fix Javadoc on Java 11+.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git The following commit(s) were added to refs/heads/master by this push: new 999030a Fix Javadoc on Java 11+. 999030a is described below commit 999030a23c214a1fdcfc2f1464183e0c752777f5 Author: pascalschumacher AuthorDate: Tue May 21 22:04:36 2019 +0200 Fix Javadoc on Java 11+. --- pom.xml | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/pom.xml b/pom.xml index 2010bba..5857196 100644 --- a/pom.xml +++ b/pom.xml @@ -608,6 +608,7 @@ 0.8.3 3.0.0-M3 +3.1.0 false @@ -653,8 +654,8 @@ maven-javadoc-plugin -${commons.javadoc.version} + ${maven.compiler.source} true utf-8 utf-8 @@ -905,19 +906,6 @@ - java11+ - -[11,) - - - -true - - - - benchmark true
[commons-text] branch master updated: Fix Javadoc on Java 11+.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new 547f651 Fix Javadoc on Java 11+. 547f651 is described below commit 547f6519c41164455f093a8eaba1db9c671cc661 Author: Pascal Schumacher AuthorDate: Tue May 21 21:55:06 2019 +0200 Fix Javadoc on Java 11+. --- pom.xml | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/pom.xml b/pom.xml index 9d177ec..506fe50 100644 --- a/pom.xml +++ b/pom.xml @@ -54,6 +54,8 @@ 0.8.2 +3.1.0 + false @@ -181,6 +183,13 @@ + +org.apache.maven.plugins +maven-javadoc-plugin + + ${maven.compiler.source} + + @@ -431,18 +440,6 @@ - java11+ - -[11,) - - - -true - - - java13+ [13,)
[commons-lang] branch master updated: Skip javadoc on Java 12+ to workaround https://bugs.openjdk.java.net/browse/JDK-8212233 which causes javadoc to fail with "Exit code: 1 - javadoc: error - The cod
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git The following commit(s) were added to refs/heads/master by this push: new 58dfe55 Skip javadoc on Java 12+ to workaround https://bugs.openjdk.java.net/browse/JDK-8212233 which causes javadoc to fail with "Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/7/docs/api/ are in the unnamed module." 58dfe55 is described below commit 58dfe5517d188e1daf20e507624fd851a87e9ba5 Author: pascalschumacher AuthorDate: Sat Apr 27 10:19:11 2019 +0200 Skip javadoc on Java 12+ to workaround https://bugs.openjdk.java.net/browse/JDK-8212233 which causes javadoc to fail with "Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/7/docs/api/ are in the unnamed module." --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index e8518ed..410e11c 100644 --- a/pom.xml +++ b/pom.xml @@ -905,9 +905,9 @@ - java11 + java11+ -11 +[11,)
[commons-text] branch master updated: Update AssertJ to version 3.12.0.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new e7a0979 Update AssertJ to version 3.12.0. e7a0979 is described below commit e7a097968a0dc310d96564358b9e626935a9ea7d Author: Pascal Schumacher AuthorDate: Sun Feb 24 11:16:15 2019 +0100 Update AssertJ to version 3.12.0. --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 78b3a57..9cba628 100644 --- a/pom.xml +++ b/pom.xml @@ -85,7 +85,7 @@ org.assertj assertj-core - 3.11.1 + 3.12.0 test
[commons-text] branch master updated: Do not enable checkstyle modules which results are always suppressed.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new c62b177 Do not enable checkstyle modules which results are always suppressed. c62b177 is described below commit c62b177c7e649729b42794d79c57bd504b17ce8c Author: Pascal Schumacher AuthorDate: Sun Feb 24 11:11:59 2019 +0100 Do not enable checkstyle modules which results are always suppressed. --- checkstyle-suppressions.xml | 6 -- checkstyle.xml | 6 -- 2 files changed, 12 deletions(-) diff --git a/checkstyle-suppressions.xml b/checkstyle-suppressions.xml index dcc57fe..2d6e4b1 100644 --- a/checkstyle-suppressions.xml +++ b/checkstyle-suppressions.xml @@ -19,12 +19,6 @@ limitations under the License. --> - - - - - - diff --git a/checkstyle.xml b/checkstyle.xml index de7dad0..c72d854 100644 --- a/checkstyle.xml +++ b/checkstyle.xml @@ -176,10 +176,8 @@ - - @@ -189,17 +187,13 @@ - - - -
[commons-text] branch master updated: Remove unnecessary checkstyle suppression.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new 0f8ee16 Remove unnecessary checkstyle suppression. 0f8ee16 is described below commit 0f8ee163cb53a1772206383ab835098a22122f0b Author: Pascal Schumacher AuthorDate: Sun Feb 24 10:56:30 2019 +0100 Remove unnecessary checkstyle suppression. --- checkstyle-suppressions.xml | 1 - 1 file changed, 1 deletion(-) diff --git a/checkstyle-suppressions.xml b/checkstyle-suppressions.xml index a50d7c5..dcc57fe 100644 --- a/checkstyle-suppressions.xml +++ b/checkstyle-suppressions.xml @@ -25,7 +25,6 @@ -
[commons-text] branch master updated (56c060d -> 512f1a9)
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git. from 56c060d Merge pull request #102 from kinow/deprecate-jaro-winkler-for-20 new 9e414e3 TEXT-104: deprecate JaroWinkler methods for 2.0, and fix clirr report new 512f1a9 checkstyle-suppressions.xml: Remove unnecessary 'lines="0-9"' attributes The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: checkstyle-suppressions.xml | 48 +++-- 1 file changed, 25 insertions(+), 23 deletions(-)
[commons-text] 02/02: checkstyle-suppressions.xml: Remove unnecessary 'lines="0-99999"' attributes
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git commit 512f1a9b4b1cdd53fa4adacf4367608734284c54 Author: Pascal Schumacher AuthorDate: Sun Feb 24 10:44:48 2019 +0100 checkstyle-suppressions.xml: Remove unnecessary 'lines="0-9"' attributes --- checkstyle-suppressions.xml | 46 ++--- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/checkstyle-suppressions.xml b/checkstyle-suppressions.xml index 9ee7fbe..a50d7c5 100644 --- a/checkstyle-suppressions.xml +++ b/checkstyle-suppressions.xml @@ -19,35 +19,35 @@ limitations under the License. --> - - - - - - - - - - - + + + + + + + + + + + - - - - - - - - - - + + + + + + + + + + - + - +
[commons-text] 01/02: TEXT-104: deprecate JaroWinkler methods for 2.0, and fix clirr report
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git commit 9e414e3b1004d47647ce33468132520e793e9774 Author: Pascal Schumacher AuthorDate: Sun Feb 24 10:28:35 2019 +0100 TEXT-104: deprecate JaroWinkler methods for 2.0, and fix clirr report Suppress checkstyle errors for TODO comments and magic numbers in JaroWinklerSimilarity (as done for JaroWinklerDistance). --- checkstyle-suppressions.xml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/checkstyle-suppressions.xml b/checkstyle-suppressions.xml index d93989a..9ee7fbe 100644 --- a/checkstyle-suppressions.xml +++ b/checkstyle-suppressions.xml @@ -30,6 +30,7 @@ + @@ -51,4 +52,5 @@ +
[commons-text] branch master updated: Update checkstyle to version 8.17
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new 4ca1e32 Update checkstyle to version 8.17 4ca1e32 is described below commit 4ca1e3266db4b24c4a5a54bed5d4d181d5f6d380 Author: Pascal Schumacher AuthorDate: Sat Feb 9 14:13:40 2019 +0100 Update checkstyle to version 8.17 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 06b96c0..78b3a57 100644 --- a/pom.xml +++ b/pom.xml @@ -48,7 +48,7 @@ site-content 3.0.0 -8.14 +8.17 3.1.10
[commons-lang] branch master updated: Update checkstyle to version 8.17
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git The following commit(s) were added to refs/heads/master by this push: new 508ddd1 Update checkstyle to version 8.17 508ddd1 is described below commit 508ddd1295975474ee18ba651e6b902ae5c2459d Author: pascalschumacher AuthorDate: Sat Feb 9 13:54:01 2019 +0100 Update checkstyle to version 8.17 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 63f53de..c588346 100644 --- a/pom.xml +++ b/pom.xml @@ -597,7 +597,7 @@ utf-8 3.0.0 -8.13 +8.17 3.1.10 false
[commons-lang] 01/02: Update Hamcrest to version 2.1
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git commit b5ed6c6180fd331743cd925b8ca0aeda7a082ffb Author: pascalschumacher AuthorDate: Sat Feb 9 13:43:15 2019 +0100 Update Hamcrest to version 2.1 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 15c7bfc..ea8481d 100644 --- a/pom.xml +++ b/pom.xml @@ -524,8 +524,8 @@ org.hamcrest - hamcrest-all - 1.3 + hamcrest + 2.1 test
[commons-lang] 02/02: Update EasyMock to version 4.0.2
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git commit c127a7266a7633722a5a7b8a5294bc98b1b1a101 Author: pascalschumacher AuthorDate: Sat Feb 9 13:46:58 2019 +0100 Update EasyMock to version 4.0.2 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index ea8481d..63f53de 100644 --- a/pom.xml +++ b/pom.xml @@ -532,7 +532,7 @@ org.easymock easymock - 4.0 + 4.0.2 test
[commons-lang] branch master updated (c6bb13c -> c127a72)
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git. from c6bb13c Remove dependency management for JUnit (since the update to JUnit 5.4.0 we only have a single JUnit test dependency). new b5ed6c6 Update Hamcrest to version 2.1 new c127a72 Update EasyMock to version 4.0.2 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: pom.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
[commons-lang] branch master updated: Remove dependency management for JUnit (since the update to JUnit 5.4.0 we only have a single JUnit test dependency).
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git The following commit(s) were added to refs/heads/master by this push: new c6bb13c Remove dependency management for JUnit (since the update to JUnit 5.4.0 we only have a single JUnit test dependency). c6bb13c is described below commit c6bb13cb9997c50f2b5158f481a8f5fa19679c3f Author: pascalschumacher AuthorDate: Sat Feb 9 13:31:34 2019 +0100 Remove dependency management for JUnit (since the update to JUnit 5.4.0 we only have a single JUnit test dependency). --- pom.xml | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/pom.xml b/pom.xml index 7a4954e..15c7bfc 100644 --- a/pom.xml +++ b/pom.xml @@ -507,24 +507,13 @@ - - - -org.junit -junit-bom -${junit.version} -pom -import - - - - org.junit.jupiter junit-jupiter + 5.4.0 test @@ -617,8 +606,6 @@ 1.21 benchmarks -5.4.0 - 0.8.2
[commons-lang] 01/02: Use assertThrows in FunctionsTest (closes #404)
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git commit a4adb41259d1318212833eb6379e1528d859b434 Author: Allon Mureinik AuthorDate: Fri Feb 8 21:36:33 2019 +0200 Use assertThrows in FunctionsTest (closes #404) Use JUnit Jupiter's elegant assertThrows method instead of the boilerplate pattern of try-fail-catch to assert an exception was thrown. --- .../org/apache/commons/lang3/FunctionsTest.java| 185 - 1 file changed, 67 insertions(+), 118 deletions(-) diff --git a/src/test/java/org/apache/commons/lang3/FunctionsTest.java b/src/test/java/org/apache/commons/lang3/FunctionsTest.java index 77c67f4..0808b80 100644 --- a/src/test/java/org/apache/commons/lang3/FunctionsTest.java +++ b/src/test/java/org/apache/commons/lang3/FunctionsTest.java @@ -26,8 +26,8 @@ import org.junit.jupiter.api.Test; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertNotNull; import static org.junit.jupiter.api.Assertions.assertSame; +import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertTrue; -import static org.junit.jupiter.api.Assertions.fail; class FunctionsTest { public static class SomeException extends Exception { @@ -117,30 +117,24 @@ class FunctionsTest { @Test void testRunnable() { FailureOnOddInvocations.invocation = 0; -try { -Functions.run(FailureOnOddInvocations::new); -fail("Expected Exception"); -} catch (UndeclaredThrowableException e) { -final Throwable cause = e.getCause(); -assertNotNull(cause); -assertTrue(cause instanceof SomeException); -assertEquals("Odd Invocation: 1", cause.getMessage()); -} +UndeclaredThrowableException e = assertThrows(UndeclaredThrowableException.class, () -> Functions.run(FailureOnOddInvocations::new)); +final Throwable cause = e.getCause(); +assertNotNull(cause); +assertTrue(cause instanceof SomeException); +assertEquals("Odd Invocation: 1", cause.getMessage()); + +// Even invocation, should not throw an exception Functions.run(FailureOnOddInvocations::new); } @Test void testCallable() { FailureOnOddInvocations.invocation = 0; -try { -Functions.call(FailureOnOddInvocations::new); -fail("Expected Exception"); -} catch (UndeclaredThrowableException e) { -final Throwable cause = e.getCause(); -assertNotNull(cause); -assertTrue(cause instanceof SomeException); -assertEquals("Odd Invocation: 1", cause.getMessage()); -} +UndeclaredThrowableException e = assertThrows(UndeclaredThrowableException.class, () -> Functions.run(FailureOnOddInvocations::new)); +final Throwable cause = e.getCause(); +assertNotNull(cause); +assertTrue(cause instanceof SomeException); +assertEquals("Odd Invocation: 1", cause.getMessage()); final FailureOnOddInvocations instance = Functions.call(FailureOnOddInvocations::new); assertNotNull(instance); } @@ -149,30 +143,21 @@ class FunctionsTest { void testAcceptConsumer() { final IllegalStateException ise = new IllegalStateException(); final Testable testable = new Testable(ise); -try { -Functions.accept(Testable::test, testable); -fail("Expected Exception"); -} catch (IllegalStateException e) { -assertSame(ise, e); -} +Throwable e = assertThrows(IllegalStateException.class, () -> Functions.accept(Testable::test, testable)); +assertSame(ise, e); + final Error error = new OutOfMemoryError(); testable.setThrowable(error); -try { -Functions.accept(Testable::test, testable); -} catch (OutOfMemoryError e) { -assertSame(error, e); -} +e = assertThrows(OutOfMemoryError.class, () -> Functions.accept(Testable::test, testable)); +assertSame(error, e); + final IOException ioe = new IOException("Unknown I/O error"); testable.setThrowable(ioe); -try { -Functions.accept(Testable::test, testable); -fail("Expected Exception"); -} catch (UncheckedIOException e) { -final Throwable t = e.getCause(); -assertNotNull(t); -assertTrue(t instanceof IOException); -assertSame(ioe, t); -} +e = assertThrows(UncheckedIOException.class, () -> Functions.accept(Testable::test, testable)); +final Throwable t
[commons-lang] branch master updated (6b7a848 -> c01fa9a)
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git. from 6b7a848 [ToStringBuilderTest] clean up after some old issues new a4adb41 Use assertThrows in FunctionsTest (closes #404) new c01fa9a Simplify assertions (closes #404) The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../apache/commons/lang3/ArrayUtilsAddTest.java| 256 ++--- .../lang3/ArrayUtilsRemoveMultipleTest.java| 407 ++--- .../apache/commons/lang3/ArrayUtilsRemoveTest.java | 238 ++-- .../org/apache/commons/lang3/ArrayUtilsTest.java | 274 +- .../org/apache/commons/lang3/CharRangeTest.java| 14 +- .../org/apache/commons/lang3/ClassUtilsTest.java | 19 +- .../org/apache/commons/lang3/FunctionsTest.java| 185 -- .../org/apache/commons/lang3/ObjectUtilsTest.java | 3 +- .../java/org/apache/commons/lang3/RangeTest.java | 2 +- .../org/apache/commons/lang3/StringUtilsTest.java | 18 +- .../commons/lang3/builder/EqualsBuilderTest.java | 10 +- .../apache/commons/lang3/math/NumberUtilsTest.java | 86 ++--- .../commons/lang3/mutable/MutableBooleanTest.java | 2 +- .../commons/lang3/mutable/MutableByteTest.java | 3 +- .../commons/lang3/mutable/MutableDoubleTest.java | 3 +- .../commons/lang3/mutable/MutableFloatTest.java| 3 +- .../commons/lang3/mutable/MutableIntTest.java | 3 +- .../commons/lang3/mutable/MutableLongTest.java | 3 +- .../commons/lang3/mutable/MutableObjectTest.java | 39 +- .../commons/lang3/mutable/MutableShortTest.java| 3 +- .../lang3/reflect/ConstructorUtilsTest.java| 4 +- .../commons/lang3/reflect/MethodUtilsTest.java | 3 +- .../lang3/text/ExtendedMessageFormatTest.java | 5 +- .../apache/commons/lang3/text/StrBuilderTest.java | 20 +- .../org/apache/commons/lang3/tuple/PairTest.java | 3 +- 25 files changed, 708 insertions(+), 898 deletions(-)
[commons-text] branch master updated: Skip Javadoc on Java 11+ to workaround https://bugs.openjdk.java.net/browse/JDK-8212233 which causes Javadoc to fail with "Exit code: 1 - javadoc: error - The cod
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new a348c98 Skip Javadoc on Java 11+ to workaround https://bugs.openjdk.java.net/browse/JDK-8212233 which causes Javadoc to fail with "Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/8/docs/api/ are in the unnamed module." a348c98 is described below commit a348c9871d1aedfddda1d8bb0dfc3b420d040a83 Author: Pascal Schumacher AuthorDate: Fri Feb 8 20:27:36 2019 +0100 Skip Javadoc on Java 11+ to workaround https://bugs.openjdk.java.net/browse/JDK-8212233 which causes Javadoc to fail with "Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/8/docs/api/ are in the unnamed module." --- pom.xml | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index 1896c17..06b96c0 100644 --- a/pom.xml +++ b/pom.xml @@ -431,12 +431,14 @@ - java12+ + java11+ -[12,) +[11,) - + true
[commons-text] branch master updated: Update JUnit to version 5.4.0
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new a2735fe Update JUnit to version 5.4.0 a2735fe is described below commit a2735feae60791ca16ec1171f006588cacc25b4f Author: Pascal Schumacher AuthorDate: Fri Feb 8 20:10:50 2019 +0100 Update JUnit to version 5.4.0 --- pom.xml | 27 ++- 1 file changed, 2 insertions(+), 25 deletions(-) diff --git a/pom.xml b/pom.xml index 1c9ef29..1896c17 100644 --- a/pom.xml +++ b/pom.xml @@ -47,8 +47,6 @@ https://svn.apache.org/repos/infra/websites/production/commons/content/proper/commons-text site-content -5.3.1 - 3.0.0 8.14 @@ -71,18 +69,6 @@ B6E73D84EA4FCC47166087253FAAD2CD5ECBB314 - - - - org.junit - junit-bom - ${junit.version} - pom - import - - - - org.apache.commons @@ -92,17 +78,8 @@ org.junit.jupiter - junit-jupiter-engine - test - - - org.junit.jupiter - junit-jupiter-params - test - - - org.junit.platform - junit-platform-launcher + junit-jupiter + 5.4.0 test
[commons-lang] branch master updated (17bbe77 -> bfa50b3)
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git. from 17bbe77 Skip javadoc on Java 11 to workaround https://bugs.openjdk.java.net/browse/JDK-8212233 which causes javadoc to fail with "Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/7/docs/api/ are in the unnamed module." new 2273b6e Upgrade JUnit depedency to 5.4.0 (closes #402) new bfa50b3 Clean up floating point assertions (closes #402) The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: pom.xml| 14 +- .../org/apache/commons/lang3/ArrayUtilsTest.java | 348 + .../org/apache/commons/lang3/ObjectUtilsTest.java | 11 +- .../apache/commons/lang3/math/NumberUtilsTest.java | 36 +-- .../commons/lang3/mutable/MutableByteTest.java | 9 +- .../commons/lang3/mutable/MutableDoubleTest.java | 8 +- .../commons/lang3/mutable/MutableIntTest.java | 9 +- .../commons/lang3/mutable/MutableLongTest.java | 9 +- .../commons/lang3/mutable/MutableShortTest.java| 9 +- 9 files changed, 178 insertions(+), 275 deletions(-)
[commons-lang] 01/02: Upgrade JUnit depedency to 5.4.0 (closes #402)
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git commit 2273b6e44e75ab2f9946acfc961b7c0657c5066f Author: Allon Mureinik AuthorDate: Fri Feb 8 15:28:02 2019 +0200 Upgrade JUnit depedency to 5.4.0 (closes #402) Upgrade the JUnit dependency to the latest available 5.4.0. Note that JUnit simplified its artifacts, and now it contains a single, simple org.junit:junit-jupiter artifact. --- pom.xml | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/pom.xml b/pom.xml index ce7e595..7a4954e 100644 --- a/pom.xml +++ b/pom.xml @@ -524,17 +524,7 @@ org.junit.jupiter - junit-jupiter-api - test - - - org.junit.jupiter - junit-jupiter-params - test - - - org.junit.jupiter - junit-jupiter-engine + junit-jupiter test @@ -627,7 +617,7 @@ 1.21 benchmarks -5.3.2 +5.4.0 0.8.2
[commons-lang] 02/02: Clean up floating point assertions (closes #402)
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git commit bfa50b3edf09aa41363eeae28b4abe3b86f2e261 Author: Allon Mureinik AuthorDate: Fri Feb 8 16:21:11 2019 +0200 Clean up floating point assertions (closes #402) JUnit Jupiter 5.4.0 supports deltas of 0 when asserting double and float equalities. This patch utilizes these new assertEquals methods and removes the hack of using assertTrue with an == statement that was needed in older JUnit versions. --- .../org/apache/commons/lang3/ArrayUtilsTest.java | 348 + .../org/apache/commons/lang3/ObjectUtilsTest.java | 11 +- .../apache/commons/lang3/math/NumberUtilsTest.java | 36 +-- .../commons/lang3/mutable/MutableByteTest.java | 9 +- .../commons/lang3/mutable/MutableDoubleTest.java | 8 +- .../commons/lang3/mutable/MutableIntTest.java | 9 +- .../commons/lang3/mutable/MutableLongTest.java | 9 +- .../commons/lang3/mutable/MutableShortTest.java| 9 +- 8 files changed, 176 insertions(+), 263 deletions(-) diff --git a/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java b/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java index 7d83ed0..3348a1b 100644 --- a/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java +++ b/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java @@ -1498,14 +1498,11 @@ public class ArrayUtilsTest { @Test public void testReverseDouble() { -// TODO: JUnit Jupiter 5.3.1 doesn't support delta=0. -// This should be replaced when it is supported in JUnit Jupiter 5.4. -// See https://github.com/junit-team/junit5/pull/1613 for details. double[] array = new double[]{0.3d, 0.4d, 0.5d}; ArrayUtils.reverse(array); -assertTrue(array[0] == 0.5d); -assertTrue(array[1] == 0.4d); -assertTrue(array[2] == 0.3d); +assertEquals(0.5d, array[0]); +assertEquals(0.4d, array[1]); +assertEquals(0.3d, array[2]); array = null; ArrayUtils.reverse(array); @@ -1514,14 +1511,11 @@ public class ArrayUtilsTest { @Test public void testReverseFloat() { -// TODO: JUnit Jupiter 5.3.1 doesn't support delta=0. -// This should be replaced when it is supported in JUnit Jupiter 5.4. -// See https://github.com/junit-team/junit5/pull/1613 for details. float[] array = new float[]{0.3f, 0.4f, 0.5f}; ArrayUtils.reverse(array); -assertTrue(array[0] == 0.5f); -assertTrue(array[1] == 0.4f); -assertTrue(array[2] == 0.3f); +assertEquals(0.5f, array[0]); +assertEquals(0.4f, array[1]); +assertEquals(0.3f, array[2]); array = null; ArrayUtils.reverse(array); @@ -1639,33 +1633,30 @@ public class ArrayUtilsTest { @Test public void testReverseDoubleRange() { -// TODO: JUnit Jupiter 5.3.1 doesn't support delta=0. -// This should be replaced when it is supported in JUnit Jupiter 5.4. -// See https://github.com/junit-team/junit5/pull/1613 for details. double[] array = new double[]{1, 2, 3}; // The whole array ArrayUtils.reverse(array, 0, 3); -assertTrue(3 == array[0]); -assertTrue(2 == array[1]); -assertTrue(1 == array[2]); +assertEquals(3, array[0]); +assertEquals(2, array[1]); +assertEquals(1, array[2]); // a range array = new double[]{1, 2, 3}; ArrayUtils.reverse(array, 0, 2); -assertTrue(2 == array[0]); -assertTrue(1 == array[1]); -assertTrue(3 == array[2]); +assertEquals(2, array[0]); +assertEquals(1, array[1]); +assertEquals(3, array[2]); // a range with a negative start array = new double[]{1, 2, 3}; ArrayUtils.reverse(array, -1, 3); -assertTrue(3 == array[0]); -assertTrue(2 == array[1]); -assertTrue(1 == array[2]); +assertEquals(3, array[0]); +assertEquals(2, array[1]); +assertEquals(1, array[2]); // a range with a large stop index array = new double[]{1, 2, 3}; ArrayUtils.reverse(array, -1, array.length + 1000); -assertTrue(3 == array[0]); -assertTrue(2 == array[1]); -assertTrue(1 == array[2]); +assertEquals(3, array[0]); +assertEquals(2, array[1]); +assertEquals(1, array[2]); // null array = null; ArrayUtils.reverse(array, 0, 3); @@ -1674,33 +1665,30 @@ public class ArrayUtilsTest { @Test public void testReverseFloatRange() { -// TODO: JUnit Jupiter 5.3.1 doesn't support delta=0. -// This should be replaced when it is supported in JUnit Jupiter 5.4. -// See https://github.com/junit-team/junit5/p
[commons-lang] branch master updated: Skip javadoc on Java 11 to workaround https://bugs.openjdk.java.net/browse/JDK-8212233 which causes javadoc to fail with "Exit code: 1 - javadoc: error - The code
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git The following commit(s) were added to refs/heads/master by this push: new 17bbe77 Skip javadoc on Java 11 to workaround https://bugs.openjdk.java.net/browse/JDK-8212233 which causes javadoc to fail with "Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/7/docs/api/ are in the unnamed module." 17bbe77 is described below commit 17bbe7726265b2125f31ab9a9eaee86057e98df5 Author: pascalschumacher AuthorDate: Fri Feb 8 19:50:44 2019 +0100 Skip javadoc on Java 11 to workaround https://bugs.openjdk.java.net/browse/JDK-8212233 which causes javadoc to fail with "Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/7/docs/api/ are in the unnamed module." --- pom.xml | 13 + 1 file changed, 13 insertions(+) diff --git a/pom.xml b/pom.xml index 96d688b..ce7e595 100644 --- a/pom.xml +++ b/pom.xml @@ -903,6 +903,19 @@ + java11 + +11 + + + +true + + + + benchmark true
[commons-lang] 10/13: FunctionsTest whitespace after comma
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git commit 19a5a09b092cf7e225de3ded6f7bd355ab9abed8 Author: Allon Mureinik AuthorDate: Fri Feb 8 19:37:38 2019 +0200 FunctionsTest whitespace after comma Add a space after the comma as per the project's Checkstyle rules --- src/test/java/org/apache/commons/lang3/FunctionsTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/org/apache/commons/lang3/FunctionsTest.java b/src/test/java/org/apache/commons/lang3/FunctionsTest.java index a161f9b..3e360ee 100644 --- a/src/test/java/org/apache/commons/lang3/FunctionsTest.java +++ b/src/test/java/org/apache/commons/lang3/FunctionsTest.java @@ -276,7 +276,7 @@ class FunctionsTest { @Test public void testTryWithResources() { final CloseableObject co = new CloseableObject(); - final FailableConsumer consumer = co::run; + final FailableConsumer consumer = co::run; final IllegalStateException ise = new IllegalStateException(); try { Functions.tryWithResources(() -> consumer.accept(ise), co::close);
[commons-lang] 09/13: FunctionsTest method references
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git commit 5e315d1ac926ead1349ebcb75abe91b124867591 Author: Allon Mureinik AuthorDate: Fri Feb 8 19:36:29 2019 +0200 FunctionsTest method references Use method references instead of lambda expression to clean up the code and comply to the project's Checkstyle rules. --- .../org/apache/commons/lang3/FunctionsTest.java| 50 +++--- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/src/test/java/org/apache/commons/lang3/FunctionsTest.java b/src/test/java/org/apache/commons/lang3/FunctionsTest.java index fe74bf1..a161f9b 100644 --- a/src/test/java/org/apache/commons/lang3/FunctionsTest.java +++ b/src/test/java/org/apache/commons/lang3/FunctionsTest.java @@ -118,7 +118,7 @@ class FunctionsTest { void testRunnable() { FailureOnOddInvocations.invocation = 0; try { - Functions.run(() -> new FailureOnOddInvocations()); + Functions.run(FailureOnOddInvocations::new); fail("Expected Exception"); } catch (UndeclaredThrowableException e) { final Throwable cause = e.getCause(); @@ -126,14 +126,14 @@ class FunctionsTest { assertTrue(cause instanceof SomeException); assertEquals("Odd Invocation: 1", cause.getMessage()); } - Functions.run(() -> new FailureOnOddInvocations()); + Functions.run(FailureOnOddInvocations::new); } @Test void testCallable() { FailureOnOddInvocations.invocation = 0; try { - Functions.call(() -> new FailureOnOddInvocations()); + Functions.call(FailureOnOddInvocations::new); fail("Expected Exception"); } catch (UndeclaredThrowableException e) { final Throwable cause = e.getCause(); @@ -141,7 +141,7 @@ class FunctionsTest { assertTrue(cause instanceof SomeException); assertEquals("Odd Invocation: 1", cause.getMessage()); } - final FailureOnOddInvocations instance = Functions.call(() -> new FailureOnOddInvocations()); + final FailureOnOddInvocations instance = Functions.call(FailureOnOddInvocations::new); assertNotNull(instance); } @@ -150,7 +150,7 @@ class FunctionsTest { final IllegalStateException ise = new IllegalStateException(); final Testable testable = new Testable(ise); try { - Functions.accept((t) -> t.test(), testable); + Functions.accept(Testable::test, testable); fail("Expected Exception"); } catch (IllegalStateException e) { assertSame(ise, e); @@ -158,14 +158,14 @@ class FunctionsTest { final Error error = new OutOfMemoryError(); testable.setThrowable(error); try { - Functions.accept((t) -> t.test(), testable); + Functions.accept(Testable::test, testable); } catch (OutOfMemoryError e) { assertSame(error, e); } final IOException ioe = new IOException("Unknown I/O error"); testable.setThrowable(ioe); try { - Functions.accept((t) -> t.test(), testable); + Functions.accept(Testable::test, testable); fail("Expected Exception"); } catch (UncheckedIOException e) { final Throwable t = e.getCause(); @@ -174,7 +174,7 @@ class FunctionsTest { assertSame(ioe, t); } testable.setThrowable(null); - Functions.accept((t) -> t.test(), testable); + Functions.accept(Testable::test, testable); } @Test @@ -182,21 +182,21 @@ class FunctionsTest { final IllegalStateException ise = new IllegalStateException(); final Testable testable = new Testable(null); try { - Functions.accept((t1,t2) -> t1.test(t2), testable, ise); + Functions.accept(Testable::test, testable, ise); fail("Expected Exception"); } catch (IllegalStateException e) { assertSame(ise, e); } final Error error = new OutOfMemory
[commons-lang] 07/13: FunctionsTest imports
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git commit 95926eb5d97e9f89718993bbed0a0f70da58a68f Author: Allon Mureinik AuthorDate: Fri Feb 8 19:32:39 2019 +0200 FunctionsTest imports Clean up FunctionsTest's imports as per the project's Checkstyle rules. --- src/test/java/org/apache/commons/lang3/FunctionsTest.java | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/test/java/org/apache/commons/lang3/FunctionsTest.java b/src/test/java/org/apache/commons/lang3/FunctionsTest.java index 5ce9350..ed76cb7 100644 --- a/src/test/java/org/apache/commons/lang3/FunctionsTest.java +++ b/src/test/java/org/apache/commons/lang3/FunctionsTest.java @@ -16,16 +16,19 @@ */ package org.apache.commons.lang3; -import static org.junit.jupiter.api.Assertions.*; - import java.io.IOException; import java.io.UncheckedIOException; import java.lang.reflect.UndeclaredThrowableException; -import org.apache.commons.lang3.Functions.FailableBiConsumer; import org.apache.commons.lang3.Functions.FailableConsumer; import org.junit.jupiter.api.Test; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertSame; +import static org.junit.jupiter.api.Assertions.assertTrue; +import static org.junit.jupiter.api.Assertions.fail; + class FunctionsTest { public static class SomeException extends Exception { private static final long serialVersionUID = -4965704778119283411L;
[commons-lang] 05/13: Add spaces after commas in Functions.java
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git commit 962e529984cac73b364e24c81904db6f2b207c56 Author: Allon Mureinik AuthorDate: Fri Feb 8 19:29:06 2019 +0200 Add spaces after commas in Functions.java Add spaces after commas as per the project's Checkstyle rules. --- .../java/org/apache/commons/lang3/Functions.java | 32 +++--- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/src/main/java/org/apache/commons/lang3/Functions.java b/src/main/java/org/apache/commons/lang3/Functions.java index 715eaa6..fac1f3a 100644 --- a/src/main/java/org/apache/commons/lang3/Functions.java +++ b/src/main/java/org/apache/commons/lang3/Functions.java @@ -55,7 +55,7 @@ public class Functions { void run() throws T; } @FunctionalInterface - public interface FailableCallable { + public interface FailableCallable { /** * Calls the callable. * @return The value returned from the callable @@ -64,7 +64,7 @@ public class Functions { O call() throws T; } @FunctionalInterface - public interface FailableConsumer { + public interface FailableConsumer { /** * Accepts the consumer. * @param pObject the parameter for the consumable to accept @@ -73,7 +73,7 @@ public class Functions { void accept(O pObject) throws T; } @FunctionalInterface - public interface FailableBiConsumer { + public interface FailableBiConsumer { /** * Accepts the consumer. * @param pObject1 the first parameter for the consumable to accept @@ -83,7 +83,7 @@ public class Functions { void accept(O1 pObject1, O2 pObject2) throws T; } @FunctionalInterface - public interface FailableFunction { + public interface FailableFunction { /** * Apply the function. * @param pInput the input for the function @@ -93,7 +93,7 @@ public class Functions { O apply(I pInput) throws T; } @FunctionalInterface - public interface FailableBiFunction { + public interface FailableBiFunction { /** * Apply the function. * @param pInput1 the first input for the function @@ -104,7 +104,7 @@ public class Functions { O apply(I1 pInput1, I2 pInput2) throws T; } @FunctionalInterface - public interface FailablePredicate { + public interface FailablePredicate { /** * Test the predicate. * @param pObject the object to test the predicate on @@ -114,7 +114,7 @@ public class Functions { boolean test(O pObject) throws T; } @FunctionalInterface - public interface FailableBiPredicate { + public interface FailableBiPredicate { /** * Test the predicate. * @param pObject1 the first object to test the predicate on @@ -145,7 +145,7 @@ public class Functions { * @param the type of checked exception the callable may throw * @return the value returned from the callable */ - public static O call(FailableCallable pCallable) { + public static O call(FailableCallable pCallable) { try { return pCallable.call(); } catch (Throwable t) { @@ -160,7 +160,7 @@ public class Functions { * @param the type the consumer accepts * @param the type of checked exception the consumer may throw */ - public static void accept(FailableConsumer pConsumer, O pObject) { + public static void accept(FailableConsumer pConsumer, O pObject) { try { pConsumer.accept(pObject); } catch (Throwable t) { @@ -177,7 +177,7 @@ public class Functions { * @param the type of the second argument the consumer accepts * @param the type of checked exception the consumer may throw */ - public static void accept(FailableBiConsumer pConsumer, O1 pObject1, O2 pObject2) { + public static void accept(FailableBiConsumer pConsumer, O1 pObject1, O2 pObject2) { try { pConsumer.accept(pObject1, pObject2); } catch (Throwable t) { @@ -194,7 +194,7 @@ public class Functions { * @param the type of checked exception the function may throw * @return the value returned from the function */ - public static O apply(FailableFunction pFunction, I pInput) { + public static O apply(FailableFunction pFunction, I p
[commons-lang] 11/13: FunctionsTest whitespaces
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git commit f12cfc8d4e723c0973150350eb0c68c52ea1068b Author: Allon Mureinik AuthorDate: Fri Feb 8 19:39:01 2019 +0200 FunctionsTest whitespaces Use four spaces instead of a tab as per the projcet's Checkstyle rules. --- .../org/apache/commons/lang3/FunctionsTest.java| 510 ++--- 1 file changed, 255 insertions(+), 255 deletions(-) diff --git a/src/test/java/org/apache/commons/lang3/FunctionsTest.java b/src/test/java/org/apache/commons/lang3/FunctionsTest.java index 3e360ee..77c67f4 100644 --- a/src/test/java/org/apache/commons/lang3/FunctionsTest.java +++ b/src/test/java/org/apache/commons/lang3/FunctionsTest.java @@ -30,282 +30,282 @@ import static org.junit.jupiter.api.Assertions.assertTrue; import static org.junit.jupiter.api.Assertions.fail; class FunctionsTest { - public static class SomeException extends Exception { - private static final long serialVersionUID = -4965704778119283411L; +public static class SomeException extends Exception { +private static final long serialVersionUID = -4965704778119283411L; - private Throwable t; +private Throwable t; - SomeException(String pMsg) { - super(pMsg); - } +SomeException(String pMsg) { +super(pMsg); +} - public void setThrowable(Throwable pThrowable) { - t = pThrowable; - } +public void setThrowable(Throwable pThrowable) { +t = pThrowable; +} - public void test() throws Throwable { - if (t != null) { - throw t; - } - } - } - public static class Testable { - private Throwable t; +public void test() throws Throwable { +if (t != null) { +throw t; +} +} +} +public static class Testable { +private Throwable t; - Testable(Throwable pTh) { - t = pTh; - } +Testable(Throwable pTh) { +t = pTh; +} - public void setThrowable(Throwable pThrowable) { - t = pThrowable; - } +public void setThrowable(Throwable pThrowable) { +t = pThrowable; +} - public void test() throws Throwable { - test(t); - } +public void test() throws Throwable { +test(t); +} - public void test(Throwable pThrowable) throws Throwable { - if (pThrowable != null) { - throw pThrowable; - } - } +public void test(Throwable pThrowable) throws Throwable { +if (pThrowable != null) { +throw pThrowable; +} +} - public Integer testInt() throws Throwable { - return testInt(t); - } +public Integer testInt() throws Throwable { +return testInt(t); +} - public Integer testInt(Throwable pThrowable) throws Throwable { - if (pThrowable != null) { - throw pThrowable; - } - return 0; - } - } +public Integer testInt(Throwable pThrowable) throws Throwable { +if (pThrowable != null) { +throw pThrowable; +} +return 0; +} +} - public static class FailureOnOddInvocations { - private static int invocation; - FailureOnOddInvocations() throws SomeException { - final int i = ++invocation; - if (i % 2 == 1) { - throw new SomeException("Odd Invocation: " + i); - } - } - } +public static class FailureOnOddInvocations { +private static int invocation; +FailureOnOddInvocations() throws SomeException { +final int i = ++invocation; +if (i % 2 == 1) { +throw new SomeException("Odd Invocation: " + i); +} +} +} - public static class CloseableObject { - private boolean closed; +public static class CloseableObject { +private boolean closed; - public void run(Throwable pTh) throws Throwable { - if (pTh != null) { - throw pTh; - } - } +publ
[commons-lang] 02/13: Functions' interfaces modifiers
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git commit f7fae53aecb73eb794ff3ba3e84ee836b6800b68 Author: Allon Mureinik AuthorDate: Fri Feb 8 18:18:40 2019 +0200 Functions' interfaces modifiers Remove the redundant public modifier from the inner interfaces in Functions, as per the Checkstyle policy of the project. --- src/main/java/org/apache/commons/lang3/Functions.java | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/main/java/org/apache/commons/lang3/Functions.java b/src/main/java/org/apache/commons/lang3/Functions.java index 5eaed0c..b48d13a 100644 --- a/src/main/java/org/apache/commons/lang3/Functions.java +++ b/src/main/java/org/apache/commons/lang3/Functions.java @@ -48,35 +48,35 @@ import java.lang.reflect.UndeclaredThrowableException; public class Functions { @FunctionalInterface public interface FailableRunnable { - public void run() throws T; + void run() throws T; } @FunctionalInterface public interface FailableCallable { - public O call() throws T; + O call() throws T; } @FunctionalInterface public interface FailableConsumer { - public void accept(O pObject) throws T; + void accept(O pObject) throws T; } @FunctionalInterface public interface FailableBiConsumer { - public void accept(O1 pObject1, O2 pObject2) throws T; + void accept(O1 pObject1, O2 pObject2) throws T; } @FunctionalInterface public interface FailableFunction { - public O apply(I pInput) throws T; + O apply(I pInput) throws T; } @FunctionalInterface public interface FailableBiFunction { - public O apply(I1 pInput1, I2 pInput2) throws T; + O apply(I1 pInput1, I2 pInput2) throws T; } @FunctionalInterface public interface FailablePredicate { - public boolean test(O pObject) throws T; + boolean test(O pObject) throws T; } @FunctionalInterface public interface FailableBiPredicate { - public boolean test(O1 pObject1, O2 pObject2) throws T; + boolean test(O1 pObject1, O2 pObject2) throws T; } public static void run(FailableRunnable pRunnable) {
[commons-lang] 04/13: Remove unused generic argument from Functions#tryWithResources
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git commit 028c9ec70c0f4cca03500143dacb4b160b40d7dd Author: Allon Mureinik AuthorDate: Fri Feb 8 19:24:03 2019 +0200 Remove unused generic argument from Functions#tryWithResources --- src/main/java/org/apache/commons/lang3/Functions.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/apache/commons/lang3/Functions.java b/src/main/java/org/apache/commons/lang3/Functions.java index cff1279..715eaa6 100644 --- a/src/main/java/org/apache/commons/lang3/Functions.java +++ b/src/main/java/org/apache/commons/lang3/Functions.java @@ -278,7 +278,7 @@ public class Functions { * @see #tryWithResources(FailableRunnable, FailableRunnable...) */ @SafeVarargs - public static void tryWithResources(FailableRunnable pAction, + public static void tryWithResources(FailableRunnable pAction, FailableConsumer pErrorHandler, FailableRunnable... pResources) { final FailableConsumer errorHandler; @@ -340,7 +340,7 @@ public class Functions { * @see #tryWithResources(FailableRunnable, FailableConsumer, FailableRunnable...) */ @SafeVarargs - public static void tryWithResources(FailableRunnable pAction, + public static void tryWithResources(FailableRunnable pAction, FailableRunnable... pResources) { tryWithResources(pAction, null, pResources); }
[commons-lang] branch master updated (ef1480a -> 43badd4)
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git. from ef1480a Add missing Apache license header new 1c48eb0 Add license to FunctionsTest.java new f7fae53 Functions' interfaces modifiers new b08c92e Fix Javadoc issues in Functions new 028c9ec Remove unused generic argument from Functions#tryWithResources new 962e529 Add spaces after commas in Functions.java new c5eadb1 Functions.java whitspaces new 95926eb FunctionsTest imports new 76a243c FunctionTest redundant constructor modifier new 5e315d1 FunctionsTest method references new 19a5a09 FunctionsTest whitespace after comma new f12cfc8 FunctionsTest whitespaces new fc6a392 Fix javadoc errors in Functions.java new 43badd4 Merge remote-tracking branch 'origin/pr/403' The 13 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../java/org/apache/commons/lang3/Functions.java | 507 .../org/apache/commons/lang3/FunctionsTest.java| 523 +++-- 2 files changed, 575 insertions(+), 455 deletions(-)
[commons-lang] 01/13: Add license to FunctionsTest.java
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git commit 1c48eb0d8be78dd18ce4fe1fd3a0cc0fcad58149 Author: Allon Mureinik AuthorDate: Fri Feb 8 17:47:29 2019 +0200 Add license to FunctionsTest.java Add a license header to FunctionsTest.java to make the rat maven task pass. --- .../java/org/apache/commons/lang3/FunctionsTest.java | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/src/test/java/org/apache/commons/lang3/FunctionsTest.java b/src/test/java/org/apache/commons/lang3/FunctionsTest.java index baef2dd..5ce9350 100644 --- a/src/test/java/org/apache/commons/lang3/FunctionsTest.java +++ b/src/test/java/org/apache/commons/lang3/FunctionsTest.java @@ -1,3 +1,19 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ package org.apache.commons.lang3; import static org.junit.jupiter.api.Assertions.*; @@ -44,7 +60,7 @@ class FunctionsTest { public void test() throws Throwable { test(t); } - + public void test(Throwable pThrowable) throws Throwable { if (pThrowable != null) { throw pThrowable; @@ -94,7 +110,7 @@ class FunctionsTest { return closed; } } - + @Test void testRunnable() { FailureOnOddInvocations.invocation = 0;
[commons-lang] 12/13: Fix javadoc errors in Functions.java
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git commit fc6a392b7c1a23227a994972985dadef10ab83a9 Author: Allon Mureinik AuthorDate: Fri Feb 8 20:05:43 2019 +0200 Fix javadoc errors in Functions.java --- src/main/java/org/apache/commons/lang3/Functions.java | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/main/java/org/apache/commons/lang3/Functions.java b/src/main/java/org/apache/commons/lang3/Functions.java index 903a527..ec4db67 100644 --- a/src/main/java/org/apache/commons/lang3/Functions.java +++ b/src/main/java/org/apache/commons/lang3/Functions.java @@ -28,7 +28,7 @@ import java.lang.reflect.UndeclaredThrowableException; * not to throw Exceptions, at least not checked Exceptions, aka instances of * {@link Exception}. This enforces the use of constructs like * - * Consumer consumer = (m) -> { + * Consumer<java.lang.reflect.Method> consumer = (m) -> { * try { * m.invoke(o, args); * } catch (Throwable t) { @@ -36,11 +36,11 @@ import java.lang.reflect.UndeclaredThrowableException; * } * }; * - * By replacing a {@link Consumer Consumer} with a - * {@link FailableConsumer FailableConsumer - * Functions.accept((m) -> m.invoke(o,args)); + * Functions.accept((m) -> m.invoke(o,args)); * * Obviously, the second version is much more concise and the spirit of * Lambda expressions is met better than the second version. @@ -265,7 +265,7 @@ public class Functions { * {@link Throwable} is rethrown. Example use: * * final FileInputStream fis = new FileInputStream("my.file"); - * Functions.tryWithResources(useInputStream(fis), null, () -> fis.close()); + * Functions.tryWithResources(useInputStream(fis), null, () -> fis.close()); * * @param pAction The action to execute. This object will always * be invoked. @@ -330,7 +330,7 @@ public class Functions { * {@link Throwable} is rethrown. Example use: * * final FileInputStream fis = new FileInputStream("my.file"); - * Functions.tryWithResources(useInputStream(fis), () -> fis.close()); + * Functions.tryWithResources(useInputStream(fis), () -> fis.close()); * * @param pAction The action to execute. This object will always * be invoked.
[commons-lang] 06/13: Functions.java whitspaces
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git commit c5eadb1c6d5245526bf895f22957cadec3dfc3b6 Author: Allon Mureinik AuthorDate: Fri Feb 8 19:30:35 2019 +0200 Functions.java whitspaces Replace tabs with four spaces, as per the project's Checkstyle rules. --- .../java/org/apache/commons/lang3/Functions.java | 616 ++--- 1 file changed, 308 insertions(+), 308 deletions(-) diff --git a/src/main/java/org/apache/commons/lang3/Functions.java b/src/main/java/org/apache/commons/lang3/Functions.java index fac1f3a..903a527 100644 --- a/src/main/java/org/apache/commons/lang3/Functions.java +++ b/src/main/java/org/apache/commons/lang3/Functions.java @@ -46,323 +46,323 @@ import java.lang.reflect.UndeclaredThrowableException; * Lambda expressions is met better than the second version. */ public class Functions { - @FunctionalInterface - public interface FailableRunnable { - /** -* Runs the function. -* @throws T if the function fails -*/ - void run() throws T; - } - @FunctionalInterface - public interface FailableCallable { - /** -* Calls the callable. -* @return The value returned from the callable -* @throws T if the callable fails -*/ - O call() throws T; - } - @FunctionalInterface - public interface FailableConsumer { - /** -* Accepts the consumer. -* @param pObject the parameter for the consumable to accept -* @throws T if the consumer fails -*/ - void accept(O pObject) throws T; - } - @FunctionalInterface - public interface FailableBiConsumer { - /** -* Accepts the consumer. -* @param pObject1 the first parameter for the consumable to accept -* @param pObject2 the second parameter for the consumable to accept -* @throws T if the consumer fails -*/ - void accept(O1 pObject1, O2 pObject2) throws T; - } - @FunctionalInterface - public interface FailableFunction { - /** -* Apply the function. -* @param pInput the input for the function -* @return the result of the function -* @throws T if the function fails -*/ - O apply(I pInput) throws T; - } - @FunctionalInterface - public interface FailableBiFunction { - /** -* Apply the function. -* @param pInput1 the first input for the function -* @param pInput2 the second input for the function -* @return the result of the function -* @throws T if the function fails -*/ - O apply(I1 pInput1, I2 pInput2) throws T; - } - @FunctionalInterface - public interface FailablePredicate { - /** -* Test the predicate. -* @param pObject the object to test the predicate on -* @return the predicate's evaluation -* @throws T if the predicate fails -*/ - boolean test(O pObject) throws T; - } - @FunctionalInterface - public interface FailableBiPredicate { - /** -* Test the predicate. -* @param pObject1 the first object to test the predicate on -* @param pObject2 the second object to test the predicate on -* @return the predicate's evaluation -* @throws T if the predicate fails -*/ - boolean test(O1 pObject1, O2 pObject2) throws T; - } +@FunctionalInterface +public interface FailableRunnable { +/** + * Runs the function. + * @throws T if the function fails + */ +void run() throws T; +} +@FunctionalInterface +public interface FailableCallable { +/** + * Calls the callable. + * @return The value returned from the callable + * @throws T if the callable fails + */ +O call() throws T; +} +@FunctionalInterface +public interface FailableConsumer { +/** + * Accepts the consumer. + * @param pObject the parameter for the consumable to accept + * @throws T if the consumer fails + */ +void accept(O pObject) throws T; +} +@FunctionalInterface +public interface FailableBiConsumer { +/** + * Accepts the consumer. + * @param pObject1 the first parameter for
[commons-lang] 13/13: Merge remote-tracking branch 'origin/pr/403'
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git commit 43badd4dfa44b5e0c2fe65cbc20c7766298b5960 Merge: ef1480a fc6a392 Author: pascalschumacher AuthorDate: Fri Feb 8 19:41:40 2019 +0100 Merge remote-tracking branch 'origin/pr/403' .../java/org/apache/commons/lang3/Functions.java | 507 .../org/apache/commons/lang3/FunctionsTest.java| 523 +++-- 2 files changed, 575 insertions(+), 455 deletions(-)
[commons-lang] 08/13: FunctionTest redundant constructor modifier
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git commit 76a243c58776c577935985f6114b9597e5725dab Author: Allon Mureinik AuthorDate: Fri Feb 8 19:34:40 2019 +0200 FunctionTest redundant constructor modifier Remove redundant public modifiers from inner classes constructors as per the project's Checkstyle rules. --- src/test/java/org/apache/commons/lang3/FunctionsTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/test/java/org/apache/commons/lang3/FunctionsTest.java b/src/test/java/org/apache/commons/lang3/FunctionsTest.java index ed76cb7..fe74bf1 100644 --- a/src/test/java/org/apache/commons/lang3/FunctionsTest.java +++ b/src/test/java/org/apache/commons/lang3/FunctionsTest.java @@ -35,7 +35,7 @@ class FunctionsTest { private Throwable t; - public SomeException(String pMsg) { + SomeException(String pMsg) { super(pMsg); } @@ -52,7 +52,7 @@ class FunctionsTest { public static class Testable { private Throwable t; - public Testable(Throwable pTh) { + Testable(Throwable pTh) { t = pTh; } @@ -84,7 +84,7 @@ class FunctionsTest { public static class FailureOnOddInvocations { private static int invocation; - public FailureOnOddInvocations() throws SomeException { + FailureOnOddInvocations() throws SomeException { final int i = ++invocation; if (i % 2 == 1) { throw new SomeException("Odd Invocation: " + i);
[commons-lang] 03/13: Fix Javadoc issues in Functions
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git commit b08c92e75d9885ffa03dc61f323489beb2ca7778 Author: Allon Mureinik AuthorDate: Fri Feb 8 19:21:27 2019 +0200 Fix Javadoc issues in Functions --- .../java/org/apache/commons/lang3/Functions.java | 117 + 1 file changed, 117 insertions(+) diff --git a/src/main/java/org/apache/commons/lang3/Functions.java b/src/main/java/org/apache/commons/lang3/Functions.java index b48d13a..cff1279 100644 --- a/src/main/java/org/apache/commons/lang3/Functions.java +++ b/src/main/java/org/apache/commons/lang3/Functions.java @@ -48,37 +48,88 @@ import java.lang.reflect.UndeclaredThrowableException; public class Functions { @FunctionalInterface public interface FailableRunnable { + /** +* Runs the function. +* @throws T if the function fails +*/ void run() throws T; } @FunctionalInterface public interface FailableCallable { + /** +* Calls the callable. +* @return The value returned from the callable +* @throws T if the callable fails +*/ O call() throws T; } @FunctionalInterface public interface FailableConsumer { + /** +* Accepts the consumer. +* @param pObject the parameter for the consumable to accept +* @throws T if the consumer fails +*/ void accept(O pObject) throws T; } @FunctionalInterface public interface FailableBiConsumer { + /** +* Accepts the consumer. +* @param pObject1 the first parameter for the consumable to accept +* @param pObject2 the second parameter for the consumable to accept +* @throws T if the consumer fails +*/ void accept(O1 pObject1, O2 pObject2) throws T; } @FunctionalInterface public interface FailableFunction { + /** +* Apply the function. +* @param pInput the input for the function +* @return the result of the function +* @throws T if the function fails +*/ O apply(I pInput) throws T; } @FunctionalInterface public interface FailableBiFunction { + /** +* Apply the function. +* @param pInput1 the first input for the function +* @param pInput2 the second input for the function +* @return the result of the function +* @throws T if the function fails +*/ O apply(I1 pInput1, I2 pInput2) throws T; } @FunctionalInterface public interface FailablePredicate { + /** +* Test the predicate. +* @param pObject the object to test the predicate on +* @return the predicate's evaluation +* @throws T if the predicate fails +*/ boolean test(O pObject) throws T; } @FunctionalInterface public interface FailableBiPredicate { + /** +* Test the predicate. +* @param pObject1 the first object to test the predicate on +* @param pObject2 the second object to test the predicate on +* @return the predicate's evaluation +* @throws T if the predicate fails +*/ boolean test(O1 pObject1, O2 pObject2) throws T; } + /** +* Runs a runnable and rethrows any exception as a {@link RuntimeException}. +* @param pRunnable The runnable to run +* @param the type of checked exception the runnable may throw +*/ public static void run(FailableRunnable pRunnable) { try { pRunnable.run(); @@ -87,6 +138,13 @@ public class Functions { } } + /** +* Calls a callable and rethrows any exception as a {@link RuntimeException}. +* @param pCallable the callable to call +* @param the return type of the callable +* @param the type of checked exception the callable may throw +* @return the value returned from the callable +*/ public static O call(FailableCallable pCallable) { try { return pCallable.call(); @@ -95,6 +153,13 @@ public class Functions { } } + /** +* Consumes a consumer and rethrows any exception as a {@link RuntimeException}. +
svn commit: r1852282 - in /commons/proper/commons-parent/trunk: pom.xml src/changes/changes.xml
Author: pascalschumacher Date: Sun Jan 27 10:02:12 2019 New Revision: 1852282 URL: http://svn.apache.org/viewvc?rev=1852282&view=rev Log: org.jacoco:jacoco-maven-plugin 0.8.2 -> 0.8.3 (Java 11) Modified: commons/proper/commons-parent/trunk/pom.xml commons/proper/commons-parent/trunk/src/changes/changes.xml Modified: commons/proper/commons-parent/trunk/pom.xml URL: http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?rev=1852282&r1=1852281&r2=1852282&view=diff == --- commons/proper/commons-parent/trunk/pom.xml (original) +++ commons/proper/commons-parent/trunk/pom.xml Sun Jan 27 10:02:12 2019 @@ -1664,7 +1664,7 @@ 3.1.1 3.1.1 3.7.1 -0.8.2 +0.8.3 2.7 4.3.0 EpochMillis Modified: commons/proper/commons-parent/trunk/src/changes/changes.xml URL: http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/src/changes/changes.xml?rev=1852282&r1=1852281&r2=1852282&view=diff == --- commons/proper/commons-parent/trunk/src/changes/changes.xml (original) +++ commons/proper/commons-parent/trunk/src/changes/changes.xml Sun Jan 27 10:02:12 2019 @@ -73,7 +73,7 @@ The type attribute can be add,u presence of the file src/site/resources/profile.japicmp - org.apache.felix:maven-bundle-plugin 3.5.0 -> 3.5.1 org.apache.felix:maven-bundle-plugin 3.5.0 -> 3.5.1 -org.jacoco:jacoco-maven-plugin 0.8.1 -> 0.8.2 (Java 11) +org.jacoco:jacoco-maven-plugin 0.8.1 -> 0.8.3 (Java 11) org.apache.maven.wagon:wagon-ssh 3.1.0 -> 3.2.0 maven-surefire-plugin 2.22.0 -> 2.22.1 maven-surefire-report-plugin 2.22.0 -> 2.22.1
[commons-lang] branch master updated: Update spotbugs-maven-plugin to version 3.1.10
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git The following commit(s) were added to refs/heads/master by this push: new f7c62b2 Update spotbugs-maven-plugin to version 3.1.10 f7c62b2 is described below commit f7c62b29c91b095e46658638263ed82a4272f4bd Author: pascalschumacher AuthorDate: Sat Jan 5 22:51:18 2019 +0100 Update spotbugs-maven-plugin to version 3.1.10 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 56ddfd0..96d688b 100644 --- a/pom.xml +++ b/pom.xml @@ -620,7 +620,7 @@ 3.0.0 8.13 -3.1.8 +3.1.10 false
[commons-text] branch master updated (f41e918 -> 73adcbb)
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git. from f41e918 Update spotbugs-maven-plugin to version 3.1.10 new 21c7737 Travis: "openjdk-ea" now means Java 13, so add Java 12 to JDKs to build on. new 2614a94 Disable JaCoCo on Java 13+, because it does not support it yet. new 73adcbb Skip SpotBugs on Java 13+, because it fails with "java.lang.IllegalArgumentException: Unsupported class file major version 57". The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .travis.yml | 1 + pom.xml | 12 2 files changed, 13 insertions(+)
[commons-text] 01/03: Travis: "openjdk-ea" now means Java 13, so add Java 12 to JDKs to build on.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git commit 21c7737afa3775cbbbea5785a94c014be833b038 Author: Pascal Schumacher AuthorDate: Sat Jan 5 21:11:56 2019 +0100 Travis: "openjdk-ea" now means Java 13, so add Java 12 to JDKs to build on. --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index 769d039..9845844 100644 --- a/.travis.yml +++ b/.travis.yml @@ -18,6 +18,7 @@ language: java jdk: - oraclejdk8 - openjdk11 + - openjdk12 - openjdk-ea script:
[commons-text] 03/03: Skip SpotBugs on Java 13+, because it fails with "java.lang.IllegalArgumentException: Unsupported class file major version 57".
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git commit 73adcbbef6ee1a9f349f060f789be97194890f6a Author: Pascal Schumacher AuthorDate: Sat Jan 5 22:43:03 2019 +0100 Skip SpotBugs on Java 13+, because it fails with "java.lang.IllegalArgumentException: Unsupported class file major version 57". --- pom.xml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pom.xml b/pom.xml index a8cb9e3..1c9ef29 100644 --- a/pom.xml +++ b/pom.xml @@ -471,6 +471,8 @@ true + +true
[commons-text] 02/03: Disable JaCoCo on Java 13+, because it does not support it yet.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git commit 2614a94acc1a1669a5a49105bde219de770795d9 Author: Pascal Schumacher AuthorDate: Sat Jan 5 22:33:07 2019 +0100 Disable JaCoCo on Java 13+, because it does not support it yet. --- pom.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/pom.xml b/pom.xml index d5649cd..a8cb9e3 100644 --- a/pom.xml +++ b/pom.xml @@ -463,5 +463,15 @@ true + + java13+ + +[13,) + + + +true + +
[commons-text] branch master updated: Update spotbugs-maven-plugin to version 3.1.10
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new f41e918 Update spotbugs-maven-plugin to version 3.1.10 f41e918 is described below commit f41e918b7804318009c9cbd409b53e08a4b44940 Author: Pascal Schumacher AuthorDate: Sat Jan 5 22:24:17 2019 +0100 Update spotbugs-maven-plugin to version 3.1.10 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 2fc32fa..d5649cd 100644 --- a/pom.xml +++ b/pom.xml @@ -52,7 +52,7 @@ 3.0.0 8.14 -3.1.9 +3.1.10 0.8.2
[commons-lang] branch master updated: Travis: "openjdk-ea" now means Java 13, so add Java 12 to JDKs to build on. (closes #396)
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git The following commit(s) were added to refs/heads/master by this push: new ef18f3e Travis: "openjdk-ea" now means Java 13, so add Java 12 to JDKs to build on. (closes #396) ef18f3e is described below commit ef18f3ea26b509ce4f2e321b9772e73eb00d4ca0 Author: pascalschumacher AuthorDate: Sat Jan 5 21:29:45 2019 +0100 Travis: "openjdk-ea" now means Java 13, so add Java 12 to JDKs to build on. (closes #396) --- .travis.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.travis.yml b/.travis.yml index c1b70e3..19630c1 100644 --- a/.travis.yml +++ b/.travis.yml @@ -18,10 +18,12 @@ language: java jdk: - oraclejdk8 - openjdk11 + - openjdk12 - openjdk-ea matrix: allow_failures: +- jdk: openjdk12 - jdk: openjdk-ea script:
[commons-text] branch master updated: Update spotbugs-maven-plugin to version 3.1.9 and enable SpotBugs on Java 12+ (closes #99).
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-text.git The following commit(s) were added to refs/heads/master by this push: new 5fcf96c Update spotbugs-maven-plugin to version 3.1.9 and enable SpotBugs on Java 12+ (closes #99). 5fcf96c is described below commit 5fcf96ca1128a1a59f72d242b2f133893998df12 Author: Pascal Schumacher AuthorDate: Thu Dec 20 15:24:12 2018 +0100 Update spotbugs-maven-plugin to version 3.1.9 and enable SpotBugs on Java 12+ (closes #99). --- pom.xml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index 194a2ad..2fc32fa 100644 --- a/pom.xml +++ b/pom.xml @@ -52,7 +52,7 @@ 3.0.0 8.14 -3.1.8 +3.1.9 0.8.2 @@ -461,8 +461,6 @@ true - -true
[commons-lang] branch master updated: Update to JaCoCo 0.8.2 with works Java 11+.
This is an automated email from the ASF dual-hosted git repository. pascalschumacher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git The following commit(s) were added to refs/heads/master by this push: new e0a5a4b Update to JaCoCo 0.8.2 with works Java 11+. e0a5a4b is described below commit e0a5a4b5b63068063878fa68d2568e57d9e1f4fc Author: pascalschumacher AuthorDate: Thu Dec 20 14:48:34 2018 +0100 Update to JaCoCo 0.8.2 with works Java 11+. --- pom.xml | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/pom.xml b/pom.xml index cbbedf8..56ddfd0 100644 --- a/pom.xml +++ b/pom.xml @@ -629,6 +629,8 @@ 5.3.2 +0.8.2 + false @@ -901,17 +903,6 @@ - java11+ - -[11,) - - - -true - - - - benchmark true