[GitHub] dpogue commented on issue #559: Ignore version file in eslint to resolve build error

[GitBox]

dpogue commented on issue #559: Ignore version file in eslint to resolve build 
error
URL: https://github.com/apache/cordova-android/pull/559#issuecomment-438935516
 
 
   > I may be wrong here. Not sure if I would favor an extra eslint comment 
though. Build of `master` branch is green again, moving on.
   
   If the file is entirely generated by coho, then the best option is probably 
looking at how to generate it with the right quotes. The eslint comment 
suggestion was assuming that coho was just doing a find-and-replace on it in an 
existing file.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] ECNU3D commented on issue #454: Use NSOperationQueue (GH-452)

[GitBox]

ECNU3D commented on issue #454: Use NSOperationQueue (GH-452)
URL: https://github.com/apache/cordova-ios/pull/454#issuecomment-438925110
 
 
   @brodybits thanks, I will try to follow that document and post some plugin 
to demonstrate the issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] artuska edited a comment on issue #260: File becomes [object Object] in FormData

[GitBox]

artuska edited a comment on issue #260: File becomes [object Object] in FormData
URL: 
https://github.com/apache/cordova-plugin-file/issues/260#issuecomment-438918491
 
 
   About the Blob. There are a lot of weird stuff here about the Blob in 
Cordova.
   
   I used some custom file chooser (do not remember which exactly but you have 
to use custom file chooser, not ``) which returned `cdvfile` 
file path of the selected file → then I used `cordova-plugin-file` and it's 
`resolveLocalFileSystemURL` to get a link to the real file path → then I 
converted it to Blob and was able to sent it to the server the same way I sent 
File and then I wrote a comment here that everything works now... but all this 
was on Android API 21 emulator.
   
   When I installed my app with all my Blob stuff to the Android phone (the 
phone which had issues with file select)... Cordova did not allowed me to send 
a Blob outside the Cordova environment. That's it. You cannot send Blob, 
Cordova will throw you the SSL error. I dunno what it is and what to do about 
it, so I just found other way to deal with broken file select (by removing 
AndroidLaunchMode preference as I wrote above here in comments) and just 
stopped further dealing with the Blob.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] artuska commented on issue #260: File becomes [object Object] in FormData

[GitBox]

artuska commented on issue #260: File becomes [object Object] in FormData
URL: 
https://github.com/apache/cordova-plugin-file/issues/260#issuecomment-438918491
 
 
   About the Blob. There are a lot of weird stuff here about the Blob in 
Cordova.
   
   I used some custom file chooser (do not remember which exactly but you have 
to use custom file chooser, not ) which returned `cdvfile` 
file path of the selected file → then I used `cordova-plugin-file` and it's 
`resolveLocalFileSystemURL` to get a link to the real file path → then I 
converted it to Blob and was able to sent it to the server the same way I sent 
File and then I wrote a comment here that everything works now... but all this 
was on Android API 21 emulator.
   
   When I installed my app with all my Blob stuff to the Android phone (the 
phone which had issues with file select)... Cordova did not allowed me to send 
a Blob outside the Cordova environment. That's it. You cannot send Blob, 
Cordova will throw you the SSL error. I dunno what it is and what to do about 
it, so I just found other way to deal with broken file select (by removing 
AndroidLaunchMode preference as I wrote above here in comments) and just 
stopped further dealing with the Blob.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] blukis opened a new issue #560: Content-security-policy bug

[GitBox]

blukis opened a new issue #560: Content-security-policy bug
URL: https://github.com/apache/cordova-android/issues/560
 
 
   I believe I found an issue with content-security-policy in cordova 
environment...
   
   I have an app that includes this page in an iframe: 
"http://201x.plurib.us/test/2018/content-security-outer.html";, which in turn 
includes this page in another iframe 
"http://201x.plurib.us/test/2018/content-security-inner.php";.  (Note: these are 
very short pages created to debug this issue.  The original page causing the 
issue was a shopify checkout page, found in the comments of "...outer.html".)
   
   "...inner.php" includes this http header:
   `Content-Security-Policy: frame-ancestors *`
   
   "...outer.html" (and its inner iframe) loads OK in Chrome on Android, but 
when included the url in a cordova app, "...inner.php" iframe does not load.  
(Note: app has "cordova-plugin-whitelist" plugin and ``).
   
   When I enable android debugging and check the remote device console in 
Chrome, I see this error in the Chrome console:
   
   > Refused to display 
'http://201x.plurib.us/test/2018/content-security-inner.php' in a frame because 
an ancestor violates the following Content Security Policy directive: 
"frame-ancestors *".
   
   Maybe I'm missing something, but I'm not sure how anything could fail to 
pass "frame-ancestors *".  Is it a cordova issue?  Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #555: 7.1.3 patch updates

[GitBox]

brodybits commented on issue #555: 7.1.3 patch updates
URL: https://github.com/apache/cordova-android/pull/555#issuecomment-438911311
 
 
   I just finished testing the patch updates with some plugins listed in the OP 
description, quick review would be appreciated.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] artuska commented on issue #260: File becomes [object Object] in FormData

[GitBox]

artuska commented on issue #260: File becomes [object Object] in FormData
URL: 
https://github.com/apache/cordova-plugin-file/issues/260#issuecomment-438907238
 
 
   @Polypants in my case the reason why some Androids cannot select files from 
the file system and returns `null` is `cordova-plugin-deeplinks` plugin which 
requires this string in `config.xml` file:
   
   ```
   
   ```
   
   This preference ruins file select. I removed this line and file select is 
working now... but deeplinks are not working :) So you need to decide what you 
need most — file select of deeplinks on Android.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #547: Compatibility of old plugins with non-Java source-file entries

[GitBox]

brodybits commented on issue #547: Compatibility of old plugins with non-Java 
source-file entries
URL: https://github.com/apache/cordova-android/issues/547#issuecomment-438905081
 
 
   Payments plugin is not supported here. For payments problem please raise a 
new issue on the payments plugin and explain why it is not a duplicate.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] nagthgr8 commented on issue #547: Compatibility of old plugins with non-Java source-file entries

[GitBox]

nagthgr8 commented on issue #547: Compatibility of old plugins with non-Java 
source-file entries
URL: https://github.com/apache/cordova-android/issues/547#issuecomment-438900353
 
 
   Guys, can anyone help me understand why does build succeed on such breaking 
changes, the runtime failures are more disastrous! my app stopped taking 
payments since few days with the new cordova update


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #559: Ignore version file in eslint to resolve build error

[GitBox]

brodybits commented on issue #559: Ignore version file in eslint to resolve 
build error
URL: https://github.com/apache/cordova-android/pull/559#issuecomment-43302
 
 
   > That would involve updating the cordova-coho tool.
   
   I may be wrong here. Not sure if I would favor an extra eslint comment 
though. Build of `master` branch is green again, moving on.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits closed pull request #559: Ignore version file in eslint to resolve build error

[GitBox]

brodybits closed pull request #559: Ignore version file in eslint to resolve 
build error
URL: https://github.com/apache/cordova-android/pull/559
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/package.json b/package.json
index 418e349f6..a790addf1 100644
--- a/package.json
+++ b/package.json
@@ -26,7 +26,7 @@
 "java-unit-tests": "node test/run_java_unit_tests.js",
 "eslint": "run-s -c eslint:*",
 "eslint:scripts": "eslint bin spec test",
-"eslint:bins": "eslint 'bin/**/*' --ignore-pattern '**/*.*' 
--ignore-pattern '**/gitignore'"
+"eslint:bins": "eslint 'bin/**/*' --ignore-pattern '**/*.*' 
--ignore-pattern '**/gitignore' --ignore-pattern 
'bin/templates/cordova/version'"
   },
   "author": "Apache Software Foundation",
   "license": "Apache-2.0",


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-android] branch master updated: eslint ignore version file (#559)

[brodybits]

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-android.git


The following commit(s) were added to refs/heads/master by this push:
 new f1396c7  eslint ignore version file (#559)
f1396c7 is described below

commit f1396c7aad169445204638df32d086730f6ad691
Author: Chris Brody 
AuthorDate: Wed Nov 14 20:35:47 2018 -0500

eslint ignore version file (#559)

Quick workaround to resolve build error

needed since cordova-coho generates version file with double-quotes
---
 package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package.json b/package.json
index 418e349..a790add 100644
--- a/package.json
+++ b/package.json
@@ -26,7 +26,7 @@
 "java-unit-tests": "node test/run_java_unit_tests.js",
 "eslint": "run-s -c eslint:*",
 "eslint:scripts": "eslint bin spec test",
-"eslint:bins": "eslint 'bin/**/*' --ignore-pattern '**/*.*' 
--ignore-pattern '**/gitignore'"
+"eslint:bins": "eslint 'bin/**/*' --ignore-pattern '**/*.*' 
--ignore-pattern '**/gitignore' --ignore-pattern 
'bin/templates/cordova/version'"
   },
   "author": "Apache Software Foundation",
   "license": "Apache-2.0",


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #559: Ignore version file in eslint to resolve build error

[GitBox]

brodybits commented on issue #559: Ignore version file in eslint to resolve 
build error
URL: https://github.com/apache/cordova-android/pull/559#issuecomment-438883292
 
 
   Build is green, merging now


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] dpolivy commented on issue #417: Keyboard Dismissal Leaves Viewport Shifted in iOS 12 / XCode 10

[GitBox]

dpolivy commented on issue #417: Keyboard Dismissal Leaves Viewport Shifted in 
iOS 12 / XCode 10
URL: https://github.com/apache/cordova-ios/issues/417#issuecomment-438873097
 
 
   I'm seeing a potentially similar issue with `UIWebView` on iOS 12: if you 
are scrolled to the bottom of the page with an input field at the bottom and 
tap in it to open the keyboard, it covers the bottom of the page and does not 
scroll up like it used to on iOS 11 (and prior). As a result, the input field 
is completely covered by the keyboard and you can't see what you're typing. I 
don't know if this is related to the same root WebKit bug, but happy to open 
another issue if this should be treated separately.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #559: Ignore version file in eslint to resolve build error

[GitBox]

brodybits commented on issue #559: Ignore version file in eslint to resolve 
build error
URL: https://github.com/apache/cordova-android/pull/559#issuecomment-438869673
 
 
   Passes on Travis CI now, will watch for the result on AppVeyor. Hope we can 
get this finished soon.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #559: Ignore version file in eslint to resolve build error

[GitBox]

brodybits commented on issue #559: Ignore version file in eslint to resolve 
build error
URL: https://github.com/apache/cordova-android/pull/559#issuecomment-438866450
 
 
   > There might be an eslint ignore comment we can wrap around the version 
line to suppress the error?
   
   That would involve updating the cordova-coho tool. I would rather not spend 
time on updating cordova-coho right now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] dpogue commented on issue #559: Ignore version file in eslint to resolve build error

[GitBox]

dpogue commented on issue #559: Ignore version file in eslint to resolve build 
error
URL: https://github.com/apache/cordova-android/pull/559#issuecomment-438866164
 
 
   There might be an eslint ignore comment we can wrap around the version line 
to suppress the error?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits opened a new pull request #559: Ignore version file in eslint to resolve build error

[GitBox]

brodybits opened a new pull request #559: Ignore version file in eslint to 
resolve build error
URL: https://github.com/apache/cordova-android/pull/559
 
 
   This change should to give us a green build again.
   
   Rationale is that the eslint update introduced in 
393dad6349d8df55d8fca7d3e5014f36dfa4610c checks most of the files under `bin` 
and will not accept JavaScript that uses double-quotes for strings. The 
workaround in 393dad6349d8df55d8fca7d3e5014f36dfa4610c was to change the 
generated `bin/templates/cordova/version` file to use single-quotes in the 
version string.
   
   But since cordova-coho will regenerate `bin/templates/cordova/version` with 
double-quotes when updating the version number, we need a different solution.
   
   This is a quick workaround solution. I won't have a problem if anyone wants 
to propose an improved solution. Alternative may be to update cordova-coho to 
generate version file with single-quotes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits closed pull request #199: [WIP] Add previous patch dependency note

[GitBox]

brodybits closed pull request #199: [WIP] Add previous patch dependency note
URL: https://github.com/apache/cordova-coho/pull/199
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #555: [WIP] 7.1.3 patch updates - proposed WIP

[GitBox]

brodybits commented on issue #555: [WIP] 7.1.3 patch updates - proposed WIP
URL: https://github.com/apache/cordova-android/pull/555#issuecomment-438857403
 
 
   > I don't see #551 fix in the resulting changes
   
   Just added it, thanks for catching it!
   
   FYI This PR is still marked as WIP since I would like to test on a couple 
plugins before merging.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] jcesarmobile commented on issue #555: [WIP] 7.1.3 patch updates - proposed WIP

[GitBox]

jcesarmobile commented on issue #555: [WIP] 7.1.3 patch updates - proposed WIP
URL: https://github.com/apache/cordova-android/pull/555#issuecomment-438854815
 
 
   I don't see https://github.com/apache/cordova-android/pull/551 fix in the 
resulting changes


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

[GitBox]

brodybits commented on issue #550: Fix for old plugins with non-Java sources 
(GH-547)
URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438847411
 
 
   Thanks @jcesarmobile for the detailed review!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-android] 01/01: Merge pull request #550 from brodybits/gh-547-bugfix

[brodybits]

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-android.git

commit 21ae48eada2f1aebe970857c5d54eadcc91fd16d
Merge: 53e1c1b a67bc75
Author: Chris Brody 
AuthorDate: Wed Nov 14 17:44:31 2018 -0500

Merge pull request #550 from brodybits/gh-547-bugfix

Fix for old plugins with non-Java sources (GH-547)

 bin/templates/cordova/lib/pluginHandlers.js|  32 ---
 .../org.test.plugins.dummyplugin/plugin.xml|   6 ++
 .../src/android/jniLibs/x86/libnative.so   |   1 +
 .../src/android/myapi.aidl |   1 +
 .../src/android/mysettings.xml |   1 +
 .../src/android/other.extension|   1 +
 .../src/android/testaar2.aar   |   1 +
 .../src/android/testjar2.jar   |   1 +
 spec/unit/pluginHandlers/handlers.spec.js  | 100 +
 9 files changed, 116 insertions(+), 28 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits closed pull request #550: Fix for old plugins with non-Java sources (GH-547)

[GitBox]

brodybits closed pull request #550: Fix for old plugins with non-Java sources 
(GH-547)
URL: https://github.com/apache/cordova-android/pull/550
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bin/templates/cordova/lib/pluginHandlers.js 
b/bin/templates/cordova/lib/pluginHandlers.js
index f1b0dba02..794154b54 100644
--- a/bin/templates/cordova/lib/pluginHandlers.js
+++ b/bin/templates/cordova/lib/pluginHandlers.js
@@ -293,20 +293,28 @@ function generateAttributeError (attribute, element, id) {
 }
 
 function getInstallDestination (obj) {
-return studioPathRemap(obj) ||
-path.join(obj.targetDir, path.basename(obj.src));
-}
-
-function studioPathRemap (obj) {
-// If any source file is using the app new directory structure,
-// don't penalize it
-if (!obj.targetDir.includes('app')) {
-if (obj.src.endsWith('.java')) {
-return path.join('app/src/main/java', obj.targetDir.substring(4), 
path.basename(obj.src));
+var APP_MAIN_PREFIX = 'app/src/main';
+
+if (obj.targetDir.includes('app')) {
+// If any source file is using the new app directory structure,
+// don't penalize it
+return path.join(obj.targetDir, path.basename(obj.src));
+} else if (obj.src.endsWith('.java')) {
+return path.join(APP_MAIN_PREFIX, 'java', obj.targetDir.substring(4), 
path.basename(obj.src));
+} else if (obj.src.endsWith('.aidl')) {
+return path.join(APP_MAIN_PREFIX, 'aidl', obj.targetDir.substring(4), 
path.basename(obj.src));
+} else if (obj.targetDir.includes('libs')) {
+if (obj.src.endsWith('.so')) {
+return path.join(APP_MAIN_PREFIX, 'jniLibs', 
obj.targetDir.substring(5), path.basename(obj.src));
 } else {
-// For all other files, add 'app/src/main' to the targetDir if it 
didn't have it already
-return path.join('app/src/main', obj.targetDir, 
path.basename(obj.src));
+return path.join('app', obj.targetDir, path.basename(obj.src));
 }
+} else if (obj.targetDir.includes('src/main')) {
+return path.join('app', obj.targetDir, path.basename(obj.src));
+} else {
+// For all other source files not using the new app directory 
structure,
+// add 'app/src/main' to the targetDir
+return path.join(APP_MAIN_PREFIX, obj.targetDir, 
path.basename(obj.src));
 }
 
 }
diff --git a/spec/fixtures/org.test.plugins.dummyplugin/plugin.xml 
b/spec/fixtures/org.test.plugins.dummyplugin/plugin.xml
index b299b645a..4e2ebcc6c 100644
--- a/spec/fixtures/org.test.plugins.dummyplugin/plugin.xml
+++ b/spec/fixtures/org.test.plugins.dummyplugin/plugin.xml
@@ -76,6 +76,12 @@
 target-dir="app/libs" />
 
+
+
+   
+   
+   
+   
 
 
 
diff --git 
a/spec/fixtures/org.test.plugins.dummyplugin/src/android/jniLibs/x86/libnative.so
 
b/spec/fixtures/org.test.plugins.dummyplugin/src/android/jniLibs/x86/libnative.so
new file mode 100644
index 0..421376db9
--- /dev/null
+++ 
b/spec/fixtures/org.test.plugins.dummyplugin/src/android/jniLibs/x86/libnative.so
@@ -0,0 +1 @@
+dummy
diff --git a/spec/fixtures/org.test.plugins.dummyplugin/src/android/myapi.aidl 
b/spec/fixtures/org.test.plugins.dummyplugin/src/android/myapi.aidl
new file mode 100644
index 0..421376db9
--- /dev/null
+++ b/spec/fixtures/org.test.plugins.dummyplugin/src/android/myapi.aidl
@@ -0,0 +1 @@
+dummy
diff --git 
a/spec/fixtures/org.test.plugins.dummyplugin/src/android/mysettings.xml 
b/spec/fixtures/org.test.plugins.dummyplugin/src/android/mysettings.xml
new file mode 100644
index 0..421376db9
--- /dev/null
+++ b/spec/fixtures/org.test.plugins.dummyplugin/src/android/mysettings.xml
@@ -0,0 +1 @@
+dummy
diff --git 
a/spec/fixtures/org.test.plugins.dummyplugin/src/android/other.extension 
b/spec/fixtures/org.test.plugins.dummyplugin/src/android/other.extension
new file mode 100644
index 0..421376db9
--- /dev/null
+++ b/spec/fixtures/org.test.plugins.dummyplugin/src/android/other.extension
@@ -0,0 +1 @@
+dummy
diff --git 
a/spec/fixtures/org.test.plugins.dummyplugin/src/android/testaar2.aar 
b/spec/fixtures/org.test.plugins.dummyplugin/src/android/testaar2.aar
new file mode 100644
index 0..421376db9
--- /dev/null
+++ b/spec/fixtures/org.test.plugins.dummyplugin/src/android/testaar2.aar
@@ -0,0 +1 @@
+dummy
diff --git 
a/spec/fixtures/org.test.plugins.dummyplugin/src/android/testjar2.jar 
b/spec/fixtures/org.test.plugins.dummyplugin/src/android/testjar2.jar
new file mode 100644
index 0..421376db9
--- /dev/null
+++ b/spec/fixtures/org.test.plugins.dummyplugin/src/android/testjar2.jar
@@ -0,0 +1 @@
+dummy
diff --git a/spec/unit/pluginHandlers/handle

[cordova-android] branch master updated (53e1c1b -> 21ae48e)

[brodybits]

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-android.git.


from 53e1c1b  Set version & VERSION to 8.0.0-dev (coho)
 add 9d03e4e  Fix tests of plugin files with new app dir scheme
 add 578a642  Check target-dir mapping of plugin xml source file
 add 92f07d0  Check old compat of other extension (CB-14125)
 add bbb3913  Test old plugin aidl & lib mapping - repros GH-547
 add 21f8473  Cleanup getInstallDestination in pluginHandlers.js
 add 895ab0c  Fix comments in getInstallDestination
 add a67bc75  GH-547 Fix for old plugins with non-Java sources
 new 21ae48e  Merge pull request #550 from brodybits/gh-547-bugfix

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 bin/templates/cordova/lib/pluginHandlers.js|  32 ---
 .../org.test.plugins.dummyplugin/plugin.xml|   6 ++
 .../src/android/jniLibs/x86/libnative.so   |   1 +
 .../src/android/myapi.aidl |   1 +
 .../src/android/mysettings.xml |   1 +
 .../src/android/other.extension|   1 +
 .../src/android/testaar2.aar   |   1 +
 .../src/android/testjar2.jar   |   1 +
 spec/unit/pluginHandlers/handlers.spec.js  | 100 +
 9 files changed, 116 insertions(+), 28 deletions(-)
 create mode 100644 
spec/fixtures/org.test.plugins.dummyplugin/src/android/jniLibs/x86/libnative.so
 create mode 100644 
spec/fixtures/org.test.plugins.dummyplugin/src/android/myapi.aidl
 create mode 100644 
spec/fixtures/org.test.plugins.dummyplugin/src/android/mysettings.xml
 create mode 100644 
spec/fixtures/org.test.plugins.dummyplugin/src/android/other.extension
 create mode 100644 
spec/fixtures/org.test.plugins.dummyplugin/src/android/testaar2.aar
 create mode 100644 
spec/fixtures/org.test.plugins.dummyplugin/src/android/testjar2.jar


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #558: Mark 8.0.0-dev & update cordova.js

[GitBox]

brodybits commented on issue #558: Mark 8.0.0-dev & update cordova.js
URL: https://github.com/apache/cordova-android/pull/558#issuecomment-438845851
 
 
   > Why is a PR with failing tests being merged?
   
   It is a build error, no actually failing tests.
   
   I deleted my branch right after merge, that is what caused the failure. I 
didn't see the failure.
   
   I tried restoring my branch and restarting the build a couple times. 
Unfortunately it didn't seem to work. It should go green in the next merge.
   
   > Why does this PR contain a lot more than it says in the PR title?
   
   I just updated the title.
   
   Purpose was only to mark 8.0.0-dev. But the procedure involves regenerating 
cordova.js, and I wanted to do that in a couple smaller steps, to avoid 
excessive changes combined in a single commit.
   
   > Why does this PR refer to a WIP and unmerged coho PR?
   
   I have some enhancements that help me update cordova.js from a specific 
cordova-js version. There is quite a bit of review feedback on the PR and I did 
not a chance to process it. I just updated the description with some more info.
   
   Alternative would be to close the WIP PR on cordova-coho and use my own 
fork, without giving record of what commands I used to do the update.
   
   I will admit that this update did not go quite right, not much we can do now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #194: onDestroy and dealloc ambiguity

[GitBox]

janpio commented on issue #194: onDestroy  and dealloc ambiguity
URL: 
https://github.com/apache/cordova-plugin-media/issues/194#issuecomment-438839380
 
 
   Yes, that sounds very reasonable. 
   Maybe an additional 
[`MediaError`](https://github.com/apache/cordova-plugin-media#mediaerror)?
   Is there any handling of such cases in the code base already?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #558: Mark 8.0.0-dev

[GitBox]

janpio commented on issue #558: Mark 8.0.0-dev
URL: https://github.com/apache/cordova-android/pull/558#issuecomment-438837496
 
 
   Why is a PR with failing tests being merged?
   Why does this PR contain a lot more than it says in the PR title?
   Why does this PR refer to a WIP and unmerged coho PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits closed pull request #558: Mark 8.0.0-dev

[GitBox]

brodybits closed pull request #558: Mark 8.0.0-dev
URL: https://github.com/apache/cordova-android/pull/558
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/VERSION b/VERSION
index 7e4568592..e4be07b06 100644
--- a/VERSION
+++ b/VERSION
@@ -1 +1 @@
-7.2.0-dev
+8.0.0-dev
diff --git a/bin/templates/cordova/version b/bin/templates/cordova/version
index 23e837672..01229aa6d 100755
--- a/bin/templates/cordova/version
+++ b/bin/templates/cordova/version
@@ -20,7 +20,7 @@
 */
 
 // Coho updates this line:
-var VERSION = '7.2.0-dev';
+var VERSION = "8.0.0-dev";
 
 module.exports.version = VERSION;
 
diff --git a/bin/templates/project/assets/www/cordova.js 
b/bin/templates/project/assets/www/cordova.js
index 3ae354cd8..4cdb1e3e5 100644
--- a/bin/templates/project/assets/www/cordova.js
+++ b/bin/templates/project/assets/www/cordova.js
@@ -1,5 +1,5 @@
 // Platform: android
-// 4450a4cea50616e080a82e8ede9e3d6a1fe3c3ec
+// e040d9e9343d5f27dd4f67616660b33b92a82ff7
 /*
  Licensed to the Apache Software Foundation (ASF) under one
  or more contributor license agreements.  See the NOTICE file
@@ -19,9 +19,11 @@
  under the License.
 */
 ;(function() {
-var PLATFORM_VERSION_BUILD_LABEL = '7.2.0-dev';
+var PLATFORM_VERSION_BUILD_LABEL = '8.0.0-dev';
 // file: src/scripts/require.js
 
+/* jshint -W079 */
+/* jshint -W020 */
 
 var require;
 var define;
@@ -305,6 +307,7 @@ var cordova = {
 } catch (err) {
 var msg = 'Error in ' + (isSuccess ? 'Success' : 'Error') + ' 
callbackId: ' + callbackId + ' : ' + err;
 console && console.log && console.log(msg);
+console && console.log && err.stack && console.log(err.stack);
 cordova.fireWindowEvent('cordovacallbackerror', { 'message': msg 
});
 throw err;
 }
@@ -324,7 +327,7 @@ module.exports = cordova;
 
 });
 
-// file: 
/Users/steveng/repo/cordova/cordova-android/cordova-js-src/android/nativeapiprovider.js
+// file: 
/Users/brodybits/Documents/cordova/cordova-android/cordova-js-src/android/nativeapiprovider.js
 define("cordova/android/nativeapiprovider", function(require, exports, module) 
{
 
 /**
@@ -347,7 +350,7 @@ module.exports = {
 
 });
 
-// file: 
/Users/steveng/repo/cordova/cordova-android/cordova-js-src/android/promptbasednativeapi.js
+// file: 
/Users/brodybits/Documents/cordova/cordova-android/cordova-js-src/android/promptbasednativeapi.js
 define("cordova/android/promptbasednativeapi", function(require, exports, 
module) {
 
 /**
@@ -879,7 +882,7 @@ module.exports = channel;
 
 });
 
-// file: /Users/steveng/repo/cordova/cordova-android/cordova-js-src/exec.js
+// file: 
/Users/brodybits/Documents/cordova/cordova-android/cordova-js-src/exec.js
 define("cordova/exec", function(require, exports, module) {
 
 /**
@@ -972,17 +975,6 @@ function androidExec(success, fail, service, action, args) 
{
 }
 
 androidExec.init = function() {
-//CB-11828
-//This failsafe checks the version of Android and if it's Jellybean, it 
switches it to
-//using the Online Event bridge for communicating from Native to JS
-//
-//It's ugly, but it's necessary.
-var check = 
navigator.userAgent.toLowerCase().match(/android\s[0-9].[0-9]/);
-var version_code = check && check[0].match(/4.[0-3].*/);
-if (version_code != null && nativeToJsBridgeMode == 
nativeToJsModes.EVAL_BRIDGE) {
-  nativeToJsBridgeMode = nativeToJsModes.ONLINE_EVENT;
-}
-
 bridgeSecret = +prompt('', 'gap_init:' + nativeToJsBridgeMode);
 channel.onNativeReady.fire();
 };
@@ -1637,7 +1629,7 @@ exports.reset();
 
 });
 
-// file: /Users/steveng/repo/cordova/cordova-android/cordova-js-src/platform.js
+// file: 
/Users/brodybits/Documents/cordova/cordova-android/cordova-js-src/platform.js
 define("cordova/platform", function(require, exports, module) {
 
 // The last resume event that was received that had the result of a plugin 
call.
@@ -1747,7 +1739,7 @@ function onMessageFromNative(msg) {
 
 });
 
-// file: 
/Users/steveng/repo/cordova/cordova-android/cordova-js-src/plugin/android/app.js
+// file: 
/Users/brodybits/Documents/cordova/cordova-android/cordova-js-src/plugin/android/app.js
 define("cordova/plugin/android/app", function(require, exports, module) {
 
 var exec = require('cordova/exec');
diff --git a/framework/build.gradle b/framework/build.gradle
index de8451d11..520b0868c 100644
--- a/framework/build.gradle
+++ b/framework/build.gradle
@@ -44,7 +44,7 @@ apply plugin: 'com.github.dcendents.android-maven'
 apply plugin: 'com.jfrog.bintray'
 
 group = 'org.apache.cordova'
-version = '7.2.0-dev'
+version = '8.0.0-dev'
 
 android {
 compileSdkVersion cdvCompileSdkVersion
@@ -131,9 +131,9 @@ bintray {
 licenses = ['Apache-2.0']
 labels = ['android', 

[cordova-android] branch master updated (7eed65e -> 53e1c1b)

[brodybits]

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-android.git.


from 7eed65e  GH-552 (android) check for build-extras.gradle in the 
app-parent directory (#553)
 add cf5a02e  Update cordova.js from cordova-js@4.2.3
 add 5c334b6  CB-9366 cordova.js log error.stack (cordova-js@4.2.4)
 add 858611f  Update JS to version 8.0.0-dev (via coho)
 add 53e1c1b  Set version & VERSION to 8.0.0-dev (coho)

No new revisions were added by this update.

Summary of changes:
 VERSION|  2 +-
 bin/templates/cordova/version  |  2 +-
 bin/templates/project/assets/www/cordova.js| 28 --
 framework/build.gradle |  6 ++---
 .../src/org/apache/cordova/CordovaWebView.java |  2 +-
 package.json   |  2 +-
 6 files changed, 17 insertions(+), 25 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits opened a new pull request #558: Mark 8.0.0-dev

[GitBox]

brodybits opened a new pull request #558: Mark 8.0.0-dev
URL: https://github.com/apache/cordova-android/pull/558
 
 
   According to the following steps taken, using local checkout of cordova-coho 
with `improve-patch-and-dev-version-support` branch as proposed in 
:
   
   * Update cordova.js from cordova-js@4.2.3, which includes GH-534: Remove 
obsolete check for JellyBean to work properly on Android Pie:
   
   ```sh
   ./cordova-coho/coho copy-js -r android --js 4.2.3
   ```
   
   * Update cordova.js from cordova-js@4.2.4, which includes CB-9366 cordova.js 
log error.stack:
   
   ```sh
   ./cordova-coho/coho copy-js -r android --js 4.2.4
   ```
   
   * Update cordova.js, version, and VERSION to 8.0.0-dev:
   
   ```sh
   ./cordova-coho/coho prepare-platform-release-branch --version 8.0.0-dev -r 
android --js 4.2.4
   ```
   
   Will be merged by push to master.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] Polypants commented on issue #260: File becomes [object Object] in FormData

[GitBox]

Polypants commented on issue #260: File becomes [object Object] in FormData
URL: 
https://github.com/apache/cordova-plugin-file/issues/260#issuecomment-438802756
 
 
   @artuska how exactly did you do that? I'm dealing with the same issue


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] wspresto commented on issue #194: onDestroy and dealloc ambiguity

[GitBox]

wspresto commented on issue #194: onDestroy  and dealloc ambiguity
URL: 
https://github.com/apache/cordova-plugin-media/issues/194#issuecomment-438801783
 
 
   Correct. That is what was happening in my situation which was causing a bug 
in my use case.
   I personally do not believe the plugin should trigger the success playback 
if the OS _pulls the rugs_ so to speak. However, the case could be made where 
someone would want client code to be triggered in response to this event. 
   Maybe, instead of triggering a state change -> MEDIA_STOPPED during destroy 
(android) or dealloc events (ios) , the plugin would throw a new type of error. 
That way, the client code gets a chance to respond to a destroyed event, and 
any code in the success callback can keep assuming that a successful state 
change to MEDIA_STOPPED occurred.
   Thoughts?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] shokry055 commented on issue #120: When getting location does'nt return anything or return empty error with a timeout (Android Oreo)

[GitBox]

shokry055 commented on issue #120: When getting location does'nt return 
anything or return empty error with a timeout (Android Oreo)
URL: 
https://github.com/apache/cordova-plugin-geolocation/issues/120#issuecomment-438794450
 
 
   +1


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] shokry055 commented on issue #119: Getting location with high accuracy taking time more than 4 mins

[GitBox]

shokry055 commented on issue #119: Getting location with high accuracy taking 
time more than 4 mins 
URL: 
https://github.com/apache/cordova-plugin-geolocation/issues/119#issuecomment-438794348
 
 
   same here i takes more than 3 minutes 
   or return code 3 TO


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

[GitBox]

brodybits commented on issue #550: Fix for old plugins with non-Java sources 
(GH-547)
URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438788760
 
 
   @janpio I was thinking to do a merge commit to keep the cleanup changes 
separate from the behavior change. I think it makes it easier to understand, 
and less to potentially revert just in case. If anyone has objections please do 
not hesitate.
   
   In general I have been testing the changes on both master and 7.1.x to help 
ensure the patch goes smoothly. Proposal for patch updates in #555 is marked 
WIP to avoid a premature merge. In case this PR is not merged for some reason 
it would be really easy to remove the unwanted commits from #555.
   
   Considering that this change has gone through review and is waiting for 
final approval, I would like to get it into the upcoming patch if possible. I 
think it would be a major benefit for a number of existing plugins. I hope we 
can merge and release soon. I put some client work on hold, at personal cost, 
in order to make the fixes and get some plugins working again.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] datamystic closed issue #187: Dies under iPhone XHR

[GitBox]

datamystic closed issue #187: Dies under iPhone XHR
URL: https://github.com/apache/cordova-plugin-media/issues/187
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-lib] branch azure-pipelines updated (4fa827a -> 6dc2051)

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a change to branch azure-pipelines
in repository https://gitbox.apache.org/repos/asf/cordova-lib.git.


 discard 4fa827a  add job on macOS
 discard 20f2fec  extract steps to own file
 discard 9c98b80  add another newline at the end to trigger another CI run
 discard a5974a1  nicer matrix labels
 discard a04a447  Create azure-pipelines.yml
 add 3079853  Dereference possible symlinks when copying plugin (#705)
 add 21cf61b  Add unit tests for `Context#requireCordovaModule`
 add 1fdc38d  Fix for module names that start with "cordova-lib"
 add 27a2cfd  Emit deprecation warning when requiring non-cordova modules
 add 74ffd92  Update JSDoc and clarify inline comments
 add 81439dc  Merge pull request #707 from 
raphinesse/deprecate-requireCordovaModule
 add 58aa9f7  CB-7078 Rewrite disabled test for serve as unit test
 add 17938d8  Fix globby usage in cordova/serve
 add a8f04e5  Add failing test resulting in pending promise
 add 3ed7530  Correctly reject promise when failing
 add 1ae1562  Use `md5-file` to calculate MD5 sum of files
 add 5a178d1  Refactor platform serve handler & add tests
 add 5bb3849  Simplify absolute path handler
 add 26ade93  Render index page from a template
 add 7163cd7  Make use of express default 404
 add be8fdff  Improve testability of main export
 add d1becda  Improve tests after improving testability
 add 9f6fadd  Organize imports
 add f41b829  Add failing test for handling failed server launch
 add 36ce5a5  Fix waiting for launched server
 add ba90e39  Merge pull request #687 from raphinesse/to-serve-and-protect
 add 9c3ce13  Replace leftover usage of Q's instance API
 add ce99066  Search and replace usage of Q's static API
 add 86394db  Fix linting error `prefer-promise-reject-errors`
 add 7681351  Replace `Q.delay` with npm package `delay`
 add eb9aa97  Use `superspawn` to get rid of `Q.defer` in plugman/install
 add af1a1b5  Rewrite cordova/requirements to get rid of `Q.allSettled`
 add 4701dcb  Add ESLint rule against unhandled promises
 add ddac33d  Fix some unhandled promises
 add 54a9b3d  Remove Q :tada:
 add 53b2ebb  Merge pull request #710 from raphinesse/q-nomore
 add 17508a7  Fix 2 integration tests failures on macOS
 add a76667d  remove JIRA link
 add b5cf8d7  Create azure-pipelines.yml
 add a7989f6  nicer matrix labels
 add 80f2e15  add another newline at the end to trigger another CI run
 add a2ca69b  extract steps to own file
 add 6dc2051  add job on macOS

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (4fa827a)
\
 N -- N -- N   refs/heads/azure-pipelines (6dc2051)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

No new revisions were added by this update.

Summary of changes:
 .eslintrc.yml |   1 +
 README.md |   2 -
 integration-tests/HooksRunner.spec.js |  12 +-
 integration-tests/pkgJson.spec.js |   2 +-
 integration-tests/plugin.spec.js  |   5 +-
 integration-tests/plugman_fetch.spec.js   |  11 +-
 integration-tests/plugman_uninstall.spec.js   |   9 +-
 package.json  |   3 +-
 spec/cordova/build.spec.js|   9 +-
 spec/cordova/compile.spec.js  |   7 +-
 spec/cordova/emulate.spec.js  |  13 +-
 spec/cordova/platform/addHelper.spec.js   |  23 +-
 spec/cordova/platform/check.spec.js   |  14 +-
 spec/cordova/platform/list.spec.js|   3 +-
 spec/cordova/platform/platform.spec.js|   3 +-
 spec/cordova/platform/remove.spec.js  |   3 +-
 spec/cordova/plugin/add.spec.js   |  21 +-
 spec/cordova/plugin/list.spec.js  |   9 +-
 spec/cordova/plugin/remove.spec.js|   9 +-
 spec/cordova/prepare.spec.js  |  17 +-
 spec/cordova/run.spec.js  |  17 +-
 spec/cordova/serve.spec.js| 495 +++---
 spec/helpers.js   |  26 +-
 spec/hooks/Context.spec.js| 108 +
 spec/plugman/install.spec.js  |  36 +-
 src/cordova/build.js 

[GitHub] janpio commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

[GitBox]

janpio commented on issue #550: Fix for old plugins with non-Java sources 
(GH-547)
URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438779027
 
 
   How can you add a non-merged PR to a new PR? 
   Did you just cherry pick the individual commits? 
   If so, I would advise against that (which would act as a "do not merge" 
blocker on the other PR) as you do not really know if this PR will be merged 
that way - especially as this one here should probably be squashed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #194: onDestroy and dealloc ambiguity

[GitBox]

janpio commented on issue #194: onDestroy  and dealloc ambiguity
URL: 
https://github.com/apache/cordova-plugin-media/issues/194#issuecomment-438778052
 
 
   Ok, now I think I understand - the plugin could report "playback 
successfully finished" to the web app even though the OS pulled the rug under 
the plugin, correct? 
   What could be a reason for Android to do that?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] wspresto commented on issue #194: onDestroy and dealloc ambiguity

[GitBox]

wspresto commented on issue #194: onDestroy  and dealloc ambiguity
URL: 
https://github.com/apache/cordova-plugin-media/issues/194#issuecomment-438776438
 
 
   Sure. 
   For Android specifically, When the success callback is triggered, there is 
client JavaScript code that is executed on the WebCore thread. This JS code is 
unaware of the _reason_ why the success callback was triggered.  The reason 
could be either that the playback has ended because EOF was reached, **OR** 
that the underlying Operating System signaled the activity to be "destroyed".
   
   These are 2 distinct reasons that both trigger the success callback equally. 
I will be submitting a PR shortly in order to suggest a solution, but I wanted 
to get feedback first.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-lib] branch azure-pipelines updated (501c9ab -> 4fa827a)

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a change to branch azure-pipelines
in repository https://gitbox.apache.org/repos/asf/cordova-lib.git.


omit 501c9ab  add job on macOS
 add 4fa827a  add job on macOS

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (501c9ab)
\
 N -- N -- N   refs/heads/azure-pipelines (4fa827a)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

No new revisions were added by this update.

Summary of changes:
 azure-pipelines/steps.yml | 40 +---
 1 file changed, 21 insertions(+), 19 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-lib] branch azure-pipelines updated (f0a73ad -> 501c9ab)

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a change to branch azure-pipelines
in repository https://gitbox.apache.org/repos/asf/cordova-lib.git.


 discard f0a73ad  add job on macOS
 add 501c9ab  add job on macOS

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (f0a73ad)
\
 N -- N -- N   refs/heads/azure-pipelines (501c9ab)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

No new revisions were added by this update.

Summary of changes:


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-lib] branch azure-pipelines updated (9c98b80 -> f0a73ad)

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a change to branch azure-pipelines
in repository https://gitbox.apache.org/repos/asf/cordova-lib.git.


from 9c98b80  add another newline at the end to trigger another CI run
 add 20f2fec  extract steps to own file
 add f0a73ad  add job on macOS

No new revisions were added by this update.

Summary of changes:
 azure-pipelines.yml   | 51 ---
 azure-pipelines/steps.yml | 23 +
 2 files changed, 40 insertions(+), 34 deletions(-)
 create mode 100644 azure-pipelines/steps.yml


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

[GitBox]

brodybits commented on issue #550: Fix for old plugins with non-Java sources 
(GH-547)
URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438768035
 
 
   I just added these changes to PR #555 on 7.x for a patch release, hope we 
can make it soon!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio edited a comment on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

[GitBox]

janpio edited a comment on issue #110: Cordova Status Bar Plugin hides the 
input when the keyboard appears
URL: 
https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-438766049
 
 
   Best minimize the HTML as well so it is really just the needed elements then 
please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

[GitBox]

janpio commented on issue #110: Cordova Status Bar Plugin hides the input when 
the keyboard appears
URL: 
https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-438766049
 
 
   Best minimize the HTML as well so it is really just the needed elements then 
please.-


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio edited a comment on issue #194: onDestroy and dealloc ambiguity

[GitBox]

janpio edited a comment on issue #194: onDestroy  and dealloc ambiguity
URL: 
https://github.com/apache/cordova-plugin-media/issues/194#issuecomment-438765687
 
 
   We are always open for Pull Requests improving the plugin.
   
   That being said, I don't really understand what currently doesn't work as 
documented, intended or wanted. Could you describe a usecase where what you 
describe matters? What platform are you talking about?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #194: onDestroy and dealloc ambiguity

[GitBox]

janpio commented on issue #194: onDestroy  and dealloc ambiguity
URL: 
https://github.com/apache/cordova-plugin-media/issues/194#issuecomment-438765687
 
 
   We are always open for Pull Requests improving the plugin.
   
   That being said, I don't really understand what currently doesn't work as 
documented, intended or wanted. Could you describe a usecase where what you 
describe matters?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

[GitBox]

brodybits commented on issue #550: Fix for old plugins with non-Java sources 
(GH-547)
URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438765761
 
 
   Just removed the comment, my bad.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] jcesarmobile commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

[GitBox]

jcesarmobile commented on issue #550: Fix for old plugins with non-Java sources 
(GH-547)
URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438762849
 
 
   I still see the thanks comment&link, can you remove it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] Kasun002 opened a new issue #121: Askin permission when need

[GitBox]

Kasun002 opened a new issue #121: Askin permission when need
URL: https://github.com/apache/cordova-plugin-geolocation/issues/121
 
 
   Iam using this plugin with this permission
   
   
   
   
   
   how to ask permission when we need only.
   
   In my situation it ask location when app initally load


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] wspresto opened a new issue #194: onDestroy and dealloc ambiguity

[GitBox]

wspresto opened a new issue #194: onDestroy  and dealloc ambiguity
URL: https://github.com/apache/cordova-plugin-media/issues/194
 
 
   Currently, it is impossible for client code to interpret the state or event 
in which the underlying native Media object has been destroyed when the OS is 
terminating the activity / process. This is a short coming of the plugin, 
because the success callback is called without any indication that the entire 
activity or process was stopped abruptly. In other worse, the MEDIA_STOPPED 
state is too _ambiguous_ . I would like to request a solution to resolve this 
ambiguity. 
   
   There is no way for the plugin to indicate to the client code that the 
underlying OS is terminating the the process. Please provide a way for client 
code to discern the difference between OS forcefully stopping the media and the 
media stopping because it has successfully reached the end of playback.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

[GitBox]

brodybits commented on issue #550: Fix for old plugins with non-Java sources 
(GH-547)
URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438732150
 
 
   > `app/src/main` is used multiple times, might be worth to put it in a 
variable
   
   Done. CanI get a final approval to merge?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

[GitBox]

tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input 
when the keyboard appears
URL: 
https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-438724335
 
 
   Yeah without the status bar plugin, I get the same result as the browser :)
   Actually I just got the html from the designer and the cordova project had 
only this plugin enabled :) :)
   
   I'll do what you've asked soon and post a link here!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

[GitBox]

brodybits commented on issue #550: Fix for old plugins with non-Java sources 
(GH-547)
URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438714101
 
 
   I think the primary rule should be to place files based on target-dir 
prefix, i.e. `app` vs `src` vs `lib`, and extensions should be treated as 
special cases. This is basically how it is implemented in this PR.
   
   I would rather not make a special case for `.h` and `.c` files since 
cordova-android does not need to do anything with them. Use of `.h` and `.c` 
files should remain plugin-specific, plugin provides its own Gradle file to 
handle them.
   
   For example:  specifies 
the native build with `.h` and `.c` files in the following places:
   * 
 
to use `build-extras.gradle` (probably should have been a `framework` element)
   * 

 to use `Android.mk`
   * 

[GitHub] brodybits opened a new issue #557: Inconsistent installation of NDK .so files

[GitBox]

brodybits opened a new issue #557: Inconsistent installation of NDK .so files
URL: https://github.com/apache/cordova-android/issues/557
 
 
   For JAR files I can think of the following options:
   * `source-file` element with `libs` or `app/libs` target dir
   * `lib-file` element
   
   AFAIK for NDK `.so` the plugin has to use a `source-file` element, with 
target-dir in `app/src/main/jniLibs` for it to work (may be changed by PR #550).
   
   I would like to see the following fixes:
   * possible to use `lib-file` for both JAR and `.so`
   * `.so` files should work from a subdirectory of `libs` or `app/libs` (`.so` 
files should **not** have to be installed in subdirectory of `app/src`)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #907: browser platform is missing from sections

[GitBox]

janpio commented on issue #907: browser platform is missing from sections
URL: https://github.com/apache/cordova-docs/issues/907#issuecomment-438692446
 
 
   Is `browser` really a fully supported platform? 
   Is plugin support good enough?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits opened a new issue #908: Platform Centered Workflow missing for macOS ("osx")

[GitBox]

brodybits opened a new issue #908: Platform Centered Workflow missing for macOS 
("osx")
URL: https://github.com/apache/cordova-docs/issues/908
 
 
   
   
   **Issue Type**
   [x] Bug
   [ ] Feature Request
   
   **Priority**
   [x] Minor 
   [ ] Major 
   [ ] Critical 
   [ ] Blocker 
   
   **Environment**
   * OS: macOS ("osx")
   * Browser: WebKit
   
   **Description**
   
   See title


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits opened a new issue #907: browser platform is missing from sections

[GitBox]

brodybits opened a new issue #907: browser platform is missing from sections
URL: https://github.com/apache/cordova-docs/issues/907
 
 
   
   
   **Issue Type**
   [x] Bug
   [ ] Feature Request
   
   **Priority**
   [ ] Minor 
   [x] Major 
   [ ] Critical 
   [ ] Blocker 
   
   **Environment**
   * OS: desktop
   * Browser: WebKit
   
   **Description**
   
   browser platform is missing from the following sections:
   
   * "Platform Support" table in 

   * "Develop for platform" pages


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-docs] branch brodybits-ios-create-docfix created (now e9017e7)

[brodybits]

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a change to branch brodybits-ios-create-docfix
in repository https://gitbox.apache.org/repos/asf/cordova-docs.git.


  at e9017e7  Remove incorrect info for cordova-ios-bin/create

This branch includes the following new commits:

 new e9017e7  Remove incorrect info for cordova-ios-bin/create

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits opened a new pull request #906: Remove incorrect info for cordova-ios-bin/create

[GitBox]

brodybits opened a new pull request #906: Remove incorrect info for 
cordova-ios-bin/create
URL: https://github.com/apache/cordova-docs/pull/906
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-docs] 01/01: Remove incorrect info for cordova-ios-bin/create

[brodybits]

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a commit to branch brodybits-ios-create-docfix
in repository https://gitbox.apache.org/repos/asf/cordova-docs.git

commit e9017e75c80a9749f26ce1b93166f5a36879703a
Author: Chris Brody 
AuthorDate: Wed Nov 14 09:51:42 2018 -0500

Remove incorrect info for cordova-ios-bin/create
---
 www/docs/en/dev/guide/platforms/ios/index.md | 2 --
 1 file changed, 2 deletions(-)

diff --git a/www/docs/en/dev/guide/platforms/ios/index.md 
b/www/docs/en/dev/guide/platforms/ios/index.md
index 8f38269..171afc8 100644
--- a/www/docs/en/dev/guide/platforms/ios/index.md
+++ b/www/docs/en/dev/guide/platforms/ios/index.md
@@ -293,8 +293,6 @@ $ cordova-ios/bin/run
 
 The created project will have a folder named `cordova` inside that contains
 scripts for the project-specific Cordova commands (e.g. `run`, `build`, etc.).
-Additionally, The project will feature a structure different from that of a
-normal Cordova project. Notably, `/www` is moved to `/assets/www`.
 
 To install plugins in this project, use the [Cordova Plugman 
Utility](../../../plugin_ref/plugman.html).
 


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] thepianist2 edited a comment on issue #417: Keyboard Dismissal Leaves Viewport Shifted in iOS 12 / XCode 10

[GitBox]

thepianist2 edited a comment on issue #417: Keyboard Dismissal Leaves Viewport 
Shifted in iOS 12 / XCode 10
URL: https://github.com/apache/cordova-ios/issues/417#issuecomment-438682821
 
 
   My solution was use a plugin or any thing to detect the event on keyboard 
native hide, and on this moment execute script to normalize the height of the 
app.
   
   https://github.com/cjpearson/cordova-plugin-keyboard
   
   ```
   //install the plugin
   cordova plugin add cordova-plugin-keyboard
   
   //on the .js file detect the event and apply the normal height in the event 
the keyboard will hide.
   window.addEventListener('keyboardWillHide', function () {
 document.getElementsByTagName('html')[0].style.height = '101vh';
 setTimeout(()=>{
   document.getElementsByTagName('html')[0].style.height = '100vh';
 }, 40);
   });
   ```
   
   for the time being


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] uerceg commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update

[GitBox]

uerceg commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update
URL: https://github.com/apache/cordova-android/issues/554#issuecomment-438684410
 
 
   Awesome. Thank you very much, will keep an eye on 7.1.3 official release and 
update plugin and docs accordingly.
   
   Cheers! 🍺 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update

[GitBox]

brodybits commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 
update
URL: https://github.com/apache/cordova-android/issues/554#issuecomment-438684105
 
 
   > Is there a way to declare paths in `plugin.xml` in a way that it supports 
both, `cordova-android@6` and `cordova-android@7`?
   
   Once PR #550 is merged, it should just work if you revert 
.
   
   PR #550 was raised due to the large number of plugins that were broken by 
the 7.0.0 release.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] thepianist2 edited a comment on issue #417: Keyboard Dismissal Leaves Viewport Shifted in iOS 12 / XCode 10

[GitBox]

thepianist2 edited a comment on issue #417: Keyboard Dismissal Leaves Viewport 
Shifted in iOS 12 / XCode 10
URL: https://github.com/apache/cordova-ios/issues/417#issuecomment-438682821
 
 
   My solution was use a plugin or any thing to detect the event on keyboard 
native hide, and on this moment execute script to normalize the height of the 
app.
   
   https://github.com/cjpearson/cordova-plugin-keyboard
   
   ```
   //install the plugin
   cordova plugin add cordova-plugin-keyboard
   
   //on the .js file detect the event and apply the normal height in the event 
the keyboard will hide.
   window.addEventListener('keyboardWillHide', function () {
 document.getElementsByTagName('html')[0].style.height = '101vh';
 setTimeout(()=>{
   document.getElementsByTagName('html')[0].style.height = '100vh';
 }, 40);
   });
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] thepianist2 commented on issue #417: Keyboard Dismissal Leaves Viewport Shifted in iOS 12 / XCode 10

[GitBox]

thepianist2 commented on issue #417: Keyboard Dismissal Leaves Viewport Shifted 
in iOS 12 / XCode 10
URL: https://github.com/apache/cordova-ios/issues/417#issuecomment-438682821
 
 
   My solution was use a plugin or any thing to detect the event on keyboard 
native hide, and on this moment execute script to normalize the height of the 
app.
   
   
   ```
   //install the plugin
   cordova plugin add cordova-plugin-keyboard
   
   //on the .js file detect the event and apply the normal height in the event 
the keyboard will hide.
   window.addEventListener('keyboardWillHide', function () {
 document.getElementsByTagName('html')[0].style.height = '101vh';
 setTimeout(()=>{
   document.getElementsByTagName('html')[0].style.height = '100vh';
 }, 40);
   });
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] uerceg commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update

[GitBox]

uerceg commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update
URL: https://github.com/apache/cordova-android/issues/554#issuecomment-438680723
 
 
   Awesome guys, thanks for super quick reply.
   
   I tried @brodybits's flow with nightly build and it works like a charm. 
Nice. 👍 
   
   I am just not sure I understood P.S. comment. Is there a way to declare 
paths in `plugin.xml` in a way that it supports both, `cordova-android@6` and 
`cordova-android@7`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits opened a new issue #556: app/build.gradle vs legacy/build.gradle?

[GitBox]

brodybits opened a new issue #556: app/build.gradle vs legacy/build.gradle?
URL: https://github.com/apache/cordova-android/issues/556
 
 
   Can someone explain the relationship between 
`bin/templates/project/app/build.gradle` and 
`bin/templates/project/legacy/build.gradle`?
   
   Do they work together?
   
   Could they work against each other?
   
   Is there an opportunity for better integration between old version and new 
version?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #552: Cordova project ignores build-extras after toolchain upgrade

[GitBox]

brodybits commented on issue #552: Cordova project ignores build-extras after 
toolchain upgrade
URL: https://github.com/apache/cordova-android/issues/552#issuecomment-438679242
 
 
   Closing since PR #553 was merged. This should be fixed in upcoming 7.1.3 
release.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits closed issue #552: Cordova project ignores build-extras after toolchain upgrade

[GitBox]

brodybits closed issue #552: Cordova project ignores build-extras after 
toolchain upgrade
URL: https://github.com/apache/cordova-android/issues/552
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update

[GitBox]

janpio commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update
URL: https://github.com/apache/cordova-android/issues/554#issuecomment-438679126
 
 
   (FYI: Can also reproduce @brodybits' temp fix via using nightly [we seem to 
have replied at the same time])


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update

[GitBox]

brodybits commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 
update
URL: https://github.com/apache/cordova-android/issues/554#issuecomment-438678457
 
 
   P.S. Once PR #550 is merged and released you should not need the cordova-8 
changes in 

 any more. Just in case you need to support cordova-android@6 (previous 
release) for any reason.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update

[GitBox]

janpio commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update
URL: https://github.com/apache/cordova-android/issues/554#issuecomment-438678478
 
 
   (FYI: Can reproduce on Windows with same Cordova CLI version)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update

[GitBox]

brodybits commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 
update
URL: https://github.com/apache/cordova-android/issues/554#issuecomment-438677676
 
 
   Already solved in `master`, tested as follows:
   
   * `cordova platform add cordova-android@nightly`
   * `cordova plugin add https://github.com/adjust/cordova_sdk.git\#cordova-8`
   * `cordova build android`
   
   Will be fixed in 7.1.3. Closing as a duplicate of GH-540.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits closed issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update

[GitBox]

brodybits closed issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update
URL: https://github.com/apache/cordova-android/issues/554
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #345: In App Browser - doesn't load webpage in iOS 12

[GitBox]

janpio commented on issue #345: In App Browser - doesn't load webpage in iOS 12
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/345#issuecomment-438675407
 
 
   What version of `cordova-ios` are you using?
   
   The best way for us to reporoduce and later debug this issue would be for 
you to create a new Cordova project with `cordova create`, add the platform and 
plugins you really need and implement the minimal code (open inappbrowser with 
that URL) that shows your problem clearly and reproducibly. Please upload that 
project to GitHub and then post the URL here. Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] jcesarmobile commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

[GitBox]

jcesarmobile commented on issue #550: Fix for old plugins with non-Java sources 
(GH-547)
URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438669256
 
 
   It knows nothing about any file extension at all, this PR is the one placing 
files based on the extension


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] Nazirovich commented on issue #345: In App Browser - doesn't load webpage in iOS 12

[GitBox]

Nazirovich commented on issue #345: In App Browser - doesn't load webpage in 
iOS 12
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/345#issuecomment-438667199
 
 
   > You are posting this in the Cordova plugin repository, not Ionic. Any 
specific reason why you are using the Ionic issue template?
   > 
   > From the output above, you don't have Cordova CLI installed, no platforms 
or plugins in your project. This can not be true. Can you please post those 
versions?
   > 
   > What URL are you trying to load?
   
   - Because i'm using the ionic framework for my app
   
   - yes sure
   ```
   Cordova:
   
  cordova (Cordova CLI) : 8.1.2 (cordova-lib@8.1.1)
  Cordova Platforms : none
  Cordova Plugins   : cordova-plugin-ionic-keyboard 2.1.3, (and 5 other 
plugins)
   ```
   ```
   Node version: v8.9.4
   
   Cordova version: 8.1.1
   

   http://*/*"; />
   https://*/*"; />
   
   
   mailto:*"; />
   
   
   https://www.sabis.net";>
  
   
   
   
   
   
   
   
   
   
   ```
   - https://www.sabis.net
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

[GitBox]

brodybits commented on issue #550: Fix for old plugins with non-Java sources 
(GH-547)
URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438665079
 
 
   > [...] it also has `.h` and `.c` files that are treated as `.java` files.
   > They were `src/c/common/mylib/parts` and he updated them to 
`app/src/main/java/c/common/mylib`
   > 
   > We could add those two extensions in the .java check.
   
   I would not favor making a special case for these files. Right now 
cordova-android knows nothing about these files by itself and I think we should 
keep it that way. If a plugin wants to put these files in a special location I 
think it should specify the full prefix starting with `app`. I will add them to 
the unit test, though.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio edited a comment on issue #345: In App Browser - doesn't load webpage in iOS 12

[GitBox]

janpio edited a comment on issue #345: In App Browser - doesn't load webpage in 
iOS 12
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/345#issuecomment-438664689
 
 
   You are posting this in the Cordova plugin repository, not Ionic. Any 
specific reason why you are using the Ionic issue template?
   
   From the output above, you don't have Cordova CLI installed, no platforms or 
plugins in your project. This can not be true. Can you please post those 
versions?
   
   What URL are you trying to load?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #345: In App Browser - doesn't load webpage in iOS 12

[GitBox]

janpio commented on issue #345: In App Browser - doesn't load webpage in iOS 12
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/345#issuecomment-438664689
 
 
   You are posting this in the Cordova plugin repository, not Ionic. Any 
specific reason why you are using the Ionic issue template?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] Nazirovich opened a new issue #345: In App Browser - doesn't load webpage in iOS 12

[GitBox]

Nazirovich opened a new issue #345: In App Browser - doesn't load webpage in 
iOS 12
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/345
 
 
   
   
   **Ionic version:**
   [ ] 1.x
   [ ] 2.x
   [X] 3.x
   
   **I'm submitting a ...**  (check one with "x")
   [x ] bug report
   [ ] feature request
   
   
   
   **Current behavior:**
   Open the in app browser and the url does not load, it always shows a blank 
white page on iOS,
   however, it is working in Android
   
   **Expected behavior:**
   Open the in app browser and load the url
   
   **Related code:**
   
   
   
   ```
   openWebPage() {
const browser = this.inAppBrowser.create("www.url.com", '_blank');
}
   ```
   
   **Other information:**
   
   
   **Ionic info:** (run `ionic info` from a terminal/cmd prompt and paste 
output below):
   
   ```
   Ionic:
   
  ionic (Ionic CLI)  : 4.3.1 
(C:\Users\***\AppData\Roaming\npm\node_modules\ionic)
  Ionic Framework: ionic-angular 3.9.2
  @ionic/app-scripts : 3.2.0
   
   Cordova:
   
  cordova (Cordova CLI) : not installed
  Cordova Platforms : none
  Cordova Plugins   : not available
   
   System:
   
  NodeJS : v8.9.4 (C:\Program Files (x86)\nodejs\node.exe)
  npm: 5.6.0
  OS : Windows 10
   ```
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] duncan-c edited a comment on issue #173: App crashes on ANDROID 8 version

[GitBox]

duncan-c edited a comment on issue #173: App crashes on ANDROID 8 version 
URL: 
https://github.com/apache/cordova-plugin-contacts/issues/173#issuecomment-434470449
 
 
   Have done now: https://github.com/apache/cordova-plugin-contacts/pull/180
   I wasn't sure if I should as the plugin is marked as deprecated.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio edited a comment on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

[GitBox]

janpio edited a comment on issue #110: Cordova Status Bar Plugin hides the 
input when the keyboard appears
URL: 
https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-438662302
 
 
   And without the statusbar plugin, you get the same result as in the browser?
   
   I think it would be important to have a super simple project that replicated 
the problem here. Meaning: `cordova create`, add the platform and this plugin 
and some minimal html code that replicated this behaviour so one can test it. 
Please create such a project and put it up on Github and post the link here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

[GitBox]

janpio commented on issue #110: Cordova Status Bar Plugin hides the input when 
the keyboard appears
URL: 
https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-438662302
 
 
   And without the statusbar plugin, you get the same result as in the browser?
   
   I think it would be important to have a super simple project that replicated 
the problem here. Meaning: `cordova create`, add the platform and this plugin 
and some minimal html code that replicated this behaviour so one can test it. 
Are you up for creating this project and putting it up on Github and posting 
the link here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] OmarHassan25 commented on issue #173: App crashes on ANDROID 8 version

[GitBox]

OmarHassan25 commented on issue #173: App crashes on ANDROID 8 version 
URL: 
https://github.com/apache/cordova-plugin-contacts/issues/173#issuecomment-438661600
 
 
   @duncan-c updated ContactManager.java solves the problem


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #468: Update CordovaResourceApi.java

[GitBox]

brodybits commented on issue #468: Update CordovaResourceApi.java
URL: https://github.com/apache/cordova-android/pull/468#issuecomment-438659079
 
 
   Can we move some of this functionality into a plugin?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

[GitBox]

tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input 
when the keyboard appears
URL: 
https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-438654508
 
 
   *cordova


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

[GitBox]

tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input 
when the keyboard appears
URL: 
https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-438654430
 
 
   sure!
   
![121](https://user-images.githubusercontent.com/44980392/48484272-b9a34680-e83b-11e8-992e-11adc68bf823.jpg)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-android] branch master updated: GH-552 (android) check for build-extras.gradle in the app-parent directory (#553)

[brodybits]

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-android.git


The following commit(s) were added to refs/heads/master by this push:
 new 7eed65e  GH-552 (android) check for build-extras.gradle in the 
app-parent directory (#553)
7eed65e is described below

commit 7eed65e9b4652cd5ef3afb163690aab940095fe2
Author: David Boho 
AuthorDate: Wed Nov 14 14:00:36 2018 +0100

GH-552 (android) check for build-extras.gradle in the app-parent directory 
(#553)

as documented in 
https://cordova.apache.org/docs/en/latest/guide/platforms/android/?#extending-buildgradle

and deal with multiple build-extras.gradle locations

Co-authored-by: David Boho 
Co-authored-by: Christopher J. Brody 
---
 bin/templates/project/app/build.gradle | 9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/bin/templates/project/app/build.gradle 
b/bin/templates/project/app/build.gradle
index 87bf049..016c0b3 100644
--- a/bin/templates/project/app/build.gradle
+++ b/bin/templates/project/app/build.gradle
@@ -93,11 +93,16 @@ ext {
 // PLUGIN GRADLE EXTENSIONS START
 // PLUGIN GRADLE EXTENSIONS END
 
-def hasBuildExtras = file('build-extras.gradle').exists()
-if (hasBuildExtras) {
+def hasBuildExtras1 = file('build-extras.gradle').exists()
+if (hasBuildExtras1) {
 apply from: 'build-extras.gradle'
 }
 
+def hasBuildExtras2 = file('../build-extras.gradle').exists()
+if (hasBuildExtras2) {
+apply from: '../build-extras.gradle'
+}
+
 // Set property defaults after extension .gradle files.
 if (ext.cdvCompileSdkVersion == null) {
 ext.cdvCompileSdkVersion = privateHelpers.getProjectTarget()


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits closed pull request #553: #552: (android) check for build-extras.gradle in the app-parent directory

[GitBox]

brodybits closed pull request #553: #552: (android) check for 
build-extras.gradle in the app-parent directory
URL: https://github.com/apache/cordova-android/pull/553
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bin/templates/project/app/build.gradle 
b/bin/templates/project/app/build.gradle
index 24006ea0d..720652926 100644
--- a/bin/templates/project/app/build.gradle
+++ b/bin/templates/project/app/build.gradle
@@ -93,11 +93,16 @@ ext {
 // PLUGIN GRADLE EXTENSIONS START
 // PLUGIN GRADLE EXTENSIONS END
 
-def hasBuildExtras = file('build-extras.gradle').exists()
-if (hasBuildExtras) {
+def hasBuildExtras1 = file('build-extras.gradle').exists()
+if (hasBuildExtras1) {
 apply from: 'build-extras.gradle'
 }
 
+def hasBuildExtras2 = file('../build-extras.gradle').exists()
+if (hasBuildExtras2) {
+apply from: '../build-extras.gradle'
+}
+
 // Set property defaults after extension .gradle files.
 if (ext.cdvCompileSdkVersion == null) {
 ext.cdvCompileSdkVersion = privateHelpers.getProjectTarget()


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #94: check for required permission before video capture

[GitBox]

janpio commented on issue #94: check for required permission before video 
capture
URL: 
https://github.com/apache/cordova-plugin-media-capture/pull/94#issuecomment-438652925
 
 
   This PR here seems to have quite some more code and differentiates between 
different permissions being required. Might that be relevant?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits opened a new pull request #555: [WIP] 7.1.3 patch updates - proposed

[GitBox]

brodybits opened a new pull request #555: [WIP] 7.1.3 patch updates - proposed
URL: https://github.com/apache/cordova-android/pull/555
 
 
   * Remove obsolete check for JellyBean to work properly on Android Pie 
(GH-534)
   * GH-539 fix destination path fallback
   * GH-540 fix for source-file with app target-dir
   * Tests to reproduce GH-547
   * add missing cast for cdvMinSdkVersion (GH-551)
   * Multiple build-extras.gradle locations (GH-552) - pending approval of PR 
#553
   
   TODO:
   
   - [ ] wait for approval of PR #553
   - [ ] GH-547 fix from PR #550, upon approval
   
   ## How tested
   
   - [x] `npm run unit-tests` succeeds
   - [ ] `npm test` succeeds in Travis CI
   - [ ] Verify that it is possible to build with `cordova-plugin-deezer` and 
`https://github.com/j3k0/cordova-plugin-purchase#master` in patch release 
(GH-540)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] uerceg opened a new issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update

[GitBox]

uerceg opened a new issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update
URL: https://github.com/apache/cordova-android/issues/554
 
 
   Hey guys.
   
   We have our plugin built for Cordova and the version on Github `master` 
branch is compatible with pre `android@7.0.0` platform version. For 
`android@7.0.0` and above we made separate branch called `cordova-8` from which 
people can add our plugin in case they are using those platform version(s).
   
   Together with `android@7.1.1` platform version, everything worked fine, but 
as of `android@7.1.2`, plugin can't be added on Android platform. I was trying 
to go through all the PRs you merged as part of `android@7.1.2` update, but no 
luck in finding what is actually causing the error.
   
   Error which happens once plugin is being added:
   
   ```
   No scripts found for hook "before_plugin_add".
   Calling plugman.fetch on plugin 
"https://github.com/adjust/cordova_sdk.git#cordova-8";
   saving
   Running command: npm install 
https://github.com/adjust/cordova_sdk.git#cordova-8 --production --save
   Command finished with error code 0: npm 
install,https://github.com/adjust/cordova_sdk.git#cordova-8,--production,--save
   Copying plugin 
"/Users/uerceg/Projects/Cordova/AdjustCordovaEight/node_modules/com.adjust.sdk" 
=> "/Users/uerceg/Projects/Cordova/AdjustCordovaEight/plugins/com.adjust.sdk"
   Calling plugman.install on plugin 
"/Users/uerceg/Projects/Cordova/AdjustCordovaEight/plugins/com.adjust.sdk" for 
platform "android
   Installing "com.adjust.sdk" for android
   Running command: 
/Users/uerceg/Projects/Cordova/AdjustCordovaEight/platforms/android/cordova/version
   Command finished with error code 0: 
/Users/uerceg/Projects/Cordova/AdjustCordovaEight/platforms/android/cordova/version
   Finding scripts for "before_plugin_install" hook from plugin com.adjust.sdk 
on android platform only.
   No scripts found for hook "before_plugin_install".
   Install start for "com.adjust.sdk" on android.
   PlatformApi successfully found for platform android
   Android Studio project detected
   Beginning processing of action stack for android project...
   Error during processing of action! Attempting to revert...
   Failed to install 'com.adjust.sdk': TypeError [ERR_INVALID_ARG_TYPE]: Uh oh!
   The "path" argument must be of type string
   at assertPath (path.js:28:11)
   at Object.resolve (path.js:1179:7)
   at copyNewFile 
(/Users/uerceg/Projects/Cordova/AdjustCordovaEight/platforms/android/cordova/lib/pluginHandlers.js:258:28)
   at install 
(/Users/uerceg/Projects/Cordova/AdjustCordovaEight/platforms/android/cordova/lib/pluginHandlers.js:43:17)
   at ActionStack.process 
(/Users/uerceg/Projects/Cordova/AdjustCordovaEight/platforms/android/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
   at PluginManager.doOperation 
(/Users/uerceg/Projects/Cordova/AdjustCordovaEight/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:114:20)
   at PluginManager.addPlugin 
(/Users/uerceg/Projects/Cordova/AdjustCordovaEight/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:144:17)
   at 
/Users/uerceg/Projects/Cordova/AdjustCordovaEight/platforms/android/cordova/Api.js:247:74
   at _fulfilled 
(/Users/uerceg/Projects/Cordova/AdjustCordovaEight/platforms/android/cordova/node_modules/q/q.js:834:54)
   at self.promiseDispatch.done 
(/Users/uerceg/Projects/Cordova/AdjustCordovaEight/platforms/android/cordova/node_modules/q/q.js:863:30)
   Uh oh!
   The "path" argument must be of type string
   TypeError [ERR_INVALID_ARG_TYPE]: Uh oh!
   The "path" argument must be of type string
   at assertPath (path.js:28:11)
   at Object.resolve (path.js:1179:7)
   at copyNewFile 
(/Users/uerceg/Projects/Cordova/AdjustCordovaEight/platforms/android/cordova/lib/pluginHandlers.js:258:28)
   at install 
(/Users/uerceg/Projects/Cordova/AdjustCordovaEight/platforms/android/cordova/lib/pluginHandlers.js:43:17)
   at ActionStack.process 
(/Users/uerceg/Projects/Cordova/AdjustCordovaEight/platforms/android/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
   at PluginManager.doOperation 
(/Users/uerceg/Projects/Cordova/AdjustCordovaEight/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:114:20)
   at PluginManager.addPlugin 
(/Users/uerceg/Projects/Cordova/AdjustCordovaEight/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:144:17)
   at 
/Users/uerceg/Projects/Cordova/AdjustCordovaEight/platforms/android/cordova/Api.js:247:74
   at _fulfilled 
(/Users/uerceg/Projects/Cordova/AdjustCordovaEight/platforms/android/cordova/node_modules/q/q.js:834:54)
   at self.promiseDispatch.done 
(/Users/uerceg/Projects/Cordova/AdjustCordovaEight/platforms/android/cordova/node_modules/q/q.js:863:30)
   ```
   
   Steps to reproduce:
   
   1. Create empty new Cordova app.
   2. `cordova platform add

[GitHub] brodybits commented on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory

[GitBox]

brodybits commented on issue #553: #552: (android) check for 
build-extras.gradle in the app-parent directory
URL: https://github.com/apache/cordova-android/pull/553#issuecomment-438645251
 
 
   Thanks @DavidWiesner, would like to get review from one more member before 
merging.
   
   If someone else does a merge, I recommend a squash merge but please be sure 
to give @DavidWiesner credit in the commit. I hope we can do this today.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] ffMathy edited a comment on issue #100: CB-13683: (android) cordova-plugin-media-capture rotates pictures with some devices

[GitBox]

ffMathy edited a comment on issue #100: CB-13683: (android) 
cordova-plugin-media-capture rotates pictures with some devices
URL: 
https://github.com/apache/cordova-plugin-media-capture/pull/100#issuecomment-438601158
 
 
   Do you have a list of committers somewhere that would elligible for that 
description?
   
   My concern is that there won't ever be random Cordova committers that will 
come by and review this. Only new people that won't fit that description.
   
   This is a critical bug. It's unusable on Android devices. The fix works. It 
has been tested by the author and myself on real devices. The approach we are 
using right now doesn't seem very pragmatic to be honest.
   
   I get that we shouldn't try to rush things in, but this could take years!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] ffMathy commented on issue #94: check for required permission before video capture

[GitBox]

ffMathy commented on issue #94: check for required permission before video 
capture
URL: 
https://github.com/apache/cordova-plugin-media-capture/pull/94#issuecomment-438643472
 
 
   #95? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #552: Cordova project ignores build-extras after toolchain upgrade

[GitBox]

brodybits commented on issue #552: Cordova project ignores build-extras after 
toolchain upgrade
URL: https://github.com/apache/cordova-android/issues/552#issuecomment-438643092
 
 
   From the history it looks like the work was done in PR #389. It seems like 
they did try to preserve compatibility, but evidently it was not preserved 100%.
   
   > All other configuration files e.g.: release-signing.properties are still 
referenced from the old location: platforms/android/
   
   I find that really interesting, just discovered that 
`release-signing.properties` is referenced by both 
`bin/templates/project/app/build.gradle` and 
`bin/templates/project/legacy/build.gradle`. I have no idea how or even if they 
would work together.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org