brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547) URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438714101 I think the primary rule should be to place files based on target-dir prefix, i.e. `app` vs `src` vs `lib`, and extensions should be treated as special cases. This is basically how it is implemented in this PR. I would rather not make a special case for `.h` and `.c` files since cordova-android does not need to do anything with them. Use of `.h` and `.c` files should remain plugin-specific, plugin provides its own Gradle file to handle them. For example: <https://github.com/dpa99c/cordova-plugin-hello-c> specifies the native build with `.h` and `.c` files in the following places: * <https://github.com/dpa99c/cordova-plugin-hello-c/blob/master/plugin.xml#L47> to use `build-extras.gradle` (probably should have been a `framework` element) * <https://github.com/dpa99c/cordova-plugin-hello-c/blob/master/src/android/build-extras.gradle#L8-L20> to use `Android.mk` * <https://github.com/dpa99c/cordova-plugin-hello-c/blob/master/src/android/jni/Android.mk#L21-L36 specifies the actual source files for NDK build, including files shared with iOS platform I would be happy to add these files to the unit test, for the sake of verification and understanding.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
