[GitHub] SanjanaTailor edited a comment on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

2018-11-15 Thread GitBox
SanjanaTailor edited a comment on issue #407: [ANNOUNCEMENT] Status of Xcode 10 
support
URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-439305136
 
 
   Thank you for me using CLI command where I used below command which worked 
for me well 
   
xcodebuild clean -project /Users/xxx.xcodeproj -configuration Release 
-alltargets -UseModernBuildSystem = NO


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] SanjanaTailor commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

2018-11-15 Thread GitBox
SanjanaTailor commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support
URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-439305136
 
 
   Thank you for me using CLI command where I used below which worked for me 
well 
   
xcodebuild clean -project /Users/xxx.xcodeproj -configuration Release 
-alltargets -UseModernBuildSystem = NO


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] danbeo95 opened a new issue #186: Please support me ! When i call save() method to modify contact.It was sccucess.But i notify , after that access to contact lists on phone it was very slow .

2018-11-15 Thread GitBox
danbeo95 opened a new issue #186: Please support me ! When i call save() method 
to modify contact.It was sccucess.But i notify ,after that access to contact 
lists on phone it was very slow .How can i fix it ?
URL: https://github.com/apache/cordova-plugin-contacts/issues/186
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

2018-11-15 Thread GitBox
tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input 
when the keyboard appears
URL: 
https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-439285726
 
 
   1. That's because of the color of text and background being white. Check 
again?
   
   Yeah other than that everything as expected! 👍 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] barnesdc commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

2018-11-15 Thread GitBox
barnesdc commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support
URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-439225700
 
 
   I ended up getting my app running on my iPhone X.
   Steps that I took:
   - opened the ionic-ios build folder on Xcode
   - attempted build, failed.
   - resolved any cautions, literally just had to click and let Xcode do its 
thing.
   - Xcode -> preferences -> accounts: then log in to your developer account 
and "manage certificates" and add your signing cert.
   - then select views -> navigators -> show project navigator
   -- should be on a screen that shows info & build settings. on that same 
like, the first thing should be the name of your app, click that and then 
select your app in the "targets" area. this will bring up the "general" tab
   - inside the general tab, change the "bundle identifier" to the name of your 
developer profile and make sure your team is selected as the signing profile.
   - lastly, file -> workspace setting -> change the build setting to legacy.
   
   After these steps the build of my app failed. On my iPhone I had to navigate 
to Settings -> general - device management -> and trust the signing certificate 
(I think that is what is was)
   Rebuilt the app and everything ran successfully.
   
   Hopefully you all can follow my steps.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio commented on issue #197: Add durationUpdate callback

2018-11-15 Thread GitBox
janpio commented on issue #197: Add durationUpdate callback
URL: 
https://github.com/apache/cordova-plugin-media/pull/197#issuecomment-439213524
 
 
   Could you update the PR description, platform etc please?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio edited a comment on issue #197: Add durationUpdate callback

2018-11-15 Thread GitBox
janpio edited a comment on issue #197: Add durationUpdate callback
URL: 
https://github.com/apache/cordova-plugin-media/pull/197#issuecomment-439213524
 
 
   Could you update the PR description, platform etc please? I think this is a 
copy/paste error right now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] BuddyLReno commented on issue #197: Add durationUpdate callback

2018-11-15 Thread GitBox
BuddyLReno commented on issue #197: Add durationUpdate callback
URL: 
https://github.com/apache/cordova-plugin-media/pull/197#issuecomment-439210840
 
 
   This particular change helps deal with the fact that Android shuts down 
webapps in the background after a few minutes. You can subscribe to this 
callback and let the audio player report the duration to you when it's 
available instead of querying for it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] BuddyLReno commented on issue #190: Add Error Call for Stalled Playback. Add Set Rate support for android. Fix rate setting on seek in iOS.

2018-11-15 Thread GitBox
BuddyLReno commented on issue #190: Add Error Call for Stalled Playback. Add 
Set Rate support for android. Fix rate setting on seek in iOS.
URL: 
https://github.com/apache/cordova-plugin-media/pull/190#issuecomment-439210391
 
 
   @janpio no problem! Sorry it took so long, we had to work through some 
issues with our app to start testing these.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] JacobSiegle edited a comment on issue #562: Updated to 7.1.2 - android.os.DeadObjectException: Transaction failed on small parcel; remote process

2018-11-15 Thread GitBox
JacobSiegle edited a comment on issue #562: Updated to 7.1.2 - 
android.os.DeadObjectException: Transaction failed on small parcel; remote 
process
URL: https://github.com/apache/cordova-android/issues/562#issuecomment-439134023
 
 
   1) Yes and no. The form on my page will always crash, but at different spots.
   2) Pixel (1st gen) 8.0.
   3) I haven't tried reproducing it in another app yet.
   
   It seems like the issue is coming from the auto fill service added in 
Android 8.0. When auto fill is turned on the app will crash. When auto fill is 
turned off I can complete the form with no issue. As mentioned previously it 
seems like it only happens with the 8.0 auto fill, so something in the newer 
versions of Android is probably fixed with it.
   
   Is there anyway to disable the auto fill service in a cordova app? Or is 
this issue not related / cant be fixed via cordova?
   
   Related -
   
https://stackoverflow.com/questions/45731372/disabling-android-o-auto-fill-service-for-an-application/46698028


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] JacobSiegle edited a comment on issue #562: Updated to 7.1.2 - android.os.DeadObjectException: Transaction failed on small parcel; remote process

2018-11-15 Thread GitBox
JacobSiegle edited a comment on issue #562: Updated to 7.1.2 - 
android.os.DeadObjectException: Transaction failed on small parcel; remote 
process
URL: https://github.com/apache/cordova-android/issues/562#issuecomment-439134023
 
 
   1) Yes and no. The form on my page will always crash, but at different spots.
   2) Pixel (1st gen) 8.0.
   3) I haven't tried reproducing it in another app yet.
   
   It seems like the issue is coming from the auto fill service added in 
Android 8.0. When auto fill is turned on the app will crash. When auto fill is 
turned off I can complete the form with no issue. As mentioned previously it 
seems like it only happens with the 8.0 auto fill, so something in the newer 
versions of Android is probably fixed with it.
   
   Is there anyway to disable the auto fill service in a cordova app? Or is 
this issue not related / cant be fixed via cordova?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] JacobSiegle edited a comment on issue #562: Updated to 7.1.2 - android.os.DeadObjectException: Transaction failed on small parcel; remote process

2018-11-15 Thread GitBox
JacobSiegle edited a comment on issue #562: Updated to 7.1.2 - 
android.os.DeadObjectException: Transaction failed on small parcel; remote 
process
URL: https://github.com/apache/cordova-android/issues/562#issuecomment-439134023
 
 
   1) Yes and no. The form on my page will always crash, but at different spots.
   2) Pixel (1st gen) 8.0.
   3) I haven't tried reproducing it in another app yet.
   
   It seems like the issue is coming from the auto fill service added in 
Android 8.0. When auto fill is turned on the app will crash. When auto fill is 
turned off I can complete the form with no issue. As mentioned previously it 
seems like it only happens with the 8.0 auto fill, so something in the newer 
versions of Android is probably fixed with it.
   
   Is there anyway to disable the auto fill service in a cordova app? Or is 
this issue not related to cordova?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio commented on issue #190: Add Error Call for Stalled Playback. Add Set Rate support for android. Fix rate setting on seek in iOS.

2018-11-15 Thread GitBox
janpio commented on issue #190: Add Error Call for Stalled Playback. Add Set 
Rate support for android. Fix rate setting on seek in iOS.
URL: 
https://github.com/apache/cordova-plugin-media/pull/190#issuecomment-439173459
 
 
   Thank you. That's awesome! 😍 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] Motoralfa commented on issue #120: When getting location does'nt return anything or return empty error with a timeout (Android Oreo)

2018-11-15 Thread GitBox
Motoralfa commented on issue #120: When getting location does'nt return 
anything or return empty error with a timeout (Android Oreo)
URL: 
https://github.com/apache/cordova-plugin-geolocation/issues/120#issuecomment-439172158
 
 
   Well, i was reading documentation and i realize that error return a 
PositionError that has message and code as it say here
   
![captura](https://user-images.githubusercontent.com/10781270/48578370-2da32480-e8f8-11e8-88b4-dd1fca66d0fa.JPG)
   try to change 
   `console.log(err);`
   to
   `console.log(err.message);`
   to see what it is wrong with the code. In my case it was a problem with the 
Secure Origins. Im sure most of the problems is related with that. I hope it 
can help you!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] BuddyLReno commented on issue #190: Add Error Call for Stalled Playback. Add Set Rate support for android. Fix rate setting on seek in iOS.

2018-11-15 Thread GitBox
BuddyLReno commented on issue #190: Add Error Call for Stalled Playback. Add 
Set Rate support for android. Fix rate setting on seek in iOS.
URL: 
https://github.com/apache/cordova-plugin-media/pull/190#issuecomment-439170595
 
 
   Hi @janpio! I've fixed this PR by creating three new PRs and removed the 
accidental formatting changes:  Please see PRs #195, #196, and #197


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] BuddyLReno opened a new pull request #197: Add durationUpdate callback

2018-11-15 Thread GitBox
BuddyLReno opened a new pull request #197: Add durationUpdate callback
URL: https://github.com/apache/cordova-plugin-media/pull/197
 
 
   ### Platforms affected
   - Android
   
   ### What does this PR do?
   - Add support for setRate to Android
   
   ### What testing has been done on this change?
   Physical device testing on:
   
   - OnePlus 5T (Oreo 8.1)
   - Samsung Galaxy S8 (Nougat 7.1)
   
   ### Checklist
   - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
   - [ ] Added automated test coverage as appropriate for this change.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] BuddyLReno opened a new pull request #196: Add support for setRate on Android. Fix setRate on iOS when seeking.

2018-11-15 Thread GitBox
BuddyLReno opened a new pull request #196: Add support for setRate on Android. 
Fix setRate on iOS when seeking.
URL: https://github.com/apache/cordova-plugin-media/pull/196
 
 
   ### Platforms affected
   - Android
   - iOS
   
   ### What does this PR do?
   - Fix rate setting when seeking audio tracks on iOS.
   - Adds setRate support for android.
   
   ### What testing has been done on this change?
   Physical device testing on:
   
   - iPhone X (iOS 12)
   - iPhone 6 (iOS 11)
   - OnePlus 5T (Oreo 8.1)
   - Samsung Galaxy S8 (Nougat 7.1)
   
   ### Checklist
   - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
   - [ ] Added automated test coverage as appropriate for this change.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] BuddyLReno opened a new pull request #195: Add error call for stalled_playback (iOS only)

2018-11-15 Thread GitBox
BuddyLReno opened a new pull request #195: Add error call for stalled_playback 
(iOS only)
URL: https://github.com/apache/cordova-plugin-media/pull/195
 
 
   ### Platforms affected
   - iOS
   
   ### What does this PR do?
   - Adds an error call for stalled playback on iOS.
   
   ### What testing has been done on this change?
   Physical device testing on:
   
   - iPhone X (iOS 12)
   - iPhone 6 (iOS 11)
   
   
   ### Checklist
   - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
   - [ ] Added automated test coverage as appropriate for this change.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

2018-11-15 Thread GitBox
janpio commented on issue #110: Cordova Status Bar Plugin hides the input when 
the keyboard appears
URL: 
https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-439145721
 
 
   Ok, have it running (had to delete `node_modules` and run `npm i`) on my 
Android device (Nexus 5, Android 6.0.1):
   
   1. I see no statusbar at all by default.
   2. When I tap into the "Message" input field, the keyboard pops up and the 
input fields disappears. 
   3. Removing the plugin makes the statusbar appear and the input field is 
visible over the keyboard when tapping into it.
   
   Everything as expected?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] JacobSiegle edited a comment on issue #562: Updated to 7.1.2 - android.os.DeadObjectException: Transaction failed on small parcel; remote process

2018-11-15 Thread GitBox
JacobSiegle edited a comment on issue #562: Updated to 7.1.2 - 
android.os.DeadObjectException: Transaction failed on small parcel; remote 
process
URL: https://github.com/apache/cordova-android/issues/562#issuecomment-439134023
 
 
   1) Yes and no. The form on my page will always crash, but at different spots.
   2) Pixel (1st gen) 8.0.
   3) I haven't tried reproducing it in another app yet.
   
   It seems like the issue is coming from the auto fill service added in 
Android 8.0. When auto fill is turned on the app will crash. When auto fill is 
turned off I can complete the form with no issue. As mentioned previously it 
seems like it only happens with the 8.0 auto fill.
   
   Is there anyway to disable the auto fill service in a cordova app? Or is 
this issue not related to cordova?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] JacobSiegle edited a comment on issue #562: Updated to 7.1.2 - android.os.DeadObjectException: Transaction failed on small parcel; remote process

2018-11-15 Thread GitBox
JacobSiegle edited a comment on issue #562: Updated to 7.1.2 - 
android.os.DeadObjectException: Transaction failed on small parcel; remote 
process
URL: https://github.com/apache/cordova-android/issues/562#issuecomment-439134023
 
 
   1) Yes and no. The form on my page will always crash, but at different spots.
   2) Pixel (1st gen) 8.0.
   3) I haven't tried reproducing it in another app yet.
   
   It seems like the issue is coming from the auto fill service added in 
Android 8.0. When auto fill is turned on the app will crash. When auto fill is 
turned off I can complete the form with no issue. As mentioned previously it 
seems like it only happens with the 8.0 auto fill.
   
   Is there anyway to disable the auto fill service in a cordova app? Or is 
this issue not related?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] JacobSiegle edited a comment on issue #562: Updated to 7.1.2 - android.os.DeadObjectException: Transaction failed on small parcel; remote process

2018-11-15 Thread GitBox
JacobSiegle edited a comment on issue #562: Updated to 7.1.2 - 
android.os.DeadObjectException: Transaction failed on small parcel; remote 
process
URL: https://github.com/apache/cordova-android/issues/562#issuecomment-439134023
 
 
   1) Yes and no. The form on my page will always crash, but at different 
intervals.
   2) Pixel (1st gen) 8.0.
   3) I haven't tried reproducing it in another app yet.
   
   It seems like the issue is coming from the auto fill service added in 
Android 8.0. When auto fill is turned on the app will crash. When auto fill is 
turned off I can complete the form with no issue. As mentioned previously it 
seems like it only happens with the 8.0 auto fill.
   
   Is there anyway to disable the auto fill service in a cordova app? Or is 
this issue not related?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] kabua opened a new issue #346: Help: How to reference the definition file?

2018-11-15 Thread GitBox
kabua opened a new issue #346: Help: How to reference the definition file?
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/346
 
 
   I hope this is a dumb `TS 101` question, but we can't seem to figure it out.
   
   We are porting the the following code snippet to TypeScript: 
   ```
   this._popup = cordova.InAppBrowser.open(params.url, this.target, 
this.features);
   ```
   
   However, we are getting the following error:
   ```
   [ts] Property 'InAppBrowser' does not exist on type 'Cordova'. [2339]
   ```
   Therefore we ran:
   ```
   npm i -D cordova-plugin-inappbrowser
   ```
   Okay, we now have access to the `...\cordova-plugin-inappbrowser\index.d.ts` 
file but the issue still exists. We've tried all kinds of ways to using 
`import` but nothing seam to be working.
   
   What are we doing wrong? 
   
   As a work-a-round we are doing this:
   ```
   const localCordova =  cordova;
   this._popup = localCordova.InAppBrowser.open(params.url, this.target, 
this.features);
   ```
   
   
   Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] JacobSiegle edited a comment on issue #562: Updated to 7.1.2 - android.os.DeadObjectException: Transaction failed on small parcel; remote process

2018-11-15 Thread GitBox
JacobSiegle edited a comment on issue #562: Updated to 7.1.2 - 
android.os.DeadObjectException: Transaction failed on small parcel; remote 
process
URL: https://github.com/apache/cordova-android/issues/562#issuecomment-439134023
 
 
   1) Yes.
   2) Pixel (1st gen) 8.0.
   3) I haven't tried reproducing it in another app yet.
   
   It seems like the issue is coming from the auto fill service added in 
Android 8.0. When auto fill is turned on the app will crash. When auto fill is 
turned off I can complete the form with no issue. As mentioned previously it 
seems like it only happens with the 8.0 auto fill.
   
   Is there anyway to disable the auto fill service in a cordova app? Or is 
this issue not related?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] JacobSiegle commented on issue #562: Updated to 7.1.2 - android.os.DeadObjectException: Transaction failed on small parcel; remote process

2018-11-15 Thread GitBox
JacobSiegle commented on issue #562: Updated to 7.1.2 - 
android.os.DeadObjectException: Transaction failed on small parcel; remote 
process
URL: https://github.com/apache/cordova-android/issues/562#issuecomment-439134023
 
 
   1) Yes.
   2) Pixel (1st gen) 8.0.
   3) I haven't tried reproducing it in another app yet.
   
   It seems like the issue is coming from the autofill service added in Android 
8.0. When auto fill is turned on the app will crash. When auto is turned off I 
can complete the form with no issue.
   
   Is there anyway to disable the auto fill service in a cordova app? Or is 
this issue not related?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

2018-11-15 Thread GitBox
tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input 
when the keyboard appears
URL: 
https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-439131775
 
 
   done :)
   https://github.com/tharunkumar0/test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

2018-11-15 Thread GitBox
janpio commented on issue #110: Cordova Status Bar Plugin hides the input when 
the keyboard appears
URL: 
https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-439128763
 
 
   Please create a repository on Github and upload the code there. That can be 
checked out and tested directly on  the command line. THanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

2018-11-15 Thread GitBox
tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input 
when the keyboard appears
URL: 
https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-439128431
 
 
   Sorry For the late action. Here's a simple project demonstrating the issue
   
[test.zip](https://github.com/apache/cordova-plugin-statusbar/files/2586414/test.zip)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] theMartux commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

2018-11-15 Thread GitBox
theMartux commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support
URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-439123539
 
 
   > @theMartux
   > I am fairly new to building Apps (like just started this past two months). 
Could you further explain the steps you took to build your app in Xcode using 
the Legacy Build System?
   
   Ciao
   It’s very simple! You should create app with the Cordova CLI command.
   Next step you adding the platform iOS and follow the dpogue's steps in her 
first post.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] theMartux removed a comment on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

2018-11-15 Thread GitBox
theMartux removed a comment on issue #407: [ANNOUNCEMENT] Status of Xcode 10 
support
URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-439122775
 
 
   > @ theMartux
   > Sono abbastanza nuovo nella creazione di app (come appena iniziato negli 
ultimi due mesi). Potresti spiegare ulteriormente i passaggi che hai seguito 
per costruire la tua app in Xcode utilizzando il Legacy Build System?
   
   @barnesdc Ciao 
   E 'molto semplice! Dovresti creare un'app con il comando CLI Cordova. 
   Il prossimo passo è aggiungere la piattaforma iOS e seguire i passi di 
dpogue nel suo primo post.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] theMartux commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

2018-11-15 Thread GitBox
theMartux commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support
URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-439122775
 
 
   > @ theMartux
   > Sono abbastanza nuovo nella creazione di app (come appena iniziato negli 
ultimi due mesi). Potresti spiegare ulteriormente i passaggi che hai seguito 
per costruire la tua app in Xcode utilizzando il Legacy Build System?
   
   @barnesdc Ciao 
   E 'molto semplice! Dovresti creare un'app con il comando CLI Cordova. 
   Il prossimo passo è aggiungere la piattaforma iOS e seguire i passi di 
dpogue nel suo primo post.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] theMartux removed a comment on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

2018-11-15 Thread GitBox
theMartux removed a comment on issue #407: [ANNOUNCEMENT] Status of Xcode 10 
support
URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-439122370
 
 
   @barnesdc Ciao
   It’s very simple! You should create app with the Cordova CLI command.
   Next step you adding the platform iOS and follow the dpogue's steps in her 
first post.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] theMartux commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

2018-11-15 Thread GitBox
theMartux commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support
URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-439122370
 
 
   @barnesdc Ciao
   It’s very simple! You should create app with the Cordova CLI command.
   Next step you adding the platform iOS and follow the dpogue's steps in her 
first post.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] shokry055 commented on issue #119: Getting location with high accuracy taking time more than 4 mins

2018-11-15 Thread GitBox
shokry055 commented on issue #119: Getting location with high accuracy taking 
time more than 4 mins 
URL: 
https://github.com/apache/cordova-plugin-geolocation/issues/119#issuecomment-439119101
 
 
   Time out @janpio


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio commented on issue #562: Updated to 7.1.2 - android.os.DeadObjectException: Transaction failed on small parcel; remote process

2018-11-15 Thread GitBox
janpio commented on issue #562: Updated to 7.1.2 - 
android.os.DeadObjectException: Transaction failed on small parcel; remote 
process
URL: https://github.com/apache/cordova-android/issues/562#issuecomment-439117222
 
 
   > I've attached a full catlog below where I basically click some buttons in 
the app before it breaks.
   
   Can you reproduce the problem consistently? 
   What device are you testing with?
   Can you also reproduce it in a new app created with `cordova create` or only 
in your app?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio commented on issue #119: Getting location with high accuracy taking time more than 4 mins

2018-11-15 Thread GitBox
janpio commented on issue #119: Getting location with high accuracy taking time 
more than 4 mins 
URL: 
https://github.com/apache/cordova-plugin-geolocation/issues/119#issuecomment-439116468
 
 
   @Gurjit-ONEBCG Nokia 6 and iOS 6 doesn't make sense. Do you mean Android 6 
maybe?
   @GPlay97 What platform and device are your experiences with?
   @shokry055 What platform and device? What does `return code 3 TO` mean?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] Motoralfa commented on issue #120: When getting location does'nt return anything or return empty error with a timeout (Android Oreo)

2018-11-15 Thread GitBox
Motoralfa commented on issue #120: When getting location does'nt return 
anything or return empty error with a timeout (Android Oreo)
URL: 
https://github.com/apache/cordova-plugin-geolocation/issues/120#issuecomment-439108524
 
 
   +1
   I tried everything, setting the timeout in the options object, using 
navigator.geolocations, And the only that response is a null object... 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] JacobSiegle opened a new issue #562: Updated to 7.1.2 - android.os.DeadObjectException: Transaction failed on small parcel; remote process

2018-11-15 Thread GitBox
JacobSiegle opened a new issue #562: Updated to 7.1.2 - 
android.os.DeadObjectException: Transaction failed on small parcel; remote 
process
URL: https://github.com/apache/cordova-android/issues/562
 
 
   After updating to the latest Cordova Android (7.1.2) I've received about 80 
crash error reports. They all come from exactly Android 8.0 and they all throw 
this exact same error.
   `java.lang.IllegalStateException: Failure reading AssistStructure data: 
android.os.DeadObjectException: Transaction failed on small parcel; remote 
process probably died`
   
   I've attached a full catlog below where I basically click some buttons in 
the app before it breaks. The app does not break in the browser, i've also not 
received any errors from it's iOS counterpart and it's successfully working on 
every other version of Android.
   
   I've tried selectively pulling out each one of the cordova plugins i've been 
using to see if any of them are causing this issue but haven't had any luck.
   
   I use the following plugins and have ensured all of them are up to date -
   ```
   
   
   
   
   
   
   
   
   
   ```
   
   
[full-catlog.txt](https://github.com/apache/cordova-android/files/2586191/full-catlog.txt)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] barnesdc commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

2018-11-15 Thread GitBox
barnesdc commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support
URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-439093822
 
 
   @theMartux 
   I am fairly new to building Apps (like just started this past two months). 
Could you further explain the steps you took to build your app in Xcode using 
the Legacy Build System?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] f18nfz edited a comment on issue #178: Save to sim card

2018-11-15 Thread GitBox
f18nfz edited a comment on issue #178: Save to sim card
URL: 
https://github.com/apache/cordova-plugin-contacts/issues/178#issuecomment-439085794
 
 
   > @f18nfz On which platform would you like this? Because I do not see this 
happen on iOS for example.
   
   Want to see this on Android 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio commented on issue #115: Audio Capture NullPointerException audio record from sony

2018-11-15 Thread GitBox
janpio commented on issue #115: Audio Capture NullPointerException audio record 
from sony
URL: 
https://github.com/apache/cordova-plugin-media-capture/issues/115#issuecomment-439085743
 
 
   Yep, I'm not an Android developer either, so I have no idea. 
   You can always edit the code and put some manual logging in there ;)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] f18nfz commented on issue #178: Save to sim card

2018-11-15 Thread GitBox
f18nfz commented on issue #178: Save to sim card
URL: 
https://github.com/apache/cordova-plugin-contacts/issues/178#issuecomment-439085794
 
 
   > @f18nfz On which platform would you like this? Because I do not see this 
happen on iOS for example.
   
   Wanted to see this on Android 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] dGodinho edited a comment on issue #115: Audio Capture NullPointerException audio record from sony

2018-11-15 Thread GitBox
dGodinho edited a comment on issue #115: Audio Capture NullPointerException 
audio record from sony
URL: 
https://github.com/apache/cordova-plugin-media-capture/issues/115#issuecomment-439079188
 
 
   yes, "com.horus.enterprise" is my app ID.
   
   Im new to this and i think im kind of lost. Im using Android Studio, deploy 
in debug mode and just check Logcat for errors.
   
   There is any way to put some breakpoints to debug it. Or how can i debug it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] dGodinho edited a comment on issue #115: Audio Capture NullPointerException audio record from sony

2018-11-15 Thread GitBox
dGodinho edited a comment on issue #115: Audio Capture NullPointerException 
audio record from sony
URL: 
https://github.com/apache/cordova-plugin-media-capture/issues/115#issuecomment-439079188
 
 
   yes, "com.horus.enterprise" is my app ID.
   
   Im new this and i think im kind of lost. Im using Android Studio, deploy in 
debug mode and just check Logcat for errors.^
   
   There is any way to put some breakpoints to debug it. Or how can i debug it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] dGodinho commented on issue #115: Audio Capture NullPointerException audio record from sony

2018-11-15 Thread GitBox
dGodinho commented on issue #115: Audio Capture NullPointerException audio 
record from sony
URL: 
https://github.com/apache/cordova-plugin-media-capture/issues/115#issuecomment-439079188
 
 
   yes, "com.horus.enterprise" is my app ID.
   
   Imnew this and i think im kind of lost. Im using Android Studio, deploy in 
debug mode and just check Logcat for errors.^
   
   There is any way to put some breakpoints to debug it. Or how can i debug it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] jcesarmobile commented on issue #547: Compatibility of old plugins with non-Java source-file entries

2018-11-15 Thread GitBox
jcesarmobile commented on issue #547: Compatibility of old plugins with 
non-Java source-file entries
URL: https://github.com/apache/cordova-android/issues/547#issuecomment-439078467
 
 
   The problem is people is using source-file for everything, while they should 
be using resource-file and lib-file in most cases.
   
   source-file should only be used for .java files, so that was the only case 
taken into account
   resource-file and lib-file also got the proper remapping
   
   but as the use of source-file for non source files seems to be massive we 
had to do this patches to handle other file types different from .java.
   
   So trying to fix this is definitely a patch, not a breaking change, the 
purpose of the fix is to make old non updated plugins compatible. If it will 
break plugins that got "fixed" with some workaround, they will have to fix it 
again.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] jcesarmobile closed issue #185: New (Capacitor) contacts plugin to solve deprecated status

2018-11-15 Thread GitBox
jcesarmobile closed issue #185: New (Capacitor) contacts plugin to solve 
deprecated status 
URL: https://github.com/apache/cordova-plugin-contacts/issues/185
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] jcesarmobile commented on issue #185: New (Capacitor) contacts plugin to solve deprecated status

2018-11-15 Thread GitBox
jcesarmobile commented on issue #185: New (Capacitor) contacts plugin to solve 
deprecated status 
URL: 
https://github.com/apache/cordova-plugin-contacts/issues/185#issuecomment-439074302
 
 
   I'll suggest you to look on the network tab to see other active forks 
https://github.com/apache/cordova-plugin-contacts/network
   
   The plugin was deprecated by Cordova committers because the main goal of 
Cordova Core plugins was to be replaced by the browser implementation once the 
vendors catch up, but contacts API was discontinued by W3C, so we did the same.
   
   This only mean Cordova committers will not take care of the plugin anymore, 
but anybody can fork it and maintain it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio commented on issue #185: New (Capacitor) contacts plugin to solve deprecated status

2018-11-15 Thread GitBox
janpio commented on issue #185: New (Capacitor) contacts plugin to solve 
deprecated status 
URL: 
https://github.com/apache/cordova-plugin-contacts/issues/185#issuecomment-439071896
 
 
   Yeah, the "problem" here is that is not a "solution for the community", but 
an invitation to change communities ;) 
   
   I, as a Cordova committer, would greatly prefer a new Cordova plugin for 
contact management. 
   I, as a Ionic user, don't really care if I package my app with Cordova or 
Capacitor.
   
   I'll let the issue live a bit here, hope it gives a few +1 to the issue over 
there.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] brodybits commented on issue #547: Compatibility of old plugins with non-Java source-file entries

2018-11-15 Thread GitBox
brodybits commented on issue #547: Compatibility of old plugins with non-Java 
source-file entries
URL: https://github.com/apache/cordova-android/issues/547#issuecomment-439071894
 
 
   Interesting. So some remapping was introduced in 7.0.0, and some modified 
remapping was introduced in master, as was merged from #550.
   
   We know that the changes to the project structure and file remapping from 
7.0.0 could be considered breaking changes, which evidently broke some plugins. 
This is valid from according to semver rules, but I did not see much in the way 
of notifying the community that plugins would be broken, testing of workaround 
solutions, etc.
   
   From this discussion I have a major concern that the modified remapping as 
introduced in master may prove to be a breaking change, which should definitely 
not be part of a patch release and also should not be part of a minor release.
   
   I think the modified remapping in master could really benefit the user 
community. I am now starting to wonder if we should consider proposing a major 
release, with the modified remapping, in the near future?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] Bramzor commented on issue #185: New (Capacitor) contacts plugin to solve deprecated status

2018-11-15 Thread GitBox
Bramzor commented on issue #185: New (Capacitor) contacts plugin to solve 
deprecated status 
URL: 
https://github.com/apache/cordova-plugin-contacts/issues/185#issuecomment-439070371
 
 
   Good point. If cordova could benefit from the plugins written for Capacitor 
(or the other frameworks), all the better. Seems a lot of cordova plugins can 
use some maintenance done by the other frameworks anyway. For me personally it 
does not matter that much, but in the end we really needed to solve this 
deprecated plugin.
   And yes, it is a bit of advertising for a solution of the competition but as 
the current solution is no more, the community needs an alternative anyway. I 
do not have any relations with Capacitor whatsoever, but it seems that it might 
be a solution to this specific issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio edited a comment on issue #185: New (Capacitor) contacts plugin to solve deprecated status

2018-11-15 Thread GitBox
janpio edited a comment on issue #185: New (Capacitor) contacts plugin to solve 
deprecated status 
URL: 
https://github.com/apache/cordova-plugin-contacts/issues/185#issuecomment-439067963
 
 
   Yes, Cordova plugins can be used with Capacitor (as they built this to be 
able to benefit from all the existing Cordova plugins - smart move). The 
reverse is not true for Capacitor plugins in Cordova unfortunately.
   
   If this **could** even be possible would depend on how the Capacitor plugin 
is implemented. Some of the native functionality is integrated in Capacitor 
itself as "APIs", I haven'T seen to many really external plugins for it yet. 
Could those maybe somehow be integrated in Cordova apps @jcesarmobile?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio commented on issue #185: New (Capacitor) contacts plugin to solve deprecated status

2018-11-15 Thread GitBox
janpio commented on issue #185: New (Capacitor) contacts plugin to solve 
deprecated status 
URL: 
https://github.com/apache/cordova-plugin-contacts/issues/185#issuecomment-439067963
 
 
   Yes, Cordova plugins can be used with Capacitor (as they built this to be 
able to benefit from all the existing Cordova plugins - smart move). The 
reverse is not true for Capacitor plugins in Cordova.
   
   If this could even be possible would depend on how the Capacitor plugin is 
implemented. Some of the native functionality is integrated in Capacitor itself 
as "APIs", I haven'T seen to many really external plugins for it yet. Could 
those maybe somehow be integrated in Cordova apps @jcesarmobile?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] brodybits commented on issue #561: Remove GH-547 update for aidl files

2018-11-15 Thread GitBox
brodybits commented on issue #561: Remove GH-547 update for aidl files
URL: https://github.com/apache/cordova-android/pull/561#issuecomment-439067494
 
 
   Closing for now, at least.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio edited a comment on issue #185: New contacts plugin to solve deprecated status

2018-11-15 Thread GitBox
janpio edited a comment on issue #185: New contacts plugin to solve deprecated 
status
URL: 
https://github.com/apache/cordova-plugin-contacts/issues/185#issuecomment-439065859
 
 
   Important to know: Capacitor is a replacement for Cordova built by Ionic.
   You will not be able to use this new Capacitor plugin with Cordova apps, 
just with Capacitor apps.
   
   I am honestly not sure how to handle this issue here. It's a bit like 
advertising for the competition, but I like Capacitor (and even [wrote a bit 
about it](https://ionic.zone/capacitor)) and having an udpated cross platform 
way to do contacts is definitely needed (I gave the issue my +1). So...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio commented on issue #185: New contacts plugin to solve deprecated status

2018-11-15 Thread GitBox
janpio commented on issue #185: New contacts plugin to solve deprecated status
URL: 
https://github.com/apache/cordova-plugin-contacts/issues/185#issuecomment-439065859
 
 
   Important to know: Capacitor is a replacement for Cordova built by Ionic.
   You will not be able to use this new Capacitor plugin with Cordova apps, 
just with Capacitor apps.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] Bramzor opened a new issue #185: New contacts plugin to solve deprecated status

2018-11-15 Thread GitBox
Bramzor opened a new issue #185: New contacts plugin to solve deprecated status
URL: https://github.com/apache/cordova-plugin-contacts/issues/185
 
 
   As you all know, this plugin was deprecated and no further development or 
bugfixing will be done. This is a major issue for everyone who uses this plugin 
which is a lot of people.
   
   Now their might be a solution, but it all depends on you guys.
   Capacitor is creating a list of plugins they will write and all they needs 
is a thumbs up from you guys to prioritize this plugin!
   https://github.com/ionic-team/capacitor/issues/799
   
   What is Capacitor? Its a way to include native code into your hybrid app (a 
bit like cordova does but better).
   
   
   Help us with your thumbs up: 
https://github.com/ionic-team/capacitor/issues/799


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] jcesarmobile commented on issue #547: Compatibility of old plugins with non-Java source-file entries

2018-11-15 Thread GitBox
jcesarmobile commented on issue #547: Compatibility of old plugins with 
non-Java source-file entries
URL: https://github.com/apache/cordova-android/issues/547#issuecomment-439054347
 
 
   The duplicate problem is not just for the .aidl, it will happen on any 
extension if the plugin maintainer added different source-file tags for the 
same file but different paths for different cordova-android versions.
   I don't think we should fix this, we should keep with the remapping, and ask 
plugin authors to update the plugins, as this will only happen on plugins that 
got updated, not for old unmaintained plugins. 
   
   Other than that, all we can do is copy the file even if it exists instead of 
failing, but that could be even a bigger breaking change.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] kkjhamb01 opened a new issue #460: Issue in Cordova iOS 4.5.5 for xcode 10.0

2018-11-15 Thread GitBox
kkjhamb01 opened a new issue #460: Issue in Cordova iOS 4.5.5 for xcode 10.0
URL: https://github.com/apache/cordova-ios/issues/460
 
 
   I build successfully app in IOS12 / Xcode20 but I am facing many design 
related issues like header disappear after moving to a screen and click not 
working sometimes. So I want to ask you when you release cordova ios 5.0.0 
major release to solve design layout related issue. Please reply as soon as 
possible because this is the very big issue for me and i am hardly waiting for 
your new release .


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] kkjhamb01 closed issue #460: Issue in Cordova iOS 4.5.5 for xcode 10.0

2018-11-15 Thread GitBox
kkjhamb01 closed issue #460: Issue in Cordova iOS 4.5.5 for xcode 10.0
URL: https://github.com/apache/cordova-ios/issues/460
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio commented on issue #561: Remove GH-547 update for aidl files

2018-11-15 Thread GitBox
janpio commented on issue #561: Remove GH-547 update for aidl files
URL: https://github.com/apache/cordova-android/pull/561#issuecomment-439048587
 
 
   Just give this PR here a title and description one can understand without 
reading your works of the last 48 hours. A PR should be self-contained and have 
all the information to understand a change 2 years from now. This is currently 
not the case.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] brodybits commented on issue #561: Remove GH-547 update for aidl files

2018-11-15 Thread GitBox
brodybits commented on issue #561: Remove GH-547 update for aidl files
URL: https://github.com/apache/cordova-android/pull/561#issuecomment-439047606
 
 
   >
   > An alternative solution could be to revert a67bc75
   > 
,
   > which would remove 10 lines from
   > bin/templates/cordova/lib/pluginHandlers.js
   >
   
   Reverts are ugly, I would rather just take the 2 lines out of plugin
   handlers.js as proposed here. Looking forward to the next steps.
   
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] brodybits commented on issue #561: Remove GH-547 update for aidl files

2018-11-15 Thread GitBox
brodybits commented on issue #561: Remove GH-547 update for aidl files
URL: https://github.com/apache/cordova-android/pull/561#issuecomment-439043671
 
 
   GH-547 is an issue that is still open. I already proposed a solution in #550 
and it was merged. But when I rebased it on 7.1.x and did some more testing I 
discovered a case where the changes introduced an issue with a plugin. As I 
said in the OP the reasoning is explained in 
.
   
   This PR does the following in a single commit in order to resolve the 
problem with `https://github.com/j3k0/cordova-plugin-purchase#master`:
   * removes 2 lines from `bin/templates/cordova/lib/pluginHandlers.js` that 
were added in a67bc75b93f4630e3a5ef9b09ad1ed720bbf 
 (PR #550)
   * updates a few lines of test code to reflect the change in behavior, in 
order to resolve the problem with the plugin.
   
   This PR does not revert an entire commit since other changes in the commit 
(a67bc75b93f4630e3a5ef9b09ad1ed720bbf) are needed to resolve GH-547.
   
   An alternative solution could be to revert 
a67bc75b93f4630e3a5ef9b09ad1ed720bbf, which would remove 10 lines from 
`bin/templates/cordova/lib/pluginHandlers.js` along with a few test changes, 
and then add the 8 lines we _do_ want in a separate commit.
   
   I would be happy either way and open to suggestions. I have been up for over 
24 hours and am looking forward to a resolution.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

2018-11-15 Thread GitBox
janpio commented on issue #550: Fix for old plugins with non-Java sources 
(GH-547)
URL: https://github.com/apache/cordova-android/pull/550#issuecomment-439036948
 
 
   So, No.
   
   > I think the biggest downside to combining commits is in case there is a 
need to revert some but not all of the changes for some reason.
   
   I prefer a clean and comprehensible commit history versus already planning 
having to revert stuff.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio commented on issue #561: Remove GH-547 update for aidl files

2018-11-15 Thread GitBox
janpio commented on issue #561: Remove GH-547 update for aidl files
URL: https://github.com/apache/cordova-android/pull/561#issuecomment-439035698
 
 
   What does "Remove GH-547 update for aidl files" mean? Does this revert some 
code from ... what? #547 seems to be an issue...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] davidschreiber commented on a change in pull request #507: Gradle updates

2018-11-15 Thread GitBox
davidschreiber commented on a change in pull request #507: Gradle updates
URL: https://github.com/apache/cordova-android/pull/507#discussion_r233835245
 
 

 ##
 File path: bin/templates/project/app/build.gradle
 ##
 @@ -22,33 +22,32 @@ apply plugin: 'com.android.application'
 buildscript {
 repositories {
 mavenCentral()
-maven {
-url "https://maven.google.com";
-}
+google()
 jcenter()
 }
 
 dependencies {
-classpath 'com.android.tools.build:gradle:3.1.0'
+classpath 'com.android.tools.build:gradle:3.2.0'
 }
 }
 
 // Allow plugins to declare Maven dependencies via build-extras.gradle.
 allprojects {
 repositories {
-mavenCentral();
+mavenCentral()
 jcenter()
 }
 }
 
 task wrapper(type: Wrapper) {
-gradleVersion = '4.4.0'
+gradleVersion = '4.6.0'
 
 Review comment:
   Any reason for not using the latest 4.10.2? It should deliver better build 
speeds and other benefits.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] codecov-io commented on issue #561: Remove GH-547 update for aidl files

2018-11-15 Thread GitBox
codecov-io commented on issue #561: Remove GH-547 update for aidl files
URL: https://github.com/apache/cordova-android/pull/561#issuecomment-439032386
 
 
   # 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/561?src=pr&el=h1) 
Report
   > Merging 
[#561](https://codecov.io/gh/apache/cordova-android/pull/561?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/f1396c7aad169445204638df32d086730f6ad691?src=pr&el=desc)
 will **decrease** coverage by `0.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/561/graphs/tree.svg?width=650&token=q14nMf6C5a&height=150&src=pr)](https://codecov.io/gh/apache/cordova-android/pull/561?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #561  +/-   ##
   ==
   - Coverage   62.11%   62.07%   -0.04% 
   ==
 Files  17   17  
 Lines1985 1983   -2 
 Branches  371  370   -1 
   ==
   - Hits 1233 1231   -2 
 Misses752  752
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-android/pull/561?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[bin/templates/cordova/lib/pluginHandlers.js](https://codecov.io/gh/apache/cordova-android/pull/561/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wbHVnaW5IYW5kbGVycy5qcw==)
 | `86.98% <ø> (-0.16%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/561?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/561?src=pr&el=footer).
 Last update 
[f1396c7...eb868d0](https://codecov.io/gh/apache/cordova-android/pull/561?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] codecov-io edited a comment on issue #561: Remove GH-547 update for aidl files

2018-11-15 Thread GitBox
codecov-io edited a comment on issue #561: Remove GH-547 update for aidl files
URL: https://github.com/apache/cordova-android/pull/561#issuecomment-439032386
 
 
   # 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/561?src=pr&el=h1) 
Report
   > Merging 
[#561](https://codecov.io/gh/apache/cordova-android/pull/561?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/f1396c7aad169445204638df32d086730f6ad691?src=pr&el=desc)
 will **decrease** coverage by `0.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/561/graphs/tree.svg?width=650&token=q14nMf6C5a&height=150&src=pr)](https://codecov.io/gh/apache/cordova-android/pull/561?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #561  +/-   ##
   ==
   - Coverage   62.11%   62.07%   -0.04% 
   ==
 Files  17   17  
 Lines1985 1983   -2 
 Branches  371  370   -1 
   ==
   - Hits 1233 1231   -2 
 Misses752  752
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-android/pull/561?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[bin/templates/cordova/lib/pluginHandlers.js](https://codecov.io/gh/apache/cordova-android/pull/561/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wbHVnaW5IYW5kbGVycy5qcw==)
 | `86.98% <ø> (-0.16%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/561?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/561?src=pr&el=footer).
 Last update 
[f1396c7...eb868d0](https://codecov.io/gh/apache/cordova-android/pull/561?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] brodybits commented on issue #555: [WIP] 7.1.3 patch updates

2018-11-15 Thread GitBox
brodybits commented on issue #555: [WIP] 7.1.3 patch updates
URL: https://github.com/apache/cordova-android/pull/555#issuecomment-439031435
 
 
   Waiting for final approval of 
, which is expected to be 
merged as a merge commit. I will include the merge commit in this proposal once 
it is available.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] brodybits opened a new pull request #561: Remove GH-547 update for aidl files

2018-11-15 Thread GitBox
brodybits opened a new pull request #561: Remove GH-547 update for aidl files
URL: https://github.com/apache/cordova-android/pull/561
 
 
   As discussed in 
 
this update is needed for 
`https://github.com/j3k0/cordova-plugin-purchase#master` (version v7.2.4) to 
work on Android platform. A quick review would be really appreciated.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] brodybits commented on issue #547: Compatibility of old plugins with non-Java source-file entries

2018-11-15 Thread GitBox
brodybits commented on issue #547: Compatibility of old plugins with non-Java 
source-file entries
URL: https://github.com/apache/cordova-android/issues/547#issuecomment-439024555
 
 
   > I wonder if the "fileType" part of `path.join` calls shouldn't be an extra 
attribute of ``.
   
   I think a much better solution is that we move away from using `source-file` 
elements for `.aidl`, library, and framework files. For a followup issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] j3k0 edited a comment on issue #547: Compatibility of old plugins with non-Java source-file entries

2018-11-15 Thread GitBox
j3k0 edited a comment on issue #547: Compatibility of old plugins with non-Java 
source-file entries
URL: https://github.com/apache/cordova-android/issues/547#issuecomment-439023007
 
 
   When I see this proposed patch:
   
   ```js
   } else if (obj.src.endsWith('.java')) {
   return path.join(APP_MAIN_PREFIX, 'java', 
obj.targetDir.substring(4), path.basename(obj.src));
   } else if (obj.src.endsWith('.aidl')) {
   return path.join(APP_MAIN_PREFIX, 'aidl', 
obj.targetDir.substring(4), path.basename(obj.src));
   } else if (obj.targetDir.includes('libs')) {
   if (obj.src.endsWith('.so')) {
   return path.join(APP_MAIN_PREFIX, 'jniLibs', 
obj.targetDir.substring(5), path.basename(obj.src));
   } else {
   return path.join('app', obj.targetDir, path.basename(obj.src));
   }
   ```
   
   I wonder if the "fileType" part of `path.join` calls shouldn't be an extra 
attribute of ``. It could default to this kind of heuristic, but 
allow more flexibility.
   
   Example:
   ```xml
   
   
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] j3k0 edited a comment on issue #547: Compatibility of old plugins with non-Java source-file entries

2018-11-15 Thread GitBox
j3k0 edited a comment on issue #547: Compatibility of old plugins with non-Java 
source-file entries
URL: https://github.com/apache/cordova-android/issues/547#issuecomment-439023007
 
 
   When I see this proposed patch:
   
   ```js
   } else if (obj.src.endsWith('.java')) {
   return path.join(APP_MAIN_PREFIX, 'java', 
obj.targetDir.substring(4), path.basename(obj.src));
   } else if (obj.src.endsWith('.aidl')) {
   return path.join(APP_MAIN_PREFIX, 'aidl', 
obj.targetDir.substring(4), path.basename(obj.src));
   } else if (obj.targetDir.includes('libs')) {
   if (obj.src.endsWith('.so')) {
   return path.join(APP_MAIN_PREFIX, 'jniLibs', 
obj.targetDir.substring(5), path.basename(obj.src));
   } else {
   return path.join('app', obj.targetDir, path.basename(obj.src));
   }
   ```
   
   I wonder if the "fileType" part of `path.join` calls shouldn't be an extra 
attribute of ``. It could default to this kind of heuristic, but 
allow more flexibility.
   
   Example:
   ```xml
   
   
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] j3k0 commented on issue #547: Compatibility of old plugins with non-Java source-file entries

2018-11-15 Thread GitBox
j3k0 commented on issue #547: Compatibility of old plugins with non-Java 
source-file entries
URL: https://github.com/apache/cordova-android/issues/547#issuecomment-439023007
 
 
   When I see this proposed patch:
   
   ```js
   } else if (obj.src.endsWith('.java')) {
   return path.join(APP_MAIN_PREFIX, 'java', 
obj.targetDir.substring(4), path.basename(obj.src));
   } else if (obj.src.endsWith('.aidl')) {
   return path.join(APP_MAIN_PREFIX, 'aidl', 
obj.targetDir.substring(4), path.basename(obj.src));
   } else if (obj.targetDir.includes('libs')) {
   if (obj.src.endsWith('.so')) {
   return path.join(APP_MAIN_PREFIX, 'jniLibs', 
obj.targetDir.substring(5), path.basename(obj.src));
   } else {
   return path.join('app', obj.targetDir, path.basename(obj.src));
   }
   ```
   
   I wonder if the "fileType" part of `path.join` calls shouldn't be an extra 
attribute of ``. It could default to this kind of heuristic, but 
allow more flexibility.
   
   Example:
   ```xml
   
   
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

2018-11-15 Thread GitBox
brodybits commented on issue #550: Fix for old plugins with non-Java sources 
(GH-547)
URL: https://github.com/apache/cordova-android/pull/550#issuecomment-439022502
 
 
   > Was @jcesarmobile's feedback on how to merge or not merge this taken into 
account?
   
   I think the edit was too late. Not sure if I would have done it exactly that 
way, but probably would have been good to combine _some_ of the commits.
   
   I think the biggest downside to combining commits is in case there is a need 
to revert some but not all of the changes for some reason.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio commented on issue #375: Not supporting on browser

2018-11-15 Thread GitBox
janpio commented on issue #375: Not supporting on browser 
URL: 
https://github.com/apache/cordova-plugin-camera/issues/375#issuecomment-439020789
 
 
   Ionic Native documentation links to this repository as it is the the Cordova 
plugin being used by the Ionic Native wrapper. But if you have problems using 
the Ionic Native wrapper, you still have to go to the Ionic Native repository - 
we can't help for that.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio edited a comment on issue #115: Audio Capture NullPointerException audio record from sony

2018-11-15 Thread GitBox
janpio edited a comment on issue #115: Audio Capture NullPointerException audio 
record from sony
URL: 
https://github.com/apache/cordova-plugin-media-capture/issues/115#issuecomment-439019449
 
 
   Is `com.horus.enterprise` your app ID?
   
   The error seems to come from here: 
https://github.com/apache/cordova-plugin-media-capture/blob/288a47eee12b8cff7c3512d87b5aa2023daa46d5/src/android/Capture.java#L454
   
   `java.lang.NullPointerException: Attempt to invoke virtual method 
'java.lang.String java.io.File.getAbsolutePath()' on a null object reference` 
then means that `fp` was null here.
   
   It was created at the start of this method:
   
https://github.com/apache/cordova-plugin-media-capture/blob/288a47eee12b8cff7c3512d87b5aa2023daa46d5/src/android/Capture.java#L433
   
   So the question is why did `webView.getResourceApi().mapUriToFile(data);` 
return null - maybe `data` was already empty? Why didn't this method itself 
also throw an error instead of just returning null?
   
   That's where I would start to investigate and debugging.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio edited a comment on issue #115: Audio Capture NullPointerException audio record from sony

2018-11-15 Thread GitBox
janpio edited a comment on issue #115: Audio Capture NullPointerException audio 
record from sony
URL: 
https://github.com/apache/cordova-plugin-media-capture/issues/115#issuecomment-439019449
 
 
   Is `com.horus.enterprise` your app ID?
   
   ---
   
   The error seems to come from here: 
https://github.com/apache/cordova-plugin-media-capture/blob/288a47eee12b8cff7c3512d87b5aa2023daa46d5/src/android/Capture.java#L454
   
   `java.lang.NullPointerException: Attempt to invoke virtual method 
'java.lang.String java.io.File.getAbsolutePath()' on a null object reference` 
then means that `fp` was null here.
   
   It was created at the start of this method:
   
https://github.com/apache/cordova-plugin-media-capture/blob/288a47eee12b8cff7c3512d87b5aa2023daa46d5/src/android/Capture.java#L433
   
   So the question is why did `webView.getResourceApi().mapUriToFile(data);` 
return null - maybe `data` was already empty? Why didn't this method itself 
also throw an error instead of just returning null?
   
   That's where I would start to investigate and debugging.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] Cui-y closed issue #64: Layout abnormal under iPhone X+

2018-11-15 Thread GitBox
Cui-y closed issue #64: Layout abnormal under iPhone X+
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/issues/64
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] brodybits commented on issue #547: Compatibility of old plugins with non-Java source-file entries

2018-11-15 Thread GitBox
brodybits commented on issue #547: Compatibility of old plugins with non-Java 
source-file entries
URL: https://github.com/apache/cordova-android/issues/547#issuecomment-439019566
 
 
   From 
:
   > Maybe ignore `` entries that start with `app/src/main/aidl/` 
if you're not on a Android Studio project?
   
   cordova-android@7 project structure seems to be based on Android Studio 
project structure now, don't see how this could make a difference. Any other 
input would be appreciated.
   
   > More longer term, I wonder if a definite solution wouldn't be to support 
`.aidl` natively on cordova-android?
   
   +1
   
   > Example `` entry:
   > [...]
   
   Cordova seems to use more portable tags such as `header-file`, 
`source-file`, `lib-file`, `framework`, etc. Maybe we could add something like 
an `interface` tag or `idl` tag.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio commented on issue #115: Audio Capture NullPointerException audio record from sony

2018-11-15 Thread GitBox
janpio commented on issue #115: Audio Capture NullPointerException audio record 
from sony
URL: 
https://github.com/apache/cordova-plugin-media-capture/issues/115#issuecomment-439019449
 
 
   Is `com.horus.enterprise` your app ID?
   
   The error seems to come from here: 
https://github.com/apache/cordova-plugin-media-capture/blob/288a47eee12b8cff7c3512d87b5aa2023daa46d5/src/android/Capture.java#L454


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] amitgandole edited a comment on issue #375: Not supporting on browser

2018-11-15 Thread GitBox
amitgandole edited a comment on issue #375: Not supporting on browser 
URL: 
https://github.com/apache/cordova-plugin-camera/issues/375#issuecomment-439018935
 
 
   haha.. wow.. and I redirected to this repo from official ionic website. 
Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] amitgandole commented on issue #375: Not supporting on browser

2018-11-15 Thread GitBox
amitgandole commented on issue #375: Not supporting on browser 
URL: 
https://github.com/apache/cordova-plugin-camera/issues/375#issuecomment-439018935
 
 
   haha.. wow.. and I and redirected to this repo from official ionic website. 
Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio edited a comment on issue #375: Not supporting on browser

2018-11-15 Thread GitBox
janpio edited a comment on issue #375: Not supporting on browser 
URL: 
https://github.com/apache/cordova-plugin-camera/issues/375#issuecomment-439018458
 
 
   As I wrote, you are in the wrong place here then. You are looking for 
https://github.com/ionic-team/ionic-native/issues/
   
   Besides that:
   
   > But when I run same on mobile browser, Its saying cordova not available.
   
   If you run the app in the mobile browser, it is not running in a Cordova app 
and Cordova is not available. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio closed issue #375: Not supporting on browser

2018-11-15 Thread GitBox
janpio closed issue #375: Not supporting on browser 
URL: https://github.com/apache/cordova-plugin-camera/issues/375
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio commented on issue #375: Not supporting on browser

2018-11-15 Thread GitBox
janpio commented on issue #375: Not supporting on browser 
URL: 
https://github.com/apache/cordova-plugin-camera/issues/375#issuecomment-439018458
 
 
   As I wrote, you are in the wrong place here then. You are looking for 
https://github.com/ionic-team/ionic-native/issues/


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio commented on issue #374: Multiple capture crashes the Application

2018-11-15 Thread GitBox
janpio commented on issue #374: Multiple capture crashes the Application
URL: 
https://github.com/apache/cordova-plugin-camera/issues/374#issuecomment-439018336
 
 
   I got that. But does this have to do with your question on how to remove 
some files?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

2018-11-15 Thread GitBox
janpio commented on issue #550: Fix for old plugins with non-Java sources 
(GH-547)
URL: https://github.com/apache/cordova-android/pull/550#issuecomment-439018225
 
 
   Was @jcesarmobile's feedback on how to merge or not merge this taken into 
account?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] brodybits edited a comment on issue #547: Compatibility of old plugins with non-Java source-file entries

2018-11-15 Thread GitBox
brodybits edited a comment on issue #547: Compatibility of old plugins with 
non-Java source-file entries
URL: https://github.com/apache/cordova-android/issues/547#issuecomment-439016006
 
 
   Updates as proposed in PR #550 are now on the master branch. But I 
discovered that if I try adding  
`https://github.com/j3k0/cordova-plugin-purchase#master` (v7.2.4) with these 
updates then it fails due to a duplicated `.aidl` file. This is a breaking 
change which is not wanted in patch release and not desired in the near future. 
The legacy target-dir mapping for `.aidl` files will be removed in an upcoming 
PR.
   
   I had an interesting discussion with @j3k0, with some good ideas in 
, would rather 
discuss these ideas here or in another Cordova issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] dGodinho commented on issue #115: Audio Capture NullPointerException audio record from sony

2018-11-15 Thread GitBox
dGodinho commented on issue #115: Audio Capture NullPointerException audio 
record from sony
URL: 
https://github.com/apache/cordova-plugin-media-capture/issues/115#issuecomment-439017612
 
 
   Already did it. Thanks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] dGodinho opened a new issue #116: Supported apps for audio record

2018-11-15 Thread GitBox
dGodinho opened a new issue #116: Supported apps for audio record
URL: https://github.com/apache/cordova-plugin-media-capture/issues/116
 
 
   As far as i know, on android, only 2 apps support this pluggin (act = 
android.provider.MediaStore.RECORD_SOUND).
   
   - Audio Recorder from sony
   - Samsung Voice Recorder
   
   There are any more app that can run this plugin properly?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] brodybits commented on issue #547: Compatibility of old plugins with non-Java source-file entries

2018-11-15 Thread GitBox
brodybits commented on issue #547: Compatibility of old plugins with non-Java 
source-file entries
URL: https://github.com/apache/cordova-android/issues/547#issuecomment-439016006
 
 
   Updates as proposed in PR #550 are now on the master branch. But I 
discovered that if I try adding  
`https://github.com/j3k0/cordova-plugin-purchase#master` (v7.2.4) with these 
updates then it fails due to a duplicated `.aidl` file. This is a breaking 
change which is not wanted in patch release and not desired in the near future. 
The legacy target-dir mapping will be removed in an upcoming PR.
   
   I had an interesting discussion with @j3k0, with some good ideas in 
, would rather 
discuss these ideas here or in another Cordova issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] sks30 commented on issue #374: Multiple capture crashes the Application

2018-11-15 Thread GitBox
sks30 commented on issue #374: Multiple capture crashes the Application
URL: 
https://github.com/apache/cordova-plugin-camera/issues/374#issuecomment-439013767
 
 
   yes due to multiple capture these crash things are happening.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio commented on issue #374: Multiple capture crashes the Application

2018-11-15 Thread GitBox
janpio commented on issue #374: Multiple capture crashes the Application
URL: 
https://github.com/apache/cordova-plugin-camera/issues/374#issuecomment-439013218
 
 
   Yes, that I got. But does it have to do with your question in 
https://github.com/apache/cordova-plugin-camera/issues/374#issuecomment-439011146?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] amitgandole edited a comment on issue #375: Not supporting on browser

2018-11-15 Thread GitBox
amitgandole edited a comment on issue #375: Not supporting on browser 
URL: 
https://github.com/apache/cordova-plugin-camera/issues/375#issuecomment-439012994
 
 
   DevApp is IONIC DevApp which allows to  run app without installation. and i 
have declared the camera constructor in constructor : 
   `constructor(public navCtrl: NavController,public camera: Camera) {}`
   
   Also in import section : 
   `import { Camera, CameraOptions } from '@ionic-native/camera';`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] amitgandole commented on issue #375: Not supporting on browser

2018-11-15 Thread GitBox
amitgandole commented on issue #375: Not supporting on browser 
URL: 
https://github.com/apache/cordova-plugin-camera/issues/375#issuecomment-439012994
 
 
   DevApp is IONIC DevApp which allows to  run app without installation. and i 
have declared the camera constructor in constructor : `constructor(public 
navCtrl: NavController,
   public camera: Camera) {
   
 }`
   
   Also in import section : 
   `import { Camera, CameraOptions } from '@ionic-native/camera';
   `


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio commented on issue #115: Audio Capture NullPointerException audio record from sony

2018-11-15 Thread GitBox
janpio commented on issue #115: Audio Capture NullPointerException audio record 
from sony
URL: 
https://github.com/apache/cordova-plugin-media-capture/issues/115#issuecomment-439012235
 
 
   Please open a new issue for your first question so this can be answered 
separately from your NullPointerException. Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] sks30 commented on issue #374: Multiple capture crashes the Application

2018-11-15 Thread GitBox
sks30 commented on issue #374: Multiple capture crashes the Application
URL: 
https://github.com/apache/cordova-plugin-camera/issues/374#issuecomment-439012272
 
 
   When user add document image to preview from camera or gallery, then storage 
increase, and it does not get cleared up on cancelling the preview or uploading 
the document successfully. If user adds image to preview and cancel it- Repeat 
5 times, then storage keeps on increasing and finally crashing.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio commented on issue #375: Not supporting on browser

2018-11-15 Thread GitBox
janpio commented on issue #375: Not supporting on browser 
URL: 
https://github.com/apache/cordova-plugin-camera/issues/375#issuecomment-439011988
 
 
   What is "DevApp"?
   
   Also, what is `this.camera`? The plugin is available under 
`navigator.camera`.
   
   Are you using Ionic Native maybe? Then you should probably open an issue at 
their repository - you are at the Cordova plugin's repository that is used by 
Ionic Native.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] sks30 commented on issue #374: Multiple capture crashes the Application

2018-11-15 Thread GitBox
sks30 commented on issue #374: Multiple capture crashes the Application
URL: 
https://github.com/apache/cordova-plugin-camera/issues/374#issuecomment-439011962
 
 
   If i am doing those process explained above multiple times then Android app 
is crashing.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



  1   2   >