brodybits commented on issue #550: Fix for old plugins with non-Java sources 
(GH-547)
URL: https://github.com/apache/cordova-android/pull/550#issuecomment-439022502
 
 
   > Was @jcesarmobile's feedback on how to merge or not merge this taken into 
account?
   
   I think the edit was too late. Not sure if I would have done it exactly that 
way, but probably would have been good to combine _some_ of the commits.
   
   I think the biggest downside to combining commits is in case there is a need 
to revert some but not all of the changes for some reason.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

Reply via email to