[GitHub] janpio commented on issue #563: [Fix] better support to find Home path for window
janpio commented on issue #563: [Fix] better support to find Home path for window URL: https://github.com/apache/cordova-android/pull/563#issuecomment-439713042 Pull Request reviews relate to the code being suggested in the Pull Request, so yes - I just made sure it is clear that this should not be merged by anyone. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #563: [Fix] better support to find Home path for window
janpio commented on issue #563: [Fix] better support to find Home path for window URL: https://github.com/apache/cordova-android/pull/563#issuecomment-439710421 Thanks @raphinesse for this necessary context. So if we decide to keep this functionality, it would probably make sense to switch over to using this package (any maybe make this available to all platforms along the way?). The package uses `os.homedir()` internally, which is probably a _lot_ more stable than any hack we can place in our code ourselves. Agree? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #563: [Fix] better support to find Home path for window
janpio commented on issue #563: [Fix] better support to find Home path for window URL: https://github.com/apache/cordova-android/pull/563#issuecomment-439701558 After writing this, I decided to look into why this tilde code is there in the first place: https://github.com/apache/cordova-android/commit/d78ae309f1234cec4f1651a7140508ff1b1dda32 https://issues.apache.org/jira/browse/CB-10105 Maybe this is not needed any more in the first place as the problem in node was fixed? Anyway, the usage of environment variables in the path itself is a totally new and different feature and I am not sure this is the way to go. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #563: [Fix] better support to find Home path for window
janpio commented on issue #563: [Fix] better support to find Home path for window URL: https://github.com/apache/cordova-android/pull/563#issuecomment-439701170 So your issue is that you develop your app on different computers. To be able to use the same `build.json` on all machines, you used `~` in the path to the keystore - but this didn't work as `HOME` was not correctly set on some machines. Is that correct? And to "fix" that, you now implemented this PR that allows the usage of `$HOME`, `%HOMEPATH%` and `%USERPROFILE%` instead of only `~` in the path of the keystore. But doesn't this still mean that all computer using the build.json still have to have exactly one of those environment variables set to work? Wouldn't it make more sense to try to replace `~` with all those environment variables, whichever are available instead of just offering alternatives? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #563: [Fix] better support to find Home path for window
janpio commented on issue #563: [Fix] better support to find Home path for window URL: https://github.com/apache/cordova-android/pull/563#issuecomment-439368754 Hm, first time I see this. Is the `~` behavior documented anywhere? Where did you learn that you can do it this way? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
