[GitHub] [incubator-echarts] MarxZhou commented on issue #11278: 主题构建工具需要添加关于渐变色的全局配置项

2019-09-19 Thread GitBox
MarxZhou commented on issue #11278: 主题构建工具需要添加关于渐变色的全局配置项
URL: 
https://github.com/apache/incubator-echarts/issues/11278#issuecomment-533418348
 
 
   > 为什么是「开关」?其实就是你把传入的 option 记录一下,下次在这个基础上改就行了。
   
   我之前没有描述清楚。
   我希望这里既可以传入自定义配置,也可以支持布尔值。
   
   例如传入一个truthy后,可以自动实现类似下图中的简单渐变色效果。
   也就是说希望echarts可以内置一些简单的效果,毕竟我的审美不是很好。
   
   
![360截图20190920135109919](https://user-images.githubusercontent.com/39861054/65302482-e9368400-dbad-11e9-86e1-a2aa50b9dad8.jpg)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] MarxZhou commented on issue #11278: 主题构建工具需要添加关于渐变色的全局配置项

2019-09-19 Thread GitBox
MarxZhou commented on issue #11278: 主题构建工具需要添加关于渐变色的全局配置项
URL: 
https://github.com/apache/incubator-echarts/issues/11278#issuecomment-533416362
 
 
   > 为什么是「开关」?其实就是你把传入的 option 记录一下,下次在这个基础上改就行了。
   
   我之前没有描述清楚。
   我希望这里既可以传入自定义配置,也可以支持布尔值。


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] MarxZhou removed a comment on issue #11278: 主题构建工具需要添加关于渐变色的全局配置项

2019-09-19 Thread GitBox
MarxZhou removed a comment on issue #11278: 主题构建工具需要添加关于渐变色的全局配置项
URL: 
https://github.com/apache/incubator-echarts/issues/11278#issuecomment-533416362
 
 
   > 为什么是「开关」?其实就是你把传入的 option 记录一下,下次在这个基础上改就行了。
   
   我之前没有描述清楚。
   我希望这里既可以传入自定义配置,也可以支持布尔值。


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] surplus-cat commented on issue #5346: y坐标轴标题(name)文字位置不能相对于y轴居左的问题

2019-09-19 Thread GitBox
surplus-cat commented on issue #5346: y坐标轴标题(name)文字位置不能相对于y轴居左的问题
URL: 
https://github.com/apache/incubator-echarts/issues/5346#issuecomment-533416190
 
 
   nameRotate 的单位不是px吧,而且设置成0.1和1 效果都是一样的,需求是要求和legend 左对齐,发现只能通过加空格对齐。


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] MarxZhou commented on issue #11278: 主题构建工具需要添加关于渐变色的全局配置项

2019-09-19 Thread GitBox
MarxZhou commented on issue #11278: 主题构建工具需要添加关于渐变色的全局配置项
URL: 
https://github.com/apache/incubator-echarts/issues/11278#issuecomment-533415930
 
 
   > 为什么是「开关」?其实就是你把传入的 option 记录一下,下次在这个基础上改就行了。
   
   我可能没有描述清楚。


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] MarxZhou removed a comment on issue #11278: 主题构建工具需要添加关于渐变色的全局配置项

2019-09-19 Thread GitBox
MarxZhou removed a comment on issue #11278: 主题构建工具需要添加关于渐变色的全局配置项
URL: 
https://github.com/apache/incubator-echarts/issues/11278#issuecomment-533415930
 
 
   > 为什么是「开关」?其实就是你把传入的 option 记录一下,下次在这个基础上改就行了。
   
   我可能没有描述清楚。


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] Ovilia commented on issue #11241: 用graphic实现拖拽的散点图,当series开启large:true,且点的数量超过largeThreshold 的设置时候,tooltip消失

2019-09-19 Thread GitBox
Ovilia commented on issue #11241: 
用graphic实现拖拽的散点图,当series开启large:true,且点的数量超过largeThreshold 的设置时候,tooltip消失
URL: 
https://github.com/apache/incubator-echarts/issues/11241#issuecomment-533408555
 
 
   Remove the `triggerOn: 'none'` and you will have the tooltip.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] Ovilia commented on issue #11278: 主题构建工具需要添加关于渐变色的全局配置项

2019-09-19 Thread GitBox
Ovilia commented on issue #11278: 主题构建工具需要添加关于渐变色的全局配置项
URL: 
https://github.com/apache/incubator-echarts/issues/11278#issuecomment-533407920
 
 
   为什么是「开关」?其实就是你把传入的 option 记录一下,下次在这个基础上改就行了。


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] microchang commented on issue #11241: 用graphic实现拖拽的散点图,当series开启large:true,且点的数量超过largeThreshold 的设置时候,tooltip消失

2019-09-19 Thread GitBox
microchang commented on issue #11241: 
用graphic实现拖拽的散点图,当series开启large:true,且点的数量超过largeThreshold 的设置时候,tooltip消失
URL: 
https://github.com/apache/incubator-echarts/issues/11241#issuecomment-533406437
 
 
   hello?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] kangning1206 opened a new issue #11289: 网站页面 https://gallery.echartsjs.com/help.html 增加搜索

2019-09-19 Thread GitBox
kangning1206 opened a new issue #11289: 网站页面  
https://gallery.echartsjs.com/help.html 增加搜索
URL: https://github.com/apache/incubator-echarts/issues/11289
 
 
   echars官网 【问题交流】版本怎么没有搜索?难道是我没找到?太不方便了;
   https://gallery.echartsjs.com/help.html
   
   我需要搜索geo坐标,是不是对dataZoom缩放不支持,我现在移动端需要对地图手势缩放。
   
   
![image](https://user-images.githubusercontent.com/6220088/65297514-bafb7900-db9a-11e9-940a-0c77cdfcfeaf.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-robot[bot] closed issue #11289: 网站页面 https://gallery.echartsjs.com/help.html 增加搜索

2019-09-19 Thread GitBox
echarts-robot[bot] closed issue #11289: 网站页面  
https://gallery.echartsjs.com/help.html 增加搜索
URL: https://github.com/apache/incubator-echarts/issues/11289
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-robot[bot] commented on issue #11289: 网站页面 https://gallery.echartsjs.com/help.html 增加搜索

2019-09-19 Thread GitBox
echarts-robot[bot] commented on issue #11289: 网站页面  
https://gallery.echartsjs.com/help.html 增加搜索
URL: 
https://github.com/apache/incubator-echarts/issues/11289#issuecomment-533391230
 
 
   This issue is not created using [issue 
template](https://ecomfe.github.io/echarts-issue-helper/) so I'm going to close 
it. 
   Sorry for this, but it helps save our maintainers' time so that more 
developers get helped.
   Feel free to create another issue using the issue template.
   
   If you think you have already made your point clear without the template, or 
your problem cannot be covered by it, you may re-open this issue again.
   
   这个 issue 未使用 [issue 
模板](https://ecomfe.github.io/echarts-issue-helper/?lang=zh-cn) 创建,所以我将关闭此 issue。
   为此带来的麻烦我深表歉意,但是请理解这是为了节约社区维护者的时间,以更高效地服务社区的开发者群体。
   如果您愿意,可以请使用 issue 模板重新创建 issue。
   
   如果你认为虽然没有使用模板,但你已经提供了复现问题的充分描述,或者你的问题无法使用模板表达,也可以重新 open 这个 issue。


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang edited a comment on issue #11267: 折线图在图表容器宽高更高情况下,图表被严重压缩,无法正确显示

2019-09-19 Thread GitBox
pissang edited a comment on issue #11267: 折线图在图表容器宽高更高情况下,图表被严重压缩,无法正确显示
URL: 
https://github.com/apache/incubator-echarts/issues/11267#issuecomment-533374361
 
 
   Thanks, @alex2wong . The grid top is a fixed height by default. It's for the 
space of legend, title, toolbox or other components. Currently, this is not 
automatically layout. You can change the top with the option 
[grid.height](https://echarts.apache.org/en/option.html#grid.height). It can be 
fixed height or a percent value.
   
   About the issue @CeleKing asked. The container height is too small and it 
caused the grid height to a negative value. 
   
   Perhaps we can limit the value to zero to avoid confusing. Of course, the 
best solution is adding automatically layout to utilize the space as much as 
possible.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang edited a comment on issue #11267: 折线图在图表容器宽高更高情况下,图表被严重压缩,无法正确显示

2019-09-19 Thread GitBox
pissang edited a comment on issue #11267: 折线图在图表容器宽高更高情况下,图表被严重压缩,无法正确显示
URL: 
https://github.com/apache/incubator-echarts/issues/11267#issuecomment-533374361
 
 
   Thanks, @alex2wong . The grid top is a fixed height by default. It's for the 
space of legend, title, toolbox or other components. Currently, this is not 
automatically layout. You can configure it with option 
[grid.height](https://echarts.apache.org/en/option.html#grid.height)
   
   About the issue @CeleKing asked. The container height is too small and it 
caused the grid height to a negative value. 
   
   Perhaps we can limit the value to zero to avoid confusing. Of course, the 
best solution is adding automatically layout to utilize the space as much as 
possible.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang edited a comment on issue #11267: 折线图在图表容器宽高更高情况下,图表被严重压缩,无法正确显示

2019-09-19 Thread GitBox
pissang edited a comment on issue #11267: 折线图在图表容器宽高更高情况下,图表被严重压缩,无法正确显示
URL: 
https://github.com/apache/incubator-echarts/issues/11267#issuecomment-533374361
 
 
   Thanks, @alex2wong . The grid top is a fixed height id default for the space 
of legend, title, toolbox or other components. Currently, this is not 
automatically layout. You can configure it with option 
[grid.height](https://echarts.apache.org/en/option.html#grid.height)
   
   About the issue @CeleKing asked. The container height is too small and it 
caused the grid height to a negative value. 
   
   Perhaps we can limit the value to zero to avoid confusing. Of course, the 
best solution is adding automatically layout to utilize the space as much as 
possible.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] MarxZhou commented on issue #11278: 主题构建工具需要添加关于渐变色的全局配置项

2019-09-19 Thread GitBox
MarxZhou commented on issue #11278: 主题构建工具需要添加关于渐变色的全局配置项
URL: 
https://github.com/apache/incubator-echarts/issues/11278#issuecomment-533376229
 
 
   > 那这个问题就解决了?
   
   
我认为是的,我最初的目的只是希望在引用主题构建工具生成的js文件时能够提供一个是否开启渐变色的开关。因为我前两天引入js文件的时候,折线图中的渐变色只能通过Option.series.areaStyle.color进行逐个设置。如果有这么一个开关的话,我就不必再写代码遍历了


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang closed issue #8935: Stacked Bar with dataZoom regression (4.1.0)

2019-09-19 Thread GitBox
pissang closed issue #8935: Stacked Bar with dataZoom regression (4.1.0)
URL: https://github.com/apache/incubator-echarts/issues/8935
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang closed issue #9751: geo event with geoRoam

2019-09-19 Thread GitBox
pissang closed issue #9751: geo event with geoRoam
URL: https://github.com/apache/incubator-echarts/issues/9751
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang closed issue #8848: bug: Bar series with multiple axis

2019-09-19 Thread GitBox
pissang closed issue #8848: bug: Bar series with multiple axis
URL: https://github.com/apache/incubator-echarts/issues/8848
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang closed issue #11086: Bug with stack bar with min value

2019-09-19 Thread GitBox
pissang closed issue #11086: Bug with stack bar with min value
URL: https://github.com/apache/incubator-echarts/issues/11086
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] branch master updated (fcf80fe -> e239a02)

2019-09-19 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git.


from fcf80fe  fix(lint): fix code style by eslint.
 add 0b2b5e6  feat: add clip option on scatter series
 add 755787f  fix: fix scatter clipping on polar
 add 70e8e6c  Merge branch 'master' into feature/clip
 add dc7aade  WIP(clip): Rename clipOverflow to clip in line series
 add 94dfc92  WIP(clip): support clip in lines series
 add d80db8e  feat(dataZoom): Add filterMode in the toolbox dataZoom 
feature.
 add 47116e7  fix(dataZoom): set filterMode from toolbox dataZoom in 
preprocessor
 add 9cfe402  test: fix random in the echarts caused random in demo 
inconsistent between versions.
 add de98ef6  feat(clip): clip bar on grid.
 add 3c78e96  feat(clip): support clip in custom series and large bar.
 add 2bbb297  test: add recorded action for clip test. not save result when 
replay in recorder page.
 add 5c2d8cf  fix(clip): only access clip option in series.
 new e239a02  Merge pull request #11283 from apache/feature/clip

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 src/chart/bar/BarSeries.js |   7 +-
 src/chart/bar/BarView.js   |  87 +++
 src/chart/custom.js|  20 +-
 src/chart/helper/LargeSymbolDraw.js|  22 +-
 src/chart/helper/createClipPathFromCoordSys.js | 101 +++
 src/chart/line/LineSeries.js   |   2 +-
 src/chart/line/LineView.js | 163 ++---
 src/chart/lines/LinesSeries.js |   4 +
 src/chart/lines/LinesView.js   |  11 +
 src/chart/scatter/ScatterSeries.js |   6 +-
 src/chart/scatter/ScatterView.js   |  19 +-
 src/component/toolbox/feature/DataZoom.js  |   3 +
 src/coord/cartesian/Cartesian2D.js |  31 +
 src/coord/polar/Polar.js   |  38 +
 src/layout/barGrid.js  |  18 +-
 src/preprocessor/backwardCompat.js |   9 +-
 test/clip.html | 961 +
 test/runTest/actions/__meta__.json |   3 +-
 test/runTest/actions/clip.json |   1 +
 test/runTest/cli.js| 113 +--
 test/runTest/config.js |   1 +
 test/runTest/runtime/main.js   |  11 +-
 test/runTest/server.js |  32 +-
 test/runTest/util.js   |  23 +-
 24 files changed, 1474 insertions(+), 212 deletions(-)
 create mode 100644 src/chart/helper/createClipPathFromCoordSys.js
 create mode 100644 test/clip.html
 create mode 100644 test/runTest/actions/clip.json


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] 01/01: Merge pull request #11283 from apache/feature/clip

2019-09-19 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git

commit e239a020f115689c639dbe33e26efc4d29938f18
Merge: fcf80fe 5c2d8cf
Author: Yi Shen 
AuthorDate: Fri Sep 20 10:13:45 2019 +0800

Merge pull request #11283 from apache/feature/clip

Add clip option for line, bar, lines, scatter, custom series

 src/chart/bar/BarSeries.js |   7 +-
 src/chart/bar/BarView.js   |  87 +++
 src/chart/custom.js|  20 +-
 src/chart/helper/LargeSymbolDraw.js|  22 +-
 src/chart/helper/createClipPathFromCoordSys.js | 101 +++
 src/chart/line/LineSeries.js   |   2 +-
 src/chart/line/LineView.js | 163 ++---
 src/chart/lines/LinesSeries.js |   4 +
 src/chart/lines/LinesView.js   |  11 +
 src/chart/scatter/ScatterSeries.js |   6 +-
 src/chart/scatter/ScatterView.js   |  19 +-
 src/component/toolbox/feature/DataZoom.js  |   3 +
 src/coord/cartesian/Cartesian2D.js |  31 +
 src/coord/polar/Polar.js   |  38 +
 src/layout/barGrid.js  |  18 +-
 src/preprocessor/backwardCompat.js |   9 +-
 test/clip.html | 961 +
 test/runTest/actions/__meta__.json |   3 +-
 test/runTest/actions/clip.json |   1 +
 test/runTest/cli.js| 113 +--
 test/runTest/config.js |   1 +
 test/runTest/runtime/main.js   |  11 +-
 test/runTest/server.js |  32 +-
 test/runTest/util.js   |  23 +-
 24 files changed, 1474 insertions(+), 212 deletions(-)



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang merged pull request #11283: Add clip option for line, bar, lines, scatter, custom series

2019-09-19 Thread GitBox
pissang merged pull request #11283: Add clip option for line, bar, lines, 
scatter, custom series
URL: https://github.com/apache/incubator-echarts/pull/11283
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] fuyunfeng961010 commented on issue #11284: X轴的 文字能否紧贴刻度线布局

2019-09-19 Thread GitBox
fuyunfeng961010 commented on issue #11284: X轴的  文字能否紧贴刻度线布局
URL: 
https://github.com/apache/incubator-echarts/issues/11284#issuecomment-533374629
 
 
   @Ovilia 谢谢  但rich属性中貌似也并没有能解决当前问题的属性  我早已尝试过 或许是我没有找到正确的方法


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] Ovilia commented on issue #11288: AxisPointer make a hidden symbol display in line chart

2019-09-19 Thread GitBox
Ovilia commented on issue #11288: AxisPointer make a hidden symbol display in 
line chart
URL: 
https://github.com/apache/incubator-echarts/issues/11288#issuecomment-533373883
 
 
   Please provide a demo based on https://jsfiddle.net/ovilia/n6xc4df3/


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] Ovilia commented on issue #11284: X轴的 文字能否紧贴刻度线布局

2019-09-19 Thread GitBox
Ovilia commented on issue #11284: X轴的  文字能否紧贴刻度线布局
URL: 
https://github.com/apache/incubator-echarts/issues/11284#issuecomment-533373639
 
 
   
可以试试富文本,可以实现比较复杂的文字效果:https://echarts.apache.org/zh/option.html#xAxis.axisLabel.rich


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] fuyunfeng961010 edited a comment on issue #11284: X轴的 文字能否紧贴刻度线布局

2019-09-19 Thread GitBox
fuyunfeng961010 edited a comment on issue #11284: X轴的  文字能否紧贴刻度线布局
URL: 
https://github.com/apache/incubator-echarts/issues/11284#issuecomment-533371460
 
 
   @Ovilia align属性貌似并达不到我预期的效果  期望的是文字能够紧贴刻度线  如图   
   
![image](https://user-images.githubusercontent.com/31279101/65293033-50dbd780-db8c-11e9-81d1-d38ff2eabcc2.png)
   我的设想是将需要居中显示的标红字体拆分成左右两段   标注线左侧右对齐 右侧左对齐达到居中效果  但align属性无法满足  或许我的思路就有问题  
不知这样是否能够实现
   同时图表是需要适应性缩放的


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] Ovilia commented on issue #11278: 主题构建工具需要添加关于渐变色的全局配置项

2019-09-19 Thread GitBox
Ovilia commented on issue #11278: 主题构建工具需要添加关于渐变色的全局配置项
URL: 
https://github.com/apache/incubator-echarts/issues/11278#issuecomment-533372779
 
 
   那这个问题就解决了?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] Ovilia commented on issue #11267: 折线图在图表容器宽高更高情况下,图表被严重压缩,无法正确显示

2019-09-19 Thread GitBox
Ovilia commented on issue #11267: 折线图在图表容器宽高更高情况下,图表被严重压缩,无法正确显示
URL: 
https://github.com/apache/incubator-echarts/issues/11267#issuecomment-533372414
 
 
   @alex2wong That's an excellent job!
   @100pah Please help look at the comment to see if @alex2wong could make a 
pull request here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] fuyunfeng961010 commented on issue #11284: X轴的 文字能否紧贴刻度线布局

2019-09-19 Thread GitBox
fuyunfeng961010 commented on issue #11284: X轴的  文字能否紧贴刻度线布局
URL: 
https://github.com/apache/incubator-echarts/issues/11284#issuecomment-533371460
 
 
   @Ovilia align属性貌似并达不到我预期的效果  期望的是文字能够紧贴刻度线  如图   
   
![image](https://user-images.githubusercontent.com/31279101/65293033-50dbd780-db8c-11e9-81d1-d38ff2eabcc2.png)
   我的设想是将需要居中显示的标红字体拆分成左右两段   标注线左侧右对齐 右侧左对齐达到居中效果  但align属性无法满足  或许我的思路就有问题  
不止这样是否能够实现


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] alex2wong commented on issue #11267: 折线图在图表容器宽高更高情况下,图表被严重压缩,无法正确显示

2019-09-19 Thread GitBox
alex2wong commented on issue #11267: 折线图在图表容器宽高更高情况下,图表被严重压缩,无法正确显示
URL: 
https://github.com/apache/incubator-echarts/issues/11267#issuecomment-533361806
 
 
   Hi team, I may find some clue. As you can see, the grid rect has a big top 
(about 60 px) relative to the canvas.
   
   
![image](https://user-images.githubusercontent.com/10528482/65290378-8e873300-db81-11e9-92c6-4e588cfd9390.png)
   
   After some debug, I found a weird thing: the 
**gridModel**.getBoxLayoutParams() always get option.top with big value, which 
means the grid rect has unnecessray large margin-top, then it cause following 
height set as minus:
   ```
function getLayoutRect(
   positionInfo, containerRect, margin
   ) {
   margin = normalizeCssArray$1(margin || 0);
   
   var containerWidth = containerRect.width;
   var containerHeight = containerRect.height;
   
   var left = parsePercent$1(positionInfo.left, containerWidth);
   var top = parsePercent$1(positionInfo.top, containerHeight);
   var right = parsePercent$1(positionInfo.right, containerWidth);
   var bottom = parsePercent$1(positionInfo.bottom, containerHeight);
   var width = parsePercent$1(positionInfo.width, containerWidth);
   var height = parsePercent$1(positionInfo.height, containerHeight);
   
   var verticalMargin = margin[2] + margin[0];
   var horizontalMargin = margin[1] + margin[3];
   var aspect = positionInfo.aspect;
   
   // If width is not specified, calculate width from left and right
   if (isNaN(width)) {
   width = containerWidth - right - horizontalMargin - left;
   }
   if (isNaN(height)) {
    containerHeight - 60 - 0 - 60 often result in minus number.
   height = containerHeight - bottom - verticalMargin - top;
   }
   // ...
   
   ```
   
   
![Echart-issue1](https://user-images.githubusercontent.com/10528482/65290949-e9218e80-db83-11e9-980c-e04e577b15e4.jpg)
   
   Finally, you would see the grid rect height result in 10 px, that's why our 
chart looks extremely short.
   
   So, my question is where does the gridModel.option.top comes from ?? em, it 
may take top/bottom xAxis into consideration.. need further investigation. Do 
you guys have any idea?
   
   btw, the official demo does not have this issue, it has responsive canvas 
container depend on the window size.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] ankushjamdagani commented on issue #9402: Cannot read property 'getRawIndex' of undefined

2019-09-19 Thread GitBox
ankushjamdagani commented on issue #9402: Cannot read property 'getRawIndex' of 
undefined
URL: 
https://github.com/apache/incubator-echarts/issues/9402#issuecomment-533263332
 
 
   # Issue Reason
   I was passing every dynamic config to`echarts-for-react` component as a 
prop. Config consited of 1...3 number of series. Exception was raised when the 
new config doesn't consist of a series present previously and moving mouse over 
that series. 
   
   # Obvious Solution
   Stop the event handling when chart is updating.
   
   # Fix 1
   `Show an overlay over chart when it is updating.`
   1. `chartInstance.showLoading()` when change has started. (I did it as soon 
as the API call for next data is triggered)
   2. `chartInstance.hideLoading()` when `chartInstance.on('finished')` event.
   
   # Fix 2
   `chartInstance.setOption does the update with silent (no-event-listening) 
mode.`
   https://www.echartsjs.com/en/api.html#echartsInstance.setOption
   1. Pass initial config as prop to Echart component.
   2. For next changes, use `chartInstance.setOptions(...)` instead of passing 
new config as prop to the component.
   
   Hope this is of use to you guys. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] 100pah commented on issue #9269: 地图无数据的区域,无法使用formtter修改显示的label

2019-09-19 Thread GitBox
100pah commented on issue #9269: 地图无数据的区域,无法使用formtter修改显示的label
URL: 
https://github.com/apache/incubator-echarts/issues/9269#issuecomment-533240142
 
 
   Fixed since 4.2.1


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] 100pah commented on a change in pull request #11283: Add clip option for line, bar, lines, scatter, custom series

2019-09-19 Thread GitBox
100pah commented on a change in pull request #11283: Add clip option for line, 
bar, lines, scatter, custom series
URL: 
https://github.com/apache/incubator-echarts/pull/11283#discussion_r326123409
 
 

 ##
 File path: src/chart/bar/BarView.js
 ##
 @@ -191,6 +231,53 @@ export default echarts.extendChartView({
 
 });
 
+var mathMax = Math.max;
+var mathMin = Math.min;
+
+var clip = {
+cartesian2d: function (coordSysBoundingRect, layout) {
+var signWidth = layout.width < 0 ? -1 : 1;
+var signHeight = layout.height < 0 ? -1 : 1;
+// Needs positive width and height
+if (signWidth < 0) {
+layout.x += layout.width;
+layout.width = -layout.width;
+}
+if (signHeight < 0) {
+layout.y += layout.height;
+layout.height = -layout.height;
+}
+
+var x = mathMax(layout.x, coordSysBoundingRect.x);
+var x2 = mathMin(layout.x + layout.width, coordSysBoundingRect.x + 
coordSysBoundingRect.width);
+var y = mathMax(layout.y, coordSysBoundingRect.y);
+var y2 = mathMin(layout.y + layout.height, coordSysBoundingRect.y + 
coordSysBoundingRect.height);
+
+layout.x = x;
+layout.y = y;
+layout.width = x2 - x;
+layout.height = y2 - y;
+
+var clipped = layout.width < 0 || layout.height < 0;;
 
 Review comment:
   two ;;


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] 100pah commented on a change in pull request #11283: Add clip option for line, bar, lines, scatter, custom series

2019-09-19 Thread GitBox
100pah commented on a change in pull request #11283: Add clip option for line, 
bar, lines, scatter, custom series
URL: 
https://github.com/apache/incubator-echarts/pull/11283#discussion_r326124588
 
 

 ##
 File path: src/chart/bar/BarView.js
 ##
 @@ -158,6 +187,17 @@ export default echarts.extendChartView({
 _renderLarge: function (seriesModel, ecModel, api) {
 this._clear();
 createLarge(seriesModel, this.group);
+
+// Use clipPath in large mode.
+var clipPath = seriesModel.get('clip', true)
+? createClipPath(seriesModel.coordinateSystem, false, seriesModel)
+: null;
+if (clipPath) {
+this.group.setClipPath(clipPath);
+}
+else {
+this.group.removeClipPath(null);
 
 Review comment:
   `null` is not needed.
   It seems that `removeClipPath` has no arg.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] mechmillan commented on issue #9402: Cannot read property 'getRawIndex' of undefined

2019-09-19 Thread GitBox
mechmillan commented on issue #9402: Cannot read property 'getRawIndex' of 
undefined
URL: 
https://github.com/apache/incubator-echarts/issues/9402#issuecomment-533186359
 
 
   I'm seeing the same on echarts `4.1.0` and `4.3.0` and `echarts-for-react 
2.0.14`, `echarts-for-react 2.0.15-beta.0`, specifically using a Pie Chart. Can 
this issue be re-opened?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] 100pah opened a new issue #11288: AxisPointer make a hidden symbol display in line chart

2019-09-19 Thread GitBox
100pah opened a new issue #11288: AxisPointer make a hidden symbol display in 
line chart
URL: https://github.com/apache/incubator-echarts/issues/11288
 
 
   ### Version
   4.1.0-release
   
   ### Reproduction link
   
[fill:///echarts/test/dataZoom-clip.html](fill:///echarts/test/dataZoom-clip.html)
   
   ### Steps to reproduce
   In the first chart in `echarts/test/dataZoom-clip.html`,
   do not zoom, hover mouse on the right edge of the `grid`,
   a hidden cycle, which overflows the grid, will display.
   And the `axisPointer` is not in the correct position.
   
   There is still the same problem in 4.3.0 and event probably 4.4.0.
   
   
![image](https://user-images.githubusercontent.com/1956569/65257763-50175700-db34-11e9-994a-dc4cc9a3157b.png)
   
   ### What is expected?
   Normal
   
   ### What is actually happening?
   hidden symbol display unexpected.
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-robot[bot] commented on issue #11288: AxisPointer make a hidden symbol display in line chart

2019-09-19 Thread GitBox
echarts-robot[bot] commented on issue #11288: AxisPointer make a hidden symbol 
display in line chart
URL: 
https://github.com/apache/incubator-echarts/issues/11288#issuecomment-533182054
 
 
   Hi! We've received your issue and please be patient to get responded. 
   The average response time is expected to be within one day for weekdays.
   
   In the meanwhile, please make sure that **you have posted enough image to 
demo your request**. You may also check out the 
[API](http://echarts.apache.org/api.html) and [chart 
option](http://echarts.apache.org/option.html) to get the answer.
   
   If you don't get helped for a long time (over a week) or have an urgent 
question to ask, you may also send an email to d...@echarts.apache.org .
   
   If you are interested in the project, you may also subscribe our [mail 
list](https://echarts.apache.org/en/maillist.html).
   
   Have a nice day! 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] MarxZhou commented on issue #11278: 主题构建工具需要添加关于渐变色的全局配置项

2019-09-19 Thread GitBox
MarxZhou commented on issue #11278: 主题构建工具需要添加关于渐变色的全局配置项
URL: 
https://github.com/apache/incubator-echarts/issues/11278#issuecomment-533142487
 
 
   > 把你写的这个 gradient 值作为一个变量存着,其他地方也使用这个变量,会有什么不方便吗?
   
   没有,可以随意处理。


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] Ovilia commented on issue #11284: X轴的 文字能否紧贴刻度线布局

2019-09-19 Thread GitBox
Ovilia commented on issue #11284: X轴的  文字能否紧贴刻度线布局
URL: 
https://github.com/apache/incubator-echarts/issues/11284#issuecomment-533141539
 
 
   https://echarts.apache.org/en/option.html#xAxis.axisLabel.align


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] Ovilia commented on issue #11278: 主题构建工具需要添加关于渐变色的全局配置项

2019-09-19 Thread GitBox
Ovilia commented on issue #11278: 主题构建工具需要添加关于渐变色的全局配置项
URL: 
https://github.com/apache/incubator-echarts/issues/11278#issuecomment-533139456
 
 
   把你写的这个 gradient 值作为一个变量存着,其他地方也使用这个变量,会有什么不方便吗?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] Ovilia opened a new issue #11287: [feature] map events handling area

2019-09-19 Thread GitBox
Ovilia opened a new issue #11287: [feature] map events handling area
URL: https://github.com/apache/incubator-echarts/issues/11287
 
 
   Currently, the map events like roaming and zooming are only responded within 
the bounding box of the map. It is inconvenient and sometimes confusing. A 
better solution would be triggering events on the whole canvas. If there are 
toolbox or other components, events could be prevented propagation from those.
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] Ovilia commented on issue #11272: fix(map): map transform changed from geo coord to screen position; fix #11055

2019-09-19 Thread GitBox
Ovilia commented on issue #11272: fix(map): map transform changed from geo 
coord to screen position; fix #11055
URL: 
https://github.com/apache/incubator-echarts/pull/11272#issuecomment-533114827
 
 
   I will check with #5429 tomorrow.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] branch fix-11055 updated (48906c9 -> 9289603)

2019-09-19 Thread ovilia
This is an automated email from the ASF dual-hosted git repository.

ovilia pushed a change to branch fix-11055
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git.


from 48906c9  test(map): add test for #11055
 add 9289603  fix(map): use for-loop instead of zrUtil.map

No new revisions were added by this update.

Summary of changes:
 src/component/helper/MapDraw.js | 13 +++--
 1 file changed, 7 insertions(+), 6 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] branch fix-11055 updated (c8777f4 -> 48906c9)

2019-09-19 Thread ovilia
This is an automated email from the ASF dual-hosted git repository.

ovilia pushed a change to branch fix-11055
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git.


from c8777f4  WIP(map): map path changed from geo coord to screen position
 add efde58e  WIP(map): works expect clicking map data
 add 48906c9  test(map): add test for #11055

No new revisions were added by this update.

Summary of changes:
 src/component/helper/MapDraw.js| 18 ++
 test/runTest/actions/__meta__.json |  2 +-
 test/runTest/actions/map.json  |  2 +-
 3 files changed, 12 insertions(+), 10 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang commented on issue #11285: new feature Fix9215 add event ''brushEnd"

2019-09-19 Thread GitBox
pissang commented on issue #11285: new feature   Fix9215   add event ''brushEnd"
URL: 
https://github.com/apache/incubator-echarts/pull/11285#issuecomment-533081512
 
 
   Thanks cuijian!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] lelesu edited a comment on issue #11286: 官方实例Stacked Line Chart Y轴数据显示错误

2019-09-19 Thread GitBox
lelesu edited a comment on issue #11286: 官方实例Stacked Line Chart Y轴数据显示错误
URL: 
https://github.com/apache/incubator-echarts/issues/11286#issuecomment-533078892
 
 
   option = {
   title: {
   text: '折线图堆叠'
   },
   tooltip: {
   trigger: 'axis'
   },
   legend: {
   data:['邮件营销','联盟广告','视频广告','直接访问','搜索引擎']
   },
   grid: {
   left: '3%',
   right: '4%',
   bottom: '3%',
   containLabel: true
   },
   toolbox: {
   feature: {
   saveAsImage: {}
   }
   },
   xAxis: {
   type: 'category',
   boundaryGap: false,
   data: ['周一','周二','周三','周四','周五','周六','周日']
   },
   yAxis: {
   type: 'value'
   },
   series: [
   {
   name:'邮件营销',
   type:'line',
   data:[120, 132, 101, 134, 90, 230, 210]
   },
   {
   name:'联盟广告',
   type:'line',
   data:[220, 182, 191, 234, 290, 330, 310]
   },
   {
   name:'视频广告',
   type:'line',
   data:[150, 232, 201, 154, 190, 330, 410]
   },
   {
   name:'直接访问',
   type:'line',
   data:[320, 332, 301, 334, 390, 330, 320]
   },
   {
   name:'搜索引擎',
   type:'line',
   data:[820, 932, 901, 934, 1290, 1330, 1320]
   }
   ]
   };
   
   去掉series中的stack即可。但话说回来了,官方的demo,真的就不打算改一下么?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] lelesu commented on issue #11286: 官方实例Stacked Line Chart Y轴数据显示错误

2019-09-19 Thread GitBox
lelesu commented on issue #11286: 官方实例Stacked Line Chart Y轴数据显示错误
URL: 
https://github.com/apache/incubator-echarts/issues/11286#issuecomment-533078892
 
 
   option = {
   title: {
   text: '折线图堆叠'
   },
   tooltip: {
   trigger: 'axis'
   },
   legend: {
   data:['邮件营销','联盟广告','视频广告','直接访问','搜索引擎']
   },
   grid: {
   left: '3%',
   right: '4%',
   bottom: '3%',
   containLabel: true
   },
   toolbox: {
   feature: {
   saveAsImage: {}
   }
   },
   xAxis: {
   type: 'category',
   boundaryGap: false,
   data: ['周一','周二','周三','周四','周五','周六','周日']
   },
   yAxis: {
   type: 'value'
   },
   series: [
   {
   name:'邮件营销',
   type:'line',
   data:[120, 132, 101, 134, 90, 230, 210]
   },
   {
   name:'联盟广告',
   type:'line',
   data:[220, 182, 191, 234, 290, 330, 310]
   },
   {
   name:'视频广告',
   type:'line',
   data:[150, 232, 201, 154, 190, 330, 410]
   },
   {
   name:'直接访问',
   type:'line',
   data:[320, 332, 301, 334, 390, 330, 320]
   },
   {
   name:'搜索引擎',
   type:'line',
   data:[820, 932, 901, 934, 1290, 1330, 1320]
   }
   ]
   };
   
   去掉series中的stack即可。但话说回来了,官方的demo,真的就不打算改一下么?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] lelesu edited a comment on issue #11286: 官方实例Stacked Line Chart Y轴数据显示错误

2019-09-19 Thread GitBox
lelesu edited a comment on issue #11286: 官方实例Stacked Line Chart Y轴数据显示错误
URL: 
https://github.com/apache/incubator-echarts/issues/11286#issuecomment-533078892
 
 
   `option = {
   title: {
   text: '折线图堆叠'
   },
   tooltip: {
   trigger: 'axis'
   },
   legend: {
   data:['邮件营销','联盟广告','视频广告','直接访问','搜索引擎']
   },
   grid: {
   left: '3%',
   right: '4%',
   bottom: '3%',
   containLabel: true
   },
   toolbox: {
   feature: {
   saveAsImage: {}
   }
   },
   xAxis: {
   type: 'category',
   boundaryGap: false,
   data: ['周一','周二','周三','周四','周五','周六','周日']
   },
   yAxis: {
   type: 'value'
   },
   series: [
   {
   name:'邮件营销',
   type:'line',
   data:[120, 132, 101, 134, 90, 230, 210]
   },
   {
   name:'联盟广告',
   type:'line',
   data:[220, 182, 191, 234, 290, 330, 310]
   },
   {
   name:'视频广告',
   type:'line',
   data:[150, 232, 201, 154, 190, 330, 410]
   },
   {
   name:'直接访问',
   type:'line',
   data:[320, 332, 301, 334, 390, 330, 320]
   },
   {
   name:'搜索引擎',
   type:'line',
   data:[820, 932, 901, 934, 1290, 1330, 1320]
   }
   ]
   };`
   
   去掉series中的stack即可。但话说回来了,官方的demo,真的就不打算改一下么?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] dangoldstein commented on issue #11260: Overlapping Links in Graph

2019-09-19 Thread GitBox
dangoldstein commented on issue #11260: Overlapping Links in Graph
URL: 
https://github.com/apache/incubator-echarts/issues/11260#issuecomment-533076797
 
 
   > Duplicate of #11260
   
   You referenced this issue ..


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-robot[bot] commented on issue #11286: 官方实例Stacked Line Chart Y轴数据显示错误

2019-09-19 Thread GitBox
echarts-robot[bot] commented on issue #11286: 官方实例Stacked Line Chart Y轴数据显示错误
URL: 
https://github.com/apache/incubator-echarts/issues/11286#issuecomment-533075259
 
 
   This issue is not created using [issue 
template](https://ecomfe.github.io/echarts-issue-helper/) so I'm going to close 
it. 
   Sorry for this, but it helps save our maintainers' time so that more 
developers get helped.
   Feel free to create another issue using the issue template.
   
   If you think you have already made your point clear without the template, or 
your problem cannot be covered by it, you may re-open this issue again.
   
   这个 issue 未使用 [issue 
模板](https://ecomfe.github.io/echarts-issue-helper/?lang=zh-cn) 创建,所以我将关闭此 issue。
   为此带来的麻烦我深表歉意,但是请理解这是为了节约社区维护者的时间,以更高效地服务社区的开发者群体。
   如果您愿意,可以请使用 issue 模板重新创建 issue。
   
   如果你认为虽然没有使用模板,但你已经提供了复现问题的充分描述,或者你的问题无法使用模板表达,也可以重新 open 这个 issue。


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-robot[bot] closed issue #11286: 官方实例Stacked Line Chart Y轴数据显示错误

2019-09-19 Thread GitBox
echarts-robot[bot] closed issue #11286: 官方实例Stacked Line Chart Y轴数据显示错误
URL: https://github.com/apache/incubator-echarts/issues/11286
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] lelesu opened a new issue #11286: 官方实例Stacked Line Chart Y轴数据显示错误

2019-09-19 Thread GitBox
lelesu opened a new issue #11286: 官方实例Stacked Line Chart Y轴数据显示错误
URL: https://github.com/apache/incubator-echarts/issues/11286
 
 
   
![image](https://user-images.githubusercontent.com/11418032/65237655-a8872e00-db0d-11e9-8f0e-c9429377369a.png)
   如图,实例中的“搜索引擎”第一天的数值应该是820,但是Y轴已经直接从1600附近开始了,这是BUG么?
   但是当把其他线条都去掉,只展示“搜索引擎”时,数据是正常的,如下图
   
![image](https://user-images.githubusercontent.com/11418032/65237809-f4d26e00-db0d-11e9-80e6-1fb6241b538e.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] branch feature/clip updated (2bbb297 -> 5c2d8cf)

2019-09-19 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a change to branch feature/clip
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git.


from 2bbb297  test: add recorded action for clip test. not save result when 
replay in recorder page.
 add 5c2d8cf  fix(clip): only access clip option in series.

No new revisions were added by this update.

Summary of changes:
 src/chart/bar/BarView.js | 4 ++--
 src/chart/custom.js  | 2 +-
 src/chart/line/LineView.js   | 2 +-
 src/chart/lines/LinesView.js | 2 +-
 src/chart/scatter/ScatterView.js | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] stale[bot] commented on issue #4856: 环形图 进度条两端如何设置圆角?

2019-09-19 Thread GitBox
stale[bot] commented on issue #4856: 环形图 进度条两端如何设置圆角?
URL: 
https://github.com/apache/incubator-echarts/issues/4856#issuecomment-533069602
 
 
   This issue is marked to be `stale` and is going to be closed within a week. 
If you think it shouldn't be closed, please leave a comment.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] chenxia123 opened a new issue #4856: 环形图 进度条两端如何设置圆角?

2019-09-19 Thread GitBox
chenxia123 opened a new issue #4856: 环形图 进度条两端如何设置圆角?
URL: https://github.com/apache/incubator-echarts/issues/4856
 
 
   
   
   
   ### One-line summary [问题简述]
   
   想给环形图进度条两端设置圆角,但是好像只有柱状图有barBorderRadius属性。
   
   
   
   ### Version & Environment [版本及环境]
   + ECharts version [ECharts 版本]:
   + Browser version [浏览器类型和版本]:
   + OS Version [操作系统类型和版本]:
   
   
   
   
   
   ### Expected behaviour [期望结果]
   
   
![image](https://cloud.githubusercontent.com/assets/22878190/21632838/08900108-d285-11e6-93bd-d8fb7eaef798.png)
   
   
   
   ### ECharts option [ECharts配置项]
   
   
   ```javascript
   option = {
   
   }
   
   ```
   
   
   
   
   ### Other comments [其他信息]
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] fuyunfeng961010 commented on issue #11284: X轴的 文字能否紧贴刻度线布局

2019-09-19 Thread GitBox
fuyunfeng961010 commented on issue #11284: X轴的  文字能否紧贴刻度线布局
URL: 
https://github.com/apache/incubator-echarts/issues/11284#issuecomment-533064523
 
 
   
![1568883889](https://user-images.githubusercontent.com/31279101/65235201-bdad8e00-db08-11e9-9a8f-c0f9bbdbb294.png)
   实际是这样的效果  我现在的问题是标红文字处在 偶数列类型时   判断就无法居中  所以期望能让文字紧右侧贴刻度线 自定义拼接出居中效果  
或者能有其他办法


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] fuyunfeng961010 commented on issue #11284: X轴的 文字能否紧贴刻度线布局

2019-09-19 Thread GitBox
fuyunfeng961010 commented on issue #11284: X轴的  文字能否紧贴刻度线布局
URL: 
https://github.com/apache/incubator-echarts/issues/11284#issuecomment-533062109
 
 
   目前的创建的例子链接与本地实际效果不一致  可能是版本的原因  正常是底部是第二条X轴控制刻度线显隐从而做大类的区分  目前的想要解决问题是描述中的那样 
期望标红的文字能紧贴左侧刻度线  自定义居中的效果


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] cuijian-dexter commented on issue #11285: Fix9215 add event ''brushEnd"

2019-09-19 Thread GitBox
cuijian-dexter commented on issue #11285: Fix9215   add event ''brushEnd"
URL: 
https://github.com/apache/incubator-echarts/pull/11285#issuecomment-533061286
 
 
   #9215


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] fuyunfeng961010 opened a new issue #11284: X轴的 文字能否紧贴刻度线布局

2019-09-19 Thread GitBox
fuyunfeng961010 opened a new issue #11284: X轴的  文字能否紧贴刻度线布局
URL: https://github.com/apache/incubator-echarts/issues/11284
 
 
   ### Version
   4.3.0
   
   ### Reproduction link
   
[https://gallery.echartsjs.com/editor.html?c=x-RDAbBZtw=1](https://gallery.echartsjs.com/editor.html?c=x-RDAbBZtw=1)
   
   ### Steps to reproduce
   正常出现
   
   ### What is expected?
   X轴label文字能够紧贴刻度线左侧 || 右侧
   
   ### What is actually happening?
   通过align达不到预期结果
   
   ---
   查找官网  没有找到属性或者方法 align left || right  也无法达到预期结果
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-robot[bot] commented on issue #11284: X轴的 文字能否紧贴刻度线布局

2019-09-19 Thread GitBox
echarts-robot[bot] commented on issue #11284: X轴的  文字能否紧贴刻度线布局
URL: 
https://github.com/apache/incubator-echarts/issues/11284#issuecomment-533059027
 
 
   Hi! We've received your issue and please be patient to get responded. 
   The average response time is expected to be within one day for weekdays.
   
   In the meanwhile, please make sure that **you have posted enough image to 
demo your request**. You may also check out the 
[API](http://echarts.apache.org/api.html) and [chart 
option](http://echarts.apache.org/option.html) to get the answer.
   
   If you don't get helped for a long time (over a week) or have an urgent 
question to ask, you may also send an email to d...@echarts.apache.org .
   
   If you are interested in the project, you may also subscribe our [mail 
list](https://echarts.apache.org/en/maillist.html).
   
   Have a nice day! 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang opened a new pull request #11283: Add clip option for line, bar, lines, scatter, custom series

2019-09-19 Thread GitBox
pissang opened a new pull request #11283: Add clip option for line, bar, lines, 
scatter, custom series
URL: https://github.com/apache/incubator-echarts/pull/11283
 
 
   This is a pull request about adding clip option for line, bar, lines, 
scatter and custom series.
   
   More details can be found in the issue 
https://github.com/apache/incubator-echarts/issues/11240
   
   ### Test Case
   
   https://github.com/apache/incubator-echarts/blob/feature/clip/test/clip.html
   
   
   ### Test result compared to 4.2.1
   
   
![screencapture-localhost-8866-test-runTest-client-index-html-2019-09-19-16_20_37](https://user-images.githubusercontent.com/841551/65232621-0adb3100-db04-11e9-94ab-e446ab4fefa3.png)
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] branch feature/clip updated: test: add recorded action for clip test. not save result when replay in recorder page.

2019-09-19 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch feature/clip
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git


The following commit(s) were added to refs/heads/feature/clip by this push:
 new 2bbb297  test: add recorded action for clip test. not save result when 
replay in recorder page.
2bbb297 is described below

commit 2bbb2975f3ae743b4f708c3d42c878e889dba4a5
Author: pissang 
AuthorDate: Thu Sep 19 17:33:00 2019 +0800

test: add recorded action for clip test. not save result when replay in 
recorder page.
---
 test/clip.html |  11 +++-
 test/runTest/actions/__meta__.json |   3 +-
 test/runTest/actions/clip.json |   1 +
 test/runTest/cli.js| 113 +
 test/runTest/server.js |  32 ++-
 5 files changed, 94 insertions(+), 66 deletions(-)

diff --git a/test/clip.html b/test/clip.html
index ecfca8c..ad7dd3d 100644
--- a/test/clip.html
+++ b/test/clip.html
@@ -315,12 +315,16 @@ under the License.
 dataZoom: [{
 type: 'inside',
 xAxisIndex: 0,
-filterMode: 'filter'
+filterMode: 'filter',
+start: 30,
+end: 70
 },
 {
 type: 'inside',
 yAxisIndex: 0,
-filterMode: 'weakFilter'
+filterMode: 'weakFilter',
+start: 30,
+end: 70
 }
 ],
 series: [{
@@ -349,7 +353,8 @@ under the License.
 buttons: makeToggleChartButtons(function (clip) {
 chart.setOption({
 series: [{
-clip: clip
+clip: clip,
+data: lineData
 }]
 })
 })
diff --git a/test/runTest/actions/__meta__.json 
b/test/runTest/actions/__meta__.json
index 839a201..b4e3080 100644
--- a/test/runTest/actions/__meta__.json
+++ b/test/runTest/actions/__meta__.json
@@ -129,5 +129,6 @@
   "treemap-option2": 1,
   "visualMap-categories": 1,
   "axes": 0,
-  "stackBar-dataZoom": 7
+  "stackBar-dataZoom": 7,
+  "clip": 9
 }
\ No newline at end of file
diff --git a/test/runTest/actions/clip.json b/test/runTest/actions/clip.json
new file mode 100644
index 000..53e9f6e
--- /dev/null
+++ b/test/runTest/actions/clip.json
@@ -0,0 +1 @@
+[{"name":"Action 
1","ops":[{"type":"mousedown","time":447,"x":92,"y":75},{"type":"mouseup","time":559,"x":92,"y":75},{"time":560,"delay":400,"type":"screenshot-auto"},{"type":"mousemove","time":749,"x":90,"y":75},{"type":"mousemove","time":949,"x":43,"y":75},{"type":"mousemove","time":1157,"x":34,"y":75},{"type":"mousedown","time":1225,"x":34,"y":75},{"type":"mouseup","time":1322,"x":34,"y":75},{"time":1323,"delay":400,"type":"screenshot-auto"}],"scrollY":0,"scrollX":0,"timestamp":156888
 [...]
\ No newline at end of file
diff --git a/test/runTest/cli.js b/test/runTest/cli.js
index 39f85b9..2076710 100644
--- a/test/runTest/cli.js
+++ b/test/runTest/cli.js
@@ -35,7 +35,8 @@ program
 .option('-s, --speed ', 'Playback speed')
 .option('--expected ', 'Expected version')
 .option('--actual ', 'Actual version')
-.option('--renderer ', 'svg/canvas renderer');
+.option('--renderer ', 'svg/canvas renderer')
+.option('--no-save', 'Don\'t save result');
 
 program.parse(process.argv);
 
@@ -115,6 +116,9 @@ async function runActions(page, testOpt, isExpected, 
screenshots) {
 
 let count = 0;
 async function _innerTakeScreenshot() {
+if (!program.save) {
+return;
+}
 const desc = action.desc || action.name;
 const {screenshotName, screenshotPath} = await 
takeScreenshot(page, false, testOpt.fileUrl, desc, isExpected, count++);
 screenshots.push({screenshotName, desc, screenshotPath});
@@ -165,9 +169,11 @@ async function runTestPage(browser, testOpt, version, 
runtimeCode, isExpected) {
 await waitTime(500);  // Wait for animation or something else. Pending
 // Final shot.
 await page.mouse.move(0, 0);
-let desc = 'Full Shot';
-const {screenshotName, screenshotPath} = await takeScreenshot(page, 
true, fileUrl, desc, isExpected);
-screenshots.push({screenshotName, desc, screenshotPath});
+if (program.save) {
+let desc = 'Full Shot';
+const {screenshotName, screenshotPath} = await 
takeScreenshot(page, true, fileUrl, desc, isExpected);
+screenshots.push({screenshotName, desc, 

[GitHub] [incubator-echarts] 100pah opened a new issue #11282: Label position is not correct in SVG renderer.

2019-09-19 Thread GitBox
100pah opened a new issue #11282: Label position is not correct in SVG renderer.
URL: https://github.com/apache/incubator-echarts/issues/11282
 
 
   ### Version
   4.3.0
   
   ### Steps to reproduce
   
   Compare SVG renderer and canvas renderer with the option:
   ```js
   option = {
   xAxis: {},
   yAxis: {},
   series: {
   type: 'scatter',
   symbolSize: 40,
   label: {
   show: true,
   // color: 'green',
   position: 'top'
   },
   data: [[11, 22], [33, 44]]
   }
   };
   ```
   
   ### What is expected?
   Work the same as in canvas renderer.
   
   ### What is actually happening?
   SVG renderer and canvas renderer has diff.
   
   ---
   If have made a fix for it in zrender in months ago, but not tested them 
completely.
   I will create a PR soon.
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-robot[bot] commented on issue #11282: Label position is not correct in SVG renderer.

2019-09-19 Thread GitBox
echarts-robot[bot] commented on issue #11282: Label position is not correct in 
SVG renderer.
URL: 
https://github.com/apache/incubator-echarts/issues/11282#issuecomment-533048031
 
 
   Hi! We've received your issue and please be patient to get responded. 
   The average response time is expected to be within one day for weekdays.
   
   In the meanwhile, please make sure that **you have posted enough image to 
demo your request**. You may also check out the 
[API](http://echarts.apache.org/api.html) and [chart 
option](http://echarts.apache.org/option.html) to get the answer.
   
   If you don't get helped for a long time (over a week) or have an urgent 
question to ask, you may also send an email to d...@echarts.apache.org .
   
   If you are interested in the project, you may also subscribe our [mail 
list](https://echarts.apache.org/en/maillist.html).
   
   Have a nice day! 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] 100pah opened a new issue #11281: UMD wrapper may be need to update to fit some env that not standard

2019-09-19 Thread GitBox
100pah opened a new issue #11281: UMD wrapper may be need to update to fit some 
env that not standard
URL: https://github.com/apache/incubator-echarts/issues/11281
 
 
   ### Version
   4.3.0
   
   ### Steps to reproduce
   Record an issue here:
   In some runtime environment that not standard (like smart app / mini app)
   
   The UMD wrapper will detect that there is `export` / `module export`.
   But the `export` and `module export` might be not the same,
   which brings some error.
   
   Essential this issue dues to the implementation of those runtime 
environments.
   But in some cases, we can not push the env to modify it.
   So we might have to make some compatible code, like what we previously did 
for IE6.
   
   ### What is expected?
   
   The compatible code might be:
   Use 
   ```js
   typeof exports === 'object' && typeof module !== 'undefined' ? 
   (funtion () {
   var ex = {}; 
   factory(ex); 
   for(var key in ex) {
   ex.hasOwnProperty(key) && exports[key] = ex[key] && modules.exports 
&& modules.exports[key] = ex[key];
   }
   })() : ...
   ```
   to replace the original code in UMD wrapper:
   ```js
   typeof exports === 'object' && typeof module !== 'undefined' ? 
factory(exports) : ...
   ```
   
   ### What is actually happening?
   -
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-robot[bot] commented on issue #11281: UMD wrapper may be need to update to fit some env that not standard

2019-09-19 Thread GitBox
echarts-robot[bot] commented on issue #11281: UMD wrapper may be need to update 
to fit some env that not standard
URL: 
https://github.com/apache/incubator-echarts/issues/11281#issuecomment-533042639
 
 
   Hi! We've received your issue and please be patient to get responded. 
   The average response time is expected to be within one day for weekdays.
   
   In the meanwhile, please make sure that **you have posted enough image to 
demo your request**. You may also check out the 
[API](http://echarts.apache.org/api.html) and [chart 
option](http://echarts.apache.org/option.html) to get the answer.
   
   If you don't get helped for a long time (over a week) or have an urgent 
question to ask, you may also send an email to d...@echarts.apache.org .
   
   If you are interested in the project, you may also subscribe our [mail 
list](https://echarts.apache.org/en/maillist.html).
   
   Have a nice day! 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-robot[bot] commented on issue #11280: X轴 希望文字居中 || 贴靠轴线布局

2019-09-19 Thread GitBox
echarts-robot[bot] commented on issue #11280: X轴 希望文字居中 || 贴靠轴线布局
URL: 
https://github.com/apache/incubator-echarts/issues/11280#issuecomment-533026098
 
 
   This issue is not created using [issue 
template](https://ecomfe.github.io/echarts-issue-helper/) so I'm going to close 
it. 
   Sorry for this, but it helps save our maintainers' time so that more 
developers get helped.
   Feel free to create another issue using the issue template.
   
   If you think you have already made your point clear without the template, or 
your problem cannot be covered by it, you may re-open this issue again.
   
   这个 issue 未使用 [issue 
模板](https://ecomfe.github.io/echarts-issue-helper/?lang=zh-cn) 创建,所以我将关闭此 issue。
   为此带来的麻烦我深表歉意,但是请理解这是为了节约社区维护者的时间,以更高效地服务社区的开发者群体。
   如果您愿意,可以请使用 issue 模板重新创建 issue。
   
   如果你认为虽然没有使用模板,但你已经提供了复现问题的充分描述,或者你的问题无法使用模板表达,也可以重新 open 这个 issue。


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-robot[bot] closed issue #11280: X轴 希望文字居中 || 贴靠轴线布局

2019-09-19 Thread GitBox
echarts-robot[bot] closed issue #11280: X轴 希望文字居中 || 贴靠轴线布局
URL: https://github.com/apache/incubator-echarts/issues/11280
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] fuyunfeng961010 opened a new issue #11280: X轴 希望文字居中 || 贴靠轴线布局

2019-09-19 Thread GitBox
fuyunfeng961010 opened a new issue #11280: X轴 希望文字居中 || 贴靠轴线布局
URL: https://github.com/apache/incubator-echarts/issues/11280
 
 
   
   
   This issue is not created by 
[echarts-issue-helper](https://ecomfe.github.io/echarts-issue-helper) and will 
be soon closed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[incubator-echarts] branch feature/clip updated: feat(clip): support clip in custom series and large bar.

2019-09-19 Thread shenyi
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch feature/clip
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git


The following commit(s) were added to refs/heads/feature/clip by this push:
 new 3c78e96  feat(clip): support clip in custom series and large bar.
3c78e96 is described below

commit 3c78e9681e8da1b5402c8f5178f6930808b2961b
Author: pissang 
AuthorDate: Thu Sep 19 16:01:35 2019 +0800

feat(clip): support clip in custom series and large bar.
---
 src/chart/bar/BarSeries.js |   7 +-
 src/chart/bar/BarView.js   |  17 
 src/chart/bar/BaseBarSeries.js |   3 -
 src/chart/custom.js|  20 +++-
 test/clip.html | 213 ++---
 5 files changed, 241 insertions(+), 19 deletions(-)

diff --git a/src/chart/bar/BarSeries.js b/src/chart/bar/BarSeries.js
index 1b717a5..477a584 100644
--- a/src/chart/bar/BarSeries.js
+++ b/src/chart/bar/BarSeries.js
@@ -48,6 +48,11 @@ export default BaseBarSeries.extend({
 progressiveThreshold = largeThreshold;
 }
 return progressiveThreshold;
-}
+},
 
+defaultOption: {
+// If clipped
+// Only available on cartesian2d
+clip: true
+}
 });
diff --git a/src/chart/bar/BarView.js b/src/chart/bar/BarView.js
index 5cbcf86..0219ef6 100644
--- a/src/chart/bar/BarView.js
+++ b/src/chart/bar/BarView.js
@@ -26,6 +26,7 @@ import Model from '../../model/Model';
 import barItemStyle from './barItemStyle';
 import Path from 'zrender/src/graphic/Path';
 import {throttle} from '../../util/throttle';
+import {createClipPath} from '../helper/createClipPathFromCoordSys';
 
 var BAR_BORDER_WIDTH_QUERY = ['itemStyle', 'barBorderWidth'];
 var _eventPos = [0, 0];
@@ -97,6 +98,11 @@ export default echarts.extendChartView({
 
 var needsClip = seriesModel.get('clip');
 
+// If there is clipPath created in large mode. Remove it.
+group.removeClipPath();
+// We don't use clipPath in normal mode because we needs a perfect 
animation
+// And don't want the label are clipped.
+
 data.diff(oldData)
 .add(function (dataIndex) {
 if (!data.hasValue(dataIndex)) {
@@ -181,6 +187,17 @@ export default echarts.extendChartView({
 _renderLarge: function (seriesModel, ecModel, api) {
 this._clear();
 createLarge(seriesModel, this.group);
+
+// Use clipPath in large mode.
+var clipPath = seriesModel.get('clip')
+? createClipPath(seriesModel.coordinateSystem, false, seriesModel)
+: null;
+if (clipPath) {
+this.group.setClipPath(clipPath);
+}
+else {
+this.group.removeClipPath(null);
+}
 },
 
 _incrementalRenderLarge: function (params, seriesModel) {
diff --git a/src/chart/bar/BaseBarSeries.js b/src/chart/bar/BaseBarSeries.js
index 7916c4c..7c8b603 100644
--- a/src/chart/bar/BaseBarSeries.js
+++ b/src/chart/bar/BaseBarSeries.js
@@ -65,9 +65,6 @@ export default SeriesModel.extend({
 progressive: 3e3,
 progressiveChunkMode: 'mod',
 
-// If clipped
-// Only available on cartesian2d
-clip: true,
 // barMaxWidth: null,
 // 默认自适应
 // barWidth: null,
diff --git a/src/chart/custom.js b/src/chart/custom.js
index a48f187..c279460 100644
--- a/src/chart/custom.js
+++ b/src/chart/custom.js
@@ -27,6 +27,7 @@ import DataDiffer from '../data/DataDiffer';
 import SeriesModel from '../model/Series';
 import Model from '../model/Model';
 import ChartView from '../view/Chart';
+import {createClipPath} from './helper/createClipPathFromCoordSys';
 
 import prepareCartesian2d from '../coord/cartesian/prepareCustom';
 import prepareGeo from '../coord/geo/prepareCustom';
@@ -80,7 +81,13 @@ SeriesModel.extend({
 z: 2,
 legendHoverLink: true,
 
-useTransform: true
+useTransform: true,
+
+// Custom series will not clip by default.
+// Some case will use custom series to draw label
+// For example 
https://echarts.apache.org/examples/en/editor.html?c=custom-gantt-flight
+// Only works on polar and cartesian2d coordinate system.
+clip: false
 
 // Cartesian coordinate system
 // xAxisIndex: 0,
@@ -159,6 +166,17 @@ ChartView.extend({
 })
 .execute();
 
+// Do clipping
+var clipPath = customSeries.get('clip')
+? createClipPath(customSeries.coordinateSystem, false, 
customSeries)
+: null;
+if (clipPath) {
+group.setClipPath(clipPath);
+}
+else {
+group.removeClipPath();
+}
+
 this._data = data;
 },
 
diff --git a/test/clip.html b/test/clip.html
index f21eefa..ecfca8c 100644
--- a/test/clip.html
+++ b/test/clip.html
@@ -43,18 +43,6 @@ under the License.
 

[GitHub] [incubator-echarts] 100pah commented on a change in pull request #11212: fix bug #11049

2019-09-19 Thread GitBox
100pah commented on a change in pull request #11212: fix bug #11049
URL: 
https://github.com/apache/incubator-echarts/pull/11212#discussion_r326032832
 
 

 ##
 File path: src/component/toolbox/feature/DataZoom.js
 ##
 @@ -269,7 +269,7 @@ echarts.registerPreprocessor(function (option) {
 }
 
 if (toolboxOpt && toolboxOpt.feature) {
-var dataZoomOpt = toolboxOpt.feature.dataZoom;
+var dataZoomOpt = toolboxOpt.feature.dataZoom || {};
 
 Review comment:
   1. Add a default `{}` will make the condition at L281 no longer make sense. 
So only add a `{}` is not enough.
   
   2. Add a defualt `{}` will cause that `dataZoom` models are always added 
whatever `toolbox.featrue.dataZoom` declared. I am worried that might bring 
some other bug or bad cases.
   And event we fix this error throw in this way, there are other issue: if 
`setOption` changes the axes, the `toolbox dataZoom` will not follow and will 
also be buggy.
   
   I think this issue is a little complicated:
   Currently, making a hidden `dataZoom` model is performed in the `preprocess` 
stage,
   which can not take the existing options into account. But they need that, 
because
   they need the axes info.
   If we want to resolve this kind of issue thoroughly, we might need another 
stage,
   perhaps in `setOption`(the second round of setOption, only triggered 
inside), 
   to insert/update this kind of hidden model, where the existing model (like 
axes)
   can be taken into account.
   
   Anyway, before we resolve it totally, we can probably consider the feature 
`toolbox dataZoom` 
   only support being used in the first setOption.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] icetimidus edited a comment on issue #11226: 柱状图中series指定的dataset定位错误

2019-09-19 Thread GitBox
icetimidus edited a comment on issue #11226: 柱状图中series指定的dataset定位错误
URL: 
https://github.com/apache/incubator-echarts/issues/11226#issuecomment-531729930
 
 
   https://user-images.githubusercontent.com/2377333/64952002-c22c3980-d8b1-11e9-8bdd-c8109c20fb71.png;>
   https://user-images.githubusercontent.com/2377333/64952208-51d1e800-d8b2-11e9-8a58-481fd7017e00.png;>
   
   @deqingli 
   The problem is the data of "公司业务系统" in bar chart is wrong. Use screenshots 
to illustrate, in row three, the data of "公司业务系统" should be 1332.5. 
But it is 1666775.33, as same as "ECM".
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] Ovilia commented on issue #11155: Chart is taking 0 width of its container div, when the parent element is initially hidden

2019-09-19 Thread GitBox
Ovilia commented on issue #11155: Chart is taking 0 width of its container div, 
when the parent element is initially hidden
URL: 
https://github.com/apache/incubator-echarts/issues/11155#issuecomment-532985372
 
 
   @dileepyelleti This seems to be a general JS problem. See if this helps: 
https://stackoverflow.com/questions/27846057/iframe-does-not-trigger-resize-event


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-robot[bot] closed issue #11279: 树图所有连接线都是曲线,能不能加个属性可以设置成折线

2019-09-19 Thread GitBox
echarts-robot[bot] closed issue #11279: 树图所有连接线都是曲线,能不能加个属性可以设置成折线
URL: https://github.com/apache/incubator-echarts/issues/11279
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] echarts-robot[bot] commented on issue #11279: 树图所有连接线都是曲线,能不能加个属性可以设置成折线

2019-09-19 Thread GitBox
echarts-robot[bot] commented on issue #11279: 树图所有连接线都是曲线,能不能加个属性可以设置成折线
URL: 
https://github.com/apache/incubator-echarts/issues/11279#issuecomment-532980685
 
 
   This issue is not created using [issue 
template](https://ecomfe.github.io/echarts-issue-helper/) so I'm going to close 
it. 
   Sorry for this, but it helps save our maintainers' time so that more 
developers get helped.
   Feel free to create another issue using the issue template.
   
   If you think you have already made your point clear without the template, or 
your problem cannot be covered by it, you may re-open this issue again.
   
   这个 issue 未使用 [issue 
模板](https://ecomfe.github.io/echarts-issue-helper/?lang=zh-cn) 创建,所以我将关闭此 issue。
   为此带来的麻烦我深表歉意,但是请理解这是为了节约社区维护者的时间,以更高效地服务社区的开发者群体。
   如果您愿意,可以请使用 issue 模板重新创建 issue。
   
   如果你认为虽然没有使用模板,但你已经提供了复现问题的充分描述,或者你的问题无法使用模板表达,也可以重新 open 这个 issue。


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org