Re: [I] [Java] optimize map performance for reference tracking and serializer dispatch [incubator-fury]
chaokunyang commented on issue #1409:
URL:
https://github.com/apache/incubator-fury/issues/1409#issuecomment-2040992654
Hi @tommyettinger , thanks for this hard work.
Fury has a `src/main/java/org/apache/fury/benchmark/MapSuite.java` which did
some benchmarks for IdentityMap.
For end-to-end tests,
`src/main/java/org/apache/fury/benchmark/UserTypeSerializeSuite.java` can be
used. You can use following config:
```java
public static void main(String[] args) throws IOException {
if (args.length == 0) {
String commandLine =
"org.apache.fury.*UserTypeSerializeSuite.fury* -f 3 -wi 10 -i 10
-t 1 -w 2s -r 2s -rf csv";
System.out.println(commandLine);
args = commandLine.split(" ");
}
Main.main(args);
}
```
`org.apache.fury.benchmark.state.BenchmarkState#references` should be set to
true only, otherwise referecne tracking won't be enabled:
```java
@Param({"true"})
public boolean references;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For additional commands, e-mail: commits-h...@fury.apache.org
Re: [PR] chore(java): Add comments for loop unrolling [incubator-fury]
chaokunyang commented on PR #1450: URL: https://github.com/apache/incubator-fury/pull/1450#issuecomment-2040991342 @LiangliangSui There are some conflict between your branch and main branch, could you resolve the conflict? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For additional commands, e-mail: commits-h...@fury.apache.org
Re: [PR] chore(java): Add comments for loop unrolling [incubator-fury]
chaokunyang commented on code in PR #1450:
URL: https://github.com/apache/incubator-fury/pull/1450#discussion_r1554535283
##
java/fury-core/src/main/java/org/apache/fury/memory/MemoryBuffer.java:
##
@@ -1316,24 +1316,15 @@ public int readPositiveVarInt() {
}
private int readPositiveVarIntSlow() {
-int b = readByte();
-int result = b & 0x7F;
-if ((b & 0x80) != 0) {
+int shift = 0;
Review Comment:
I don't think it's necessary, only rolling code will be used in the release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For additional commands, e-mail: commits-h...@fury.apache.org
Re: [I] [Java] optimize map performance for reference tracking and serializer dispatch [incubator-fury]
tommyettinger commented on issue #1409: URL: https://github.com/apache/incubator-fury/issues/1409#issuecomment-2040990074 I'm making progress on the rest of the map types now; IdentityMap seems done and ObjectIntMap might be done or close to it. Hybridizing the two shouldn't be hard at all. Is there a particular benchmark that you think would best test the performance of these map types? It looks like running all benchmarks would take well over a day. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For additional commands, e-mail: commits-h...@fury.apache.org
Re: [I] [Java] remove guava dependency [incubator-fury]
Munoon commented on issue #1113: URL: https://github.com/apache/incubator-fury/issues/1113#issuecomment-2039846480 > @Munoon That would be really great. Actually I am on the work of first release of Fury under asf and don't have enough time for this feature Can you please specify which exactly help you need? To complete @nandakumar131 PR or to do some further steps? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For additional commands, e-mail: commits-h...@fury.apache.org
Re: [I] [Java] remove guava dependency [incubator-fury]
chaokunyang commented on issue #1113: URL: https://github.com/apache/incubator-fury/issues/1113#issuecomment-2039834094 > This also helps in reducing JAR file size. Let me know if I can help you here. That would be really great. Actually I am on the work of first release of Fury under asf and don't have enough time for this feature -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For additional commands, e-mail: commits-h...@fury.apache.org
[GH] (incubator-fury): Workflow run "Fury CI" is working again!
The GitHub Actions job "Fury CI" on incubator-fury.git has succeeded. Run started by GitHub user Munoon (triggered by Munoon). Head commit for run: bccdf0ddd168a90b1a475bbb91041fde188e1f30 / Nikita Ivchenko Merge branch 'main' into extract_fury_public_methods Report URL: https://github.com/apache/incubator-fury/actions/runs/8569176094 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For additional commands, e-mail: commits-h...@fury.apache.org
Re: [I] [Java] remove guava dependency [incubator-fury]
Munoon commented on issue #1113: URL: https://github.com/apache/incubator-fury/issues/1113#issuecomment-2039575782 This also helps in reducing JAR file size. Let me know if I can help you here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For additional commands, e-mail: commits-h...@fury.apache.org
Re: [PR] feat(java): extract public Fury methods to BaseFury [incubator-fury]
chaokunyang commented on code in PR #1467:
URL: https://github.com/apache/incubator-fury/pull/1467#discussion_r1553444979
##
java/fury-core/src/main/java/org/apache/fury/BaseFury.java:
##
@@ -64,9 +71,16 @@ public interface BaseFury {
*/
void registerSerializer(Class type, Class
serializerClass);
+ void registerSerializer(Class type, Serializer serializer);
Review Comment:
I see, thanks. This is reasonable to add to BaseFury
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For additional commands, e-mail: commits-h...@fury.apache.org
Re: [PR] feat(java): extract public Fury methods to BaseFury [incubator-fury]
Munoon commented on code in PR #1467:
URL: https://github.com/apache/incubator-fury/pull/1467#discussion_r1553192936
##
java/fury-core/src/main/java/org/apache/fury/BaseFury.java:
##
@@ -64,9 +71,16 @@ public interface BaseFury {
*/
void registerSerializer(Class type, Class
serializerClass);
+ void registerSerializer(Class type, Serializer serializer);
Review Comment:
There might be a singleton serializer. I've personally create some of them
in my project. In this case they will be applied to each existing and each new
Fury instances in `ThreadLocalFury` and `ThreadPoolFury`.
Maybe this is something that worth mentioning in the documentation.
However, if you didn't like it, we can remove this method and make user
register singleton serializers using `execute` method. In this case, there is
more chances that user will know what he is doing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For additional commands, e-mail: commits-h...@fury.apache.org
[GH] (incubator-fury): Workflow run "Fury CI" failed!
The GitHub Actions job "Fury CI" on incubator-fury.git has failed. Run started by GitHub user Munoon (triggered by Munoon). Head commit for run: b3d8942f540fec3a2cd3ac182d94cdde2a318597 / Munoon Rollback `Fury#register(Class, String)` method extraction Report URL: https://github.com/apache/incubator-fury/actions/runs/8567178799 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For additional commands, e-mail: commits-h...@fury.apache.org
