Zouxxyy opened a new pull request, #8537:
URL: https://github.com/apache/hudi/pull/8537

   ### Change Logs
   
   - Don't explicitly set default values for hoodie confs in the call 
procedure, this is because **hudi should build the value of hoodie confs 
itself** according to its rules (for example, build from table props, hudi 
globle conf and so on) when user does not specify. 
   
   ```scala
   //  before
   ProcedureParameter.optional(4, "retain_commits", DataTypes.IntegerType, 
HoodieCleanConfig.CLEANER_COMMITS_RETAINED.defaultValue().toInt)
   
   // after
   ProcedureParameter.optional(4, "retain_commits", DataTypes.IntegerType)
   ```
   
   - Add options in run_clean/compacion for use to specifie the running configs 
of the table service
   
   ```scala
   call run_compaction(table => "tbl", op => "run", options => "x=a,y=b")
   ```
   
   -  Format code: `default` in the `ProcedureParameter` needn't to be added if 
no default value is specified. And when the `ProcedureParameter` is require, 
`default` should not be exposed.
   
   ### Impact
   
   Above
   
   ### Risk level (write none, low medium or high below)
   
   low
   
   ### Documentation Update
   
   None
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to