[GitHub] [hudi] danny0405 commented on a diff in pull request #7231: [HUDI-5234] streaming read skip clustering

[GitBox]

danny0405 commented on code in PR #7231:
URL: https://github.com/apache/hudi/pull/7231#discussion_r1025961537


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/IncrementalInputSplits.java:
##########
@@ -482,13 +487,12 @@ private List<HoodieInstant> filterInstantsWithRange(
       final String endCommit = this.conf.get(FlinkOptions.READ_END_COMMIT);
       instantStream = instantStream.filter(s -> 
HoodieTimeline.compareTimestamps(s.getTimestamp(), LESSER_THAN_OR_EQUALS, 
endCommit));
     }
-    return maySkipCompaction(instantStream).collect(Collectors.toList());
+    return 
maySkipOverwriteInstants(instantStream).collect(Collectors.toList());
   }
 
-  private Stream<HoodieInstant> maySkipCompaction(Stream<HoodieInstant> 
instants) {
-    return this.skipCompaction
-        ? instants.filter(instant -> 
!instant.getAction().equals(HoodieTimeline.COMMIT_ACTION))
-        : instants;
+  private Stream<HoodieInstant> maySkipOverwriteInstants(Stream<HoodieInstant> 
instants) {
+    return instants.filter(instant -> !this.skipCompaction || 
!instant.getAction().equals(HoodieTimeline.COMPACTION_ACTION))
+            .filter(instant -> !this.skipClustering|| 
!instant.getAction().equals(HoodieTimeline.REPLACE_COMMIT_ACTION));
   }

Review Comment:
   `!this.skipClustering||` -> `!this.skipClustering ||`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org