sbernauer commented on a change in pull request #2650:
URL: https://github.com/apache/hudi/pull/2650#discussion_r594155813
##########
File path:
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/index/simple/FlinkHoodieSimpleIndex.java
##########
@@ -135,8 +133,8 @@ public boolean isImplicitWithStorage() {
context.map(latestBaseFiles, partitionPathBaseFile -> new
HoodieKeyLocationFetchHandle<>(config, hoodieTable, partitionPathBaseFile),
parallelism);
Map<HoodieKey, HoodieRecordLocation> recordLocations = new HashMap<>();
hoodieKeyLocationFetchHandles.stream()
- .flatMap(handle -> Lists.newArrayList(handle.locations()).stream())
- .forEach(x -> x.forEach(y -> recordLocations.put(y.getKey(),
y.getRight())));
+ .flatMap(handle -> handle.locations())
Review comment:
This was changed because of the removal of the used guava libs ;)
##########
File path: hudi-common/src/main/avro/HoodieRestoreMetadata.avsc
##########
@@ -38,7 +38,6 @@
/* overlaps with 'instantsToRollback' field. Adding this to track action
type for all the instants being rolled back. */
{
"name": "restoreInstantInfo",
- "default": null,
Review comment:
The default value of null doesn't match top a field with type array.
Instead of removing the default value of `null` i now changed it to an empty
array `[]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
