[GitHub] [hudi] xushiyan commented on pull request #9221: [HUDI-6550] Add Hadoop conf to HiveConf for HiveSyncConfig
xushiyan commented on PR #9221: URL: https://github.com/apache/hudi/pull/9221#issuecomment-1707608339 @danny0405 do you have other input? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] xushiyan commented on pull request #9221: [HUDI-6550] Add Hadoop conf to HiveConf for HiveSyncConfig
xushiyan commented on PR #9221: URL: https://github.com/apache/hudi/pull/9221#issuecomment-1704733085 > The issue above only show up when using new HiveConf(hadoopConf, HiveConf.class). When it's reverted it to HiveConf hiveConf = new HiveConf(); hiveConf.addResource(hadoopConf); it works fine @CTTY ok the order of loading resources makes a difference: 1st approach first adds `hadoopConf` then overrides whatever from hive-specific confs, 2nd approach does the opposite. In our case, we want to respect user-provided `hadoopConf` so we should add the resource after `HiveConf` initializes. I'll rebase master as the CI seemed not running for your last push. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] xushiyan commented on pull request #9221: [HUDI-6550] Add Hadoop conf to HiveConf for HiveSyncConfig
xushiyan commented on PR #9221: URL: https://github.com/apache/hudi/pull/9221#issuecomment-1698457359 @CTTY will you be able to test and verify the change before we land it? it's a blocker for 0.14.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] xushiyan commented on pull request #9221: [HUDI-6550] Add Hadoop conf to HiveConf for HiveSyncConfig
xushiyan commented on PR #9221: URL: https://github.com/apache/hudi/pull/9221#issuecomment-1649394492 > Hi @xushiyan, I noticed the casting from hadoopConf to hiveConf was introduced by this PR from you(#6202) but I couldn't find any context. Could you help me learn why we made that change? > > ``` > HiveConf hiveConf = hadoopConf instanceof HiveConf > ? (HiveConf) hadoopConf : new HiveConf(hadoopConf, HiveConf.class); > ``` hey @CTTY it's probably meant for being fully compatible with the original code, as it was done for refactoring. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
