lamber-ken commented on a change in pull request #1159: [HUDI-479] Eliminate or
Minimize use of Guava if possible
URL: https://github.com/apache/incubator-hudi/pull/1159#discussion_r362276178
##########
File path:
hudi-client/src/main/java/org/apache/hudi/table/RollbackExecutor.java
##########
@@ -217,7 +216,7 @@ private HoodieRollbackStat
mergeRollbackStat(HoodieRollbackStat stat1, HoodieRol
private Map<HeaderMetadataType, String> generateHeader(String commit) {
// generate metadata
- Map<HeaderMetadataType, String> header = Maps.newHashMap();
+ Map<HeaderMetadataType, String> header = new HashMap<>();
Review comment:
> Collections.emptyMap() works? Similarly, if we can pull this into our own
`CollectionUtils` class, that would be useful to change later on?
Hi @vinothchandar, `Collections.emptyMap()`, `Collections.emptyList()`,
`Collections.emptySet()` don't support put / add /remove operations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
