Re: [PR] [HUDI-7297] Fix ambiguous error message when field type defined in sc… [hudi]
danny0405 merged PR #10497: URL: https://github.com/apache/hudi/pull/10497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7297] Fix ambiguous error message when field type defined in sc… [hudi]
hudi-bot commented on PR #10497: URL: https://github.com/apache/hudi/pull/10497#issuecomment-1894943957 ## CI report: * fda81dda555c15ab51ee817fda9977bdcde84356 UNKNOWN * dd7311e64b0747772b7d20ad232feb3a4be0bdd9 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21988) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7297] Fix ambiguous error message when field type defined in sc… [hudi]
hudi-bot commented on PR #10497: URL: https://github.com/apache/hudi/pull/10497#issuecomment-1894856364 ## CI report: * c586484b0f4587c465a469b3bdf9fbf0bef28666 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21963) * fda81dda555c15ab51ee817fda9977bdcde84356 UNKNOWN * dd7311e64b0747772b7d20ad232feb3a4be0bdd9 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21988) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7297] Fix ambiguous error message when field type defined in sc… [hudi]
paul8263 commented on code in PR #10497: URL: https://github.com/apache/hudi/pull/10497#discussion_r1454374435 ## hudi-flink-datasource/hudi-flink1.14.x/src/main/java/org/apache/hudi/table/format/cow/ParquetSplitReaderUtil.java: ## @@ -460,59 +460,59 @@ private static WritableColumnVector createWritableColumnVector( case BOOLEAN: checkArgument( typeName == PrimitiveType.PrimitiveTypeName.BOOLEAN, -"Unexpected type: %s", typeName); +"Unexpected type exception. Primitive type: %s. Field type: %s.", typeName, fieldType.getTypeRoot().name()); Review Comment: I extracted it as a static method. The code for error message construction won't be duplicated too many times. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7297] Fix ambiguous error message when field type defined in sc… [hudi]
paul8263 commented on code in PR #10497:
URL: https://github.com/apache/hudi/pull/10497#discussion_r1454372097
##
hudi-flink-datasource/hudi-flink1.14.x/src/main/java/org/apache/hudi/table/format/cow/vector/reader/ParquetColumnarRowSplitReader.java:
##
@@ -218,11 +218,17 @@ private WritableColumnVector[] createWritableVectors() {
List types = requestedSchema.getFields();
List descriptors = requestedSchema.getColumns();
for (int i = 0; i < requestedTypes.length; i++) {
- columns[i] = createWritableColumnVector(
- batchSize,
- requestedTypes[i],
- types.get(i),
- descriptors);
+ String fieldName = requestedSchema.getFieldName(i);
Review Comment:
Hi @danny0405 ,
Correct. It should be moved to the catch block as it would be only needed if
there was an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [HUDI-7297] Fix ambiguous error message when field type defined in sc… [hudi]
hudi-bot commented on PR #10497: URL: https://github.com/apache/hudi/pull/10497#issuecomment-1894823533 ## CI report: * c586484b0f4587c465a469b3bdf9fbf0bef28666 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21963) * fda81dda555c15ab51ee817fda9977bdcde84356 UNKNOWN * dd7311e64b0747772b7d20ad232feb3a4be0bdd9 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7297] Fix ambiguous error message when field type defined in sc… [hudi]
hudi-bot commented on PR #10497: URL: https://github.com/apache/hudi/pull/10497#issuecomment-1894817105 ## CI report: * c586484b0f4587c465a469b3bdf9fbf0bef28666 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21963) * fda81dda555c15ab51ee817fda9977bdcde84356 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7297] Fix ambiguous error message when field type defined in sc… [hudi]
danny0405 commented on code in PR #10497:
URL: https://github.com/apache/hudi/pull/10497#discussion_r1452868560
##
hudi-flink-datasource/hudi-flink1.14.x/src/main/java/org/apache/hudi/table/format/cow/vector/reader/ParquetColumnarRowSplitReader.java:
##
@@ -218,11 +218,17 @@ private WritableColumnVector[] createWritableVectors() {
List types = requestedSchema.getFields();
List descriptors = requestedSchema.getColumns();
for (int i = 0; i < requestedTypes.length; i++) {
- columns[i] = createWritableColumnVector(
- batchSize,
- requestedTypes[i],
- types.get(i),
- descriptors);
+ String fieldName = requestedSchema.getFieldName(i);
Review Comment:
Is it possible to move this line to the catch block?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [HUDI-7297] Fix ambiguous error message when field type defined in sc… [hudi]
danny0405 commented on code in PR #10497: URL: https://github.com/apache/hudi/pull/10497#discussion_r1452868383 ## hudi-flink-datasource/hudi-flink1.14.x/src/main/java/org/apache/hudi/table/format/cow/ParquetSplitReaderUtil.java: ## @@ -460,59 +460,59 @@ private static WritableColumnVector createWritableColumnVector( case BOOLEAN: checkArgument( typeName == PrimitiveType.PrimitiveTypeName.BOOLEAN, -"Unexpected type: %s", typeName); +"Unexpected type exception. Primitive type: %s. Field type: %s.", typeName, fieldType.getTypeRoot().name()); Review Comment: Can we abstract it as an utility? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7297] Fix ambiguous error message when field type defined in sc… [hudi]
hudi-bot commented on PR #10497: URL: https://github.com/apache/hudi/pull/10497#issuecomment-1891424318 ## CI report: * c586484b0f4587c465a469b3bdf9fbf0bef28666 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21963) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7297] Fix ambiguous error message when field type defined in sc… [hudi]
hudi-bot commented on PR #10497: URL: https://github.com/apache/hudi/pull/10497#issuecomment-1891404950 ## CI report: * c586484b0f4587c465a469b3bdf9fbf0bef28666 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21963) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7297] Fix ambiguous error message when field type defined in sc… [hudi]
paul8263 commented on PR #10497: URL: https://github.com/apache/hudi/pull/10497#issuecomment-1891355213 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7297] Fix ambiguous error message when field type defined in sc… [hudi]
hudi-bot commented on PR #10497: URL: https://github.com/apache/hudi/pull/10497#issuecomment-1891265691 ## CI report: * c586484b0f4587c465a469b3bdf9fbf0bef28666 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21963) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HUDI-7297] Fix ambiguous error message when field type defined in sc… [hudi]
hudi-bot commented on PR #10497: URL: https://github.com/apache/hudi/pull/10497#issuecomment-1891261231 ## CI report: * c586484b0f4587c465a469b3bdf9fbf0bef28666 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
