Re: [PR] [KARAF-7754] Upgrade to Pax Web 9.0.11 & Jetty 10.0.16 [karaf]
grgrzybek commented on PR #1785: URL: https://github.com/apache/karaf/pull/1785#issuecomment-1816912448 I'll get back to https://github.com/grgrzybek/karaf/commits/KARAF-7544-Jetty10-PaxWeb9 at some point. I'm working on Jolokia now and I need Pax Web with jakarta support, so I got back to Pax Web 10 and realized that Pax URL War needs `jakarta.servlet` version too, so I started checking Pax URL 3 (work in progress) and realized there are Maven Resolver things to solve (we should move to Maven Resolver 2 soon). But I didn't lost track of what I work on ;) (https://www.youtube.com/watch?v=AbSehcT19u0) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [KARAF-7754] Upgrade to Pax Web 9.0.11 & Jetty 10.0.16 [karaf]
jbonofre commented on PR #1785: URL: https://github.com/apache/karaf/pull/1785#issuecomment-1816452393 Better to resume what @grgrzybek started imho. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [KARAF-7754] Upgrade to Pax Web 9.0.11 & Jetty 10.0.16 [karaf]
jbonofre closed pull request #1785: [KARAF-7754] Upgrade to Pax Web 9.0.11 & Jetty 10.0.16 URL: https://github.com/apache/karaf/pull/1785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [KARAF-7754] Upgrade to Pax Web 9.0.11 & Jetty 10.0.16 [karaf]
rovarga commented on PR #1785: URL: https://github.com/apache/karaf/pull/1785#issuecomment-1772968017 > Please check https://issues.apache.org/jira/browse/KARAF-7544 and my previous attempt: https://github.com/grgrzybek/karaf/commits/KARAF-7544-Jetty10-PaxWeb9 Argh, sorry for the confusion and thanks for the pointer. I will be closing this PR and re-start with your attempt as it contains quite a few clean ups which I think we can merge before making the jump. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [KARAF-7754] Upgrade to Pax Web 9.0.11 & Jetty 10.0.16 [karaf]
rovarga commented on code in PR #1785:
URL: https://github.com/apache/karaf/pull/1785#discussion_r1367154542
##
examples/karaf-websocket-example/src/main/java/org/apache/karaf/examples/websocket/WebsocketExampleServlet.java:
##
@@ -16,16 +16,16 @@
*/
package org.apache.karaf.examples.websocket;
-import org.eclipse.jetty.websocket.servlet.WebSocketServlet;
-import org.eclipse.jetty.websocket.servlet.WebSocketServletFactory;
+import org.eclipse.jetty.websocket.server.JettyWebSocketServlet;
+import org.eclipse.jetty.websocket.server.JettyWebSocketServletFactory;
import javax.servlet.annotation.WebServlet;
@WebServlet(name = "Example WebSocket Servlet", urlPatterns = {
"/example-websocket "})
-public class WebsocketExampleServlet extends WebSocketServlet {
+public class WebsocketExampleServlet extends JettyWebSocketServlet {
Review Comment:
> We should use the websocket handling here, not the Jetty one.
This is just the Jetty 9.4 -> 10 renaming. Do you mean to switch the
example to just use JSR356?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@karaf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [KARAF-7754] Upgrade to Pax Web 9.0.11 & Jetty 10.0.16 [karaf]
jbonofre commented on code in PR #1785:
URL: https://github.com/apache/karaf/pull/1785#discussion_r1367146223
##
examples/karaf-websocket-example/src/main/java/org/apache/karaf/examples/websocket/WebsocketExampleServlet.java:
##
@@ -16,16 +16,16 @@
*/
package org.apache.karaf.examples.websocket;
-import org.eclipse.jetty.websocket.servlet.WebSocketServlet;
-import org.eclipse.jetty.websocket.servlet.WebSocketServletFactory;
+import org.eclipse.jetty.websocket.server.JettyWebSocketServlet;
+import org.eclipse.jetty.websocket.server.JettyWebSocketServletFactory;
import javax.servlet.annotation.WebServlet;
@WebServlet(name = "Example WebSocket Servlet", urlPatterns = {
"/example-websocket "})
-public class WebsocketExampleServlet extends WebSocketServlet {
+public class WebsocketExampleServlet extends JettyWebSocketServlet {
Review Comment:
We should use the websocket handling here, not the Jetty one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@karaf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [KARAF-7754] Upgrade to Pax Web 9.0.11 & Jetty 10.0.16 [karaf]
grgrzybek commented on PR #1785: URL: https://github.com/apache/karaf/pull/1785#issuecomment-1771471320 Please check https://issues.apache.org/jira/browse/KARAF-7544 and my previous attempt: https://github.com/grgrzybek/karaf/commits/KARAF-7544-Jetty10-PaxWeb9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [KARAF-7754] Upgrade to Pax Web 9.0.11 & Jetty 10.0.16 [karaf]
rovarga opened a new pull request, #1785: URL: https://github.com/apache/karaf/pull/1785 Signed-off-by: Robert Varga -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
