[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.
This is an automated email from the ASF dual-hosted git repository. aaronmarkham pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new e90e897 Bump the publish timestamp. e90e897 is described below commit e90e8972d6c2cc9a0d396067e17d2d0bf22e2bf2 Author: mxnet-ci AuthorDate: Sat May 23 06:53:54 2020 + Bump the publish timestamp. --- date.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/date.txt b/date.txt new file mode 100644 index 000..01cb5b2 --- /dev/null +++ b/date.txt @@ -0,0 +1 @@ +Sat May 23 06:53:53 UTC 2020
[GitHub] [incubator-mxnet] JustinhoCHN opened a new issue #18392: Need cuda 10.2 python prebuild wheel for nvidia jetson platform.
JustinhoCHN opened a new issue #18392: URL: https://github.com/apache/incubator-mxnet/issues/18392 ## Description Currently the newest nvidia jetson jetpack version is 4.4 DP, with cuda 10.2, cudnn 8.0. I tried to install mxnet 1.6 in jetpack 4.4, following the [same pipeline as in jetpack 4.3](https://github.com/apache/incubator-mxnet/issues/17923#issuecomment-606444051) #17923 , failed to import mxnet. Here's what I tried: 1. Install cuda 10.0 toolkit in jetpack 4.4, [reference](https://forums.developer.nvidia.com/t/how-to-to-install-cuda-10-0-on-jetson-nano-separately/82405/4?u=coderjustin) ``` sudo apt-get install cuda-toolkit-10.0 ``` 2. [followed the same installation pipeline as in jetpack 4.3](https://github.com/apache/incubator-mxnet/issues/17923#issuecomment-606444051) 3. Test importing mxnet ``` root@jetbot:/home/jetbot/Downloads# python3 Python 3.6.9 (default, Apr 18 2020, 01:56:04) [GCC 8.4.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import mxnet as mx Segmentation fault (core dumped) ``` So the mxnet-1.6.0-py3-none-any.whl doesn't work in jetpack 4.4, we need a mxnet python wheel that are compiled with cuda 10.2. ## Known implementations The [ci jetson dockerfile](https://github.com/apache/incubator-mxnet/blob/master/ci/docker/Dockerfile.build.jetson) in master branch can be modify using cuda 10.2, I tried to replace the deb file mentioned in the dockerfile, but I can't find ```cuda-repo-cross-aarch64-10-2-x.deb``` in jetpack sdk manager download folder. Someone please help me, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #18379: change _Pragma to #pragma
leezu commented on pull request #18379: URL: https://github.com/apache/incubator-mxnet/pull/18379#issuecomment-632996894 Yes, that's an option. I'm not convinced though that only fixing this current incompatibility without introducing any mechanism of preventing future problems is helpful. So if you think we need to support MSVC 2017, then let's also turn it on in the CI. If not, then let's just use MSVC 2019 on the CD. But supporting MSVC 2017 without having any CI checks would just cause unnecessary problems down the road (with the CD breaking often) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18352: Back port the PR #17672:boolean indexing to branch v1.7.x
mxnet-bot commented on pull request #18352: URL: https://github.com/apache/incubator-mxnet/pull/18352#issuecomment-632996589 Jenkins CI successfully triggered : [edge] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] Alicia1529 commented on pull request #18352: Back port the PR #17672:boolean indexing to branch v1.7.x
Alicia1529 commented on pull request #18352: URL: https://github.com/apache/incubator-mxnet/pull/18352#issuecomment-632996582 @mxnet-bot run ci [edge] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] Alicia1529 commented on pull request #18351: Back port the PR #17672:boolean indexing to branch v1.x
Alicia1529 commented on pull request #18351: URL: https://github.com/apache/incubator-mxnet/pull/18351#issuecomment-632996540 @mxnet-bot run ci [edge] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18351: Back port the PR #17672:boolean indexing to branch v1.x
mxnet-bot commented on pull request #18351: URL: https://github.com/apache/incubator-mxnet/pull/18351#issuecomment-632996551 Jenkins CI successfully triggered : [edge] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] ZheyuYe commented on issue #18353: [Numpy] Division fails for differnt floating dtypes
ZheyuYe commented on issue #18353: URL: https://github.com/apache/incubator-mxnet/issues/18353#issuecomment-632994463 Actually, for this issue, we might expect a proper error that aborts the compuation. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] leezu removed a comment on pull request #18379: change _Pragma to #pragma
leezu removed a comment on pull request #18379: URL: https://github.com/apache/incubator-mxnet/pull/18379#issuecomment-632974522 MXNet 2 will be released after Cuda 11 release, so there is no Cuda 9 support in MXNet 2 currently This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #18379: change _Pragma to #pragma
leezu commented on pull request #18379: URL: https://github.com/apache/incubator-mxnet/pull/18379#issuecomment-632974522 MXNet 2 will be released after Cuda 11 release, so there is no Cuda 9 support in MXNet 2 currently This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-mxnet] branch master updated: Fix flaky CSVIter test (#18390)
This is an automated email from the ASF dual-hosted git repository.
lausen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git
The following commit(s) were added to refs/heads/master by this push:
new 6ab6128 Fix flaky CSVIter test (#18390)
6ab6128 is described below
commit 6ab61284d21e7649a8795f83a13a00605238deea
Author: Joshua Z. Zhang
AuthorDate: Fri May 22 19:49:05 2020 -0700
Fix flaky CSVIter test (#18390)
---
tests/python/unittest/test_io.py | 25 +++--
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git a/tests/python/unittest/test_io.py b/tests/python/unittest/test_io.py
index 635471d..1b0ae20 100644
--- a/tests/python/unittest/test_io.py
+++ b/tests/python/unittest/test_io.py
@@ -324,12 +324,11 @@ def test_NDArrayIter_csr():
begin += batch_size
-def test_LibSVMIter():
+def test_LibSVMIter(tmpdir):
def check_libSVMIter_synthetic():
-cwd = os.getcwd()
-data_path = os.path.join(cwd, 'data.t')
-label_path = os.path.join(cwd, 'label.t')
+data_path = os.path.join(str(tmpdir), 'data.t')
+label_path = os.path.join(str(tmpdir), 'label.t')
with open(data_path, 'w') as fout:
fout.write('1.0 0:0.5 2:1.2\n')
fout.write('-2.0\n')
@@ -342,7 +341,7 @@ def test_LibSVMIter():
fout.write('-3.0 2:1.2\n')
fout.write('4 1:1.0 2:-1.2\n')
-data_dir = os.path.join(cwd, 'data')
+data_dir = os.path.join(str(tmpdir), 'data')
data_train = mx.io.LibSVMIter(data_libsvm=data_path,
label_libsvm=label_path,
data_shape=(3, ), label_shape=(3, ),
batch_size=3)
@@ -367,7 +366,7 @@ def test_LibSVMIter():
}
batch_size = 33
num_examples = news_metadata['num_examples']
-data_dir = os.path.join(os.getcwd(), 'data')
+data_dir = os.path.join(str(tmpdir), 'data')
get_bz2_data(data_dir, news_metadata['name'], news_metadata['url'],
news_metadata['origin_name'])
path = os.path.join(data_dir, news_metadata['name'])
@@ -388,9 +387,8 @@ def test_LibSVMIter():
data_train.reset()
def check_libSVMIter_exception():
-cwd = os.getcwd()
-data_path = os.path.join(cwd, 'data.t')
-label_path = os.path.join(cwd, 'label.t')
+data_path = os.path.join(str(tmpdir), 'data.t')
+label_path = os.path.join(str(tmpdir), 'label.t')
with open(data_path, 'w') as fout:
fout.write('1.0 0:0.5 2:1.2\n')
fout.write('-2.0\n')
@@ -403,7 +401,7 @@ def test_LibSVMIter():
fout.write('-2.0 0:0.125\n')
fout.write('-3.0 2:1.2\n')
fout.write('4 1:1.0 2:-1.2\n')
-data_dir = os.path.join(cwd, 'data')
+data_dir = os.path.join(str(tmpdir), 'data')
data_train = mx.io.LibSVMIter(data_libsvm=data_path,
label_libsvm=label_path,
data_shape=(3, ), label_shape=(3, ),
batch_size=3)
for batch in iter(data_train):
@@ -426,11 +424,10 @@ def test_DataBatch():
r'DataBatch: data shapes: \[\(2L?, 3L?\), \(7L?, 8L?\)\] label shapes:
\[\(4L?, 5L?\)\]', str(batch))
-def test_CSVIter():
+def test_CSVIter(tmpdir):
def check_CSVIter_synthetic(dtype='float32'):
-cwd = os.getcwd()
-data_path = os.path.join(cwd, 'data.t')
-label_path = os.path.join(cwd, 'label.t')
+data_path = os.path.join(str(tmpdir), 'data.t')
+label_path = os.path.join(str(tmpdir), 'label.t')
entry_str = '1'
if dtype is 'int32':
entry_str = '20001'
[GitHub] [incubator-mxnet] leezu closed issue #18382: test_CSVIter
leezu closed issue #18382: URL: https://github.com/apache/incubator-mxnet/issues/18382 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] leezu merged pull request #18390: Fix #18382 use tmpdir fixture to CSVIter test
leezu merged pull request #18390: URL: https://github.com/apache/incubator-mxnet/pull/18390 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] pengzhao-intel commented on pull request #18160: [1.x] Add BatchNormWithReLU fp32/bf16
pengzhao-intel commented on pull request #18160: URL: https://github.com/apache/incubator-mxnet/pull/18160#issuecomment-632973661 > there are some issues on the 1.x CI and the team is working on it. once resolved, we can trigger the CI for this PR again. Thanks a lot! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] yajiedesign commented on pull request #18379: change _Pragma to #pragma
yajiedesign commented on pull request #18379: URL: https://github.com/apache/incubator-mxnet/pull/18379#issuecomment-632965410 Keep the MSVC of CI compatible with the minimum supported CUDA version. Then upgrade MSVC when drop CUDA version support. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] wkcn commented on issue #18333: How to implement cross entropy for binary segmentation using symbol only?
wkcn commented on issue #18333: URL: https://github.com/apache/incubator-mxnet/issues/18333#issuecomment-632965057 @John1231983 Your implementation is correct. It is available to use `data.sum(axis=1).mean()`, which is equal to `data.sum() / len(data)`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #18379: change _Pragma to #pragma
leezu commented on pull request #18379: URL: https://github.com/apache/incubator-mxnet/pull/18379#issuecomment-632964034 (Soon Cuda 11 will be released and we'll drop Cuda 9 support in any case) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #18379: change _Pragma to #pragma
leezu commented on pull request #18379: URL: https://github.com/apache/incubator-mxnet/pull/18379#issuecomment-632963894 Thanks for clarifying. In that case, should we either drop the old Cuda versions for MXNet 2 or switch the CI to an older MSVC version? What do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] yajiedesign commented on pull request #18379: change _Pragma to #pragma
yajiedesign commented on pull request #18379: URL: https://github.com/apache/incubator-mxnet/pull/18379#issuecomment-632961357 @leezu Because CUDA. The old version of CUDA does not support the new version of msvc. CI is only one CUDA version. but CD requires multiple versions of CUDA. cannot upgrade MSVC. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] chinakook commented on a change in pull request #17970: fix block.export
chinakook commented on a change in pull request #17970: URL: https://github.com/apache/incubator-mxnet/pull/17970#discussion_r429500913 ## File path: python/mxnet/gluon/block.py ## @@ -1248,7 +1248,11 @@ def export(self, path, epoch=0, remove_amp_cast=True): will be created, where is the 4 digits epoch number. epoch : int Epoch number of saved model. - +remove_amp_cast : bool, optional +Whether to remove the amp_cast and amp_multicast operators, before exporting the model. +allow_extra : bool, optional +Whether to save extra parameters whose name not in the result symbol. User can set +allow_extra to True to load these parameters with old mxnet.mod.Module.set_params api. Review comment: Like @wkcn said, someone would like to save extra parameters. We can drop this argument, but it may be useful in some rarely cases. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] eric-haibin-lin closed pull request #18388: remove mx.model.FeedForward API
eric-haibin-lin closed pull request #18388: URL: https://github.com/apache/incubator-mxnet/pull/18388 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.
This is an automated email from the ASF dual-hosted git repository. aaronmarkham pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 1b8ca08 Bump the publish timestamp. 1b8ca08 is described below commit 1b8ca08b1128751ddd7623f75aa591bd344c7b40 Author: mxnet-ci AuthorDate: Sat May 23 00:48:33 2020 + Bump the publish timestamp. --- date.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/date.txt b/date.txt new file mode 100644 index 000..854ab2f --- /dev/null +++ b/date.txt @@ -0,0 +1 @@ +Sat May 23 00:48:33 UTC 2020
[GitHub] [incubator-mxnet] Alicia1529 commented on pull request #18351: Back port the PR #17672:boolean indexing to branch v1.x
Alicia1529 commented on pull request #18351: URL: https://github.com/apache/incubator-mxnet/pull/18351#issuecomment-632954788 @mxnet-bot run ci [edge] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18352: Back port the PR #17672:boolean indexing to branch v1.7.x
mxnet-bot commented on pull request #18352: URL: https://github.com/apache/incubator-mxnet/pull/18352#issuecomment-632954796 Jenkins CI successfully triggered : [edge] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] Alicia1529 commented on pull request #18352: Back port the PR #17672:boolean indexing to branch v1.7.x
Alicia1529 commented on pull request #18352: URL: https://github.com/apache/incubator-mxnet/pull/18352#issuecomment-632954781 @mxnet-bot run ci [edge] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18351: Back port the PR #17672:boolean indexing to branch v1.x
mxnet-bot commented on pull request #18351: URL: https://github.com/apache/incubator-mxnet/pull/18351#issuecomment-632954801 Jenkins CI successfully triggered : [edge] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] zhreshold commented on pull request #18358: [1.7.x] Fix memory leaks in Gluon
zhreshold commented on pull request #18358: URL: https://github.com/apache/incubator-mxnet/pull/18358#issuecomment-632947318 @leezu Fix to mem leak is nice to have and I don't see any problem with this pariticular PR, however, `deepcopy` of a full network isn't a rare usecase which means a fix to deepcopy is needed anyway. In fact, the behavior of `__deepcopy__` of a `Block` has to be overrided with the `_BlockScope` being renewed in the new `Block`, and the suspicious copy behavior of parameters has to be verified and secured. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] leezu edited a comment on pull request #18358: [1.7.x] Fix memory leaks in Gluon
leezu edited a comment on pull request #18358: URL: https://github.com/apache/incubator-mxnet/pull/18358#issuecomment-632944907 @zhreshold should we revert this PR on the 1.7 and 1.x branch as weakref doesn't work with deepcopy? https://github.com/dmlc/gluon-cv/blob/428ee05d7ae4f2955ef00380a1b324b05e6bc80f/gluoncv/data/transforms/presets/yolo.py#L144 (Though I'm surprised that `copy.deepcopy` worked in the first place; for example, using deepcopy probably leads to double free and/or use of invalid memory as you duplicate the ndarray handles of the parameters) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #18358: [1.7.x] Fix memory leaks in Gluon
leezu commented on pull request #18358: URL: https://github.com/apache/incubator-mxnet/pull/18358#issuecomment-632944907 @zhreshold should we revert this PR on the 1.7 and 1.x branch as weakref doesn't work with deepcopy? https://github.com/dmlc/gluon-cv/blob/428ee05d7ae4f2955ef00380a1b324b05e6bc80f/gluoncv/data/transforms/presets/yolo.py#L144 (Though I'm surprised that `copy.deepcopy` worked in the first place) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18375: [v1.x] Backport edge pipeline
mxnet-bot commented on pull request #18375: URL: https://github.com/apache/incubator-mxnet/pull/18375#issuecomment-632928642 Jenkins CI successfully triggered : [clang, centos-cpu, miscellaneous, centos-gpu, windows-cpu, windows-gpu, sanity, unix-cpu, website, unix-gpu, edge] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #18375: [v1.x] Backport edge pipeline
leezu commented on pull request #18375: URL: https://github.com/apache/incubator-mxnet/pull/18375#issuecomment-632928603 @mxnet-bot run ci [all] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #18375: [v1.x] Backport edge pipeline
leezu commented on pull request #18375: URL: https://github.com/apache/incubator-mxnet/pull/18375#issuecomment-632928380 @nickguletskii thank you for your help fixing the 1.x pipeline! To address the current Jetson related failure, it would be sufficient to backport only the jetson changes (ie Dockerfile.build.jetson and the corresponding cmake files). @waytrue17 is attempting to do that in https://github.com/apache/incubator-mxnet/pull/18339 for the 1.7 branch. However, backporting more of the changes (as in your PR) will help the CI stability. So once your PR passes CI, it's great to merge it. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] leezu edited a comment on pull request #18375: [v1.x] Backport edge pipeline
leezu edited a comment on pull request #18375: URL: https://github.com/apache/incubator-mxnet/pull/18375#issuecomment-632928380 @nickguletskii thank you for your help fixing the 1.x pipeline! To address the current Jetson related failure, it would be sufficient to backport only the jetson changes (ie Dockerfile.build.jetson and the corresponding cmake files). @waytrue17 is attempting to do that in https://github.com/apache/incubator-mxnet/pull/18339 for the 1.7 branch. However, backporting more of the changes (as in your PR) will help the CI stability on the 1.x branch. So once your PR passes CI, it's great to merge it. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] waytrue17 commented on a change in pull request #18339: update dockerfile for jetson
waytrue17 commented on a change in pull request #18339:
URL: https://github.com/apache/incubator-mxnet/pull/18339#discussion_r429474732
##
File path: ci/docker/install/ubuntu_julia.sh
##
@@ -32,7 +32,7 @@ function install_julia() {
# The julia version in Ubuntu repo is too old
# We download the tarball from the official link:
# https://julialang.org/downloads/
-wget -qO $JLBINARY
https://s3.amazonaws.com/julialang2/bin/linux/x64/0.7/julia-0.7.0-linux-x86_64.tar.gz
Review comment:
Thanks for pointing it out. I'll replace it back to the S3 path.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18339: update dockerfile for jetson
leezu commented on a change in pull request #18339:
URL: https://github.com/apache/incubator-mxnet/pull/18339#discussion_r429472380
##
File path: ci/docker/install/ubuntu_julia.sh
##
@@ -32,7 +32,7 @@ function install_julia() {
# The julia version in Ubuntu repo is too old
# We download the tarball from the official link:
# https://julialang.org/downloads/
-wget -qO $JLBINARY
https://s3.amazonaws.com/julialang2/bin/linux/x64/0.7/julia-0.7.0-linux-x86_64.tar.gz
Review comment:
The problem is not about the S3 path but that you hardcode the 0.7
version instead of using `$1` and `$2`. In any case, hopefully
https://julialang-s3.julialang.org/bin/linux/x64/$1/julia-$2-linux-x86_64.tar.gz
will remain stable for the future
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18375: [v1.x] Backport edge pipeline
mxnet-bot commented on pull request #18375: URL: https://github.com/apache/incubator-mxnet/pull/18375#issuecomment-632921402 Jenkins CI successfully triggered : [sanity] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] nickguletskii commented on pull request #18375: [v1.x] Backport edge pipeline
nickguletskii commented on pull request #18375: URL: https://github.com/apache/incubator-mxnet/pull/18375#issuecomment-632921386 @mxnet-bot run ci [sanity] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18391: Disable test_CSVIter
mxnet-bot commented on pull request #18391: URL: https://github.com/apache/incubator-mxnet/pull/18391#issuecomment-632920282 Hey @leezu , Thanks for submitting the PR All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: - To trigger all jobs: @mxnet-bot run ci [all] - To trigger specific jobs: @mxnet-bot run ci [job1, job2] *** **CI supported jobs**: [clang, centos-cpu, miscellaneous, centos-gpu, website, sanity, unix-cpu, windows-cpu, unix-gpu, edge, windows-gpu] *** _Note_: Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. All CI tests must pass before the PR can be merged. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] leezu closed pull request #18391: Disable test_CSVIter
leezu closed pull request #18391: URL: https://github.com/apache/incubator-mxnet/pull/18391 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] leezu opened a new pull request #18391: Disable test_CSVIter
leezu opened a new pull request #18391: URL: https://github.com/apache/incubator-mxnet/pull/18391 https://github.com/apache/incubator-mxnet/issues/18382 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] zhreshold opened a new pull request #18390: Fix #18382 use tmpdir fixture to CSVIter test
zhreshold opened a new pull request #18390: URL: https://github.com/apache/incubator-mxnet/pull/18390 ## Description ## Fix #18382 ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes) - [ ] Changes are complete (i.e. I finished coding on this PR) - [ ] All changes have test coverage: - Unit tests are added for small changes to verify correctness (e.g. adding a new operator) - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore) - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL) - [ ] Code is well-documented: - For user-facing API changes, API doc string has been updated. - For new C++ functions in header files, their functionalities and arguments are documented. - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable - Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html - [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### Changes ### - [ ] Feature1, tests, (and when applicable, API doc) - [ ] Feature2, tests, (and when applicable, API doc) ## Comments ## - If this change is a backward incompatible change, why must this change be made. - Interesting edge cases to note here This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18390: Fix #18382 use tmpdir fixture to CSVIter test
mxnet-bot commented on pull request #18390: URL: https://github.com/apache/incubator-mxnet/pull/18390#issuecomment-632912969 Hey @zhreshold , Thanks for submitting the PR All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: - To trigger all jobs: @mxnet-bot run ci [all] - To trigger specific jobs: @mxnet-bot run ci [job1, job2] *** **CI supported jobs**: [centos-cpu, clang, edge, windows-gpu, miscellaneous, unix-cpu, website, centos-gpu, windows-cpu, sanity, unix-gpu] *** _Note_: Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. All CI tests must pass before the PR can be merged. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-mxnet] 01/01: Disable test_CSVIter
This is an automated email from the ASF dual-hosted git repository. lausen pushed a commit to branch leezu-patch-4 in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git commit 1c17e342ee66add304cc54b3c0558965b1bb0c87 Author: Leonard Lausen AuthorDate: Fri May 22 13:39:13 2020 -0700 Disable test_CSVIter --- tests/python/unittest/test_io.py | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tests/python/unittest/test_io.py b/tests/python/unittest/test_io.py index 635471d..86af2b9 100644 --- a/tests/python/unittest/test_io.py +++ b/tests/python/unittest/test_io.py @@ -23,7 +23,7 @@ from mxnet.base import MXNetError import numpy as np import os import gzip -import pickle as pickle +import pickle import time try: import h5py @@ -32,10 +32,7 @@ except ImportError: import sys from common import assertRaises import pytest -try: -from itertools import izip_longest as zip_longest -except: -from itertools import zip_longest +from itertools import zip_longest def test_MNISTIter(tmpdir): @@ -426,6 +423,7 @@ def test_DataBatch(): r'DataBatch: data shapes: \[\(2L?, 3L?\), \(7L?, 8L?\)\] label shapes: \[\(4L?, 5L?\)\]', str(batch)) +@pytest.mark.skip(reason="https://github.com/apache/incubator-mxnet/issues/18382";) def test_CSVIter(): def check_CSVIter_synthetic(dtype='float32'): cwd = os.getcwd()
[incubator-mxnet] branch leezu-patch-4 created (now 1c17e34)
This is an automated email from the ASF dual-hosted git repository. lausen pushed a change to branch leezu-patch-4 in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. at 1c17e34 Disable test_CSVIter This branch includes the following new commits: new 1c17e34 Disable test_CSVIter The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GitHub] [incubator-mxnet] leezu commented on issue #18382: test_CSVIter
leezu commented on issue #18382: URL: https://github.com/apache/incubator-mxnet/issues/18382#issuecomment-632900116 Also failed on CD This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] leezu edited a comment on issue #18382: test_CSVIter
leezu edited a comment on issue #18382: URL: https://github.com/apache/incubator-mxnet/issues/18382#issuecomment-632900116 Also failed on CD http://jenkins.mxnet-ci.amazon-ml.com/blue/rest/organizations/jenkins/pipelines/restricted-mxnet-cd/pipelines/mxnet-cd-release-job/runs/1153/nodes/222/steps/248/log/?start=0 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-mxnet] branch master updated: Introduce MXNET_BUILD_SHARED_LIBS to specify build type of libmxnet (#18365)
This is an automated email from the ASF dual-hosted git repository.
lausen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git
The following commit(s) were added to refs/heads/master by this push:
new 497bf7e Introduce MXNET_BUILD_SHARED_LIBS to specify build type of
libmxnet (#18365)
497bf7e is described below
commit 497bf7efb403a9174817f07ab3d2f9be033845ad
Author: Balint Cristian
AuthorDate: Fri May 22 22:35:43 2020 +0300
Introduce MXNET_BUILD_SHARED_LIBS to specify build type of libmxnet (#18365)
* Consider BUILD_SHARED_LIBS flag
* Use MXNET_BUILD_SHARED_LIBS
---
CMakeLists.txt | 44 +-
.../predict-cpp/CMakeLists.txt | 31 ---
tests/CMakeLists.txt | 30 ---
3 files changed, 33 insertions(+), 72 deletions(-)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 790f31b..0f82bd3 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -38,6 +38,7 @@ include(${CMAKE_CURRENT_SOURCE_DIR}/cmake/Utils.cmake)
include(CMakeDependentOption)
#Some things have order. This must be put in front alone
+option(MXNET_BUILD_SHARED_LIBS "Build shared libraries instead of static
libraries" ON)
option(USE_CUDA "Build with CUDA support" ON)
set(MXNET_CUDA_ARCH "Auto" CACHE STRING "Target NVIDIA GPU achitecture.
Format: Auto | Common | All | LIST(ARCH_AND_PTX ...)
@@ -657,26 +658,24 @@ endif()
# Add cmake targets
add_subdirectory("3rdparty/mshadow")
-set(MXNET_INSTALL_TARGETS mxnet)
if(UNIX)
string(APPEND CMAKE_CUDA_FLAGS " ${CUDA_ARCH_FLAGS_SPACES}")
# Create dummy file since we want an empty shared library before linking
set(DUMMY_SOURCE ${CMAKE_BINARY_DIR}/dummy.c)
file(WRITE ${DUMMY_SOURCE} "")
- list(APPEND MXNET_INSTALL_TARGETS mxnet_static)
- add_library(mxnet_static STATIC ${SOURCE})
- target_link_libraries(mxnet_static PUBLIC mshadow)
- target_compile_definitions(mxnet_static PUBLIC
DMLC_LOG_FATAL_THROW=$)
- add_library(mxnet SHARED ${DUMMY_SOURCE})
- target_link_libraries(mxnet PRIVATE ${BEGIN_WHOLE_ARCHIVE}
$ ${END_WHOLE_ARCHIVE})
- target_link_libraries(mxnet PRIVATE mxnet_static)
- target_link_libraries(mxnet_static PUBLIC ${CMAKE_DL_LIBS})
- set_target_properties(mxnet_static PROPERTIES OUTPUT_NAME mxnet)
+ if(MXNET_BUILD_SHARED_LIBS)
+add_library(mxnet SHARED ${SOURCE})
+ else()
+add_library(mxnet STATIC ${SOURCE})
+ endif()
+ target_link_libraries(mxnet PUBLIC mshadow)
+ target_link_libraries(mxnet PUBLIC ${CMAKE_DL_LIBS})
+ target_compile_definitions(mxnet PUBLIC
DMLC_LOG_FATAL_THROW=$)
if(CMAKE_BUILD_TYPE STREQUAL "RelWithDebInfo")
-target_compile_options(mxnet_static PRIVATE
"$<$:-Werror>")
+target_compile_options(mxnet PRIVATE "$<$:-Werror>")
# Ignore erroneous compiler warnings:
# 1) variables used in '#pragma omp parallel' are considered unused
-target_compile_options(mxnet_static PRIVATE
"$<$:-Wno-error=unused-variable>")
+target_compile_options(mxnet PRIVATE
"$<$:-Wno-error=unused-variable>")
if(USE_CUDA)
# Note: "=" is required to avoid breaking ccache
string(APPEND CMAKE_CUDA_FLAGS " -Werror=cross-execution-space-call")
@@ -684,8 +683,8 @@ if(UNIX)
endif()
if(ENABLE_TESTCOVERAGE)
find_program(GCOV_PATH gcov REQUIRED)
-target_compile_options(mxnet_static PUBLIC "--coverage")
-target_link_libraries(mxnet_static PUBLIC gcov)
+target_compile_options(mxnet PUBLIC "--coverage")
+target_link_libraries(mxnet PUBLIC gcov)
endif()
elseif(MSVC)
if(USE_CUDA)
@@ -822,25 +821,18 @@ if(MSVC)
target_link_libraries(mxnet_${arch} PUBLIC ${mxnet_LINKER_LIBS})
target_link_libraries(mxnet_${arch} PUBLIC dmlc)
endforeach()
- else()
-target_link_libraries(mxnet PUBLIC ${mxnet_LINKER_LIBS})
-target_link_libraries(mxnet PUBLIC dmlc)
endif()
-else()
- target_link_libraries(mxnet_static PUBLIC ${mxnet_LINKER_LIBS})
- target_link_libraries(mxnet PUBLIC dmlc)
endif()
+target_link_libraries(mxnet PUBLIC ${mxnet_LINKER_LIBS})
+target_link_libraries(mxnet PUBLIC dmlc)
+
if(USE_OPENCV AND OpenCV_VERSION_MAJOR GREATER 2)
add_executable(im2rec "tools/im2rec.cc")
- if(MSVC)
-target_link_libraries(im2rec mxnet)
- else()
-target_link_libraries(im2rec ${BEGIN_WHOLE_ARCHIVE} mxnet_static
${END_WHOLE_ARCHIVE})
- endif()
target_link_libraries(im2rec
${mxnet_LINKER_LIBS}
${OpenCV_LIBS}
+mxnet
dmlc
)
else()
@@ -858,7 +850,7 @@ endif()
# https://cmake.org/cmake/help/v3.13/variable/CMAKE_INSTALL_PREFIX.html
# https://cmake.org/cmake/help/v3.13/module/GNUInstallDirs.html
include(GNUInstallDirs)
-install(TARGETS ${MXNET_INSTALL_TARGETS}
+install(TARGETS mxnet
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
diff --git a/ex
[GitHub] [incubator-mxnet] leezu merged pull request #18365: Consider MXNET_BUILD_SHARED_LIBS flag
leezu merged pull request #18365: URL: https://github.com/apache/incubator-mxnet/pull/18365 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #18365: Consider MXNET_BUILD_SHARED_LIBS flag
leezu commented on pull request #18365: URL: https://github.com/apache/incubator-mxnet/pull/18365#issuecomment-632879807 Thanks @cbalint13 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on issue #18227: label data type mistake
szha commented on issue #18227: URL: https://github.com/apache/incubator-mxnet/issues/18227#issuecomment-632861892 let's add a magic number header to the file for proper versioning and correctly handling large integer in the new version. and for files without magic number, we keep the behavior consistent with the current behavior. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-mxnet] branch master updated: Fix reference leak in Block._children and enable reference leak tests universally (#18376)
This is an automated email from the ASF dual-hosted git repository.
zhasheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git
The following commit(s) were added to refs/heads/master by this push:
new c3aff73 Fix reference leak in Block._children and enable reference
leak tests universally (#18376)
c3aff73 is described below
commit c3aff732371d6177e5d522c052fb7258978d8ce4
Author: Leonard Lausen
AuthorDate: Fri May 22 11:53:44 2020 -0700
Fix reference leak in Block._children and enable reference leak tests
universally (#18376)
* Fix reference leak in Block._children
* Activate everywhere
* Disable on CentOS
* Fix
---
conftest.py | 47 ---
pytest.ini | 1 +
python/mxnet/gluon/block.py | 20 +++
python/mxnet/gluon/contrib/nn/basic_layers.py | 4 +-
python/mxnet/gluon/nn/basic_layers.py | 28 +
python/mxnet/gluon/rnn/rnn_cell.py | 62 ++-
tests/python/conftest.py| 79 +
tests/python/gpu/test_contrib_amp.py| 1 +
tests/python/train/test_bucketing.py| 3 +
tests/python/train/test_dtype.py| 7 ++-
tests/python/train/test_resnet_aug.py | 7 ++-
tests/python/unittest/onnx/mxnet_export_test.py | 2 +-
tests/python/unittest/test_autograd.py | 3 +
tests/python/unittest/test_gluon.py | 37 +++-
tests/python/unittest/test_gluon_data.py| 3 +
tests/python/unittest/test_module.py| 2 +
16 files changed, 183 insertions(+), 123 deletions(-)
diff --git a/conftest.py b/conftest.py
index 7a0aa44..0500818 100644
--- a/conftest.py
+++ b/conftest.py
@@ -230,50 +230,3 @@ def doctest(doctest_namespace):
logging.warning('Unable to import numpy/mxnet. Skipping conftest.')
import doctest
doctest.ELLIPSIS_MARKER = '-etc-'
-
-
-@pytest.fixture(scope='session')
-def mxnet_module():
-import mxnet
-return mxnet
-
-
-@pytest.fixture()
-# @pytest.fixture(autouse=True) # Fix all the bugs and mark this autouse=True
-def check_leak_ndarray(mxnet_module):
-# Collect garbage prior to running the next test
-gc.collect()
-# Enable gc debug mode to check if the test leaks any arrays
-gc_flags = gc.get_debug()
-gc.set_debug(gc.DEBUG_SAVEALL)
-
-# Run the test
-yield
-
-# Check for leaked NDArrays
-gc.collect()
-gc.set_debug(gc_flags) # reset gc flags
-
-seen = set()
-def has_array(element):
-try:
-if element in seen:
-return False
-seen.add(element)
-except TypeError: # unhashable
-pass
-
-if isinstance(element, mxnet_module.nd._internal.NDArrayBase):
-return True
-elif hasattr(element, '__dict__'):
-return any(has_array(x) for x in vars(element))
-elif isinstance(element, dict):
-return any(has_array(x) for x in element.items())
-else:
-try:
-return any(has_array(x) for x in element)
-except (TypeError, KeyError):
-return False
-
-assert not any(has_array(x) for x in gc.garbage), 'Found leaked NDArrays
due to reference cycles'
-del gc.garbage[:]
diff --git a/pytest.ini b/pytest.ini
index 6c299d1..a88e501 100644
--- a/pytest.ini
+++ b/pytest.ini
@@ -23,6 +23,7 @@ markers =
gpu: mark a test that requires GPU.
integration: mark an integration test
onnx_coverage: ONNX coverage test
+garbage_expected: this test leaks ndarray references. The tested
functionality is broken or there is a Python bug.
env =
MXNET_HOME=tests/data
diff --git a/python/mxnet/gluon/block.py b/python/mxnet/gluon/block.py
index ded66a7..78b5a72 100644
--- a/python/mxnet/gluon/block.py
+++ b/python/mxnet/gluon/block.py
@@ -348,7 +348,7 @@ class Block(object):
return True
return False
elif isinstance(data, Block):
-return not data in children
+return not data in (c() for c in children)
else:
return False
for k, v in self.__dict__.items():
@@ -426,7 +426,7 @@ class Block(object):
pattern = re.compile(select)
ret.update({name:value for name, value in self.params.items() if
pattern.match(name)})
for cld in self._children.values():
-ret.update(cld.collect_params(select=select))
+ret.update(cld().collect_params(select=select))
return ret
def _collect_params_with_prefix(self, prefix=''):
@@ -434,7 +434,7 @@ class Block(object):
prefix += '.'
ret = {prefix + key : val for key, val in self._reg_params.items()}
for name, child in self._children.it
[GitHub] [incubator-mxnet] szha merged pull request #18376: Fix reference leak in Block._children and enable reference leak tests universally
szha merged pull request #18376: URL: https://github.com/apache/incubator-mxnet/pull/18376 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.
This is an automated email from the ASF dual-hosted git repository. aaronmarkham pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 8a67291 Bump the publish timestamp. 8a67291 is described below commit 8a67291b1ad2f91a8f1d0866e3fd0d9675db412c Author: mxnet-ci AuthorDate: Fri May 22 18:43:12 2020 + Bump the publish timestamp. --- date.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/date.txt b/date.txt new file mode 100644 index 000..aacd754 --- /dev/null +++ b/date.txt @@ -0,0 +1 @@ +Fri May 22 18:43:12 UTC 2020
[GitHub] [incubator-mxnet] yzhliu closed issue #16964: Data comparison is inconsistent with numpy
yzhliu closed issue #16964: URL: https://github.com/apache/incubator-mxnet/issues/16964 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] yzhliu commented on issue #16964: Data comparison is inconsistent with numpy
yzhliu commented on issue #16964: URL: https://github.com/apache/incubator-mxnet/issues/16964#issuecomment-632842690 closed by #18277 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] yzhliu commented on issue #18068: [Numpy] Failed for Boolean type
yzhliu commented on issue #18068: URL: https://github.com/apache/incubator-mxnet/issues/18068#issuecomment-632842398 closed by #18277 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-mxnet] branch master updated (d9fc74e -> 48dea6e)
This is an automated email from the ASF dual-hosted git repository. liuyizhi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from d9fc74e Fix FInferShape for some ops to support partial type inference (#18348) add 48dea6e Fix binary scalar dtype and add bool support (#18277) No new revisions were added by this update. Summary of changes: python/mxnet/symbol/numpy/_symbol.py | 8 +- src/api/operator/ufunc_helper.cc | 64 - src/operator/contrib/gradient_multiplier_op.cc | 6 +- .../numpy/np_elemwise_broadcast_logic_op.cc| 18 +-- src/operator/numpy/np_elemwise_broadcast_op.cc | 30 ++--- src/operator/numpy/np_elemwise_broadcast_op.h | 10 -- .../numpy/np_elemwise_broadcast_op_extended.cc | 68 +- .../numpy/np_elemwise_broadcast_op_extended_sec.cc | 44 +++ src/operator/numpy/np_matrix_op-inl.h | 4 +- src/operator/numpy/np_true_divide-inl.h| 3 +- src/operator/numpy/np_true_divide.cc | 12 +- src/operator/tensor/elemwise_binary_scalar_op.h| 123 + .../tensor/elemwise_binary_scalar_op_basic.cc | 49 +++ .../tensor/elemwise_binary_scalar_op_extended.cc | 36 ++--- .../tensor/elemwise_binary_scalar_op_logic.cc | 3 +- tests/python/unittest/test_higher_order_grad.py| 6 + tests/python/unittest/test_numpy_op.py | 145 +++-- tests/python/unittest/test_symbol.py | 2 - 18 files changed, 397 insertions(+), 234 deletions(-)
[GitHub] [incubator-mxnet] yzhliu closed issue #18068: [Numpy] Failed for Boolean type
yzhliu closed issue #18068: URL: https://github.com/apache/incubator-mxnet/issues/18068 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] yzhliu closed issue #16653: [Bug][Numpy] The data type of power is not correct
yzhliu closed issue #16653: URL: https://github.com/apache/incubator-mxnet/issues/16653 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] yzhliu commented on issue #16653: [Bug][Numpy] The data type of power is not correct
yzhliu commented on issue #16653: URL: https://github.com/apache/incubator-mxnet/issues/16653#issuecomment-632842301 closed by #18277 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-mxnet] branch master updated (d9fc74e -> 48dea6e)
This is an automated email from the ASF dual-hosted git repository. liuyizhi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from d9fc74e Fix FInferShape for some ops to support partial type inference (#18348) add 48dea6e Fix binary scalar dtype and add bool support (#18277) No new revisions were added by this update. Summary of changes: python/mxnet/symbol/numpy/_symbol.py | 8 +- src/api/operator/ufunc_helper.cc | 64 - src/operator/contrib/gradient_multiplier_op.cc | 6 +- .../numpy/np_elemwise_broadcast_logic_op.cc| 18 +-- src/operator/numpy/np_elemwise_broadcast_op.cc | 30 ++--- src/operator/numpy/np_elemwise_broadcast_op.h | 10 -- .../numpy/np_elemwise_broadcast_op_extended.cc | 68 +- .../numpy/np_elemwise_broadcast_op_extended_sec.cc | 44 +++ src/operator/numpy/np_matrix_op-inl.h | 4 +- src/operator/numpy/np_true_divide-inl.h| 3 +- src/operator/numpy/np_true_divide.cc | 12 +- src/operator/tensor/elemwise_binary_scalar_op.h| 123 + .../tensor/elemwise_binary_scalar_op_basic.cc | 49 +++ .../tensor/elemwise_binary_scalar_op_extended.cc | 36 ++--- .../tensor/elemwise_binary_scalar_op_logic.cc | 3 +- tests/python/unittest/test_higher_order_grad.py| 6 + tests/python/unittest/test_numpy_op.py | 145 +++-- tests/python/unittest/test_symbol.py | 2 - 18 files changed, 397 insertions(+), 234 deletions(-)
[GitHub] [incubator-mxnet] yzhliu commented on issue #18213: Cannot concatenate boolean numpy arrays
yzhliu commented on issue #18213: URL: https://github.com/apache/incubator-mxnet/issues/18213#issuecomment-632842204 closed by #18277 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] yzhliu closed issue #18213: Cannot concatenate boolean numpy arrays
yzhliu closed issue #18213: URL: https://github.com/apache/incubator-mxnet/issues/18213 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] yzhliu commented on pull request #18277: Fix binary scalar dtype and add bool support
yzhliu commented on pull request #18277: URL: https://github.com/apache/incubator-mxnet/pull/18277#issuecomment-632841881 Thanks @Tommliu @CassiniXu @sxjscience This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] yzhliu merged pull request #18277: Fix binary scalar dtype and add bool support
yzhliu merged pull request #18277: URL: https://github.com/apache/incubator-mxnet/pull/18277 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] John1231983 commented on issue #18333: How to implement cross entropy for binary segmentation using symbol only?
John1231983 commented on issue #18333: URL: https://github.com/apache/incubator-mxnet/issues/18333#issuecomment-632833156 @wkcn thanks so much for your answer. Could you please verify my implementation. Does it correct, should I use `axis=1` in `sum` and then use `.mean()` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] zhreshold commented on a change in pull request #18379: change _Pragma to #pragma
zhreshold commented on a change in pull request #18379:
URL: https://github.com/apache/incubator-mxnet/pull/18379#discussion_r429381407
##
File path: src/io/batchify.cc
##
@@ -37,6 +37,17 @@
namespace mxnet {
namespace io {
+
+#ifdef _MSC_VER
+ #if _MSC_VER < 1925
+#define omp_parallel __pragma(omp parallel for num_threads(bs))
Review comment:
Can you make `bs` argument of the macro?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-mxnet] dlearner2020 opened a new issue #18389: Exception in thread "main" org.apache.mxnet.MXNetError--run java exmaple code error
dlearner2020 opened a new issue #18389: URL: https://github.com/apache/incubator-mxnet/issues/18389 ## Description I want to inference a pic by java,so I've followed the official instructions (https://mxnet.apache.org/api/java.html) and configured a maven project.But when I tried to run the sample code(ObjectDetectionTutorial.java),I encountered 2 issues: 1.when I run java -cp "target/javaMXNet-1.0-SNAPSHOT.jar:target/dependency/*" mxnet.ObjectDetectionTutorial in terminal,it returns an error: 错误: 找不到或无法加载主类 mxnet.ObjectDetectionTutorial (Error: Could not find or load main class) 2.When I run using the command shown below: bash bin/run_od.sh It will return another error: oak@oaksheild:~/下载/java-demo$ bash bin/run_od.sh modelPath: /home/oak/CODE/resnet50_ssd/resnet50_ssd_model imagePath: /home/oak/CODE/resnet50_ssd/images/dog.jpg [org.apache.mxnet.infer.MXNetThreadPoolHandler-0] INFO MXNetJVM - Try loading mxnet-scala from native path. [org.apache.mxnet.infer.MXNetThreadPoolHandler-0] INFO MXNetJVM - Copying and loading native library from the jar archive Exception in thread "main" org.apache.mxnet.MXNetError: MXNetError: Check failed: ch == '\"' (-1 vs. ") : Error at Line 763, around ^``, Expect '"' but get 'ÿ' Stack trace: File "/work/mxnet/3rdparty/dmlc-core/include/dmlc/./json.h", line 677 at org.apache.mxnet.Base$.checkCall(Base.scala:110) at org.apache.mxnet.Symbol$.load(Symbol.scala:1357) at org.apache.mxnet.Model$.loadCheckpoint(Model.scala:70) at org.apache.mxnet.module.Module$.loadCheckpoint(Module.scala:644) at org.apache.mxnet.infer.Predictor$$anonfun$14.apply(Predictor.scala:256) at org.apache.mxnet.infer.Predictor$$anonfun$14.apply(Predictor.scala:256) at org.apache.mxnet.infer.MXNetThreadPoolHandler$$anon$4.call(MXNetHandler.scala:83) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) [Thread-1] INFO org.apache.mxnet.util.NativeLibraryLoader - Deleting /tmp/mxnet1689381890391321595/libquadmath.so.0 [Thread-1] INFO org.apache.mxnet.util.NativeLibraryLoader - Deleting /tmp/mxnet1689381890391321595/libgfortran.so.3 [Thread-1] INFO org.apache.mxnet.util.NativeLibraryLoader - Deleting /tmp/mxnet1689381890391321595/mxnet-scala [Thread-1] INFO org.apache.mxnet.util.NativeLibraryLoader - Deleting /tmp/mxnet1689381890391321595/libmxnet.so [Thread-1] INFO org.apache.mxnet.util.NativeLibraryLoader - Deleting /tmp/mxnet1689381890391321595 ## Environment OS: cat /proc/version Linux version 5.4.0-21-generic (buildd@lcy01-amd64-006) (gcc version 9.3.0 (Ubuntu 9.3.0-8ubuntu1)) #25-Ubuntu SMP Sat Mar 28 13:10:28 UTC 2020 installed from ubuntukylin-20.04-beta-enhanced-amd64.iso java version: oak@oaksheild:~/CODE/java-demo$ java -version openjdk version "1.8.0_252" OpenJDK Runtime Environment (build 1.8.0_252-8u252-b09-1~18.04-b09) OpenJDK 64-Bit Server VM (build 25.252-b09, mixed mode) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #18160: [1.x] Add BatchNormWithReLU fp32/bf16
szha commented on pull request #18160: URL: https://github.com/apache/incubator-mxnet/pull/18160#issuecomment-632819881 there are some issues on the 1.x CI and the team is working on it. once resolved, we can trigger the CI for this PR again. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky commented on pull request #18236: [1.7] Pass args fix2 + Fix pylint with unpinned astroid causing CI issues
samskalicky commented on pull request #18236: URL: https://github.com/apache/incubator-mxnet/pull/18236#issuecomment-632819992 @ciyongch looks like the CI is currently broken for 1.x per @leezu does this block the 1.7 release? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-mxnet] branch master updated (2cb6153 -> d9fc74e)
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 2cb6153 Fix test_subgraph skipif (#18361) add d9fc74e Fix FInferShape for some ops to support partial type inference (#18348) No new revisions were added by this update. Summary of changes: src/operator/contrib/batch_norm_relu.cc | 7 +++ src/operator/nn/batch_norm.cc | 7 +++ src/operator/nn/group_norm.cc | 8 src/operator/nn/layer_norm.cc | 7 --- src/operator/nn/pooling.cc | 9 +++-- src/operator/tensor/matrix_op-inl.h | 22 +- 6 files changed, 38 insertions(+), 22 deletions(-)
[incubator-mxnet] branch master updated (2cb6153 -> d9fc74e)
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 2cb6153 Fix test_subgraph skipif (#18361) add d9fc74e Fix FInferShape for some ops to support partial type inference (#18348) No new revisions were added by this update. Summary of changes: src/operator/contrib/batch_norm_relu.cc | 7 +++ src/operator/nn/batch_norm.cc | 7 +++ src/operator/nn/group_norm.cc | 8 src/operator/nn/layer_norm.cc | 7 --- src/operator/nn/pooling.cc | 9 +++-- src/operator/tensor/matrix_op-inl.h | 22 +- 6 files changed, 38 insertions(+), 22 deletions(-)
[incubator-mxnet] branch master updated: Fix FInferShape for some ops to support partial type inference (#18348)
This is an automated email from the ASF dual-hosted git repository.
zhasheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git
The following commit(s) were added to refs/heads/master by this push:
new d9fc74e Fix FInferShape for some ops to support partial type
inference (#18348)
d9fc74e is described below
commit d9fc74ecb6efa2c32501ba343b6e9d0c0ee43f57
Author: Serge Panev
AuthorDate: Fri May 22 19:21:04 2020 +0200
Fix FInferShape for some ops to support partial type inference (#18348)
* Fix FInferShape for some ops to support partial type inference
Signed-off-by: Serge Panev
* Add missing ndim check in in matrix_op-inl.h
Signed-off-by: Serge Panev
---
src/operator/contrib/batch_norm_relu.cc | 7 +++
src/operator/nn/batch_norm.cc | 7 +++
src/operator/nn/group_norm.cc | 8
src/operator/nn/layer_norm.cc | 7 ---
src/operator/nn/pooling.cc | 9 +++--
src/operator/tensor/matrix_op-inl.h | 22 +-
6 files changed, 38 insertions(+), 22 deletions(-)
diff --git a/src/operator/contrib/batch_norm_relu.cc
b/src/operator/contrib/batch_norm_relu.cc
index 14452cc..0bb2f0b 100644
--- a/src/operator/contrib/batch_norm_relu.cc
+++ b/src/operator/contrib/batch_norm_relu.cc
@@ -55,6 +55,9 @@ static bool BatchNormWithReLUShape(const nnvm::NodeAttrs&
attrs,
CHECK_EQ(in_shape->size(), 5U) << "Input:[data, gamma, beta, MovingMean,
MovingVar]";
CHECK_EQ(out_shape->size(), 4U);
const mxnet::TShape &dshape = in_shape->at(batchnormrelu::kData);
+ if (!mxnet::ndim_is_known(dshape)) {
+return false;
+ }
const size_t channelAxis = static_cast(param.axis < 0
? static_cast(dshape.ndim()) + param.axis
@@ -63,10 +66,6 @@ static bool BatchNormWithReLUShape(const nnvm::NodeAttrs&
attrs,
const int channelCount = dshape[channelAxis];
- if (!mxnet::ndim_is_known(dshape)) {
-return false;
- }
-
in_shape->at(batchnormrelu::kGamma) = mxnet::TShape(Shape1(channelCount));
in_shape->at(batchnormrelu::kBeta) = mxnet::TShape(Shape1(channelCount));
in_shape->at(batchnormrelu::kInMovingMean) =
mxnet::TShape(Shape1(channelCount)); // kMovingMean
diff --git a/src/operator/nn/batch_norm.cc b/src/operator/nn/batch_norm.cc
index 815288c..b865269 100644
--- a/src/operator/nn/batch_norm.cc
+++ b/src/operator/nn/batch_norm.cc
@@ -323,6 +323,9 @@ static bool BatchNormShape(const nnvm::NodeAttrs& attrs,
CHECK_EQ(in_shape->size(), 5U) << "Input:[data, gamma, beta, MovingMean,
MovingVar]";
CHECK_EQ(out_shape->size(), 3U);
const mxnet::TShape &dshape = in_shape->at(batchnorm::kData);
+ if (!mxnet::ndim_is_known(dshape)) {
+return false;
+ }
const size_t channelAxis = static_cast(param.axis < 0
? static_cast(dshape.ndim()) + param.axis
@@ -331,10 +334,6 @@ static bool BatchNormShape(const nnvm::NodeAttrs& attrs,
const index_t channelCount = dshape[channelAxis];
- if (!mxnet::ndim_is_known(dshape)) {
-return false;
- }
-
in_shape->at(batchnorm::kGamma) = mxnet::TShape(Shape1(channelCount));
in_shape->at(batchnorm::kBeta) = mxnet::TShape(Shape1(channelCount));
in_shape->at(batchnorm::kInMovingMean) =
mxnet::TShape(Shape1(channelCount)); // kMovingMean
diff --git a/src/operator/nn/group_norm.cc b/src/operator/nn/group_norm.cc
index c939b44..53fab31 100644
--- a/src/operator/nn/group_norm.cc
+++ b/src/operator/nn/group_norm.cc
@@ -39,14 +39,14 @@ static bool GroupNormShape(const nnvm::NodeAttrs& attrs,
using namespace mshadow;
CHECK_EQ(in_shape->size(), 3U) << "Input:[data, gamma, beta]";
const mxnet::TShape &dshape = in_shape->at(groupnorm::kData);
- CHECK_GE(dshape.ndim(), 3U);
- const int num_groups = param.num_groups;
- CHECK_EQ(dshape[1] % num_groups, 0) << "# of channels must be divisible by #
of groups";
-
if (!mxnet::ndim_is_known(dshape)) {
return false;
}
+ CHECK_GE(dshape.ndim(), 3U);
+ const int num_groups = param.num_groups;
+ CHECK_EQ(dshape[1] % num_groups, 0) << "# of channels must be divisible by #
of groups";
+
in_shape->at(groupnorm::kGamma) = mxnet::TShape(Shape1(dshape[1]));
in_shape->at(groupnorm::kBeta) = mxnet::TShape(Shape1(dshape[1]));
diff --git a/src/operator/nn/layer_norm.cc b/src/operator/nn/layer_norm.cc
index e3d641a..11178b3 100644
--- a/src/operator/nn/layer_norm.cc
+++ b/src/operator/nn/layer_norm.cc
@@ -43,15 +43,16 @@ static bool LayerNormShape(const nnvm::NodeAttrs& attrs,
using namespace mshadow;
CHECK_EQ(in_shape->size(), 3U) << "Input:[data, gamma, beta]";
const mxnet::TShape &dshape = in_shape->at(layernorm::kData);
+ if (!mxnet::ndim_is_known(dshape)) {
+return false;
+ }
+
int axis = GetRealAxis(param.axis, dshape.ndim());
CHECK(axis >= 0 && axis < dshape.ndim())
<< "Channel axis out of range: axis=" << param.axis;
const index_t channelCount = dshape[ax
[GitHub] [incubator-mxnet] szha merged pull request #18348: Fix FInferShape for some ops to support partial type inference
szha merged pull request #18348: URL: https://github.com/apache/incubator-mxnet/pull/18348 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18236: [1.7] Pass args fix2 + Fix pylint with unpinned astroid causing CI issues
mxnet-bot commented on pull request #18236: URL: https://github.com/apache/incubator-mxnet/pull/18236#issuecomment-632791604 Jenkins CI successfully triggered : [edge, centos-cpu, windows-gpu, centos-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky commented on pull request #18236: [1.7] Pass args fix2 + Fix pylint with unpinned astroid causing CI issues
samskalicky commented on pull request #18236: URL: https://github.com/apache/incubator-mxnet/pull/18236#issuecomment-632791542 @mxnet-bot run ci [edge, windows-gpu, centos-cpu, centos-gpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #17970: fix block.export
szha commented on a change in pull request #17970: URL: https://github.com/apache/incubator-mxnet/pull/17970#discussion_r429346195 ## File path: python/mxnet/gluon/block.py ## @@ -1248,7 +1248,11 @@ def export(self, path, epoch=0, remove_amp_cast=True): will be created, where is the 4 digits epoch number. epoch : int Epoch number of saved model. - +remove_amp_cast : bool, optional +Whether to remove the amp_cast and amp_multicast operators, before exporting the model. +allow_extra : bool, optional +Whether to save extra parameters whose name not in the result symbol. User can set +allow_extra to True to load these parameters with old mxnet.mod.Module.set_params api. Review comment: ```suggestion Whether to save extra parameters whose names are not in the result symbol. User can set allow_extra to True to load these parameters with old mxnet.mod.Module.set_params API. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #17970: fix block.export
szha commented on a change in pull request #17970: URL: https://github.com/apache/incubator-mxnet/pull/17970#discussion_r429346446 ## File path: python/mxnet/gluon/block.py ## @@ -1248,7 +1248,11 @@ def export(self, path, epoch=0, remove_amp_cast=True): will be created, where is the 4 digits epoch number. epoch : int Epoch number of saved model. - +remove_amp_cast : bool, optional +Whether to remove the amp_cast and amp_multicast operators, before exporting the model. +allow_extra : bool, optional +Whether to save extra parameters whose name not in the result symbol. User can set +allow_extra to True to load these parameters with old mxnet.mod.Module.set_params api. Review comment: You may want to backport this to 1.x as we are dropping module support in 2.0 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet-ci] ChaiBapchya commented on a change in pull request #26: Update latest build selection and log when one build fails
ChaiBapchya commented on a change in pull request #26:
URL: https://github.com/apache/incubator-mxnet-ci/pull/26#discussion_r429339036
##
File path: services/jenkins-pipeline-monitor/handler.py
##
@@ -123,8 +141,6 @@ def jenkins_pipeline_monitor():
latest_day_builds = get_latest_day_builds(job, latest_build_number)
logging.info(f'latest builds {latest_day_builds}')
# filter latest day builds by desired build type a.k.a release job type
-desired_release_job_type = ['mxnet_lib/static', 'python/pypi']
-
filtered_builds = filter_by_desired_release_job_type(latest_day_builds,
desired_release_job_type)
Review comment:
Addressed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-mxnet-ci] ChaiBapchya commented on a change in pull request #26: Update latest build selection and log when one build fails
ChaiBapchya commented on a change in pull request #26:
URL: https://github.com/apache/incubator-mxnet-ci/pull/26#discussion_r429338819
##
File path: services/jenkins-pipeline-monitor/handler.py
##
@@ -4,12 +4,14 @@
import logging
import secret_manager
+from datetime import datetime, timezone
from jenkinsapi.jenkins import Jenkins
logging.getLogger().setLevel(logging.INFO)
logging.getLogger('boto3').setLevel(logging.CRITICAL)
logging.getLogger('botocore').setLevel(logging.CRITICAL)
+desired_release_job_type = ['mxnet_lib/static', 'python/pypi']
Review comment:
Renamed it to `release_job_type`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-mxnet] eric-haibin-lin closed pull request #18388: remove mx.model.FeedForward API
eric-haibin-lin closed pull request #18388: URL: https://github.com/apache/incubator-mxnet/pull/18388 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] eric-haibin-lin opened a new pull request #18388: remove mx.model.FeedForward API
eric-haibin-lin opened a new pull request #18388: URL: https://github.com/apache/incubator-mxnet/pull/18388 ## Description ## remove the API and related examples. ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes) - [ ] Changes are complete (i.e. I finished coding on this PR) - [ ] All changes have test coverage: - Unit tests are added for small changes to verify correctness (e.g. adding a new operator) - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore) - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL) - [ ] Code is well-documented: - For user-facing API changes, API doc string has been updated. - For new C++ functions in header files, their functionalities and arguments are documented. - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable - Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html - [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### Changes ### - [ ] Feature1, tests, (and when applicable, API doc) - [ ] Feature2, tests, (and when applicable, API doc) ## Comments ## - If this change is a backward incompatible change, why must this change be made. - Interesting edge cases to note here This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18388: remove mx.model.FeedForward API
mxnet-bot commented on pull request #18388: URL: https://github.com/apache/incubator-mxnet/pull/18388#issuecomment-632774977 Hey @eric-haibin-lin , Thanks for submitting the PR All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: - To trigger all jobs: @mxnet-bot run ci [all] - To trigger specific jobs: @mxnet-bot run ci [job1, job2] *** **CI supported jobs**: [website, windows-gpu, sanity, unix-gpu, edge, miscellaneous, centos-cpu, windows-cpu, clang, unix-cpu, centos-gpu] *** _Note_: Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. All CI tests must pass before the PR can be merged. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] Alicia1529 commented on pull request #18351: Back port the PR #17672:boolean indexing to branch v1.x
Alicia1529 commented on pull request #18351: URL: https://github.com/apache/incubator-mxnet/pull/18351#issuecomment-632681180 @mxnet-bot run ci [edge] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18351: Back port the PR #17672:boolean indexing to branch v1.x
mxnet-bot commented on pull request #18351: URL: https://github.com/apache/incubator-mxnet/pull/18351#issuecomment-632681237 Jenkins CI successfully triggered : [edge] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18352: Back port the PR #17672:boolean indexing to branch v1.7.x
mxnet-bot commented on pull request #18352: URL: https://github.com/apache/incubator-mxnet/pull/18352#issuecomment-632681267 Jenkins CI successfully triggered : [edge] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] Alicia1529 commented on pull request #18352: Back port the PR #17672:boolean indexing to branch v1.7.x
Alicia1529 commented on pull request #18352: URL: https://github.com/apache/incubator-mxnet/pull/18352#issuecomment-632681231 @mxnet-bot run ci [edge] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] TriLoo commented on issue #18364: mx.gluon.data.Dataset class not support multiprocessing.Pool()
TriLoo commented on issue #18364: URL: https://github.com/apache/incubator-mxnet/issues/18364#issuecomment-632676244 Looks like some modification errors to `FindMKL.cmake` and the missed `libiomp5` caused this error, now it works. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.
This is an automated email from the ASF dual-hosted git repository. aaronmarkham pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new a0e2557 Bump the publish timestamp. a0e2557 is described below commit a0e2557a1c4250f6740fe2b6f54435785c4a5e00 Author: mxnet-ci AuthorDate: Fri May 22 12:48:02 2020 + Bump the publish timestamp. --- date.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/date.txt b/date.txt new file mode 100644 index 000..81e421f --- /dev/null +++ b/date.txt @@ -0,0 +1 @@ +Fri May 22 12:48:02 UTC 2020
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18379: change _Pragma to #pragma
mxnet-bot commented on pull request #18379: URL: https://github.com/apache/incubator-mxnet/pull/18379#issuecomment-632641079 Jenkins CI successfully triggered : [windows-cpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] yajiedesign commented on pull request #18379: change _Pragma to #pragma
yajiedesign commented on pull request #18379: URL: https://github.com/apache/incubator-mxnet/pull/18379#issuecomment-632641019 @mxnet-bot run ci [windows-cpu] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18351: Back port the PR #17672:boolean indexing to branch v1.x
mxnet-bot commented on pull request #18351: URL: https://github.com/apache/incubator-mxnet/pull/18351#issuecomment-632597142 Jenkins CI successfully triggered : [edge] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] Alicia1529 commented on pull request #18352: Back port the PR #17672:boolean indexing to branch v1.7.x
Alicia1529 commented on pull request #18352: URL: https://github.com/apache/incubator-mxnet/pull/18352#issuecomment-632597281 @mxnet-bot run ci [edge] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] Alicia1529 commented on pull request #18351: Back port the PR #17672:boolean indexing to branch v1.x
Alicia1529 commented on pull request #18351: URL: https://github.com/apache/incubator-mxnet/pull/18351#issuecomment-632597078 @mxnet-bot run ci [edge] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18352: Back port the PR #17672:boolean indexing to branch v1.7.x
mxnet-bot commented on pull request #18352: URL: https://github.com/apache/incubator-mxnet/pull/18352#issuecomment-632597322 Jenkins CI successfully triggered : [edge] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] JustinhoCHN commented on issue #17923: can not install mxnet on jetson nano, jetpack 4.3, mxnet 1.4
JustinhoCHN commented on issue #17923: URL: https://github.com/apache/incubator-mxnet/issues/17923#issuecomment-632580832 > Do you still have the image which you used on your Jetson Nano? Nvidia keeps on updating their images regularly and I ended up with CUDA 10.2 :/ > > Edit: This works? >  I changed the os to jetpack 4.4 DP, same issue as yours, I try to install cuda 10.0 in jetpack 4.4, but when I import mxnet, it'll just quit with "segmentation fault". I'm working on compile the cuda 10.2 python whl for jetson. I'll let you know if I make it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet] cbalint13 commented on pull request #18365: Consider BUILD_SHARED_LIBS flag
cbalint13 commented on pull request #18365: URL: https://github.com/apache/incubator-mxnet/pull/18365#issuecomment-632574190 > Adopting the standard `BUILD_SHARED_LIBS` may take additional work to make sure all dependencies + the CI logic correctly handle the result. It would however result into a more "distro-friendly" build you quote, as the dependencies will also be built dynamically. Wow someone circumvent CI :1st_place_medal: > > But to keep things simple in this PR, it's fine to use an MXNet specific setting for now. I modified your PR slightly to reintroduce the MXNet specific option. Thank you very much @leezu ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-mxnet-ci] marcoabreu commented on a change in pull request #26: Update latest build selection and log when one build fails
marcoabreu commented on a change in pull request #26:
URL: https://github.com/apache/incubator-mxnet-ci/pull/26#discussion_r429116101
##
File path: services/jenkins-pipeline-monitor/handler.py
##
@@ -4,12 +4,14 @@
import logging
import secret_manager
+from datetime import datetime, timezone
from jenkinsapi.jenkins import Jenkins
logging.getLogger().setLevel(logging.INFO)
logging.getLogger('boto3').setLevel(logging.CRITICAL)
logging.getLogger('botocore').setLevel(logging.CRITICAL)
+desired_release_job_type = ['mxnet_lib/static', 'python/pypi']
Review comment:
Can you give this a more neutral name?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
