Re: [PR] host/audio: move old LE Audio files to new directory [mynewt-nimble]
KKopyscinski merged PR #1714: URL: https://github.com/apache/mynewt-nimble/pull/1714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] host/audio: move old LE Audio files to new directory [mynewt-nimble]
KKopyscinski commented on code in PR #1714: URL: https://github.com/apache/mynewt-nimble/pull/1714#discussion_r1508759891 ## apps/btshell/pkg.yml: ## @@ -35,6 +35,7 @@ pkg.deps: - nimble/host/services/gatt - nimble/host/store/config - nimble/host/util +- nimble/host/audio Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] host/audio: move old LE Audio files to new directory [mynewt-nimble]
KKopyscinski commented on code in PR #1714: URL: https://github.com/apache/mynewt-nimble/pull/1714#discussion_r1508749892 ## apps/auracast/syscfg.yml: ## @@ -59,4 +59,6 @@ syscfg.vals: BLE_MAX_BIG: 1 BLE_MAX_BIS: 2 -BLE_PHY_NRF52_HEADERMASK_WORKAROUND: 1 \ No newline at end of file +BLE_PHY_NRF52_HEADERMASK_WORKAROUND: 1 Review Comment: I'll remove it then -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] host/audio: move old LE Audio files to new directory [mynewt-nimble]
KKopyscinski commented on code in PR #1714: URL: https://github.com/apache/mynewt-nimble/pull/1714#discussion_r1508745985 ## nimble/host/syscfg.yml: ## @@ -523,6 +514,20 @@ syscfg.defs: description: 'Minimum level for the BLE EATT log.' value: 1 +BLE_MAX_BIG: Review Comment: And BLE_ISO_MAX_BISES -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] host/audio: move old LE Audio files to new directory [mynewt-nimble]
KKopyscinski commented on code in PR #1714: URL: https://github.com/apache/mynewt-nimble/pull/1714#discussion_r1508742482 ## nimble/host/syscfg.yml: ## @@ -523,6 +514,20 @@ syscfg.defs: description: 'Minimum level for the BLE EATT log.' value: 1 +BLE_MAX_BIG: Review Comment: I left ISO in host, so I'll change to that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] host/audio: move old LE Audio files to new directory [mynewt-nimble]
andrzej-kaczmarek commented on code in PR #1714: URL: https://github.com/apache/mynewt-nimble/pull/1714#discussion_r1508720095 ## nimble/host/audio/syscfg.yml: ## @@ -17,5 +17,18 @@ # syscfg.defs: +BLE_MAX_BIG: Review Comment: BLE_AUDIO_MAX_BIGS ## apps/auracast/syscfg.yml: ## @@ -59,4 +59,6 @@ syscfg.vals: BLE_MAX_BIG: 1 BLE_MAX_BIS: 2 -BLE_PHY_NRF52_HEADERMASK_WORKAROUND: 1 \ No newline at end of file +BLE_PHY_NRF52_HEADERMASK_WORKAROUND: 1 Review Comment: this is only required on nrf52 if encryption is enabled ## apps/btshell/pkg.yml: ## @@ -35,6 +35,7 @@ pkg.deps: - nimble/host/services/gatt - nimble/host/store/config - nimble/host/util +- nimble/host/audio Review Comment: dep should be added by package which defines BLE_AUDIO ## nimble/host/syscfg.yml: ## @@ -523,6 +514,20 @@ syscfg.defs: description: 'Minimum level for the BLE EATT log.' value: 1 +BLE_MAX_BIG: Review Comment: BLE_ISO_MAX_BIGS or BLE_AUDIO_MAX_BIGS I think the former makes more sense -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] host/audio: move old LE Audio files to new directory [mynewt-nimble]
KKopyscinski commented on PR #1714: URL: https://github.com/apache/mynewt-nimble/pull/1714#issuecomment-1972823297 @sjanc as discussed offline, this refactor must be single-commit, because apps won't build otherwise -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] host/audio: move old LE Audio files to new directory [mynewt-nimble]
KKopyscinski commented on code in PR #1714: URL: https://github.com/apache/mynewt-nimble/pull/1714#discussion_r1508711952 ## nimble/host/syscfg.yml: ## @@ -440,6 +440,11 @@ syscfg.defs: that have been enabled in the stack, such as GATT support. value: 0 +BLE_AUDIO: +description: 'This option enables Bluetooth LE Audio support' +value: 0 Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] host/audio: move old LE Audio files to new directory [mynewt-nimble]
KKopyscinski commented on code in PR #1714: URL: https://github.com/apache/mynewt-nimble/pull/1714#discussion_r1508708626 ## apps/btshell/src/cmd_leaudio.c: ## @@ -17,13 +17,13 @@ * under the License. */ -#include "host/ble_audio_broadcast_source.h" #include "cmd_leaudio.h" #include "btshell.h" #include "console/console.h" #include "errno.h" -#if (MYNEWT_VAL(BLE_ISO_BROADCAST_SOURCE)) +#if (MYNEWT_VAL(BLE_AUDIO)) +#include "audio/ble_audio_bcst_source.h" Review Comment: Left full `broadcast` in names -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] host/audio: move old LE Audio files to new directory [mynewt-nimble]
KKopyscinski commented on code in PR #1714: URL: https://github.com/apache/mynewt-nimble/pull/1714#discussion_r1508615426 ## apps/btshell/src/cmd_leaudio.c: ## @@ -17,13 +17,13 @@ * under the License. */ -#include "host/ble_audio_broadcast_source.h" #include "cmd_leaudio.h" #include "btshell.h" #include "console/console.h" #include "errno.h" -#if (MYNEWT_VAL(BLE_ISO_BROADCAST_SOURCE)) +#if (MYNEWT_VAL(BLE_AUDIO)) +#include "audio/ble_audio_bcst_source.h" Review Comment: So maybe ble_audio_broadcast_src? and later we'll use snk counterpart -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] host/audio: move old LE Audio files to new directory [mynewt-nimble]
sjanc commented on code in PR #1714: URL: https://github.com/apache/mynewt-nimble/pull/1714#discussion_r1508613063 ## apps/btshell/src/cmd_leaudio.c: ## @@ -17,13 +17,13 @@ * under the License. */ -#include "host/ble_audio_broadcast_source.h" #include "cmd_leaudio.h" #include "btshell.h" #include "console/console.h" #include "errno.h" -#if (MYNEWT_VAL(BLE_ISO_BROADCAST_SOURCE)) +#if (MYNEWT_VAL(BLE_AUDIO)) +#include "audio/ble_audio_bcst_source.h" Review Comment: I'm not very happy with this bcst abbreviation... ## nimble/host/syscfg.yml: ## @@ -440,6 +440,11 @@ syscfg.defs: that have been enabled in the stack, such as GATT support. value: 0 +BLE_AUDIO: +description: 'This option enables Bluetooth LE Audio support' +value: 0 Review Comment: mark this as experimental -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] host/audio: move old LE Audio files to new directory [mynewt-nimble]
KKopyscinski commented on code in PR #1714: URL: https://github.com/apache/mynewt-nimble/pull/1714#discussion_r1507675837 ## apps/btshell/pkg.yml: ## @@ -35,6 +35,7 @@ pkg.deps: - nimble/host/services/gatt - nimble/host/store/config - nimble/host/util +- nimble/host/audio Review Comment: moved to deps of BLE_AUDIO -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] host/audio: move old LE Audio files to new directory [mynewt-nimble]
KKopyscinski commented on code in PR #1714: URL: https://github.com/apache/mynewt-nimble/pull/1714#discussion_r1507670930 ## nimble/host/audio/syscfg.yml: ## @@ -17,5 +17,8 @@ # syscfg.defs: +BLE_AUDIO: +description: 'Indicates that a BLE Audio is present.' Review Comment: Fully agree :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] host/audio: move old LE Audio files to new directory [mynewt-nimble]
MariuszSkamra commented on code in PR #1714: URL: https://github.com/apache/mynewt-nimble/pull/1714#discussion_r1507665393 ## nimble/host/audio/syscfg.yml: ## @@ -17,5 +17,8 @@ # syscfg.defs: +BLE_AUDIO: +description: 'Indicates that a BLE Audio is present.' Review Comment: I'd move this config to `host/syscfg.yml`, similarly where `BLE_MESH` is defined. Plus, I'd suggest to describe this option like: ```suggestion description: 'This option enables Bluetooth LE Audio support.' ``` Otherwise LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] host/audio: move old LE Audio files to new directory [mynewt-nimble]
MariuszSkamra commented on code in PR #1714: URL: https://github.com/apache/mynewt-nimble/pull/1714#discussion_r1507665393 ## nimble/host/audio/syscfg.yml: ## @@ -17,5 +17,8 @@ # syscfg.defs: +BLE_AUDIO: +description: 'Indicates that a BLE Audio is present.' Review Comment: I'd move this config to `host/syscfg.yml`, similarly where `BLE_MESH` is defined. Plus, I'd suggest to describe this option like: ```suggestion description: 'This option enables Bluetooth LE Audio support.' ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] host/audio: move old LE Audio files to new directory [mynewt-nimble]
MariuszSkamra commented on code in PR #1714: URL: https://github.com/apache/mynewt-nimble/pull/1714#discussion_r1507665393 ## nimble/host/audio/syscfg.yml: ## @@ -17,5 +17,8 @@ # syscfg.defs: +BLE_AUDIO: +description: 'Indicates that a BLE Audio is present.' Review Comment: I'd move this config to `host/syscfg.yml`, just like `BLE_MESH` is defined. Plus, I'd suggest to describe this option like: ```suggestion description: 'This option enables Bluetooth LE Audio support.' ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] host/audio: move old LE Audio files to new directory [mynewt-nimble]
MariuszSkamra commented on code in PR #1714: URL: https://github.com/apache/mynewt-nimble/pull/1714#discussion_r1507599864 ## nimble/host/pkg.yml: ## @@ -32,6 +32,9 @@ pkg.deps: - nimble - nimble/transport +pkg.deps.BLE_ISO: +- nimble/host/audio + Review Comment: sounds good to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] host/audio: move old LE Audio files to new directory [mynewt-nimble]
KKopyscinski commented on code in PR #1714: URL: https://github.com/apache/mynewt-nimble/pull/1714#discussion_r1507597483 ## nimble/host/pkg.yml: ## @@ -32,6 +32,9 @@ pkg.deps: - nimble - nimble/transport +pkg.deps.BLE_ISO: +- nimble/host/audio + Review Comment: maybe we should have one common config for audio? I can add one here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] host/audio: move old LE Audio files to new directory [mynewt-nimble]
MariuszSkamra commented on code in PR #1714: URL: https://github.com/apache/mynewt-nimble/pull/1714#discussion_r1507594247 ## apps/btshell/pkg.yml: ## @@ -35,6 +35,7 @@ pkg.deps: - nimble/host/services/gatt - nimble/host/store/config - nimble/host/util +- nimble/host/audio Review Comment: this seems to be ordered, thus I'd place `nimble/host/audio` right after `nimble/host` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] host/audio: move old LE Audio files to new directory [mynewt-nimble]
KKopyscinski commented on PR #1714: URL: https://github.com/apache/mynewt-nimble/pull/1714#issuecomment-1971088580 @MariuszSkamra PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
