[jira] [Updated] (NETBEANS-5914) NetBeans 12.4 freezes on startup
[ https://issues.apache.org/jira/browse/NETBEANS-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jaroslav Tulach updated NETBEANS-5914: -- Fix Version/s: 12.6 > NetBeans 12.4 freezes on startup > > > Key: NETBEANS-5914 > URL: https://issues.apache.org/jira/browse/NETBEANS-5914 > Project: NetBeans > Issue Type: Bug >Affects Versions: 12.5 > Environment: NetBeans 12.4 on Zulu/OpenJDK 11 on Windows 10. >Reporter: Eirik Bakke >Assignee: Jaroslav Tulach >Priority: Blocker > Fix For: 12.6 > > Attachments: 12.5-beta2-threaddump-1629986898821.tdump, 210506 > NetBeans Deadlock on Startup 2.txt, 210506 NetBeans Deadlock on Startup.txt, > 210516 Another NetBeans Deadlock.txt, 210526 NetBeans Deadlock again.txt > > > On NetBeans 12.4, I was previously experiencing some intermittent freezes on > startup, at the time when projects were being loaded and such. I did some > thread dumps of the frozen IDE using VisualVM. I'm uploading these now in > case they are related to NETBEANS-5913. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5914) NetBeans 12.4 freezes on startup
[ https://issues.apache.org/jira/browse/NETBEANS-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17405585#comment-17405585 ] Jaroslav Tulach commented on NETBEANS-5914: --- Right. While the deadlock is unfortunate, it is not a regression in 12.5. If people could live it so far, they will be able to live with it one more release. > NetBeans 12.4 freezes on startup > > > Key: NETBEANS-5914 > URL: https://issues.apache.org/jira/browse/NETBEANS-5914 > Project: NetBeans > Issue Type: Bug >Affects Versions: 12.5 > Environment: NetBeans 12.4 on Zulu/OpenJDK 11 on Windows 10. >Reporter: Eirik Bakke >Assignee: Jaroslav Tulach >Priority: Blocker > Attachments: 12.5-beta2-threaddump-1629986898821.tdump, 210506 > NetBeans Deadlock on Startup 2.txt, 210506 NetBeans Deadlock on Startup.txt, > 210516 Another NetBeans Deadlock.txt, 210526 NetBeans Deadlock again.txt > > > On NetBeans 12.4, I was previously experiencing some intermittent freezes on > startup, at the time when projects were being loaded and such. I did some > thread dumps of the frozen IDE using VisualVM. I'm uploading these now in > case they are related to NETBEANS-5913. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5949) remote debugger does not work
[ https://issues.apache.org/jira/browse/NETBEANS-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17405493#comment-17405493 ] pat commented on NETBEANS-5949: --- I went down the path to figure out what all was necessary to make remote debugging work. The scriptdef target in remote-platform-impl.xml needs to look something like below. Of course the paths to the jar files need to match where they are installed. And HelloWorld.properties needs to have the following line added. The debug-args-line needs to be defined but can be empty. debug-args-line= An then the debugger can launch and debug the application on the remote host. > remote debugger does not work > -- > > Key: NETBEANS-5949 > URL: https://issues.apache.org/jira/browse/NETBEANS-5949 > Project: NetBeans > Issue Type: Bug > Components: debugger - Java, projects - Ant >Affects Versions: 12.4 > Environment: Host is Windows 10, Netbeans 12.4 > Remote Host is raspberry pi with java 11.0.12. >Reporter: pat >Priority: Major > > Create a java application project. > Add this code to main and fix the imports >public static void main(String[] args) { > try { > InetAddress id = InetAddress.getLocalHost(); > System.out.println(id.getHostName()); > System.out.println("java version is " + > System.getProperty("java.version")); > System.out.println("VM is " + > > ManagementFactory.getRuntimeMXBean().getVmVersion()); > } catch (UnknownHostException ex) { > Logger.getLogger(HelloWorld.class.getName()).log(Level.SEVERE, > null, ex); > } > } > Run natively to verify you got it right. > Follow the instructions here to create a remote java standard edition > platform targeting a different Linux computer. My computer is a raspberry > pi with java 11 installed, Oracle Java SE 8 Embedded is no longer available > for most people but java 11 works fine. (The bug is independent of java > version on the target). > https://netbeans.apache.org/kb/docs/java/javase-embedded.html?print=yes > Select the remote platform you created and run the program. The output > should show that it ran on the remote host. > Now debug the program.I get the following error. > ant -f C:\\Users\\PATGI\\OneDrive\\Documents\\NetBeansProjects\\HelloWorld > -Dnb.internal.action.name=debug -Dremote.platform.passphrase=* > -Dremote.platform.rp.target=linuxarm-15 > -Dremote.platform.rp.filename=linuxarm -Ddebug.class=helloworld.HelloWorld > -Dremote.platform.java.spec.ver=11 debug-remote > init: > deps-jar: > Updating property file: > C:\Users\PATGI\OneDrive\Documents\NetBeansProjects\HelloWorld\build\built-jar.properties > compile: > Copying 1 file to > C:\Users\PATGI\OneDrive\Documents\NetBeansProjects\HelloWorld\build > Nothing to copy. > To run this application from the command line without Ant, try: > java -jar > "C:\Users\PATGI\OneDrive\Documents\NetBeansProjects\HelloWorld\dist\HelloWorld.jar" > deploy: > jar: > C:\Users\PATGI\OneDrive\Documents\NetBeansProjects\HelloWorld\nbproject\remote-platform-impl.xml:143: > Unable to create javax script engine for javascript > BUILD FAILED (total time: 0 seconds) > I was able to for the debugger to work by manually starting the debugger on > the remote host with something like > /usr/bin/java > -agentlib:jdwp=transport=dt_socket,address=*:8000,suspend=y,server=y > -Dfile.encoding=UTF-8 -jar > /home/pi/NetBeansProjects/HelloWorld/dist/HelloWorld.jar > And then connect the debugger to a process already running on the remote host > at port 8000. > I traced this back to javascript not being supported in this installation of > Ant. I also think several of the configuration variables for remote > debugging are not setup. e.g. jdpa.address and jdpa.port but I could easily > be wrong about this. > The good news is it can be made to work and it is very nice when it is > working. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5914) NetBeans 12.4 freezes on startup
[ https://issues.apache.org/jira/browse/NETBEANS-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17405369#comment-17405369 ] Neil C Smith commented on NETBEANS-5914: Thanks [~ebakke] That's expected, although good to know it's that infrequent for you. There's nothing in 12.5 related to this issue - fix was for NETBEANS-5913. > NetBeans 12.4 freezes on startup > > > Key: NETBEANS-5914 > URL: https://issues.apache.org/jira/browse/NETBEANS-5914 > Project: NetBeans > Issue Type: Bug >Affects Versions: 12.5 > Environment: NetBeans 12.4 on Zulu/OpenJDK 11 on Windows 10. >Reporter: Eirik Bakke >Assignee: Jaroslav Tulach >Priority: Blocker > Attachments: 12.5-beta2-threaddump-1629986898821.tdump, 210506 > NetBeans Deadlock on Startup 2.txt, 210506 NetBeans Deadlock on Startup.txt, > 210516 Another NetBeans Deadlock.txt, 210526 NetBeans Deadlock again.txt > > > On NetBeans 12.4, I was previously experiencing some intermittent freezes on > startup, at the time when projects were being loaded and such. I did some > thread dumps of the frozen IDE using VisualVM. I'm uploading these now in > case they are related to NETBEANS-5913. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Comment Edited] (NETBEANS-5914) NetBeans 12.4 freezes on startup
[ https://issues.apache.org/jira/browse/NETBEANS-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17405356#comment-17405356 ] Eirik Bakke edited comment on NETBEANS-5914 at 8/26/21, 4:43 PM: - It's not an issue I can reproduce on demand, unfortunately, and I haven't seen it occur for several months. There were about 20 Maven-based NetBeans module projects open, and the deadlock would occur on IDE startup (rather than while building the projects). Was there a patch in 12.5 already with regards to this bug? If my IDE enters a state again where it becomes possible to trigger the deadlock by restarting, I can try with and without a patch. Otherwise I think the only way to "confirm" solutions to these kinds of bugs is to stare hard at the original thread dump and the resulting patch... was (Author: ebakke): It's not an issue I can reproduce on demand, unfortunately, and I haven't seen it occur for several months. There were about 20 Maven-based NetBeans module projects open, and the deadlock would occur on IDE startup. Was there a patch in 12.5 already with regards to this bug? If my IDE enters a state again where it becomes possible to trigger the deadlock by restarting, I can try with and without a patch. Otherwise I think the only way to "confirm" solutions to these kinds of bugs is to stare hard at the original thread dump and the resulting patch... > NetBeans 12.4 freezes on startup > > > Key: NETBEANS-5914 > URL: https://issues.apache.org/jira/browse/NETBEANS-5914 > Project: NetBeans > Issue Type: Bug >Affects Versions: 12.5 > Environment: NetBeans 12.4 on Zulu/OpenJDK 11 on Windows 10. >Reporter: Eirik Bakke >Assignee: Jaroslav Tulach >Priority: Blocker > Attachments: 12.5-beta2-threaddump-1629986898821.tdump, 210506 > NetBeans Deadlock on Startup 2.txt, 210506 NetBeans Deadlock on Startup.txt, > 210516 Another NetBeans Deadlock.txt, 210526 NetBeans Deadlock again.txt > > > On NetBeans 12.4, I was previously experiencing some intermittent freezes on > startup, at the time when projects were being loaded and such. I did some > thread dumps of the frozen IDE using VisualVM. I'm uploading these now in > case they are related to NETBEANS-5913. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5914) NetBeans 12.4 freezes on startup
[ https://issues.apache.org/jira/browse/NETBEANS-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17405356#comment-17405356 ] Eirik Bakke commented on NETBEANS-5914: --- It's not an issue I can reproduce on demand, unfortunately, and I haven't seen it occur for several months. There were about 20 Maven-based NetBeans module projects open, and the deadlock would occur on IDE startup. Was there a patch in 12.5 already with regards to this bug? If my IDE enters a state again where it becomes possible to trigger the deadlock by restarting, I can try with and without a patch. Otherwise I think the only way to "confirm" solutions to these kinds of bugs is to stare hard at the original thread dump and the resulting patch... > NetBeans 12.4 freezes on startup > > > Key: NETBEANS-5914 > URL: https://issues.apache.org/jira/browse/NETBEANS-5914 > Project: NetBeans > Issue Type: Bug >Affects Versions: 12.5 > Environment: NetBeans 12.4 on Zulu/OpenJDK 11 on Windows 10. >Reporter: Eirik Bakke >Assignee: Jaroslav Tulach >Priority: Blocker > Attachments: 12.5-beta2-threaddump-1629986898821.tdump, 210506 > NetBeans Deadlock on Startup 2.txt, 210506 NetBeans Deadlock on Startup.txt, > 210516 Another NetBeans Deadlock.txt, 210526 NetBeans Deadlock again.txt > > > On NetBeans 12.4, I was previously experiencing some intermittent freezes on > startup, at the time when projects were being loaded and such. I did some > thread dumps of the frozen IDE using VisualVM. I'm uploading these now in > case they are related to NETBEANS-5913. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-5914) NetBeans 12.4 freezes on startup
[ https://issues.apache.org/jira/browse/NETBEANS-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neil C Smith updated NETBEANS-5914: --- Affects Version/s: 12.5 > NetBeans 12.4 freezes on startup > > > Key: NETBEANS-5914 > URL: https://issues.apache.org/jira/browse/NETBEANS-5914 > Project: NetBeans > Issue Type: Bug >Affects Versions: 12.5 > Environment: NetBeans 12.4 on Zulu/OpenJDK 11 on Windows 10. >Reporter: Eirik Bakke >Assignee: Jaroslav Tulach >Priority: Blocker > Attachments: 12.5-beta2-threaddump-1629986898821.tdump, 210506 > NetBeans Deadlock on Startup 2.txt, 210506 NetBeans Deadlock on Startup.txt, > 210516 Another NetBeans Deadlock.txt, 210526 NetBeans Deadlock again.txt > > > On NetBeans 12.4, I was previously experiencing some intermittent freezes on > startup, at the time when projects were being loaded and such. I did some > thread dumps of the frozen IDE using VisualVM. I'm uploading these now in > case they are related to NETBEANS-5913. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-5914) NetBeans 12.4 freezes on startup
[ https://issues.apache.org/jira/browse/NETBEANS-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neil C Smith updated NETBEANS-5914: --- Priority: Blocker (was: Major) > NetBeans 12.4 freezes on startup > > > Key: NETBEANS-5914 > URL: https://issues.apache.org/jira/browse/NETBEANS-5914 > Project: NetBeans > Issue Type: Bug > Environment: NetBeans 12.4 on Zulu/OpenJDK 11 on Windows 10. >Reporter: Eirik Bakke >Assignee: Jaroslav Tulach >Priority: Blocker > Attachments: 12.5-beta2-threaddump-1629986898821.tdump, 210506 > NetBeans Deadlock on Startup 2.txt, 210506 NetBeans Deadlock on Startup.txt, > 210516 Another NetBeans Deadlock.txt, 210526 NetBeans Deadlock again.txt > > > On NetBeans 12.4, I was previously experiencing some intermittent freezes on > startup, at the time when projects were being loaded and such. I did some > thread dumps of the frozen IDE using VisualVM. I'm uploading these now in > case they are related to NETBEANS-5913. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-5914) NetBeans 12.4 freezes on startup
[ https://issues.apache.org/jira/browse/NETBEANS-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Kellerer updated NETBEANS-5914: -- Attachment: 12.5-beta2-threaddump-1629986898821.tdump > NetBeans 12.4 freezes on startup > > > Key: NETBEANS-5914 > URL: https://issues.apache.org/jira/browse/NETBEANS-5914 > Project: NetBeans > Issue Type: Bug > Environment: NetBeans 12.4 on Zulu/OpenJDK 11 on Windows 10. >Reporter: Eirik Bakke >Assignee: Jaroslav Tulach >Priority: Major > Attachments: 12.5-beta2-threaddump-1629986898821.tdump, 210506 > NetBeans Deadlock on Startup 2.txt, 210506 NetBeans Deadlock on Startup.txt, > 210516 Another NetBeans Deadlock.txt, 210526 NetBeans Deadlock again.txt > > > On NetBeans 12.4, I was previously experiencing some intermittent freezes on > startup, at the time when projects were being loaded and such. I did some > thread dumps of the frozen IDE using VisualVM. I'm uploading these now in > case they are related to NETBEANS-5913. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Closed] (NETBEANS-5950) cleanup warnings related to unreachable exception catches
[ https://issues.apache.org/jira/browse/NETBEANS-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brad Walker closed NETBEANS-5950. - Resolution: Fixed fixed and integrated.. > cleanup warnings related to unreachable exception catches > - > > Key: NETBEANS-5950 > URL: https://issues.apache.org/jira/browse/NETBEANS-5950 > Project: NetBeans > Issue Type: Improvement >Reporter: Brad Walker >Assignee: Brad Walker >Priority: Minor > Labels: pull-request-available > Fix For: 12.6 > > Time Spent: 50m > Remaining Estimate: 0h > > The java compiler knows explicitly what exceptions are thrown when compiling > code. > This change removes all the warnings related to "{code:java}warning: > unreachable catch clause{code}" > For example: > {code:java} >[repeat] > /home/bwalker/src/netbeans/enterprise/web.struts/src/org/netbeans/modules/web/struts/StrutsConfigDataObject.java:297: > warning: unreachable catch clause >[repeat] } catch(SAXException ex) { >[repeat] ^ >[repeat] thrown type SAXParseException has already been caught > {code} > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[netbeans] branch master updated: [NETBEANS-5950] - cleanup warnings related to unreachable exception catches (#3126)
This is an automated email from the ASF dual-hosted git repository. bwalker pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git The following commit(s) were added to refs/heads/master by this push: new 4679faa [NETBEANS-5950] - cleanup warnings related to unreachable exception catches (#3126) 4679faa is described below commit 4679faadde45cb11d7ce30f05b9c2832de67adcc Author: Brad Walker AuthorDate: Thu Aug 26 07:57:45 2021 -0600 [NETBEANS-5950] - cleanup warnings related to unreachable exception catches (#3126) The java compiler knows explicitly what exceptions are thrown when compiling code. This change removes all the warnings related to "warning: unreachable catch clause" For example: [repeat] /home/bwalker/src/netbeans/enterprise/web.struts/src/org/netbeans/modules/web/struts/StrutsConfigDataObject.java:297: warning: unreachable catch clause [repeat] } catch(SAXException ex) { [repeat] ^ [repeat] thrown type SAXParseException has already been caught --- .../src/org/netbeans/modules/j2ee/sun/share/plan/Util.java | 2 -- .../org/netbeans/modules/web/refactoring/PositionBoundsResolver.java | 2 -- .../src/org/netbeans/modules/web/struts/StrutsConfigDataObject.java | 5 + ide/parsing.nb/src/org/netbeans/modules/parsing/nb/EventSupport.java | 3 --- ide/utilities/src/org/netbeans/modules/url/URLDataObject.java| 3 --- .../modules/j2ee/jpa/refactoring/util/PositionBoundsResolver.java| 2 -- .../modules/java/j2seplatform/libraries/J2SEVolumeCustomizer.java| 2 -- .../org/netbeans/modules/java/platform/ui/PlatformsCustomizer.java | 3 --- .../netbeans/modules/php/codeception/coverage/CoverageProvider.java | 3 --- 9 files changed, 1 insertion(+), 24 deletions(-) diff --git a/enterprise/j2ee.sun.ddui/src/org/netbeans/modules/j2ee/sun/share/plan/Util.java b/enterprise/j2ee.sun.ddui/src/org/netbeans/modules/j2ee/sun/share/plan/Util.java index d9d6ed1..addae36 100644 --- a/enterprise/j2ee.sun.ddui/src/org/netbeans/modules/j2ee/sun/share/plan/Util.java +++ b/enterprise/j2ee.sun.ddui/src/org/netbeans/modules/j2ee/sun/share/plan/Util.java @@ -85,8 +85,6 @@ public class Util { dp.addFileEntry(fe); } catch(DDException ex) { giveUp(ex); -} catch (org.netbeans.modules.schema2beans.Schema2BeansException s2bX) { -giveUp(s2bX); } catch (java.beans.PropertyVetoException pv) { giveUp(pv); } diff --git a/enterprise/web.refactoring/src/org/netbeans/modules/web/refactoring/PositionBoundsResolver.java b/enterprise/web.refactoring/src/org/netbeans/modules/web/refactoring/PositionBoundsResolver.java index 290b045..07a4ce9 100644 --- a/enterprise/web.refactoring/src/org/netbeans/modules/web/refactoring/PositionBoundsResolver.java +++ b/enterprise/web.refactoring/src/org/netbeans/modules/web/refactoring/PositionBoundsResolver.java @@ -155,8 +155,6 @@ public class PositionBoundsResolver { Exceptions.printStackTrace(ex); } catch (FileNotFoundException ex) { Exceptions.printStackTrace(ex); -} catch (IOException ex) { -Exceptions.printStackTrace(ex); } catch (BadLocationException ex) { Exceptions.printStackTrace(ex); } diff --git a/enterprise/web.struts/src/org/netbeans/modules/web/struts/StrutsConfigDataObject.java b/enterprise/web.struts/src/org/netbeans/modules/web/struts/StrutsConfigDataObject.java index 01b1003..302ded7 100644 --- a/enterprise/web.struts/src/org/netbeans/modules/web/struts/StrutsConfigDataObject.java +++ b/enterprise/web.struts/src/org/netbeans/modules/web/struts/StrutsConfigDataObject.java @@ -291,11 +291,8 @@ public class StrutsConfigDataObject extends MultiDataObject try { Document doc = getDomDocument(is); lastGoodConfig = StrutsConfig.createGraph(doc); -} -catch(SAXParseException ex) { +} catch(SAXParseException ex) { return new SAXParseError(ex); -} catch(SAXException ex) { -throw new IOException(); } return null; } diff --git a/ide/parsing.nb/src/org/netbeans/modules/parsing/nb/EventSupport.java b/ide/parsing.nb/src/org/netbeans/modules/parsing/nb/EventSupport.java index fbc3164..4163e25 100644 --- a/ide/parsing.nb/src/org/netbeans/modules/parsing/nb/EventSupport.java +++ b/ide/parsing.nb/src/org/netbeans/modules/parsing/nb/EventSupport.java @@ -289,9 +289,6 @@ final class EventSupport extends SourceEnvironment { resetState(true, false, -1, -1, false); } catch (DataObjectNotFoundException e) { //Ignore - invalidated after fobj.isValid () was called -} catch (IOException ex) { -
[netbeans] branch master updated: LSP: Move refactoring added. (#3123)
This is an automated email from the ASF dual-hosted git repository. dbalek pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git The following commit(s) were added to refs/heads/master by this push: new bd2d92c LSP: Move refactoring added. (#3123) bd2d92c is described below commit bd2d92c51a3ec43c41820ef1214ea21105c550fb Author: Dusan Balek AuthorDate: Thu Aug 26 09:41:14 2021 +0200 LSP: Move refactoring added. (#3123) * LSP: Move refactoring added. * LSP: Rename refactoring modifies originating file only - fixed. --- .../refactoring/plugins/FileMovePlugin.java| 2 +- .../java/hints/introduce/FieldValidator.java | 30 +- .../java/hints/introduce/IntroduceConstantFix.java | 15 +- .../IntroduceExpressionBasedMethodFix.java | 21 +- .../java/hints/introduce/IntroduceFieldFix.java| 32 +- .../java/hints/introduce/IntroduceFixBase.java | 12 +- .../java/hints/introduce/IntroduceHint.java| 25 +- .../java/hints/introduce/IntroduceMethodFix.java | 25 +- .../java/hints/introduce/IntroduceVariableFix.java | 22 +- .../java/hints/introduce/MethodValidator.java | 21 +- ...CodeGenerator.java => CodeActionsProvider.java} | 35 +- .../lsp/server/protocol/ConstructorGenerator.java | 14 +- .../server/protocol/DelegateMethodGenerator.java | 14 +- .../server/protocol/EqualsHashCodeGenerator.java | 14 +- .../lsp/server/protocol/GetterSetterGenerator.java | 13 +- .../protocol/ImplementOverrideMethodGenerator.java | 14 +- .../java/lsp/server/protocol/LoggerGenerator.java | 14 +- .../java/lsp/server/protocol/MoveRefactoring.java | 373 +++ .../modules/java/lsp/server/protocol/Server.java | 8 +- .../server/protocol/TextDocumentServiceImpl.java | 96 ++--- .../lsp/server/protocol/ToStringGenerator.java | 14 +- .../lsp/server/protocol/WorkspaceServiceImpl.java | 6 +- .../java/lsp/server/protocol/ServerTest.java | 410 - .../java/plugins/MoveFileRefactoringPlugin.java| 1 + 24 files changed, 1034 insertions(+), 197 deletions(-) diff --git a/ide/refactoring.api/src/org/netbeans/modules/refactoring/plugins/FileMovePlugin.java b/ide/refactoring.api/src/org/netbeans/modules/refactoring/plugins/FileMovePlugin.java index 610c414..578ed02 100644 --- a/ide/refactoring.api/src/org/netbeans/modules/refactoring/plugins/FileMovePlugin.java +++ b/ide/refactoring.api/src/org/netbeans/modules/refactoring/plugins/FileMovePlugin.java @@ -80,7 +80,7 @@ public class FileMovePlugin implements RefactoringPlugin { public void cancelRequest() { } -private class MoveFile extends SimpleRefactoringElementImplementation { +public class MoveFile extends SimpleRefactoringElementImplementation { private FileObject fo; public MoveFile(FileObject fo, RefactoringElementsBag session) { diff --git a/java/java.hints/src/org/netbeans/modules/java/hints/introduce/FieldValidator.java b/java/java.hints/src/org/netbeans/modules/java/hints/introduce/FieldValidator.java index 4b2a630..c94c0ab 100644 --- a/java/java.hints/src/org/netbeans/modules/java/hints/introduce/FieldValidator.java +++ b/java/java.hints/src/org/netbeans/modules/java/hints/introduce/FieldValidator.java @@ -25,10 +25,9 @@ import com.sun.source.tree.Tree; import com.sun.source.tree.TryTree; import com.sun.source.tree.VariableTree; import com.sun.source.util.TreePath; -import java.io.IOException; +import java.util.Collections; import java.util.Map; import javax.lang.model.element.Element; -import javax.lang.model.element.ElementKind; import javax.lang.model.element.TypeElement; import javax.lang.model.type.DeclaredType; import javax.lang.model.type.TypeMirror; @@ -37,16 +36,20 @@ import org.netbeans.api.java.source.CompilationInfo; import org.netbeans.api.java.source.ElementHandle; import org.netbeans.api.java.source.ElementUtilities.ElementAcceptor; import org.netbeans.api.java.source.JavaSource; -import org.netbeans.api.java.source.Task; import org.netbeans.api.java.source.TreePathHandle; import org.netbeans.api.java.source.TypeMirrorHandle; +import org.netbeans.modules.parsing.api.ParserManager; +import org.netbeans.modules.parsing.api.ResultIterator; +import org.netbeans.modules.parsing.api.Source; +import org.netbeans.modules.parsing.api.UserTask; +import org.netbeans.modules.parsing.spi.ParseException; /** * * @author sdedic */ final class FieldValidator implements MemberValidator { -private final JavaSourcetheSource; +private final SourcetheSource; private final TypeMirrorHandle fieldTypeHandle; private final TreePathHandlesrcHandle; @@ -54,7 +57,7 @@ final class FieldValidator implements MemberValidator { private ElementHandle target; private MemberSearchResult lastResult; -public FieldValidator(JavaSource theSource,
[netbeans] branch master updated: LSP: Find tests on initial scan. (#3093)
This is an automated email from the ASF dual-hosted git repository. dbalek pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/netbeans.git The following commit(s) were added to refs/heads/master by this push: new 16a48da LSP: Find tests on initial scan. (#3093) 16a48da is described below commit 16a48da097a251638483fbc33699bea0f73d8da2 Author: Dusan Balek AuthorDate: Thu Aug 26 09:39:27 2021 +0200 LSP: Find tests on initial scan. (#3093) --- .../groovy/editor/api/parser/GroovyParser.java | 5 +- .../editor/compiler/ParsingCompilerCustomizer.java | 9 +- ide/gsf.testrunner.ui/apichanges.xml | 12 ++ ide/gsf.testrunner.ui/manifest.mf | 2 - ide/gsf.testrunner.ui/nbproject/project.properties | 1 + ide/gsf.testrunner.ui/nbproject/project.xml| 2 +- .../gsf/testrunner/ui/TestMethodFinderImpl.java| 154 + .../gsf/testrunner/ui/api/TestMethodFinder.java| 118 .../parsing/impl/indexing/RepositoryUpdater.java | 19 ++- java/java.lsp.server/nbproject/project.xml | 2 +- .../server/protocol/TextDocumentServiceImpl.java | 39 +- .../lsp/server/protocol/WorkspaceServiceImpl.java | 110 +++ 12 files changed, 370 insertions(+), 103 deletions(-) diff --git a/groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/api/parser/GroovyParser.java b/groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/api/parser/GroovyParser.java index fee5c7f..40860f8 100644 --- a/groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/api/parser/GroovyParser.java +++ b/groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/api/parser/GroovyParser.java @@ -829,7 +829,10 @@ public class GroovyParser extends Parser { } void setIndexingTask(Task t) { -this.parserTask = parserTask; +this.parserTask = t; +if (customizerCtx != null) { +customizerCtx.setConsumerTask(t); +} } @Override diff --git a/groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/compiler/ParsingCompilerCustomizer.java b/groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/compiler/ParsingCompilerCustomizer.java index 046272f..0e3d405 100644 --- a/groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/compiler/ParsingCompilerCustomizer.java +++ b/groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/compiler/ParsingCompilerCustomizer.java @@ -61,7 +61,7 @@ public interface ParsingCompilerCustomizer { */ public final class Context { private final Snapshot snapshot; -private final Task consumerTask; +private Task consumerTask; /** * Constructs the context. @@ -90,5 +90,12 @@ public interface ParsingCompilerCustomizer { public Task getConsumerTask() { return consumerTask; } + +/** + * Sets the task that is about to consume the parser's results. + */ +public void setConsumerTask(Task consumerTask) { +this.consumerTask = consumerTask; +} } } diff --git a/ide/gsf.testrunner.ui/apichanges.xml b/ide/gsf.testrunner.ui/apichanges.xml index 2d3d18c..19ba911 100644 --- a/ide/gsf.testrunner.ui/apichanges.xml +++ b/ide/gsf.testrunner.ui/apichanges.xml @@ -52,6 +52,18 @@ + + +Added FindTestMethods API + + + + + +Added API to provide a list of TestMethods found in sources under particutlar test roots. + + + Added ComputeTestMethods SPI and getTestClassPosition() to TestMethod diff --git a/ide/gsf.testrunner.ui/manifest.mf b/ide/gsf.testrunner.ui/manifest.mf index 741896d..6df6ce7 100644 --- a/ide/gsf.testrunner.ui/manifest.mf +++ b/ide/gsf.testrunner.ui/manifest.mf @@ -2,5 +2,3 @@ Manifest-Version: 1.0 OpenIDE-Module: org.netbeans.modules.gsf.testrunner.ui OpenIDE-Module-Layer: org/netbeans/modules/gsf/testrunner/ui/layer.xml OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/gsf/testrunner/ui/Bundle.properties -OpenIDE-Module-Specification-Version: 1.26 - diff --git a/ide/gsf.testrunner.ui/nbproject/project.properties b/ide/gsf.testrunner.ui/nbproject/project.properties index 9c1cd1c..d664921 100644 --- a/ide/gsf.testrunner.ui/nbproject/project.properties +++ b/ide/gsf.testrunner.ui/nbproject/project.properties @@ -18,3 +18,4 @@ is.eager=true javac.source=1.8 javac.compilerargs=-Xlint -Xlint:-serial javadoc.apichanges=${basedir}/apichanges.xml +spec.version.base=1.27 diff --git a/ide/gsf.testrunner.ui/nbproject/project.xml b/ide/gsf.testrunner.ui/nbproject/project.xml index e7ccc9f..63ffee1 100644 --- a/ide/gsf.testrunner.ui/nbproject/project.xml +++ b/ide/gsf.testrunner.ui/nbproject/project.xml @@ -136,7 +136,7 @@
[jira] [Resolved] (NETBEANS-5526) New Java project for NBLS over LSP for Maven and Gradle
[ https://issues.apache.org/jira/browse/NETBEANS-5526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jaroslav Tulach resolved NETBEANS-5526. --- Fix Version/s: (was: Next) 12.5 Resolution: Fixed https://github.com/apache/netbeans/pull/3084 https://github.com/apache/netbeans/pull/2999 > New Java project for NBLS over LSP for Maven and Gradle > --- > > Key: NETBEANS-5526 > URL: https://issues.apache.org/jira/browse/NETBEANS-5526 > Project: NetBeans > Issue Type: New Feature > Components: vscode >Affects Versions: 12.4 >Reporter: Martin Balin >Assignee: Jaroslav Tulach >Priority: Major > Labels: Gradle, maven > Fix For: 12.5 > > > VSNetBeans is missing an easy way to create a New Java project. This is > really missing and I personally switch to NetBeans to jump start new project > so pom.xml... is created for me as well as main Java class. > To really enable Java development in VSCode we need to provide this > functionality. Otherwise it is missing the _Start of Java journey_ for > ordinary developer. > It will be good if connect this to NBLS project support and enable > Maven+Gradle projects there. Wizard should be invoked from Command Palette > and will likely consists of several steps for simplest project types. > For the start we can support just some simple projects. > Original idea was to get pom.xml with main Java class set for execution, jar > packaging and listing main class for jar execution in Manifest.mf... -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Resolved] (NETBEANS-5159) Select proper JDK for mx project
[ https://issues.apache.org/jira/browse/NETBEANS-5159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jaroslav Tulach resolved NETBEANS-5159. --- Fix Version/s: 12.5 Resolution: Fixed Fixed by https://github.com/apache/netbeans/pull/3071 > Select proper JDK for mx project > > > Key: NETBEANS-5159 > URL: https://issues.apache.org/jira/browse/NETBEANS-5159 > Project: NetBeans > Issue Type: New Feature > Components: java - Project >Affects Versions: 12.3 >Reporter: Jaroslav Tulach >Assignee: Jaroslav Tulach >Priority: Major > Fix For: 12.5 > > > "mx project support" as developed in > [PR-2575|https://github.com/apache/netbeans/pull/2575] should be able to > properly select the right JDK for each "javaCompliance" level. Various > {{EXTRA_JAVA_HOMES}} can be specified in {{mx}}'s {{env}} files and the right > JDK should be used for each source root. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Assigned] (NETBEANS-5159) Select proper JDK for mx project
[ https://issues.apache.org/jira/browse/NETBEANS-5159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jaroslav Tulach reassigned NETBEANS-5159: - Assignee: Jaroslav Tulach > Select proper JDK for mx project > > > Key: NETBEANS-5159 > URL: https://issues.apache.org/jira/browse/NETBEANS-5159 > Project: NetBeans > Issue Type: New Feature > Components: java - Project >Affects Versions: 12.3 >Reporter: Jaroslav Tulach >Assignee: Jaroslav Tulach >Priority: Major > > "mx project support" as developed in > [PR-2575|https://github.com/apache/netbeans/pull/2575] should be able to > properly select the right JDK for each "javaCompliance" level. Various > {{EXTRA_JAVA_HOMES}} can be specified in {{mx}}'s {{env}} files and the right > JDK should be used for each source root. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Updated] (NETBEANS-5215) Progress API use-cases aren't valid
[ https://issues.apache.org/jira/browse/NETBEANS-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jaroslav Tulach updated NETBEANS-5215: -- Description: Looking at [https://bits.netbeans.org/11.1/javadoc/org-netbeans-api-progress/overview-summary.html] I see that the documentation hasn't been properly updated to reflect the split of Progress API and Progress Swing API. For example: {code:java} ProgressHandle handle = ProgressHandleFactory.creatHandle("My custom task"); {code} there is a typo (consider using @codesnippet tag, at least in documentation inside of classes). Moreover the {{ProgressHandleFactory}} isn't even in the Progress API! Various other apichanges entries like {{showProgressDialogAndRun}} are also out of scope and belong to Progress Swing API. was: Looking at [https://bits.netbeans.org/11.1/javadoc/org-netbeans-api-progress/overview-summary.html] I see that the documentation hasn't been properly updated to reflect the split of Progress API and Progress Swing API. For example: {code:java} ProgressHandle handle = ProgressHandleFactory.creatHandle("My custom task"); {code} there is a typo (consider using @codesnippet tag, at least in documentation inside of classes). Moreover the {{ProgressHandleFactory}} isn't even in the Progress API! Various other apichanges entries like showProgressDialogAndRun are also out of scope and belong to Progress Swing API. > Progress API use-cases aren't valid > --- > > Key: NETBEANS-5215 > URL: https://issues.apache.org/jira/browse/NETBEANS-5215 > Project: NetBeans > Issue Type: Bug > Components: platform - Progress >Affects Versions: 11.1 >Reporter: Jaroslav Tulach >Assignee: Svatopluk Dedic >Priority: Minor > Labels: sd-candidate > > Looking at > [https://bits.netbeans.org/11.1/javadoc/org-netbeans-api-progress/overview-summary.html] > I see that the documentation hasn't been properly updated to reflect the > split of Progress API and Progress Swing API. For example: > {code:java} > ProgressHandle handle = ProgressHandleFactory.creatHandle("My custom task"); > {code} > there is a typo (consider using @codesnippet tag, at least in documentation > inside of classes). Moreover the {{ProgressHandleFactory}} isn't even in the > Progress API! > Various other apichanges entries like {{showProgressDialogAndRun}} are also > out of scope and belong to Progress Swing API. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Commented] (NETBEANS-5339) Let's NetBeans Java Support work with --release X flag
[ https://issues.apache.org/jira/browse/NETBEANS-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17404976#comment-17404976 ] Jaroslav Tulach commented on NETBEANS-5339: --- There is an attempt to reuse profiles support for releases: [https://github.com/apache/netbeans/pull/2786] - however it is far from being finished. > Let's NetBeans Java Support work with --release X flag > -- > > Key: NETBEANS-5339 > URL: https://issues.apache.org/jira/browse/NETBEANS-5339 > Project: NetBeans > Issue Type: Improvement > Components: java - Source >Affects Versions: 12.0 >Reporter: Jaroslav Tulach >Assignee: Jan Lahoda >Priority: Critical > > Since JDK9 there is {{-release}} flag which can specify which JDK API one > wishes to compile against. Time to use it in NetBeans! > Historically NetBeans Java support tries to detect a JDK one is running on > and decrease the requested {{--source}} level to the supported JDK. This is > very annoying and in the context of {{--release}} flag, unnecessary. > Modern {{javac}} compiler have snapshot JDK API for each version since JDK7 > to the latest JDK. Regardless on which version the NetBeans IDE is running, > people should be able to select the right release/target JDK and get errors > according to its API. > By default a specified {{--source}} (by a SourceVersionQuery) should also > imply appropriate {{--release}}. There might be other means how to control > both source as well as release. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[jira] [Resolved] (NETBEANS-5802) Gradle project wizard should use gradle init
[ https://issues.apache.org/jira/browse/NETBEANS-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jaroslav Tulach resolved NETBEANS-5802. --- Fix Version/s: 12.6 Resolution: Fixed Fixed in https://github.com/apache/netbeans/pull/3084 > Gradle project wizard should use gradle init > > > Key: NETBEANS-5802 > URL: https://issues.apache.org/jira/browse/NETBEANS-5802 > Project: NetBeans > Issue Type: Improvement > Components: projects - Gradle >Affects Versions: 12.3 >Reporter: Jaroslav Tulach >Assignee: Laszlo Kishalmi >Priority: Major > Fix For: 12.6 > > > Hello Laszlo. As soon as I implemented the [VSCode project > wizard|https://github.com/apache/netbeans/pull/2999] I got following feedback: > {quote}The New Java Project wizard uses an unusual Gradle template with an > older deprecated plugins syntax and jacoco included for some reason. > To make this feature maintainable we should instead use the existing "gradle > init" functionality: > {code:java} > gradle init --type java-application --test-framework junit-jupiter --dsl > groovy --package com.example --project-name example > {code} > {quote} > Shall we switch the new project in NetBeans to use the above given command? > Do you want to do it? Or shall I do it? -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@netbeans.apache.org For additional commands, e-mail: commits-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists