[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352189#comment-15352189
 ] 

ASF GitHub Bot commented on NIFI-1838:
--

Github user PuspenduBanerjee commented on a diff in the pull request:

https://github.com/apache/nifi/pull/534#discussion_r68686042
  
--- Diff: 
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java
 ---
@@ -92,11 +92,10 @@
 logger.error(message, t);
 }
 }
-} else {
-// Return defaults for now
-relationships.add(REL_SUCCESS);
-relationships.add(REL_FAILURE);
 }
+// Add defaults
+relationships.add(REL_SUCCESS);
+relationships.add(REL_FAILURE);
--- End diff --

@pvillard31 @mattyb149  any thoughts?


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349723#comment-15349723
 ] 

ASF GitHub Bot commented on NIFI-1838:
--

Github user PuspenduBanerjee commented on a diff in the pull request:

https://github.com/apache/nifi/pull/534#discussion_r68490863
  
--- Diff: 
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java
 ---
@@ -92,11 +92,10 @@
 logger.error(message, t);
 }
 }
-} else {
-// Return defaults for now
-relationships.add(REL_SUCCESS);
-relationships.add(REL_FAILURE);
 }
+// Add defaults
+relationships.add(REL_SUCCESS);
+relationships.add(REL_FAILURE);
--- End diff --

Even  in original state of `InvokeScriptedProcesor`, the documentation says 

> SUCCESS and FAILURE are always returned, and if the script
 processor has defined additional relationships, those will be added as 
well

```
 /**
 * Returns the valid relationships for this processor. SUCCESS and 
FAILURE are always returned, and if the script
 * processor has defined additional relationships, those will be added 
as well.
 *
 * @return a Set of Relationships supported by this processor
 */
@Override
public Set getRelationships()
```

So, ideally those test cases does not require modification, they are there 
as per contract stated in the java-doc and this piece is valid.

I strongly believe we should not break that contract as that may create 
implication for scripted-processor in production. 

Please correct me otherwise. 


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349019#comment-15349019
 ] 

ASF GitHub Bot commented on NIFI-1838:
--

Github user PuspenduBanerjee commented on a diff in the pull request:

https://github.com/apache/nifi/pull/534#discussion_r68482427
  
--- Diff: 
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java
 ---
@@ -92,11 +92,10 @@
 logger.error(message, t);
 }
 }
-} else {
-// Return defaults for now
-relationships.add(REL_SUCCESS);
-relationships.add(REL_FAILURE);
 }
+// Add defaults
+relationships.add(REL_SUCCESS);
+relationships.add(REL_FAILURE);
--- End diff --

Okay, I shall revert that into original state and fix test scripts. Thanks 
for all your guidance and review.


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347667#comment-15347667
 ] 

ASF GitHub Bot commented on NIFI-1838:
--

Github user PuspenduBanerjee commented on a diff in the pull request:

https://github.com/apache/nifi/pull/534#discussion_r68351775
  
--- Diff: 
nifi-mock/src/test/java/org/apache/nifi/util/TestMockProcessSession.java ---
@@ -36,7 +36,7 @@ public void testPenalizeFlowFileFromProcessor() {
 
 protected static class PoorlyBehavedProcessor extends 
AbstractProcessor {
 
-private static final Relationship REL_FAILURE = new 
Relationship.Builder()
+protected static final Relationship REL_FAILURE = new 
Relationship.Builder()
--- End diff --

reverted back.


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347651#comment-15347651
 ] 

ASF GitHub Bot commented on NIFI-1838:
--

Github user PuspenduBanerjee commented on a diff in the pull request:

https://github.com/apache/nifi/pull/534#discussion_r68350873
  
--- Diff: 
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java
 ---
@@ -92,11 +92,10 @@
 logger.error(message, t);
 }
 }
-} else {
-// Return defaults for now
-relationships.add(REL_SUCCESS);
-relationships.add(REL_FAILURE);
 }
+// Add defaults
+relationships.add(REL_SUCCESS);
+relationships.add(REL_FAILURE);
--- End diff --

As per documentation of 
[ExecuteScript](https://github.com/apache/nifi/blob/1bd2cf0d09a7111bcecffd0f473aa71c25a69845/nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ExecuteScript.java),
  the script evaluation expects a FlowFile to be returned, in which case it 
will route the FlowFile to **success**. If a script error occurs, the original 
FlowFile will be routed to **failure**. 

So, to comply with that statement I think, it is required to add those 
defaults. 
Please correct me otherwise.



> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343011#comment-15343011
 ] 

ASF GitHub Bot commented on NIFI-1838:
--

Github user mattyb149 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/534#discussion_r67970007
  
--- Diff: 
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java
 ---
@@ -92,11 +92,10 @@
 logger.error(message, t);
 }
 }
-} else {
-// Return defaults for now
-relationships.add(REL_SUCCESS);
-relationships.add(REL_FAILURE);
 }
+// Add defaults
+relationships.add(REL_SUCCESS);
+relationships.add(REL_FAILURE);
--- End diff --

Yeah if this is failing tests, I'd say take a look at the tests. We don't 
want to add default relationships, especially when there's a legit instance of 
a Processor, as it is the Processor's responsibility to define all relationships


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341342#comment-15341342
 ] 

ASF GitHub Bot commented on NIFI-1838:
--

Github user pvillard31 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/534#discussion_r67825033
  
--- Diff: 
nifi-mock/src/main/java/org/apache/nifi/util/MockProcessSession.java ---
@@ -793,13 +798,21 @@ private void validateState(final FlowFile flowFile) {
 throw new FlowFileHandlingException(flowFile + " is not the 
most recent version of this flow file within this session");
 }
 
+
 for (final List flowFiles : transferMap.values()) {
 if (flowFiles.contains(flowFile)) {
 throw new IllegalStateException(flowFile + " has already 
been transferred");
 }
 }
 }
 
+private void validateDestinationRelation(final Relationship 
relationship) {
+if (!relationships.contains(relationship)) {
+rollback();
--- End diff --

Fair enough.


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341337#comment-15341337
 ] 

ASF GitHub Bot commented on NIFI-1838:
--

Github user pvillard31 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/534#discussion_r67824794
  
--- Diff: 
nifi-mock/src/test/java/org/apache/nifi/util/TestMockProcessSession.java ---
@@ -36,7 +36,7 @@ public void testPenalizeFlowFileFromProcessor() {
 
 protected static class PoorlyBehavedProcessor extends 
AbstractProcessor {
 
-private static final Relationship REL_FAILURE = new 
Relationship.Builder()
+protected static final Relationship REL_FAILURE = new 
Relationship.Builder()
--- End diff --

Is it still needed?


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337695#comment-15337695
 ] 

ASF GitHub Bot commented on NIFI-1838:
--

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/534
  
thanks @PuspenduBanerjee, I'm quite busy this WE, will have another look 
asap


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335090#comment-15335090
 ] 

ASF GitHub Bot commented on NIFI-1838:
--

Github user PuspenduBanerjee commented on the issue:

https://github.com/apache/nifi/pull/534
  
@pvillard31 Thanks for your effort to review this. 
I have incorporated your comments as much as I could.


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335084#comment-15335084
 ] 

ASF GitHub Bot commented on NIFI-1838:
--

Github user PuspenduBanerjee commented on a diff in the pull request:

https://github.com/apache/nifi/pull/534#discussion_r67446868
  
--- Diff: 
nifi-mock/src/test/java/org/apache/nifi/util/TestMockProcessSession.java ---
@@ -36,7 +36,7 @@ public void testPenalizeFlowFileFromProcessor() {
 
 protected static class PoorlyBehavedProcessor extends 
AbstractProcessor {
 
-private static final Relationship REL_FAILURE = new 
Relationship.Builder()
+protected static final Relationship REL_FAILURE = new 
Relationship.Builder()
--- End diff --

No not needed anymore. :)


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335083#comment-15335083
 ] 

ASF GitHub Bot commented on NIFI-1838:
--

Github user PuspenduBanerjee commented on a diff in the pull request:

https://github.com/apache/nifi/pull/534#discussion_r67446830
  
--- Diff: 
nifi-mock/src/main/java/org/apache/nifi/util/MockProcessSession.java ---
@@ -793,13 +798,21 @@ private void validateState(final FlowFile flowFile) {
 throw new FlowFileHandlingException(flowFile + " is not the 
most recent version of this flow file within this session");
 }
 
+
 for (final List flowFiles : transferMap.values()) {
 if (flowFiles.contains(flowFile)) {
 throw new IllegalStateException(flowFile + " has already 
been transferred");
 }
 }
 }
 
+private void validateDestinationRelation(final Relationship 
relationship) {
+if (!relationships.contains(relationship)) {
+rollback();
--- End diff --

I think, though it's for testing purpose , we should emulate as real as we 
can and rollback is the best possible way to revert back to a stable state. 
And, in a real context we may face such issue in case of orchestration, where 
an attribute in a flowfile may finally dictate where it should be transferred.


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334897#comment-15334897
 ] 

ASF GitHub Bot commented on NIFI-1838:
--

Github user PuspenduBanerjee commented on a diff in the pull request:

https://github.com/apache/nifi/pull/534#discussion_r67439195
  
--- Diff: 
nifi-mock/src/test/java/org/apache/nifi/util/TestMockProcessSession.java ---
@@ -55,4 +55,35 @@ public void onTrigger(final ProcessContext ctx, final 
ProcessSession session) th
 }
 
 }
+
+
+@Test(expected = AssertionError.class)
+public void testNonExistentRelationFromProcessor() {
+
TestRunners.newTestRunner(NonExistentRelationTestProcessor.class).run();
+}
+
+protected static class NonExistentRelationTestProcessor extends 
PoorlyBehavedProcessor {
+
+static final Relationship REL_NON_EXISTENT = new 
Relationship.Builder()
+.name("NonExistent Relation")
+.build();
+
+public Set relationships = 
Collections.singleton(REL_FAILURE);
+
+@Override
+public Set getRelationships() {
+return relationships;
--- End diff --

Good finding. Can't really remember why did I add that. removed now and 
checking in.


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334819#comment-15334819
 ] 

ASF GitHub Bot commented on NIFI-1838:
--

Github user PuspenduBanerjee commented on a diff in the pull request:

https://github.com/apache/nifi/pull/534#discussion_r67434506
  
--- Diff: 
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java
 ---
@@ -92,11 +92,10 @@
 logger.error(message, t);
 }
 }
-} else {
-// Return defaults for now
-relationships.add(REL_SUCCESS);
-relationships.add(REL_FAILURE);
 }
+// Add defaults
+relationships.add(REL_SUCCESS);
+relationships.add(REL_FAILURE);
--- End diff --

@pvillard31 Please check the use of session.transfer(flowFile, 
InvokeScriptedProcessor.REL_SUCCESS) in test_reader.groovy#onTrigger. All 
groovy test cases uses REL_SUCCESS or REL_FAILURE . It is not a problem in 
pre-NIFI-1152 and that's why I had to raise NIFI-1838.


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334733#comment-15334733
 ] 

ASF GitHub Bot commented on NIFI-1838:
--

Github user pvillard31 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/534#discussion_r67428396
  
--- Diff: 
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java
 ---
@@ -92,11 +92,10 @@
 logger.error(message, t);
 }
 }
-} else {
-// Return defaults for now
-relationships.add(REL_SUCCESS);
-relationships.add(REL_FAILURE);
 }
+// Add defaults
+relationships.add(REL_SUCCESS);
+relationships.add(REL_FAILURE);
--- End diff --

@mattyb149 do you mind having a look? I don't think this is what we want 
here, I'd rather say that if we need to change something it would be on tests 
side.


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334699#comment-15334699
 ] 

ASF GitHub Bot commented on NIFI-1838:
--

Github user pvillard31 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/534#discussion_r67424962
  
--- Diff: 
nifi-mock/src/test/java/org/apache/nifi/util/TestMockProcessSession.java ---
@@ -55,4 +55,35 @@ public void onTrigger(final ProcessContext ctx, final 
ProcessSession session) th
 }
 
 }
+
+
+@Test(expected = AssertionError.class)
+public void testNonExistentRelationFromProcessor() {
+
TestRunners.newTestRunner(NonExistentRelationTestProcessor.class).run();
+}
+
+protected static class NonExistentRelationTestProcessor extends 
PoorlyBehavedProcessor {
+
+static final Relationship REL_NON_EXISTENT = new 
Relationship.Builder()
+.name("NonExistent Relation")
+.build();
+
+public Set relationships = 
Collections.singleton(REL_FAILURE);
+
+@Override
+public Set getRelationships() {
+return relationships;
--- End diff --

It looks to me this is unrelated. This is a test class absolutely 
independent from scripting processors, you don't need to change the scope of 
the relationship in ``PoorlyBehavedProcessor``and you can return an empty set 
of relationships to execute your unit test.


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334677#comment-15334677
 ] 

ASF GitHub Bot commented on NIFI-1838:
--

Github user pvillard31 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/534#discussion_r67423663
  
--- Diff: 
nifi-mock/src/main/java/org/apache/nifi/util/MockProcessSession.java ---
@@ -793,13 +798,21 @@ private void validateState(final FlowFile flowFile) {
 throw new FlowFileHandlingException(flowFile + " is not the 
most recent version of this flow file within this session");
 }
 
+
 for (final List flowFiles : transferMap.values()) {
 if (flowFiles.contains(flowFile)) {
 throw new IllegalStateException(flowFile + " has already 
been transferred");
 }
 }
 }
 
+private void validateDestinationRelation(final Relationship 
relationship) {
+if (!relationships.contains(relationship)) {
+rollback();
--- End diff --

This class is limited to testing purpose, so throwing an exception would 
make fail the associated test. I think this is what we want and in this case 
rollback is not needed. In a real context we should not be in such situation 
where the relationship does not exist.


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334338#comment-15334338
 ] 

ASF GitHub Bot commented on NIFI-1838:
--

Github user PuspenduBanerjee commented on a diff in the pull request:

https://github.com/apache/nifi/pull/534#discussion_r67395014
  
--- Diff: 
nifi-mock/src/test/java/org/apache/nifi/util/TestMockProcessSession.java ---
@@ -55,4 +55,35 @@ public void onTrigger(final ProcessContext ctx, final 
ProcessSession session) th
 }
 
 }
+
+
+@Test(expected = AssertionError.class)
+public void testNonExistentRelationFromProcessor() {
+
TestRunners.newTestRunner(NonExistentRelationTestProcessor.class).run();
+}
+
+protected static class NonExistentRelationTestProcessor extends 
PoorlyBehavedProcessor {
+
+static final Relationship REL_NON_EXISTENT = new 
Relationship.Builder()
+.name("NonExistent Relation")
+.build();
+
+public Set relationships = 
Collections.singleton(REL_FAILURE);
+
+@Override
+public Set getRelationships() {
+return relationships;
--- End diff --

The way groovy test cases are written , they will fail if we return Empty 
Relationship. please see NIFI-1838


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334333#comment-15334333
 ] 

ASF GitHub Bot commented on NIFI-1838:
--

Github user PuspenduBanerjee commented on a diff in the pull request:

https://github.com/apache/nifi/pull/534#discussion_r67394594
  
--- Diff: 
nifi-mock/src/test/java/org/apache/nifi/util/TestMockProcessSession.java ---
@@ -36,7 +36,7 @@ public void testPenalizeFlowFileFromProcessor() {
 
 protected static class PoorlyBehavedProcessor extends 
AbstractProcessor {
 
-private static final Relationship REL_FAILURE = new 
Relationship.Builder()
+protected static final Relationship REL_FAILURE = new 
Relationship.Builder()
--- End diff --

Directly using it in Test NonExistentRelationTestProcessor public 
Set relationships = Collections.singleton(REL_FAILURE);


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334327#comment-15334327
 ] 

ASF GitHub Bot commented on NIFI-1838:
--

Github user PuspenduBanerjee commented on a diff in the pull request:

https://github.com/apache/nifi/pull/534#discussion_r67394024
  
--- Diff: 
nifi-mock/src/main/java/org/apache/nifi/util/MockProcessSession.java ---
@@ -793,13 +798,21 @@ private void validateState(final FlowFile flowFile) {
 throw new FlowFileHandlingException(flowFile + " is not the 
most recent version of this flow file within this session");
 }
 
+
 for (final List flowFiles : transferMap.values()) {
 if (flowFiles.contains(flowFile)) {
 throw new IllegalStateException(flowFile + " has already 
been transferred");
 }
 }
 }
 
+private void validateDestinationRelation(final Relationship 
relationship) {
+if (!relationships.contains(relationship)) {
+rollback();
--- End diff --

So, if a relationship does not exist what should we do?


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334317#comment-15334317
 ] 

ASF GitHub Bot commented on NIFI-1838:
--

Github user PuspenduBanerjee commented on a diff in the pull request:

https://github.com/apache/nifi/pull/534#discussion_r67393509
  
--- Diff: 
nifi-mock/src/main/java/org/apache/nifi/util/MockProcessSession.java ---
@@ -587,13 +589,15 @@ public void transfer(final FlowFile flowFile, final 
Relationship relationship) {
 }
 
 validateState(flowFile);
+validateDestinationRelation(relationship);
 List list = transferMap.get(relationship);
 if (list == null) {
 list = new ArrayList<>();
 transferMap.put(relationship, list);
 }
 
 beingProcessed.remove(flowFile.getId());
+   // if(sharedState.)
--- End diff --

done


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334269#comment-15334269
 ] 

ASF GitHub Bot commented on NIFI-1838:
--

Github user pvillard31 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/534#discussion_r67390898
  
--- Diff: 
nifi-mock/src/test/java/org/apache/nifi/util/TestMockProcessSession.java ---
@@ -16,6 +16,9 @@
  */
 package org.apache.nifi.util;
 
+import java.util.Collections;
+import java.util.Set;
+
--- End diff --

I believe your IDE is automatically changing the import order when you save 
your modifications. Could you revert the changes?


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334262#comment-15334262
 ] 

ASF GitHub Bot commented on NIFI-1838:
--

Github user pvillard31 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/534#discussion_r67390513
  
--- Diff: 
nifi-mock/src/main/java/org/apache/nifi/util/MockProcessSession.java ---
@@ -587,13 +589,15 @@ public void transfer(final FlowFile flowFile, final 
Relationship relationship) {
 }
 
 validateState(flowFile);
+validateDestinationRelation(relationship);
 List list = transferMap.get(relationship);
 if (list == null) {
 list = new ArrayList<>();
 transferMap.put(relationship, list);
 }
 
 beingProcessed.remove(flowFile.getId());
+   // if(sharedState.)
--- End diff --

Could you remove this comment?


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334187#comment-15334187
 ] 

ASF GitHub Bot commented on NIFI-1838:
--

GitHub user PuspenduBanerjee opened a pull request:

https://github.com/apache/nifi/pull/534

Fix for NIFI-1838 & NIFI-1152

Fix for NIFI-1838 & NIFI-1152


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PuspenduBanerjee/nifi NIFI-1152

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/534.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #534


commit 1ee24388bb54a82d008d4ab7e32dd39c2bb0ff4d
Author: Puspendu Banerjee 
Date:   2016-05-03T01:36:50Z

Fix for NIFI-1838 & NIFI-1152




> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320967#comment-15320967
 ] 

ASF GitHub Bot commented on NIFI-1838:
--

Github user PuspenduBanerjee closed the pull request at:

https://github.com/apache/nifi/pull/400


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273564#comment-15273564
 ] 

ASF GitHub Bot commented on NIFI-1838:
--

Github user PuspenduBanerjee commented on the pull request:

https://github.com/apache/nifi/pull/400#issuecomment-217337176
  
@markap14  @trkurc @apiri Will anyone get a chance to merge it in.


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268846#comment-15268846
 ] 

ASF GitHub Bot commented on NIFI-1838:
--

Github user PuspenduBanerjee commented on the pull request:

https://github.com/apache/nifi/pull/400#issuecomment-216557197
  
@markap14 If it looks good, will you be able to check in?


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[Puspendu Banerjee (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268774#comment-15268774
 ] 

Puspendu Banerjee commented on NIFI-1838:
-

PR available.

https://github.com/apache/nifi/pull/400#issuecomment-216414833
Updated to address Fix for NIFI-1838 & NIFI-1152


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[Puspendu Banerjee (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268690#comment-15268690
 ] 

Puspendu Banerjee commented on NIFI-1838:
-

PR: https://github.com/apache/nifi/pull/400/ is addressing this issue and the 
related one.

> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[Puspendu Banerjee (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268681#comment-15268681
 ] 

Puspendu Banerjee commented on NIFI-1838:
-

That patch is just  a squashed version and same as that PR.
As CI Build in *appveyor* CI is failing , so I have created that patch for 
quick/review and test.

> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[Oleg Zhurakousky (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268638#comment-15268638
 ] 

Oleg Zhurakousky commented on NIFI-1838:


I am specifically referring to 
https://github.com/apache/nifi/pull/400/commits/1c52e096da907d30df43ea9f5c97a1e1234b856e
 as it points to the same JIRAs

> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[Oleg Zhurakousky (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268636#comment-15268636
 ] 

Oleg Zhurakousky commented on NIFI-1838:


It appears you have a PR and patch and they are different. Could you please 
clarify?


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>  Labels: patch
> Fix For: 1.0.0
>
> Attachments: 
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15267912#comment-15267912
 ] 

ASF GitHub Bot commented on NIFI-1838:
--

Github user PuspenduBanerjee commented on the pull request:

https://github.com/apache/nifi/pull/400#issuecomment-216414833
  
Updated to address Fix for NIFI-1838 & NIFI-1152


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> --
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
>Reporter: Puspendu Banerjee
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they 
> don't define Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)