(nuttx) branch master updated (2713c5e9dfd -> d54fb6ad005)

2025-08-20 Thread lupyuen
This is an automated email from the ASF dual-hosted git repository.

lupyuen pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


from 2713c5e9dfd boards/esp32s3: Add SPI slave device support
 add d54fb6ad005 drivers/audio/CMakeLists.txt: Aligned Cmake with Make

No new revisions were added by this update.

Summary of changes:
 drivers/audio/CMakeLists.txt | 4 
 1 file changed, 4 insertions(+)



Re: [PR] drivers/audio/CMakeLists.txt: Aligned Cmake with Make [nuttx]

2025-08-20 Thread via GitHub


lupyuen merged PR #16870:
URL: https://github.com/apache/nuttx/pull/16870


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] drivers/leds/CMakeLists.txt: Aligned Cmake with Make [nuttx]

2025-08-20 Thread via GitHub


lupyuen merged PR #16871:
URL: https://github.com/apache/nuttx/pull/16871


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(nuttx) branch master updated: drivers/leds/CMakeLists.txt: Aligned Cmake with Make

2025-08-20 Thread lupyuen
This is an automated email from the ASF dual-hosted git repository.

lupyuen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


The following commit(s) were added to refs/heads/master by this push:
 new 50bbad510a5 drivers/leds/CMakeLists.txt: Aligned Cmake with Make
50bbad510a5 is described below

commit 50bbad510a50454924ec2577ea4d20e2c251937e
Author: simbit18 <101105604+simbi...@users.noreply.github.com>
AuthorDate: Wed Aug 20 11:13:54 2025 +0200

drivers/leds/CMakeLists.txt: Aligned Cmake with Make

Add:

KTD2052 led driver

#16217

Signed-off-by: simbit18 
---
 drivers/leds/CMakeLists.txt | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/leds/CMakeLists.txt b/drivers/leds/CMakeLists.txt
index eb292f16da0..70ffdbbaaac 100644
--- a/drivers/leds/CMakeLists.txt
+++ b/drivers/leds/CMakeLists.txt
@@ -34,6 +34,10 @@ if(CONFIG_LEDS_APA102)
   list(APPEND SRCS apa102.c)
 endif()
 
+if(CONFIG_KTD2052)
+  list(APPEND SRCS ktd2052.c)
+endif()
+
 if(CONFIG_LEDS_MAX7219)
   list(APPEND SRCS max7219.c)
 endif()



[PR] arch/arm: Add missing barriers.h [nuttx]

2025-08-20 Thread via GitHub


TangMeng12 opened a new pull request, #16881:
URL: https://github.com/apache/nuttx/pull/16881

   This commit adds the missing `barriers.h` for arm.
   
   Change-Id: Ia8c33ccbac47830ac179108a2d59fd75f5ede400
   
   *Note: Please adhere to [Contributing 
Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).*
   
   ## Summary
   In the arch/arm/include/barriers.h file, there is the following
   statement:
   
   41 # include 
   
   But arch/arm/barriers.h file does not actually exist, so this commit
   has added an arch/arm/barriers.h file
   
   ## Impact
   
   NA
   
   ## Testing
   
   NA
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(nuttx) branch master updated: boards/esp32s3: Add SPI slave device support

2025-08-20 Thread fdcavalcanti
This is an automated email from the ASF dual-hosted git repository.

fdcavalcanti pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


The following commit(s) were added to refs/heads/master by this push:
 new 2713c5e9dfd boards/esp32s3: Add SPI slave device support
2713c5e9dfd is described below

commit 2713c5e9dfdc5baf25272425314a42dc4e215cbb
Author: Thiago Finelon 
AuthorDate: Tue Aug 19 10:31:38 2025 -0300

boards/esp32s3: Add SPI slave device support

- Added esp32s3_board_spislavedev.c with board-level SPI slave logic
- Added esp32s3_board_spislavedev.h public header in common/include
- Updated Make.defs to include the new source when CONFIG_SPI_SLAVE_DRIVER=y
- Adding spislv board config to esp32s3-devkit
- Adding documentation of esp32s3 devkit spi slv
- Fixing path include in esp32s3_board_spislavedev.c
- Fixing relative path in the header of esp32s3_board_spislavedev.h
- Removing neasted check in Make.defs, consistency reasons

This provides initial support for SPI slave device initialization
on ESP32-S3 boards, making the feature available under conditional
build configuration.

Signed-off-by: Thiago Finelon 
---
 .../xtensa/esp32s3/boards/esp32s3-devkit/index.rst | 20 ++
 .../common/include/esp32s3_board_spislavedev.h | 76 
 boards/xtensa/esp32s3/common/src/Make.defs |  4 ++
 .../esp32s3/common/src/esp32s3_board_spislavedev.c | 82 ++
 .../esp32s3-devkit/configs/spislv/defconfig| 51 ++
 .../esp32s3/esp32s3-devkit/src/esp32s3_bringup.c   | 29 +++-
 6 files changed, 259 insertions(+), 3 deletions(-)

diff --git 
a/Documentation/platforms/xtensa/esp32s3/boards/esp32s3-devkit/index.rst 
b/Documentation/platforms/xtensa/esp32s3/boards/esp32s3-devkit/index.rst
index 8ca90082b26..061ab406d02 100644
--- a/Documentation/platforms/xtensa/esp32s3/boards/esp32s3-devkit/index.rst
+++ b/Documentation/platforms/xtensa/esp32s3/boards/esp32s3-devkit/index.rst
@@ -963,6 +963,26 @@ Once booted you can use the following commands to mount 
the file system::
 
 Note that mksmartfs is only needed the first time.
 
+spislv
+--
+
+This configuration enables the SPI2 peripheral in **slave mode** and
+provides the ``spislv`` example application to test data exchange with an
+external SPI master.
+
+After building and flashing the firmware, run the following command on the
+board terminal::
+
+nsh> spislv -x 5 1a2b3c4d5e
+
+This command enqueues the data sequence ``1a2b3c4d5e`` in the slave buffer.  
+On the next transfer, the external SPI master should receive this data back
+from the slave.
+
+By default, SPI2 pins are used for the slave interface. The exact pin mapping
+depends on the ESP32-S3 DevKit version and can be adjusted through
+``menuconfig`` under *System type → SPI configuration*.  
+
 sta_softap
 --
 
diff --git a/boards/xtensa/esp32s3/common/include/esp32s3_board_spislavedev.h 
b/boards/xtensa/esp32s3/common/include/esp32s3_board_spislavedev.h
new file mode 100644
index 000..b79c8456321
--- /dev/null
+++ b/boards/xtensa/esp32s3/common/include/esp32s3_board_spislavedev.h
@@ -0,0 +1,76 @@
+/
+ * boards/xtensa/esp32s3/common/include/esp32s3_board_spislavedev.h
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.  The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+#ifndef __BOARDS_XTENSA_ESP32S3_COMMON_INCLUDE_ESP32S3_BOARD_SPISLAVEDEV_H
+#define __BOARDS_XTENSA_ESP32S3_COMMON_INCLUDE_ESP32S3_BOARD_SPISLAVEDEV_H
+
+/
+ * Included Files
+ /
+
+#include 
+
+/
+ * Pre-processor Definitions
+ /
+
+#ifndef __ASSEMBLY__
+
+#undef EXTERN
+#if defined(__cplusplus)
+#define EXTERN extern "C"
+extern "C"
+{
+#else
+

Re: [PR] boards/esp32s3: Add SPI slave device support [nuttx]

2025-08-20 Thread via GitHub


fdcavalcanti merged PR #16866:
URL: https://github.com/apache/nuttx/pull/16866


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] drivers/analog/ads7046: Add support for ADS7046 ADC [nuttx]

2025-08-20 Thread via GitHub


fdcavalcanti commented on PR #16836:
URL: https://github.com/apache/nuttx/pull/16836#issuecomment-3207562888

   You have a build error on CI.
   
   ```
 Cleaning...
 Configuring...
 Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
 Enabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
 Building NuttX...
 [1/1] Normalize xiao-ra4m1/nsh
   

   Configuration/Tool: 
raspberrypi-pico-w/nsh-flash,CONFIG_ARM_TOOLCHAIN_GNU_EABI
   2025-08-20 11:40:35
   

 Cleaning...
 Configuring...
 Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
 Enabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
 Building NuttX...
   In file included from 
/tools/pico-sdk/src/common/pico_base_headers/include/pico.h:64,
from 
/tools/pico-sdk/src/rp2040/pico_platform/include/pico/asm_helper.S:7,
from 
/tools/pico-sdk/src/rp2040/boot_stage2/boot2_w25q080.S:29:
   /tools/pico-sdk/src/rp2040/pico_platform/include/pico/platform.h:26:10: 
fatal error: pico/platform/common.h: No such file or directory
  26 | #include "pico/platform/common.h"
 |  ^~~~
   compilation terminated.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] boards/esp32s3: Add SPI slave device support [nuttx]

2025-08-20 Thread via GitHub


xiaoxiang781216 commented on code in PR #16866:
URL: https://github.com/apache/nuttx/pull/16866#discussion_r2288010299


##
boards/xtensa/esp32s3/esp32s3-devkit/src/esp32s3_bringup.c:
##
@@ -188,15 +192,34 @@ int esp32s3_bringup(void)
 #endif
 
 #if defined(CONFIG_ESP32S3_SPI) && defined(CONFIG_SPI_DRIVER)
-  #ifdef CONFIG_ESP32S3_SPI2
+
+  #if defined(CONFIG_SPI_SLAVE_DRIVER) && defined(CONFIG_ESP32S3_SPI2)
+  ret = board_spislavedev_initialize(ESP32S3_SPI2);
+  if (ret < 0)
+{
+  syslog(LOG_ERR, "Failed to initialize SPI%d Slave driver: %d\n",
+ ESP32S3_SPI2, ret);
+}
+  #endif
+
+  #if defined(CONFIG_SPI_SLAVE_DRIVER) && defined(CONFIG_ESP32S3_SPI3)
+  ret = board_spislavedev_initialize(ESP32S3_SPI3);
+  if (ret < 0)
+{
+  syslog(LOG_ERR, "Failed to initialize SPI%d Slave driver: %d\n",
+ ESP32S3_SPI2, ret);
+}
+  #endif
+
+  #if  defined(CONFIG_ESP32S3_SPI2) && !defined(CONFIG_SPI_SLAVE_DRIVER)

Review Comment:
   `#if defined(CONFIG_ESP32S3_SPI2) && !defined(CONFIG_SPI_SLAVE_DRIVER)`



##
boards/xtensa/esp32s3/common/src/esp32s3_board_spislavedev.c:
##
@@ -32,7 +32,7 @@
 
 #include 
 
-#include "esp32s3_spi.h"
+#include "esp32s3_board_spislavedev.h"

Review Comment:
   ditto



##
boards/xtensa/esp32s3/common/src/Make.defs:
##
@@ -36,9 +36,10 @@ endif
 
 ifeq ($(CONFIG_SPI_DRIVER),y)
   CSRCS += esp32s3_board_spidev.c
-  ifeq ($(CONFIG_SPI_SLAVE_DRIVER),y)
-CSRCS += esp32s3_board_spislavedev.c
-  endif
+endif
+
+ifeq ($(CONFIG_SPI_SLAVE_DRIVER),y)
+  CSRCS += esp32s3_board_spislavedev.c

Review Comment:
   please organize your patch in the reasonable patch



##
boards/xtensa/esp32s3/common/include/esp32s3_board_spislavedev.h:
##
@@ -1,5 +1,5 @@
 /
- * boards/xtensa/esp32s2/common/include/esp32s2_board_spislavedev.h
+ * boards/xtensa/esp32s3/common/include/esp32s3_board_spislavedev.h

Review Comment:
   merge this patch to:
   
https://github.com/apache/nuttx/pull/16866/commits/4bb93d3539033e5fa9bfccb06d49e6d9e4e9b2e4



##
boards/xtensa/esp32s3/common/src/esp32s3_board_spislavedev.c:
##
@@ -1,5 +1,5 @@
 /
- * boards/xtensa/esp32s2/common/src/esp32s2_board_spislavedev.c
+ * boards/xtensa/esp32s3/common/src/esp32s3_board_spislavedev.c

Review Comment:
   merge to the first patch



##
boards/xtensa/esp32s3/common/src/esp32s3_board_spislavedev.c:
##
@@ -32,7 +32,7 @@
 
 #include 
 
-#include "esp32s3_board_spislavedev.h"
+#include "esp32s3_spi.h"

Review Comment:
   why you change this line several time? let's squash into one patch



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] boards/esp32s3: Add SPI slave device support [nuttx]

2025-08-20 Thread via GitHub


thiagofinelon commented on PR #16866:
URL: https://github.com/apache/nuttx/pull/16866#issuecomment-3206160052

   https://github.com/user-attachments/assets/917861b5-31b9-49ed-a856-21db7f28fcdf";
 />
   
   I retested, queing slave data @fdcavalcanti 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] boards/esp32s3: Add SPI slave device support [nuttx]

2025-08-20 Thread via GitHub


thiagofinelon commented on code in PR #16866:
URL: https://github.com/apache/nuttx/pull/16866#discussion_r2288126163


##
boards/xtensa/esp32s3/esp32s3-devkit/src/esp32s3_bringup.c:
##
@@ -188,15 +192,34 @@ int esp32s3_bringup(void)
 #endif
 
 #if defined(CONFIG_ESP32S3_SPI) && defined(CONFIG_SPI_DRIVER)
-  #ifdef CONFIG_ESP32S3_SPI2
+
+  #if defined(CONFIG_SPI_SLAVE_DRIVER) && defined(CONFIG_ESP32S3_SPI2)
+  ret = board_spislavedev_initialize(ESP32S3_SPI2);
+  if (ret < 0)
+{
+  syslog(LOG_ERR, "Failed to initialize SPI%d Slave driver: %d\n",
+ ESP32S3_SPI2, ret);
+}
+  #endif
+
+  #if defined(CONFIG_SPI_SLAVE_DRIVER) && defined(CONFIG_ESP32S3_SPI3)
+  ret = board_spislavedev_initialize(ESP32S3_SPI3);
+  if (ret < 0)
+{
+  syslog(LOG_ERR, "Failed to initialize SPI%d Slave driver: %d\n",
+ ESP32S3_SPI2, ret);
+}
+  #endif
+
+  #if  defined(CONFIG_ESP32S3_SPI2) && !defined(CONFIG_SPI_SLAVE_DRIVER)

Review Comment:
   unwanted space removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] boards/esp32s3: Add SPI slave device support [nuttx]

2025-08-20 Thread via GitHub


thiagofinelon commented on code in PR #16866:
URL: https://github.com/apache/nuttx/pull/16866#discussion_r2288127008


##
boards/xtensa/esp32s3/common/include/esp32s3_board_spislavedev.h:
##
@@ -1,5 +1,5 @@
 /
- * boards/xtensa/esp32s2/common/include/esp32s2_board_spislavedev.h
+ * boards/xtensa/esp32s3/common/include/esp32s3_board_spislavedev.h

Review Comment:
   the patch was organized



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] boards/esp32s3: Add SPI slave device support [nuttx]

2025-08-20 Thread via GitHub


thiagofinelon commented on code in PR #16866:
URL: https://github.com/apache/nuttx/pull/16866#discussion_r2288129427


##
boards/xtensa/esp32s3/common/src/esp32s3_board_spislavedev.c:
##
@@ -1,5 +1,5 @@
 /
- * boards/xtensa/esp32s2/common/src/esp32s2_board_spislavedev.c
+ * boards/xtensa/esp32s3/common/src/esp32s3_board_spislavedev.c

Review Comment:
   merged



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] boards/arm/rp2040: Fix code style and error checking [nuttx]

2025-08-20 Thread via GitHub


nmaggioni commented on PR #16869:
URL: https://github.com/apache/nuttx/pull/16869#issuecomment-3205637993

   @acassis Thanks for having taken care of this, I've retested my hw and the 
sensor still works fine.
   
   @cederom I'm on it, SDK 2.2.0 is misbehaving on clean pulls for me too. 
Sorry if I didn't catch that earlier, I may have been tricked by some cache 
somewhere.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] drivers/audio/CMakeLists.txt: Aligned Cmake with Make [nuttx]

2025-08-20 Thread via GitHub


simbit18 commented on PR #16870:
URL: https://github.com/apache/nuttx/pull/16870#issuecomment-3205632329

   

   Configuration/Tool: 
raspberrypi-pico-w/nsh-flash,CONFIG_ARM_TOOLCHAIN_GNU_EABI
   2025-08-20 10:05:06
   

 Cleaning...
 Configuring...
 Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
 Enabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
 Building NuttX...
   In file included from 
/tools/pico-sdk/src/common/pico_base_headers/include/pico.h:64,
from 
/tools/pico-sdk/src/rp2040/pico_platform/include/pico/asm_helper.S:7,
from 
/tools/pico-sdk/src/rp2040/boot_stage2/boot2_w25q080.S:29:
   /tools/pico-sdk/src/rp2040/pico_platform/include/pico/platform.h:26:10: 
fatal error: pico/platform/common.h: No such file or directory
  26 | #include "pico/platform/common.h"
 |  ^~~~
   compilation terminated.
   make[2]: *** [chip/boot2/Make.defs:56: rp2040_boot_stage2.elf] Error 1
   make[2]: Target 'makedepfile' not remade because of errors.
   make[1]: *** [Makefile:261: .depend] Error 2
   make[1]: Target 'depend' not remade because of errors.
   make: *** [tools/Unix.mk:660: pass2dep] Error 2
   make: Target 'all' not remade because of errors.
   /github/workspace/sources/nuttx/tools/testbuild.sh: line 385: 
/github/workspace/sources/nuttx/../nuttx/nuttx.manifest: No such file or 
directory
 [1/1] Normalize raspberrypi-pico-w/nsh-flash
   

   
   @xiaoxiang781216  @acassis  This error does not depend on this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Add missing PSE52 interfaces [nuttx]

2025-08-20 Thread via GitHub


szafonimateusz-mi opened a new pull request, #16874:
URL: https://github.com/apache/nuttx/pull/16874

   ## Summary
   
   Add missing PSE52 interfaces:
   
   - pthread_setconcurrency() and pthread_getconcurrency()
   - sigsetjmp() and siglongjmp()
   - confstr()
   - pthread_attr_getguardsize() and pthread_attr_setguardsize()
   
   ## Impact
   missing interfaces required by POSIX Profile 52 Test Suite
   
   ## Testing
   sim
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] boards/arm/rp2040: Fix code style and error checking [nuttx]

2025-08-20 Thread via GitHub


cederom commented on PR #16869:
URL: https://github.com/apache/nuttx/pull/16869#issuecomment-3206027867

   > @cederom Care to try #16876? The fix was simple enough but, as you said, 
the upstream did not mark it as a breaking change (...?).
   
   Im on it, thanks! :-)
   
   Looking at https://github.com/raspberrypi/pico-sdk/releases/tag/2.2.0 there 
is only one mention of breaking change for `pico_encrypt_binary`, no mention on 
headers relocation / change :-P


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] arch/arm/rp2040: Support pico-sdk 2.2.0 [nuttx]

2025-08-20 Thread via GitHub


nmaggioni opened a new pull request, #16876:
URL: https://github.com/apache/nuttx/pull/16876

   ## Summary
   
   Version 2.2.0 of the pico-sdk seems to have unified some RP2040 and RP2350 
headers under a new path. Now both the old and the new paths are searched 
during compilation.
   
   The commands in the documentation have been updated and a tip about not 
necessarily having to compile picotool manually has been added. The RP2040 has 
SDK instructions in its main arch page, while the RP2350 has them in a board 
page; due to the smaller number of RP230 boards currently documented, this may 
not be an issue (yet).
   
   ## Impact
   
   It will now be possible to compile RP2040 binaries with newer pico-sdk 
versions (namely 2.2.0). Compatibility with version 2.1.1 has been preserved.
   
   ## Testing
   
   These changes were tested on a Linux host, targeting a custom RP2040 board 
using today's NuttX master as the baseline. The pico-sdk versions tested were 
2.1.1 (known working) and 2.2.0 (latest release, previously breaking in CI); 
older versions were not tested since they are not currently targeted by either 
the docs or the build system.
   
   Compilation of the RP2350 `raspberrypi-pico-2/usbnsh` target has been 
tested, but I don't have any real hardware to upload the final binary to.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] boards/esp32s3: Add SPI slave device support [nuttx]

2025-08-20 Thread via GitHub


acassis commented on PR #16866:
URL: https://github.com/apache/nuttx/pull/16866#issuecomment-3206388972

   > @acassis Do I need to add a board config for spi slave ?
   
   Yes, it is important to make it easy for other people to test it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] drivers/can/kvaser_pci: configure number of passes in interrupt handler [nuttx]

2025-08-20 Thread via GitHub


raiden00pl commented on code in PR #16875:
URL: https://github.com/apache/nuttx/pull/16875#discussion_r2288222948


##
drivers/can/Kconfig:
##
@@ -273,6 +273,15 @@ config CAN_KVASER
 
 if CAN_KVASER
 
+config CAN_KVASER_IRQ_PASSES
+   int "Kvaser PCI interrupt passes"
+   default 16

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] boards/arm/rp2040: Fix code style and error checking [nuttx]

2025-08-20 Thread via GitHub


nmaggioni commented on PR #16869:
URL: https://github.com/apache/nuttx/pull/16869#issuecomment-3206058194

   > no mention on headers relocation / change :-P
   
   In their defense, I suppose not using the SDK in its entirety is outside 
their scope - even if they should care about that IMO.
   
   Anyway, my bad for having trusted their changelog and not having retested 
_everything_ on a clean slate :)
   Fortunately there's CI for that, though.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] boards/arm/rp2040: Fix code style and error checking [nuttx]

2025-08-20 Thread via GitHub


nmaggioni commented on PR #16869:
URL: https://github.com/apache/nuttx/pull/16869#issuecomment-3205977892

   @cederom Care to try #16876? The fix was simple enough but, as you said, the 
upstream did not mark it as a breaking change (...?).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] tools/rp{2040,23xx}: Ensure that picotool is found or built [nuttx]

2025-08-20 Thread via GitHub


nmaggioni commented on PR #16855:
URL: https://github.com/apache/nuttx/pull/16855#issuecomment-3206017032

   I'll rebase on top of #16876 when possible, that should fix CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] arch/arm/rp2040: Support pico-sdk 2.2.0 [nuttx]

2025-08-20 Thread via GitHub


simbit18 commented on PR #16876:
URL: https://github.com/apache/nuttx/pull/16876#issuecomment-3206094541

   Hi @cederom, can you test it with a Raspberry Pi board??


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] boards/esp32s3: Add SPI slave device support [nuttx]

2025-08-20 Thread via GitHub


fdcavalcanti commented on PR #16866:
URL: https://github.com/apache/nuttx/pull/16866#issuecomment-3206225833

   Please resolve the changes requested and we can approve. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] boards/esp32s3: Add SPI slave device support [nuttx]

2025-08-20 Thread via GitHub


thiagofinelon commented on PR #16866:
URL: https://github.com/apache/nuttx/pull/16866#issuecomment-3206363009

   @acassis Do I need to add a board config for spi slave ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] boards/esp32s3: Add SPI slave device support [nuttx]

2025-08-20 Thread via GitHub


thiagofinelon commented on PR #16866:
URL: https://github.com/apache/nuttx/pull/16866#issuecomment-3206699668

   @acassis Just added the board config and a spislv section to esp32s3 devkit 
documentation


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] arch: Add Cmake build support for raspberrypi-4b board & bcm2711 chip [nuttx]

2025-08-20 Thread via GitHub


wangchdo opened a new pull request, #16872:
URL: https://github.com/apache/nuttx/pull/16872

   Add:
   arch/arm64/src/bcm2711/CMakeLists.txt
   boards/arm64/bcm2711/raspberrypi-4b/CMakeLists.txt 
   boards/arm64/bcm2711/raspberrypi-4b/src/CMakeLists.txt
   
   Change-Id: Ie721a65e5d52d76ae7a79547a208e2f1fe5d6766
   
   *Note: Please adhere to [Contributing 
Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).*
   
   ## Summary
   
   provide chip bcm2711 and board raspberrypi-4b with Cmake build capability
   
   ## Impact
   
   people can enjoy Cmake when building nuttx  raspberrypi-4b  image
   
   ## Testing
   
   cmake build pass log:
   
   ```
   [ 99%] Building C object 
apps/testing/ostest/CMakeFiles/apps_ostest.dir/timedmqueue.c.obj
   [ 99%] Building C object 
apps/testing/ostest/CMakeFiles/apps_ostest.dir/posixtimer.c.obj
   [ 99%] Building C object 
apps/testing/ostest/CMakeFiles/apps_ostest.dir/vfork.c.obj
   [ 99%] Building C object 
apps/testing/ostest/CMakeFiles/apps_ostest.dir/wdog.c.obj
   [ 99%] Linking C static library libapps_ostest.a
   [ 99%] Built target apps_ostest
   [ 99%] Building C object 
apps/testing/sched/getprime/CMakeFiles/apps_getprime.dir/getprime_main.c.obj
   [ 99%] Linking C static library libapps_getprime.a
   [ 99%] Built target apps_getprime
   [ 99%] Building C object 
apps/examples/hello/CMakeFiles/apps_hello.dir/hello_main.c.obj
   [ 99%] Linking C static library libapps_hello.a
   [ 99%] Built target apps_hello
   [ 99%] Building C object 
apps/examples/leds/CMakeFiles/apps_leds.dir/leds_main.c.obj
   [ 99%] Linking C static library libapps_leds.a
   [ 99%] Built target apps_leds
   [ 99%] Building CXX object CMakeFiles/nuttx.dir/empty.cxx.obj
   [ 99%] Linking CXX executable nuttx
   Memory region Used Size  Region Size  %age Used
   [ 99%] Built target nuttx
   [ 99%] Generating nuttx.hex
   [ 99%] Built target nuttx-hex
   [ 99%] Generating nuttx.bin
   [ 99%] Built target nuttx-bin
   [100%] Generating System.map
   [100%] Built target systemma
   
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] boards/esp32s3: Add SPI slave device support [nuttx]

2025-08-20 Thread via GitHub


thiagofinelon commented on code in PR #16866:
URL: https://github.com/apache/nuttx/pull/16866#discussion_r2288061322


##
boards/xtensa/esp32s3/common/src/esp32s3_board_spislavedev.c:
##
@@ -32,7 +32,7 @@
 
 #include 
 
-#include "esp32s3_board_spislavedev.h"
+#include "esp32s3_spi.h"

Review Comment:
   i changed by mistake



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] drivers/analog/ads7046: Add support for ADS7046 ADC [nuttx]

2025-08-20 Thread via GitHub


nmaggioni commented on PR #16836:
URL: https://github.com/apache/nuttx/pull/16836#issuecomment-3205511986

   @acassis Rebased, refreshed, tested :+1: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] boards/arm/rp2040: Fix code style and error checking [nuttx]

2025-08-20 Thread via GitHub


simbit18 commented on PR #16869:
URL: https://github.com/apache/nuttx/pull/16869#issuecomment-3205678617

   There are errors in Linux (arm-06)
   
   
https://github.com/apache/nuttx/actions/runs/17084057983/job/48447096636#logs`
   
   
   ``
   

   Configuration/Tool: 
raspberrypi-pico-w/nsh-flash,CONFIG_ARM_TOOLCHAIN_GNU_EABI
   2025-08-20 00:22:32
   

 Cleaning...
 Configuring...
 Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
 Enabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
 Building NuttX...
   In file included from 
/tools/pico-sdk/src/common/pico_base_headers/include/pico.h:64,
from 
/tools/pico-sdk/src/rp2040/pico_platform/include/pico/asm_helper.S:7,
from 
/tools/pico-sdk/src/rp2040/boot_stage2/boot2_w25q080.S:29:
   /tools/pico-sdk/src/rp2040/pico_platform/include/pico/platform.h:26:10: 
fatal error: pico/platform/common.h: No such file or directory
  26 | #include "pico/platform/common.h"
 |  ^~~~
   compilation terminated.
   make[2]: *** [chip/boot2/Make.defs:56: rp2040_boot_stage2.elf] Error 1
   make[2]: Target 'makedepfile' not remade because of errors.
   make[1]: *** [Makefile:261: .depend] Error 2
   make[1]: Target 'depend' not remade because of errors.
   make: *** [tools/Unix.mk:660: pass2dep] Error 2
   make: Target 'all' not remade because of errors.
   /github/workspace/sources/nuttx/tools/testbuild.sh: line 385: 
/github/workspace/sources/nuttx/../nuttx/nuttx.manifest: No such file or 
directory
 [1/1] Normalize raspberrypi-pico-w/nsh-flash
   

   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] boards/arm/rp2040: Fix code style and error checking [nuttx]

2025-08-20 Thread via GitHub


cederom commented on PR #16869:
URL: https://github.com/apache/nuttx/pull/16869#issuecomment-3205877955

   * This CI build comes from pico-sdk version 2.2.0. I had exactly the same 
problem in local build, so had to revert pico-sdk to version 2.1.0.
   * https://github.com/apache/nuttx/pull/16862 adds local fetch of pico-sdk 
2.2.0 to CI to help with builds, but 2.2.0 breaks self-compatibility in a minor 
release :D :D :D 
   * thus my push for avoiding and clearly marking breaking changes :-)
   * external SDKs are s sweet :-) this is why we avoid it here in NuttX :-)
   * although this sdk issue is not related with this specific PR, rather a 
result, we should fix that probably before merging this PR, and use this PR as 
testbench to verify build? :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] drivers/can/kvaser_pci: configure number of passes in interrupt handler [nuttx]

2025-08-20 Thread via GitHub


szafonimateusz-mi opened a new pull request, #16875:
URL: https://github.com/apache/nuttx/pull/16875

   ## Summary
   
   Configure number of passes in interrupt handler logic to avoid losing RX 
frames in QEMU environment.
   
   ## Impact
   
   Fixes the problem with lost frames when flooding the CAN network with 
messages.
   
   ## Testing
   
   qemu-x86_64
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] drivers/can/kvaser_pci: configure number of passes in interrupt handler [nuttx]

2025-08-20 Thread via GitHub


acassis commented on code in PR #16875:
URL: https://github.com/apache/nuttx/pull/16875#discussion_r2288092863


##
drivers/can/Kconfig:
##
@@ -273,6 +273,15 @@ config CAN_KVASER
 
 if CAN_KVASER
 
+config CAN_KVASER_IRQ_PASSES
+   int "Kvaser PCI interrupt passes"
+   default 16

Review Comment:
   Please include a range here, if the user pass a zeroed or negative value the 
"for" loop will run "forever" (until overflow)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] drivers/leds/CMakeLists.txt: Aligned Cmake with Make [nuttx]

2025-08-20 Thread via GitHub


simbit18 opened a new pull request, #16871:
URL: https://github.com/apache/nuttx/pull/16871

   ## Summary
   
   Add KTD2052 led driver
   
   #16217
   
   ## Impact
   
   Impact on user: NO
   
   Impact on build: This PR Aligned Cmake with Make
   
   Impact on hardware: NO
   
   Impact on documentation: NO
   
   Impact on security: NO
   
   Impact on compatibility: NO
   
   ## Testing
   
   locally
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] arch: Add Cmake build support for raspberrypi-4b board & bcm2711 chip [nuttx]

2025-08-20 Thread via GitHub


xiaoxiang781216 commented on PR #16872:
URL: https://github.com/apache/nuttx/pull/16872#issuecomment-3205295959

   please remove Change-Id from commit message.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] boards/arm/rp2040: Fix code style and error checking [nuttx]

2025-08-20 Thread via GitHub


hartmannathan commented on code in PR #16869:
URL: https://github.com/apache/nuttx/pull/16869#discussion_r2288637970


##
boards/arm/rp2040/common/src/rp2040_common_bringup.c:
##
@@ -546,43 +554,72 @@ int rp2040_common_bringup(void)
 
   /* Try to register SHT4X device on I2C0 */
 
-  ret = sht4x_register(rp2040_i2cbus_initialize(0), 0,
-   CONFIG_SHT4X_I2C_ADDR);
-  if (ret < 0)
+  i2c = rp2040_i2cbus_initialize(0);
+  if (i2c == NULL)
 {
-  syslog(LOG_ERR, "ERROR: couldn't initialize SHT4x: %d\n", ret);
+  syslog(LOG_ERR, "ERROR: failed to initialize I2C0\n");
+}
+  else
+{
+  ret = sht4x_register(i2c, 0, CONFIG_SHT4X_I2C_ADDR);
+  if (ret < 0)
+{
+  syslog(LOG_ERR, "ERROR: couldn't initialize SHT4x: %d\n", ret);
+}
 }
 #endif
 
 #ifdef CONFIG_SENSORS_MCP9600
   /* Try to register MCP9600 device as /dev/therm0 at I2C0. */
 
-  ret = mcp9600_register(rp2040_i2cbus_initialize(0), 0x60, 1, 2, 3);
-  if (ret < 0)
+  i2c = rp2040_i2cbus_initialize(0);

Review Comment:
   What happens if `CONFIG_SENSORS_SHT4X` and i2c is already initialized?



##
boards/arm/rp2040/common/src/rp2040_common_bringup.c:
##
@@ -546,43 +554,72 @@ int rp2040_common_bringup(void)
 
   /* Try to register SHT4X device on I2C0 */
 
-  ret = sht4x_register(rp2040_i2cbus_initialize(0), 0,
-   CONFIG_SHT4X_I2C_ADDR);
-  if (ret < 0)
+  i2c = rp2040_i2cbus_initialize(0);
+  if (i2c == NULL)
 {
-  syslog(LOG_ERR, "ERROR: couldn't initialize SHT4x: %d\n", ret);
+  syslog(LOG_ERR, "ERROR: failed to initialize I2C0\n");
+}
+  else
+{
+  ret = sht4x_register(i2c, 0, CONFIG_SHT4X_I2C_ADDR);
+  if (ret < 0)
+{
+  syslog(LOG_ERR, "ERROR: couldn't initialize SHT4x: %d\n", ret);
+}
 }
 #endif
 
 #ifdef CONFIG_SENSORS_MCP9600
   /* Try to register MCP9600 device as /dev/therm0 at I2C0. */
 
-  ret = mcp9600_register(rp2040_i2cbus_initialize(0), 0x60, 1, 2, 3);
-  if (ret < 0)
+  i2c = rp2040_i2cbus_initialize(0);
+  if (i2c == NULL)
 {
-  syslog(LOG_ERR, "ERROR: couldn't initialize MCP9600: %d\n", ret);
+  syslog(LOG_ERR, "ERROR: failed to initialize I2C0\n");
+}
+  else
+{
+  ret = mcp9600_register(i2c, 0x60, 1, 2, 3);
+  if (ret < 0)
+{
+  syslog(LOG_ERR, "ERROR: couldn't initialize MCP9600: %d\n", ret);
+}
 }
 #endif
 
 #ifdef CONFIG_SENSORS_MS56XX
   /* Try to register MS56xx device at I2C0 */
 
-  ret = ms56xx_register(rp2040_i2cbus_initialize(0), 0, MS56XX_ADDR0,
-MS56XX_MODEL_MS5611);
-  if (ret < 0)
+  i2c = rp2040_i2cbus_initialize(0);

Review Comment:
   Ditto, what happens if `CONFIG_SENSORS_SHT4X` and/or 
`CONFIG_SENSORS_MCP9600` and i2c is already initialized?



##
boards/arm/rp2040/common/src/rp2040_common_bringup.c:
##
@@ -546,43 +554,72 @@ int rp2040_common_bringup(void)
 
   /* Try to register SHT4X device on I2C0 */
 
-  ret = sht4x_register(rp2040_i2cbus_initialize(0), 0,
-   CONFIG_SHT4X_I2C_ADDR);
-  if (ret < 0)
+  i2c = rp2040_i2cbus_initialize(0);
+  if (i2c == NULL)
 {
-  syslog(LOG_ERR, "ERROR: couldn't initialize SHT4x: %d\n", ret);
+  syslog(LOG_ERR, "ERROR: failed to initialize I2C0\n");
+}
+  else
+{
+  ret = sht4x_register(i2c, 0, CONFIG_SHT4X_I2C_ADDR);
+  if (ret < 0)
+{
+  syslog(LOG_ERR, "ERROR: couldn't initialize SHT4x: %d\n", ret);
+}
 }
 #endif
 
 #ifdef CONFIG_SENSORS_MCP9600
   /* Try to register MCP9600 device as /dev/therm0 at I2C0. */
 
-  ret = mcp9600_register(rp2040_i2cbus_initialize(0), 0x60, 1, 2, 3);
-  if (ret < 0)
+  i2c = rp2040_i2cbus_initialize(0);
+  if (i2c == NULL)
 {
-  syslog(LOG_ERR, "ERROR: couldn't initialize MCP9600: %d\n", ret);
+  syslog(LOG_ERR, "ERROR: failed to initialize I2C0\n");
+}
+  else
+{
+  ret = mcp9600_register(i2c, 0x60, 1, 2, 3);
+  if (ret < 0)
+{
+  syslog(LOG_ERR, "ERROR: couldn't initialize MCP9600: %d\n", ret);
+}
 }
 #endif
 
 #ifdef CONFIG_SENSORS_MS56XX
   /* Try to register MS56xx device at I2C0 */
 
-  ret = ms56xx_register(rp2040_i2cbus_initialize(0), 0, MS56XX_ADDR0,
-MS56XX_MODEL_MS5611);
-  if (ret < 0)
+  i2c = rp2040_i2cbus_initialize(0);
+  if (i2c == NULL)
 {
-syslog(LOG_ERR, "ERROR: couldn't register MS5611: %d\n", ret);
+  syslog(LOG_ERR, "ERROR: failed to initialize I2C0\n");
+}
+  else
+{
+  ret = ms56xx_register(i2c, 0, MS56XX_ADDR0, MS56XX_MODEL_MS5611);
+  if (ret < 0)
+{
+  syslog(LOG_ERR, "ERROR: couldn't register MS5611: %d\n", ret);
+}
 }
 #endif
 
 #ifdef CONFIG_SENSORS_TMP112
   /* Try to register TMP112 device at I2C0 with a common address */
 
-  ret = board_tmp112_initialize(rp2040_i2cbus_initialize(0), 0,
-TMP112_ADD

Re: [PR] arch/arm/rp2040: Support pico-sdk 2.2.0 [nuttx]

2025-08-20 Thread via GitHub


cederom commented on PR #16876:
URL: https://github.com/apache/nuttx/pull/16876#issuecomment-3207029644

   Uhm, Im soldering some stuff right now, sorry for the delay @simbit18, will 
confirm in a free moment on the actual hardware, thanks @nmaggioni for the 
fixes!! :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] boards/arm/rp2040: Fix code style and error checking [nuttx]

2025-08-20 Thread via GitHub


cederom commented on PR #16869:
URL: https://github.com/apache/nuttx/pull/16869#issuecomment-3207035682

   As https://github.com/apache/nuttx/pull/16876 is merged lets see how this CI 
builds now :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] drivers/audio/CMakeLists.txt: Aligned Cmake with Make [nuttx]

2025-08-20 Thread via GitHub


simbit18 opened a new pull request, #16870:
URL: https://github.com/apache/nuttx/pull/16870

   ## Summary
   
   Add fake audio driver
   
   https://github.com/apache/nuttx/pull/15295
   
   ## Impact
   
   Impact on user: NO
   
   Impact on build: This PR Aligned Cmake with Make
   
   Impact on hardware: NO
   
   Impact on documentation: NO
   
   Impact on security: NO
   
   Impact on compatibility: NO
   
   ## Testing
   
   locally
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] boards/arm/rp2040: Fix code style and error checking [nuttx]

2025-08-20 Thread via GitHub


cederom commented on code in PR #16869:
URL: https://github.com/apache/nuttx/pull/16869#discussion_r2287916101


##
boards/arm/rp2040/common/src/rp2040_common_bringup.c:
##
@@ -478,17 +482,21 @@ int rp2040_common_bringup(void)
 {
   syslog(LOG_ERR, "Failed to initialize SPI bus 0\n");
 }
-
-  struct adc_dev_s *mcp3008 = mcp3008_initialize(spi);
-  if (mcp3008 == NULL)
-{
-  syslog(LOG_ERR, "Failed to initialize MCP3008\n");
-}
-
-  ret = adc_register("/dev/adc1", mcp3008);
-  if (ret < 0)
+  else
 {
-  syslog(LOG_ERR, "Failed to register MCP3008 device driver: %d\n", ret);
+  struct adc_dev_s *mcp3008 = mcp3008_initialize(spi);

Review Comment:
   this actually may be a good idea to remove external ic specific code from 
common rp2040 initialization code.. users may want to add it to their 
application :-)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] boards/esp32s3: Add SPI slave device support [nuttx]

2025-08-20 Thread via GitHub


thiagofinelon commented on code in PR #16866:
URL: https://github.com/apache/nuttx/pull/16866#discussion_r2288065801


##
boards/xtensa/esp32s3/common/src/Make.defs:
##
@@ -36,9 +36,10 @@ endif
 
 ifeq ($(CONFIG_SPI_DRIVER),y)
   CSRCS += esp32s3_board_spidev.c
-  ifeq ($(CONFIG_SPI_SLAVE_DRIVER),y)
-CSRCS += esp32s3_board_spislavedev.c
-  endif
+endif
+
+ifeq ($(CONFIG_SPI_SLAVE_DRIVER),y)
+  CSRCS += esp32s3_board_spislavedev.c

Review Comment:
   I did organized the patch



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(nuttx) 02/03: Documentation/platforms/rp2040: Update the docs for pico-sdk 2.2.0

2025-08-20 Thread acassis
This is an automated email from the ASF dual-hosted git repository.

acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git

commit a6b8210580bf62299fc60648f072a9434578140e
Author: Niccolò Maggioni 
AuthorDate: Wed Aug 20 13:22:48 2025 +0200

Documentation/platforms/rp2040: Update the docs for pico-sdk 2.2.0

Bump the version referenced in the commmands and add some tips.

Signed-off-by: Niccolò Maggioni 
---
 Documentation/platforms/arm/rp2040/index.rst | 39 
 1 file changed, 22 insertions(+), 17 deletions(-)

diff --git a/Documentation/platforms/arm/rp2040/index.rst 
b/Documentation/platforms/arm/rp2040/index.rst
index bfbd4371e05..25dc7df4af1 100644
--- a/Documentation/platforms/arm/rp2040/index.rst
+++ b/Documentation/platforms/arm/rp2040/index.rst
@@ -21,14 +21,14 @@ Peripheral Notes
 == =
 GPIO   See Supported Boards documentation for available pins.
 UART   GPIO 0 (UART0 TX) and GPIO 1 (UART0 RX) are often used for the 
console.
-I2C
-SPI 
-DMAC
-PWM 
-USB 
+I2C
+SPI
+DMAC
+PWM
+USB
 PIORP2040 Programmable I/O
-IRQs
-DMA 
+IRQs
+DMA
 Clock Output
 ws2812 Smart pixels (e.g. Neopixel)
 Flash ROM Boot
@@ -37,7 +37,7 @@ BMP180 Requires I2C0
 INA219 Requires I2C0
 == =
 
-The Pico Display Pack (ST7789 LCD) and Pico Audio Pack (PCM5100A I2S DAC) are 
+The Pico Display Pack (ST7789 LCD) and Pico Audio Pack (PCM5100A I2S DAC) are
 also available.
 
 There is currently no direct user mode access to these RP2040 hardware 
features:
@@ -59,16 +59,20 @@ Installation
 1. Download the Raspberry Pi Pico SDK:
 
.. code:: console
-   
-  $ git clone -b 2.0.0 https://github.com/raspberrypi/pico-sdk.git
 
-2. Download and install the ``picotool``
+  $ git clone -b 2.2.0 --recurse-submodules 
https://github.com/raspberrypi/pico-sdk.git
 
-   Instructions for installing/building it can be found here:
-   https://github.com/raspberrypi/picotool
+2. Download and install ``picotool``
 
-   If you are on Arch Linux, you can also install the ``picotool`` through the
-   AUR:
+   .. note::
+
+  If not found at build time, this tool will also be automatically compiled
+  from the SDK sources. Manually downloading or compiling it is
+  `preferred `__, 
though.
+
+   Instructions can be found here: https://github.com/raspberrypi/picotool
+
+   If you are on Arch Linux, you can also install ``picotool`` through the AUR:
 
.. code-block:: console
 
@@ -83,12 +87,13 @@ Installation
You will have to do this every time you restart the terminal where you are
building NuttX, so it might be best to include this command in your
``bashrc`` so NuttX's build system always knows where to find the SDK.
+   You may also want to look into tools like `direnv `__.
 
 4. Download NuttX and NuttX applications. These must both be contained in the
same directory:
 
.. code:: console
-  
+
   $ git clone https://github.com/apache/nuttx.git nuttx
   $ git clone https://github.com/apache/nuttx-apps.git apps
 
@@ -130,7 +135,7 @@ Building NuttX
 5. Build NuttX:
 
.. code:: console
- 
+
   $ make
 
 The output of the build process will be a file called ``nuttx.uf2``, which you



(nuttx) 03/03: Documentation/platforms/rp2350: Update the docs for pico-sdk 2.2.0

2025-08-20 Thread acassis
This is an automated email from the ASF dual-hosted git repository.

acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git

commit 06cc058b61d0de240d901ac5b38f0c634adc7544
Author: Niccolò Maggioni 
AuthorDate: Wed Aug 20 13:53:02 2025 +0200

Documentation/platforms/rp2350: Update the docs for pico-sdk 2.2.0

Bump the version referenced in the commmands and add some tips.

Signed-off-by: Niccolò Maggioni 
---
 .../arm/rp23xx/boards/raspberrypi-pico-2/index.rst | 18 --
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git 
a/Documentation/platforms/arm/rp23xx/boards/raspberrypi-pico-2/index.rst 
b/Documentation/platforms/arm/rp23xx/boards/raspberrypi-pico-2/index.rst
index 6c67bb3f9c7..403390c8cb5 100644
--- a/Documentation/platforms/arm/rp23xx/boards/raspberrypi-pico-2/index.rst
+++ b/Documentation/platforms/arm/rp23xx/boards/raspberrypi-pico-2/index.rst
@@ -164,17 +164,23 @@ Installation
 
 .. code-block:: console
 
-  $ git clone -b 2.1.1 https://github.com/raspberrypi/pico-sdk.git
+  $ git clone -b 2.2.0 --recurse-submodules 
https://github.com/raspberrypi/pico-sdk.git
 
-2. Download and install picotool
+2. Download and install ``picotool``
 
-  Instructions can be found here: https://github.com/raspberrypi/picotool
+   .. note::
 
-  If you are on Arch Linux, you can install the picotool through the AUR:
+  If not found at build time, this tool will also be automatically compiled
+  from the SDK sources. Manually downloading or compiling it is
+  `preferred `__, 
though.
 
-.. code-block:: console
+   Instructions can be found here: https://github.com/raspberrypi/picotool
+
+   If you are on Arch Linux, you can also install ``picotool`` through the AUR:
+
+   .. code-block:: console
 
-  $ yay -S picotool
+  $ yay -S picotool
 
 3. Set PICO_SDK_PATH environment variable
 



(nuttx) branch master updated (0dbbce3a8fe -> 06cc058b61d)

2025-08-20 Thread acassis
This is an automated email from the ASF dual-hosted git repository.

acassis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


from 0dbbce3a8fe sched: Remove unnecessary affinity restriction & 
restoration over smp calls
 new 093f4d36887 arch/arm/rp2040: Update include paths for pico-sdk 2.2.0
 new a6b8210580b Documentation/platforms/rp2040: Update the docs for 
pico-sdk 2.2.0
 new 06cc058b61d Documentation/platforms/rp2350: Update the docs for 
pico-sdk 2.2.0

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 Documentation/platforms/arm/rp2040/index.rst   | 39 --
 .../arm/rp23xx/boards/raspberrypi-pico-2/index.rst | 18 ++
 arch/arm/src/rp2040/boot2/Make.defs|  3 +-
 3 files changed, 36 insertions(+), 24 deletions(-)



Re: [PR] arch/arm/rp2040: Support pico-sdk 2.2.0 [nuttx]

2025-08-20 Thread via GitHub


acassis merged PR #16876:
URL: https://github.com/apache/nuttx/pull/16876


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(nuttx) 01/03: arch/arm/rp2040: Update include paths for pico-sdk 2.2.0

2025-08-20 Thread acassis
This is an automated email from the ASF dual-hosted git repository.

acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git

commit 093f4d368874a19f2be0ce42ffa1224235decf2f
Author: Niccolò Maggioni 
AuthorDate: Wed Aug 20 13:19:05 2025 +0200

arch/arm/rp2040: Update include paths for pico-sdk 2.2.0

Version 2.2.0 of the SDK unified some headers under a new path.
Now both the old and the new paths are searched during compilation.

Signed-off-by: Niccolò Maggioni 
---
 arch/arm/src/rp2040/boot2/Make.defs | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/src/rp2040/boot2/Make.defs 
b/arch/arm/src/rp2040/boot2/Make.defs
index 9787cf8901e..2e37d119ebd 100644
--- a/arch/arm/src/rp2040/boot2/Make.defs
+++ b/arch/arm/src/rp2040/boot2/Make.defs
@@ -39,7 +39,8 @@ BOOT2CFLAGS += 
-I$(PICO_SDK_PATH)/src/rp2040/hardware_regs/include
 BOOT2CFLAGS += -I$(PICO_SDK_PATH)/src/rp2_common/hardware_base/include
 BOOT2CFLAGS += -I$(PICO_SDK_PATH)/src/common/pico_base_headers/include
 BOOT2CFLAGS += -I$(PICO_SDK_PATH)/src/boards/include
-BOOT2CFLAGS += -I$(PICO_SDK_PATH)/src/rp2040/pico_platform/include
+BOOT2CFLAGS += -I$(PICO_SDK_PATH)/src/rp2040/pico_platform/include 
# pico-sdk <2.2.0
+BOOT2CFLAGS += -I$(PICO_SDK_PATH)/src/rp2_common/pico_platform_common/include  
# pico-sdk >=2.2.0
 BOOT2CFLAGS += -I$(PICO_SDK_PATH)/src/rp2_common/pico_platform_compiler/include
 BOOT2CFLAGS += -I$(PICO_SDK_PATH)/src/rp2_common/pico_platform_sections/include
 BOOT2CFLAGS += -I$(PICO_SDK_PATH)/src/rp2_common/pico_platform_panic/include



[PR] Documentation/xedge_demo: Fix RST formatting issues [nuttx]

2025-08-20 Thread via GitHub


JorgeGzm opened a new pull request, #16877:
URL: https://github.com/apache/nuttx/pull/16877

   ## Summary
   
   Fixed RST (reStructuredText) formatting issues in xedge_demo documentation 
   
   ## Impact
   
   Fixes broken formatting that was affecting the visual presentation of the 
docs
   
   ## Testing
   
   Verified if RST syntax is valid and follows formatting rules
   
   ```bash
   ~/nuttxspace/nuttx$ ./tools/checkpatch.sh -g HEAD~...HEAD
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] include/nuttx/compiler.h: [nuttx]

2025-08-20 Thread via GitHub


xiaoxiang781216 commented on code in PR #16879:
URL: https://github.com/apache/nuttx/pull/16879#discussion_r2289689918


##
include/nuttx/compiler.h:
##
@@ -268,7 +268,7 @@
 
 /* The nooptimiziation_function attribute no optimize */
 
-#  if defined(__clang__)
+#  if defined(__clang__) || defined (CONFIG_TRICORE_TOOLCHAIN_GNU)

Review Comment:
   ```suggestion
   #  if defined(__clang__) || defined(CONFIG_TRICORE_TOOLCHAIN_GNU)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] arch: Add Cmake build support for raspberrypi-4b board & bcm2711 chip [nuttx]

2025-08-20 Thread via GitHub


wangchdo closed pull request #16872: arch: Add Cmake build support for 
raspberrypi-4b board & bcm2711 chip
URL: https://github.com/apache/nuttx/pull/16872


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] arch: Add Cmake build support for raspberrypi-4b board & bcm2711 chip [nuttx]

2025-08-20 Thread via GitHub


wangchdo opened a new pull request, #16880:
URL: https://github.com/apache/nuttx/pull/16880

   closed previous pull request and just reopen this new pull request
   
   Add:
   arch/arm64/src/bcm2711/CMakeLists.txt
   boards/arm64/bcm2711/raspberrypi-4b/CMakeLists.txt 
boards/arm64/bcm2711/raspberrypi-4b/src/CMakeLists.txt
   
   *Note: Please adhere to [Contributing 
Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).*
   
   ## Summary
   
   add cmake build support for bcm2711 chip and raspberrypi-4b board
   
   ## Impact
   
   people can enjoy cmake build for raspberrypi-4b board
   
   ## Testing
   
   **cmake build pass log:**
   
   ```
   [ 97%] Building C object libs/libc/CMakeFiles/c.dir/wchar/lib_mbsrtowcs.c.obj
   [ 97%] Building C object libs/libc/CMakeFiles/c.dir/wchar/lib_mbsinit.c.obj
   [ 97%] Building C object libs/libc/CMakeFiles/c.dir/wchar/lib_wcsrtombs.c.obj
   [ 97%] Building C object libs/libc/CMakeFiles/c.dir/wchar/lib_wcscpy.c.obj
   [ 97%] Building C object libs/libc/CMakeFiles/c.dir/wchar/lib_wcscat.c.obj
   [ 97%] Building C object libs/libc/CMakeFiles/c.dir/wchar/lib_wcslcat.c.obj
   [ 97%] Building C object libs/libc/CMakeFiles/c.dir/wchar/lib_wcsncat.c.obj
   [ 97%] Building C object libs/libc/CMakeFiles/c.dir/wchar/lib_wcsrchr.c.obj
   [ 98%] Building C object libs/libc/CMakeFiles/c.dir/wchar/lib_wcschr.c.obj
   [ 98%] Building C object libs/libc/CMakeFiles/c.dir/wchar/lib_wcsncpy.c.obj
   [ 98%] Building C object libs/libc/CMakeFiles/c.dir/wchar/lib_wcsncmp.c.obj
   [ 98%] Building C object libs/libc/CMakeFiles/c.dir/wchar/lib_wcscspn.c.obj
   [ 98%] Building C object libs/libc/CMakeFiles/c.dir/wchar/lib_wcspbrk.c.obj
   [ 98%] Building C object libs/libc/CMakeFiles/c.dir/wchar/lib_wcsspn.c.obj
   [ 98%] Building C object libs/libc/CMakeFiles/c.dir/wchar/lib_wcsstr.c.obj
   [ 98%] Building C object libs/libc/CMakeFiles/c.dir/wchar/lib_wcswcs.c.obj
   [ 98%] Building C object libs/libc/CMakeFiles/c.dir/wchar/lib_wcstok.c.obj
   [ 98%] Building C object libs/libc/CMakeFiles/c.dir/wchar/lib_wcwidth.c.obj
   [ 98%] Building C object libs/libc/CMakeFiles/c.dir/wchar/lib_wcswidth.c.obj
   [ 98%] Building C object libs/libc/CMakeFiles/c.dir/wctype/lib_wctype.c.obj
   [ 99%] Building C object libs/libc/CMakeFiles/c.dir/wctype/lib_iswctype.c.obj
   [ 99%] Building C object libs/libc/CMakeFiles/c.dir/wctype/lib_towlower.c.obj
   [ 99%] Building C object libs/libc/CMakeFiles/c.dir/wctype/lib_towupper.c.obj
   [ 99%] Linking C static library libc.a
   [ 99%] Built target c
   [ 99%] Building CXX object CMakeFiles/nuttx.dir/empty.cxx.obj
   [ 99%] Linking CXX executable nuttx
   Memory region Used Size  Region Size  %age Used
   [ 99%] Built target nuttx
   [ 99%] Generating nuttx.hex
   [ 99%] Generating nuttx.bin
   [100%] Generating System.map
   [100%] Built target nuttx-bin
   [100%] Built target nuttx-hex
   [100%] Built target systemmap
   ```
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] arch/xtensa/esp32s3: Add EXT1 wakeup support in power management [nuttx]

2025-08-20 Thread via GitHub


thiagofinelon opened a new pull request, #16878:
URL: https://github.com/apache/nuttx/pull/16878

   ## Summary
   
   This PR adds **EXT1 wakeup support** to the ESP32-S3 power management
   subsystem.  
   It enables the ESP32-S3 to wake from **PM_STANDBY** or **PM_SLEEP** using
   one or more RTC GPIOs as external wakeup sources.
   
   Changes include:
   - EXT1 wakeup configuration and preparation logic added to `esp32s3_rtc.c`.
   - Integrated EXT1 handling into `esp32s3_pm.c` (`pmstandby()` and 
`pmsleep()`).
   - New **board-level Kconfig options** exposed under ESP32-S3 DevKit menu:
 - `CONFIG_PM_EXT1_WAKEUP`: enable EXT1 wakeup support
 - `CONFIG_PM_EXT1_WAKEUP_RTC_GPIO`: select RTC GPIOs as EXT1 wake 
sources
 - `CONFIG_PM_EXT1_WAKEUP_TRIGGER_MODE`: choose wakeup on HIGH or LOW level
   
   This is the first external wakeup method supported by ESP32-S3 PM
   (EXT0 is not implemented in this port).
   
   ## Impact
   
   - **Build impact**: None unless `CONFIG_PM_EXT1_WAKEUP` is enabled.  
   - **Runtime impact**: When enabled, ESP32-S3 can wake from light or deep 
sleep
 on external RTC GPIO triggers.  
   - **API impact**: No new public API; configuration is managed via board 
Kconfig.  
   - **Area impacted**: ESP32-S3 PM subsystem and board configuration menus.  
   
   ## Testing
   
   - Built with `xtensa-esp32s3-elf-gcc` toolchain on Linux host.  
   - Verified build passes with and without `CONFIG_PM_EXT1_WAKEUP` enabled.  
   - Tested on ESP32-S3 DevKit:  
 - Enabled `PM EXT1 Wakeup` in board Kconfig.  
 - Configured GPIO4 and GPIO5 as EXT1 wake sources.  
 - Entered light sleep, confirmed wakeup on GPIO trigger.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] arch/arm/rp2040: Support pico-sdk 2.2.0 [nuttx]

2025-08-20 Thread via GitHub


cederom commented on PR #16876:
URL: https://github.com/apache/nuttx/pull/16876#issuecomment-3208104235

   Yup, builds and works fine now on pico-sdk 2.2.0 and real hardware, built 
git master already :-)
   
   ```
   % git -C $PICO_SDK_PATH branch
   * (HEAD detached at 2.2.0)
 master
   hexagon% ./tools/configure.sh -B  raspberrypi-pico:usbnsh
 Copy files
 Select CONFIG_HOST_BSD=y
 Refreshing...
   CP: arch/dummy/Kconfig to /tmp/nuttx/nuttx/arch/dummy/dummy_kconfig
   CP: boards/dummy/Kconfig to /tmp/nuttx/nuttx/boards/dummy/dummy_kconfig
   LN: platform/board to /tmp/nuttx/nuttx-apps/platform/dummy
   LN: include/arch to arch/arm/include
   LN: include/arch/board to 
/tmp/nuttx/nuttx/boards/arm/rp2040/raspberrypi-pico/include
   LN: drivers/platform to /tmp/nuttx/nuttx/drivers/dummy
   LN: include/arch/chip to /tmp/nuttx/nuttx/arch/arm/include/rp2040
   LN: arch/arm/src/chip to /tmp/nuttx/nuttx/arch/arm/src/rp2040
   LN: arch/arm/src/board to 
/tmp/nuttx/nuttx/boards/arm/rp2040/raspberrypi-pico/../common
   LN: arch/arm/src/board/board to 
/tmp/nuttx/nuttx/boards/arm/rp2040/raspberrypi-pico/src
   mkkconfig in /tmp/nuttx/nuttx-apps/audioutils
   mkkconfig in /tmp/nuttx/nuttx-apps/benchmarks
   mkkconfig in /tmp/nuttx/nuttx-apps/boot
   mkkconfig in /tmp/nuttx/nuttx-apps/canutils
   mkkconfig in /tmp/nuttx/nuttx-apps/crypto
   mkkconfig in /tmp/nuttx/nuttx-apps/database
   mkkconfig in /tmp/nuttx/nuttx-apps/examples/mcuboot
   mkkconfig in /tmp/nuttx/nuttx-apps/examples/module
   mkkconfig in /tmp/nuttx/nuttx-apps/examples/rust
   mkkconfig in /tmp/nuttx/nuttx-apps/examples/sotest
   mkkconfig in /tmp/nuttx/nuttx-apps/examples
   mkkconfig in /tmp/nuttx/nuttx-apps/fsutils
   mkkconfig in /tmp/nuttx/nuttx-apps/games
   mkkconfig in /tmp/nuttx/nuttx-apps/graphics
   mkkconfig in /tmp/nuttx/nuttx-apps/industry
   mkkconfig in /tmp/nuttx/nuttx-apps/inertial
   mkkconfig in /tmp/nuttx/nuttx-apps/interpreters/luamodules
   mkkconfig in /tmp/nuttx/nuttx-apps/interpreters
   mkkconfig in /tmp/nuttx/nuttx-apps/logging
   mkkconfig in /tmp/nuttx/nuttx-apps/lte
   mkkconfig in /tmp/nuttx/nuttx-apps/math
   mkkconfig in /tmp/nuttx/nuttx-apps/mlearning
   mkkconfig in /tmp/nuttx/nuttx-apps/netutils
   mkkconfig in /tmp/nuttx/nuttx-apps/sdr
   mkkconfig in /tmp/nuttx/nuttx-apps/system
   mkkconfig in /tmp/nuttx/nuttx-apps/tee
   mkkconfig in /tmp/nuttx/nuttx-apps/testing/arch
   mkkconfig in /tmp/nuttx/nuttx-apps/testing/cxx
   mkkconfig in /tmp/nuttx/nuttx-apps/testing/drivers
   mkkconfig in /tmp/nuttx/nuttx-apps/testing/fs
   mkkconfig in /tmp/nuttx/nuttx-apps/testing/libc
   mkkconfig in /tmp/nuttx/nuttx-apps/testing/mm
   mkkconfig in /tmp/nuttx/nuttx-apps/testing/sched
   mkkconfig in /tmp/nuttx/nuttx-apps/testing
   mkkconfig in /tmp/nuttx/nuttx-apps/videoutils
   mkkconfig in /tmp/nuttx/nuttx-apps/wireless/bluetooth
   mkkconfig in /tmp/nuttx/nuttx-apps/wireless/ieee802154
   mkkconfig in /tmp/nuttx/nuttx-apps/wireless
   mkkconfig in /tmp/nuttx/nuttx-apps
   #
   # configuration written to .config
   #
   hexagon% /usr/bin/time -h gmake -j
   Create version.h
   LN: platform/board to /tmp/nuttx/nuttx-apps/platform/dummy
   Register: hello
   Register: dd
   Register: nsh
   Register: sh
   Register: getprime
   Register: ostest
   
/usr/local/gcc-arm-embedded-14.2.rel1/bin/../lib/gcc/arm-none-eabi/14.2.1/../../../../arm-none-eabi/bin/ld:
 warning: rp2040_boot_stage2.elf has a LOAD segment with RWX permissions
   CPP:  
/tmp/nuttx/nuttx/boards/arm/rp2040/raspberrypi-pico/scripts/raspberrypi-pico-flash.ld->
 /tmp/nuttx/nuttx/boards/arm/rp2040/raspberrypi-pico/scripts/raspbLD: nuttx
   Memory region Used Size  Region Size  %age Used
  flash:156 KB 2 MB  7.62%
   sram:8768 B   264 KB  3.24%
   Generating: nuttx.uf2
   Done.
   6,19s real  30,35s user 13,05s sys
   hexagon% picotool load nuttx.uf2
   Loading into Flash:   [==]  100%
   hexagon% picotool reboot
   The device was rebooted into application mode.
   hexagon% cu -l /dev/cuaU0 -s 115200
   Connected
   NuttShell (NSH) NuttX-12.10.0
   sh> uname -a
   NuttX 12.10.0 2713c5e9df Aug 20 2025 23:07:14 arm raspberrypi-pinsh>
   [EOT]
   ```
   
   Also on 2.1.0 that was required before :-)
   
   ```
   % git -C $PICO_SDK_PATH branch
   * (HEAD detached at 2.1.0)
 master
   hexagon% ./tools/configure.sh -B  raspberrypi-pico:usbnsh
 Copy files
 Select CONFIG_HOST_BSD=y
 Refreshing...
   CP: arch/dummy/Kconfig to /tmp/nuttx/nuttx/arch/dummy/dummy_kconfig
   CP: boards/dummy/Kconfig to /tmp/nuttx/nuttx/boards/dummy/dummy_kconfig
   LN: platform/board to /tmp/nuttx/nuttx-apps/platform/dummy
   LN: include/arch to arch/arm/include
   LN: include/arch/board to 
/tmp/nuttx/nuttx/boards/arm/rp2040/raspberrypi-pico/include
   LN: drivers/platform to /tmp/nuttx/nuttx/drivers/dummy
   LN: include/arch/chip to 

Re: [PR] arch: Add Cmake build support for raspberrypi-4b board & bcm2711 chip [nuttx]

2025-08-20 Thread via GitHub


anchao commented on PR #16872:
URL: https://github.com/apache/nuttx/pull/16872#issuecomment-3208643502

   @wangchdo please don't merge branch, rebase is fine, let us discard this 
commit:
   
   https://github.com/user-attachments/assets/b4c3a979-72ec-4331-8c69-a2d1431d82a4";
 />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] include/nuttx/compiler.h: [nuttx]

2025-08-20 Thread via GitHub


wangchdo opened a new pull request, #16879:
URL: https://github.com/apache/nuttx/pull/16879

   include/nuttx/compiler.h:
   fix nooptimiziation_function definition problem for tricore gnu 
compiler
   arch/tricore:
   move tricore_csa2addr and tricore_addr2csa definition from 
include/arch.h to include/irq.h to fix build error
   
   *Note: Please adhere to [Contributing 
Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).*
   
   ## Summary
   change nooptimiziation_function definition in include/nuttx/compiler.h and 
relocate tricore_csa2addr and tricore_addr2csa definition in tricore/arch to 
fix tc397 bord build error
   
   ## Impact
   
fix tc397 bord build error
   
   ## Testing
   
   **before updating include/nuttx/compiler.h:**
   
   ```
   [  5%] Building C object fs/CMakeFiles/fs.dir/procfs/fs_procfstcbinfo.c.obj
   cd /home/lixiang/repos/nuttxspace/output/fs && 
/home/lixiang/repos/avatar_master_linux/prebuilts/linux/gcc/tricore/bin/tricore-elf-gcc
 -D__KERNEL__ -D__NuttX__ -I/home/lixiang/repos/nuttxspace/nuttx/fs 
-I/home/lixiang/repos/nuttxspace/nuttx/sched -isystem 
/home/lixiang/repos/nuttxspace/nuttx/include -isystem 
/home/lixiang/repos/nuttxspace/output/include -mcpu=tc39xx -mtc162 
-I/home/lixiang/repos/nuttxspace/nuttx/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/Cpu/Std
 
-I/home/lixiang/repos/nuttxspace/nuttx/arch/tricore/src/tc3xx/tc397/Libraries/Infra/Platform
 
-I/home/lixiang/repos/nuttxspace/nuttx/arch/tricore/src/tc3xx/tc397/Configurations
 -fno-common -Wall -Wshadow -Wundef -nostdlib -Os -fno-strict-aliasing 
-fomit-frame-pointer -ffunction-sections -fdata-sections -g -Wno-attributes 
-Wno-unknown-pragmas -Wstrict-prototypes -fdiagnostics-color=always -DNDEBUG 
-fmacro-prefix-map=/home/lixiang/repos/nuttxspace/nuttx= 
-fmacro-prefix-map=/home/lixiang/repos/nuttxspace/nuttx-a
 pps= 
-fmacro-prefix-map=/home/lixiang/repos/nuttxspace/nuttx/boards/tricore/tc3xx/tc397=
 
-fmacro-prefix-map=/home/lixiang/repos/nuttxspace/nuttx/arch/tricore/src/tc3xx= 
-MD -MT fs/CMakeFiles/fs.dir/procfs/fs_procfstcbinfo.c.obj -MF 
CMakeFiles/fs.dir/procfs/fs_procfstcbinfo.c.obj.d -o 
CMakeFiles/fs.dir/procfs/fs_procfstcbinfo.c.obj -c 
/home/lixiang/repos/nuttxspace/nuttx/fs/procfs/fs_procfstcbinfo.c
   during RTL pass: reload
   /home/lixiang/repos/nuttxspace/nuttx/fs/procfs/fs_procfstcbinfo.c: 
在函数‘tcbinfo_read’中:
   /home/lixiang/repos/nuttxspace/nuttx/fs/procfs/fs_procfstcbinfo.c:239:1: 
编译器内部错误: 在 check_bool_attrs 中,于 recog.c:2644
 239 | }
 | ^
   
   ```
   
   **before updating arch/tricore/include/arch.h and 
rch/tricore/include/irq.h:**
   
   ```
   [ 96%] Linking C executable nuttx
   /home/lixiang/downloads/cmake-3.27.1-linux-x86_64/bin/cmake -E 
cmake_link_script CMakeFiles/nuttx.dir/link.txt --verbose=1
   
/home/lixiang/repos/avatar_master_linux/prebuilts/linux/gcc/tricore/bin/tricore-elf-gcc
 -mcpu=tc39xx -mtc162 
-I/home/lixiang/repos/nuttxspace/nuttx/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/Cpu/Std
 
-I/home/lixiang/repos/nuttxspace/nuttx/arch/tricore/src/tc3xx/tc397/Libraries/Infra/Platform
 
-I/home/lixiang/repos/nuttxspace/nuttx/arch/tricore/src/tc3xx/tc397/Configurations
 -Wl,--gc-sections -Wl,--cref -Wl,-Map=nuttx.map -Wl,--no-warn-rwx-segments 
-Xlinker -nostdlib 
CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Configurations/Ifx_Cfg_Ssw.c.obj
 
CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/Asclin/Std/IfxAsclin.c.obj
 
CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/Cpu/Std/IfxCpu.c.obj
 
CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/Cpu/Trap/IfxCpu_Trap.c.obj
 
CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/_Impl/IfxAsclin_cfg.c.obj
 CMakeFiles/
 
nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/_Impl/IfxCif_cfg.c.obj
 
CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/_Impl/IfxCpu_cfg.c.obj
 
CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/_Impl/IfxPort_cfg.c.obj
 
CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/_Impl/IfxStm_cfg.c.obj
 
CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/_PinMap/IfxAsclin_PinMap.c.obj
 
CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/Pms/Std/IfxPmsEvr.c.obj
 
CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/Pms/Std/IfxPmsPm.c.obj
 
CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/Port/Std/IfxPort.c.obj
 
CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/Scu/Std/IfxScuCcu.c.obj
 CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/
 Scu/Std/IfxScuEru.c.obj 
CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/Scu/

Re: [PR] arch/xtensa/esp32s3: Add EXT1 wakeup support in power management [nuttx]

2025-08-20 Thread via GitHub


thiagofinelon commented on PR #16878:
URL: https://github.com/apache/nuttx/pull/16878#issuecomment-3207757459

   
https://drive.google.com/file/d/1ThlGv1DsYma6dJLjgZsOGfeL0c_Hi69P/view?usp=sharing
 link to the test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(nuttx-website) branch asf-site updated: Publishing web: 9694bc613262aaa0e4e5b8ccb54017a1c229e44e docs: 2713c5e9dfdc5baf25272425314a42dc4e215cbb

2025-08-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository.

github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git


The following commit(s) were added to refs/heads/asf-site by this push:
 new 89e55a19f Publishing web: 9694bc613262aaa0e4e5b8ccb54017a1c229e44e 
docs: 2713c5e9dfdc5baf25272425314a42dc4e215cbb
89e55a19f is described below

commit 89e55a19f761eca680b788e6f8dc134554a390c1
Author: Tomasz 'CeDeROM' CEDRO 
AuthorDate: Thu Aug 21 00:31:39 2025 +

Publishing web: 9694bc613262aaa0e4e5b8ccb54017a1c229e44e docs: 
2713c5e9dfdc5baf25272425314a42dc4e215cbb
---
 content/docs/10.0.0/index.html |   2 +-
 content/docs/10.0.1/index.html |   2 +-
 content/docs/10.1.0/index.html |   2 +-
 content/docs/10.2.0/index.html |   2 +-
 content/docs/10.3.0/index.html |   2 +-
 content/docs/11.0.0/index.html |   2 +-
 content/docs/12.0.0/index.html |   2 +-
 content/docs/12.0.0/searchindex.js |   2 +-
 content/docs/12.1.0/index.html |   2 +-
 content/docs/12.1.0/searchindex.js |   2 +-
 content/docs/12.10.0/index.html|   2 +-
 content/docs/12.10.0/searchindex.js|   2 +-
 content/docs/12.2.0/index.html |   2 +-
 content/docs/12.2.0/searchindex.js |   2 +-
 content/docs/12.2.1/index.html |   2 +-
 content/docs/12.2.1/searchindex.js |   2 +-
 content/docs/12.3.0/index.html |   2 +-
 content/docs/12.3.0/searchindex.js |   2 +-
 content/docs/12.4.0/index.html |   2 +-
 content/docs/12.4.0/searchindex.js |   2 +-
 content/docs/12.5.0/index.html |   2 +-
 content/docs/12.5.0/searchindex.js |   2 +-
 content/docs/12.5.1/index.html |   2 +-
 content/docs/12.5.1/searchindex.js |   2 +-
 content/docs/12.6.0/index.html |   2 +-
 content/docs/12.6.0/searchindex.js |   2 +-
 content/docs/12.7.0/index.html |   2 +-
 content/docs/12.7.0/searchindex.js |   2 +-
 content/docs/12.8.0/index.html |   2 +-
 content/docs/12.8.0/searchindex.js |   2 +-
 content/docs/12.9.0/index.html |   2 +-
 content/docs/12.9.0/searchindex.js |   2 +-
 .../_sources/platforms/arm/rp2040/index.rst.txt|  39 -
 .../rp23xx/boards/raspberrypi-pico-2/index.rst.txt |  18 ++
 .../esp32s3/boards/esp32s3-devkit/index.rst.txt|  20 +++
 content/docs/latest/guides/fully_linked_elf.html   |   2 +-
 .../docs/latest/guides/partially_linked_elf.html   |   2 +-
 content/docs/latest/index.html |   2 +-
 content/docs/latest/objects.inv| Bin 159876 -> 159912 bytes
 .../docs/latest/platforms/arm/rp2040/index.html|  19 ++
 .../rp23xx/boards/raspberrypi-pico-2/index.html|  21 ++-
 .../esp32s3/boards/esp32s3-devkit/index.html   |  17 +
 content/docs/latest/searchindex.js |   2 +-
 content/feed.xml   |   4 +--
 44 files changed, 133 insertions(+), 77 deletions(-)

diff --git a/content/docs/10.0.0/index.html b/content/docs/10.0.0/index.html
index 89e9af965..9fa78a121 100644
--- a/content/docs/10.0.0/index.html
+++ b/content/docs/10.0.0/index.html
@@ -207,7 +207,7 @@ by following these 
 NuttX Documentation¶
 NuttX is a real-time operating system (RTOS) with an emphasis on standards 
compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller 
environments, the primary governing standards in NuttX are Posix and ANSI 
standards. Additional standard APIs from Unix and other common RTOS’s (such as 
VxWorks) are adopted for functionality not available under these standards, or 
for functionality that is not appropriate for deeply-embedded environments 
(such as fork()).
-Last Updated: 20 August 25 at 00:14
+Last Updated: 21 August 25 at 00:13
 
 Table of Contents
 
diff --git a/content/docs/10.0.1/index.html b/content/docs/10.0.1/index.html
index 9098090b3..b5c21e72b 100644
--- a/content/docs/10.0.1/index.html
+++ b/content/docs/10.0.1/index.html
@@ -245,7 +245,7 @@ by following these 
 NuttX Documentation¶
 NuttX is a real-time operating system (RTOS) with an emphasis on standards 
compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller 
environments, the primary governing standards in NuttX are Posix and ANSI 
standards. Additional standard APIs from Unix and other common RTOS’s (such as 
VxWorks) are adopted for functionality not available under these standards, or 
for functionality that is not appropriate for deeply-embedded en

Re: [PR] include/nuttx/compiler.h: [nuttx]

2025-08-20 Thread via GitHub


wangchdo commented on code in PR #16879:
URL: https://github.com/apache/nuttx/pull/16879#discussion_r2289701444


##
include/nuttx/compiler.h:
##
@@ -268,7 +268,7 @@
 
 /* The nooptimiziation_function attribute no optimize */
 
-#  if defined(__clang__)
+#  if defined(__clang__) || defined (CONFIG_TRICORE_TOOLCHAIN_GNU)

Review Comment:
   updated accordingly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] sched: Fix smp scheduling [nuttx]

2025-08-20 Thread via GitHub


jlaitine commented on PR #16673:
URL: https://github.com/apache/nuttx/pull/16673#issuecomment-3204854277

   Big thanks to everyone who helped in testing and to the reviewers!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] boards/esp32s3: Add SPI slave device support [nuttx]

2025-08-20 Thread via GitHub


eren-terzioglu commented on PR #16866:
URL: https://github.com/apache/nuttx/pull/16866#issuecomment-3204617647

   Just a minor comment. Rest of it related to driver itself. Thanks for 
contribution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] boards/esp32s3: Add SPI slave device support [nuttx]

2025-08-20 Thread via GitHub


eren-terzioglu commented on code in PR #16866:
URL: https://github.com/apache/nuttx/pull/16866#discussion_r2287258808


##
boards/xtensa/esp32s3/common/src/Make.defs:
##
@@ -36,6 +36,9 @@ endif
 
 ifeq ($(CONFIG_SPI_DRIVER),y)
   CSRCS += esp32s3_board_spidev.c
+  ifeq ($(CONFIG_SPI_SLAVE_DRIVER),y)
+CSRCS += esp32s3_board_spislavedev.c
+  endif
 endif

Review Comment:
   Other devices implemented it seperately. For consistency reasons could you 
change it?
   [Here is an 
implementation](https://github.com/apache/nuttx/blob/master/boards/risc-v/esp32c6/common/src/Make.defs#L41-L47)
 
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] boards/esp32s3: Add SPI slave device support [nuttx]

2025-08-20 Thread via GitHub


eren-terzioglu commented on code in PR #16866:
URL: https://github.com/apache/nuttx/pull/16866#discussion_r2287258808


##
boards/xtensa/esp32s3/common/src/Make.defs:
##
@@ -36,6 +36,9 @@ endif
 
 ifeq ($(CONFIG_SPI_DRIVER),y)
   CSRCS += esp32s3_board_spidev.c
+  ifeq ($(CONFIG_SPI_SLAVE_DRIVER),y)
+CSRCS += esp32s3_board_spislavedev.c
+  endif
 endif

Review Comment:
   ```suggestion
   ifeq ($(CONFIG_SPI_DRIVER),y)
 CSRCS += esp32s3_board_spidev.c
 ifeq ($(CONFIG_SPI_SLAVE_DRIVER),y)
   CSRCS += esp32s3_board_spislavedev.c
 endif
   endif
   ```
   
   Other devices implemented it seperately. For consistency reasons could you 
change it?
   [Here is an 
implementation](https://github.com/apache/nuttx/blob/master/boards/risc-v/esp32c6/common/src/Make.defs#L41-L47)
 
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] arch: Add Cmake build support for raspberrypi-4b board & bcm2711 chip [nuttx]

2025-08-20 Thread via GitHub


wangchdo commented on PR #16872:
URL: https://github.com/apache/nuttx/pull/16872#issuecomment-3205354884

   Change-Id was removed from commit message


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] drivers/ioexpander/CMakeLists.txt: Aligned Cmake with Make [nuttx]

2025-08-20 Thread via GitHub


simbit18 opened a new pull request, #16873:
URL: https://github.com/apache/nuttx/pull/16873

   ## Summary
   
   Add:
   
   iC-JX driver #11590
   
   ISO1H812G driver #10426
   
   ISO1I813T driver #10435
   
   PCA9557 driver #16042
   
   mcp23008 driver #10532
   
   ## Impact
   
   Impact on user: NO
   
   Impact on build: This PR Aligned Cmake with Make
   
   Impact on hardware: NO
   
   Impact on documentation: NO
   
   Impact on security: NO
   
   Impact on compatibility: NO
   
   
   
   ## Testing
   
   locally
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org