[jira] [Closed] (OPENMEETINGS-2540) Suggestions resulting from tests

2021-01-31 Thread Kden (Jira) 


 [ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kden closed OPENMEETINGS-2540.
--

ok

> Suggestions resulting from tests
> 
>
> Key: OPENMEETINGS-2540
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2540
> Project: Openmeetings
>  Issue Type: Test
>  Components: Dashboard, Invitation
>Affects Versions: 5.1.0
>Reporter: Kden
>Assignee: Maxim Solodovnik
>Priority: Major
>
> Hello!
> 1. In my opinion, the delete user buttons should be removed from the 
> moderator panel. And at the moment Moderator can not delete users, these 
> buttons will just confuse him.
> 2. When the moderator enters the room and clicks the "Edit Settings" button - 
> no settings window is displayed, but the server is reloaded.
> 3. When sending an invitation to an e-mail that is not to a registered user - 
> one is created in the database, directly from the invitation form - this 
> allows the moderator to register countless users with fictitious e-mails, 
> outside his groups, without him knowing.
> Overall - everything works perfectly!
>  With respect:
> K. D.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (OPENMEETINGS-2565) Typo in RoomDTO getExternal - doesn't return correct room

2021-01-31 Thread Sebastian Wagner (Jira) 


 [ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebastian Wagner resolved OPENMEETINGS-2565.

Fix Version/s: 6.0.0
   Resolution: Fixed

> Typo in RoomDTO getExternal - doesn't return correct room
> -
>
> Key: OPENMEETINGS-2565
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2565
> Project: Openmeetings
>  Issue Type: Bug
>Reporter: Sebastian Wagner
>Assignee: Sebastian Wagner
>Priority: Major
> Fix For: 6.0.0
>
>
> This is quite annoying.
>  
> Cause it looks like its working but in fact it isnt'.
>  
> {code:java}
> @WebMethod
>   @GET
>   @Path("/{type}/{externaltype}/{externaliid}")
>   public RoomDTO getExternal(@WebParam(name="sid") @QueryParam("sid") 
> String sid
>   , @PathParam("type") @WebParam(name="type") String type
>   , @PathParam("externaltype") 
> @WebParam(name="externaltype") String externalType
>   , @PathParam("externalid") @WebParam(name="externalid") 
> String externalId
>   , @WebParam(name="room") @QueryParam("room") RoomDTO 
> room) {
> {code}
>  
> externaliid == Spelled wrong and differently from
> @PathParam("externalid") @WebParam(name="externalid") String externalId
> => Effect in
> {code:java}
> Room r = roomDao.getExternal(Room.Type.valueOf(type), externalType, 
> externalId);{code}
> externalId is simply null. Nothing inside. Cause the param in the header 
> decoration is spelled wrongly/different.
> However it just returns the first entry based on the "externalType", which 
> sometimes works, for example if you just have 1 room. But in most cases just 
> doesn't work at all.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OPENMEETINGS-2565) Typo in RoomDTO getExternal - doesn't return correct room

2021-01-31 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276006#comment-17276006
 ] 

ASF subversion and git services commented on OPENMEETINGS-2565:
---

Commit d7f4822a32a6a0ef9922fbc3361f80527e8ea764 in openmeetings's branch 
refs/heads/feature/typo-in-get-room-by-externalid from Sebastian Wagner
[ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=d7f4822 ]

OPENMEETINGS-2565 Spelling mistake in web service method.


> Typo in RoomDTO getExternal - doesn't return correct room
> -
>
> Key: OPENMEETINGS-2565
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2565
> Project: Openmeetings
>  Issue Type: Bug
>Reporter: Sebastian Wagner
>Assignee: Sebastian Wagner
>Priority: Major
>
> This is quite annoying.
>  
> Cause it looks like its working but in fact it isnt'.
>  
> {code:java}
> @WebMethod
>   @GET
>   @Path("/{type}/{externaltype}/{externaliid}")
>   public RoomDTO getExternal(@WebParam(name="sid") @QueryParam("sid") 
> String sid
>   , @PathParam("type") @WebParam(name="type") String type
>   , @PathParam("externaltype") 
> @WebParam(name="externaltype") String externalType
>   , @PathParam("externalid") @WebParam(name="externalid") 
> String externalId
>   , @WebParam(name="room") @QueryParam("room") RoomDTO 
> room) {
> {code}
>  
> externaliid == Spelled wrong and differently from
> @PathParam("externalid") @WebParam(name="externalid") String externalId
> => Effect in
> {code:java}
> Room r = roomDao.getExternal(Room.Type.valueOf(type), externalType, 
> externalId);{code}
> externalId is simply null. Nothing inside. Cause the param in the header 
> decoration is spelled wrongly/different.
> However it just returns the first entry based on the "externalType", which 
> sometimes works, for example if you just have 1 room. But in most cases just 
> doesn't work at all.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[openmeetings] branch feature/typo-in-get-room-by-externalid created (now d7f4822)

2021-01-31 Thread sebawagner 
This is an automated email from the ASF dual-hosted git repository.

sebawagner pushed a change to branch feature/typo-in-get-room-by-externalid
in repository https://gitbox.apache.org/repos/asf/openmeetings.git.


  at d7f4822  OPENMEETINGS-2565 Spelling mistake in web service method.

This branch includes the following new commits:

 new d7f4822  OPENMEETINGS-2565 Spelling mistake in web service method.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

[openmeetings] 01/01: OPENMEETINGS-2565 Spelling mistake in web service method.

2021-01-31 Thread sebawagner 
This is an automated email from the ASF dual-hosted git repository.

sebawagner pushed a commit to branch feature/typo-in-get-room-by-externalid
in repository https://gitbox.apache.org/repos/asf/openmeetings.git

commit d7f4822a32a6a0ef9922fbc3361f80527e8ea764
Author: Sebastian Wagner 
AuthorDate: Mon Feb 1 12:13:23 2021 +1300

OPENMEETINGS-2565 Spelling mistake in web service method.
---
 .../main/java/org/apache/openmeetings/webservice/RoomWebService.java| 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/openmeetings-webservice/src/main/java/org/apache/openmeetings/webservice/RoomWebService.java
 
b/openmeetings-webservice/src/main/java/org/apache/openmeetings/webservice/RoomWebService.java
index d704577..ace6598 100644
--- 
a/openmeetings-webservice/src/main/java/org/apache/openmeetings/webservice/RoomWebService.java
+++ 
b/openmeetings-webservice/src/main/java/org/apache/openmeetings/webservice/RoomWebService.java
@@ -164,7 +164,7 @@ public class RoomWebService extends BaseWebService {
 */
@WebMethod
@GET
-   @Path("/{type}/{externaltype}/{externaliid}")
+   @Path("/{type}/{externaltype}/{externalid}")
public RoomDTO getExternal(@WebParam(name="sid") @QueryParam("sid") 
String sid
, @PathParam("type") @WebParam(name="type") String type
, @PathParam("externaltype") 
@WebParam(name="externaltype") String externalType

[jira] [Created] (OPENMEETINGS-2565) Typo in RoomDTO getExternal - doesn't return correct room

2021-01-31 Thread Sebastian Wagner (Jira) 
Sebastian Wagner created OPENMEETINGS-2565:
--

 Summary: Typo in RoomDTO getExternal - doesn't return correct room
 Key: OPENMEETINGS-2565
 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2565
 Project: Openmeetings
  Issue Type: Bug
Reporter: Sebastian Wagner
Assignee: Sebastian Wagner


This is quite annoying.

 

Cause it looks like its working but in fact it isnt'.

 
{code:java}
@WebMethod
@GET
@Path("/{type}/{externaltype}/{externaliid}")
public RoomDTO getExternal(@WebParam(name="sid") @QueryParam("sid") 
String sid
, @PathParam("type") @WebParam(name="type") String type
, @PathParam("externaltype") 
@WebParam(name="externaltype") String externalType
, @PathParam("externalid") @WebParam(name="externalid") 
String externalId
, @WebParam(name="room") @QueryParam("room") RoomDTO 
room) {
{code}
 

externaliid == Spelled wrong and differently from

@PathParam("externalid") @WebParam(name="externalid") String externalId

=> Effect in
{code:java}
Room r = roomDao.getExternal(Room.Type.valueOf(type), externalType, 
externalId);{code}
externalId is simply null. Nothing inside. Cause the param in the header 
decoration is spelled wrongly/different.

However it just returns the first entry based on the "externalType", which 
sometimes works, for example if you just have 1 room. But in most cases just 
doesn't work at all.

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)