Re: [PR] Clean Google Dependencies [pinot]
Jackie-Jiang merged PR #13297: URL: https://github.com/apache/pinot/pull/13297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
Re: [PR] Clean Google Dependencies [pinot]
abhioncbr commented on code in PR #13297: URL: https://github.com/apache/pinot/pull/13297#discussion_r1628677484 ## pom.xml: ## @@ -224,12 +224,12 @@ 26.40.0 -1.23.0 -2.10.1 -33.1.0-jre -1.44.1 -3.25.2 -1.61.1 +3.25.2 +1.61.1 Review Comment: Imported `grpc-bom` and `protobuf-pom` into the project. In this way, the version during compilation and runtime should be the same. However, while updating `google-bom,` we need to make sure that the `grpc` and `protobuf ` versions is supported or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
Re: [PR] Clean Google Dependencies [pinot]
Jackie-Jiang commented on code in PR #13297: URL: https://github.com/apache/pinot/pull/13297#discussion_r1628489765 ## pom.xml: ## @@ -1395,7 +1389,7 @@ net.openhft posix -2.26ea0 +2.25ea0 Review Comment: Is this change intended? ## pom.xml: ## @@ -224,12 +224,12 @@ 26.40.0 -1.23.0 -2.10.1 -33.1.0-jre -1.44.1 -3.25.2 -1.61.1 +3.25.2 +1.61.1 Review Comment: Is there a way to extract these 2 versions from the BOM? ## pom.xml: ## @@ -1646,7 +1640,7 @@ org.apache.maven.plugins maven-javadoc-plugin - 3.7.0 + 3.6.3 Review Comment: Is this change intended? ## pom.xml: ## @@ -224,12 +224,12 @@ 26.40.0 -1.23.0 -2.10.1 -33.1.0-jre -1.44.1 -3.25.2 -1.61.1 +3.25.2 +1.61.1 +3.0.2 +2.27.1 Review Comment: This doesn't match the current version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
Re: [PR] Clean Google Dependencies [pinot]
abhioncbr closed pull request #13297: Clean Google Dependencies URL: https://github.com/apache/pinot/pull/13297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
Re: [PR] Clean Google Dependencies [pinot]
codecov-commenter commented on PR #13297: URL: https://github.com/apache/pinot/pull/13297#issuecomment-2144101503 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13297?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 0.00%. Comparing base [(`59551e4`)](https://app.codecov.io/gh/apache/pinot/commit/59551e45224f1535c4863fd577622b37366ccc97?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`b763d05`)](https://app.codecov.io/gh/apache/pinot/commit/b763d058f7f9026ea755e87cf70f8fe74756152a?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 537 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #13297 +/- ## = - Coverage 61.75%0.00% -61.76% = Files 2436 2459 +23 Lines133233 135540 +2307 Branches 2063620971 +335 = - Hits 822740-82274 - Misses44911 135540+90629 + Partials 60480 -6048 ``` | [Flag](https://app.codecov.io/gh/apache/pinot/pull/13297/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/13297/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | | [integration](https://app.codecov.io/gh/apache/pinot/pull/13297/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `0.00% <ø> (-0.01%)` | :arrow_down: | | [integration1](https://app.codecov.io/gh/apache/pinot/pull/13297/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | | [integration2](https://app.codecov.io/gh/apache/pinot/pull/13297/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `0.00% <ø> (ø)` | | | [java-11](https://app.codecov.io/gh/apache/pinot/pull/13297/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | | [java-21](https://app.codecov.io/gh/apache/pinot/pull/13297/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `0.00% <ø> (-61.63%)` | :arrow_down: | | [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/13297/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `0.00% <ø> (-61.75%)` | :arrow_down: | | [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/13297/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | | [temurin](https://app.codecov.io/gh/apache/pinot/pull/13297/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `0.00% <ø> (-61.76%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/pinot/pull/13297/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/13297/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/13297/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/13297?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For