[GitHub] [pulsar] shiv4289 commented on issue #3949: [issue 3939] [pulsar-flink]: Allow client authentication from pulsar-flink package

[GitBox]

shiv4289 commented on issue #3949: [issue 3939] [pulsar-flink]: Allow client 
authentication from pulsar-flink package
URL: https://github.com/apache/pulsar/pull/3949#issuecomment-478867226
 
 
   > @shiv4289 can you rebase to latest master? :)
   
   Done :-)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] skyrocknroll commented on issue #3744: Exposing getSchemaVersion in the client by making it public.

[GitBox]

skyrocknroll commented on issue #3744: Exposing getSchemaVersion in the client 
by making it public.
URL: https://github.com/apache/pulsar/pull/3744#issuecomment-478866574
 
 
   Thanks @merlimat


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] wolfstudy commented on issue #3854: [issue #3767] support go function for pulsar

[GitBox]

wolfstudy commented on issue #3854: [issue #3767] support go function for pulsar
URL: https://github.com/apache/pulsar/pull/3854#issuecomment-478858365
 
 
   run cpp tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] ayolivia opened a new issue #3963: RedisSink not available

[GitBox]

ayolivia opened a new issue #3963: RedisSink not available
URL: https://github.com/apache/pulsar/issues/3963
 
 
   **Describe the bug**
   When trying to copy the `pulsar-io-redis-2.4.0-SNAPSHOT.nar` to the existing 
directory `connectors` and restart the broker, it failed to list the redis 
connector by the following script:
   ```
   $ curl -s http://localhost:8080/admin/v2/functions/connectors
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] wolfstudy commented on issue #3904: [go schema] support go schema for pulsar-client-go

[GitBox]

wolfstudy commented on issue #3904: [go schema] support go schema for 
pulsar-client-go
URL: https://github.com/apache/pulsar/pull/3904#issuecomment-478854592
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3744: Exposing getSchemaVersion in the client by making it public.

[GitBox]

merlimat commented on issue #3744: Exposing getSchemaVersion in the client by 
making it public.
URL: https://github.com/apache/pulsar/pull/3744#issuecomment-478845595
 
 
   Merged in 2.3.1 at 
   515a55e


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3956: Exposing getSchemaVersion in the client by making it public. (#3744)

[GitBox]

merlimat commented on issue #3956: Exposing getSchemaVersion in the client by 
making it public. (#3744)
URL: https://github.com/apache/pulsar/pull/3956#issuecomment-478845453
 
 
   This is actually a backport of #3744 for branch-2.3. I'm cherry-picking that 
change directly instead (same as all the other changes merged in master and 
marked for 2.3.1 milestone).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[pulsar] branch branch-2.3 updated: Exposing getSchemaVersion in the client by making it public. (#3744)

[mmerli]

This is an automated email from the ASF dual-hosted git repository.

mmerli pushed a commit to branch branch-2.3
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/branch-2.3 by this push:
 new 515a55e  Exposing getSchemaVersion in the client by making it public. 
(#3744)
515a55e is described below

commit 515a55e327dc26a2771d342b29ab8c85cdc50ccf
Author: Yuvaraj L 
AuthorDate: Tue Mar 5 00:58:36 2019 +0530

Exposing getSchemaVersion in the client by making it public. (#3744)

* Exposing getSchemaVersion in the client by making it public.

* Implemented getSchemaVersion in TopicMessageImpl.java

* Changed the release version
---
 .../src/main/java/org/apache/pulsar/client/api/Message.java| 7 +++
 .../src/main/java/org/apache/pulsar/client/impl/MessageImpl.java   | 3 ++-
 .../main/java/org/apache/pulsar/client/impl/TopicMessageImpl.java  | 5 +
 3 files changed, 14 insertions(+), 1 deletion(-)

diff --git 
a/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Message.java 
b/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Message.java
index 58e6162..e672ab0 100644
--- a/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Message.java
+++ b/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Message.java
@@ -180,4 +180,11 @@ public interface Message {
  * @return message redelivery count
  */
 int getRedeliveryCount();
+
+/**
+ * Get schema version of the message.
+ * @since 2.4.0
+ * @return Schema version of the message if the message is produced with 
schema otherwise null.
+ */
+byte[] getSchemaVersion();
 }
diff --git 
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java 
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java
index 665fd36..30e1474 100644
--- a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java
+++ b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java
@@ -228,7 +228,8 @@ public class MessageImpl implements Message {
 }
 }
 
-private byte[] getSchemaVersion() {
+@Override
+public byte[] getSchemaVersion() {
 if (msgMetadataBuilder.hasSchemaVersion()) {
 return msgMetadataBuilder.getSchemaVersion().toByteArray();
 } else {
diff --git 
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/TopicMessageImpl.java
 
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/TopicMessageImpl.java
index bf6b281..fff104d 100644
--- 
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/TopicMessageImpl.java
+++ 
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/TopicMessageImpl.java
@@ -143,6 +143,11 @@ public class TopicMessageImpl implements Message {
 return msg.getRedeliveryCount();
 }
 
+@Override
+public byte[] getSchemaVersion() {
+return msg.getSchemaVersion();
+}
+
 public Message getMessage() {
 return msg;
 }

[GitHub] [pulsar] merlimat closed pull request #3956: Exposing getSchemaVersion in the client by making it public. (#3744)

[GitBox]

merlimat closed pull request #3956: Exposing getSchemaVersion in the client by 
making it public. (#3744)
URL: https://github.com/apache/pulsar/pull/3956
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on a change in pull request #3962: Feature / Interceptor for negative ack redelivery

[GitBox]

merlimat commented on a change in pull request #3962: Feature / Interceptor for 
negative ack redelivery
URL: https://github.com/apache/pulsar/pull/3962#discussion_r271134069
 
 

 ##
 File path: 
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerInterceptors.java
 ##
 @@ -109,9 +110,29 @@ public void onAcknowledge(Consumer consumer, MessageId 
messageId, Throwable e
  * @param exception exception returned by broker.
  */
 public void onAcknowledgeCumulative(Consumer consumer, MessageId 
messageId, Throwable exception) {
-for (int i = 0; i < interceptors.size(); i++) {
+for (ConsumerInterceptor interceptor : interceptors) {
 try {
-interceptors.get(i).onAcknowledgeCumulative(consumer, 
messageId, exception);
+interceptor.onAcknowledgeCumulative(consumer, messageId, 
exception);
+} catch (Exception e) {
+log.warn("Error executing interceptor onAcknowledgeCumulative 
callback ", e);
+}
+}
+}
+
+/**
+ * This method will be called when a redelivery from a negative 
acknowledge occurs.
+ * 
+ * This method calls {@link 
ConsumerInterceptor#onNegativeAckRedelivery(Consumer, Set)} method 
for each interceptor.
+ * 
+ * This method does not throw exceptions. Exceptions thrown by any of 
interceptors in the chain are logged, but not propagated.
+ *
+ * @param consumer the consumer which contains the interceptors
+ * @param messageIds set of messages ids being redelivery.
+ */
+public void onNegativeAckRedelivery(Consumer consumer, Set 
messageIds) {
 
 Review comment:
   Regarding the naming of this method, I think it might get a bit misleading 
because the redelivery might actually get to a different consumer. Eg. 
ConsumerA calls Nack() and after 1 min ConsumerB will get the message again.
   
   Would it be more intuitive to have the method called `onNegativeAck()` and 
call it as soon as the app calls `consumer.negativeAcknowledgement()`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3848: [Issue-2122] [pulsar-client] Adding configuration for backoff strategy

[GitBox]

merlimat commented on issue #3848: [Issue-2122] [pulsar-client] Adding 
configuration for backoff strategy
URL: https://github.com/apache/pulsar/pull/3848#issuecomment-478842059
 
 
   run java8 tests
   run integration tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3960: Fixed reader reading from a partition

[GitBox]

merlimat commented on issue #3960: Fixed reader reading from a partition
URL: https://github.com/apache/pulsar/pull/3960#issuecomment-478840801
 
 
   run java8 tests
   run integration tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie closed issue #3851: java.net.BindException when starting broker via the config initialized in cluster metadata

[GitBox]

sijie closed issue #3851: java.net.BindException when starting broker via the 
config initialized in cluster metadata
URL: https://github.com/apache/pulsar/issues/3851
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[pulsar] branch master updated: [Issue 3851] [pulsar-broker] Support to start broker use the port initialized in cluster metadata (#3853)

[sijie]

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
 new 2e93452  [Issue 3851] [pulsar-broker] Support to start broker use the 
port initialized in cluster metadata (#3853)
2e93452 is described below

commit 2e934529d940bdd1b271ea0913249d787fc78ec4
Author: Fangbin Sun 
AuthorDate: Tue Apr 2 12:21:48 2019 +0800

[Issue 3851] [pulsar-broker] Support to start broker use the port 
initialized in cluster metadata (#3853)

### Motivation

Fixes #3851

### Modifications

Override the port of service urls in brokerConfig by the config initialized 
in cluster metadata.
---
 site2/docs/deploy-bare-metal-multi-cluster.md | 14 +-
 site2/docs/deploy-bare-metal.md   | 13 +++--
 2 files changed, 24 insertions(+), 3 deletions(-)

diff --git a/site2/docs/deploy-bare-metal-multi-cluster.md 
b/site2/docs/deploy-bare-metal-multi-cluster.md
index 1fc1fce..ad54e15 100644
--- a/site2/docs/deploy-bare-metal-multi-cluster.md
+++ b/site2/docs/deploy-bare-metal-multi-cluster.md
@@ -280,7 +280,7 @@ Brokers can be configured using the 
[`conf/broker.conf`](reference-configuration
 
 The most important element of broker configuration is ensuring that each 
broker is aware of its local ZooKeeper quorum as well as the configuration 
store quorum. Make sure that you set the 
[`zookeeperServers`](reference-configuration.md#broker-zookeeperServers) 
parameter to reflect the local quorum and the 
[`configurationStoreServers`](reference-configuration.md#broker-configurationStoreServers)
 parameter to reflect the configuration store quorum (although you'll need to 
specify only tho [...]
 
-You also need to specify the name of the 
[cluster](reference-terminology.md#cluster) to which the broker belongs using 
the [`clusterName`](reference-configuration.md#broker-clusterName) parameter.
+You also need to specify the name of the 
[cluster](reference-terminology.md#cluster) to which the broker belongs using 
the [`clusterName`](reference-configuration.md#broker-clusterName) parameter. 
In addition, you need to match the broker and web service ports provided when 
initializing the cluster's metadata (especially when using a different port 
from default).
 
 Here's an example configuration:
 
@@ -292,6 +292,18 @@ 
zookeeperServers=zk1.us-west.example.com:2181,zk2.us-west.example.com:2181,zk3.u
 
configurationStoreServers=zk1.us-west.example.com:2184,zk2.us-west.example.com:2184,zk3.us-west.example.com:2184
 
 clusterName=us-west
+
+# Broker data port
+brokerServicePort=6650
+
+# Broker data port for TLS
+brokerServicePortTls=6651
+
+# Port to use to server HTTP request
+webServicePort=8080
+
+# Port to use to server HTTPS request
+webServicePortTls=8443
 ```
 
 ### Broker hardware
diff --git a/site2/docs/deploy-bare-metal.md b/site2/docs/deploy-bare-metal.md
index 9bb7978..0e41a13 100644
--- a/site2/docs/deploy-bare-metal.md
+++ b/site2/docs/deploy-bare-metal.md
@@ -303,19 +303,28 @@ Pulsar brokers are the last thing you need to deploy in 
your Pulsar cluster. Bro
 
 ### Configuring Brokers
 
-The most important element of broker configuration is ensuring that that each 
broker is aware of the ZooKeeper cluster that you've deployed. Make sure that 
the [`zookeeperServers`](reference-configuration.md#broker-zookeeperServers) 
and 
[`configurationStoreServers`](reference-configuration.md#broker-configurationStoreServers)
 parameters. In this case, since we only have 1 cluster and no configuration 
store setup, the `configurationStoreServers` will point to the same 
`zookeeperServers`.
+The most important element of broker configuration is ensuring that each 
broker is aware of the ZooKeeper cluster that you've deployed. Make sure that 
the [`zookeeperServers`](reference-configuration.md#broker-zookeeperServers) 
and 
[`configurationStoreServers`](reference-configuration.md#broker-configurationStoreServers)
 parameters. In this case, since we only have 1 cluster and no configuration 
store setup, the `configurationStoreServers` will point to the same 
`zookeeperServers`.
 
 ```properties
 
zookeeperServers=zk1.us-west.example.com:2181,zk2.us-west.example.com:2181,zk3.us-west.example.com:2181
 
configurationStoreServers=zk1.us-west.example.com:2181,zk2.us-west.example.com:2181,zk3.us-west.example.com:2181
 ```
 
-You also need to specify the cluster name (matching the name that you provided 
when [initializing the cluster's metadata](#initializing-cluster-metadata):
+You also need to specify the cluster name (matching the name that you provided 
when [initializing the cluster's metadata](#initializing-cluster-metadata)):
 
 ```properties
 clusterName=pulsar-cluster-1
 ```
 
+In addition, you need to match the broker and web service ports provided when 
initializing the cluster's metadata (especia

[GitHub] [pulsar] sijie merged pull request #3853: [Issue 3851] [pulsar-broker] Support to start broker use the port initialized in cluster metadata

[GitBox]

sijie merged pull request #3853: [Issue 3851] [pulsar-broker] Support to start 
broker use the port initialized in cluster metadata
URL: https://github.com/apache/pulsar/pull/3853
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] lovelle opened a new pull request #3962: Feature / Interceptor for negative ack redelivery

[GitBox]

lovelle opened a new pull request #3962: Feature / Interceptor for negative ack 
redelivery
URL: https://github.com/apache/pulsar/pull/3962
 
 
   **Motivation**
   
   In some scenarios is it helpful to be able to set interceptor for 
redeliveries
   being happening due to negative acknowledge.
   
   **Modifications**
   
 - Add onNegativeAckRedelivery() method in ConsumerInterceptor interface.
 - Add handler for onNegativeAckRedelivery() interceptor in ConsumerBase.
 - Favor forEach on ConsumerInterceptor instead of classic for loop by 
index.
 - Add call method to onNegativeAckRedelivery() from NegativeAcksTracker.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #3949: [issue 3939] [pulsar-flink]: Allow client authentication from pulsar-flink package

[GitBox]

sijie commented on issue #3949: [issue 3939] [pulsar-flink]: Allow client 
authentication from pulsar-flink package
URL: https://github.com/apache/pulsar/pull/3949#issuecomment-478838124
 
 
   @shiv4289 can you rebase to latest master? :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie merged pull request #3955: [Flink] Allow to customize PulsarProducer

[GitBox]

sijie merged pull request #3955: [Flink] Allow to customize PulsarProducer
URL: https://github.com/apache/pulsar/pull/3955
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[pulsar] branch master updated: [Flink] Allow to customize PulsarProducer (#3955)

[sijie]

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
 new 4101168  [Flink] Allow to customize PulsarProducer (#3955)
4101168 is described below

commit 4101168fbf5689af0eac37e1fc03195778f544d5
Author: Cristian 
AuthorDate: Mon Apr 1 21:15:44 2019 -0700

[Flink] Allow to customize PulsarProducer (#3955)

This is an improvement over #3894.

Because of how Flink instantiates functions, instead of passing a
custom `PulsarProducer` client we need to pass an object that is
serializable. The current implementation will default to always
call `createProducer()` because `producer` is `transient`, so it will
always be null when Flink creates new instances of the sink.
---
 .../connectors/pulsar/FlinkPulsarProducer.java | 23 +++---
 1 file changed, 16 insertions(+), 7 deletions(-)

diff --git 
a/pulsar-flink/src/main/java/org/apache/flink/streaming/connectors/pulsar/FlinkPulsarProducer.java
 
b/pulsar-flink/src/main/java/org/apache/flink/streaming/connectors/pulsar/FlinkPulsarProducer.java
index 04e69f8..c0d3905 100644
--- 
a/pulsar-flink/src/main/java/org/apache/flink/streaming/connectors/pulsar/FlinkPulsarProducer.java
+++ 
b/pulsar-flink/src/main/java/org/apache/flink/streaming/connectors/pulsar/FlinkPulsarProducer.java
@@ -22,6 +22,7 @@ import static 
org.apache.flink.util.Preconditions.checkArgument;
 import static org.apache.flink.util.Preconditions.checkNotNull;
 
 import java.util.function.Function;
+import java.util.Map;
 
 import org.apache.commons.lang3.StringUtils;
 import org.apache.flink.api.common.functions.RuntimeContext;
@@ -37,8 +38,10 @@ import 
org.apache.flink.streaming.connectors.pulsar.partitioner.PulsarKeyExtract
 import org.apache.flink.util.SerializableObject;
 import org.apache.pulsar.client.api.MessageId;
 import org.apache.pulsar.client.api.Producer;
+import org.apache.pulsar.client.api.ProducerBuilder;
 import org.apache.pulsar.client.api.PulsarClient;
 import org.apache.pulsar.client.api.TypedMessageBuilder;
+import org.apache.pulsar.client.impl.conf.ProducerConfigurationData;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -73,6 +76,11 @@ public class FlinkPulsarProducer
 protected final PulsarKeyExtractor flinkPulsarKeyExtractor;
 
 /**
+ * {@link Producer} configuration map (will be materialized as a {@link 
ProducerConfigurationData} instance)
+ */
+protected final Map producerConfig;
+
+/**
  * Produce Mode.
  */
 protected PulsarProduceMode produceMode = PulsarProduceMode.AT_LEAST_ONCE;
@@ -122,7 +130,7 @@ public class FlinkPulsarProducer
String defaultTopicName,
SerializationSchema serializationSchema,
PulsarKeyExtractor keyExtractor,
-   Producer producer) {
+   Map producerConfig) {
 checkArgument(StringUtils.isNotBlank(serviceUrl), "Service url cannot 
be blank");
 checkArgument(StringUtils.isNotBlank(defaultTopicName), "TopicName 
cannot be blank");
 this.serviceUrl = serviceUrl;
@@ -130,7 +138,7 @@ public class FlinkPulsarProducer
 this.schema = checkNotNull(serializationSchema, "Serialization Schema 
not set");
 this.flinkPulsarKeyExtractor = getOrNullKeyExtractor(keyExtractor);
 ClosureCleaner.ensureSerializable(serializationSchema);
-this.producer = producer;
+this.producerConfig = producerConfig;
 }
 
 // -- Properties --
@@ -183,7 +191,11 @@ public class FlinkPulsarProducer
 
 private Producer createProducer() throws Exception {
 PulsarClient client = 
PulsarClient.builder().serviceUrl(serviceUrl).build();
-return client.newProducer().topic(defaultTopicName).create();
+ProducerBuilder producerBuilder = client.newProducer();
+if (producerConfig != null) {
+producerBuilder = producerBuilder.loadConf(producerConfig);
+}
+return producerBuilder.topic(defaultTopicName).create();
 }
 
 /**
@@ -194,10 +206,7 @@ public class FlinkPulsarProducer
  */
 @Override
 public void open(Configuration parameters) throws Exception {
-if (producer == null) {
-// If no custom producer was specified create a default one
-this.producer = createProducer();
-}
+this.producer = createProducer();
 
 RuntimeContext ctx = getRuntimeContext();
 

[pulsar] branch master updated: [Doc] Refine language issues (#3959)

[sijie]

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
 new 181c341  [Doc] Refine language issues (#3959)
181c341 is described below

commit 181c3418bfa426ad0e57cb674760e6ab642040ba
Author: Jennifer Huang <47805623+jennifer88hu...@users.noreply.github.com>
AuthorDate: Tue Apr 2 12:15:19 2019 +0800

[Doc] Refine language issues (#3959)

### Motivation
The description of "Assignment granularity" is not quite clear, i'm trying 
to make it easy to understand.

### Modifications
1. Refine the description of "Assignment granularity".
2. Refine some language issues.
---
 site2/docs/administration-load-distribution.md | 21 +
 1 file changed, 9 insertions(+), 12 deletions(-)

diff --git a/site2/docs/administration-load-distribution.md 
b/site2/docs/administration-load-distribution.md
index a8a2dc9..8976746 100644
--- a/site2/docs/administration-load-distribution.md
+++ b/site2/docs/administration-load-distribution.md
@@ -20,26 +20,23 @@ context to understand how the traffic is managed in Pulsar.
 Topics are dynamically assigned to brokers based on the load conditions of all 
brokers in the
 cluster.
 
-When a clients starts using new topics that are not assigned to any broker, it 
will trigger a
-process that, given the load conditions, it will choose the best suited broker 
to acquire ownership
-of such topic.
+When a client starts using new topics that are not assigned to any broker, a
+process is triggered to choose the best suited broker to acquire ownership
+of these topics according to the load conditions. 
 
-In case of partitioned topics, different partitions might be assigned to 
different brokers. We talk
-about "topic" in this context to mean either a non-partitioned topic or one 
partition of a topic.
+In case of partitioned topics, different partitions are assigned to different 
brokers. Here "topic" means either a non-partitioned topic or one partition of 
a topic.
 
-The assignment is "dynamic" because it can change very quickly. For example, 
if the broker owning
+The assignment is "dynamic" because it changes quickly. For example, if the 
broker owning
 the topic crashes, the topic will be reassigned immediately to another broker. 
Another scenario is
-that the broker owning the topic becomes overloaded. In this case too, the 
topic will be
+that the broker owning the topic becomes overloaded. In this case, the topic is
 reassigned to a less loaded broker.
 
-The dynamic assignment is made possible by the stateless nature of brokers. 
This also ensure that
-we can quickly expand or shrink the cluster based on usage.
+The dynamic assignment is made possible by the stateless nature of brokers, so 
you can 
+quickly expand or shrink the cluster based on usage.
 
 ### Assignment granularity
 
-The assignment of topics/partitions to brokers is not done at the individual 
level. The reason for
-it is to amortize the amount of information that we need to keep track (eg. 
which topics are
-assigned to a particular broker, what's the load on topics for a broker and 
similar).
+The assignment of topics/partitions to brokers is not done at the 
topics/partitions level, but done at the Bundle level (a higher level). The 
reason is to amortize the amount of information that you need to keep track. 
Based on CPU, memory, traffic load and other indexes, topics are assigned to a 
particular broker dynamically. 
 
 Instead of individual topic/partition assignment, each broker takes ownership 
of a subset of the
 topics for a namespace. This subset is called a "*bundle*" and effectively 
it's a sharding

[GitHub] [pulsar] sijie merged pull request #3959: [Doc] Refine language issues in administration-load-distribution.md

[GitBox]

sijie merged pull request #3959: [Doc] Refine language issues in 
administration-load-distribution.md
URL: https://github.com/apache/pulsar/pull/3959
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] wolfstudy commented on issue #3904: [go schema] support go schema for pulsar-client-go

[GitBox]

wolfstudy commented on issue #3904: [go schema] support go schema for 
pulsar-client-go
URL: https://github.com/apache/pulsar/pull/3904#issuecomment-478835516
 
 
thanks for @merlimat @sijie help, PTAL again.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3956: Exposing getSchemaVersion in the client by making it public. (#3744)

[GitBox]

merlimat commented on issue #3956: Exposing getSchemaVersion in the client by 
making it public. (#3744)
URL: https://github.com/apache/pulsar/pull/3956#issuecomment-478831399
 
 
   run java8 tests
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] soroshsabz commented on issue #2461: windows server support needed!

[GitBox]

soroshsabz commented on issue #2461: windows server support needed!
URL: https://github.com/apache/pulsar/issues/2461#issuecomment-478824067
 
 
   A [vcpkg](https://github.com/Microsoft/vcpkg) support would make all this 
much simpler :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] soroshsabz commented on issue #2990: [Feature request] Conan recipe to build C++ client and publication to conan-center

[GitBox]

soroshsabz commented on issue #2990: [Feature request] Conan recipe to build 
C++ client and publication to conan-center
URL: https://github.com/apache/pulsar/issues/2990#issuecomment-478823810
 
 
   related to #3800 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] soroshsabz edited a comment on issue #2990: [Feature request] Conan recipe to build C++ client and publication to conan-center

[GitBox]

soroshsabz edited a comment on issue #2990: [Feature request] Conan recipe to 
build C++ client and publication to conan-center
URL: https://github.com/apache/pulsar/issues/2990#issuecomment-478823442
 
 
   ITNOA
   
   `__builtin_expect` does not exist in Windows on MSVC, did you any plan to 
resolve this?
   
   I think vcpkg is popular package manager too, so I think adding pulsar to 
vcpkg is important too, but we can see many errors on this 
[procedure](https://github.com/Microsoft/vcpkg/pull/5693)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] soroshsabz commented on issue #2990: [Feature request] Conan recipe to build C++ client and publication to conan-center

[GitBox]

soroshsabz commented on issue #2990: [Feature request] Conan recipe to build 
C++ client and publication to conan-center
URL: https://github.com/apache/pulsar/issues/2990#issuecomment-478823442
 
 
   ITNOA
   
   `__builtin_expect` does not exist in Windows on MSVC, did you any plan to 
resolve this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

[GitBox]

wolfstudy commented on a change in pull request #3904: [go schema] support go 
schema for pulsar-client-go
URL: https://github.com/apache/pulsar/pull/3904#discussion_r271115850
 
 

 ##
 File path: pulsar-client-go/pulsar/binaryfreelist.go
 ##
 @@ -0,0 +1,318 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package pulsar
+
+import (
+   "encoding/binary"
+   "fmt"
+   "io"
+   "math"
+)
+
+const (
+   IoMaxSize = 1024
+   maxBorrowSize = 10
+)
+
+var (
+   bigEndian = binary.BigEndian
+)
+
+type BinaryFreeList chan []byte
+
+var BinarySerializer BinaryFreeList = make(chan []byte, IoMaxSize)
+
+func (b BinaryFreeList) Borrow() (buf []byte) {
+   select {
+   case buf = <-b:
+   default:
+   buf = make([]byte, maxBorrowSize)
+
+   }
+   return buf[:maxBorrowSize]
+}
+
+func (b BinaryFreeList) Return(buf []byte) {
+   select {
+   case b <- buf:
+   default:
+   }
+}
+
+func (b BinaryFreeList) Uint8(r io.Reader) (uint8, error) {
+   buf := b.Borrow()[:1]
+   if _, err := io.ReadFull(r, buf); err != nil {
+   b.Return(buf)
+   return 0, err
+   }
+   rv := buf[0]
+   b.Return(buf)
+   return rv, nil
+}
+
+func (b BinaryFreeList) Uint16(r io.Reader, byteOrder binary.ByteOrder) 
(uint16, error) {
+   buf := b.Borrow()[:2]
+   if _, err := io.ReadFull(r, buf); err != nil {
+   b.Return(buf)
+   return 0, err
+   }
+   rv := byteOrder.Uint16(buf)
+   b.Return(buf)
+   return rv, nil
+}
+
+func (b BinaryFreeList) Uint32(r io.Reader, byteOrder binary.ByteOrder) 
(uint32, error) {
+   buf := b.Borrow()[:4]
+   if _, err := io.ReadFull(r, buf); err != nil {
+   b.Return(buf)
+   return 0, err
+   }
+   rv := byteOrder.Uint32(buf)
+   b.Return(buf)
+   return rv, nil
+}
+
+func (b BinaryFreeList) Uint64(r io.Reader, byteOrder binary.ByteOrder) 
(uint64, error) {
+   buf := b.Borrow()[:8]
+   if _, err := io.ReadFull(r, buf); err != nil {
+   b.Return(buf)
+   return 0, err
+   }
+   rv := byteOrder.Uint64(buf)
+   b.Return(buf)
+   return rv, nil
+}
+
+func (b BinaryFreeList) Float64(buf []byte) (float64, error) {
+   if len(buf) < 8 {
+   return 0, fmt.Errorf("cannot decode binary double: %s", 
io.ErrShortBuffer)
+   }
+   return math.Float64frombits(binary.BigEndian.Uint64(buf[:8])), nil
+}
+
+func (b BinaryFreeList) Float32(buf []byte) (float32, error) {
+   if len(buf) < 4 {
+   return 0, fmt.Errorf("cannot decode binary float: %s", 
io.ErrShortBuffer)
+   }
+   return math.Float32frombits(binary.BigEndian.Uint32(buf[:4])), nil
+}
+
+func (b BinaryFreeList) PutUint8(w io.Writer, val uint8) error {
+   buf := b.Borrow()[:1]
+   buf[0] = val
+   _, err := w.Write(buf)
+   b.Return(buf)
+   return err
+}
+
+func (b BinaryFreeList) PutUint16(w io.Writer, byteOrder binary.ByteOrder, val 
uint16) error {
+   buf := b.Borrow()[:2]
+   byteOrder.PutUint16(buf, val)
+   _, err := w.Write(buf)
+   b.Return(buf)
+   return err
+}
+
+func (b BinaryFreeList) PutUint32(w io.Writer, byteOrder binary.ByteOrder, val 
uint32) error {
+
+   buf := b.Borrow()[:4]
+   byteOrder.PutUint32(buf, val)
+   _, err := w.Write(buf)
+   b.Return(buf)
+   return err
+}
+
+func (b BinaryFreeList) PutUint64(w io.Writer, byteOrder binary.ByteOrder, val 
uint64) error {
+   buf := b.Borrow()[:8]
+   byteOrder.PutUint64(buf, val)
+   _, err := w.Write(buf)
+   b.Return(buf)
+   return err
+}
+
+func (b BinaryFreeList) PutFloat64(datum interface{}) ([]byte, error) {
+   var value float64
+   switch v := datum.(type) {
+   case float64:
+   value = v
+   case float32:
+   value = float64(v)
+   case int:
+   if value = float64(v); int(value) != v {
+   return nil, fmt.Errorf("serialize failed: provided Go 
int would lose precision: %d", v)
+   }
+   case int64:
+   if value 

[GitHub] [pulsar] murong00 commented on issue #3853: [Issue 3851] [pulsar-broker] Support to start broker use the port initialized in cluster metadata

[GitBox]

murong00 commented on issue #3853: [Issue 3851] [pulsar-broker] Support to 
start broker use the port initialized in cluster metadata
URL: https://github.com/apache/pulsar/pull/3853#issuecomment-478807955
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] rdhabalia opened a new pull request #3961: [pulsar-broker] add producer/consumer id in error-logging

[GitBox]

rdhabalia opened a new pull request #3961: [pulsar-broker] add 
producer/consumer id in error-logging
URL: https://github.com/apache/pulsar/pull/3961
 
 
   ### Motivation
   
   Log Producer/Consumer Id when broker logs "Producer/consumer is already 
connected" to help in debugging when client is keep failing to create producer 
and broker is keep logging  the same error.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3960: Fixed reader reading from a partition

[GitBox]

merlimat commented on issue #3960: Fixed reader reading from a partition
URL: https://github.com/apache/pulsar/pull/3960#issuecomment-478772968
 
 
   run java8 tests
   run integration tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3956: Exposing getSchemaVersion in the client by making it public. (#3744)

[GitBox]

merlimat commented on issue #3956: Exposing getSchemaVersion in the client by 
making it public. (#3744)
URL: https://github.com/apache/pulsar/pull/3956#issuecomment-478718049
 
 
   run java8 tests
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat opened a new pull request #3960: Fixed reader reading from a partition

[GitBox]

merlimat opened a new pull request #3960: Fixed reader reading from a partition
URL: https://github.com/apache/pulsar/pull/3960
 
 
   ### Motivation
   
   When reader is reading from a partition in a partitioned topic, is currently 
getting stuck. The reason is that the initial batch of permits is never sent to 
broker.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] skyrocknroll commented on issue #3945: [#3944][dashboard]Dashboard authentication support for JWT token

[GitBox]

skyrocknroll commented on issue #3945: [#3944][dashboard]Dashboard 
authentication support for JWT token
URL: https://github.com/apache/pulsar/pull/3945#issuecomment-478690205
 
 
   locally it works and does not break. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3840: [issue 3838] [schema] : Allow incompatible schemas to co-exist on a topic

[GitBox]

merlimat commented on issue #3840: [issue 3838] [schema] : Allow incompatible 
schemas to co-exist on a topic
URL: https://github.com/apache/pulsar/pull/3840#issuecomment-478689606
 
 
   Merged in 2.3.1 at 
   5dd2f47


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3890: By default use `journalFormatVersionToWrite=5` for Bookie journal

[GitBox]

merlimat commented on issue #3890: By default use 
`journalFormatVersionToWrite=5` for Bookie journal
URL: https://github.com/apache/pulsar/pull/3890#issuecomment-478689512
 
 
   Merged in 2.3.1 at 
   16f0e7b


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3923: Fix comments of schema compatibility strategy.

[GitBox]

merlimat commented on issue #3923: Fix comments of schema compatibility 
strategy.
URL: https://github.com/apache/pulsar/pull/3923#issuecomment-478689280
 
 
   Merged in 2.3.1 at 
   f3a77b7


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3907: Misc Function fixes

[GitBox]

merlimat commented on issue #3907: Misc Function fixes
URL: https://github.com/apache/pulsar/pull/3907#issuecomment-478689509
 
 
   Merged in 2.3.1 at 
   6e8320a


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3934: fix submit function via url

[GitBox]

merlimat commented on issue #3934: fix submit function via url
URL: https://github.com/apache/pulsar/pull/3934#issuecomment-478689183
 
 
   Merged in 2.3.1 at 
   04de22e


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[pulsar] branch branch-2.3 updated (47f85a1 -> 04de22e)

[mmerli]

This is an automated email from the ASF dual-hosted git repository.

mmerli pushed a change to branch branch-2.3
in repository https://gitbox.apache.org/repos/asf/pulsar.git.


from 47f85a1  Issue #3211: Fix NPE when creating schema after deleting a 
schema (#3836)
 new 5dd2f47  issue#3838 : Allow incompatible schemas to co-exist on a 
topic, allow set-schema-autoupdate-strategy = none (#3840)
 new 16f0e7b  By default use `journalFormatVersionToWrite=5` for Bookie 
journal (#3890)
 new 6e8320a  Misc Function fixes:- (#3907)
 new f3a77b7  Fix comments of schema compatibility strategy. (#3923)
 new 04de22e  fix submit function via url (#3934)

The 2985 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 conf/bookkeeper.conf   |  29 +++--
 ...bilityCheck.java => AlwaysSchemaValidator.java} |  13 ++-
 .../schema/SchemaCompatibilityStrategy.java|  11 +-
 .../apache/pulsar/io/PulsarFunctionE2ETest.java| 123 +++--
 .../org/apache/pulsar/admin/cli/CmdNamespaces.java |   2 +
 .../SchemaAutoUpdateCompatibilityStrategy.java |   8 +-
 .../pulsar/functions/instance/ContextImpl.java |   7 +-
 .../functions/instance/JavaInstanceRunnable.java   |  10 +-
 .../pulsar/functions/instance/ContextImplTest.java |   1 -
 .../org/apache/pulsar/functions/utils/Utils.java   |  44 ++--
 site2/docs/reference-pulsar-admin.md   |  23 +++-
 .../integration/cli/SchemaUpdateStrategyTest.java  |  55 -
 12 files changed, 249 insertions(+), 77 deletions(-)
 copy 
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/{ProtobufSchemaCompatibilityCheck.java
 => AlwaysSchemaValidator.java} (71%)

[GitHub] [pulsar] merlimat commented on issue #3956: Exposing getSchemaVersion in the client by making it public. (#3744)

[GitBox]

merlimat commented on issue #3956: Exposing getSchemaVersion in the client by 
making it public. (#3744)
URL: https://github.com/apache/pulsar/pull/3956#issuecomment-478685348
 
 
   Yes, picking this up 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3956: Exposing getSchemaVersion in the client by making it public. (#3744)

[GitBox]

merlimat commented on issue #3956: Exposing getSchemaVersion in the client by 
making it public. (#3744)
URL: https://github.com/apache/pulsar/pull/3956#issuecomment-478685472
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3938: Upgrade third party libraries with security vulnerabilities

[GitBox]

merlimat commented on issue #3938: Upgrade third party libraries with security 
vulnerabilities
URL: https://github.com/apache/pulsar/pull/3938#issuecomment-478684733
 
 
   Merged in 2.3.1 at
   cbd2f64


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3940: [schema] store schema type correctly in schema registry

[GitBox]

merlimat commented on issue #3940: [schema] store schema type correctly in 
schema registry
URL: https://github.com/apache/pulsar/pull/3940#issuecomment-478684813
 
 
   Merged in 2.3.1 at 
   ea94ba0


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3932: Cleanup logic in JavaInstanceRunnable close method

[GitBox]

merlimat commented on issue #3932: Cleanup logic in JavaInstanceRunnable close 
method
URL: https://github.com/apache/pulsar/pull/3932#issuecomment-478684231
 
 
   Merged in 2.3.1 at 
   d1c17cd


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3929: [3928][tiered-storage] Include java-xmlbuilder in tiered-storage-jcloud NAR

[GitBox]

merlimat commented on issue #3929: [3928][tiered-storage] Include 
java-xmlbuilder in tiered-storage-jcloud NAR
URL: https://github.com/apache/pulsar/pull/3929#issuecomment-478684144
 
 
   Merged in 2.3.1 at 
   ec3d635


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3922: [Issue 3908] [pulsar-client-tool] Fix source/sink creation to use JSON config values

[GitBox]

merlimat commented on issue #3922: [Issue 3908] [pulsar-client-tool] Fix 
source/sink creation to use JSON config values
URL: https://github.com/apache/pulsar/pull/3922#issuecomment-478683862
 
 
   Merged in 2.3.1 at 
   a465530


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3920: Fix: unloading namespace logging

[GitBox]

merlimat commented on issue #3920: Fix: unloading namespace logging
URL: https://github.com/apache/pulsar/pull/3920#issuecomment-478683783
 
 
   Merged in 2.3.1 at 
   ee76078


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3913: Fixed manual offloading when the last ledger is empty

[GitBox]

merlimat commented on issue #3913: Fixed manual offloading when the last ledger 
is empty
URL: https://github.com/apache/pulsar/pull/3913#issuecomment-478683680
 
 
   Merged in 2.3.1 at
   3418de9


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3900: Logical type use

[GitBox]

merlimat commented on issue #3900: Logical type use
URL: https://github.com/apache/pulsar/pull/3900#issuecomment-478683347
 
 
   Merged in 2.3.1 at 
   0bc17d1


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3899: [Issue 3896] [pulsar-io] Fix NPE in ElasticSearchSink

[GitBox]

merlimat commented on issue #3899: [Issue 3896] [pulsar-io] Fix NPE in 
ElasticSearchSink
URL: https://github.com/apache/pulsar/pull/3899#issuecomment-478683250
 
 
   Merged in 2.3.1 at 
   3bfc264


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[pulsar] branch merlimat-patch-4 deleted (was 2ff9eb2)

[mmerli]

This is an automated email from the ASF dual-hosted git repository.

mmerli pushed a change to branch merlimat-patch-4
in repository https://gitbox.apache.org/repos/asf/pulsar.git.


 was 2ff9eb2  Also set fileInfoFormatVersionToWrite=0

The revisions that were on this branch are still contained in
other references; therefore, this change does not discard any commits
from the repository.

[GitHub] [pulsar] merlimat commented on issue #3872: Add ability to specify runtime flags in functions/sources/sinks

[GitBox]

merlimat commented on issue #3872: Add ability to specify runtime flags in 
functions/sources/sinks
URL: https://github.com/apache/pulsar/pull/3872#issuecomment-478682739
 
 
   Merged in 2.3.1 at 
   0e378dc


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3871: Enable generation of swagger definitions for functions/sources/sinks

[GitBox]

merlimat commented on issue #3871: Enable generation of swagger definitions for 
functions/sources/sinks
URL: https://github.com/apache/pulsar/pull/3871#issuecomment-478682637
 
 
   Merged in 2.3.1 at fa3bc7e
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3870: [schema] Batch message should propagate the schema version from single message

[GitBox]

merlimat commented on issue #3870: [schema] Batch message should propagate the 
schema version from single message
URL: https://github.com/apache/pulsar/pull/3870#issuecomment-478682015
 
 
   Merged in 2.3.1 at 
   a9c4738


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3866: Added sensitive annotations

[GitBox]

merlimat commented on issue #3866: Added sensitive annotations
URL: https://github.com/apache/pulsar/pull/3866#issuecomment-478681901
 
 
   Merged in 2.3.1 at 
   a9c4738


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3865: Classloader choice for validating Source/Sink

[GitBox]

merlimat commented on issue #3865: Classloader choice for validating Source/Sink
URL: https://github.com/apache/pulsar/pull/3865#issuecomment-478681296
 
 
   Merged in 2.3.1 at 
   4959f51


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3864: Fixed reading from file with newlines

[GitBox]

merlimat commented on issue #3864: Fixed reading from file with newlines
URL: https://github.com/apache/pulsar/pull/3864#issuecomment-478681216
 
 
   Merged in 2.3.1 at 
   c216dc0


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3863: [cpp client] implement reference count for close()

[GitBox]

merlimat commented on issue #3863: [cpp client] implement reference count for 
close()
URL: https://github.com/apache/pulsar/pull/3863#issuecomment-478681124
 
 
   Merged in 2.3.1 at 
   5f3f5cf


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3858: Use `PULSAR_PREFIX_` for appending new keys

[GitBox]

merlimat commented on issue #3858: Use `PULSAR_PREFIX_` for appending new keys
URL: https://github.com/apache/pulsar/pull/3858#issuecomment-478680967
 
 
   Merged in 2.3.1 at 
   780ba31


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3862: [pulsar-client] Fix pulsar-cpp crash on lookup timeout

[GitBox]

merlimat commented on issue #3862: [pulsar-client] Fix pulsar-cpp crash on 
lookup timeout
URL: https://github.com/apache/pulsar/pull/3862#issuecomment-478681025
 
 
   Merged in 2.3.1 at 
   709d49b 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3852: [Issue-3850]Fix the loop of wrapper consumer poll

[GitBox]

merlimat commented on issue #3852: [Issue-3850]Fix the loop of wrapper consumer 
poll
URL: https://github.com/apache/pulsar/pull/3852#issuecomment-478680810
 
 
   Merged in 2.3.1 at 
   95b4414


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3847: Fix set-project-version.sh

[GitBox]

merlimat commented on issue #3847: Fix set-project-version.sh
URL: https://github.com/apache/pulsar/pull/3847#issuecomment-478680658
 
 
   Merged in 2.3.1 at 
   9160c14


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3856: [pulsar-client] add Date/Time/Timestamp schema

[GitBox]

merlimat commented on issue #3856: [pulsar-client] add Date/Time/Timestamp 
schema
URL: https://github.com/apache/pulsar/pull/3856#issuecomment-478680904
 
 
   Merged in 2.3.1 at 
   2fecbd6


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3849: [stats] Expose namespace topics count when exposing topic level metrics

[GitBox]

merlimat commented on issue #3849: [stats] Expose namespace topics count when 
exposing topic level metrics
URL: https://github.com/apache/pulsar/pull/3849#issuecomment-478680744
 
 
   Merged in 2.3.1 at 
   5e79dd4


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3845: Issue #3807: Fix s3 support for s3 api

[GitBox]

merlimat commented on issue #3845: Issue #3807: Fix s3 support for s3 api
URL: https://github.com/apache/pulsar/pull/3845#issuecomment-478680581
 
 
   Merged in 2.3.1 at 
   eb96f93


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3836: Issue #3211: Fix NPE when creating schema after deleting a schema

[GitBox]

merlimat commented on issue #3836: Issue #3211: Fix NPE when creating schema 
after deleting a schema
URL: https://github.com/apache/pulsar/pull/3836#issuecomment-478679837
 
 
   Merged in 2.3.1 at 47f85a1


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[pulsar] branch branch-2.3 updated: Issue #3211: Fix NPE when creating schema after deleting a schema (#3836)

[mmerli]

This is an automated email from the ASF dual-hosted git repository.

mmerli pushed a commit to branch branch-2.3
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/branch-2.3 by this push:
 new 47f85a1  Issue #3211: Fix NPE when creating schema after deleting a 
schema (#3836)
47f85a1 is described below

commit 47f85a1ddf27ca2b952ac8820537e9e0abd667b7
Author: Sijie Guo 
AuthorDate: Tue Mar 19 23:19:05 2019 +0800

Issue #3211: Fix NPE when creating schema after deleting a schema (#3836)

Fixes #3211
Fixes #2786

*Motivation*

When a schema is deleted, the schema is not removed directly.
You can still fetch the latest schema but its state is marked as `deleted`.

So when we apply schema compatibility check, we should ignore deleted 
schema.

*Modifications*

Ignore deleted schema when doing schema compatibility check
---
 .../service/schema/SchemaRegistryServiceImpl.java  |  15 ++-
 .../tests/integration/schema/SchemaTest.java   | 110 +
 .../pulsar/tests/integration/schema/Schemas.java   |  79 +++
 3 files changed, 200 insertions(+), 4 deletions(-)

diff --git 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistryServiceImpl.java
 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistryServiceImpl.java
index f066908..9b47368 100644
--- 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistryServiceImpl.java
+++ 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistryServiceImpl.java
@@ -85,8 +85,12 @@ public class SchemaRegistryServiceImpl implements 
SchemaRegistryService {
 @NotNull
 public CompletableFuture putSchemaIfAbsent(String schemaId, 
SchemaData schema,
   
SchemaCompatibilityStrategy strategy) {
-return getSchema(schemaId).thenApply(
-(existingSchema) -> existingSchema == null || 
isCompatible(existingSchema, schema, strategy))
+return getSchema(schemaId)
+.thenApply(
+(existingSchema) ->
+existingSchema == null
+|| existingSchema.schema.isDeleted()
+|| isCompatible(existingSchema, schema, strategy))
 .thenCompose(isCompatible -> {
 if (isCompatible) {
 byte[] context = 
hashFunction.hashBytes(schema.getData()).asBytes();
@@ -151,8 +155,11 @@ public class SchemaRegistryServiceImpl implements 
SchemaRegistryService {
 
 private CompletableFuture checkCompatibilityWithLatest(String 
schemaId, SchemaData schema,
 
SchemaCompatibilityStrategy strategy) {
-return getSchema(schemaId).thenApply(
-(existingSchema) -> existingSchema != null && 
isCompatible(existingSchema, schema, strategy));
+return getSchema(schemaId)
+.thenApply(
+(existingSchema) ->
+!(existingSchema == null || 
existingSchema.schema.isDeleted())
+&& isCompatible(existingSchema, schema, strategy));
 }
 
 interface Functions {
diff --git 
a/tests/integration/src/test/java/org/apache/pulsar/tests/integration/schema/SchemaTest.java
 
b/tests/integration/src/test/java/org/apache/pulsar/tests/integration/schema/SchemaTest.java
new file mode 100644
index 000..fab2542
--- /dev/null
+++ 
b/tests/integration/src/test/java/org/apache/pulsar/tests/integration/schema/SchemaTest.java
@@ -0,0 +1,110 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.tests.integration.schema;
+
+import static org.apache.pulsar.common.naming.TopicName.PUBLIC_TENANT;
+
+import com.google.common.collect.Sets;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.pulsar.client.admin.PulsarAdmin;
+import org.apache.pulsar.client.api.Producer;
+import org.apache.pulsar.client.api.PulsarClient;
+import org.apache.pulsar.client.api.Schema;
+import org.apache.pulsar.common.naming

[GitHub] [pulsar] merlimat commented on issue #3834: Use correct number of messages in batch for publish rate stats during replication

[GitBox]

merlimat commented on issue #3834: Use correct number of messages in batch for 
publish rate stats during replication
URL: https://github.com/apache/pulsar/pull/3834#issuecomment-478679387
 
 
   Merged in 2.3.1 at 
   e88fed4


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3830: Fix read batching message by pulsar reader

[GitBox]

merlimat commented on issue #3830: Fix read batching message by pulsar reader
URL: https://github.com/apache/pulsar/pull/3830#issuecomment-478679298
 
 
   Merged in 2.3.1 at 
   8e3f014


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3827: Expand add env functionality to add variables if not present

[GitBox]

merlimat commented on issue #3827: Expand add env functionality to add 
variables if not present
URL: https://github.com/apache/pulsar/pull/3827#issuecomment-478679096
 
 
   Merged in 2.3.1 at
   780ba31


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3829: [Issue 3806] Fix NPE while call PartitionedProducerImpl.getStats()

[GitBox]

merlimat commented on issue #3829: [Issue 3806] Fix NPE while call 
PartitionedProducerImpl.getStats()
URL: https://github.com/apache/pulsar/pull/3829#issuecomment-478679155
 
 
   Merged in 2.3.1 at 
   ede6f6e


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3826: [Issue #3810][pulsar-broker] Implement configurable token auth claim

[GitBox]

merlimat commented on issue #3826: [Issue #3810][pulsar-broker] Implement 
configurable token auth claim
URL: https://github.com/apache/pulsar/pull/3826#issuecomment-478678962
 
 
   Merged in 2.3.1 at
   9355a19


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3808: Issue #3803: Make ManagedLedger read batch size configurable

[GitBox]

merlimat commented on issue #3808: Issue #3803: Make ManagedLedger read batch 
size configurable
URL: https://github.com/apache/pulsar/pull/3808#issuecomment-478678793
 
 
   Merged in 2.3.1 at 
   e091a9b


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3801: fix message_id_serialize to empty slice

[GitBox]

merlimat commented on issue #3801: fix message_id_serialize to empty slice
URL: https://github.com/apache/pulsar/pull/3801#issuecomment-478678732
 
 
   Merged in 2.3.1 at 
   d131a2b


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3795: Feature - implement reference count for ConsumerImpl

[GitBox]

merlimat commented on issue #3795: Feature - implement reference count for 
ConsumerImpl
URL: https://github.com/apache/pulsar/pull/3795#issuecomment-478678653
 
 
   Merged in 2.3.1 at 
   e190534


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3792: [pulsar-webscoket] avoid creating temp list of metrics on every-metrics generator

[GitBox]

merlimat commented on issue #3792: [pulsar-webscoket] avoid creating temp list 
of metrics on every-metrics generator
URL: https://github.com/apache/pulsar/pull/3792#issuecomment-478678584
 
 
   Merged in 2.3.1 at 
   449f2f5


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3787: Fixed increasing consumer permits after ack dedup operation

[GitBox]

merlimat commented on issue #3787: Fixed increasing consumer permits after ack 
dedup operation
URL: https://github.com/apache/pulsar/pull/3787#issuecomment-478678480
 
 
   Merged in 2.3.1 at 
   7f6d36d


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie closed issue #3777: Documentation: link in standalone page failed

[GitBox]

sijie closed issue #3777: Documentation: link in standalone page failed
URL: https://github.com/apache/pulsar/issues/3777
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[pulsar] branch master updated: Update connector download URL (#3793)

[sijie]

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
 new 2782dcf  Update connector download URL (#3793)
2782dcf is described below

commit 2782dcf36124b3544ffc013697cd637e2fd7ad1c
Author: Like 
AuthorDate: Tue Apr 2 01:49:34 2019 +0800

Update connector download URL (#3793)

Closes #3777
---
 site2/docs/deploy-bare-metal.md   | 19 +--
 site2/docs/getting-started-standalone.md  | 19 +--
 site2/website/scripts/replace.js  |  2 ++
 .../versioned_docs/version-2.3.0/deploy-bare-metal.md | 19 +--
 .../version-2.3.0/getting-started-standalone.md   | 19 +--
 5 files changed, 22 insertions(+), 56 deletions(-)

diff --git a/site2/docs/deploy-bare-metal.md b/site2/docs/deploy-bare-metal.md
index f1780f6..9bb7978 100644
--- a/site2/docs/deploy-bare-metal.md
+++ b/site2/docs/deploy-bare-metal.md
@@ -117,27 +117,18 @@ one of the following ways:
 * using [wget](https://www.gnu.org/software/wget):
 
   ```shell
-  $ wget pulsar:connector_release_url
+  $ wget pulsar:connector_release_url/{connector}-{{pulsar:version}}.nar
   ```
 
-Once the tarball is downloaded, in the pulsar directory, untar the 
io-connectors package and copy the connectors as `connectors`
-in the pulsar directory:
+Once the nar file is downloaded, copy the file to directory `connectors` in 
the pulsar directory, 
+for example, if the connector file 
`pulsar-io-aerospike-{{pulsar:version}}.nar` is downloaded:
 
 ```bash
-$ tar xvfz apache-pulsar-io-connectors-{{pulsar:version}}-bin.tar.gz
-
-// you will find a directory named 
`apache-pulsar-io-connectors-{{pulsar:version}}` in the pulsar directory
-// then copy the connectors
-
-$ mv apache-pulsar-io-connectors-{{pulsar:version}}/connectors connectors
+$ mkdir connectors
+$ mv pulsar-io-aerospike-{{pulsar:version}}.nar connectors
 
 $ ls connectors
 pulsar-io-aerospike-{{pulsar:version}}.nar
-pulsar-io-cassandra-{{pulsar:version}}.nar
-pulsar-io-kafka-{{pulsar:version}}.nar
-pulsar-io-kinesis-{{pulsar:version}}.nar
-pulsar-io-rabbitmq-{{pulsar:version}}.nar
-pulsar-io-twitter-{{pulsar:version}}.nar
 ...
 ```
 
diff --git a/site2/docs/getting-started-standalone.md 
b/site2/docs/getting-started-standalone.md
index 7947b5c..61848e5 100644
--- a/site2/docs/getting-started-standalone.md
+++ b/site2/docs/getting-started-standalone.md
@@ -74,27 +74,18 @@ If you would like to enable those `builtin` connectors, you 
can download the con
 * using [wget](https://www.gnu.org/software/wget):
 
   ```shell
-  $ wget pulsar:connector_release_url
+  $ wget pulsar:connector_release_url/{connector}-{{pulsar:version}}.nar
   ```
 
-Once the tarball is downloaded, in the pulsar directory, untar the 
io-connectors package and copy the connectors as `connectors`
-in the pulsar directory:
+Once the nar file is downloaded, copy the file to directory `connectors` in 
the pulsar directory, 
+for example, if the connector file 
`pulsar-io-aerospike-{{pulsar:version}}.nar` is downloaded:
 
 ```bash
-$ tar xvfz /path/to/apache-pulsar-io-connectors-{{pulsar:version}}-bin.tar.gz
-
-// you will find a directory named 
`apache-pulsar-io-connectors-{{pulsar:version}}` in the pulsar directory
-// then copy the connectors
-
-$ cp -r apache-pulsar-io-connectors-{{pulsar:version}}/connectors connectors
+$ mkdir connectors
+$ mv pulsar-io-aerospike-{{pulsar:version}}.nar connectors
 
 $ ls connectors
 pulsar-io-aerospike-{{pulsar:version}}.nar
-pulsar-io-cassandra-{{pulsar:version}}.nar
-pulsar-io-kafka-{{pulsar:version}}.nar
-pulsar-io-kinesis-{{pulsar:version}}.nar
-pulsar-io-rabbitmq-{{pulsar:version}}.nar
-pulsar-io-twitter-{{pulsar:version}}.nar
 ...
 ```
 
diff --git a/site2/website/scripts/replace.js b/site2/website/scripts/replace.js
index 88e20fc..29bb322 100644
--- a/site2/website/scripts/replace.js
+++ b/site2/website/scripts/replace.js
@@ -32,6 +32,8 @@ function binaryReleaseUrl(version) {
 function connectorReleaseUrl(version) {
 if (version.includes('incubating')) {
 return 
`https://archive.apache.org/dist/incubator/pulsar/pulsar-${version}/apache-pulsar-io-connectors-${version}-bin.tar.gz`
+} else if (version >= '2.3.0') {
+return 
`https://archive.apache.org/dist/pulsar/pulsar-${version}/connectors`
 } else {
 return 
`https://archive.apache.org/dist/pulsar/pulsar-${version}/apache-pulsar-io-connectors-${version}-bin.tar.gz`
 }
diff --git a/site2/website/versioned_docs/version-2.3.0/deploy-bare-metal.md 
b/site2/website/versioned_docs/version-2.3.0/deploy-bare-metal.md
index 6c4c594..0699b44 100644
--- a/site2/website/versioned_docs/version-2.3.0/deploy-bare-metal.md
+++ b/site2/website/versioned_docs/version-2.3.0/deploy-bare-metal.md
@@ -118,27 +118,18 @@ one of 

[GitHub] [pulsar] merlimat commented on issue #3782: Make Python consumers acks async

[GitBox]

merlimat commented on issue #3782: Make Python consumers acks async
URL: https://github.com/apache/pulsar/pull/3782#issuecomment-478678007
 
 
   Merge  in 2.3.1 at 
   15d2c3c


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie merged pull request #3793: Update connector download URL

[GitBox]

sijie merged pull request #3793: Update connector download URL
URL: https://github.com/apache/pulsar/pull/3793
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3776: Use at least 8 threads in Jetty thread pool

[GitBox]

merlimat commented on issue #3776: Use at least 8 threads in Jetty thread pool
URL: https://github.com/apache/pulsar/pull/3776#issuecomment-478677899
 
 
   Merged in 2.3.1 at 
   49baf5d


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3771: fix: function config cleanupSubscription update bug

[GitBox]

merlimat commented on issue #3771: fix: function config cleanupSubscription 
update bug
URL: https://github.com/apache/pulsar/pull/3771#issuecomment-478677763
 
 
   Merged in 2.3.1 at 
   84dba37


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3766: Support passing schema definition for JSON and AVRO schemas

[GitBox]

merlimat commented on issue #3766: Support passing schema definition for JSON 
and AVRO schemas
URL: https://github.com/apache/pulsar/pull/3766#issuecomment-478677452
 
 
   Merged in 2.3.1 at 
   41d0979


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3764: Fixed Reader.HasNext() in Go client

[GitBox]

merlimat commented on issue #3764: Fixed Reader.HasNext() in Go client
URL: https://github.com/apache/pulsar/pull/3764#issuecomment-478677375
 
 
   Merged in 2.3.1 at 
   36362ad


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3754: NullPointerException at using BytesSchema.of()

[GitBox]

merlimat commented on issue #3754: NullPointerException at using 
BytesSchema.of()
URL: https://github.com/apache/pulsar/pull/3754#issuecomment-478677148
 
 
   Merged in 2.3.1 at 
   01f868c


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3752: revise the schema default type not null

[GitBox]

merlimat commented on issue #3752: revise the schema default type not null
URL: https://github.com/apache/pulsar/pull/3752#issuecomment-478677080
 
 
   Merged in 2.3.1 at 
   6e76af2


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3751: fix function termination cleanup

[GitBox]

merlimat commented on issue #3751: fix function termination cleanup
URL: https://github.com/apache/pulsar/pull/3751#issuecomment-478677008
 
 
   Merged in 2.3.1 at 
   5d52ccb


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3749: On shutdown, kill the function instance thread after interrupt attempt

[GitBox]

merlimat commented on issue #3749: On shutdown, kill the function instance 
thread after interrupt attempt
URL: https://github.com/apache/pulsar/pull/3749#issuecomment-478676922
 
 
   Merged in 2.3.1 at
   4d4df38


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3748: [cpp client] Bugfix prevent dup consumer for same topic subscription

[GitBox]

merlimat commented on issue #3748: [cpp client] Bugfix prevent dup consumer for 
same topic subscription
URL: https://github.com/apache/pulsar/pull/3748#issuecomment-478676847
 
 
   Merged in 2.3.1 at 
   c6aa56f


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3746: [java client] Bugfix prevent dup consumers for same topic subscription

[GitBox]

merlimat commented on issue #3746: [java client] Bugfix prevent dup consumers 
for same topic subscription
URL: https://github.com/apache/pulsar/pull/3746#issuecomment-478676735
 
 
   Merged in 2.3.1 at 
   cc638d3


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3737: [python client] set protobuf version to be larger than 3.6.0

[GitBox]

merlimat commented on issue #3737: [python client] set protobuf version to be 
larger than 3.6.0
URL: https://github.com/apache/pulsar/pull/3737#issuecomment-478676392
 
 
   Merged in 2.3.1 at 
   18aa430


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3729: fix pulsar_message_set_replication_clusters

[GitBox]

merlimat commented on issue #3729: fix pulsar_message_set_replication_clusters
URL: https://github.com/apache/pulsar/pull/3729#issuecomment-478676311
 
 
   Merged in 2.3.1 at 
   1467937


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3722: Retry creation of assignment topic a few times before giving up

[GitBox]

merlimat commented on issue #3722: Retry creation of assignment topic a few 
times before giving up
URL: https://github.com/apache/pulsar/pull/3722#issuecomment-478676227
 
 
   Merged in 2.3.1 at 
   1e344e0


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3721: Report direct memory used in Proxy to prometheus

[GitBox]

merlimat commented on issue #3721: Report direct memory used in Proxy to 
prometheus
URL: https://github.com/apache/pulsar/pull/3721#issuecomment-478676128
 
 
   Merged in 2.3.1 at 
   399b6da


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3718: In Java allow messages that compress to <5mb to be sent with batching enabled

[GitBox]

merlimat commented on issue #3718: In Java allow messages that compress to <5mb 
to be sent with batching enabled
URL: https://github.com/apache/pulsar/pull/3718#issuecomment-478676035
 
 
   Merged in 2.3.1 at 
   b725d87


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #3956: Exposing getSchemaVersion in the client by making it public. (#3744)

[GitBox]

sijie commented on issue #3956: Exposing getSchemaVersion in the client by 
making it public. (#3744)
URL: https://github.com/apache/pulsar/pull/3956#issuecomment-478676001
 
 
   @merlimat : can you include this in 2.3.1 as well?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3717: Expose Secrets in Source/SinkContext

[GitBox]

merlimat commented on issue #3717: Expose Secrets in Source/SinkContext
URL: https://github.com/apache/pulsar/pull/3717#issuecomment-478675941
 
 
   Merged in 2.3.1 at 
   253381c


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat commented on issue #3714: [Issue #3712][python-client] exposing InitialPosition management in the ConsumerConfiguration.

[GitBox]

merlimat commented on issue #3714: [Issue #3712][python-client] exposing 
InitialPosition management in the ConsumerConfiguration.
URL: https://github.com/apache/pulsar/pull/3714#issuecomment-478675860
 
 
   Merged in 2.3.1 at 
   c078e71


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services