[GitHub] [pulsar] congbobo184 opened a new pull request #4646: [pulsar-sql]deserialize the avro schema data by correct reader

2019-07-01 Thread GitBox
congbobo184 opened a new pull request #4646: [pulsar-sql]deserialize the avro 
schema data by correct reader
URL: https://github.com/apache/pulsar/pull/4646
 
 
   #4607
   Implement the correct avro schema reader to deserialize the message
   
   Motivation
   Implement the correct avro schema reader to deserialize the message
   
   Verifying this change
   Add the test for this
   
   Does this pull request potentially affect one of the following parts:
   If yes was chosen, please highlight the changes
   
   Dependencies (does it add or upgrade a dependency): (no)
   The public API: (no)
   The schema: (no)
   The default values of configurations: (no)
   The wire protocol: (no)
   The rest endpoints: (no)
   The admin cli options: (no)
   Anything that affects deployment: (no)
   
   Documentation
   Does this pull request introduce a new feature? (yes / no)
   If yes, how is the feature documented? (not applicable / docs / JavaDocs / 
not documented)
   If a feature is not applicable for documentation, explain why?
   If a feature is not documented yet in this PR, please create a followup 
issue for adding the documentation


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[pulsar] branch asf-site updated: Updated site at revision cc022f1

2019-07-01 Thread mmerli
This is an automated email from the ASF dual-hosted git repository.

mmerli pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/asf-site by this push:
 new 84f61ac  Updated site at revision cc022f1
84f61ac is described below

commit 84f61ac102bfb40f70159ce33ea21cb4c9c1fd20
Author: jenkins 
AuthorDate: Mon Jul 1 08:43:17 2019 +

Updated site at revision cc022f1
---
 content/swagger/2.5.0-SNAPSHOT/swagger.json| 38 
 .../swagger/2.5.0-SNAPSHOT/swaggerfunctions.json   | 50 +++---
 2 files changed, 44 insertions(+), 44 deletions(-)

diff --git a/content/swagger/2.5.0-SNAPSHOT/swagger.json 
b/content/swagger/2.5.0-SNAPSHOT/swagger.json
index 0728e7d..b88598f 100644
--- a/content/swagger/2.5.0-SNAPSHOT/swagger.json
+++ b/content/swagger/2.5.0-SNAPSHOT/swagger.json
@@ -4777,7 +4777,7 @@
   "200" : {
 "description" : "successful operation",
 "schema" : {
-  "$ref" : "#/definitions/NonPersistentTopicStats"
+  "$ref" : "#/definitions/TopicStats"
 }
   },
   "401" : {
@@ -8638,17 +8638,14 @@
   "type" : "number",
   "format" : "double"
 },
-"bandwidthIn" : {
-  "$ref" : "#/definitions/ResourceUsage"
-},
-"bandwidthOut" : {
-  "$ref" : "#/definitions/ResourceUsage"
+"underLoaded" : {
+  "type" : "boolean"
 },
-"memory" : {
-  "$ref" : "#/definitions/ResourceUsage"
+"overLoaded" : {
+  "type" : "boolean"
 },
-"cpu" : {
-  "$ref" : "#/definitions/ResourceUsage"
+"loadReportType" : {
+  "type" : "string"
 },
 "directMemory" : {
   "$ref" : "#/definitions/ResourceUsage"
@@ -8657,22 +8654,25 @@
   "type" : "integer",
   "format" : "int64"
 },
+"msgThroughputIn" : {
+  "type" : "number",
+  "format" : "double"
+},
 "msgThroughputOut" : {
   "type" : "number",
   "format" : "double"
 },
-"underLoaded" : {
-  "type" : "boolean"
+"cpu" : {
+  "$ref" : "#/definitions/ResourceUsage"
 },
-"overLoaded" : {
-  "type" : "boolean"
+"bandwidthIn" : {
+  "$ref" : "#/definitions/ResourceUsage"
 },
-"loadReportType" : {
-  "type" : "string"
+"bandwidthOut" : {
+  "$ref" : "#/definitions/ResourceUsage"
 },
-"msgThroughputIn" : {
-  "type" : "number",
-  "format" : "double"
+"memory" : {
+  "$ref" : "#/definitions/ResourceUsage"
 }
   }
 },
diff --git a/content/swagger/2.5.0-SNAPSHOT/swaggerfunctions.json 
b/content/swagger/2.5.0-SNAPSHOT/swaggerfunctions.json
index 286b05e..8f21f0d 100644
--- a/content/swagger/2.5.0-SNAPSHOT/swaggerfunctions.json
+++ b/content/swagger/2.5.0-SNAPSHOT/swaggerfunctions.json
@@ -1351,18 +1351,33 @@
 "replicated" : {
   "type" : "boolean"
 },
+"publishTime" : {
+  "type" : "integer",
+  "format" : "int64"
+},
+"eventTime" : {
+  "type" : "integer",
+  "format" : "int64"
+},
+"topicName" : {
+  "type" : "string"
+},
+"producerName" : {
+  "type" : "string"
+},
 "replicatedFrom" : {
   "type" : "string"
 },
-"orderingKey" : {
+"schemaVersion" : {
   "type" : "array",
   "items" : {
 "type" : "string",
 "format" : "byte"
   }
 },
-"encryptionCtx" : {
-  "$ref" : "#/definitions/EncryptionContext"
+"sequenceId" : {
+  "type" : "integer",
+  "format" : "int64"
 },
 "keyBytes" : {
   "type" : "array",
@@ -1371,37 +1386,22 @@
 "format" : "byte"
   }
 },
-"publishTime" : {
-  "type" : "integer",
-  "format" : "int64"
-},
-"eventTime" : {
-  "type" : "integer",
-  "format" : "int64"
-},
-"topicName" : {
-  "type" : "string"
-},
 "messageId" : {
   "$ref" : "#/definitions/MessageId"
 },
-"sequenceId" : {
-  "type" : "integer",
-  "format" : "int64"
-},
-"redeliveryCount" : {
-  "type" : "integer",
-  "format" : "int32"
-},
-"schemaVersion" : {
+"orderingKey" : {
   "type" : "array",
   "items" : {
 "type" : "string",
 "format" : "byte"
   }
 },
-"producerName" : {
-  "type" : "string"
+"encryptionCtx" : {
+  "$ref" : "#/definitions/EncryptionContext"
+},
+

[GitHub] [pulsar] congbobo184 commented on issue #4646: [pulsar-sql]deserialize the avro schema data by correct reader

2019-07-01 Thread GitBox
congbobo184 commented on issue #4646: [pulsar-sql]deserialize the avro schema 
data by correct reader
URL: https://github.com/apache/pulsar/pull/4646#issuecomment-507181513
 
 
   run cpp tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[pulsar.wiki] branch master updated: Updated PIP 34: Add new subscribe type Key_Failover (markdown)

2019-07-01 Thread zhaijia
This is an automated email from the ASF dual-hosted git repository.

zhaijia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new ea2081b  Updated PIP 34: Add new subscribe type Key_Failover (markdown)
ea2081b is described below

commit ea2081be99c0dd7943a14aa18f51d0e451a2bcc2
Author: Jia Zhai 
AuthorDate: Mon Jul 1 17:15:23 2019 +0800

Updated PIP 34: Add new subscribe type Key_Failover (markdown)
---
 ...ey_Failover.md => PIP-34:-Add-new-subscribe-type-Key_shared.md | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/PIP-34:-Add-new-subscribe-type-Key_Failover.md 
b/PIP-34:-Add-new-subscribe-type-Key_shared.md
similarity index 85%
rename from PIP-34:-Add-new-subscribe-type-Key_Failover.md
rename to PIP-34:-Add-new-subscribe-type-Key_shared.md
index e902656..74b24e3 100644
--- a/PIP-34:-Add-new-subscribe-type-Key_Failover.md
+++ b/PIP-34:-Add-new-subscribe-type-Key_shared.md
@@ -9,11 +9,11 @@ At present, there are 3 kinds of subscription modes: 
exclusive, shared, and fail
 
 A failover type subscription with muti-partitions could partly solve the 
issue. but the consumer number is tied with partition number, we could not add 
consumer to quick up message dispatch.
 
-This Proposal trying to introduce a new subscribe type Key_Failover to extend 
shared type. By Key_Failover, one partition could have several consumers to 
parallel consume messages, while all messages with the same key will be 
dispatched to only one consumer.
+This Proposal trying to introduce a new subscribe type Key_shared to extend 
shared type. By Key_shred, one partition could have several consumers to 
parallel consume messages, while all messages with the same key will be 
dispatched to only one consumer.
 
 ## Proposal and changes
 
-The main idea is to bring a hash routing layer in new Key_Failover dispatcher. 
Each consumer in the Key_Failover subscription serves its own ranges of hash 
value. And when a message needs to be dispatched to a consumer, dispatcher 
first get the Key of message, do the hash for the key, and send this message to 
the consumer that serves this hash value.
+The main idea is to bring a hash routing layer in new Key_Shared dispatcher. 
Each consumer in the Key_Shared subscription serves its own ranges of hash 
value. And when a message needs to be dispatched to a consumer, dispatcher 
first get the Key of message, do the hash for the key, and send this message to 
the consumer that serves this hash value.
 
 The main work is on the hash layer and the new dispatcher.
 
@@ -51,7 +51,7 @@ message CommandSubscribe {
Exclusive = 0;
Shared= 1;
Failover  = 2;
-   Key_Failover = 3; // add new type here < ==
+   Key_Shared = 3; // add new type here < ==
}
 
 message MessageMetadata {
@@ -61,7 +61,7 @@ message MessageMetadata {
 
 ### add a new dispatcher in broker side.
 
-KeyFailoverDispatcherMultipleConsumers.
+PersistentStickyKeyDispatcherMultipleConsumers.
 The main methods will include:
 ```
 void addConsumer(Consumer consumer) throws BrokerServiceException {



[GitHub] [pulsar] sijie closed issue #4009: Pulsar Functions add properties to result messages

2019-07-01 Thread GitBox
sijie closed issue #4009: Pulsar Functions add properties to result messages
URL: https://github.com/apache/pulsar/issues/4009
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #4009: Pulsar Functions add properties to result messages

2019-07-01 Thread GitBox
sijie commented on issue #4009: Pulsar Functions add properties to result 
messages
URL: https://github.com/apache/pulsar/issues/4009#issuecomment-507187981
 
 
   This is fixed by #4093 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jiazhai closed issue #4466: token auth not work well for non-persistent topic get

2019-07-01 Thread GitBox
jiazhai closed issue #4466: token auth not work well for non-persistent topic 
get
URL: https://github.com/apache/pulsar/issues/4466
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jiazhai commented on issue #4466: token auth not work well for non-persistent topic get

2019-07-01 Thread GitBox
jiazhai commented on issue #4466: token auth not work well for non-persistent 
topic get
URL: https://github.com/apache/pulsar/issues/4466#issuecomment-507187871
 
 
   dup with #4560 will close this one


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] wolfstudy opened a new issue #4647: [cpp client] fatal error: google/protobuf/port_def.inc: No such file or directory

2019-07-01 Thread GitBox
wolfstudy opened a new issue #4647: [cpp client] fatal error: 
google/protobuf/port_def.inc: No such file or directory
URL: https://github.com/apache/pulsar/issues/4647
 
 
   **Describe the bug**
   When I use `./docker-build.sh` building cpp client, encountered the 
following error:
   
   ```
   /pulsar/pulsar-client-cpp/lib/PulsarApi.pb.h:10:40: fatal error: 
google/protobuf/port_def.inc: No such file or directory
   compilation terminated.
   lib/CMakeFiles/pulsarStatic.dir/build.make:237: recipe for target 
'lib/CMakeFiles/pulsarStatic.dir/CompressionCodecZstd.cc.o' failed
   make[2]: *** [lib/CMakeFiles/pulsarStatic.dir/CompressionCodecZstd.cc.o] 
Error 1
   make[2]: *** Waiting for unfinished jobs
   In file included from /pulsar/pulsar-client-cpp/lib/ClientConnection.h:36:0,
from /pulsar/pulsar-client-cpp/lib/ConnectionPool.h:25,
from /pulsar/pulsar-client-cpp/lib/ConnectionPool.cc:19:
   /pulsar/pulsar-client-cpp/lib/PulsarApi.pb.h:10:40: fatal error: 
google/protobuf/port_def.inc: No such file or directory
   compilation terminated.
   [  4%] Building CXX object lib/CMakeFiles/pulsarStatic.dir/Schema.cc.o
   lib/CMakeFiles/pulsarStatic.dir/build.make:261: recipe for target 
'lib/CMakeFiles/pulsarStatic.dir/ConnectionPool.cc.o' failed
   make[2]: *** [lib/CMakeFiles/pulsarStatic.dir/ConnectionPool.cc.o] Error 1
   In file included from /pulsar/pulsar-client-cpp/lib/ClientConnection.h:36:0,
from /pulsar/pulsar-client-cpp/lib/ConnectionPool.h:25,
from 
/pulsar/pulsar-client-cpp/lib/BinaryProtoLookupService.h:25,
from /pulsar/pulsar-client-cpp/lib/ClientImpl.h:24,
from 
/pulsar/pulsar-client-cpp/lib/UnAckedMessageTrackerInterface.h:27,
from 
/pulsar/pulsar-client-cpp/lib/UnAckedMessageTrackerEnabled.h:21,
from 
/pulsar/pulsar-client-cpp/lib/UnAckedMessageTrackerEnabled.cc:19:
   /pulsar/pulsar-client-cpp/lib/PulsarApi.pb.h:10:40: fatal error: 
google/protobuf/port_def.inc: No such file or directory
   compilation terminated.
   In file included from /pulsar/pulsar-client-cpp/lib/ClientConnection.h:36:0,
from /pulsar/pulsar-client-cpp/lib/ConnectionPool.h:25,
from 
/pulsar/pulsar-client-cpp/lib/BinaryProtoLookupService.h:25,
from /pulsar/pulsar-client-cpp/lib/ClientImpl.h:24,
from /pulsar/pulsar-client-cpp/lib/ReaderImpl.cc:20:
   /pulsar/pulsar-client-cpp/lib/PulsarApi.pb.h:10:40: fatal error: 
google/protobuf/port_def.inc: No such file or directory
   compilation terminated.
   lib/CMakeFiles/pulsarShared.dir/build.make:69: recipe for target 
'lib/CMakeFiles/pulsarShared.dir/UnAckedMessageTrackerEnabled.cc.o' failed
   make[2]: *** 
[lib/CMakeFiles/pulsarShared.dir/UnAckedMessageTrackerEnabled.cc.o] Error 1
   lib/CMakeFiles/pulsarShared.dir/build.make:189: recipe for target 
'lib/CMakeFiles/pulsarShared.dir/ReaderImpl.cc.o' failed
   make[2]: *** [lib/CMakeFiles/pulsarShared.dir/ReaderImpl.cc.o] Error 1
   In file included from /pulsar/pulsar-client-cpp/lib/ClientConnection.h:36:0,
from /pulsar/pulsar-client-cpp/lib/ConnectionPool.h:25,
from /pulsar/pulsar-client-cpp/lib/ConnectionPool.cc:19:
   ```
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] wolfstudy commented on issue #4647: [cpp client] fatal error: google/protobuf/port_def.inc: No such file or directory

2019-07-01 Thread GitBox
wolfstudy commented on issue #4647: [cpp client] fatal error: 
google/protobuf/port_def.inc: No such file or directory
URL: https://github.com/apache/pulsar/issues/4647#issuecomment-507196469
 
 
   This issue has been fixed for the following reasons:
   
   Before I built the cpp client using `docker-build.sh`, I have already built 
the `PulsarApi.pb.h` file locally using `cmake. && make -j12 && make install`. 
The local version of protobuf used is 3.7, but the version used in 
`docker-build.sh` is `libprotoc 2.6.1`, these two versions are not compatible.
   
   ## Solution:
   
   Delete the two files `PulsarApi.pb.h` and `PulsarApi.pb.cc`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] wolfstudy commented on issue #4647: [cpp client] fatal error: google/protobuf/port_def.inc: No such file or directory

2019-07-01 Thread GitBox
wolfstudy commented on issue #4647: [cpp client] fatal error: 
google/protobuf/port_def.inc: No such file or directory
URL: https://github.com/apache/pulsar/issues/4647#issuecomment-507197377
 
 
   When you use the `protobuf` version 3.7 compiled proto file contains the 
following content:
   
   ```
   #ifndef PROTOBUF_INCLUDED_PulsarApi_2eproto
   #define PROTOBUF_INCLUDED_PulsarApi_2eproto
   
   #include 
   #include 
   
   #include  // key point
   #if PROTOBUF_VERSION < 3007000
   ```
   
this is not recognized in `protoc 2.6.1`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] wolfstudy closed issue #4647: [cpp client] fatal error: google/protobuf/port_def.inc: No such file or directory

2019-07-01 Thread GitBox
wolfstudy closed issue #4647: [cpp client] fatal error: 
google/protobuf/port_def.inc: No such file or directory
URL: https://github.com/apache/pulsar/issues/4647
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] codelipenghui opened a new issue #4648: [doc] cause deadlock while use subscribeAsync demo in java client doc.

2019-07-01 Thread GitBox
codelipenghui opened a new issue #4648: [doc] cause deadlock while use 
subscribeAsync demo in java client doc.
URL: https://github.com/apache/pulsar/issues/4648
 
 
   Here is the example in 
http://pulsar.apache.org/docs/en/client-libraries-java/#multi-topic-subscriptions
   
![image](https://user-images.githubusercontent.com/12592133/60428130-c473e580-9c2a-11e9-9c2b-1539d7945b28.png)
   
   Use receive() to get message in subscribeAsync.thenAccept() will cause 
deadlock, because thread will block at receive() and can't call 
sendFlowPermitsToBroker(), so the thread will block forever.
   
   Need to update doc 
http://pulsar.apache.org/docs/en/client-libraries-java/#multi-topic-subscriptions


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] congbobo184 commented on issue #4646: [pulsar-sql]deserialize the avro schema data by correct reader

2019-07-01 Thread GitBox
congbobo184 commented on issue #4646: [pulsar-sql]deserialize the avro schema 
data by correct reader
URL: https://github.com/apache/pulsar/pull/4646#issuecomment-507203679
 
 
   run cpp tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] congbobo184 commented on issue #4646: [pulsar-sql]deserialize the avro schema data by correct reader

2019-07-01 Thread GitBox
congbobo184 commented on issue #4646: [pulsar-sql]deserialize the avro schema 
data by correct reader
URL: https://github.com/apache/pulsar/pull/4646#issuecomment-507203908
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] codelipenghui opened a new pull request #4649: fix cause deadlock while use subscribeAsync demo in java client doc.

2019-07-01 Thread GitBox
codelipenghui opened a new pull request #4649: fix cause deadlock while use 
subscribeAsync demo in java client doc.
URL: https://github.com/apache/pulsar/pull/4649
 
 
   
   Fixes #4648 
   
   ### Motivation
   
   fix cause deadlock while use subscribeAsync demo in java client doc.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] codelipenghui commented on issue #4645: Allows consumer retrieve the sequence id that the producer set.

2019-07-01 Thread GitBox
codelipenghui commented on issue #4645: Allows consumer retrieve the sequence 
id that the producer set.
URL: https://github.com/apache/pulsar/pull/4645#issuecomment-507209372
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[pulsar.wiki] branch master updated: Updated Home (markdown)

2019-07-01 Thread penghui
This is an automated email from the ASF dual-hosted git repository.

penghui pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new a9e71ce  Updated Home (markdown)
a9e71ce is described below

commit a9e71ce99ccf918d6914cfb242b9e5ab3ca268e8
Author: lipenghui 
AuthorDate: Mon Jul 1 18:33:38 2019 +0800

Updated Home (markdown)
---
 Home.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Home.md b/Home.md
index 07a0767..b35ae68 100644
--- a/Home.md
+++ b/Home.md
@@ -19,7 +19,7 @@ We encourage to document any big change or feature or any 
addition to public use
 * [[PIP 21: Pulsar Edge Component]]
 
 ### Accepted
-* [[PIP 34: Add new subscribe type Key_Failover]]
+* [[PIP 34: Add new subscribe type Key_shared]]
 * [[PIP 30: change authentication provider API to support mutual 
authentication]]
 * [[PIP 29: One package for both pulsar-client and pulsar-admin]]
 * [[PIP 27: Add checklist in github pull request template]]



[GitHub] [pulsar] willome opened a new pull request #4650: Issue #4638 : Update Kafka connect-api to version 2.3.0

2019-07-01 Thread GitBox
willome opened a new pull request #4650: Issue #4638 : Update Kafka connect-api 
to version 2.3.0
URL: https://github.com/apache/pulsar/pull/4650
 
 
   Upgrade Kafka connect-api to version 2.3.0 in order to fix an "Unexpected 
exception" at startup with Debezium when using Postgres Debezium connector with 
an nullable "Postgis.Geometry" column.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] codelipenghui commented on issue #4645: Allows consumer retrieve the sequence id that the producer set.

2019-07-01 Thread GitBox
codelipenghui commented on issue #4645: Allows consumer retrieve the sequence 
id that the producer set.
URL: https://github.com/apache/pulsar/pull/4645#issuecomment-507268924
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] codelipenghui commented on issue #4649: fix cause deadlock while use subscribeAsync demo in java client doc.

2019-07-01 Thread GitBox
codelipenghui commented on issue #4649: fix cause deadlock while use 
subscribeAsync demo in java client doc.
URL: https://github.com/apache/pulsar/pull/4649#issuecomment-507269121
 
 
   run cpp tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] avatart93 opened a new issue #4651: HDFS sink with different schema

2019-07-01 Thread GitBox
avatart93 opened a new issue #4651: HDFS sink with different schema
URL: https://github.com/apache/pulsar/issues/4651
 
 
   **Is your feature request related to a problem? Please describe.**
   It seems that the hdfs sink connector can only parse string messages, this 
is a problem when working with schemas or already encoded messages that can't 
be parse to string (let's say encrypted messages for example) and want to send 
those messages to a data lake in hdfs for cold storage.

   **Describe the solution you'd like**
   I would like that the hdfs connector supports schemas different than 
StringSchema, or at least the raw schema (bytes[]).
   
   **Describe alternatives you've considered**
   Implement tiered storage for hdfs as well, S3 wont be a solution if working 
on-premises.
   
   **Additional context**
   If the topic's schema is different to StringSchema you can see the pulsar 
console printing a IncompatibleSchemaException when you try to run the HDFS 
sink connector. If you check the connector's status, you will see a IO 
exception error and multiple retries.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] willome opened a new issue #4652: [Build] erroneous aspectj weaving processing on

2019-07-01 Thread GitBox
willome opened a new issue #4652: [Build] erroneous aspectj weaving processing 
on 
URL: https://github.com/apache/pulsar/issues/4652
 
 
   While building the project, I see this error  in *pulsar-zookeeper-utils*  
module :  
   
   ```bad version number found in 
/root/.m2/repository/org/aspectj/aspectjrt/1.9.2/aspectjrt-1.9.2.jar expected 
1.9.1 found 1.9.2```
   
   and
   
   ```You aren't using a compiler supported by lombok, so lombok will not work 
and has been disabled.
   Your processor is: 
org.aspectj.org.eclipse.jdt.internal.compiler.apt.dispatch.BatchProcessingEnvImpl
   Lombok supports: sun/apple javac 1.6, ECJ
   :```
   
   This probably means that the weaving is not working as expected on this 
module.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] one70six commented on issue #4610: pulsar-admin cli: pulsar functions api issues after changing function parallelism > 1

2019-07-01 Thread GitBox
one70six commented on issue #4610: pulsar-admin cli: pulsar functions api 
issues after changing function parallelism > 1
URL: https://github.com/apache/pulsar/issues/4610#issuecomment-507274999
 
 
   It's like it can't route do to the URL adding the /0 or /1 etc. If that is 
not there, it works fine. I rebuilt the cluster from scratch and it still has 
this issue in 2.3.2. Not sure why it would not happen to your cluster. Is your 
conf file different than mine?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #4569: C++ client producer sendAsync() method will be blocked forever, if enough batched messages sent timeout.

2019-07-01 Thread GitBox
sijie commented on issue #4569: C++ client producer sendAsync() method will be 
blocked forever, if enough batched messages sent timeout.
URL: https://github.com/apache/pulsar/issues/4569#issuecomment-507276361
 
 
   @easyfan are you interested in sending a pull request for it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] wolfstudy opened a new pull request #4653: [issue 4589] Fix redelivered message logic of partition topic

2019-07-01 Thread GitBox
wolfstudy opened a new pull request #4653: [issue 4589] Fix redelivered message 
logic of partition topic
URL: https://github.com/apache/pulsar/pull/4653
 
 
   Fixes #4589
   
   ### Motivation
   
   When using Partition-topic, the logic of redeliver messages will not be 
triggered when the time of `ackTimeout` arrives.
   
   This is because the `unAckedMessageTrackerPtr_->add(msg.getMessageId())` is 
not call in one place
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] wolfstudy commented on issue #4653: [issue 4589] Fix redelivered message logic of partition topic

2019-07-01 Thread GitBox
wolfstudy commented on issue #4653: [issue 4589] Fix redelivered message logic 
of partition topic
URL: https://github.com/apache/pulsar/pull/4653#issuecomment-507282064
 
 
   @cckellogg @merlimat @sijie @jiazhai PTAL, thanks


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] lsroudi opened a new issue #4654: Build failed even trying multiple version of maven

2019-07-01 Thread GitBox
lsroudi opened a new issue #4654: Build failed even trying multiple version of 
maven
URL: https://github.com/apache/pulsar/issues/4654
 
 
   **Is your feature request related to a problem? Please describe.**
   I spent at leat one day trying to build apache pulsar with no success, i 
used : 
   - Vagrant
   - Maven ( i try 3.0.5,3.5.0,3.6.1)
   - Centos
   
   **Describe the solution you'd like**
   I suggest more documentation for that to help new committers to be 
confortable with the project, i can work for it with your help, it can be a 
wiki or others things


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] benstadin opened a new issue #4655: Build fails including Logger.h

2019-07-01 Thread GitBox
benstadin opened a new issue #4655: Build fails including Logger.h
URL: https://github.com/apache/pulsar/issues/4655
 
 
   Using Xcode / clang, the build fails when including Logger.h, because there 
is a log level named DEBUG (build error is "Expected identifier" because XCode 
defines a DEBUG macro per default for the debug target). Renaming it to e.g. 
TDEBUG fixes the issue:
   
   enum Level
   {
   TDEBUG = 0,
   INFO = 1,
   WARN = 2,
   ERROR = 3
   };
   
   IMHO, the best would be to avoid DEBUG and rename the enums to something 
like LOG_DEBUG, LOG_INFO etc. Even though it will mean a breaking change in 
some code. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] merlimat commented on issue #4655: Build fails including Logger.h

2019-07-01 Thread GitBox
merlimat commented on issue #4655: Build fails including Logger.h
URL: https://github.com/apache/pulsar/issues/4655#issuecomment-507418125
 
 
   @benstadin I think it would indeed be fine to update these enum names


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] merlimat commented on issue #4623: Fixed the default port for https and http in admin client

2019-07-01 Thread GitBox
merlimat commented on issue #4623: Fixed the default port for https and http in 
admin client
URL: https://github.com/apache/pulsar/pull/4623#issuecomment-507435739
 
 
   > @merlimat Is this a breaking change? For example, if a user has set up a 
pulsar cluster and use https://example.pulsar.com. Right now it will be 
connecting to port 8443, because the default http and https ports for Pulsar 
are 8080 and 8443. With your change, the client will be connect to 80 and 443, 
but fail.
   
   I think the breaking change was in  #3249. Before that, `https` was 
correctly resolving to 443 and `http` to 80.
   
   > If Pulsar's default http and https ports are 8080 and 8443, we should try 
to stick to Pulsar's default value, not the general http and https default 
values. Otherwise it might be break Pulsar 2.3.x clients, right?
   
   The fact that on server side we use 8080 and 8443 by default, shouldn't mean 
that a client should hide the port for that. 
   
   This is seriously confusing. `https://my-broker.com` must mean port 443. If 
you use a different client, other than pulsar admin, you would have to specify 
`:443`. 
   
   Now, imagine debugging why the same url works in pulsar-admin but it doesn't 
if you try with http directly.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] merlimat closed issue #4648: [doc] cause deadlock while use subscribeAsync demo in java client doc.

2019-07-01 Thread GitBox
merlimat closed issue #4648: [doc] cause deadlock while use subscribeAsync demo 
in java client doc.
URL: https://github.com/apache/pulsar/issues/4648
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] merlimat merged pull request #4649: fix cause deadlock while use subscribeAsync demo in java client doc.

2019-07-01 Thread GitBox
merlimat merged pull request #4649: fix cause deadlock while use subscribeAsync 
demo in java client doc.
URL: https://github.com/apache/pulsar/pull/4649
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[pulsar] branch master updated: fix cause deadlock while use subscribeAsync demo in java client doc. (#4649)

2019-07-01 Thread mmerli
This is an automated email from the ASF dual-hosted git repository.

mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
 new bbaf2d9  fix cause deadlock while use subscribeAsync demo in java 
client doc. (#4649)
bbaf2d9 is described below

commit bbaf2d9eadbf678fd22e1541cc583b2607499714
Author: lipenghui 
AuthorDate: Tue Jul 2 06:20:09 2019 +0800

fix cause deadlock while use subscribeAsync demo in java client doc. (#4649)
---
 site2/docs/client-libraries-java.md | 18 --
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/site2/docs/client-libraries-java.md 
b/site2/docs/client-libraries-java.md
index 35887fc..16750c6 100644
--- a/site2/docs/client-libraries-java.md
+++ b/site2/docs/client-libraries-java.md
@@ -306,16 +306,14 @@ Pattern allTopicsInNamespace = 
Pattern.compile("persistent://public/default.*");
 consumerBuilder
 .topics(topics)
 .subscribeAsync()
-.thenAccept(consumer -> {
-do {
-try {
-Message msg = consumer.receive();
-// Do something with the received message
-} catch (PulsarClientException e) {
-e.printStackTrace();
-}
-} while (true);
-});
+.thenAccept(this::receiveMessageFromConsumer);
+
+private void receiveMessageFromConsumer(Consumer consumer) {
+consumer.receiveAsync().thenAccept(message -> {
+// Do something with the received message
+receiveMessageFromConsumer(consumer);
+});
+}
 ```
 
 ### Subscription modes



[GitHub] [pulsar] jerrypeng commented on issue #4644: Improve and add authorization to function download and upload

2019-07-01 Thread GitBox
jerrypeng commented on issue #4644:  Improve and add authorization to function 
download and upload
URL: https://github.com/apache/pulsar/pull/4644#issuecomment-507455722
 
 
   rerun java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] codelipenghui commented on issue #4621: [PIP-38] Support batch receive in java client.

2019-07-01 Thread GitBox
codelipenghui commented on issue #4621: [PIP-38] Support batch receive in java 
client.
URL: https://github.com/apache/pulsar/pull/4621#issuecomment-507467837
 
 
   run java8 tests
   run Integration Tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] merlimat commented on a change in pull request #4645: Allows consumer retrieve the sequence id that the producer set.

2019-07-01 Thread GitBox
merlimat commented on a change in pull request #4645: Allows consumer retrieve 
the sequence id that the producer set.
URL: https://github.com/apache/pulsar/pull/4645#discussion_r299260480
 
 

 ##
 File path: 
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BatchMessageTest.java
 ##
 @@ -737,5 +737,69 @@ public void testOrderingOfKeyBasedBatchMessageContainer() 
throws PulsarClientExc
 producer.close();
 }
 
+@Test(dataProvider = "containerBuilder", timeOut = 3000)
+private void testRetrieveSequenceIdGenerated(BatcherBuilder builder) 
throws Exception {
+
+int numMsgs = 10;
+final String topicName = 
"persistent://prop/ns-abc/testRetrieveSequenceIdGenerated-" + UUID.randomUUID();
+final String subscriptionName = "sub-1";
+
+Consumer consumer = 
pulsarClient.newConsumer().topic(topicName).subscriptionName(subscriptionName)
+.subscriptionType(SubscriptionType.Shared).subscribe();
+
+Producer producer = pulsarClient.newProducer().topic(topicName)
+.batchingMaxPublishDelay(5, 
TimeUnit.SECONDS).batchingMaxMessages(numMsgs).enableBatching(true)
+.batcherBuilder(builder)
+.create();
+
+List> sendFutureList = 
Lists.newArrayList();
+for (int i = 0; i < numMsgs; i++) {
+byte[] message = ("my-message-" + i).getBytes();
+sendFutureList.add(producer.sendAsync(message));
+}
+FutureUtil.waitForAll(sendFutureList).get();
+
+for (int i = 0; i < numMsgs; i++) {
+Message received = consumer.receive();
+Assert.assertEquals(received.getSequenceId(), i);
+consumer.acknowledge(received);
+}
+
+producer.close();
+consumer.close();
+}
+
+@Test(dataProvider = "containerBuilder", timeOut = 3000)
 
 Review comment:
   ```suggestion
   @Test(dataProvider = "containerBuilder")
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] merlimat commented on a change in pull request #4645: Allows consumer retrieve the sequence id that the producer set.

2019-07-01 Thread GitBox
merlimat commented on a change in pull request #4645: Allows consumer retrieve 
the sequence id that the producer set.
URL: https://github.com/apache/pulsar/pull/4645#discussion_r299260444
 
 

 ##
 File path: 
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BatchMessageTest.java
 ##
 @@ -737,5 +737,69 @@ public void testOrderingOfKeyBasedBatchMessageContainer() 
throws PulsarClientExc
 producer.close();
 }
 
+@Test(dataProvider = "containerBuilder", timeOut = 3000)
 
 Review comment:
   ```suggestion
   @Test(dataProvider = "containerBuilder")
   ```
   
   Timeout is already enforced by default (and using a small timeout increases 
the chances of flaking when running in Jenkins).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] merlimat commented on a change in pull request #4645: Allows consumer retrieve the sequence id that the producer set.

2019-07-01 Thread GitBox
merlimat commented on a change in pull request #4645: Allows consumer retrieve 
the sequence id that the producer set.
URL: https://github.com/apache/pulsar/pull/4645#discussion_r299260064
 
 

 ##
 File path: pulsar-common/src/main/proto/PulsarApi.proto
 ##
 @@ -193,6 +195,7 @@ enum ProtocolVersion {
v13 = 13; // Schema-registry : added avro schema format for json
v14 = 14; // Add CommandAuthChallenge and CommandAuthResponse for 
mutual auth
  // Added Key_Shared subscription
+   v15 = 15; // Added sequence_id for SingleMessageMetadata, retrieve the 
sequence id in batch message.
 
 Review comment:
   We don't need to add a new version here because adding the field on the 
proto message will not cause any problem if the other end (broker or client) is 
running an older version.
   In protobuf, unknown fields are automatically ignored. 
   
   We just increase the version when adding a new feature that requires a 
minimum version from the peers, so that we can check pre-emptively.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #4623: Fixed the default port for https and http in admin client

2019-07-01 Thread GitBox
sijie commented on issue #4623: Fixed the default port for https and http in 
admin client
URL: https://github.com/apache/pulsar/pull/4623#issuecomment-507482783
 
 
   > I think the breaking change was in #3249. Before that, https was correctly 
resolving to 443 and http to 80.
   
   I don't think #3249 is a breaking change. If I remembered correctly, prior 
to #3249, you had to specify port in service url in order to make it work. it 
doesn't resolve directly to 443 for https or 80 for http. #3249 introduced the 
capability for resolving server url to default ports without specifying the 
port. I used 8080 for http and 8443 for https because those were the default 
ports when you setup a pulsar cluster.
   
   > This is seriously confusing. https://my-broker.com must mean port 443. If 
you use a different client, other than pulsar admin, you would have to specify 
:443.
   > Now, imagine debugging why the same url works in pulsar-admin but it 
doesn't if you try with http directly.
   
   agreed. If so, I would rather suggesting adding constraints that port is 
required. This will makes the behavior same as prior to #3249.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] easyfan commented on issue #4569: C++ client producer sendAsync() method will be blocked forever, if enough batched messages sent timeout.

2019-07-01 Thread GitBox
easyfan commented on issue #4569: C++ client producer sendAsync() method will 
be blocked forever, if enough batched messages sent timeout.
URL: https://github.com/apache/pulsar/issues/4569#issuecomment-507482953
 
 
   OK. I will send pull request later today.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #4569: C++ client producer sendAsync() method will be blocked forever, if enough batched messages sent timeout.

2019-07-01 Thread GitBox
sijie commented on issue #4569: C++ client producer sendAsync() method will be 
blocked forever, if enough batched messages sent timeout.
URL: https://github.com/apache/pulsar/issues/4569#issuecomment-507483052
 
 
   Awesome @easyfan !


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] tuteng commented on issue #4610: pulsar-admin cli: pulsar functions api issues after changing function parallelism > 1

2019-07-01 Thread GitBox
tuteng commented on issue #4610: pulsar-admin cli: pulsar functions api issues 
after changing function parallelism > 1
URL: https://github.com/apache/pulsar/issues/4610#issuecomment-507488092
 
 
   I used this [image](https://hub.docker.com/r/apachepulsar/pulsar/tags) of 
2.3.2 version to test, you can see what is different from your configuration.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] easyfan commented on issue #4569: C++ client producer sendAsync() method will be blocked forever, if enough batched messages sent timeout.

2019-07-01 Thread GitBox
easyfan commented on issue #4569: C++ client producer sendAsync() method will 
be blocked forever, if enough batched messages sent timeout.
URL: https://github.com/apache/pulsar/issues/4569#issuecomment-507489909
 
 
   @sijie BTW, I found another timeout check arbitrary issue inside C++ client. 
And the solution also in the exact same file 
pulsar/pulsar-client-cpp/lib/ProducerImpl.cc. So shall I open another issue for 
it, or just add some comments inside this one?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] wolfstudy commented on issue #4653: [issue 4589] Fix redelivered message logic of partition topic

2019-07-01 Thread GitBox
wolfstudy commented on issue #4653: [issue 4589] Fix redelivered message logic 
of partition topic
URL: https://github.com/apache/pulsar/pull/4653#issuecomment-507492743
 
 
   run cpp tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] wolfstudy commented on issue #4589: In Go client 2.3.2, can't get re-delivered message after add AckTimeout in ConsumerOptions

2019-07-01 Thread GitBox
wolfstudy commented on issue #4589: In Go client 2.3.2, can't get re-delivered 
message after add AckTimeout in ConsumerOptions
URL: https://github.com/apache/pulsar/issues/4589#issuecomment-507493042
 
 
   hello @stevenwangnarvar the issue will be fixed in [pull 
request:4653](https://github.com/apache/pulsar/pull/4653), PTAL thanks


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] easyfan opened a new issue #4656: C++ client producer sendAsync() timeout check method seems too arbitrary

2019-07-01 Thread GitBox
easyfan opened a new issue #4656: C++ client producer sendAsync() timeout check 
method seems too arbitrary
URL: https://github.com/apache/pulsar/issues/4656
 
 
   **C++ client producer sendAsync() timeout check method seems too arbitrary**
   
   
   **Analysis**
   In general, the c++ client producer timeout check was implemented in 
pulsar/pulsar-client-cpp/lib/ProducerImpl.cc, 
`ProducerImpl::handleSendTimeout(...)`, which is registered as a handler of 
`ProducerImpl::sendTimer_`;
   In any performing phase of `ProducerImpl::sendTimer_`, the very first 
`pulsar::OpSendMsg` element inside `ProducerImpl::pendingMessagesQueue_` will 
be picked up and compare the  OpSendMsg::timeout_ with current tick. If the 
time diff is less than 0, there is a sending timeout happens. 
   
   So far so good.
   
   But then, it invokes the method `ProducerImpl::failPendingMessages(...)` for 
dealing the message failure stuff. Definitely, it works, but not only on the 
message it already checked as we hoped, but just all the messages inside 
`ProducerImpl::pendingMessagesQueue_`.
   
   Result: Inside a sending timeout check, if the very oldest message inside 
the pending queue timeout, will lead all the messages inside the pending queue 
to be processed as a timeout
   
   **Expected behavior**
   A more specifical check on every message timeout. 
   
   **Desktop (please complete the following information):**
- OS: centOS
   
   **About the performance**
   As there are much more performing of check and compare than it was, the 
performance will downgrade undoubtedly. We may have a discussion of it, and 
make a decision then.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] easyfan commented on issue #4569: C++ client producer sendAsync() method will be blocked forever, if enough batched messages sent timeout.

2019-07-01 Thread GitBox
easyfan commented on issue #4569: C++ client producer sendAsync() method will 
be blocked forever, if enough batched messages sent timeout.
URL: https://github.com/apache/pulsar/issues/4569#issuecomment-507498870
 
 
   @sijie  Seems the solution of said timeout check issue I mentioned before 
need a discussion about the performance, I open another issue for recording: 
https://github.com/apache/pulsar/issues/4656


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] codelipenghui commented on issue #4645: Allows consumer retrieve the sequence id that the producer set.

2019-07-01 Thread GitBox
codelipenghui commented on issue #4645: Allows consumer retrieve the sequence 
id that the producer set.
URL: https://github.com/apache/pulsar/pull/4645#issuecomment-507500072
 
 
   @merlimat I have addressed your comments, please take a look.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] AnandSinha commented on issue #4057: Security Vulnerabilities - Black Duck Scan - Pulsar v.2.3.1

2019-07-01 Thread GitBox
AnandSinha commented on issue #4057: Security Vulnerabilities - Black Duck Scan 
- Pulsar v.2.3.1
URL: https://github.com/apache/pulsar/issues/4057#issuecomment-507507052
 
 
   Hello,
   
   I wanted to confirm if the correct binaries (without the known 
vulnerabilities) are already present in the current builds of Pulsar.
   
   If not, what is the timeline of getting these incorporated?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #4569: C++ client producer sendAsync() method will be blocked forever, if enough batched messages sent timeout.

2019-07-01 Thread GitBox
sijie commented on issue #4569: C++ client producer sendAsync() method will be 
blocked forever, if enough batched messages sent timeout.
URL: https://github.com/apache/pulsar/issues/4569#issuecomment-507507573
 
 
   @easyfan let's have a separated discussion in #4656 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[pulsar.wiki] branch master updated: Updated Release Candidate Validation (markdown)

2019-07-01 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository.

jerrypeng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new 0979417  Updated Release Candidate Validation (markdown)
0979417 is described below

commit 0979417fa25f897d67160b6e38dae6e5f917f98a
Author: Boyang Jerry Peng 
AuthorDate: Mon Jul 1 21:44:25 2019 -0700

Updated Release Candidate Validation (markdown)
---
 Release-Candidate-Validation.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Release-Candidate-Validation.md b/Release-Candidate-Validation.md
index 7a94b85..57d590b 100644
--- a/Release-Candidate-Validation.md
+++ b/Release-Candidate-Validation.md
@@ -185,7 +185,7 @@ $ bin/pulsar-admin namespaces create test/test-namespace
 b) Create function.
 
 ```shell
-$ bin/pulsar-admin functions create --functionConfigFile 
examples/example-function-config.yaml --jar examples/api-examples.jar
+$ bin/pulsar-admin functions create --function-config-file 
examples/example-function-config.yaml --jar examples/api-examples.jar
 ```
 
 The following information is returned.



[pulsar.wiki] branch master updated: Updated Release Candidate Validation (markdown)

2019-07-01 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository.

jerrypeng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new 790634e  Updated Release Candidate Validation (markdown)
790634e is described below

commit 790634ef34db7fe9d9a1d6d015f32035f81b0ab6
Author: Boyang Jerry Peng 
AuthorDate: Mon Jul 1 21:49:29 2019 -0700

Updated Release Candidate Validation (markdown)
---
 Release-Candidate-Validation.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Release-Candidate-Validation.md b/Release-Candidate-Validation.md
index 57d590b..c07c840 100644
--- a/Release-Candidate-Validation.md
+++ b/Release-Candidate-Validation.md
@@ -358,7 +358,7 @@ configs:
 4. Submit a cassandra sink.
 
 ```shell
-$ bin/pulsar-admin sink create --tenant public --namespace default --name 
cassandra-test-sink --sink-type cassandra --sinkConfigFile 
examples/cassandra-sink.yml --inputs test_cassandra
+$ bin/pulsar-admin sink create --tenant public --namespace default --name 
cassandra-test-sink --sink-type cassandra --sink-config-file 
examples/cassandra-sink.yml --inputs test_cassandra
 "Created successfully"
 ```
 



[pulsar.wiki] branch master updated: Updated Release Candidate Validation (markdown)

2019-07-01 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository.

jerrypeng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new a22cbd8  Updated Release Candidate Validation (markdown)
a22cbd8 is described below

commit a22cbd8909e601abba95fc300a22b2e86d8d
Author: Boyang Jerry Peng 
AuthorDate: Mon Jul 1 21:50:03 2019 -0700

Updated Release Candidate Validation (markdown)
---
 Release-Candidate-Validation.md | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Release-Candidate-Validation.md b/Release-Candidate-Validation.md
index c07c840..6a3adc9 100644
--- a/Release-Candidate-Validation.md
+++ b/Release-Candidate-Validation.md
@@ -225,7 +225,7 @@ The output is similar as follows:
 4. At the same terminal as step 3, retrieve the function status.
 
 ```shell
-$ bin/pulsar-admin functions getstatus --tenant test --namespace 
test-namespace --name example
+$ bin/pulsar-admin functions status --tenant test --namespace test-namespace 
--name example
 ```
 The output is similar as follows:
 
@@ -392,7 +392,7 @@ $ bin/pulsar-admin sink get --tenant public --namespace 
default --name cassandra
 
 ```shell
 // get the running status
-$ bin/pulsar-admin sink getstatus --tenant public --namespace default --name 
cassandra-test-sink
+$ bin/pulsar-admin sink status --tenant public --namespace default --name 
cassandra-test-sink
 {
   "numInstances" : 1,
   "numRunning" : 1,
@@ -423,7 +423,7 @@ $ for i in {0..10}; do bin/pulsar-client produce -m 
"key-$i" -n 1 test_cassandra
 6. Check the sink status, and 11 messages are processed.
 
 ```shell
-$ bin/pulsar-admin sink getstatus --tenant public --namespace default --name 
cassandra-test-sink
+$ bin/pulsar-admin sink status --tenant public --namespace default --name 
cassandra-test-sink
 {
   "numInstances" : 1,
   "numRunning" : 1,
@@ -526,7 +526,7 @@ $ bin/pulsar-admin functions get --tenant test --namespace 
test-namespace --name
 ```
 
 ```shell
-$ bin/pulsar-admin functions getstatus --tenant test --namespace 
test-namespace --name word_count
+$ bin/pulsar-admin functions status --tenant test --namespace test-namespace 
--name word_count
 {
   "numInstances" : 1,
   "numRunning" : 1,



[pulsar.wiki] branch master updated: Updated Release Candidate Validation (markdown)

2019-07-01 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository.

jerrypeng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new 19c45ca  Updated Release Candidate Validation (markdown)
19c45ca is described below

commit 19c45ca64008edc76ac39cd66c9b9800dd77ffb3
Author: Boyang Jerry Peng 
AuthorDate: Mon Jul 1 21:52:47 2019 -0700

Updated Release Candidate Validation (markdown)
---
 Release-Candidate-Validation.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Release-Candidate-Validation.md b/Release-Candidate-Validation.md
index 6a3adc9..535f415 100644
--- a/Release-Candidate-Validation.md
+++ b/Release-Candidate-Validation.md
@@ -489,7 +489,7 @@ The following are instructions to validate counter 
functions.
 1. Create a wordcount function.
 
 ```shell
-$ bin/pulsar-admin functions create --functionConfigFile 
examples/example-function-config.yaml --jar examples/api-examples.jar --name 
word_count --className 
org.apache.pulsar.functions.api.examples.WordCountFunction --inputs 
test_wordcount_src --output test_wordcount_dest
+$ bin/pulsar-admin functions create --function-config-file 
examples/example-function-config.yaml --jar examples/api-examples.jar --name 
word_count --className 
org.apache.pulsar.functions.api.examples.WordCountFunction --inputs 
test_wordcount_src --output test_wordcount_dest
 "Created successfully"
 ```
 



[GitHub] [pulsar] jerrypeng commented on issue #4577: fix issue when submitting NAR via file url

2019-07-01 Thread GitBox
jerrypeng commented on issue #4577: fix issue when submitting NAR via file url
URL: https://github.com/apache/pulsar/pull/4577#issuecomment-507524641
 
 
   @sijie thanks for the review.  I have updated the PR to have more return 
more specific errors.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jerrypeng commented on issue #4610: pulsar-admin cli: pulsar functions api issues after changing function parallelism > 1

2019-07-01 Thread GitBox
jerrypeng commented on issue #4610: pulsar-admin cli: pulsar functions api 
issues after changing function parallelism > 1
URL: https://github.com/apache/pulsar/issues/4610#issuecomment-507526057
 
 
   @one70six what is your cluster setup? Single node standalone or multi node 
cluster?  Running function worker with broker or alone?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] codelipenghui commented on issue #4645: Allows consumer retrieve the sequence id that the producer set.

2019-07-01 Thread GitBox
codelipenghui commented on issue #4645: Allows consumer retrieve the sequence 
id that the producer set.
URL: https://github.com/apache/pulsar/pull/4645#issuecomment-507532910
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] codelipenghui commented on issue #4621: [PIP-38] Support batch receive in java client.

2019-07-01 Thread GitBox
codelipenghui commented on issue #4621: [PIP-38] Support batch receive in java 
client.
URL: https://github.com/apache/pulsar/pull/4621#issuecomment-507533294
 
 
   run java8 tests
   run Integration Tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services