[GitHub] [pulsar] nathan-zhu commented on issue #5514: use pulsar get error in mac os
nathan-zhu commented on issue #5514: use pulsar get error in mac os URL: https://github.com/apache/pulsar/issues/5514#issuecomment-551430495 > There seems to be a lack of package boost-python3, if you try to install with source code, don't install with pip anymore. Python3 is no problem, you don't need to reinstall it. > > The following command is installed based on source code: > > ``` > git clone https://github.com/apache/pulsar > cd pulsar > git checkout branch-2.4 > brew install boost-python3 > cd pulsar-client-cpp > cmake . > make -j4 && make install > cd python > python setup.py install > # python > Python 3.7.3 (default, Mar 27 2019, 09:23:32) > [Clang 9.0.0 (clang-900.0.39.2)] on darwin > Type "help", "copyright", "credits" or "license" for more information. > >>> import pulsar > >>> dir(pulsar) > ['Authentication', 'AuthenticationAthenz', 'AuthenticationTLS', 'AuthenticationToken', 'Client', 'CompressionType', 'Consumer', 'ConsumerType', 'Context', 'Function', 'IdentitySerDe', 'InitialPosition', 'Message', 'MessageBatch', 'MessageId', 'PartitionsRoutingMode', 'PickleSerDe', 'Producer', 'Reader', 'Result', 'SerDe', '__builtins__', '__cached__', '__doc__', '__file__', '__loader__', '__name__', '__package__', '__path__', '__spec__', '_check_type', '_check_type_or_none', '_listener_wrapper', '_pulsar', '_retype', '_schema', 'certifi', 'functions', 're', 'schema'] > >>> > ``` Thanks , tuteng. follow your step to do, currently get another error during cmake . like below: ``` -- Found Boost: /usr/local/include (found version "1.71.0") found components: python37-mt -- HAS_ZSTD: 1 -- HAS_SNAPPY: 1 -- Using Boost Python libs: /usr/local/Frameworks/Python.framework/Versions/3.7/lib/libpython3.7m.dylib;/usr/local/lib/libboost_python37-mt.dylib clang-tidy not found clang-format not found CMake Error: The following variables are used in this project, but they are set to NOTFOUND. Please set them or make sure they are set and tested correctly in the CMake files: GMOCK_INCLUDE_PATH used as include directory in directory /Users/lidongzhu/python/Pulsar/pulsar/pulsar-client-cpp used as include directory in directory /Users/lidongzhu/python/Pulsar/pulsar/pulsar-client-cpp used as include directory in directory /Users/lidongzhu/python/Pulsar/pulsar/pulsar-client-cpp used as include directory in directory /Users/lidongzhu/python/Pulsar/pulsar/pulsar-client-cpp used as include directory in directory /Users/lidongzhu/python/Pulsar/pulsar/pulsar-client-cpp ``` here is CMakeOutput.log file. [CMakeOutput.log](https://github.com/apache/pulsar/files/3823548/CMakeOutput.log) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5278: Fixed reader cursor seek with disconnection
sijie commented on issue #5278: Fixed reader cursor seek with disconnection URL: https://github.com/apache/pulsar/pull/5278#issuecomment-551440754 Moved this to 2.5.0 since I think it requires some more discussions about the side effect of this change. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5022: Fixed the cleanup of non-durable cursors when a reader is closed
sijie commented on issue #5022: Fixed the cleanup of non-durable cursors when a reader is closed URL: https://github.com/apache/pulsar/pull/5022#issuecomment-551441869 @merlimat can you rebase this pull request? so it can unblock 2.4.2 release. or we can move it to 2.4.3. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5278: Fixed reader cursor seek with disconnection
sijie commented on issue #5278: Fixed reader cursor seek with disconnection URL: https://github.com/apache/pulsar/pull/5278#issuecomment-551442260 actually moved to 2.4.3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5491: [Issue 5476]Fix message deduplicate issue while using external sequence id with batch produce
codelipenghui commented on issue #5491: [Issue 5476]Fix message deduplicate issue while using external sequence id with batch produce URL: https://github.com/apache/pulsar/pull/5491#issuecomment-551445030 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5593: [Docs] Add admin api docs of Pulsar Functions
Anonymitaet commented on issue #5593: [Docs] Add admin api docs of Pulsar Functions URL: https://github.com/apache/pulsar/pull/5593#issuecomment-551451378 @sijie it seems that the contents of this PR are similar to the ["Use" chapter in Connector guide](http://pulsar.apache.org/docs/en/next/io-use/)? If so, can I create a "Use" Chapter under the "Function" guide and move the contents there?  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet edited a comment on issue #5593: [Docs] Add admin api docs of Pulsar Functions
Anonymitaet edited a comment on issue #5593: [Docs] Add admin api docs of Pulsar Functions URL: https://github.com/apache/pulsar/pull/5593#issuecomment-551451378 @sijie it seems that the contents of this PR are similar to the ["Use" chapter in Connector guide](http://pulsar.apache.org/docs/en/next/io-use/)? If so, can I create a "Use" Chapter under the "Function" guide and move the contents there? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet edited a comment on issue #5593: [Docs] Add admin api docs of Pulsar Functions
Anonymitaet edited a comment on issue #5593: [Docs] Add admin api docs of Pulsar Functions URL: https://github.com/apache/pulsar/pull/5593#issuecomment-551451378 @sijie it seems that the contents of this PR are similar to the ["Use" chapter in Connector guide](http://pulsar.apache.org/docs/en/next/io-use/)? If so, can I create a "Use" Chapter under the "Function" guide and move the contents there?  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet edited a comment on issue #5593: [Docs] Add admin api docs of Pulsar Functions
Anonymitaet edited a comment on issue #5593: [Docs] Add admin api docs of Pulsar Functions URL: https://github.com/apache/pulsar/pull/5593#issuecomment-551451378 @sijie it seems that the contents of this PR are similar to the ["Use" chapter in Connector guide](http://pulsar.apache.org/docs/en/next/io-use/)? If so, can I create a "How-to: Use" Chapter under the "Function" guide and move the contents there?  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet removed a comment on issue #5593: [Docs] Add admin api docs of Pulsar Functions
Anonymitaet removed a comment on issue #5593: [Docs] Add admin api docs of Pulsar Functions URL: https://github.com/apache/pulsar/pull/5593#issuecomment-551451378 @sijie it seems that the contents of this PR are similar to the ["Use" chapter in Connector guide](http://pulsar.apache.org/docs/en/next/io-use/)? If so, can I create a "How-to: Use" Chapter under the "Function" guide and move the contents there?  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5587: [Issue 5585][pulsar-client] Fix producer Semaphore release error
codelipenghui commented on issue #5587: [Issue 5585][pulsar-client] Fix producer Semaphore release error URL: https://github.com/apache/pulsar/pull/5587#issuecomment-551510814 @sijie @merlimat please help review, i have run the unit test on master branch, the test is failed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #4621: [PIP-38] Support batch receive in java client.
codelipenghui commented on issue #4621: [PIP-38] Support batch receive in java client. URL: https://github.com/apache/pulsar/pull/4621#issuecomment-551519583 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet edited a comment on issue #5593: [Docs] Add admin api docs of Pulsar Functions
Anonymitaet edited a comment on issue #5593: [Docs] Add admin api docs of Pulsar Functions URL: https://github.com/apache/pulsar/pull/5593#issuecomment-551520270 As discussed just now, you and @tuteng will generate docs of admin CLI, Java Admin API, and REST API from code. The formats and (contents) of this PR are similar to those in [here](http://pulsar.apache.org/docs/en/next/admin-api-namespaces/). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5593: [Docs] Add admin api docs of Pulsar Functions
Anonymitaet commented on issue #5593: [Docs] Add admin api docs of Pulsar Functions URL: https://github.com/apache/pulsar/pull/5593#issuecomment-551520270 As discussed just now, you and @tuteng will generate docs of admin CLI, Java Admin API, and REST API from code. The contents and formats of this PR are the same as those in [here](http://pulsar.apache.org/docs/en/next/admin-api-namespaces/). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5491: [Issue 5476]Fix message deduplicate issue while using external sequence id with batch produce
codelipenghui commented on issue #5491: [Issue 5476]Fix message deduplicate issue while using external sequence id with batch produce URL: https://github.com/apache/pulsar/pull/5491#issuecomment-551530217 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5571: Add epoch for connection handler to handle create producer timeout.
codelipenghui commented on issue #5571: Add epoch for connection handler to handle create producer timeout. URL: https://github.com/apache/pulsar/pull/5571#issuecomment-551533067 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang opened a new pull request #5594: [WIP][Issue 5553] [website] Add coding-guide page
Jennifer88huang opened a new pull request #5594: [WIP][Issue 5553] [website] Add coding-guide page URL: https://github.com/apache/pulsar/pull/5594 Fixes #5553 ### Motivation Lack of coding guide page on Pulsar website. ### Modifications 1. Add coding guide. 2. Add coding-guide.js file. 3. Update footer.js file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on issue #5553: [website] Lack of a coding-guide page on Pulsar website
Jennifer88huang commented on issue #5553: [website] Lack of a coding-guide page on Pulsar website URL: https://github.com/apache/pulsar/issues/5553#issuecomment-551593196 I've refined parts according to powered-by page: https://github.com/apache/pulsar/pull/5018 I've added coding-guide.js, and updated footer.js file. Maybe we need to update another part to display it correctly. See https://github.com/apache/pulsar/pull/5594 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5590: [Issue 5474][pulsar-io-debezium] Support CDC Connector for MongoDB
tuteng commented on issue #5590: [Issue 5474][pulsar-io-debezium] Support CDC Connector for MongoDB URL: https://github.com/apache/pulsar/pull/5590#issuecomment-551605145 Great job!!! Are you interested in adding an integration test using the https://hub.docker.com/r/debezium/example-mongodb image? Call me anytime if you have any questions. Reference [Debezium MySQL Source Test](https://github.com/apache/pulsar/blob/master/tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/DebeziumMySqlSourceTester.java) and [Debezium Postgresql Source Test](https://github.com/apache/pulsar/blob/master/tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/DebeziumPostgreSqlSourceTester.java) @huangdx0726 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5312: Function REST API documentation is insufficient for Create POST action
wolfstudy commented on issue #5312: Function REST API documentation is
insufficient for Create POST action
URL: https://github.com/apache/pulsar/issues/5312#issuecomment-551653091
@devinbost Sorry, I missed this message.
The REST API for create function should be correct. In
[pulsarctl](https://github.com/streamnative/pulsarctl/blob/master/pkg/pulsar/functions.go#L142),
I also called this REST API and successfully created the function.
Copy the code from pulsarctl:
```
func (f *functions) createStringFromField(w *multipart.Writer, value string)
(io.Writer, error) {
h := make(textproto.MIMEHeader)
h.Set("Content-Disposition", fmt.Sprintf(`form-data; name="%s" `,
value))
h.Set("Content-Type", "application/json")
return w.CreatePart(h)
}
func (f *functions) CreateFunc(funcConf *utils.FunctionConfig, fileName
string) error {
endpoint := f.client.endpoint(f.basePath, funcConf.Tenant,
funcConf.Namespace, funcConf.Name)
// buffer to store our request as bytes
bodyBuf := bytes.NewBufferString("")
multiPartWriter := multipart.NewWriter(bodyBuf)
jsonData, err := json.Marshal(funcConf)
if err != nil {
return err
}
stringWriter, err := f.createStringFromField(multiPartWriter,
"functionConfig")
if err != nil {
return err
}
_, err = stringWriter.Write(jsonData)
if err != nil {
return err
}
if fileName != "" && !strings.HasPrefix(fileName, "builtin://") {
// If the function code is built in, we don't need to submit
here
file, err := os.Open(fileName)
if err != nil {
return err
}
defer file.Close()
part, err := multiPartWriter.CreateFormFile("data",
filepath.Base(file.Name()))
if err != nil {
return err
}
// copy the actual file content to the filed's writer
_, err = io.Copy(part, file)
if err != nil {
return err
}
}
// In here, we completed adding the file and the fields, let's close
the multipart writer
// So it writes the ending boundary
if err = multiPartWriter.Close(); err != nil {
return err
}
contentType := multiPartWriter.FormDataContentType()
err = f.client.postWithMultiPart(endpoint, nil, bodyBuf, contentType)
if err != nil {
return err
}
return nil
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5587: [Issue 5585][pulsar-client] Fix producer Semaphore release error
codelipenghui commented on issue #5587: [Issue 5585][pulsar-client] Fix producer Semaphore release error URL: https://github.com/apache/pulsar/pull/5587#issuecomment-551693802 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar-manager] branch master updated: Move package name from io.streamnative.pulsar to org.apache.pulsar (#208)
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-manager.git The following commit(s) were added to refs/heads/master by this push: new 7ec5ef6 Move package name from io.streamnative.pulsar to org.apache.pulsar (#208) 7ec5ef6 is described below commit 7ec5ef615f169d8cef654027582c7751335d973c Author: tuteng AuthorDate: Fri Nov 8 20:20:08 2019 +0800 Move package name from io.streamnative.pulsar to org.apache.pulsar (#208) --- .../pulsar/manager/PulsarManagerApplication.java | 4 +-- .../manager/controller/BookiesController.java | 4 +-- .../manager/controller/BrokerStatsController.java | 6 ++-- .../manager/controller/BrokerTokensController.java | 8 ++--- .../manager/controller/BrokersController.java | 6 ++-- .../manager/controller/ClustersController.java | 6 ++-- .../manager/controller/EnvironmentsController.java | 10 +++--- .../pulsar/manager/controller/LoginController.java | 4 +-- .../manager/controller/NamespacesController.java | 6 ++-- .../manager/controller/TenantsController.java | 6 ++-- .../manager/controller/TopicsController.java | 6 ++-- .../exception/CustomizeExceptionHandler.java | 2 +- .../controller/exception/ErrorResource.java| 2 +- .../exception/ErrorResourceSerializer.java | 2 +- .../controller/exception/FieldErrorResource.java | 2 +- .../exception/InvalidRequestException.java | 2 +- .../manager/dao/BrokerTokensRepositoryImpl.java| 8 ++--- .../manager/dao/ConsumersStatsRepositoryImpl.java | 8 ++--- .../manager/dao/EnvironmentsRepositoryImpl.java| 8 ++--- .../manager/dao/PublishersStatsRepositoryImpl.java | 8 ++--- .../dao/ReplicationsStatsRepositoryImpl.java | 8 ++--- .../dao/SubscriptionsStatsRepositoryImpl.java | 8 ++--- .../manager/dao/TopicsStatsRepositoryImpl.java | 8 ++--- .../pulsar/manager/entity/BrokerTokenEntity.java | 2 +- .../manager/entity/BrokerTokensRepository.java | 2 +- .../pulsar/manager/entity/ConsumerStatsEntity.java | 2 +- .../manager/entity/ConsumersStatsRepository.java | 2 +- .../pulsar/manager/entity/EnvironmentEntity.java | 2 +- .../manager/entity/EnvironmentsRepository.java | 2 +- .../manager/entity/PublisherStatsEntity.java | 2 +- .../manager/entity/PublishersStatsRepository.java | 2 +- .../manager/entity/PulsarManagerConsumerStats.java | 2 +- .../entity/PulsarManagerPublisherStats.java| 2 +- .../entity/PulsarManagerReplicatorStats.java | 2 +- .../entity/PulsarManagerSubscriptionStats.java | 2 +- .../manager/entity/PulsarManagerTopicStats.java| 2 +- .../manager/entity/ReplicationStatsEntity.java | 2 +- .../entity/ReplicationsStatsRepository.java| 2 +- .../manager/entity/SubscriptionStatsEntity.java| 2 +- .../entity/SubscriptionsStatsRepository.java | 2 +- .../pulsar/manager/entity/TopicStatsEntity.java| 2 +- .../manager/entity/TopicsStatsRepository.java | 2 +- .../interceptor/AdminHandlerInterceptor.java | 8 ++--- .../manager/interceptor/WebAppConfigurer.java | 2 +- .../pulsar/manager/mapper/BrokerTokensMapper.java | 4 +-- .../pulsar/manager/mapper/ConsumerStatsMapper.java | 4 +-- .../pulsar/manager/mapper/EnvironmentsMapper.java | 4 +-- .../manager/mapper/PublishersStatsMapper.java | 4 +-- .../manager/mapper/ReplicationsStatsMapper.java| 4 +-- .../manager/mapper/SubscriptionsStatsMapper.java | 4 +-- .../pulsar/manager/mapper/TopicsStatsMapper.java | 4 +-- .../pulsar/manager/service/BookiesService.java | 2 +- .../pulsar/manager/service/BrokerStatsService.java | 2 +- .../pulsar/manager/service/BrokersService.java | 2 +- .../pulsar/manager/service/ClustersService.java| 2 +- .../manager/service/EnvironmentCacheService.java | 4 +-- .../apache}/pulsar/manager/service/JwtService.java | 2 +- .../pulsar/manager/service/NamespacesService.java | 2 +- .../pulsar/manager/service/TenantsService.java | 2 +- .../pulsar/manager/service/TopicsService.java | 2 +- .../manager/service/impl/BookiesServiceImpl.java | 6 ++-- .../service/impl/BrokerStatsServiceImpl.java | 38 +++--- .../manager/service/impl/BrokersServiceImpl.java | 6 ++-- .../manager/service/impl/ClustersServiceImpl.java | 8 ++--- .../service/impl/EnvironmentCacheServiceImpl.java | 10 +++--- .../manager/service/impl/JwtServiceImpl.java | 4 +-- .../service/impl/NamespacesServiceImpl.java| 12 +++ .../manager/service/impl/TenantsServiceImpl.java | 6 ++-- .../manager/service/impl/TopicsServiceImpl.java| 12 +++ .../pulsar/manager/swagger/SwaggerConfig.java | 4 +-- .../apache}/pulsar/manager/utils/HttpUtil.java | 2 +- .../pulsar/manager/zuul/EnvironmentForward.java| 4 +-- .../zuul/LocationHe
[GitHub] [pulsar] wolfstudy commented on issue #2719: Fix various bugs in the Go client doc examples
wolfstudy commented on issue #2719: Fix various bugs in the Go client doc examples URL: https://github.com/apache/pulsar/issues/2719#issuecomment-551707356 @grantwwu @sijie According to the go community's processing specification, we should add a `README.md` file to pulsar-client-go and introduce [godoc](https://godoc.org/) to ensure consistency between the document and the interface code. In this way we can completely solve this problem. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #2719: Fix various bugs in the Go client doc examples
sijie commented on issue #2719: Fix various bugs in the Go client doc examples URL: https://github.com/apache/pulsar/issues/2719#issuecomment-551747371 @wolfstudy can you drive the work to solve the problem? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy opened a new pull request #5595: [Docs] Fix the go client docs missing in website
wolfstudy opened a new pull request #5595: [Docs] Fix the go client docs missing in website URL: https://github.com/apache/pulsar/pull/5595 Signed-off-by: xiaolong.ran ### Motivation In website, the go client docs missing. ### Modifications Add missing docs for go client. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5593: [Docs] Add admin api docs of Pulsar Functions
Anonymitaet commented on issue #5593: [Docs] Add admin api docs of Pulsar
Functions
URL: https://github.com/apache/pulsar/pull/5593#issuecomment-551840440
@wolfstudy I've updated the contents, you can use them if my understanding
is correct
(click **...** > **Edit**)
---
id: admin-api-functions
title: Manage Functions
sidebar_label: Functions
---
**Pulsar Functions** are lightweight compute processes that
* consume messages from one or more Pulsar topics
* apply a user-supplied processing logic to each message
* publish the results of the computation to another topic
Functions can be managed via the following methods.
Method | Description
---|---
**Admin CLI** | The [`functions`](reference-pulsar-admin.md#functions)
command of the [`pulsar-admin`](reference-pulsar-admin.md) tool.
**REST API** |The `/admin/v3/functions` endpoint of the admin {@inject:
rest:REST:/} API.
**Java Admin API**| The `functions` method of the {@inject:
javadoc:PulsarAdmin:/admin/org/apache/pulsar/client/admin/PulsarAdmin} object
in the [Java API](client-libraries-java.md).
## Function resources
You can perform the following operations on functions.
### Create
You can create a Pulsar function in cluster mode (deploy it on a Pulsar
cluster) using Admin CLI, REST API or Java Admin API.
Admin CLI
Use the [`create`](reference-pulsar-admin.md#functions-create) subcommand.
**Example**
```shell
$ pulsar-admin functions create \
--tenant public \
--namespace default \
--name (the name of Pulsar Functions) \
--inputs test-input-topic \
--output persistent://public/default/test-output-topic \
--classname org.apache.pulsar.functions.api.examples.ExclamationFunction \
--jar /examples/api-examples.jar
```
REST API
{@inject:
endpoint|POST|/admin/v3/functions/{tenant}/{namespace}/{functionName}
Java Admin API
```java
FunctionConfig functionConfig = new FunctionConfig();
functionConfig.setTenant(tenant);
functionConfig.setNamespace(namespace);
functionConfig.setName(functionName);
functionConfig.setRuntime(FunctionConfig.Runtime.JAVA);
functionConfig.setParallelism(1);
functionConfig.setClassName("org.apache.pulsar.functions.api.examples.ExclamationFunction");
functionConfig.setProcessingGuarantees(FunctionConfig.ProcessingGuarantees.ATLEAST_ONCE);
functionConfig.setTopicsPattern(sourceTopicPattern);
functionConfig.setSubName(subscriptionName);
functionConfig.setAutoAck(true);
functionConfig.setOutput(sinkTopic);
admin.functions().createFunction(functionConfig, fileName);
```
### Update
You can update a Pulsar function that has been deployed to a Pulsar cluster
using Admin CLI, REST API or Java Admin API.
Admin CLI
Use the [`update`](reference-pulsar-admin.md#functions-update) subcommand.
**Example**
```shell
$ pulsar-admin functions update \
--tenant public \
--namespace default \
--name (the name of Pulsar Functions) \
--output persistent://public/default/update-output-topic \
# other options
```
REST Admin API
{@inject:
endpoint|PUT|/admin/v3/functions/{tenant}/{namespace}/{functionName}
Java Admin API
```java
FunctionConfig functionConfig = new FunctionConfig();
functionConfig.setTenant(tenant);
functionConfig.setNamespace(namespace);
functionConfig.setName(functionName);
functionConfig.setRuntime(FunctionConfig.Runtime.JAVA);
functionConfig.setParallelism(1);
functionConfig.setClassName("org.apache.pulsar.functions.api.examples.ExclamationFunction");
UpdateOptions updateOptions = new UpdateOptions();
updateOptions.setUpdateAuthData(updateAuthData);
admin.functions().updateFunction(functionConfig, userCodeFile,
updateOptions);
```
### Start 1
You can start a stopped function instance using Admin CLI, REST API or Java
Admin API.
Admin CLI
Use the [`start`](reference-pulsar-admin.md#functions-start) subcommand.
```shell
$ pulsar-admin functions start \
--tenant public \
--namespace default \
--name (the name of Pulsar Functions) \
--instance-id 1
```
REST API
{@inject:
endpoint|POST|/admin/v3/functions/{tenant}/{namespace}/{functionName}/{instanceId}/start
Java Admin API
```java
admin.functions().startFunction(tenant, namespace, functionName,
Integer.parseInt(instanceId));
```
### Start 2
You can start all stopped function instances using Admin CLI, REST API or
Java Admin API.
Admin CLI
Use the [`start`](reference-pulsar-admin.md#functions-start) subcommand.
**Example**
```shell
$ pulsar-admin functions start \
--tenant public \
--namespace default
[GitHub] [pulsar] huangdx0726 commented on issue #5575: fix the typo error
huangdx0726 commented on issue #5575: fix the typo error URL: https://github.com/apache/pulsar/issues/5575#issuecomment-551846936 shall i try to fix this issue? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang edited a comment on issue #5553: [website] Lack of a coding-guide page on Pulsar website
Jennifer88huang edited a comment on issue #5553: [website] Lack of a coding-guide page on Pulsar website URL: https://github.com/apache/pulsar/issues/5553#issuecomment-551593196 I've refined parts according to powered-by page: https://github.com/apache/pulsar/pull/5018 I've added coding-guide.js, and updated footer.js file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on issue #5575: fix the typo error
Jennifer88huang commented on issue #5575: fix the typo error URL: https://github.com/apache/pulsar/issues/5575#issuecomment-551850693 @huangdx0726 Sure, please go ahead, and thanks for your contribution. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] huangdx0726 opened a new pull request #5596: [Issue 5575] fix typo in BrokersBase file
huangdx0726 opened a new pull request #5596: [Issue 5575] fix typo in BrokersBase file URL: https://github.com/apache/pulsar/pull/5596 ## [Issue 5575] fix typo Fixes #5575 ### Motivation fix typo ### Modifications change getOwnedNamespaes to getOwnedNamespaces. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] huangdx0726 closed pull request #5596: [Issue 5575] fix typo in BrokersBase file
huangdx0726 closed pull request #5596: [Issue 5575] fix typo in BrokersBase file URL: https://github.com/apache/pulsar/pull/5596 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] huangdx0726 opened a new pull request #5596: [Issue 5575] fix typo in BrokersBase file
huangdx0726 opened a new pull request #5596: [Issue 5575] fix typo in BrokersBase file URL: https://github.com/apache/pulsar/pull/5596 ## [Issue 5575] fix typo Fixes #5575 ### Motivation fix typo ### Modifications change getOwnedNamespaes to getOwnedNamespaces. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] ltamber opened a new issue #5597: [pulsar-client-java] retry when getPartitionedTopicMetadata failed
ltamber opened a new issue #5597: [pulsar-client-java] retry when getPartitionedTopicMetadata failed URL: https://github.com/apache/pulsar/issues/5597 **Is your feature request related to a problem? Please describe.** when pulsar client create producer async, we can provide a serviceUrl with multi service address divided by comma, but when the connection to the first address failed or other exception, the producer init will fail. **Describe the solution you'd like** we can retry the other addresses This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5591: KafkaSourceRecord - Initialize key property with Optional.empty()
sijie commented on issue #5591: KafkaSourceRecord - Initialize key property with Optional.empty() URL: https://github.com/apache/pulsar/pull/5591#issuecomment-551883858 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5594: [Issue 5553] [website] Add coding-guide page
sijie commented on issue #5594: [Issue 5553] [website] Add coding-guide page URL: https://github.com/apache/pulsar/pull/5594#issuecomment-551884564 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5596: [Issue 5575] fix typo in BrokersBase file
sijie commented on issue #5596: [Issue 5575] fix typo in BrokersBase file URL: https://github.com/apache/pulsar/pull/5596#issuecomment-551885462 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] waxzce opened a new issue #5598: Proxy Websocket authentication using websocket in browser
waxzce opened a new issue #5598: Proxy Websocket authentication using websocket in browser URL: https://github.com/apache/pulsar/issues/5598 Websocket API in a browser does not allow to manage header https://developer.mozilla.org/en-US/docs/Web/API/WebSocket/WebSocket The authentication using plain HTTP is not possible on this case, and it seems that is what the pulsar implement at the moment https://github.com/apache/pulsar/blob/master/pulsar-websocket/src/main/java/org/apache/pulsar/websocket/AbstractWebSocketHandler.java#L70 There are mainly 4 solutions used out there to authenticate WS: 1. All in the query string (do not want to argue here, seems to be a bad bad idea) 2. Send a first message after connection containing the auth and close the WebSocket if there is no auth message for X seconds (I'm also not very fan of this) 3. In the URL, you can add `wss://user:password@pulsarhost/` and it will be treated as HTTP basic auth, a `wss://my_token@pulsarhost/` will be seen as the user ill be the token and the password empty. Can work despite the ugly semantic. 4. At the opening of browser WebSocket, we can pass on arguments a string array which will be sent as `Sec-WebSocket-Protocol` header and is available downstream to the authImpl, so each auth plugin can manage it. (there is some limitation so using base64 will be mandatory, but easy wrapping) So, how do you want to manage this? Manage it explicitly on the WebSocket proxy or let people manage? My personal opinion is option 4, but if we do that, best will be to make it work on default auth plugin, and add it to the documentation. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] vicaya edited a comment on issue #5598: Proxy Websocket authentication using websocket in browser
vicaya edited a comment on issue #5598: Proxy Websocket authentication using websocket in browser URL: https://github.com/apache/pulsar/issues/5598#issuecomment-551943081 Ideally, the browser websocket api needs to be enhanced to support additional headers per websocket RFC 6455 (section 4.1). OTOH, IMO, 3 (using basic auth info as token) is the most practica and requires minimal change at both client and server side. Using subprotocols for auth is even more hackish and requires more substantial changes to existing clients and servers. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] vicaya commented on issue #5598: Proxy Websocket authentication using websocket in browser
vicaya commented on issue #5598: Proxy Websocket authentication using websocket in browser URL: https://github.com/apache/pulsar/issues/5598#issuecomment-551943081 Ideally, the browser websocket api needs to be enhanced to support additional headers per websocket RFC 6455 (section 4.1). OTOH, IMO, #3 (using basic auth info as token) is the most practica and requires minimal change at both client and server side. Using subprotocols for auth is even more hackish and requires more substantial changes to existing clients and servers. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] vicaya edited a comment on issue #5598: Proxy Websocket authentication using websocket in browser
vicaya edited a comment on issue #5598: Proxy Websocket authentication using websocket in browser URL: https://github.com/apache/pulsar/issues/5598#issuecomment-551943081 Ideally, the browser websocket api needs to be enhanced to support additional headers per websocket RFC 6455 (section 4.1). OTOH, IMO, 3 (using basic auth info as token) is the most practical and requires minimal change at both client and server side. Using subprotocols for auth is even more hackish and requires more substantial changes to existing clients and servers. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on issue #5587: [Issue 5585][pulsar-client] Fix producer Semaphore release error
merlimat commented on issue #5587: [Issue 5585][pulsar-client] Fix producer Semaphore release error URL: https://github.com/apache/pulsar/pull/5587#issuecomment-551963297 @rdhabalia PTAL as well This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat merged pull request #5591: KafkaSourceRecord - Initialize key property with Optional.empty()
merlimat merged pull request #5591: KafkaSourceRecord - Initialize key property with Optional.empty() URL: https://github.com/apache/pulsar/pull/5591 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated: [pulsar-io] [kafka-connect-adapter] KafkaSourceRecord - Initialize key property with Optional.empty() if keyBytes from SourceRecord is null (Optional property should ne
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new f2ee3fa [pulsar-io] [kafka-connect-adapter] KafkaSourceRecord -
Initialize key property with Optional.empty() if keyBytes from SourceRecord is
null (Optional property should never itself be null) (#5591)
f2ee3fa is described below
commit f2ee3fa6ab98ed284cd352a33286aa35135c237e
Author: Naveen Kumar
AuthorDate: Sat Nov 9 01:15:32 2019 +0530
[pulsar-io] [kafka-connect-adapter] KafkaSourceRecord - Initialize key
property with Optional.empty() if keyBytes from SourceRecord is null (Optional
property should never itself be null) (#5591)
---
.../java/org/apache/pulsar/io/kafka/connect/KafkaConnectSource.java | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git
a/pulsar-io/kafka-connect-adaptor/src/main/java/org/apache/pulsar/io/kafka/connect/KafkaConnectSource.java
b/pulsar-io/kafka-connect-adaptor/src/main/java/org/apache/pulsar/io/kafka/connect/KafkaConnectSource.java
index d9662c4..1bdd6c4 100644
---
a/pulsar-io/kafka-connect-adaptor/src/main/java/org/apache/pulsar/io/kafka/connect/KafkaConnectSource.java
+++
b/pulsar-io/kafka-connect-adaptor/src/main/java/org/apache/pulsar/io/kafka/connect/KafkaConnectSource.java
@@ -187,9 +187,7 @@ public class KafkaConnectSource implements
Source> {
srcRecord.topic(), srcRecord.keySchema(), srcRecord.key());
byte[] valueBytes = valueConverter.fromConnectData(
srcRecord.topic(), srcRecord.valueSchema(), srcRecord.value());
-if (keyBytes != null) {
-this.key =
Optional.of(Base64.getEncoder().encodeToString(keyBytes));
-}
+this.key = keyBytes != null ?
Optional.of(Base64.getEncoder().encodeToString(keyBytes)) : Optional.empty();
this.value = new KeyValue(keyBytes, valueBytes);
this.topicName = Optional.of(srcRecord.topic());
[GitHub] [pulsar] merlimat commented on a change in pull request #5557: [Schema]Add SchemaDisabled for schema
merlimat commented on a change in pull request #5557: [Schema]Add
SchemaDisabled for schema
URL: https://github.com/apache/pulsar/pull/5557#discussion_r344342273
##
File path:
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Schema.java
##
@@ -213,6 +213,16 @@ default void configureSchemaInfo(String topic, String
componentName,
return
DefaultImplementation.newProtobufSchema(SchemaDefinition.builder().withPojo(clazz).build());
}
+/**
+ * Disable SchemaInfo.
+ *
+ * @param schema instance
+ * @return a Schema instance of bytes type
+ */
+static Schema disabled(Schema schema) {
Review comment:
> this is not about disabling schema validation. this is about disabling
carrying schema information
That was the point that "disabled" is not clear enough to convey what's
being disabled.
> We can choose a better name if SchemaDisabled is not accurate. but I don't
think it should be added to producer or consumer configuration.
Why not? To me it seems more of a producer/consumer property: the "schema"
is the same, but you don't want to pass the schema info to broker.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options
addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-551971510 rerun java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options
addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-552028052 @sijie @jerrypeng this is ready for another look, let me know if you have any questions! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jerrypeng commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options
jerrypeng commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#discussion_r344412355 ## File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionRuntimeManager.java ## @@ -151,7 +151,7 @@ public FunctionRuntimeManager(WorkerConfig workerConfig, WorkerService workerSer } secretsProviderConfigurator.init(workerConfig.getSecretsProviderConfiguratorConfig()); -Optional functionAuthProvider = Optional.empty(); Review comment: Why do we need to change this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] addisonj commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options
addisonj commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#discussion_r344412884 ## File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionRuntimeManager.java ## @@ -151,7 +151,7 @@ public FunctionRuntimeManager(WorkerConfig workerConfig, WorkerService workerSer } secretsProviderConfigurator.init(workerConfig.getSecretsProviderConfiguratorConfig()); -Optional functionAuthProvider = Optional.empty(); Review comment: Because we now allow namespaces to be overridden by the ManifestCustomizer, we end up with an authprovider class being created per function, as the authProvider might be writing creds to different namespaces depending on the function. We do that by delaying the instantiation of the AuthProvider until we have the function details, so we just pass the classname into runtime providers. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jerrypeng commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options
jerrypeng commented on a change in pull request #5400: [functions] Allow
functions to pass runtime specific options
URL: https://github.com/apache/pulsar/pull/5400#discussion_r344413224
##
File path:
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeFactory.java
##
@@ -181,24 +186,23 @@ public void initialize(WorkerConfig workerConfig,
AuthenticationConfig authentic
this.javaInstanceJarFile = this.pulsarRootDir +
"/instances/java-instance.jar";
this.pythonInstanceFile = this.pulsarRootDir +
"/instances/python-instance/python_instance_main.py";
this.serverCaBytes = workerConfig.getTlsTrustChainBytes();
+this.manifestCustomizerClassName =
factoryConfig.getKubernetesManifestCustomizerClassName();
+this.manifestCustomizerStaticConfig =
factoryConfig.getKubernetesManifestCustomizerConfig();
try {
setupClient();
} catch (Exception e) {
log.error("Failed to setup client", e);
throw new RuntimeException(e);
}
-if (functionAuthProvider.isPresent()) {
-if (!(functionAuthProvider.get() instanceof
KubernetesFunctionAuthProvider)) {
+this.authProviderClassName = functionAuthProviderClass;
Review comment:
I don't think we need change this
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jerrypeng commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options
jerrypeng commented on a change in pull request #5400: [functions] Allow
functions to pass runtime specific options
URL: https://github.com/apache/pulsar/pull/5400#discussion_r344413435
##
File path:
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeFactory.java
##
@@ -267,7 +281,8 @@ public void close() {
public void doAdmissionChecks(Function.FunctionDetails functionDetails) {
KubernetesRuntime.doChecks(functionDetails);
validateMinResourcesRequired(functionDetails);
-secretsProviderConfigurator.doAdmissionChecks(appsClient, coreClient,
jobNamespace, functionDetails);
+KubernetesManifestCustomizer manifestCustomizer =
buildManifestCustomizer(functionDetails);
Review comment:
Why do we need to add this here?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jerrypeng commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options
jerrypeng commented on a change in pull request #5400: [functions] Allow
functions to pass runtime specific options
URL: https://github.com/apache/pulsar/pull/5400#discussion_r344413435
##
File path:
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeFactory.java
##
@@ -267,7 +281,8 @@ public void close() {
public void doAdmissionChecks(Function.FunctionDetails functionDetails) {
KubernetesRuntime.doChecks(functionDetails);
validateMinResourcesRequired(functionDetails);
-secretsProviderConfigurator.doAdmissionChecks(appsClient, coreClient,
jobNamespace, functionDetails);
+KubernetesManifestCustomizer manifestCustomizer =
buildManifestCustomizer(functionDetails);
Review comment:
Why do we need to add this here?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jerrypeng commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options
jerrypeng commented on a change in pull request #5400: [functions] Allow
functions to pass runtime specific options
URL: https://github.com/apache/pulsar/pull/5400#discussion_r344414390
##
File path:
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeFactory.java
##
@@ -361,8 +376,26 @@ void
validateMinResourcesRequired(Function.FunctionDetails functionDetails) {
}
}
+KubernetesManifestCustomizer
buildManifestCustomizer(Function.FunctionDetails funcDetails) {
+
+KubernetesManifestCustomizer manifestCustomizer;
+if (!isEmpty(manifestCustomizerClassName)) {
+manifestCustomizer = (KubernetesManifestCustomizer)
Reflections.createInstance(manifestCustomizerClassName,
ClassLoader.getSystemClassLoader());
+} else {
+manifestCustomizer = new NoOpKubernetesManifestCustomizer();
+}
+manifestCustomizer.init(funcDetails, manifestCustomizerStaticConfig);
+return manifestCustomizer;
+}
+
@Override
-public Optional getAuthProvider() {
-return Optional.ofNullable(authProvider.orElse(null));
+public Optional
getAuthProvider(Function.FunctionDetails funcDetails) {
Review comment:
lets not change this
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jerrypeng commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options
jerrypeng commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#discussion_r344414425 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeFactory.java ## @@ -104,7 +109,7 @@ private SecretsProviderConfigurator secretsProviderConfigurator; @ToString.Exclude @EqualsAndHashCode.Exclude -private Optional authProvider; +private Optional authProviderClassName; Review comment: Why do we need to change this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jerrypeng commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options
jerrypeng commented on a change in pull request #5400: [functions] Allow
functions to pass runtime specific options
URL: https://github.com/apache/pulsar/pull/5400#discussion_r344415812
##
File path:
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/BasicKubernetesManifestCustomizer.java
##
@@ -0,0 +1,107 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.functions.runtime;
+
+import io.kubernetes.client.models.*;
+import lombok.Getter;
+import lombok.NoArgsConstructor;
+import lombok.Setter;
+
+import com.google.gson.Gson;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.pulsar.functions.proto.Function;
+
+import java.util.List;
+import java.util.Map;
+
+/**
+ * An implementation of the {@link KubernetesManifestCustomizer} that allows
+ * for some basic customization of namespace, labels, annotations, node
selectors,
+ * and tolerations.
+ *
+ * With the right RBAC permissions for the functions worker, these should be
safe to
+ * modify (for example, a service account must have permissions in the
specified jobNamespace)
+ *
+ */
+public class BasicKubernetesManifestCustomizer implements
KubernetesManifestCustomizer {
+
+@Getter
+@Setter
+@NoArgsConstructor
+static private class RuntimeOpts {
+private String jobNamespace;
+private Map extraLabels;
+private Map extraAnnotations;
+private Map nodeSelectorLabels;
+private List tolerations;
+}
+
+private RuntimeOpts opts;
+
+@Override
+public void init(Function.FunctionDetails funcDetails, String
staticConfig) {
Review comment:
staticConfig is not used?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] addisonj commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options
addisonj commented on a change in pull request #5400: [functions] Allow
functions to pass runtime specific options
URL: https://github.com/apache/pulsar/pull/5400#discussion_r344416501
##
File path:
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeFactory.java
##
@@ -361,8 +376,26 @@ void
validateMinResourcesRequired(Function.FunctionDetails functionDetails) {
}
}
+KubernetesManifestCustomizer
buildManifestCustomizer(Function.FunctionDetails funcDetails) {
+
+KubernetesManifestCustomizer manifestCustomizer;
+if (!isEmpty(manifestCustomizerClassName)) {
+manifestCustomizer = (KubernetesManifestCustomizer)
Reflections.createInstance(manifestCustomizerClassName,
ClassLoader.getSystemClassLoader());
+} else {
+manifestCustomizer = new NoOpKubernetesManifestCustomizer();
+}
+manifestCustomizer.init(funcDetails, manifestCustomizerStaticConfig);
+return manifestCustomizer;
+}
+
@Override
-public Optional getAuthProvider() {
-return Optional.ofNullable(authProvider.orElse(null));
+public Optional
getAuthProvider(Function.FunctionDetails funcDetails) {
Review comment:
Yeah, so the problem is (or come up with an alternative) the issues is that
we either:
1. The `KubernetesFunctionAuthProvider` won't know the right namespace to
create the secret in. Since secrets are per namespace, that will break for any
functions that override the namespace they want to run in. Or
2. We could call change the `KubernetesFunctionAuthProvider` such that it
gets the namespace via some other means (instead of the initialize method,
obviously, we don't want to have the initialize method called multiple times as
that would be very strange for custom implementations). Looking at the API, I
don't see any clean way to add the namespace into the `cacheAuthData` call of
the FunctionAuthProvider. I spent a fair amount of time considering
alternatives, but this seemed like the cleanest approach to simple delay the
invocation of the AuthProvider and have it be scoped per function.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] addisonj commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options
addisonj commented on a change in pull request #5400: [functions] Allow
functions to pass runtime specific options
URL: https://github.com/apache/pulsar/pull/5400#discussion_r344416849
##
File path:
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeFactory.java
##
@@ -181,24 +186,23 @@ public void initialize(WorkerConfig workerConfig,
AuthenticationConfig authentic
this.javaInstanceJarFile = this.pulsarRootDir +
"/instances/java-instance.jar";
this.pythonInstanceFile = this.pulsarRootDir +
"/instances/python-instance/python_instance_main.py";
this.serverCaBytes = workerConfig.getTlsTrustChainBytes();
+this.manifestCustomizerClassName =
factoryConfig.getKubernetesManifestCustomizerClassName();
+this.manifestCustomizerStaticConfig =
factoryConfig.getKubernetesManifestCustomizerConfig();
try {
setupClient();
} catch (Exception e) {
log.error("Failed to setup client", e);
throw new RuntimeException(e);
}
-if (functionAuthProvider.isPresent()) {
-if (!(functionAuthProvider.get() instanceof
KubernetesFunctionAuthProvider)) {
+this.authProviderClassName = functionAuthProviderClass;
Review comment:
see comment here https://github.com/apache/pulsar/pull/5400/files#r344416501
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] addisonj commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options
addisonj commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#discussion_r344416860 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeFactory.java ## @@ -104,7 +109,7 @@ private SecretsProviderConfigurator secretsProviderConfigurator; @ToString.Exclude @EqualsAndHashCode.Exclude -private Optional authProvider; +private Optional authProviderClassName; Review comment: See comment here: https://github.com/apache/pulsar/pull/5400/files#r344416501 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] addisonj commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options
addisonj commented on a change in pull request #5400: [functions] Allow
functions to pass runtime specific options
URL: https://github.com/apache/pulsar/pull/5400#discussion_r344417791
##
File path:
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/BasicKubernetesManifestCustomizer.java
##
@@ -0,0 +1,107 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.functions.runtime;
+
+import io.kubernetes.client.models.*;
+import lombok.Getter;
+import lombok.NoArgsConstructor;
+import lombok.Setter;
+
+import com.google.gson.Gson;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.pulsar.functions.proto.Function;
+
+import java.util.List;
+import java.util.Map;
+
+/**
+ * An implementation of the {@link KubernetesManifestCustomizer} that allows
+ * for some basic customization of namespace, labels, annotations, node
selectors,
+ * and tolerations.
+ *
+ * With the right RBAC permissions for the functions worker, these should be
safe to
+ * modify (for example, a service account must have permissions in the
specified jobNamespace)
+ *
+ */
+public class BasicKubernetesManifestCustomizer implements
KubernetesManifestCustomizer {
+
+@Getter
+@Setter
+@NoArgsConstructor
+static private class RuntimeOpts {
+private String jobNamespace;
+private Map extraLabels;
+private Map extraAnnotations;
+private Map nodeSelectorLabels;
+private List tolerations;
+}
+
+private RuntimeOpts opts;
+
+@Override
+public void init(Function.FunctionDetails funcDetails, String
staticConfig) {
Review comment:
Not in the implementation, but our use case for this is basically to have
certain tenants to be mapped to specific namespaces and what not, so in that
case, we could pass some configuration that would contain this mapping (rather
than having to hardcode it in our implementation)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options
addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-552046680 I considered such an approach, but wasn't sure if that was something that made sense for other providers. Will take a look at refactoring this to support that. However, I do believe the changes (or som other changes) to KubernetesFunctionAuthProvider are necessary such that the namespace in which the secret is created can be overridden by the customizer. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jerrypeng commented on issue #5400: [functions] Allow functions to pass runtime specific options
jerrypeng commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-552047388 @addisonj also see if modiying "KubernetesFunctionAuthProvider/FunctionAuthProvider" interface to take in custom options can satisfy your use case. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options
addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-552048442 Perhaps I am missing something, but I think there is a mismatch here. The `FunctionRuntimeManager` can manage the creation of the `RuntimeCustomizer`, but it couldn't be eagerly in it's constructor or initialization methods. It would need to be during the `addAssignment` and `updateAssignment` methods as that is the first place where we get the function details. In other words, the `FunctionRuntimeManager`'s lifecycle is such that it managed multiple functions and would need to have a factory method to create a `RuntimeCustomizer` for each function. This is essentially the problem with `FunctionAuthProvider` as it currently is created once for the whole runtime and instead needs to be per function. Perhaps the `RuntimeCustomizer` could be responsible for the lifecycle of the `FunctionAuthProvider` as well, but their lifecycles would seem intertwined. Let me know if I am missing something. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5571: Add epoch for connection handler to handle create producer timeout.
codelipenghui commented on issue #5571: Add epoch for connection handler to handle create producer timeout. URL: https://github.com/apache/pulsar/pull/5571#issuecomment-552050075 run cpp tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5491: [Issue 5476]Fix message deduplicate issue while using external sequence id with batch produce
codelipenghui commented on issue #5491: [Issue 5476]Fix message deduplicate issue while using external sequence id with batch produce URL: https://github.com/apache/pulsar/pull/5491#issuecomment-552050177 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5491: [Issue 5476]Fix message deduplicate issue while using external sequence id with batch produce
codelipenghui commented on issue #5491: [Issue 5476]Fix message deduplicate issue while using external sequence id with batch produce URL: https://github.com/apache/pulsar/pull/5491#issuecomment-552050267 run cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5582: pulsar dashboard collector encountered error message
tuteng commented on issue #5582: pulsar dashboard collector encountered error message URL: https://github.com/apache/pulsar/issues/5582#issuecomment-552055106 It seems that there are more namespaces. You can check whether there are many identical namespaces in your cluster. In theory, in one environment, multiple cluster namespaces should be unique in one environment. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia opened a new pull request #5599: [pulsar-broker] close managed-ledgers before giving up bundle ownership to avoid bad zk-version
rdhabalia opened a new pull request #5599: [pulsar-broker] close managed-ledgers before giving up bundle ownership to avoid bad zk-version URL: https://github.com/apache/pulsar/pull/5599 ### Motivation right now, while unloading bundle: broker removes ownership of bundle after timeout even if topic's managed-ledger is not closed successfully and `ManagedLedgerFactoryImpl` closes unclosed ml-ledger on broker shutdown which causes bad zk-version in to the new broker and because of that cursors are not able to update cursor-metadata into zk. ``` 01:01:13.452 [shutdown-thread-57-1] INFO org.apache.pulsar.broker.namespace.OwnedBundle - Disabling ownership: my-property/my-cluster/my-ns/0xd000_0xe000 : 01:01:13.653 [shutdown-thread-57-1] INFO org.apache.pulsar.broker.service.BrokerService - [persistent://my-property/my-cluster/my-ns/topic-partition-53] Unloading topic : 01:02:13.677 [shutdown-thread-57-1] INFO org.apache.pulsar.broker.namespace.OwnedBundle - Unloading my-property/my-cluster/my-ns/0xd000_0xe000 namespace-bundle with 0 topics completed in 60225.0 ms : 01:02:13.675 [shutdown-thread-57-1] ERROR org.apache.pulsar.broker.namespace.OwnedBundle - Failed to close topics in namespace my-property/my-cluster/my-ns/0xd000_0xe000 in 1/MINUTES timeout 01:02:13.677 [pulsar-ordered-OrderedExecutor-7-0-EventThread] INFO org.apache.pulsar.broker.namespace.OwnershipCache - [/namespace/my-property/my-cluster/my-ns/0xd000_0xe000] Removed zk lock for service unit: OK : 01:02:14.404 [shutdown-thread-57-1] INFO org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl - [my-property/my-cluster/my-ns/persistent/topic-partition-53] Closing managed ledger ``` ### Modification This fix will make sure that broker closes managed-ledger before giving up bundle ownership to avoid below exception at new broker where bundle moves ``` 19:50:25.801 [bookkeeper-ml-workers-OrderedExecutor-8-0] WARN org.apache.bookkeeper.mledger.impl.ManagedCursorImpl - [my-property/my-cluster/persistent/topic-partition-53] Failed to update consumer usne1 org.apache.bookkeeper.mledger.ManagedLedgerException$BadVersionException: org.apache.zookeeper.KeeperException$BadVersionException: KeeperErrorCode = BadVersion Caused by: org.apache.zookeeper.KeeperException$BadVersionException: KeeperErrorCode = BadVersion at org.apache.zookeeper.KeeperException.create(KeeperException.java:118) ~[zookeeper-3.4.13.jar:3.4.13-2d71af4dbe22557fda74f9a9b4309b15a7487f03] at org.apache.bookkeeper.mledger.impl.MetaStoreImplZookeeper.lambda$null$125(MetaStoreImplZookeeper.java:288) ~[managed-ledger-original-2.4.4-yahoo.jar:2.4.4-yahoo] at org.apache.bookkeeper.mledger.util.SafeRun$1.safeRun(SafeRun.java:32) [managed-ledger-original-2.4.4-yahoo.jar:2.4.4-yahoo] ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] nathan-zhu commented on issue #5514: use pulsar get error in mac os
nathan-zhu commented on issue #5514: use pulsar get error in mac os URL: https://github.com/apache/pulsar/issues/5514#issuecomment-552062028 > @nathan-zhu try this > `pip3 install pulsar-client==2.4.1.post1` thanks, aahmed-se. now it works on my mac. thanks all people to help me on it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se closed issue #5514: use pulsar get error in mac os
aahmed-se closed issue #5514: use pulsar get error in mac os URL: https://github.com/apache/pulsar/issues/5514 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sky-big opened a new issue #5600: [Kubernetes] Fix zookeeper yaml prometheus pull metrics port
sky-big opened a new issue #5600: [Kubernetes] Fix zookeeper yaml prometheus pull metrics port URL: https://github.com/apache/pulsar/issues/5600 Zookeeper expose 8000 for prometheus pull metrics, however kubernetes yaml file is 8080. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5595: [Docs] Fix the go client docs missing in website
wolfstudy commented on issue #5595: [Docs] Fix the go client docs missing in website URL: https://github.com/apache/pulsar/pull/5595#issuecomment-552069133 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sky-big opened a new pull request #5601: Fix zookeeper expose metrics port on kubernetes yaml
sky-big opened a new pull request #5601: Fix zookeeper expose metrics port on kubernetes yaml URL: https://github.com/apache/pulsar/pull/5601 #5600 Fix zookeeper kubernetes annotations for prometheus pull metrics from port 8000 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5491: [Issue 5476]Fix message deduplicate issue while using external sequence id with batch produce
wolfstudy commented on issue #5491: [Issue 5476]Fix message deduplicate issue while using external sequence id with batch produce URL: https://github.com/apache/pulsar/pull/5491#issuecomment-552069364 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5491: [Issue 5476]Fix message deduplicate issue while using external sequence id with batch produce
wolfstudy commented on issue #5491: [Issue 5476]Fix message deduplicate issue while using external sequence id with batch produce URL: https://github.com/apache/pulsar/pull/5491#issuecomment-552069382 ping @merlimat PTAL again. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sky-big commented on issue #5601: Fix zookeeper expose metrics port on kubernetes yaml
sky-big commented on issue #5601: Fix zookeeper expose metrics port on kubernetes yaml URL: https://github.com/apache/pulsar/pull/5601#issuecomment-552070020 Hi @sijie, can you please take a look? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] raghavi92 commented on issue #4672: [Kafka connect] Transformations are not working
raghavi92 commented on issue #4672: [Kafka connect] Transformations are not working URL: https://github.com/apache/pulsar/issues/4672#issuecomment-552072529 Coming from Slack here. Would like to know if there's any scope and when we can expect custom kafka-like transforms in pulsar? For transforming messages before being published to a topic This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
