[GitHub] [pulsar] codelipenghui commented on issue #4621: [PIP-38] Support batch receive in java client.
codelipenghui commented on issue #4621: [PIP-38] Support batch receive in java client. URL: https://github.com/apache/pulsar/pull/4621#issuecomment-553296421 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 commented on issue #5570: Transaction log implemention
congbobo184 commented on issue #5570: Transaction log implemention URL: https://github.com/apache/pulsar/pull/5570#issuecomment-553296234 @sijie please review again. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5607: Upgrade bk version to 4.10.0
wolfstudy commented on issue #5607: Upgrade bk version to 4.10.0 URL: https://github.com/apache/pulsar/pull/5607#issuecomment-553299342 > org.apache.pulsar.broker.admin.AdminApiTest.setup > org.apache.pulsar.broker.admin.v1.V1_AdminApiTest.setup run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5607: Upgrade bk version to 4.10.0
wolfstudy commented on issue #5607: Upgrade bk version to 4.10.0 URL: https://github.com/apache/pulsar/pull/5607#issuecomment-553299495 > org.apache.pulsar.tests.integration.functions.PulsarStateTest.pulsar-standalone-suite run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5628: Fix: Netty threads may still linger after client close
wolfstudy commented on issue #5628: Fix: Netty threads may still linger after client close URL: https://github.com/apache/pulsar/pull/5628#issuecomment-553299919 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang opened a new pull request #5647: [docs] Update content of Pulsar SQL overview
Jennifer88huang opened a new pull request #5647: [docs] Update content of Pulsar SQL overview URL: https://github.com/apache/pulsar/pull/5647 ### Motivation There are some redundant and unclear description in the Overview. ### Modifications 1. Refine it to be clear and concise. 2. Adopt minimalism writing style. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5607: Upgrade bk version to 4.10.0
wolfstudy commented on issue #5607: Upgrade bk version to 4.10.0 URL: https://github.com/apache/pulsar/pull/5607#issuecomment-553317566 > org.apache.pulsar.proxy.server.ProxyLookupThrottlingTest.testLookup test java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #4621: [PIP-38] Support batch receive in java client.
codelipenghui commented on issue #4621: [PIP-38] Support batch receive in java client. URL: https://github.com/apache/pulsar/pull/4621#issuecomment-553318546 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy edited a comment on issue #5607: Upgrade bk version to 4.10.0
wolfstudy edited a comment on issue #5607: Upgrade bk version to 4.10.0 URL: https://github.com/apache/pulsar/pull/5607#issuecomment-553317566 > org.apache.pulsar.proxy.server.ProxyLookupThrottlingTest.testLookup run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy removed a comment on issue #5607: Upgrade bk version to 4.10.0
wolfstudy removed a comment on issue #5607: Upgrade bk version to 4.10.0 URL: https://github.com/apache/pulsar/pull/5607#issuecomment-553317566 > org.apache.pulsar.proxy.server.ProxyLookupThrottlingTest.testLookup run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5607: Upgrade bk version to 4.10.0
wolfstudy commented on issue #5607: Upgrade bk version to 4.10.0 URL: https://github.com/apache/pulsar/pull/5607#issuecomment-553322067 > org.apache.pulsar.proxy.server.ProxyLookupThrottlingTest.testLookup run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang opened a new pull request #5648: [docs] Update sql getting started
Jennifer88huang opened a new pull request #5648: [docs] Update sql getting started URL: https://github.com/apache/pulsar/pull/5648 ### Motivation The structure is not quite clear. ### Modifications Refine the structure, title and content, make it more clear to follow. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #5633: Support Avro schema from Debezium source connector
jiazhai commented on issue #5633: Support Avro schema from Debezium source connector URL: https://github.com/apache/pulsar/issues/5633#issuecomment-553325573 @raghavi92 This need to config the `key.converter` and `value.converter` for the debezium connector. The default converter is Jason converter `org.apache.kafka.connect.json.JsonConverter`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet opened a new pull request #5649: [Doc] Correct Python versions
Anonymitaet opened a new pull request #5649: [Doc] Correct Python versions URL: https://github.com/apache/pulsar/pull/5649 Resolve https://github.com/apache/pulsar/issues/5345 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5649: [Doc] Correct Python versions
Anonymitaet commented on issue #5649: [Doc] Correct Python versions URL: https://github.com/apache/pulsar/pull/5649#issuecomment-553327059 @tuteng @candlerb could you please help review? Thank you This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] candlerb opened a new issue #5650: pulsar-admin: avoid changing working directory
candlerb opened a new issue #5650: pulsar-admin: avoid changing working directory URL: https://github.com/apache/pulsar/issues/5650 **Is your feature request related to a problem? Please describe.** When pulsar-admin starts, the first thing it does is [change the working directory](https://github.com/apache/pulsar/blob/master/bin/pulsar-admin#L26). This causes several problems. (1) Any filename you give on the command line cannot be in the current directory ``` $ ls womble.yaml womble.yaml $ pulsar-admin functions create --function-config-file womble.yaml womble.yaml (No such file or directory) ``` 2. Even if you give an absolute path on the command line, any path *within* the function-config-file also cannot be in the current directory ``` $ ls func1.py womble.yaml func1.py womble.yaml $ cat womble.yaml tenant: public namespace: default name: womble py: func1.py className: func1.FirstFunction inputs: [my-topic] $ apache-pulsar-2.4.1/bin/pulsar-admin functions create --function-config-file /home/ubuntu/womble.yaml The specified python file does not exist ``` **Describe the solution you'd like** Not to change directory. There must be some reason for it - there is a comment saying `Change to PULSAR_HOME to support relative paths` - but I'm not sure what it means by that. Is it working around some Java implementation issue? If changing directory makes it more convenient for pulsar itself, it makes it less convenient for the user of pulsar. **Describe alternatives you've considered** Using pulsarctl instead - but that's not fully baked yet. **Additional context** N/A This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5345: [Doc] Fix doc issues related to BookKeeper, Python Client, and so on
Anonymitaet commented on issue #5345: [Doc] Fix doc issues related to BookKeeper, Python Client, and so on URL: https://github.com/apache/pulsar/issues/5345#issuecomment-553327737 @tuteng @candlerb I've updated the file https://github.com/apache/pulsar/blob/master/pulsar-client-cpp/python/pulsar/__init__.py#L24 in https://github.com/apache/pulsar/pull/5649 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5368: [docs] Contradictory information about what versions of python are supported
Anonymitaet commented on issue #5368: [docs] Contradictory information about what versions of python are supported URL: https://github.com/apache/pulsar/issues/5368#issuecomment-553332671 #3 has been fixed, here is the [latest doc](http://pulsar.apache.org/api/python/2.5.0-SNAPSHOT/). * `client.create_producer` and `client.create_reader` can take a "schema" argument   * Message.value() contains the object deserialized via schema  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] candlerb commented on issue #5649: [Doc] Correct Python versions
candlerb commented on issue #5649: [Doc] Correct Python versions URL: https://github.com/apache/pulsar/pull/5649#issuecomment-553345499 I presume that's correct, as long as CI tests all of those versions? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang opened a new pull request #5651: [WIP][docs] Update Pulsar SQL configuration and deployment
Jennifer88huang opened a new pull request #5651: [WIP][docs] Update Pulsar SQL configuration and deployment URL: https://github.com/apache/pulsar/pull/5651 ### Motivation The structure and content needs improvement. ### Modifications 1. Improve the structure. 2. Improve the deployment steps. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on issue #5651: [WIP][docs] Update Pulsar SQL configuration and deployment
Jennifer88huang commented on issue #5651: [WIP][docs] Update Pulsar SQL configuration and deployment URL: https://github.com/apache/pulsar/pull/5651#issuecomment-553351475 Questions to be confirmed: 1. If there are more than 3 nodes in a cluster, only one node works as coordinator, and the rest are worker nodes. Right? 2. The command to start coordinator and worker nodes are the same. 3. The structure is a little confusing. Need discussion. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] candlerb opened a new issue #5652: Server wedged after deleting and recreating functions
candlerb opened a new issue #5652: Server wedged after deleting and recreating
functions
URL: https://github.com/apache/pulsar/issues/5652
**Describe the bug**
I managed to get pulsar (standalone 2.4.1) into a wedged state reporting
bookkeeper errors after deleting and recreating the same function.
**To Reproduce**
```
$ cat womble.yaml
tenant: public
namespace: default
name: womble
py: /home/ubuntu/func1.py
className: func1.FirstFunction
inputs: [my-topic]
userConfig:
wibble: bibble
$ cat func1.py
from pulsar import Function
class FirstFunction(Function):
def process(self, item, context):
log = context.get_logger()
log.info("(v%r) Got %r with properties %r" %
(context.get_function_version(), item, context.get_message_properties()))
$ apache-pulsar-2.4.1/bin/pulsar-admin functions create
--function-config-file /home/ubuntu/womble.yaml
...
$ apache-pulsar-2.4.1/bin/pulsar-admin functions delete --name womble
```
and repeat.
**Expected behavior**
Obviously, should be able to delete and recreate the function as many times
as required.
**Actual behavior**
I got into a state where pulsar commands are hanging, and timing out after
60 seconds.
tcpdump for pulsar-admin create is in [this
gist](https://gist.github.com/candlerb/e0d926ce3488f762fff91c8f1ddd8a4f).
Shows repeated `org.apache.bookkeeper.mledger.ManagedLedgerException:
ManagedCursor not found: public%2Fdefault%2Fwomble`
With pulsar-admin delete, tcpdump shows nothing useful - it just times out.
However, in the foreground output of the pulsar server itself, I see:
```
10:43:12.569 [cluster-service-coordinator-timer] ERROR
org.apache.pulsar.functions.worker.MembershipManager - Failed to get status of
coordinate topic persistent://public/functions/coordinate
org.apache.pulsar.client.admin.PulsarAdminException$TimeoutException:
java.util.concurrent.TimeoutException
at
org.apache.pulsar.client.admin.internal.TopicsImpl.getStats(TopicsImpl.java:419)
~[org.apache.pulsar-pulsar-client-admin-original-2.4.1.jar:2.4.1]
at
org.apache.pulsar.functions.worker.MembershipManager.getCurrentMembership(MembershipManager.java:126)
~[org.apache.pulsar-pulsar-functions-worker-2.4.1.jar:2.4.1]
at
org.apache.pulsar.functions.worker.MembershipManager.checkFailures(MembershipManager.java:174)
~[org.apache.pulsar-pulsar-functions-worker-2.4.1.jar:2.4.1]
at
org.apache.pulsar.functions.worker.WorkerService.lambda$start$0(WorkerService.java:191)
~[org.apache.pulsar-pulsar-functions-worker-2.4.1.jar:2.4.1]
at
org.apache.pulsar.functions.worker.ClusterServiceCoordinator.lambda$start$0(ClusterServiceCoordinator.java:72)
~[org.apache.pulsar-pulsar-functions-worker-2.4.1.jar:2.4.1]
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[?:1.8.0_222]
at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
[?:1.8.0_222]
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
[?:1.8.0_222]
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
[?:1.8.0_222]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[?:1.8.0_222]
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[?:1.8.0_222]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_222]
Caused by: java.util.concurrent.TimeoutException
at
java.util.concurrent.CompletableFuture.timedGet(CompletableFuture.java:1771)
~[?:1.8.0_222]
at
java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1915)
~[?:1.8.0_222]
at
org.apache.pulsar.client.admin.internal.TopicsImpl.getStats(TopicsImpl.java:412)
~[org.apache.pulsar-pulsar-client-admin-original-2.4.1.jar:2.4.1]
... 11 more
10:43:12.570 [cluster-service-coordinator-timer] ERROR
org.apache.pulsar.functions.worker.ClusterServiceCoordinator - Cluster timer
task membership-monitor failed with exception.
java.lang.RuntimeException:
org.apache.pulsar.client.admin.PulsarAdminException$TimeoutException:
java.util.concurrent.TimeoutException
at
org.apache.pulsar.functions.worker.MembershipManager.getCurrentMembership(MembershipManager.java:130)
~[org.apache.pulsar-pulsar-functions-worker-2.4.1.jar:2.4.1]
at
org.apache.pulsar.functions.worker.MembershipManager.checkFailures(MembershipManager.java:174)
~[org.apache.pulsar-pulsar-functions-worker-2.4.1.jar:2.4.1]
at
org.apache.pulsar.functions.worker.WorkerService.lambda$start$0(WorkerService.java:191)
~[org.apache.pulsar-pulsar-functions-worker-2.4.1.jar:2.4.1]
at
org.apache.pulsar.functions.
[GitHub] [pulsar] wolfstudy merged pull request #5643: Fix: don't set interrupt flag again after catching interrupt exception in Pulsar Client
wolfstudy merged pull request #5643: Fix: don't set interrupt flag again after catching interrupt exception in Pulsar Client URL: https://github.com/apache/pulsar/pull/5643 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (aeca8fe -> b7b9926)
This is an automated email from the ASF dual-hosted git repository. rxl pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from aeca8fe fix prometheusMetrics export contains " bug (#5605) add b7b9926 Fix: don't set interrupt flag again after catching interrupt exception in Pulsar Client (#5643) No new revisions were added by this update. Summary of changes: .../main/java/org/apache/pulsar/client/api/PulsarClientException.java| 1 - 1 file changed, 1 deletion(-)
[GitHub] [pulsar] wolfstudy commented on issue #5628: Fix: Netty threads may still linger after client close
wolfstudy commented on issue #5628: Fix: Netty threads may still linger after client close URL: https://github.com/apache/pulsar/pull/5628#issuecomment-553359372 > org.apache.pulsar.broker.service.ReplicatorTest.testResumptionAfterBacklogRelaxed org.apache.pulsar.broker.service.ReplicatorTest.testCloseReplicatorStartProducer org.apache.pulsar.broker.service.ReplicatorTest.testConfigChange org.apache.pulsar.broker.service.ReplicatorTest.testDeleteReplicatorFailure org.apache.pulsar.broker.service.ReplicatorTest.testReplicatePeekAndSkip org.apache.pulsar.broker.service.ReplicatorTest.testReplication org.apache.pulsar.broker.service.ReplicatorTest.testReplication org.apache.pulsar.broker.service.ReplicatorTest.testReplication org.apache.pulsar.broker.service.ReplicatorTest.testReplicationForBatchMessages org.apache.pulsar.broker.service.ReplicatorTest.testReplicationOverrides org.apache.pulsar.broker.service.ReplicatorTest.testReplicatorClearBacklog org.apache.pulsar.broker.service.ReplicatorTest.testResetCursorNotFail org.apache.pulsar.broker.service.ReplicatorTest.testReplicatorProducerClosing org.apache.pulsar.broker.service.schema.PartitionedTopicsSchemaTest.partitionedTopicWithSchema run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5649: [Doc] Correct Python versions
tuteng commented on issue #5649: [Doc] Correct Python versions URL: https://github.com/apache/pulsar/pull/5649#issuecomment-553362244 run java8 tests run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (b7b9926 -> ca9e28b)
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from b7b9926 Fix: don't set interrupt flag again after catching interrupt exception in Pulsar Client (#5643) add ca9e28b Improve PartitionedTopicsSchemaTest (#5640) No new revisions were added by this update. Summary of changes: .../pulsar/broker/service/BkEnsemblesTestBase.java | 115 + .../broker/service/BrokerBkEnsemblesTests.java | 83 +-- .../schema/PartitionedTopicsSchemaTest.java| 36 --- 3 files changed, 136 insertions(+), 98 deletions(-) create mode 100644 pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BkEnsemblesTestBase.java
[GitHub] [pulsar] sijie merged pull request #5640: Improve PartitionedTopicsSchemaTest
sijie merged pull request #5640: Improve PartitionedTopicsSchemaTest URL: https://github.com/apache/pulsar/pull/5640 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] ltamber commented on a change in pull request #5603: [Issue 5597][pulsar-client-java] retry when getPartitionedTopicMetadata failed
ltamber commented on a change in pull request #5603: [Issue
5597][pulsar-client-java] retry when getPartitionedTopicMetadata failed
URL: https://github.com/apache/pulsar/pull/5603#discussion_r345715692
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/HttpClient.java
##
@@ -127,8 +128,9 @@ public void close() throws IOException {
public CompletableFuture get(String path, Class clazz) {
final CompletableFuture future = new CompletableFuture<>();
try {
-String requestUrl = new
URL(serviceNameResolver.resolveHostUri().toURL(), path).toString();
-String remoteHostName =
serviceNameResolver.resolveHostUri().getHost();
Review comment:
@sijie maybe a bug here, the host in requestUrl not equal with
remoteHostName if multi-broker service url provided, and will step forward two
service url every request. please take a look.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] eolivelli commented on issue #5607: Upgrade bk version to 4.10.0
eolivelli commented on issue #5607: Upgrade bk version to 4.10.0 URL: https://github.com/apache/pulsar/pull/5607#issuecomment-553385328 @sijie in the release noted of 4.10.0 I did not mention this new Exception, it is kind of breaking change in the API. Shall we add a warning in the breaking changed section if the release notes? Can you send a PR with your findings about breaking changes? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5607: Upgrade bk version to 4.10.0
sijie commented on issue #5607: Upgrade bk version to 4.10.0 URL: https://github.com/apache/pulsar/pull/5607#issuecomment-553387022 > in the release noted of 4.10.0 I did not mention this new Exception, it is kind of breaking change in the API. @eolivelli yes we should update the release notes of bookkeeper 4.10.0. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5590: [Issue 5474][pulsar-io-debezium] Support CDC Connector for MongoDB
tuteng commented on issue #5590: [Issue 5474][pulsar-io-debezium] Support CDC Connector for MongoDB URL: https://github.com/apache/pulsar/pull/5590#issuecomment-553388736 You need init data in here https://github.com/apache/pulsar/pull/5590/files#r345036862 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5648: [docs] Update sql getting started
tuteng commented on issue #5648: [docs] Update sql getting started URL: https://github.com/apache/pulsar/pull/5648#issuecomment-553389581 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5641: Cherry-pick functions admin api docs to 2.4.1
wolfstudy commented on issue #5641: Cherry-pick functions admin api docs to 2.4.1 URL: https://github.com/apache/pulsar/pull/5641#issuecomment-553390209 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar.wiki] branch master updated: Updated PIP 47: Time Based Release Plan (markdown)
This is an automated email from the ASF dual-hosted git repository. rxl pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git The following commit(s) were added to refs/heads/master by this push: new ea599b0 Updated PIP 47: Time Based Release Plan (markdown) ea599b0 is described below commit ea599b0c64b0ee7f10bdeee476a9c2ad99c32abb Author: 冉小龙 AuthorDate: Wed Nov 13 20:54:32 2019 +0800 Updated PIP 47: Time Based Release Plan (markdown) --- PIP-47:-Time-Based-Release-Plan.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/PIP-47:-Time-Based-Release-Plan.md b/PIP-47:-Time-Based-Release-Plan.md index e3c411d..51ad5d5 100644 --- a/PIP-47:-Time-Based-Release-Plan.md +++ b/PIP-47:-Time-Based-Release-Plan.md @@ -84,6 +84,6 @@ Feature releases will be a minor release by default (e.g. 2.3.0 => 2.4.0) - unle The proposed schedule for Apache Pulsar is shown below. - December 2019 - March 2020 -- March 2020 - July 2020 -- July 2020 - November 2020 -- November 2020 - February 2021 +- March 2020 - June 2020 +- June 2020 - September 2020 +- December 2020 - December 2020
[GitHub] [pulsar] congbobo184 removed a comment on issue #5570: Transaction log implemention
congbobo184 removed a comment on issue #5570: Transaction log implemention URL: https://github.com/apache/pulsar/pull/5570#issuecomment-551422684 run Integration Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 removed a comment on issue #5570: Transaction log implemention
congbobo184 removed a comment on issue #5570: Transaction log implemention URL: https://github.com/apache/pulsar/pull/5570#issuecomment-551369493 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 removed a comment on issue #5570: Transaction log implemention
congbobo184 removed a comment on issue #5570: Transaction log implemention URL: https://github.com/apache/pulsar/pull/5570#issuecomment-551422639 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 removed a comment on issue #5570: Transaction log implemention
congbobo184 removed a comment on issue #5570: Transaction log implemention URL: https://github.com/apache/pulsar/pull/5570#issuecomment-550262242 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 removed a comment on issue #5570: Transaction log implemention
congbobo184 removed a comment on issue #5570: Transaction log implemention URL: https://github.com/apache/pulsar/pull/5570#issuecomment-551422752 run Integration Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 removed a comment on issue #5570: Transaction log implemention
congbobo184 removed a comment on issue #5570: Transaction log implemention URL: https://github.com/apache/pulsar/pull/5570#issuecomment-550239971 run Integration Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 removed a comment on issue #5570: Transaction log implemention
congbobo184 removed a comment on issue #5570: Transaction log implemention URL: https://github.com/apache/pulsar/pull/5570#issuecomment-550215995 @codelipenghui @sijie @zymap PTAL This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 removed a comment on issue #5570: Transaction log implemention
congbobo184 removed a comment on issue #5570: Transaction log implemention URL: https://github.com/apache/pulsar/pull/5570#issuecomment-550976925 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5649: [Doc] Correct Python versions
tuteng commented on issue #5649: [Doc] Correct Python versions URL: https://github.com/apache/pulsar/pull/5649#issuecomment-553394651 run cpp tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5647: [docs] Update content of Pulsar SQL overview
tuteng commented on issue #5647: [docs] Update content of Pulsar SQL overview URL: https://github.com/apache/pulsar/pull/5647#issuecomment-553395150 run cpp tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5607: Upgrade bk version to 4.10.0
wolfstudy commented on issue #5607: Upgrade bk version to 4.10.0 URL: https://github.com/apache/pulsar/pull/5607#issuecomment-553402686 > org.apache.pulsar.broker.stats.PrometheusMetricsTest.testPerNamespaceStats org.apache.pulsar.broker.stats.PrometheusMetricsTest.testPerTopicStats run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #4053: Download lastest version in old version page
tuteng commented on issue #4053: Download lastest version in old version page URL: https://github.com/apache/pulsar/issues/4053#issuecomment-553403239 @Jennifer88huang @Anonymitaet Can you fix this problem? Replace download link of the document to correct link https://archive.apache.org/dist/pulsar/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng edited a comment on issue #4053: Download lastest version in old version page
tuteng edited a comment on issue #4053: Download lastest version in old version page URL: https://github.com/apache/pulsar/issues/4053#issuecomment-553403239 @Jennifer88huang @Anonymitaet Can you fix this problem? Replace download link https://github.com/apache/pulsar/blob/master/site2/website/versioned_docs/version-2.3.0/client-libraries-cpp.md of the document to correct link https://archive.apache.org/dist/pulsar/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng edited a comment on issue #4053: Download lastest version in old version page
tuteng edited a comment on issue #4053: Download lastest version in old version page URL: https://github.com/apache/pulsar/issues/4053#issuecomment-553403239 @Jennifer88huang @Anonymitaet Can you try fix this problem? Replace download link https://github.com/apache/pulsar/blob/master/site2/website/versioned_docs/version-2.3.0/client-libraries-cpp.md of the document to correct link https://archive.apache.org/dist/pulsar/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui opened a new pull request #5653: Add highest sequenceId for CommandSendReceipt.
codelipenghui opened a new pull request #5653: Add highest sequenceId for CommandSendReceipt. URL: https://github.com/apache/pulsar/pull/5653 # Motivation Since #5491 merged, while user use new pulsar client to produce batch messages to older version broker(e.g. 2.4.0), send ack error will occur: ``` [pulsar-client-io-8-2] WARN org.apache.pulsar.client.impl.ProducerImpl - [persistent://sandbox/pressure-test/test-A-partition-11] [pulsar-cluster-test-13-294] Got ack for msg. expecting: 13 - got: 224 - queue-size: 9 ``` The problem is client use highest sequence id to match the response sequence id, but in old version broker can not return the highest id. So, this pr is try to fix the problem of produce batch message with new version client and old version broker. ### Modifications Add highest sequence id to CommandSendReceipt. If the response highest sequence id of send receipt > lowest sequence id, it means broker is a new version broker, so we need to verify the highest sequence id, otherwise we only verify the lowest sequence id. ### Verifying this change I have test on my mac book, use new version client to produce batch messages to new version broker passed and use new version client to produce batch messages to old version broker (2.4.0)passed. ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (no) - The public API: (no) - The schema: (no) - The default values of configurations: (no) - The wire protocol: (yes) - The rest endpoints: (no) - The admin cli options: (no) - Anything that affects deployment: (no) ### Documentation - Does this pull request introduce a new feature? (no) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] zymap commented on issue #5615: Fix hangs when type invalid args at command-line
zymap commented on issue #5615: Fix hangs when type invalid args at command-line URL: https://github.com/apache/pulsar/pull/5615#issuecomment-553436695 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5653: Add highest sequenceId for CommandSendReceipt.
codelipenghui commented on issue #5653: Add highest sequenceId for CommandSendReceipt. URL: https://github.com/apache/pulsar/pull/5653#issuecomment-553441370 integration tests will added This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options
addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-553489854 rerun integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] dtwright opened a new issue #5654: Python Pypi installation of pulsar-client broken because 2.4.1.post1 doesn't have Linux files
dtwright opened a new issue #5654: Python Pypi installation of pulsar-client broken because 2.4.1.post1 doesn't have Linux files URL: https://github.com/apache/pulsar/issues/5654 **Describe the bug** Trying to install pulsar-client on anything other than MacOS fails, because the 2.4.1.post1 published to Pypi only has MacOS files included. This means installing any package with Pipenv that declares a dependency on pulsar-client will result in strange failures, because Pypi says 2.4.1.post1 is available, but the the matching files for my arch (Linux) don't actually exist in the repo. It is possible to work around this by explicitly installing 2.4.1, but this is not desirable for automatically tracking new versions. **To Reproduce** Steps to reproduce the behavior: 1. `Pipenv install pulsar-client` on any non MacOS system 2. Observe installation failure **Expected behavior** Successful package installation **Desktop (please complete the following information):** - OS: Ubuntu 19.04 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5654: Python Pypi installation of pulsar-client broken because 2.4.1.post1 doesn't have Linux files
aahmed-se commented on issue #5654: Python Pypi installation of pulsar-client broken because 2.4.1.post1 doesn't have Linux files URL: https://github.com/apache/pulsar/issues/5654#issuecomment-553511680 try ```pip install pulsar-client==2.4.1``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] merlimat commented on issue #5654: Python Pypi installation of pulsar-client broken because 2.4.1.post1 doesn't have Linux files
merlimat commented on issue #5654: Python Pypi installation of pulsar-client broken because 2.4.1.post1 doesn't have Linux files URL: https://github.com/apache/pulsar/issues/5654#issuecomment-553517762 We should probably publish the `.post1` also for Linux This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jerrypeng commented on issue #5628: Fix: Netty threads may still linger after client close
jerrypeng commented on issue #5628: Fix: Netty threads may still linger after client close URL: https://github.com/apache/pulsar/pull/5628#issuecomment-553519106 rerun integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] dtwright commented on issue #5654: Python Pypi installation of pulsar-client broken because 2.4.1.post1 doesn't have Linux files
dtwright commented on issue #5654: Python Pypi installation of pulsar-client broken because 2.4.1.post1 doesn't have Linux files URL: https://github.com/apache/pulsar/issues/5654#issuecomment-553520358 @aahmed-se that does work (as noted above), but is not ideal because then my `Pipfile` is stuck on a particular version instead of tracking the latest when I update. @merlimat that would be great, it would take care of the issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jerrypeng commented on issue #5628: Fix: Netty threads may still linger after client close
jerrypeng commented on issue #5628: Fix: Netty threads may still linger after client close URL: https://github.com/apache/pulsar/pull/5628#issuecomment-553527932 rerun java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] lna-certi opened a new pull request #5655: feat: Add tuya authentication plugin in cpp
lna-certi opened a new pull request #5655: feat: Add tuya authentication plugin in cpp URL: https://github.com/apache/pulsar/pull/5655 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] lna-certi closed pull request #5655: feat: Add tuya authentication plugin in cpp
lna-certi closed pull request #5655: feat: Add tuya authentication plugin in cpp URL: https://github.com/apache/pulsar/pull/5655 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5641: Cherry-pick functions admin api docs to 2.4.1
wolfstudy commented on issue #5641: Cherry-pick functions admin api docs to 2.4.1 URL: https://github.com/apache/pulsar/pull/5641#issuecomment-553554165 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5607: Upgrade bk version to 4.10.0
wolfstudy commented on issue #5607: Upgrade bk version to 4.10.0 URL: https://github.com/apache/pulsar/pull/5607#issuecomment-55316 run java8 tests run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5607: Upgrade bk version to 4.10.0
wolfstudy commented on issue #5607: Upgrade bk version to 4.10.0 URL: https://github.com/apache/pulsar/pull/5607#issuecomment-553555684 run cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia commented on a change in pull request #5599: [pulsar-broker] close managed-ledgers before giving up bundle ownership to avoid bad zk-version
rdhabalia commented on a change in pull request #5599: [pulsar-broker] close
managed-ledgers before giving up bundle ownership to avoid bad zk-version
URL: https://github.com/apache/pulsar/pull/5599#discussion_r345968969
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Topic.java
##
@@ -110,7 +110,7 @@ default long getOriginalSequenceId() {
CompletableFuture checkReplication();
-CompletableFuture close();
+CompletableFuture close(boolean force);
Review comment:
> Can't we just consider "force" the only approach?
No, because first we want to close topic gracefully by closing all clients
first and then close managed-ledger. If things don't get closed gracefully then
close topic forcefully by closing managed-ledger before giving up ownership of
the bundle. So, we need both behavior.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] aahmed-se merged pull request #5649: [Doc] Correct Python versions
aahmed-se merged pull request #5649: [Doc] Correct Python versions URL: https://github.com/apache/pulsar/pull/5649 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se merged pull request #5646: [pulsar-io] hbase table should be closed properly
aahmed-se merged pull request #5646: [pulsar-io] hbase table should be closed properly URL: https://github.com/apache/pulsar/pull/5646 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (ca9e28b -> 73aaf68)
This is an automated email from the ASF dual-hosted git repository. aahmed pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from ca9e28b Improve PartitionedTopicsSchemaTest (#5640) add 73aaf68 update python versions (#5649) No new revisions were added by this update. Summary of changes: pulsar-client-cpp/python/pulsar/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[pulsar] branch master updated (73aaf68 -> ca361b5)
This is an automated email from the ASF dual-hosted git repository. aahmed pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 73aaf68 update python versions (#5649) add ca361b5 [pulsar-io] hbase table should be closed properly (#5646) No new revisions were added by this update. Summary of changes: .../main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java | 4 1 file changed, 4 insertions(+)
[GitHub] [pulsar] rdhabalia commented on a change in pull request #5599: [pulsar-broker] close managed-ledgers before giving up bundle ownership to avoid bad zk-version
rdhabalia commented on a change in pull request #5599: [pulsar-broker] close
managed-ledgers before giving up bundle ownership to avoid bad zk-version
URL: https://github.com/apache/pulsar/pull/5599#discussion_r345980392
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##
@@ -1860,7 +1860,7 @@ protected void unloadTopic(TopicName topicName, boolean
authoritative) {
validateTopicOwnership(topicName, authoritative);
try {
Topic topic = getTopicReference(topicName);
-topic.close().get();
+topic.close(false).get();
Review comment:
umm.. I think closing forcefully can be represent with boolean flag as we do
similar thing at multiple places: `PersistentTopic::delete(boolean... flags)`
Also, I was also trying to think about how to accommodate enum here instead
of flag. One thing I can think of is to add below enum under `Topic` instead
of flag.
```
enum CLOSE_ACTION { CLOSE_ALL, CLOSE_WITHOUT_CLIENT_WAIT }
```
But I feel enum is not helping much. Instead we can rename the flag to give
more meaning `closeWithoutWaitingClientDisconnect`.
So, for `PersistentTopic` if flag is enabled then broker skips waiting on
client-disconnect and immediately closes managed-ledger before giving up bundle
ownership.
And for `NonPersistentTopic` just completes the close if flag is enabled.
Can you please let me know if I am missing anything while renaming flag
instead making enum.? any thoughts?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] rdhabalia commented on issue #5599: [pulsar-broker] close managed-ledgers before giving up bundle ownership to avoid bad zk-version
rdhabalia commented on issue #5599: [pulsar-broker] close managed-ledgers before giving up bundle ownership to avoid bad zk-version URL: https://github.com/apache/pulsar/pull/5599#issuecomment-553585991 @merlimat addressed your comments and renamed the flag with more meaningful name instead making it enum as enum doesn't seem appropriate to define this method behavior. can you please review it again or can you please let me know if you have any thought on it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options
addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-553586235 rerun integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia removed a comment on issue #5599: [pulsar-broker] close managed-ledgers before giving up bundle ownership to avoid bad zk-version
rdhabalia removed a comment on issue #5599: [pulsar-broker] close managed-ledgers before giving up bundle ownership to avoid bad zk-version URL: https://github.com/apache/pulsar/pull/5599#issuecomment-553609353 rerun java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia commented on issue #5599: [pulsar-broker] close managed-ledgers before giving up bundle ownership to avoid bad zk-version
rdhabalia commented on issue #5599: [pulsar-broker] close managed-ledgers before giving up bundle ownership to avoid bad zk-version URL: https://github.com/apache/pulsar/pull/5599#issuecomment-553609353 rerun java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] merlimat opened a new pull request #97: Added integration test for acks and nacks
merlimat opened a new pull request #97: Added integration test for acks and nacks URL: https://github.com/apache/pulsar-client-go/pull/97 ### Motivation Added integration test for acks and nacks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jerrypeng commented on issue #5628: Fix: Netty threads may still linger after client close
jerrypeng commented on issue #5628: Fix: Netty threads may still linger after client close URL: https://github.com/apache/pulsar/pull/5628#issuecomment-553610875 rerun integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia removed a comment on issue #5599: [pulsar-broker] close managed-ledgers before giving up bundle ownership to avoid bad zk-version
rdhabalia removed a comment on issue #5599: [pulsar-broker] close managed-ledgers before giving up bundle ownership to avoid bad zk-version URL: https://github.com/apache/pulsar/pull/5599#issuecomment-553633011 rerun java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia commented on issue #5599: [pulsar-broker] close managed-ledgers before giving up bundle ownership to avoid bad zk-version
rdhabalia commented on issue #5599: [pulsar-broker] close managed-ledgers before giving up bundle ownership to avoid bad zk-version URL: https://github.com/apache/pulsar/pull/5599#issuecomment-553633011 rerun java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia commented on a change in pull request #5604: [pulsar-broker] recover zk-badversion while updating cursor metadata
rdhabalia commented on a change in pull request #5604: [pulsar-broker] recover
zk-badversion while updating cursor metadata
URL: https://github.com/apache/pulsar/pull/5604#discussion_r346036936
##
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
##
@@ -2033,6 +2033,30 @@ public void operationComplete(Void result, Stat stat) {
@Override
public void operationFailed(MetaStoreException e) {
+if (e instanceof
MetaStoreException.BadVersionException) {
+log.warn("[{}] Failed to update cursor metadata
for {} due to version conflict {}",
+ledger.name, name, e.getMessage());
+// it means previous owner of the ml might have
updated the version incorrectly. So, check
+// the ownership and refresh the version again.
+if (ledger.mlOwnershipChecker != null &&
ledger.mlOwnershipChecker.get()) {
+
ledger.getStore().asyncGetCursorInfo(ledger.getName(), name,
+new
MetaStoreCallback() {
+@Override
+public void
operationComplete(ManagedCursorInfo info, Stat stat) {
+cursorLedgerStat = stat;
Review comment:
Yes, I have thought about it earlier but it will be tricky because of race
condition:
if we retry the same function `persistPositionMetaStore` or any other
functions with same metadata then by that time markDelete position could have
been changed. also, metadata contains multiple info eg: ledgerId,
markDelete-position and its properties, etc.. and cursor only maintains latest
markDeletePosition in memory.. so, it's tricky to update metadata with all
latest information in a synchronized manner. So, broker can rely on next acked
message as this exception occurs rarely.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] HarishAtGitHub opened a new issue #5656: The KeyShared is only supported in java SDK and not in python
HarishAtGitHub opened a new issue #5656: The KeyShared is only supported in java SDK and not in python URL: https://github.com/apache/pulsar/issues/5656 **Describe the bug** There is feature to have KeyShared implementation in apache pulsar. and it works as expected. but there is no equivalent implementation in python. Can you please add ? Can you also check and guarantee that c++ client also supports it ? **To Reproduce**  **Expected behavior** The KeyShared should be supported in python and c++ **Screenshots**  **Desktop (please complete the following information):** - OS: linux **Additional context** I was not able to use KeyShared in python because of the lack of support. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] HarishAtGitHub opened a new issue #5657: [CLIENT SDK] Absense of MessageRouter support in python
HarishAtGitHub opened a new issue #5657: [CLIENT SDK] Absense of MessageRouter support in python URL: https://github.com/apache/pulsar/issues/5657 **Describe the bug** the message router explained here is supported only in java, but i cannot find an equivalent in python. can you help us by supporting the python equivalent ? **To Reproduce** 1. Go to link : https://pulsar.apache.org/docs/en/cookbooks-partitioned/ 2. see the java implementation 3) but i cannot see way to send custom message router in python **Expected behavior** the message router sending way should be supported in python and c++ **Screenshots** If applicable, add screenshots to help explain your problem.  **Desktop (please complete the following information):** - All This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jerrypeng commented on issue #5656: [CLIENT SDK] The KeyShared is only supported in java SDK and not in python
jerrypeng commented on issue #5656: [CLIENT SDK] The KeyShared is only supported in java SDK and not in python URL: https://github.com/apache/pulsar/issues/5656#issuecomment-553640941 @HarishAtGitHub this feature is actually already added to the python client but haven't be officially been released yet. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jerrypeng commented on issue #5628: Fix: Netty threads may still linger after client close
jerrypeng commented on issue #5628: Fix: Netty threads may still linger after client close URL: https://github.com/apache/pulsar/pull/5628#issuecomment-553657330 rerun integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5649: [Doc] Correct Python versions
Anonymitaet commented on issue #5649: [Doc] Correct Python versions URL: https://github.com/apache/pulsar/pull/5649#issuecomment-553674942 Thank you @tuteng @candlerb @aahmed-se This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Sunkwan-Kwon commented on issue #5589: Memory leak of pulsar-function-go library
Sunkwan-Kwon commented on issue #5589: Memory leak of pulsar-function-go library URL: https://github.com/apache/pulsar/issues/5589#issuecomment-553675368 Is there any update for merging? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Sunkwan-Kwon commented on issue #5626: Memory leak of pulsar-function-go library regarding time.NewTimer()
Sunkwan-Kwon commented on issue #5626: Memory leak of pulsar-function-go library regarding time.NewTimer() URL: https://github.com/apache/pulsar/issues/5626#issuecomment-553675492 Is there any update for merging? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Sunkwan-Kwon removed a comment on issue #5589: Memory leak of pulsar-function-go library
Sunkwan-Kwon removed a comment on issue #5589: Memory leak of pulsar-function-go library URL: https://github.com/apache/pulsar/issues/5589#issuecomment-553675368 Is there any update for merging? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Sunkwan-Kwon removed a comment on issue #5626: Memory leak of pulsar-function-go library regarding time.NewTimer()
Sunkwan-Kwon removed a comment on issue #5626: Memory leak of pulsar-function-go library regarding time.NewTimer() URL: https://github.com/apache/pulsar/issues/5626#issuecomment-553675492 Is there any update for merging? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Sunkwan-Kwon commented on issue #5627: [Issue 5626][pulsar-function-go] Fix a memory leak of pulsar-function-go library regarding time.NewTimer()
Sunkwan-Kwon commented on issue #5627: [Issue 5626][pulsar-function-go] Fix a memory leak of pulsar-function-go library regarding time.NewTimer() URL: https://github.com/apache/pulsar/pull/5627#issuecomment-553675833 Is there any update for merging? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Sunkwan-Kwon commented on issue #5592: [Issue 5589][pulsar-function-go] Fix a memory leak of pulsar-function-go library
Sunkwan-Kwon commented on issue #5592: [Issue 5589][pulsar-function-go] Fix a memory leak of pulsar-function-go library URL: https://github.com/apache/pulsar/pull/5592#issuecomment-553675910 Is there any update for merging? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet closed issue #5584: [Doc] Improve Pulsar Functions Admin API guide
Anonymitaet closed issue #5584: [Doc] Improve Pulsar Functions Admin API guide URL: https://github.com/apache/pulsar/issues/5584 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5584: [Doc] Improve Pulsar Functions Admin API guide
Anonymitaet commented on issue #5584: [Doc] Improve Pulsar Functions Admin API guide URL: https://github.com/apache/pulsar/issues/5584#issuecomment-553676027 Fix in https://github.com/apache/pulsar/pull/5593 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on issue #5368: [docs] Contradictory information about what versions of python are supported
Anonymitaet commented on issue #5368: [docs] Contradictory information about what versions of python are supported URL: https://github.com/apache/pulsar/issues/5368#issuecomment-553676304 @Jennifer88huang all issues have been fixed, could you please close this issue? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang closed issue #5368: [docs] Contradictory information about what versions of python are supported
Jennifer88huang closed issue #5368: [docs] Contradictory information about what versions of python are supported URL: https://github.com/apache/pulsar/issues/5368 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on issue #5368: [docs] Contradictory information about what versions of python are supported
Jennifer88huang commented on issue #5368: [docs] Contradictory information about what versions of python are supported URL: https://github.com/apache/pulsar/issues/5368#issuecomment-553681880 @Anonymitaet When you fix an issue, you can follow the template in PR, and write "Fixes #xxx". When the PR is merge, the related issue is closed automatically. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #5641: Cherry-pick functions admin api docs to 2.4.1
jiazhai commented on issue #5641: Cherry-pick functions admin api docs to 2.4.1 URL: https://github.com/apache/pulsar/pull/5641#issuecomment-553686974 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #5653: Add highest sequenceId for CommandSendReceipt.
jiazhai commented on issue #5653: Add highest sequenceId for CommandSendReceipt. URL: https://github.com/apache/pulsar/pull/5653#issuecomment-553688479 run cpp tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] huangdx0726 commented on a change in pull request #5590: [Issue 5474][pulsar-io-debezium] Support CDC Connector for MongoDB
huangdx0726 commented on a change in pull request #5590: [Issue
5474][pulsar-io-debezium] Support CDC Connector for MongoDB
URL: https://github.com/apache/pulsar/pull/5590#discussion_r346094820
##
File path:
tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/DebeziumMongoDbSourceTester.java
##
@@ -0,0 +1,79 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.tests.integration.io;
+
+import lombok.Getter;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.pulsar.tests.integration.containers.DebeziumMongoDbContainer;
+import org.apache.pulsar.tests.integration.containers.PulsarContainer;
+import org.apache.pulsar.tests.integration.topologies.PulsarCluster;
+
+import java.io.Closeable;
+import java.util.Map;
+
+@Slf4j
+public class DebeziumMongoDbSourceTester extends
SourceTester implements Closeable {
+
+private static final String NAME = "debezium-mongodb";
+
+private final String pulsarServiceUrl;
+
+@Getter
+private DebeziumMongoDbContainer debeziumMongoDbContainer;
+
+private final PulsarCluster pulsarCluster;
+public DebeziumMongoDbSourceTester(PulsarCluster cluster) {
+super(NAME);
+this.pulsarCluster = cluster;
+pulsarServiceUrl = "pulsar://pulsar-proxy:" +
PulsarContainer.BROKER_PORT;
+
+sourceConfig.put("mongodb.hosts", "rs0/" +
DebeziumMongoDbContainer.NAME + ":27107");
+sourceConfig.put("mongodb.name", "dbserver1");
+sourceConfig.put("mongodb.user", "debezium");
+sourceConfig.put("mongodb.password", "dbz");
+sourceConfig.put("mongodb.task.id","1");
+sourceConfig.put("database.whitelist", "inventory");
+sourceConfig.put("pulsar.service.url", pulsarServiceUrl);
+}
+
+@Override
+public void setServiceContainer(DebeziumMongoDbContainer container) {
+log.info("start debezium mongodb server container.");
+debeziumMongoDbContainer = container;
+pulsarCluster.startService(DebeziumMongoDbContainer.NAME,
debeziumMongoDbContainer);
+}
+
+@Override
+public void prepareSource() throws Exception {
+log.info("debezium mongodb server already contains preconfigured
data.");
Review comment:
I have added it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5607: Upgrade bk version to 4.10.0
wolfstudy commented on issue #5607: Upgrade bk version to 4.10.0 URL: https://github.com/apache/pulsar/pull/5607#issuecomment-553692379 run java8 tests run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5491: [Issue 5476]Fix message deduplicate issue while using external sequence id with batch produce
wolfstudy commented on issue #5491: [Issue 5476]Fix message deduplicate issue while using external sequence id with batch produce URL: https://github.com/apache/pulsar/pull/5491#issuecomment-553693070 @codelipenghui The change is not compatible with 2.4.2, i will move the `Milestone` to `2.5.0`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
