[GitHub] [pulsar] wolfstudy commented on issue #5790: [Issue:5687] Add prefix for new keys from Env
wolfstudy commented on issue #5790: [Issue:5687] Add prefix for new keys from Env URL: https://github.com/apache/pulsar/pull/5790#issuecomment-562022413 run cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Sunkwan-Kwon opened a new issue #5799: Using the latest release version of pulsar-client-go module from pulsar-function-go
Sunkwan-Kwon opened a new issue #5799: Using the latest release version of pulsar-client-go module from pulsar-function-go URL: https://github.com/apache/pulsar/issues/5799 **Describe the bug** Is it possible to use the latest released version of `pulsar-client-go` module from `pulsar-function-go`? The current version of `pulsar-function-go` uses `v0.0.0-20190320194916-f03971cb5b4f` of `pulsar-client-go` module like below. https://github.com/apache/pulsar/blob/180e28aceb39d1683df034c8c2234595d23ab935/pulsar-function-go/go.mod#L4 Actually, I faced a worker process hanging issue during a long-running test, but It seems that the related patch already has been merged to `pulsar-client-go`. (https://github.com/apache/pulsar/issues/5324) To avoid the hanging issue, I've manually modified the downloaded `pulsar-client-go` file under the local go module path by following the patch(https://github.com/apache/pulsar/pull/5336) and the problem has been resolved. But it is just a workaround. So that I suggest using the latest release version of `pulsar-client-go` module from `pulsar-function-go` to apply recently applied patch set. It will be great if you can consider my suggestion. **To Reproduce** N/A **Expected behavior** N/A **Screenshots** N/A **Desktop (please complete the following information):** N/A **Additional context** N/A This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 commented on issue #5570: Transaction log implemention
congbobo184 commented on issue #5570: Transaction log implemention URL: https://github.com/apache/pulsar/pull/5570#issuecomment-562042429 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] AllenChien opened a new issue #5800: C API 'pulsar_message_id_t' couples to C++ 'class pulsar::MessageId'
AllenChien opened a new issue #5800: C API 'pulsar_message_id_t' couples to C++ 'class pulsar::MessageId' URL: https://github.com/apache/pulsar/issues/5800 **Describe the bug** The C API prototype defined in message_id.h, such as: > PULSAR_PUBLIC const pulsar_message_id_t *pulsar_message_id_earliest(); > PULSAR_PUBLIC const pulsar_message_id_t *pulsar_message_id_latest(); the return type is pulsar_message_id_t, which is defined as: > struct _pulsar_message_id { > pulsar::MessageId messageId; > }; where the pulsar::MessageId is a C++ class. Thus this kind of APIs can't work smoothly in pure C env. **To Reproduce** Steps to reproduce the behavior: 1. Go to source file 'message_id.h' 2. Check its definition **Expected behavior** C API should not couple to C++ class definition. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 commented on issue #4847: Pulsar sql avro support schema version
congbobo184 commented on issue #4847: Pulsar sql avro support schema version URL: https://github.com/apache/pulsar/pull/4847#issuecomment-562082714 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 commented on issue #4847: Pulsar sql avro support schema version
congbobo184 commented on issue #4847: Pulsar sql avro support schema version URL: https://github.com/apache/pulsar/pull/4847#issuecomment-562082825 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 removed a comment on issue #4847: Pulsar sql avro support schema version
congbobo184 removed a comment on issue #4847: Pulsar sql avro support schema version URL: https://github.com/apache/pulsar/pull/4847#issuecomment-561933195 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 commented on issue #4847: Pulsar sql avro support schema version
congbobo184 commented on issue #4847: Pulsar sql avro support schema version URL: https://github.com/apache/pulsar/pull/4847#issuecomment-562083044 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 removed a comment on issue #4847: Pulsar sql avro support schema version
congbobo184 removed a comment on issue #4847: Pulsar sql avro support schema version URL: https://github.com/apache/pulsar/pull/4847#issuecomment-562083044 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 removed a comment on issue #4847: Pulsar sql avro support schema version
congbobo184 removed a comment on issue #4847: Pulsar sql avro support schema version URL: https://github.com/apache/pulsar/pull/4847#issuecomment-562082825 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 removed a comment on issue #4847: Pulsar sql avro support schema version
congbobo184 removed a comment on issue #4847: Pulsar sql avro support schema version URL: https://github.com/apache/pulsar/pull/4847#issuecomment-562082714 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy closed pull request #5795: Update website for 2.4.2 release
wolfstudy closed pull request #5795: Update website for 2.4.2 release URL: https://github.com/apache/pulsar/pull/5795 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy opened a new pull request #5801: Update website for 2.4.2 release
wolfstudy opened a new pull request #5801: Update website for 2.4.2 release URL: https://github.com/apache/pulsar/pull/5801 Signed-off-by: xiaolong.ran
[GitHub] [pulsar] wolfstudy commented on issue #5801: Update website for 2.4.2 release
wolfstudy commented on issue #5801: Update website for 2.4.2 release URL: https://github.com/apache/pulsar/pull/5801#issuecomment-562133084 @sijie I close the pull request: #5795 . > the current tool automatically cuts the documentation master (2.5.0 documentation) as 2.4.2 release documentation. Please check if we need to make adjustments to the documentation to exclude features that only exists 2.5.0. According to the current release process, I have no way to achieve this. Because if we [base master branch](https://github.com/apache/pulsar/wiki/Release-process#14-update-the-site) , we will update all the documents merged into the master branch to 2.4.2. In other words, we do not have a good way to separate each version of the document from the master, right? The document generation method in this pr is as follows: - git checkout branch-2.4 - yarn run version 2.4.2 - git checkout master - git checkout -b rxl/docs_release_2.4.2 - git add . - git commit -sm "" - git push origin rxl/docs_release_2.4.2 In this way we can ensure that the 2.5.0 document will not appear in 2.4.2, but I am not sure if this is a reasonable way of operation. If there is a better way to solve this problem, please let me know. @tuteng Please help check, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5801: Update website for 2.4.2 release
wolfstudy commented on issue #5801: Update website for 2.4.2 release URL: https://github.com/apache/pulsar/pull/5801#issuecomment-562133365 @sijie @tuteng @Anonymitaet @jiazhai PTAL, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] PierreZ opened a new pull request #5802: Provide raw counters metrics (#5735)
PierreZ opened a new pull request #5802: Provide raw counters metrics (#5735) URL: https://github.com/apache/pulsar/pull/5802 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes #5735 ### Motivation Add counter based metrics for topics. ### Modifications Added counter on AbstractTopics and propagate the result to the PrometheusHandler. ### Verifying this change Added a test ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - The rest endpoints ### Documentation - Does this pull request introduce a new feature? (yes) - If yes, how is the feature documented? (yes) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on issue #5783: [Issues 5763] Broker graceful shutdown when znode of loadbalance disappeared
Jennifer88huang commented on issue #5783: [Issues 5763] Broker graceful shutdown when znode of loadbalance disappeared URL: https://github.com/apache/pulsar/pull/5783#issuecomment-562142438 Related to #5784 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang removed a comment on issue #5783: [Issues 5763] Broker graceful shutdown when znode of loadbalance disappeared
Jennifer88huang removed a comment on issue #5783: [Issues 5763] Broker graceful shutdown when znode of loadbalance disappeared URL: https://github.com/apache/pulsar/pull/5783#issuecomment-562143029 run cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on issue #5783: [Issues 5763] Broker graceful shutdown when znode of loadbalance disappeared
Jennifer88huang commented on issue #5783: [Issues 5763] Broker graceful shutdown when znode of loadbalance disappeared URL: https://github.com/apache/pulsar/pull/5783#issuecomment-562143029 run cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] cckellogg commented on a change in pull request #5790: [Issue:5687] Add prefix for new keys from Env
cckellogg commented on a change in pull request #5790: [Issue:5687] Add prefix for new keys from Env URL: https://github.com/apache/pulsar/pull/5790#discussion_r354466596 ## File path: deployment/kubernetes/aws/broker.yaml ## @@ -25,15 +25,15 @@ metadata: data: # Tune for available memory. Increase the heap up to 24G to have # better GC behavior at high throughput -PULSAR_MEM: "\" -Dio.netty.leakDetectionLevel=disabled -Dio.netty.recycler.linkCapacity=1024 -XX:+ParallelRefProcEnabled -XX:+UnlockExperimentalVMOptions -XX:+AggressiveOpts -XX:+DoEscapeAnalysis -XX:ParallelGCThreads=32 -XX:ConcGCThreads=32 -XX:G1NewSizePercent=50 -XX:+DisableExplicitGC -XX:-ResizePLAB -XX:+ExitOnOutOfMemoryError -XX:+PerfDisableSharedMem -Xms12g -Xmx12g -XX:MaxDirectMemorySize=14g -Dpulsar.root.logger=DEBUG,FILE \"" -PULSAR_GC: "\" -XX:+UseG1GC -XX:MaxGCPauseMillis=10\"" -zookeeperServers: zk-0.zookeeper,zk-1.zookeeper,zk-2.zookeeper -configurationStoreServers: zk-0.zookeeper,zk-1.zookeeper,zk-2.zookeeper -clusterName: us-east -managedLedgerDefaultEnsembleSize: "2" -managedLedgerDefaultWriteQuorum: "2" -managedLedgerDefaultAckQuorum: "2" -deduplicationEnabled: "false" +PULSAR_PREFIX_PULSAR_MEM: "\" -Dio.netty.leakDetectionLevel=disabled -Dio.netty.recycler.linkCapacity=1024 -XX:+ParallelRefProcEnabled -XX:+UnlockExperimentalVMOptions -XX:+AggressiveOpts -XX:+DoEscapeAnalysis -XX:ParallelGCThreads=32 -XX:ConcGCThreads=32 -XX:G1NewSizePercent=50 -XX:+DisableExplicitGC -XX:-ResizePLAB -XX:+ExitOnOutOfMemoryError -XX:+PerfDisableSharedMem -Xms12g -Xmx12g -XX:MaxDirectMemorySize=14g -Dpulsar.root.logger=DEBUG,FILE \"" Review comment: This change only helps if the user builds their own image or waits for a release image. This change still dumps unexpected values into config files that do no expect it. Does that matter? Changing the chart might be a slightly bigger change but it fixes the problem for users on past releases images. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] gyehuda opened a new pull request #5803: updated link to Yahoo's open source website
gyehuda opened a new pull request #5803: updated link to Yahoo's open source website URL: https://github.com/apache/pulsar/pull/5803 ### Motivation The current docs pointed to yahoo.github.io, which we decommissioned a while ago. I propose pointing this to the new webpage at opensource.yahoo.com. ### Modifications I just changed the URL ### Verifying this change - [ ] Make sure that the change passes the CI checks. This change is a trivial rework / code cleanup without any test coverage. ### Does this pull request potentially affect one of the following parts: No ### Documentation - Does this pull request introduce a new feature? (yes / no) No This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] rdhabalia opened a new pull request #5804: [pulsar-server] add broker-configuration for relative dispatch throttling
rdhabalia opened a new pull request #5804: [pulsar-server] add broker-configuration for relative dispatch throttling URL: https://github.com/apache/pulsar/pull/5804 ### Motivation As we discussed at #5797, adding broker level relative dispatch-throttling-config. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5791: [Issue 5638][docs] Add explanation about the v1 REST API
sijie commented on issue #5791: [Issue 5638][docs] Add explanation about the v1 REST API URL: https://github.com/apache/pulsar/pull/5791#issuecomment-562262900 @zymap I agree with @rdhabalia. Adding this note in user doc doesn't address the problem raised in #5683 . It is actually making documentation much confused. The fundamental is the restful API documentation lacks versioning. We need to generate the rest api documentation by versions. So people can select the right version when they are using restful API. Hence a better approach to address #5683 : - figure out a way to generate swagger file by different versions. - change the website to display restful api by different versions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie edited a comment on issue #5791: [Issue 5638][docs] Add explanation about the v1 REST API
sijie edited a comment on issue #5791: [Issue 5638][docs] Add explanation about the v1 REST API URL: https://github.com/apache/pulsar/pull/5791#issuecomment-562262900 @zymap I agree with @rdhabalia. Adding this note in user doc doesn't address the problem raised in #5683 . It is actually making documentation much confused. The fundamental problem is the restful API documentation lacks versioning. We need to generate the rest api documentation by versions. So people can select the right version when they are using restful API. Hence a better approach to address #5683 : - figure out a way to generate swagger file by different versions. - change the website to display restful api by different versions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] cckellogg opened a new pull request #110: Fix seg fault when producer with same name is created.
cckellogg opened a new pull request #110: Fix seg fault when producer with same name is created. URL: https://github.com/apache/pulsar-client-go/pull/110 ### Motivation This fixes a seg fault when a producer with the same name is created for a topic. ``` [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xd755d6] goroutine 48 [running]: github.com/apache/pulsar-client-go/pulsar.(*partitionProducer).Close(0x0) github.com/apache/pulsar-client-go/pulsar/impl_partition_producer.go:443 +0x26 github.com/apache/pulsar-client-go/pulsar.newProducer(0xcc68c0, 0xc000342780, 0x58, 0x58, 0xc000596360) github.com/apache/pulsar-client-go/pulsar/impl_producer.go:103 +0x31c github.com/apache/pulsar-client-go/pulsar.(*client).CreateProducer(0xcc68c0, 0xc344c0, 0x13, 0x1030d22, 0xd, 0x0, 0x0, 0x0, 0x0, 0x0, ...) github.com/apache/pulsar-client-go/pulsar/client_impl.go:94 +0x7a ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] jerrypeng merged pull request #110: Fix seg fault when producer with same name is created.
jerrypeng merged pull request #110: Fix seg fault when producer with same name is created. URL: https://github.com/apache/pulsar-client-go/pull/110 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar-client-go] branch master updated: Fix seg fault when producer with same name is created. (#110)
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new 862285f Fix seg fault when producer with same name is created. (#110) 862285f is described below commit 862285fee18a213289062d855156f44823e5a724 Author: cckellogg AuthorDate: Thu Dec 5 12:28:32 2019 -0800 Fix seg fault when producer with same name is created. (#110) --- pulsar/{impl_producer.go => producer_impl.go} | 3 ++- ...partition_producer.go => producer_partition.go} | 2 +- pulsar/producer_test.go| 28 ++ 3 files changed, 31 insertions(+), 2 deletions(-) diff --git a/pulsar/impl_producer.go b/pulsar/producer_impl.go similarity index 98% rename from pulsar/impl_producer.go rename to pulsar/producer_impl.go index 6054402..ef0119e 100644 --- a/pulsar/impl_producer.go +++ b/pulsar/producer_impl.go @@ -93,8 +93,9 @@ func newProducer(client *client, options *ProducerOptions) (*producer, error) { if ok { if pe.err != nil { err = pe.err + } else { + p.producers[pe.partition] = pe.prod } - p.producers[pe.partition] = pe.prod } } diff --git a/pulsar/impl_partition_producer.go b/pulsar/producer_partition.go similarity index 99% rename from pulsar/impl_partition_producer.go rename to pulsar/producer_partition.go index 4e2ffd9..474401a 100644 --- a/pulsar/impl_partition_producer.go +++ b/pulsar/producer_partition.go @@ -107,7 +107,7 @@ func newPartitionProducer(client *client, topic string, options *ProducerOptions return nil, err } - p.log = p.log.WithField("name", *p.producerName) + p.log = p.log.WithField("name", p.producerName) p.log.Info("Created producer") p.state = producerReady diff --git a/pulsar/producer_test.go b/pulsar/producer_test.go index d6c8599..196c7f3 100644 --- a/pulsar/producer_test.go +++ b/pulsar/producer_test.go @@ -495,3 +495,31 @@ func TestNonPersistentTopic(t *testing.T) { assert.Nil(t, err) defer consumer.Close() } + +func TestProducerDuplicateNameOnSameTopic(t *testing.T) { + client, err := NewClient(ClientOptions{ + URL: serviceURL, + }) + if err != nil { + t.Fatal(err) + } + defer client.Close() + + topicName := newTopicName() + producerName := "my-producer" + + p1, err := client.CreateProducer(ProducerOptions{ + Topic: topicName, + Name: producerName, + }) + if err != nil { + t.Fatal(err) + } + defer p1.Close() + + _, err = client.CreateProducer(ProducerOptions{ + Topic: topicName, + Name: producerName, + }) + assert.NotNil(t, err, "expected error when creating producer with same name") +}
[GitHub] [pulsar] tuteng commented on issue #5417: Broker hangs and crashes when listing non-persistent topics
tuteng commented on issue #5417: Broker hangs and crashes when listing non-persistent topics URL: https://github.com/apache/pulsar/issues/5417#issuecomment-562382897 I tested this problem. under a cluster (including three brokers and three bookies), I used the `ab` tool to test. numHttpServerThreads defaults to 8. when the number of query requests initiated is significantly higher than the number that the thread can handle, it will indeed block the broker. I think this is because `non-persisten topic` is stored in memory. when there are multiple brokers, your request is sent to one of them, and the broker completes the remaining work. after the broker receives the request, it will forward the request to all brokers under the cluster. Look up all bundles of all broker, then traverse all topics under these bundles, and finally return topics. A large part of this operation is network delay. Therefore, when concurrent requests are large, the above problems will occur. I have not found a suitable way to solve this problem through fix code, but I have two alternatives to query `non-persistent topic`. 1. Reasonably evaluate your query request and configure the appropriate number of numHttpServerThreads, but this method cannot completely solve the above problems. 2. The proposal is divided into the following three steps a. Get all broker addresses ``` curl -v http://any-broker-ip:8080/admin/v2/brokers/cluster-name ``` b. Loop the following rest API to obtain bundle ``` curl -v http://broker-1:8080/admin/v2/non-persistent/test/test-namespace curl -v http://broker-2:8080/admin/v2/non-persistent/test/test-namespace ``` The following results will be returned ``` "bundles" : { "boundaries" : [ "0x", "0x4000", "0x8000", "0xc000", "0x" ], "numBundles" : 4 }, ``` c. Get the topic under the bundle through the bundle. ``` ... http://broker-ip:8080/admin/v2/non-persistent/test/test-namespace/0x_0x4000 http://broker-ip:8080/admin/v2/non-persistent/test/test-namespace/0x4000_0x8000 ... ``` I think the second method will solve the problem of blocking the broker due to the high number of concurrent requests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy opened a new pull request #5805: [Issue:5787] Fix docs for creating a K8S cluster on Minikube fail
wolfstudy opened a new pull request #5805: [Issue:5787] Fix docs for creating a K8S cluster on Minikube fail URL: https://github.com/apache/pulsar/pull/5805 Signed-off-by: xiaolong.ran Fixes #5787 ### Motivation When we creating a K8S cluster on Minikube, due to the different versions of Minikube in the local environment, the installation fails on `--kubernetes-version=v1.10.5`. ### Modifications - Remove the `--kubernetes-version=v1.10.5` in docs. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5805: [Issue:5787] Fix docs for creating a K8S cluster on Minikube fail
wolfstudy commented on issue #5805: [Issue:5787] Fix docs for creating a K8S cluster on Minikube fail URL: https://github.com/apache/pulsar/pull/5805#issuecomment-562402608 @jiazhai PTAL, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5788: [pulsar-java-client] Decouple partition switch frequency with maxPublishDelay in producer configuration
codelipenghui commented on issue #5788: [pulsar-java-client] Decouple partition switch frequency with maxPublishDelay in producer configuration URL: https://github.com/apache/pulsar/pull/5788#issuecomment-562405172 @sijie I have discussed with yijie, i'm not sure use a custom router is reasonable here. we can support setting frequency in RoundRobinPartitionMessageRouterImpl and user use it like: ``` newProducer().router(new RoundRobinPartitionMessageRouterImpl(int frequency)) ``` Which can reduces `ProducerConfigurationData` complexity since we all ready have routeMode and customRouter there. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5788: [pulsar-java-client] Decouple partition switch frequency with maxPublishDelay in producer configuration
sijie commented on issue #5788: [pulsar-java-client] Decouple partition switch frequency with maxPublishDelay in producer configuration URL: https://github.com/apache/pulsar/pull/5788#issuecomment-562405441 @codelipenghui that works for me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy opened a new pull request #5806: Update RESTFUL API for 2.4.2 release
wolfstudy opened a new pull request #5806: Update RESTFUL API for 2.4.2 release URL: https://github.com/apache/pulsar/pull/5806 Signed-off-by: xiaolong.ran ### Modifications - Update RESTFUL API for 2.4.2 release This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5794: [release][website] Add release notes for Release 2.4.2
codelipenghui commented on issue #5794: [release][website] Add release notes for Release 2.4.2 URL: https://github.com/apache/pulsar/pull/5794#issuecomment-562406381 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5806: Update RESTFUL API for 2.4.2 release
wolfstudy commented on issue #5806: Update RESTFUL API for 2.4.2 release URL: https://github.com/apache/pulsar/pull/5806#issuecomment-562406634 @tuteng @sijie PTAL, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5794: [release][website] Add release notes for Release 2.4.2
wolfstudy commented on issue #5794: [release][website] Add release notes for Release 2.4.2 URL: https://github.com/apache/pulsar/pull/5794#issuecomment-562417994 run cpp tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5806: Update RESTFUL API for 2.4.2 release
tuteng commented on issue #5806: Update RESTFUL API for 2.4.2 release URL: https://github.com/apache/pulsar/pull/5806#issuecomment-562418154 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5794: [release][website] Add release notes for Release 2.4.2
wolfstudy commented on issue #5794: [release][website] Add release notes for Release 2.4.2 URL: https://github.com/apache/pulsar/pull/5794#issuecomment-562422130 run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5801: Update website for 2.4.2 release
wolfstudy commented on issue #5801: Update website for 2.4.2 release URL: https://github.com/apache/pulsar/pull/5801#issuecomment-562426120 Thanks @sijie suggest. Currently, the website of 2.4.2 is generated by the following way: ``` copy version-2.4.1 && fix id of title copy version-2.4.1-sidebars fix release.json && versions.json ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy edited a comment on issue #5801: Update website for 2.4.2 release
wolfstudy edited a comment on issue #5801: Update website for 2.4.2 release URL: https://github.com/apache/pulsar/pull/5801#issuecomment-562426120 Thanks @sijie suggest. Currently, the website of 2.4.2 is generated by the following way: ``` copy version-2.4.1 && fix id of title copy version-2.4.1-sidebars fix release.json && versions.json ``` PTAL again, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] fangpengcheng95 commented on issue #5789: [Issue 5708][docs] correct some wrong info about persistent topics
fangpengcheng95 commented on issue #5789: [Issue 5708][docs] correct some wrong info about persistent topics URL: https://github.com/apache/pulsar/pull/5789#issuecomment-562448896 ping @Anonymitaet, please review this commit at your convenience. thx~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5669: Pulsar Broker restart fail owing to create functions/assignments topic fail
sijie commented on issue #5669: Pulsar Broker restart fail owing to create functions/assignments topic fail URL: https://github.com/apache/pulsar/issues/5669#issuecomment-562455503 I think the NPE was thrown when `ledgers.ceilingKey` return a NULL value. so a proper fix would be change `long ledgerId` to `Long ledgerId` and check if ledgerId is NULL. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] bigbang489 opened a new issue #5807: When CryptoFailureAction is FAIL, after a number of redeliver a message, the message is not move to deadletter topic
bigbang489 opened a new issue #5807: When CryptoFailureAction is FAIL, after a number of redeliver a message, the message is not move to deadletter topic URL: https://github.com/apache/pulsar/issues/5807 **Describe the bug** A clear and concise description of what the bug is. **To Reproduce** Steps to reproduce the behavior: 1. Go to '...' 2. Click on '' 3. Scroll down to '' 4. See error **Expected behavior** A clear and concise description of what you expected to happen. **Screenshots** If applicable, add screenshots to help explain your problem. **Desktop (please complete the following information):** - OS: [e.g. iOS] **Additional context** Add any other context about the problem here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aziwoqpd commented on issue #4599: Errors with empty ledgers
aziwoqpd commented on issue #4599: Errors with empty ledgers URL: https://github.com/apache/pulsar/issues/4599#issuecomment-562464024 I've run into this too anytime a node goes down. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services