Re: [PR] feat: TypeScript integration [tinkerpop]
tien commented on PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1993622235
Have updated the browser example to use TypeScript instead. Didn't touch the
node example as it's right now just a collection of scripts :p
NOTE:
You can see from the browser example that importing type definition is not
the best right now in terms of ergonomic. Addressing this will require changing
the export a little, which I think should be done as a separate PR.
```ts
import type { Edge, Vertex } from "gremlin/build/esm/structure/graph";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] feat: TypeScript integration [tinkerpop]
tien commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522535064
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.ts:
##
@@ -46,43 +44,49 @@ class Graph {
}
class Element {
- constructor(id, label) {
-this.id = id;
-this.label = label;
- }
+ constructor(
+readonly id: string,
+readonly label: string,
+ ) {}
/**
* Compares this instance to another and determines if they can be
considered as equal.
* @param {Element} other
* @returns {boolean}
*/
- equals(other) {
+ equals(other: Element) {
Review Comment:
Yes, this make sense, I've updated accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] feat: TypeScript integration [tinkerpop]
tien commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522534690
##
gremlin-javascript/src/main/javascript/gremlin-javascript/test/cucumber/feature-steps.js:
##
@@ -20,28 +20,28 @@
/**
* @author Jorge Bay Gondra
*/
-'use strict';
-const {Given, Then, When, setDefaultTimeout} = require('cucumber');
+import chaiString from 'chai-string';
+import { Given, Then, When, setDefaultTimeout } from '@cucumber/cucumber';
// Setting Cucumber timeout to 10s for Floating Errors on Windows on GitHub
Actions
setDefaultTimeout(10 * 1000);
-const chai = require('chai')
-chai.use(require('chai-string'));
-const expect = chai.expect;
-const util = require('util');
-const gremlin = require('./gremlin').gremlin;
-const graphModule = require('../../lib/structure/graph');
-const graphTraversalModule = require('../../lib/process/graph-traversal');
-const traversalModule = require('../../lib/process/traversal');
-const utils = require('../../lib/utils');
-const traversal = require('../../lib/process/anonymous-traversal').traversal;
-const Path = graphModule.Path;
-const __ = graphTraversalModule.statics;
-const t = traversalModule.t;
-const P = traversalModule.P;
-const direction = traversalModule.direction;
-const merge = traversalModule.merge;
-const deepMembersById = require('./element-comparison').deepMembersById;
+import { use, expect as _expect } from 'chai';
+use(chaiString);
+const expect = _expect;
+import { inspect, format, inherits } from 'util';
+import { gremlin } from './gremlin.js';
+import { Path as _Path, Vertex, Edge } from '../../lib/structure/graph.js';
Review Comment:
Yep, fixed all the weird auto refactor issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] feat: TypeScript integration [tinkerpop]
vkagamlyk commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522533103
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.ts:
##
@@ -46,43 +44,49 @@ class Graph {
}
class Element {
- constructor(id, label) {
-this.id = id;
-this.label = label;
- }
+ constructor(
+readonly id: string,
+readonly label: string,
+ ) {}
/**
* Compares this instance to another and determines if they can be
considered as equal.
* @param {Element} other
* @returns {boolean}
*/
- equals(other) {
+ equals(other: Element) {
Review Comment:
same for `Path` and `Property`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] feat: TypeScript integration [tinkerpop]
tien commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522528198
##
gremlin-javascript/src/main/javascript/gremlin-javascript/test/cucumber/feature-steps.js:
##
@@ -20,28 +20,28 @@
/**
* @author Jorge Bay Gondra
*/
-'use strict';
-const {Given, Then, When, setDefaultTimeout} = require('cucumber');
+import chaiString from 'chai-string';
+import { Given, Then, When, setDefaultTimeout } from '@cucumber/cucumber';
// Setting Cucumber timeout to 10s for Floating Errors on Windows on GitHub
Actions
setDefaultTimeout(10 * 1000);
-const chai = require('chai')
-chai.use(require('chai-string'));
-const expect = chai.expect;
-const util = require('util');
-const gremlin = require('./gremlin').gremlin;
-const graphModule = require('../../lib/structure/graph');
-const graphTraversalModule = require('../../lib/process/graph-traversal');
-const traversalModule = require('../../lib/process/traversal');
-const utils = require('../../lib/utils');
-const traversal = require('../../lib/process/anonymous-traversal').traversal;
-const Path = graphModule.Path;
-const __ = graphTraversalModule.statics;
-const t = traversalModule.t;
-const P = traversalModule.P;
-const direction = traversalModule.direction;
-const merge = traversalModule.merge;
-const deepMembersById = require('./element-comparison').deepMembersById;
+import { use, expect as _expect } from 'chai';
+use(chaiString);
+const expect = _expect;
+import { inspect, format, inherits } from 'util';
+import { gremlin } from './gremlin.js';
+import { Path as _Path, Vertex, Edge } from '../../lib/structure/graph.js';
Review Comment:
Hmm, I used the refactor functionality of VSCode to change these, look like
it did something funny with default export. Let me do a quick scan n fix all
these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] feat: TypeScript integration [tinkerpop]
vkagamlyk commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522524987
##
gremlin-javascript/src/main/javascript/gremlin-javascript/test/cucumber/feature-steps.js:
##
@@ -20,28 +20,28 @@
/**
* @author Jorge Bay Gondra
*/
-'use strict';
-const {Given, Then, When, setDefaultTimeout} = require('cucumber');
+import chaiString from 'chai-string';
+import { Given, Then, When, setDefaultTimeout } from '@cucumber/cucumber';
// Setting Cucumber timeout to 10s for Floating Errors on Windows on GitHub
Actions
setDefaultTimeout(10 * 1000);
-const chai = require('chai')
-chai.use(require('chai-string'));
-const expect = chai.expect;
-const util = require('util');
-const gremlin = require('./gremlin').gremlin;
-const graphModule = require('../../lib/structure/graph');
-const graphTraversalModule = require('../../lib/process/graph-traversal');
-const traversalModule = require('../../lib/process/traversal');
-const utils = require('../../lib/utils');
-const traversal = require('../../lib/process/anonymous-traversal').traversal;
-const Path = graphModule.Path;
-const __ = graphTraversalModule.statics;
-const t = traversalModule.t;
-const P = traversalModule.P;
-const direction = traversalModule.direction;
-const merge = traversalModule.merge;
-const deepMembersById = require('./element-comparison').deepMembersById;
+import { use, expect as _expect } from 'chai';
+use(chaiString);
+const expect = _expect;
+import { inspect, format, inherits } from 'util';
+import { gremlin } from './gremlin.js';
+import { Path as _Path, Vertex, Edge } from '../../lib/structure/graph.js';
Review Comment:
Why not just
`import { Path, Vertex, Edge } from '../../lib/structure/graph.js';` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] feat: TypeScript integration [tinkerpop]
tien commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522509577
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.ts:
##
@@ -46,43 +44,49 @@ class Graph {
}
class Element {
- constructor(id, label) {
-this.id = id;
-this.label = label;
- }
+ constructor(
+readonly id: string,
+readonly label: string,
+ ) {}
/**
* Compares this instance to another and determines if they can be
considered as equal.
* @param {Element} other
* @returns {boolean}
*/
- equals(other) {
+ equals(other: Element) {
Review Comment:
Thanks, I've updated the type here to `any`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] feat: TypeScript integration [tinkerpop]
tien commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522509374
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/process/traversal.ts:
##
@@ -476,49 +481,43 @@ function toEnum(typeName, keys) {
const directionAlias = {
from_: 'out',
to: 'in',
-};
+} as const;
// for direction enums, maps the same EnumValue object to the enum aliases
after creating them
-function toDirectionEnum(typeName, keys) {
+function toDirectionEnum(typeName: string, keys: string) {
const result = toEnum(typeName, keys);
Object.keys(directionAlias).forEach((k) => {
-result[k] = result[directionAlias[k]];
+result[k] = result[directionAlias[k as keyof typeof directionAlias]];
});
return result;
}
-class EnumValue {
- constructor(typeName, elementName) {
-this.typeName = typeName;
-this.elementName = elementName;
- }
+export class EnumValue {
+ constructor(
+public typeName: string,
+public elementName: string,
+ ) {}
toString() {
return this.elementName;
}
}
-module.exports = {
- EnumValue,
- P,
- TextP,
- withOptions,
- IO,
- Traversal,
- TraversalSideEffects,
- Traverser,
- barrier: toEnum('Barrier', 'normSack'),
- cardinality: toEnum('Cardinality', 'list set single'),
- column: toEnum('Column', 'keys values'),
- direction: toDirectionEnum('Direction', 'BOTH IN OUT from_ to'),
- dt: toEnum('DT', 'second minute hour day'),
- graphSONVersion: toEnum('GraphSONVersion', 'V1_0 V2_0 V3_0'),
- gryoVersion: toEnum('GryoVersion', 'V1_0 V3_0'),
- merge: toEnum('Merge', 'onCreate onMatch outV inV'),
- operator: toEnum('Operator', 'addAll and assign div max min minus mult or
sum sumLong'),
- order: toEnum('Order', 'asc desc shuffle'),
- pick: toEnum('Pick', 'any none'),
- pop: toEnum('Pop', 'all first last mixed'),
- scope: toEnum('Scope', 'global local'),
- t: toEnum('T', 'id key label value'),
-};
+// export const barrier = toEnum('Barrier', 'normSack');
Review Comment:
Oops, have removed these
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] feat: TypeScript integration [tinkerpop]
vkagamlyk commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522501485
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.ts:
##
@@ -46,43 +44,49 @@ class Graph {
}
class Element {
- constructor(id, label) {
-this.id = id;
-this.label = label;
- }
+ constructor(
+readonly id: string,
+readonly label: string,
+ ) {}
/**
* Compares this instance to another and determines if they can be
considered as equal.
* @param {Element} other
* @returns {boolean}
*/
- equals(other) {
+ equals(other: Element) {
Review Comment:
other can by `any`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] feat: TypeScript integration [tinkerpop]
vkagamlyk commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522500544
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/process/traversal.ts:
##
@@ -476,49 +481,43 @@ function toEnum(typeName, keys) {
const directionAlias = {
from_: 'out',
to: 'in',
-};
+} as const;
// for direction enums, maps the same EnumValue object to the enum aliases
after creating them
-function toDirectionEnum(typeName, keys) {
+function toDirectionEnum(typeName: string, keys: string) {
const result = toEnum(typeName, keys);
Object.keys(directionAlias).forEach((k) => {
-result[k] = result[directionAlias[k]];
+result[k] = result[directionAlias[k as keyof typeof directionAlias]];
});
return result;
}
-class EnumValue {
- constructor(typeName, elementName) {
-this.typeName = typeName;
-this.elementName = elementName;
- }
+export class EnumValue {
+ constructor(
+public typeName: string,
+public elementName: string,
+ ) {}
toString() {
return this.elementName;
}
}
-module.exports = {
- EnumValue,
- P,
- TextP,
- withOptions,
- IO,
- Traversal,
- TraversalSideEffects,
- Traverser,
- barrier: toEnum('Barrier', 'normSack'),
- cardinality: toEnum('Cardinality', 'list set single'),
- column: toEnum('Column', 'keys values'),
- direction: toDirectionEnum('Direction', 'BOTH IN OUT from_ to'),
- dt: toEnum('DT', 'second minute hour day'),
- graphSONVersion: toEnum('GraphSONVersion', 'V1_0 V2_0 V3_0'),
- gryoVersion: toEnum('GryoVersion', 'V1_0 V3_0'),
- merge: toEnum('Merge', 'onCreate onMatch outV inV'),
- operator: toEnum('Operator', 'addAll and assign div max min minus mult or
sum sumLong'),
- order: toEnum('Order', 'asc desc shuffle'),
- pick: toEnum('Pick', 'any none'),
- pop: toEnum('Pop', 'all first last mixed'),
- scope: toEnum('Scope', 'global local'),
- t: toEnum('T', 'id key label value'),
-};
+// export const barrier = toEnum('Barrier', 'normSack');
Review Comment:
nit: looks like duplicated code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] feat: TypeScript integration [tinkerpop]
tien commented on PR #2515: URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1993445516 Added a small entry to the `changelog` file, please let me know if further info or modification is needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: TypeScript integration [tinkerpop]
tien commented on PR #2515: URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1992675130 @vkagamlyk I've removed all the unnecessary changes to the test files. Also reset them all to what is on `master` first so there are no conflicts from `3.7`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: TypeScript integration [tinkerpop]
tien commented on PR #2515: URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1992506652 > documentation update for [users](https://tinkerpop.apache.org/docs/current/reference/#gremlin-javascript), [developers environment](https://tinkerpop.apache.org/docs/current/dev/developer/#nodejs-environment) and [release process](https://tinkerpop.apache.org/docs/current/dev/developer/#_release_process). Maybe I missed somewhere else. Maybe this part is not needed, since I've just make this change completely backward compatible: - User documentation: still should update the user usage documentation to use newer ES module import syntax though, but maybe in a separate PR to reduce the number of changes - Developer environment: this should stay the exact same - Release process: I think this should also be the exact same also, because the build step should be automatically executed every time you run `npm publish`. You can test this right now by doing `npm publish --dry-run` to see what will get published. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: TypeScript integration [tinkerpop]
tien commented on PR #2515: URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1992495561 > P.S. Please do not change the formatting because it makes code review very difficult. It's usually better to make separate PR for formatting/fix styles. Yeah, this is because my editor format code on save by default if the project has a prettier config. Will spend a bit of time later today to undo all the formatting changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: TypeScript integration [tinkerpop]
tien commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522052097
##
gremlin-javascript/src/main/javascript/gremlin-javascript/test/integration/sasl-authentication-tests.js:
##
@@ -69,38 +68,43 @@ describe('DriverRemoteConnection', function () {
it('should return error when using ws:// for a TLS configured server',
function () {
const authenticator = new PlainTextSaslAuthenticator('stephen',
'password');
-connection = helper.getDriverRemoteConnection(badServerAuthUrl, {
+connection = getDriverRemoteConnection(badServerAuthUrl, {
authenticator: authenticator,
- rejectUnauthorized: false
+ rejectUnauthorized: false,
});
-return connection.submit(new Bytecode().addStep('V',
[]).addStep('tail', []))
-.then(function() {
- assert.fail("server is running TLS and trying to connect with
ws:// so this should result in error thrown");
-})
-.catch(function (err) {
- if (err instanceof AssertionError) throw err;
- assert.ok(err);
- assert.ok(err.message === 'socket hang up');
-});
+return connection
+ .submit(new Bytecode().addStep('V', []).addStep('tail', []))
+ .then(function () {
+assert.fail('server is running TLS and trying to connect with
ws:// so this should result in error thrown');
+ })
+ .catch(function (err) {
+if (err instanceof AssertionError) throw err;
+assert.ok(err);
+assert.ok(err.message === 'socket hang up');
+ });
});
it('should return error when using ws:// for a TLS configured server',
function () {
const authenticator = new PlainTextSaslAuthenticator('stephen',
'password');
-connection = helper.getDriverRemoteConnection(badServerAuthUrl, {
+connection = getDriverRemoteConnection(badServerAuthUrl, {
authenticator: authenticator,
- rejectUnauthorized: false
+ rejectUnauthorized: false,
});
-const g = traversal().with_(connection);
-return g.V().toList().then(function() {
- assert.fail("server is running TLS and trying to connect with ws://
so this should result in error thrown");
-}).catch(function(err) {
-if (err instanceof AssertionError) throw err;
- assert.ok(err);
- assert.ok(err.message === 'socket hang up');
+const g = traversal().withRemote(connection);
Review Comment:
Oops, must have been brought over since I originally did this on the 3.7
branch. Have replaced all `withRemote` with `with_`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] feat: TypeScript integration [tinkerpop]
vkagamlyk commented on PR #2515: URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1992488713 Missing parts: - documentation update for [users](https://tinkerpop.apache.org/docs/current/reference/#gremlin-javascript), [developers environment](https://tinkerpop.apache.org/docs/current/dev/developer/#nodejs-environment) and [release process](https://tinkerpop.apache.org/docs/current/dev/developer/#_release_process). Maybe I missed somewhere else. - update nodejs examples if needed. - update `changelog` file. Also good to double check if packaging works with new changes. P.S. Please do not change the formatting because it makes code review very difficult. It's usually better to make separate PR for formatting/fix styles. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: TypeScript integration [tinkerpop]
vkagamlyk commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522028418
##
gremlin-javascript/src/main/javascript/gremlin-javascript/test/integration/sasl-authentication-tests.js:
##
@@ -69,38 +68,43 @@ describe('DriverRemoteConnection', function () {
it('should return error when using ws:// for a TLS configured server',
function () {
const authenticator = new PlainTextSaslAuthenticator('stephen',
'password');
-connection = helper.getDriverRemoteConnection(badServerAuthUrl, {
+connection = getDriverRemoteConnection(badServerAuthUrl, {
authenticator: authenticator,
- rejectUnauthorized: false
+ rejectUnauthorized: false,
});
-return connection.submit(new Bytecode().addStep('V',
[]).addStep('tail', []))
-.then(function() {
- assert.fail("server is running TLS and trying to connect with
ws:// so this should result in error thrown");
-})
-.catch(function (err) {
- if (err instanceof AssertionError) throw err;
- assert.ok(err);
- assert.ok(err.message === 'socket hang up');
-});
+return connection
+ .submit(new Bytecode().addStep('V', []).addStep('tail', []))
+ .then(function () {
+assert.fail('server is running TLS and trying to connect with
ws:// so this should result in error thrown');
+ })
+ .catch(function (err) {
+if (err instanceof AssertionError) throw err;
+assert.ok(err);
+assert.ok(err.message === 'socket hang up');
+ });
});
it('should return error when using ws:// for a TLS configured server',
function () {
const authenticator = new PlainTextSaslAuthenticator('stephen',
'password');
-connection = helper.getDriverRemoteConnection(badServerAuthUrl, {
+connection = getDriverRemoteConnection(badServerAuthUrl, {
authenticator: authenticator,
- rejectUnauthorized: false
+ rejectUnauthorized: false,
});
-const g = traversal().with_(connection);
-return g.V().toList().then(function() {
- assert.fail("server is running TLS and trying to connect with ws://
so this should result in error thrown");
-}).catch(function(err) {
-if (err instanceof AssertionError) throw err;
- assert.ok(err);
- assert.ok(err.message === 'socket hang up');
+const g = traversal().withRemote(connection);
Review Comment:
`withRemote` will be depricated in 4.0, `with_(` should be used.
the same thing a few more times
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] feat: TypeScript integration [tinkerpop]
tien commented on PR #2515: URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1992375619 > I think this is a good first step to implement the type system. Thank you for contribution @tien! > > Did I understand correctly that users will be able to use it without having to change the code? Is there any breaking changes? For most user, this will work just fine: ```ts ``` But for those that still use CommonJS instead of the standard ES Module. Then the import will be a bit weird: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: TypeScript integration [tinkerpop]
vkagamlyk commented on PR #2515: URL: https://github.com/apache/tinkerpop/pull/2515#issuecomment-1992334497 I think this is a good first step to implement the type system. Thank you for contribution @tien! Did I understand correctly that users will be able to use it without having to change the code? Is there any breaking changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch dependabot/maven/3.6-dev/com.google.errorprone-error_prone_annotations-2.25.0 deleted (was fab11ec926)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/3.6-dev/com.google.errorprone-error_prone_annotations-2.25.0 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was fab11ec926 Bump com.google.errorprone:error_prone_annotations from 2.4.0 to 2.25.0 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(tinkerpop) branch dependabot/maven/3.6-dev/com.google.errorprone-error_prone_annotations-2.26.0 created (now c4234e260a)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/3.6-dev/com.google.errorprone-error_prone_annotations-2.26.0 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at c4234e260a Bump com.google.errorprone:error_prone_annotations from 2.4.0 to 2.26.0 No new revisions were added by this update.
Re: [PR] Bump com.google.errorprone:error_prone_annotations from 2.4.0 to 2.25.0 [tinkerpop]
dependabot[bot] closed pull request #2501: Bump com.google.errorprone:error_prone_annotations from 2.4.0 to 2.25.0 URL: https://github.com/apache/tinkerpop/pull/2501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.google.errorprone:error_prone_annotations from 2.4.0 to 2.25.0 [tinkerpop]
dependabot[bot] commented on PR #2501: URL: https://github.com/apache/tinkerpop/pull/2501#issuecomment-1991878169 Superseded by #2519. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump com.google.errorprone:error_prone_annotations from 2.4.0 to 2.26.0 [tinkerpop]
dependabot[bot] opened a new pull request, #2519: URL: https://github.com/apache/tinkerpop/pull/2519 Bumps [com.google.errorprone:error_prone_annotations](https://github.com/google/error-prone) from 2.4.0 to 2.26.0. Release notes Sourced from https://github.com/google/error-prone/releases";>com.google.errorprone:error_prone_annotations's releases. Error Prone 2.26.0 Changes: The 'annotations' artifact now includes a module-info.java for Java Platform Module System support, thanks to https://github.com/sgammon";>@sgammon in https://redirect.github.com/google/error-prone/issues/4311";>#4311. Disabled checks passed to -XepPatchChecks are now ignored, instead of causing a crash. Thanks to https://github.com/oxkitsune";>@oxkitsune in https://redirect.github.com/google/error-prone/issues/4028";>#4028. New checks: https://errorprone.info/bugpattern/SystemConsoleNull";>SystemConsoleNull: Null-checking System.console() is not a reliable way to detect if the console is connected to a terminal. https://errorprone.info/bugpattern/EnumOrdinal";>EnumOrdinal: Discourage uses of Enum.ordinal() Closed issues: https://redirect.github.com/google/error-prone/issues/2649";>#2649, https://redirect.github.com/google/error-prone/issues/3908";>#3908, https://redirect.github.com/google/error-prone/issues/4028";>#4028, https://redirect.github.com/google/error-prone/issues/4311";>#4311, https://redirect.github.com/google/error-prone/issues/4314";>#4314 Full Changelog: https://github.com/google/error-prone/compare/v2.25.0...v2.26.0";>https://github.com/google/error-prone/compare/v2.25.0...v2.26.0 Error Prone 2.25.0 New checks: https://errorprone.info/bugpattern/JUnitIncompatibleType";>JUnitIncompatibleType: Detects incompatible types passed to an assertion, similar to https://errorprone.info/bugpattern/TruthIncompatibleType";>TruthIncompatibleType https://errorprone.info/bugpattern/RedundantSetterCall";>RedundantSetterCall: Detects fields set twice in the same chained expression. Generalization of previous ProtoRedundantSet check to also handle https://github.com/google/auto/blob/main/value/userguide/index.md";>AutoValue. Closed issues: https://redirect.github.com/google/error-prone/issues/4195";>#4195, https://redirect.github.com/google/error-prone/issues/4224";>#4224, https://redirect.github.com/google/error-prone/issues/4228";>#4228, https://redirect.github.com/google/error-prone/issues/4248";>#4248, https://redirect.github.com/google/error-prone/issues/4249";>#4249, https://redirect.github.com/google/error-prone/issues/4251";>#4251 Full Changelog: https://github.com/google/error-prone/compare/v2.24.1...v2.25.0";>https://github.com/google/error-prone/compare/v2.24.1...v2.25.0 Error Prone 2.24.1 Changes: Add an assertion to try to help debug https://redirect.github.com/google/error-prone/issues/4225";>google/error-prone#4225 Full Changelog: https://github.com/google/error-prone/compare/v2.24.0...v2.24.1";>https://github.com/google/error-prone/compare/v2.24.0...v2.24.1 Error Prone 2.24.0 New checks: https://errorprone.info/bugpattern/MultipleNullnessAnnotations";>MultipleNullnessAnnotations: Discourage multiple nullness annotations https://errorprone.info/bugpattern/NullableTypeParameter";>NullableTypeParameter: Discourage nullness annotations on type parameters https://errorprone.info/bugpattern/NullableWildcard";>NullableWildcard: Discourage nullness annotations on wildcards https://errorprone.info/bugpattern/SuperCallToObjectMethod";>SuperCallToObjectMethod: Generalization of SuperEqualsIsObjectEquals, now covers hashCode Full Changelog: https://github.com/google/error-prone/compare/v2.23.0...v2.24.0";>https://github.com/google/error-prone/compare/v2.23.0...v2.24.0 Error Prone 2.23.0 New checks: https://errorprone.info/bugpattern/DuplicateDateFormatField";>DuplicateDateFormatField https://errorprone.info/bugpattern/NonFinalStaticField";>NonFinalStaticField https://errorprone.info/bugpattern/StringCharset";>StringCharset https://errorprone.info/bugpattern/StringFormatWithLiteral";>StringFormatWithLiteral https://errorprone.info/bugpattern/SuperEqualsIsObjectEquals";>SuperEqualsIsObjectEquals ... (truncated) Commits https://github.com/google/error-prone/commit/ad1c05b789e28eea2dffdc02be6d89e5c8f8df8b";>ad1c05b Release Error Prone 2.26.0 https://github.com/google/error-prone/commit/ea5ef6dd29022683eced044a2b0b3fa91d8b3200";>ea5ef6d Add the 'compile' goal for 'compile-java9' https://github.com/google/error-prone/commit/0e9536471b6b8e7e03d29584eceb8a0e0f3240d7";>0e95364 feat: add jpms definition for annotations https://github.com/google/error-prone/commit/9da2d5580e3939f97ef2e91278b330a56b5ed1fe";>9da2d55 Ignore disabled checks passed to -XepPatchChecks https://github.com/google/error-prone/commit/3292632ee5
(tinkerpop) branch dependabot/nuget/gremlin-dotnet/3.6-dev/System.Text.Json-8.0.3 created (now f5d8225ca8)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/nuget/gremlin-dotnet/3.6-dev/System.Text.Json-8.0.3 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at f5d8225ca8 Bump System.Text.Json from 8.0.2 to 8.0.3 in /gremlin-dotnet No new revisions were added by this update.
[PR] Bump System.Text.Json from 8.0.2 to 8.0.3 in /gremlin-dotnet [tinkerpop]
dependabot[bot] opened a new pull request, #2518: URL: https://github.com/apache/tinkerpop/pull/2518 Bumps [System.Text.Json](https://github.com/dotnet/runtime) from 8.0.2 to 8.0.3. Commits See full diff in https://github.com/dotnet/runtime/commits";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch dependabot/nuget/gremlin-dotnet/3.6-dev/Microsoft.Extensions.Logging.Abstractions-8.0.1 created (now 588e362838)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/nuget/gremlin-dotnet/3.6-dev/Microsoft.Extensions.Logging.Abstractions-8.0.1 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at 588e362838 Bump Microsoft.Extensions.Logging.Abstractions in /gremlin-dotnet No new revisions were added by this update.
[PR] Bump Microsoft.Extensions.Logging.Abstractions from 7.0.1 to 8.0.1 in /gremlin-dotnet [tinkerpop]
dependabot[bot] opened a new pull request, #2517: URL: https://github.com/apache/tinkerpop/pull/2517 Bumps [Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime) from 7.0.1 to 8.0.1. Release notes Sourced from https://github.com/dotnet/runtime/releases";>Microsoft.Extensions.Logging.Abstractions's releases. .NET 8.0.1 https://github.com/dotnet/core/releases/tag/v8.0.1";>Release .NET 8.0.0 https://github.com/dotnet/core/releases/tag/v8.0.0";>Release What's Changed [release/8.0-rc1] [release/8.0] Events for IL methods without IL headers by https://github.com/github-actions";>@github-actions in https://redirect.github.com/dotnet/runtime/pull/92317";>dotnet/runtime#92317 [release/8.0] Update dependencies from dotnet/source-build-externals by https://github.com/dotnet-maestro";>@dotnet-maestro in https://redirect.github.com/dotnet/runtime/pull/92340";>dotnet/runtime#92340 [release/8.0-rc1] [release/8.0] Fix wasi build. by https://github.com/github-actions";>@github-actions in https://redirect.github.com/dotnet/runtime/pull/92368";>dotnet/runtime#92368 [automated] Merge branch 'release/8.0-rc2' => 'release/8.0' by https://github.com/dotnet-maestro-bot";>@dotnet-maestro-bot in https://redirect.github.com/dotnet/runtime/pull/92325";>dotnet/runtime#92325 [release/8.0] Update dependencies from dotnet/roslyn by https://github.com/dotnet-maestro";>@dotnet-maestro in https://redirect.github.com/dotnet/runtime/pull/92303";>dotnet/runtime#92303 [automated] Merge branch 'release/8.0-rc1' => 'release/8.0' by https://github.com/dotnet-maestro-bot";>@dotnet-maestro-bot in https://redirect.github.com/dotnet/runtime/pull/92374";>dotnet/runtime#92374 [release/8.0] Bump version to GA by https://github.com/carlossanlop";>@carlossanlop in https://redirect.github.com/dotnet/runtime/pull/92305";>dotnet/runtime#92305 [release/8.0] Update dependencies from dotnet/source-build-externals by https://github.com/dotnet-maestro";>@dotnet-maestro in https://redirect.github.com/dotnet/runtime/pull/92476";>dotnet/runtime#92476 [automated] Merge branch 'release/8.0-rc2' => 'release/8.0' by https://github.com/dotnet-maestro-bot";>@dotnet-maestro-bot in https://redirect.github.com/dotnet/runtime/pull/92401";>dotnet/runtime#92401 [release/8.0] Update dependencies from dotnet/roslyn by https://github.com/dotnet-maestro";>@dotnet-maestro in https://redirect.github.com/dotnet/runtime/pull/92418";>dotnet/runtime#92418 [release/8.0] Update dependencies from dotnet/source-build-reference-packages by https://github.com/dotnet-maestro";>@dotnet-maestro in https://redirect.github.com/dotnet/runtime/pull/92474";>dotnet/runtime#92474 [release/8.0] Update dependencies from dnceng/internal/dotnet-optimization by https://github.com/dotnet-maestro";>@dotnet-maestro in https://redirect.github.com/dotnet/runtime/pull/92473";>dotnet/runtime#92473 [release/8.0] Update dependencies from dotnet/roslyn by https://github.com/dotnet-maestro";>@dotnet-maestro in https://redirect.github.com/dotnet/runtime/pull/92488";>dotnet/runtime#92488 [automated] Merge branch 'release/8.0-rc2' => 'release/8.0' by https://github.com/dotnet-maestro-bot";>@dotnet-maestro-bot in https://redirect.github.com/dotnet/runtime/pull/92484";>dotnet/runtime#92484 [release/8.0] Update dependencies from dotnet/roslyn-analyzers by https://github.com/dotnet-maestro";>@dotnet-maestro in https://redirect.github.com/dotnet/runtime/pull/92499";>dotnet/runtime#92499 [release/8.0] Update dependencies from dotnet/emsdk by https://github.com/dotnet-maestro";>@dotnet-maestro in https://redirect.github.com/dotnet/runtime/pull/92532";>dotnet/runtime#92532 [automated] Merge branch 'release/8.0-rc2' => 'release/8.0' by https://github.com/dotnet-maestro-bot";>@dotnet-maestro-bot in https://redirect.github.com/dotnet/runtime/pull/92515";>dotnet/runtime#92515 [release/8.0] Update dependencies from dotnet/source-build-externals by https://github.com/dotnet-maestro";>@dotnet-maestro in https://redirect.github.com/dotnet/runtime/pull/92641";>dotnet/runtime#92641 [release/8.0] Update dependencies from dotnet/emsdk dotnet/hotreload-utils by https://github.com/dotnet-maestro";>@dotnet-maestro in https://redirect.github.com/dotnet/runtime/pull/92606";>dotnet/runtime#92606 [release/8.0][wasm] Fix regressed file sizes for blazor by https://github.com/radical";>@radical in https://redirect.github.com/dotnet/runtime/pull/92627";>dotnet/runtime#92627 [release/8.0] JIT: Fixed containment of STOREIND of HW intrinsics ConvertTo*/Extract* by https://github.com/github-actions";>@github-actions in https://redirect.github.com/dotnet/runtime/pull/92513";>dotnet/runtime#92513 [release/8.0] Define bool as Interop.BOOL to prevent upper bytes setting native bool by https://github.com/github-actions";>@github-actions in https://redirect.github.com/dotnet/runtime/
(tinkerpop) branch dependabot/nuget/gremlin-dotnet/3.6-dev/Polly-8.3.1 deleted (was aa90f77595)
This is an automated email from the ASF dual-hosted git repository. florianhockmann pushed a change to branch dependabot/nuget/gremlin-dotnet/3.6-dev/Polly-8.3.1 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was aa90f77595 Bump Polly from 8.3.0 to 8.3.1 in /gremlin-dotnet The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(tinkerpop) branch master updated (6bd2c92f63 -> cc43fbf57a)
This is an automated email from the ASF dual-hosted git repository. florianhockmann pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 6bd2c92f63 CTR add missing require to gremlin-js SetSerializer add aa90f77595 Bump Polly from 8.3.0 to 8.3.1 in /gremlin-dotnet add 936dd8137a Merge branch '3.6-dev' into 3.7-dev new cc43fbf57a Merge branch '3.7-dev' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
(tinkerpop) branch 3.6-dev updated (2d950116db -> aa90f77595)
This is an automated email from the ASF dual-hosted git repository. florianhockmann pushed a change to branch 3.6-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 2d950116db Avoiding expensive hash computation for complex steps with many children in filter ranking strategy (#2504) add aa90f77595 Bump Polly from 8.3.0 to 8.3.1 in /gremlin-dotnet No new revisions were added by this update. Summary of changes: gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
(tinkerpop) branch 3.7-dev updated (4e99e77f6a -> 936dd8137a)
This is an automated email from the ASF dual-hosted git repository. florianhockmann pushed a change to branch 3.7-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 4e99e77f6a feat: `gremlin.js` browser support (#2506) add aa90f77595 Bump Polly from 8.3.0 to 8.3.1 in /gremlin-dotnet add 936dd8137a Merge branch '3.6-dev' into 3.7-dev No new revisions were added by this update. Summary of changes: gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
(tinkerpop) 01/01: Merge branch '3.7-dev'
This is an automated email from the ASF dual-hosted git repository. florianhockmann pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit cc43fbf57af6f95213e52cb58e911dd8cb857ab4 Merge: 6bd2c92f63 936dd8137a Author: Florian Hockmann AuthorDate: Tue Mar 12 10:33:35 2024 +0100 Merge branch '3.7-dev' gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Re: [PR] Bump Polly from 8.3.0 to 8.3.1 in /gremlin-dotnet [tinkerpop]
FlorianHockmann merged PR #2513: URL: https://github.com/apache/tinkerpop/pull/2513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
