[jira] [Commented] (WICKET-5827) Allow to apply multiple Javascript / CSS compressors
[ https://issues.apache.org/jira/browse/WICKET-5827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321396#comment-14321396 ] Tobias Soloschenko commented on WICKET-5827: The pull request has not been closed automatically - I'm closing it now. Allow to apply multiple Javascript / CSS compressors Key: WICKET-5827 URL: https://issues.apache.org/jira/browse/WICKET-5827 Project: Wicket Issue Type: New Feature Components: wicket Affects Versions: 6.20.0, 7.0.0-M6 Reporter: Tobias Soloschenko Assignee: Martin Grigorov Priority: Minor Labels: features Fix For: 6.20.0, 7.0.0-M6 It would be nice to be able to add several css and javascript compressions in a chain. Example for CSS: CssRemoveCommentsCompressor CssUrlReplacementCompressor CssMinifyCompressor The same would be nice for JavaScript files. https://github.com/apache/wicket/pull/88 https://github.com/apache/wicket/pull/87 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5827) Allow to apply multiple Javascript / CSS compressors
[ https://issues.apache.org/jira/browse/WICKET-5827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321398#comment-14321398 ] ASF GitHub Bot commented on WICKET-5827: Github user klopfdreh commented on the pull request: https://github.com/apache/wicket/pull/88#issuecomment-74373886 This PR has been integrated. Thanks a lot @martin-g For more information see: https://issues.apache.org/jira/browse/WICKET-5827?focusedCommentId=14320747page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14320747 Allow to apply multiple Javascript / CSS compressors Key: WICKET-5827 URL: https://issues.apache.org/jira/browse/WICKET-5827 Project: Wicket Issue Type: New Feature Components: wicket Affects Versions: 6.20.0, 7.0.0-M6 Reporter: Tobias Soloschenko Assignee: Martin Grigorov Priority: Minor Labels: features Fix For: 6.20.0, 7.0.0-M6 It would be nice to be able to add several css and javascript compressions in a chain. Example for CSS: CssRemoveCommentsCompressor CssUrlReplacementCompressor CssMinifyCompressor The same would be nice for JavaScript files. https://github.com/apache/wicket/pull/88 https://github.com/apache/wicket/pull/87 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5827) Allow to apply multiple Javascript / CSS compressors
[ https://issues.apache.org/jira/browse/WICKET-5827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321399#comment-14321399 ] ASF GitHub Bot commented on WICKET-5827: Github user klopfdreh closed the pull request at: https://github.com/apache/wicket/pull/88 Allow to apply multiple Javascript / CSS compressors Key: WICKET-5827 URL: https://issues.apache.org/jira/browse/WICKET-5827 Project: Wicket Issue Type: New Feature Components: wicket Affects Versions: 6.20.0, 7.0.0-M6 Reporter: Tobias Soloschenko Assignee: Martin Grigorov Priority: Minor Labels: features Fix For: 6.20.0, 7.0.0-M6 It would be nice to be able to add several css and javascript compressions in a chain. Example for CSS: CssRemoveCommentsCompressor CssUrlReplacementCompressor CssMinifyCompressor The same would be nice for JavaScript files. https://github.com/apache/wicket/pull/88 https://github.com/apache/wicket/pull/87 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5837) JUnit tests may fail because of AbstractDefaultAjaxBehavior
[ https://issues.apache.org/jira/browse/WICKET-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321488#comment-14321488 ] ASF GitHub Bot commented on WICKET-5837: Github user klopfdreh commented on the pull request: https://github.com/apache/wicket/pull/90#issuecomment-74378512 Linked ticket: https://issues.apache.org/jira/browse/WICKET-5837 JUnit tests may fail because of AbstractDefaultAjaxBehavior --- Key: WICKET-5837 URL: https://issues.apache.org/jira/browse/WICKET-5837 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 7.0.0-M5, 6.19.0 Reporter: Tobias Soloschenko Assignee: Andrea Del Bene Labels: test Because JSONObject is used in the method org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.renderAjaxAttributes(Component, AjaxRequestAttributes) which internally uses a HashMap to store the key value pairs - see org.apache.wicket.ajax.json.JSONObject.JSONObject() - it is not ensured the attributes rendered in a specific order. This can cause the unit tests to pass in one run and fail in the next run. One suggestion would be to switch the HashMap and replace it with at LinkedHashMap to preserve the insertion order. See stack trace in comment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5837) JUnit tests may fail because of AbstractDefaultAjaxBehavior
[ https://issues.apache.org/jira/browse/WICKET-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321493#comment-14321493 ] Tobias Soloschenko commented on WICKET-5837: For Wicket 7.0.0-M5 the work was already done. The JSONObject in there already uses a LinkedHashMap. The changes are also made for Wicket 6.19.0, now. I also fixed the JUnit test for MultiFileUploadFieldTest in the Wicket 6.19.0 commit. JUnit tests may fail because of AbstractDefaultAjaxBehavior --- Key: WICKET-5837 URL: https://issues.apache.org/jira/browse/WICKET-5837 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 7.0.0-M5, 6.19.0 Reporter: Tobias Soloschenko Assignee: Andrea Del Bene Labels: test Because JSONObject is used in the method org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.renderAjaxAttributes(Component, AjaxRequestAttributes) which internally uses a HashMap to store the key value pairs - see org.apache.wicket.ajax.json.JSONObject.JSONObject() - it is not ensured the attributes rendered in a specific order. This can cause the unit tests to pass in one run and fail in the next run. One suggestion would be to switch the HashMap and replace it with at LinkedHashMap to preserve the insertion order. See stack trace in comment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5837) JUnit tests may fail because of AbstractDefaultAjaxBehavior
[ https://issues.apache.org/jira/browse/WICKET-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321495#comment-14321495 ] ASF GitHub Bot commented on WICKET-5837: Github user klopfdreh commented on the pull request: https://github.com/apache/wicket/pull/91#issuecomment-74378760 Linked ticket: https://issues.apache.org/jira/browse/WICKET-5837 JUnit tests may fail because of AbstractDefaultAjaxBehavior --- Key: WICKET-5837 URL: https://issues.apache.org/jira/browse/WICKET-5837 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 7.0.0-M5, 6.19.0 Reporter: Tobias Soloschenko Assignee: Andrea Del Bene Labels: test Because JSONObject is used in the method org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.renderAjaxAttributes(Component, AjaxRequestAttributes) which internally uses a HashMap to store the key value pairs - see org.apache.wicket.ajax.json.JSONObject.JSONObject() - it is not ensured the attributes rendered in a specific order. This can cause the unit tests to pass in one run and fail in the next run. One suggestion would be to switch the HashMap and replace it with at LinkedHashMap to preserve the insertion order. See stack trace in comment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (WICKET-5837) JUnit tests may fail because of AbstractDefaultAjaxBehavior
[ https://issues.apache.org/jira/browse/WICKET-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321493#comment-14321493 ] Tobias Soloschenko edited comment on WICKET-5837 at 2/14/15 3:15 PM: - For Wicket 7.0.0-M5 the work was already done. The JSONObject in there already uses a LinkedHashMap. The changes are also made for Wicket 6.19.0, now. I also fixed the JUnit test for MultiFileUploadFieldTest in the Wicket 6.19.0 commit. Edit: Forgot to say that I applied a little change to 7.0.0-M5 so that an JSONObject created based on a Map also uses a LinkedHashMap. was (Author: klopfdreh): For Wicket 7.0.0-M5 the work was already done. The JSONObject in there already uses a LinkedHashMap. The changes are also made for Wicket 6.19.0, now. I also fixed the JUnit test for MultiFileUploadFieldTest in the Wicket 6.19.0 commit. JUnit tests may fail because of AbstractDefaultAjaxBehavior --- Key: WICKET-5837 URL: https://issues.apache.org/jira/browse/WICKET-5837 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 7.0.0-M5, 6.19.0 Reporter: Tobias Soloschenko Assignee: Andrea Del Bene Labels: test Because JSONObject is used in the method org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.renderAjaxAttributes(Component, AjaxRequestAttributes) which internally uses a HashMap to store the key value pairs - see org.apache.wicket.ajax.json.JSONObject.JSONObject() - it is not ensured the attributes rendered in a specific order. This can cause the unit tests to pass in one run and fail in the next run. One suggestion would be to switch the HashMap and replace it with at LinkedHashMap to preserve the insertion order. See stack trace in comment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5837) JUnit tests may fail because of AbstractDefaultAjaxBehavior
[ https://issues.apache.org/jira/browse/WICKET-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321468#comment-14321468 ] Andrea Del Bene commented on WICKET-5837: - Thank you once again Tobias! JUnit tests may fail because of AbstractDefaultAjaxBehavior --- Key: WICKET-5837 URL: https://issues.apache.org/jira/browse/WICKET-5837 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.20.0, 7.0.0-M6 Reporter: Tobias Soloschenko Assignee: Andrea Del Bene Labels: test Because JSONObject is used in the method org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.renderAjaxAttributes(Component, AjaxRequestAttributes) which internally uses a HashMap to store the key value pairs - see org.apache.wicket.ajax.json.JSONObject.JSONObject() - it is not ensured the attributes rendered in a specific order. This can cause the unit tests to pass in one run and fail in the next run. One suggestion would be to switch the HashMap and replace it with at LinkedHashMap to preserve the insertion order. See stack trace in comment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5837) JUnit tests may fail because of AbstractDefaultAjaxBehavior
[ https://issues.apache.org/jira/browse/WICKET-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321474#comment-14321474 ] ASF GitHub Bot commented on WICKET-5837: GitHub user klopfdreh opened a pull request: https://github.com/apache/wicket/pull/90 WICKET-5837 JUnit tests may fail because of AbstractDefaultAjaxBehavior You can merge this pull request into a Git repository by running: $ git pull https://github.com/klopfdreh/wicket WICKET-5837 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/wicket/pull/90.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #90 commit 53566ad3b189c1f018a527b7a53345f5c0b14679 Author: klopfdreh klopfdreh@192.168.2.110 Date: 2015-02-14T14:57:18Z WICKET-5837 JUnit tests may fail because of AbstractDefaultAjaxBehavior JUnit tests may fail because of AbstractDefaultAjaxBehavior --- Key: WICKET-5837 URL: https://issues.apache.org/jira/browse/WICKET-5837 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 7.0.0-M5, 6.19.0 Reporter: Tobias Soloschenko Assignee: Andrea Del Bene Labels: test Because JSONObject is used in the method org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.renderAjaxAttributes(Component, AjaxRequestAttributes) which internally uses a HashMap to store the key value pairs - see org.apache.wicket.ajax.json.JSONObject.JSONObject() - it is not ensured the attributes rendered in a specific order. This can cause the unit tests to pass in one run and fail in the next run. One suggestion would be to switch the HashMap and replace it with at LinkedHashMap to preserve the insertion order. See stack trace in comment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5837) JUnit tests may fail because of AbstractDefaultAjaxBehavior
[ https://issues.apache.org/jira/browse/WICKET-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321467#comment-14321467 ] Tobias Soloschenko commented on WICKET-5837: Ok, nearly finished. I'm going to open a pull request. JUnit tests may fail because of AbstractDefaultAjaxBehavior --- Key: WICKET-5837 URL: https://issues.apache.org/jira/browse/WICKET-5837 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.20.0, 7.0.0-M6 Reporter: Tobias Soloschenko Assignee: Andrea Del Bene Labels: test Because JSONObject is used in the method org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.renderAjaxAttributes(Component, AjaxRequestAttributes) which internally uses a HashMap to store the key value pairs - see org.apache.wicket.ajax.json.JSONObject.JSONObject() - it is not ensured the attributes rendered in a specific order. This can cause the unit tests to pass in one run and fail in the next run. One suggestion would be to switch the HashMap and replace it with at LinkedHashMap to preserve the insertion order. See stack trace in comment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-5837) JUnit tests may fail because of AbstractDefaultAjaxBehavior
[ https://issues.apache.org/jira/browse/WICKET-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko updated WICKET-5837: --- Description: Because JSONObject is used in the method org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.renderAjaxAttributes(Component, AjaxRequestAttributes) which internally uses a HashMap to store the key value pairs - see org.apache.wicket.ajax.json.JSONObject.JSONObject() - it is not ensured the attributes rendered in a specific order. This can cause the unit tests to pass in one run and fail in the next run. One suggestion would be to switch the HashMap and replace it with at LinkedHashMap to preserve the insertion order. See stack trace in comment. was: Because JSONObject is used in the method org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.renderAjaxAttributes(Component, AjaxRequestAttributes) which internally uses a HashMap to store the key value pairs - see org.apache.wicket.ajax.json.JSONObject.JSONObject() - it is not ensured the attributes rendered in a specific order. This can cause the unit tests to pass in one run and fail in the next run. One suggestion would be to switch the HashMap and replace it with at LinkedHashMap to preserve the insertion order. JUnit tests may fail because of AbstractDefaultAjaxBehavior --- Key: WICKET-5837 URL: https://issues.apache.org/jira/browse/WICKET-5837 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.20.0, 7.0.0-M6 Reporter: Tobias Soloschenko Labels: test Because JSONObject is used in the method org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.renderAjaxAttributes(Component, AjaxRequestAttributes) which internally uses a HashMap to store the key value pairs - see org.apache.wicket.ajax.json.JSONObject.JSONObject() - it is not ensured the attributes rendered in a specific order. This can cause the unit tests to pass in one run and fail in the next run. One suggestion would be to switch the HashMap and replace it with at LinkedHashMap to preserve the insertion order. See stack trace in comment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5837) JUnit tests may fail because of AbstractDefaultAjaxBehavior
[
https://issues.apache.org/jira/browse/WICKET-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321420#comment-14321420
]
Tobias Soloschenko commented on WICKET-5837:
junit.framework.ComparisonFailure:
org/apache/wicket/ajax/AjaxHeaderContributionPage_expected.html expected:...
Wicket.Ajax.ajax({[u:./org.apache.wicket.ajax.AjaxHeaderContributionPage?0-1.IBehaviorListener.0-link,e:click,c:link1]});;
Wicket.Event.p... but was:...
Wicket.Ajax.ajax({[c:link1,u:./org.apache.wicket.ajax.AjaxHeaderContributionPage?0-1.IBehaviorListener.0-link,e:click]});;
Wicket.Event.p...
at junit.framework.Assert.assertEquals(Assert.java:85)
at
org.apache.wicket.util.tester.DiffUtil.validatePage(DiffUtil.java:160)
at
org.apache.wicket.util.tester.WicketTester.assertResultPage(WicketTester.java:590)
at
org.apache.wicket.ajax.AjaxHeaderContributionTest.ajaxHeaderContribution(AjaxHeaderContributionTest.java:34)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:483)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
at
org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:50)
at
org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:459)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:675)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:192)
JUnit tests may fail because of AbstractDefaultAjaxBehavior
---
Key: WICKET-5837
URL: https://issues.apache.org/jira/browse/WICKET-5837
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.20.0, 7.0.0-M6
Reporter: Tobias Soloschenko
Labels: test
Because JSONObject is used in the method
org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.renderAjaxAttributes(Component,
AjaxRequestAttributes)
which internally uses a HashMap to store the key value pairs - see
org.apache.wicket.ajax.json.JSONObject.JSONObject() - it is not ensured the
attributes rendered in a specific order. This can cause the unit tests to
pass in one run and fail in the next run.
One suggestion would be to switch the HashMap and replace it with at
LinkedHashMap to preserve the insertion order.
See stack trace in comment.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (WICKET-5837) JUnit tests may fail because of AbstractDefaultAjaxBehavior
Tobias Soloschenko created WICKET-5837: -- Summary: JUnit tests may fail because of AbstractDefaultAjaxBehavior Key: WICKET-5837 URL: https://issues.apache.org/jira/browse/WICKET-5837 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.20.0, 7.0.0-M6 Reporter: Tobias Soloschenko Because JSONObject is used in the method org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.renderAjaxAttributes(Component, AjaxRequestAttributes) which internally uses a HashMap to store the key value pairs - see org.apache.wicket.ajax.json.JSONObject.JSONObject() - it is not ensured the attributes rendered in a specific order. This can cause the unit tests to pass in one run and fail in the next run. One suggestion would be to switch the HashMap and replace it with at LinkedHashMap to preserve the insertion order. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (WICKET-5837) JUnit tests may fail because of AbstractDefaultAjaxBehavior
[ https://issues.apache.org/jira/browse/WICKET-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene reassigned WICKET-5837: --- Assignee: Andrea Del Bene JUnit tests may fail because of AbstractDefaultAjaxBehavior --- Key: WICKET-5837 URL: https://issues.apache.org/jira/browse/WICKET-5837 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.20.0, 7.0.0-M6 Reporter: Tobias Soloschenko Assignee: Andrea Del Bene Labels: test Because JSONObject is used in the method org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.renderAjaxAttributes(Component, AjaxRequestAttributes) which internally uses a HashMap to store the key value pairs - see org.apache.wicket.ajax.json.JSONObject.JSONObject() - it is not ensured the attributes rendered in a specific order. This can cause the unit tests to pass in one run and fail in the next run. One suggestion would be to switch the HashMap and replace it with at LinkedHashMap to preserve the insertion order. See stack trace in comment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5837) JUnit tests may fail because of AbstractDefaultAjaxBehavior
[ https://issues.apache.org/jira/browse/WICKET-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321451#comment-14321451 ] Tobias Soloschenko commented on WICKET-5837: I'm currently working on it - seems to be a small bit more then only changing the HashMap to LinkedHashMap but I investigate it. JUnit tests may fail because of AbstractDefaultAjaxBehavior --- Key: WICKET-5837 URL: https://issues.apache.org/jira/browse/WICKET-5837 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.20.0, 7.0.0-M6 Reporter: Tobias Soloschenko Assignee: Andrea Del Bene Labels: test Because JSONObject is used in the method org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.renderAjaxAttributes(Component, AjaxRequestAttributes) which internally uses a HashMap to store the key value pairs - see org.apache.wicket.ajax.json.JSONObject.JSONObject() - it is not ensured the attributes rendered in a specific order. This can cause the unit tests to pass in one run and fail in the next run. One suggestion would be to switch the HashMap and replace it with at LinkedHashMap to preserve the insertion order. See stack trace in comment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-5837) JUnit tests may fail because of AbstractDefaultAjaxBehavior
[ https://issues.apache.org/jira/browse/WICKET-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-5837: Affects Version/s: (was: 7.0.0-M6) (was: 6.20.0) 7.0.0-M5 6.19.0 JUnit tests may fail because of AbstractDefaultAjaxBehavior --- Key: WICKET-5837 URL: https://issues.apache.org/jira/browse/WICKET-5837 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 7.0.0-M5, 6.19.0 Reporter: Tobias Soloschenko Assignee: Andrea Del Bene Labels: test Because JSONObject is used in the method org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.renderAjaxAttributes(Component, AjaxRequestAttributes) which internally uses a HashMap to store the key value pairs - see org.apache.wicket.ajax.json.JSONObject.JSONObject() - it is not ensured the attributes rendered in a specific order. This can cause the unit tests to pass in one run and fail in the next run. One suggestion would be to switch the HashMap and replace it with at LinkedHashMap to preserve the insertion order. See stack trace in comment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5837) JUnit tests may fail because of AbstractDefaultAjaxBehavior
[ https://issues.apache.org/jira/browse/WICKET-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321490#comment-14321490 ] ASF GitHub Bot commented on WICKET-5837: GitHub user klopfdreh opened a pull request: https://github.com/apache/wicket/pull/91 WICKET-5837 JUnit tests may fail because of AbstractDefaultAjaxBehavior little adjustment for master You can merge this pull request into a Git repository by running: $ git pull https://github.com/klopfdreh/wicket WICKET-5837-master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/wicket/pull/91.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #91 commit 5445d7c6171d980a8bc1344005a2709ae748aad0 Author: klopfdreh klopfdreh@192.168.2.110 Date: 2015-02-14T15:09:33Z WICKET-5837 JUnit tests may fail because of AbstractDefaultAjaxBehavior JUnit tests may fail because of AbstractDefaultAjaxBehavior --- Key: WICKET-5837 URL: https://issues.apache.org/jira/browse/WICKET-5837 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 7.0.0-M5, 6.19.0 Reporter: Tobias Soloschenko Assignee: Andrea Del Bene Labels: test Because JSONObject is used in the method org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.renderAjaxAttributes(Component, AjaxRequestAttributes) which internally uses a HashMap to store the key value pairs - see org.apache.wicket.ajax.json.JSONObject.JSONObject() - it is not ensured the attributes rendered in a specific order. This can cause the unit tests to pass in one run and fail in the next run. One suggestion would be to switch the HashMap and replace it with at LinkedHashMap to preserve the insertion order. See stack trace in comment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
