[wicket] branch allow_to_overrride_channel_creation updated (6e35fdf -> d938675)
This is an automated email from the ASF dual-hosted git repository. reiern70 pushed a change to branch allow_to_overrride_channel_creation in repository https://gitbox.apache.org/repos/asf/wicket.git. omit 6e35fdf allow to override write channel creation add d938675 [WICKET-6936] allow to over-ride write channel creation This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (6e35fdf) \ N -- N -- N refs/heads/allow_to_overrride_channel_creation (d938675) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../src/main/java/org/apache/wicket/pageStore/FilePageStore.java| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[jira] [Commented] (WICKET-6936) FilePageStore fails on windows
[ https://issues.apache.org/jira/browse/WICKET-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445912#comment-17445912 ] ASF subversion and git services commented on WICKET-6936: - Commit d93867528b7cef01a80ee25da7080297d0335ff5 in wicket's branch refs/heads/allow_to_overrride_channel_creation from reiern70 [ https://gitbox.apache.org/repos/asf?p=wicket.git;h=d938675 ] [WICKET-6936] allow to over-ride write channel creation > FilePageStore fails on windows > --- > > Key: WICKET-6936 > URL: https://issues.apache.org/jira/browse/WICKET-6936 > Project: Wicket > Issue Type: Bug >Affects Versions: 10.0.0, 9.6.0 >Reporter: Ernesto Reinaldo Barreiro >Priority: Major > > Option StandardOpenOption.TRUNCATE_EXISTING makes file page store fail on > windows (in certain situations). > See > FYI: > https://wicket.markmail.org/search/?q=wicket#query:wicket%20list%3Aorg.apache.wicket.users%20order%3Adate-backward+page:1+mid:c4xoraz77wn5qnpj+state:results -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (WICKET-6936) FilePageStore fails on windows
[ https://issues.apache.org/jira/browse/WICKET-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ernesto Reinaldo Barreiro updated WICKET-6936: -- Description: Option StandardOpenOption.TRUNCATE_EXISTING makes file page store fail on windows (in certain situations). See FYI: https://wicket.markmail.org/search/?q=wicket#query:wicket%20list%3Aorg.apache.wicket.users%20order%3Adate-backward+page:1+mid:c4xoraz77wn5qnpj+state:results was: Option StandardOpenOption.TRUNCATE_EXISTING makes file page store fail on windows (in certain situations). > FilePageStore fails on windows > --- > > Key: WICKET-6936 > URL: https://issues.apache.org/jira/browse/WICKET-6936 > Project: Wicket > Issue Type: Bug >Affects Versions: 10.0.0, 9.6.0 >Reporter: Ernesto Reinaldo Barreiro >Priority: Major > > Option StandardOpenOption.TRUNCATE_EXISTING makes file page store fail on > windows (in certain situations). > See > FYI: > https://wicket.markmail.org/search/?q=wicket#query:wicket%20list%3Aorg.apache.wicket.users%20order%3Adate-backward+page:1+mid:c4xoraz77wn5qnpj+state:results -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (WICKET-6936) FilePageStore fails on windows
Ernesto Reinaldo Barreiro created WICKET-6936: - Summary: FilePageStore fails on windows Key: WICKET-6936 URL: https://issues.apache.org/jira/browse/WICKET-6936 Project: Wicket Issue Type: Bug Affects Versions: 9.6.0, 10.0.0 Reporter: Ernesto Reinaldo Barreiro Option StandardOpenOption.TRUNCATE_EXISTING makes file page store fail on windows (in certain situations). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (WICKET-6935) make some datatable related components more reusable
[ https://issues.apache.org/jira/browse/WICKET-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ernesto Reinaldo Barreiro closed WICKET-6935. - Resolution: Fixed > make some datatable related components more reusable > > > Key: WICKET-6935 > URL: https://issues.apache.org/jira/browse/WICKET-6935 > Project: Wicket > Issue Type: Improvement >Reporter: Ernesto Reinaldo Barreiro >Priority: Minor > > Some datatable related components are very restrictive in factory methods > return types as well as some helper classes are private. This makes reusing > them difficult in some situations. For instance, if in navigation toolbar > instead a simple label you want to place a more complex component, e.g. the > same navigation label + a text filter (a Panel and not a Label). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (WICKET-6935) make some datatable related components more reusable
[ https://issues.apache.org/jira/browse/WICKET-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445903#comment-17445903 ] ASF subversion and git services commented on WICKET-6935: - Commit 210cbe5222df4110faecc3c86898e4f73fe993ea in wicket's branch refs/heads/make_datatables_more_easy_to_override_10_X from reiern70 [ https://gitbox.apache.org/repos/asf?p=wicket.git;h=210cbe5 ] [WICKET-6935] several minor datatable improvements > make some datatable related components more reusable > > > Key: WICKET-6935 > URL: https://issues.apache.org/jira/browse/WICKET-6935 > Project: Wicket > Issue Type: Improvement >Reporter: Ernesto Reinaldo Barreiro >Priority: Minor > > Some datatable related components are very restrictive in factory methods > return types as well as some helper classes are private. This makes reusing > them difficult in some situations. For instance, if in navigation toolbar > instead a simple label you want to place a more complex component, e.g. the > same navigation label + a text filter (a Panel and not a Label). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (WICKET-6935) make some datatable related components more reusable
[ https://issues.apache.org/jira/browse/WICKET-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445904#comment-17445904 ] ASF subversion and git services commented on WICKET-6935: - Commit 210cbe5222df4110faecc3c86898e4f73fe993ea in wicket's branch refs/heads/master from reiern70 [ https://gitbox.apache.org/repos/asf?p=wicket.git;h=210cbe5 ] [WICKET-6935] several minor datatable improvements > make some datatable related components more reusable > > > Key: WICKET-6935 > URL: https://issues.apache.org/jira/browse/WICKET-6935 > Project: Wicket > Issue Type: Improvement >Reporter: Ernesto Reinaldo Barreiro >Priority: Minor > > Some datatable related components are very restrictive in factory methods > return types as well as some helper classes are private. This makes reusing > them difficult in some situations. For instance, if in navigation toolbar > instead a simple label you want to place a more complex component, e.g. the > same navigation label + a text filter (a Panel and not a Label). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[wicket] branch master updated (128125f -> 210cbe5)
This is an automated email from the ASF dual-hosted git repository. reiern70 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/wicket.git. from 128125f Simplify the test for Strings#stripJSessionId() add 210cbe5 [WICKET-6935] several minor datatable improvements No new revisions were added by this update. Summary of changes: .../ajax/markup/html/AjaxEditableChoiceLabel.java | 5 +++-- .../data/table/AjaxFallbackDefaultDataTable.java| 11 ++- .../html/repeater/data/table/NavigationToolbar.java | 17 ++--- .../markup/html/repeater/data/table/NavigatorLabel.java | 8 4 files changed, 23 insertions(+), 18 deletions(-)
[wicket] branch make_datatables_more_easy_to_override_10_X updated (55e1083 -> 210cbe5)
This is an automated email from the ASF dual-hosted git repository. reiern70 pushed a change to branch make_datatables_more_easy_to_override_10_X in repository https://gitbox.apache.org/repos/asf/wicket.git. discard 55e1083 [WICKET-6935] several minor datatable improvements add 210cbe5 [WICKET-6935] several minor datatable improvements This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (55e1083) \ N -- N -- N refs/heads/make_datatables_more_easy_to_override_10_X (210cbe5) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../wicket/extensions/ajax/markup/html/AjaxEditableChoiceLabel.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
[jira] [Commented] (WICKET-6935) make some datatable related components more reusable
[ https://issues.apache.org/jira/browse/WICKET-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445902#comment-17445902 ] ASF GitHub Bot commented on WICKET-6935: reiern70 commented on pull request #482: URL: https://github.com/apache/wicket/pull/482#issuecomment-972834645 @martin-g many thanks for review. Landed in master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > make some datatable related components more reusable > > > Key: WICKET-6935 > URL: https://issues.apache.org/jira/browse/WICKET-6935 > Project: Wicket > Issue Type: Improvement >Reporter: Ernesto Reinaldo Barreiro >Priority: Minor > > Some datatable related components are very restrictive in factory methods > return types as well as some helper classes are private. This makes reusing > them difficult in some situations. For instance, if in navigation toolbar > instead a simple label you want to place a more complex component, e.g. the > same navigation label + a text filter (a Panel and not a Label). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [wicket] reiern70 merged pull request #482: [WICKET-6935] several minor datatable improvements
reiern70 merged pull request #482: URL: https://github.com/apache/wicket/pull/482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [wicket] reiern70 commented on pull request #482: [WICKET-6935] several minor datatable improvements
reiern70 commented on pull request #482: URL: https://github.com/apache/wicket/pull/482#issuecomment-972834645 @martin-g many thanks for review. Landed in master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (WICKET-6935) make some datatable related components more reusable
[ https://issues.apache.org/jira/browse/WICKET-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445901#comment-17445901 ] ASF GitHub Bot commented on WICKET-6935: reiern70 merged pull request #482: URL: https://github.com/apache/wicket/pull/482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > make some datatable related components more reusable > > > Key: WICKET-6935 > URL: https://issues.apache.org/jira/browse/WICKET-6935 > Project: Wicket > Issue Type: Improvement >Reporter: Ernesto Reinaldo Barreiro >Priority: Minor > > Some datatable related components are very restrictive in factory methods > return types as well as some helper classes are private. This makes reusing > them difficult in some situations. For instance, if in navigation toolbar > instead a simple label you want to place a more complex component, e.g. the > same navigation label + a text filter (a Panel and not a Label). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (WICKET-6935) make some datatable related components more reusable
[ https://issues.apache.org/jira/browse/WICKET-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445900#comment-17445900 ] ASF GitHub Bot commented on WICKET-6935: reiern70 commented on a change in pull request #482: URL: https://github.com/apache/wicket/pull/482#discussion_r752205791 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java ## @@ -73,16 +68,16 @@ protected PagingNavigator newPagingNavigator(final String navigatorId, } /** -* Factory method used to create the navigator label that will be used by the datatable +* Factory method used to create the navigator label. * * @param navigatorId *component id navigator label should be created with * @param table -*dataview used by datatable +*DataTable used by datatable * @return navigator label that will be used to navigate the data table * */ - protected WebComponent newNavigatorLabel(final String navigatorId, final DataTable table) + protected Component newNavigatorLabel(final String navigatorId, final DataTable table) Review comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > make some datatable related components more reusable > > > Key: WICKET-6935 > URL: https://issues.apache.org/jira/browse/WICKET-6935 > Project: Wicket > Issue Type: Improvement >Reporter: Ernesto Reinaldo Barreiro >Priority: Minor > > Some datatable related components are very restrictive in factory methods > return types as well as some helper classes are private. This makes reusing > them difficult in some situations. For instance, if in navigation toolbar > instead a simple label you want to place a more complex component, e.g. the > same navigation label + a text filter (a Panel and not a Label). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [wicket] reiern70 commented on a change in pull request #482: [WICKET-6935] several minor datatable improvements
reiern70 commented on a change in pull request #482: URL: https://github.com/apache/wicket/pull/482#discussion_r752205791 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java ## @@ -73,16 +68,16 @@ protected PagingNavigator newPagingNavigator(final String navigatorId, } /** -* Factory method used to create the navigator label that will be used by the datatable +* Factory method used to create the navigator label. * * @param navigatorId *component id navigator label should be created with * @param table -*dataview used by datatable +*DataTable used by datatable * @return navigator label that will be used to navigate the data table * */ - protected WebComponent newNavigatorLabel(final String navigatorId, final DataTable table) + protected Component newNavigatorLabel(final String navigatorId, final DataTable table) Review comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[wicket] branch allow_to_overrride_channel_creation created (now 6e35fdf)
This is an automated email from the ASF dual-hosted git repository. reiern70 pushed a change to branch allow_to_overrride_channel_creation in repository https://gitbox.apache.org/repos/asf/wicket.git. at 6e35fdf allow to override write channel creation No new revisions were added by this update.
[GitHub] [wicket] reiern70 closed pull request #483: Allow to overrride channel creation
reiern70 closed pull request #483: URL: https://github.com/apache/wicket/pull/483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (WICKET-6935) make some datatable related components more reusable
[ https://issues.apache.org/jira/browse/WICKET-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445770#comment-17445770 ] ASF GitHub Bot commented on WICKET-6935: martin-g commented on a change in pull request #482: URL: https://github.com/apache/wicket/pull/482#discussion_r752046172 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java ## @@ -73,16 +68,16 @@ protected PagingNavigator newPagingNavigator(final String navigatorId, } /** -* Factory method used to create the navigator label that will be used by the datatable +* Factory method used to create the navigator label. * * @param navigatorId *component id navigator label should be created with * @param table -*dataview used by datatable +*DataTable used by datatable * @return navigator label that will be used to navigate the data table * */ - protected WebComponent newNavigatorLabel(final String navigatorId, final DataTable table) + protected Component newNavigatorLabel(final String navigatorId, final DataTable table) Review comment: Please do the same for `org.apache.wicket.extensions.ajax.markup.html.AjaxEditableChoiceLabel#newLabel()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > make some datatable related components more reusable > > > Key: WICKET-6935 > URL: https://issues.apache.org/jira/browse/WICKET-6935 > Project: Wicket > Issue Type: Improvement >Reporter: Ernesto Reinaldo Barreiro >Priority: Minor > > Some datatable related components are very restrictive in factory methods > return types as well as some helper classes are private. This makes reusing > them difficult in some situations. For instance, if in navigation toolbar > instead a simple label you want to place a more complex component, e.g. the > same navigation label + a text filter (a Panel and not a Label). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [wicket] martin-g commented on a change in pull request #482: [WICKET-6935] several minor datatable improvements
martin-g commented on a change in pull request #482: URL: https://github.com/apache/wicket/pull/482#discussion_r752046172 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java ## @@ -73,16 +68,16 @@ protected PagingNavigator newPagingNavigator(final String navigatorId, } /** -* Factory method used to create the navigator label that will be used by the datatable +* Factory method used to create the navigator label. * * @param navigatorId *component id navigator label should be created with * @param table -*dataview used by datatable +*DataTable used by datatable * @return navigator label that will be used to navigate the data table * */ - protected WebComponent newNavigatorLabel(final String navigatorId, final DataTable table) + protected Component newNavigatorLabel(final String navigatorId, final DataTable table) Review comment: Please do the same for `org.apache.wicket.extensions.ajax.markup.html.AjaxEditableChoiceLabel#newLabel()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (WICKET-6935) make some datatable related components more reusable
[ https://issues.apache.org/jira/browse/WICKET-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445766#comment-17445766 ] ASF subversion and git services commented on WICKET-6935: - Commit 55e10832ce22e7a122003d6c88e8e549814aa6c2 in wicket's branch refs/heads/make_datatables_more_easy_to_override_10_X from reiern70 [ https://gitbox.apache.org/repos/asf?p=wicket.git;h=55e1083 ] [WICKET-6935] several minor datatable improvements > make some datatable related components more reusable > > > Key: WICKET-6935 > URL: https://issues.apache.org/jira/browse/WICKET-6935 > Project: Wicket > Issue Type: Improvement >Reporter: Ernesto Reinaldo Barreiro >Priority: Minor > > Some datatable related components are very restrictive in factory methods > return types as well as some helper classes are private. This makes reusing > them difficult in some situations. For instance, if in navigation toolbar > instead a simple label you want to place a more complex component, e.g. the > same navigation label + a text filter (a Panel and not a Label). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[wicket] branch make_datatables_more_easy_to_override_10_X created (now 55e1083)
This is an automated email from the ASF dual-hosted git repository. reiern70 pushed a change to branch make_datatables_more_easy_to_override_10_X in repository https://gitbox.apache.org/repos/asf/wicket.git. at 55e1083 [WICKET-6935] several minor datatable improvements This branch includes the following new commits: new 55e1083 [WICKET-6935] several minor datatable improvements The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[wicket] 01/01: [WICKET-6935] several minor datatable improvements
This is an automated email from the ASF dual-hosted git repository.
reiern70 pushed a commit to branch make_datatables_more_easy_to_override_10_X
in repository https://gitbox.apache.org/repos/asf/wicket.git
commit 55e10832ce22e7a122003d6c88e8e549814aa6c2
Author: reiern70
AuthorDate: Thu Nov 18 12:17:14 2021 +0300
[WICKET-6935] several minor datatable improvements
---
.../data/table/AjaxFallbackDefaultDataTable.java| 11 ++-
.../html/repeater/data/table/NavigationToolbar.java | 17 ++---
.../markup/html/repeater/data/table/NavigatorLabel.java | 8
3 files changed, 20 insertions(+), 16 deletions(-)
diff --git
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/repeater/data/table/AjaxFallbackDefaultDataTable.java
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/repeater/data/table/AjaxFallbackDefaultDataTable.java
index 0cf9af3..795cef7 100644
---
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/repeater/data/table/AjaxFallbackDefaultDataTable.java
+++
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/repeater/data/table/AjaxFallbackDefaultDataTable.java
@@ -71,8 +71,17 @@ public class AjaxFallbackDefaultDataTable extends
DataTable
super(id, columns, dataProvider, rowsPerPage);
setOutputMarkupId(true);
setVersioned(false);
+ addToolBars(dataProvider);
+ }
+
+ /**
+* Factory method for toolbars
+* @param dataProvider {@link
org.apache.wicket.extensions.markup.html.repeater.data.table.ISortableDataProvider}
+*/
+ protected void addToolBars(final ISortableDataProvider
dataProvider)
+ {
addTopToolbar(new AjaxNavigationToolbar(this));
- addTopToolbar(new AjaxFallbackHeadersToolbar(this,
dataProvider));
+ addTopToolbar(new AjaxFallbackHeadersToolbar<>(this,
dataProvider));
addBottomToolbar(new NoRecordsToolbar(this));
}
diff --git
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java
index 70515de..1adee04 100644
---
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java
+++
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java
@@ -17,8 +17,10 @@
package org.apache.wicket.extensions.markup.html.repeater.data.table;
import org.apache.wicket.AttributeModifier;
+import org.apache.wicket.Component;
import org.apache.wicket.markup.html.WebComponent;
import org.apache.wicket.markup.html.WebMarkupContainer;
+import org.apache.wicket.markup.html.navigation.paging.IPageableItems;
import org.apache.wicket.markup.html.navigation.paging.PagingNavigator;
import org.apache.wicket.model.IModel;
@@ -44,14 +46,7 @@ public class NavigationToolbar extends AbstractToolbar
WebMarkupContainer span = new WebMarkupContainer("span");
add(span);
- span.add(AttributeModifier.replace("colspan", new
IModel()
- {
- @Override
- public String getObject()
- {
- return
String.valueOf(table.getColumns().size()).intern();
- }
- }));
+ span.add(AttributeModifier.replace("colspan", (IModel)
() -> String.valueOf(table.getColumns().size()).intern()));
span.add(newPagingNavigator("navigator", table));
span.add(newNavigatorLabel("navigatorLabel", table));
@@ -73,16 +68,16 @@ public class NavigationToolbar extends AbstractToolbar
}
/**
-* Factory method used to create the navigator label that will be used
by the datatable
+* Factory method used to create the navigator label.
*
* @param navigatorId
*component id navigator label should be created with
* @param table
-*dataview used by datatable
+*DataTable used by datatable
* @return navigator label that will be used to navigate the data table
*
*/
- protected WebComponent newNavigatorLabel(final String navigatorId,
final DataTable table)
+ protected Component newNavigatorLabel(final String navigatorId, final
DataTable table)
{
return new NavigatorLabel(navigatorId, table);
}
diff --git
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigatorLabel.java
[GitHub] [wicket] reiern70 merged pull request #481: several minor datatable improvements
reiern70 merged pull request #481: URL: https://github.com/apache/wicket/pull/481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (WICKET-6935) make some datatable related components more reusable
[ https://issues.apache.org/jira/browse/WICKET-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445755#comment-17445755 ] ASF subversion and git services commented on WICKET-6935: - Commit 6abc8fddc2f76bfe947eaae6a75fffb8ce481866 in wicket's branch refs/heads/wicket-9.x from reiern70 [ https://gitbox.apache.org/repos/asf?p=wicket.git;h=6abc8fd ] WICKET-6935] several minor datatable improvements > make some datatable related components more reusable > > > Key: WICKET-6935 > URL: https://issues.apache.org/jira/browse/WICKET-6935 > Project: Wicket > Issue Type: Improvement >Reporter: Ernesto Reinaldo Barreiro >Priority: Minor > > Some datatable related components are very restrictive in factory methods > return types as well as some helper classes are private. This makes reusing > them difficult in some situations. For instance, if in navigation toolbar > instead a simple label you want to place a more complex component, e.g. the > same navigation label + a text filter (a Panel and not a Label). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[wicket] branch wicket-9.x updated (76a28ef -> 6abc8fd)
This is an automated email from the ASF dual-hosted git repository. reiern70 pushed a change to branch wicket-9.x in repository https://gitbox.apache.org/repos/asf/wicket.git. from 76a28ef WICKET-6933 use separate key for the default instance add 6abc8fd WICKET-6935] several minor datatable improvements No new revisions were added by this update. Summary of changes: .../data/table/AjaxFallbackDefaultDataTable.java | 11 - .../repeater/data/table/NavigationToolbar.java | 48 +- .../html/repeater/data/table/NavigatorLabel.java | 2 +- 3 files changed, 48 insertions(+), 13 deletions(-)
[GitHub] [wicket] reiern70 commented on pull request #481: several minor datatable improvements
reiern70 commented on pull request #481: URL: https://github.com/apache/wicket/pull/481#issuecomment-972664149 @martin-g squashed all commits into one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (WICKET-6935) make some datatable related components more reusable
[ https://issues.apache.org/jira/browse/WICKET-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445747#comment-17445747 ] ASF subversion and git services commented on WICKET-6935: - Commit 6abc8fddc2f76bfe947eaae6a75fffb8ce481866 in wicket's branch refs/heads/make_datatables_more_easy_to_ooverride from reiern70 [ https://gitbox.apache.org/repos/asf?p=wicket.git;h=6abc8fd ] WICKET-6935] several minor datatable improvements > make some datatable related components more reusable > > > Key: WICKET-6935 > URL: https://issues.apache.org/jira/browse/WICKET-6935 > Project: Wicket > Issue Type: Improvement >Reporter: Ernesto Reinaldo Barreiro >Priority: Minor > > Some datatable related components are very restrictive in factory methods > return types as well as some helper classes are private. This makes reusing > them difficult in some situations. For instance, if in navigation toolbar > instead a simple label you want to place a more complex component, e.g. the > same navigation label + a text filter (a Panel and not a Label). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[wicket] branch make_datatables_more_easy_to_ooverride updated (fab3e4a -> 6abc8fd)
This is an automated email from the ASF dual-hosted git repository. reiern70 pushed a change to branch make_datatables_more_easy_to_ooverride in repository https://gitbox.apache.org/repos/asf/wicket.git. omit fab3e4a javadoc omit 0d5b513 javadoc omit 29dddb0 revert label factory methods. It is enough to have LabelModelObject public omit 73e611d several minor datatable improvements add 6abc8fd WICKET-6935] several minor datatable improvements This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (fab3e4a) \ N -- N -- N refs/heads/make_datatables_more_easy_to_ooverride (6abc8fd) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes:
[GitHub] [wicket] reiern70 commented on pull request #481: several minor datatable improvements
reiern70 commented on pull request #481: URL: https://github.com/apache/wicket/pull/481#issuecomment-972656891 > Please create a JIRA ticket https://issues.apache.org/jira/browse/WICKET-6935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (WICKET-6935) make some datatable related components more reusable
Ernesto Reinaldo Barreiro created WICKET-6935: - Summary: make some datatable related components more reusable Key: WICKET-6935 URL: https://issues.apache.org/jira/browse/WICKET-6935 Project: Wicket Issue Type: Improvement Reporter: Ernesto Reinaldo Barreiro Some datatable related components are very restrictive in factory methods return types as well as some helper classes are private. This makes reusing them difficult in some situations. For instance, if in navigation toolbar instead a simple label you want to place a more complex component, e.g. the same navigation label + a text filter (a Panel and not a Label). -- This message was sent by Atlassian Jira (v8.20.1#820001)
