[jira] [Commented] (WICKET-4976) WicketTester#startComponent(Component) doesn't detach the component and request cycle
[ https://issues.apache.org/jira/browse/WICKET-4976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13580588#comment-13580588 ] Hielke Hoeve commented on WICKET-4976: -- It is not needed, this could be done in a separate method but that does not change anything. > WicketTester#startComponent(Component) doesn't detach the component and > request cycle > - > > Key: WICKET-4976 > URL: https://issues.apache.org/jira/browse/WICKET-4976 > Project: Wicket > Issue Type: Sub-task > Components: wicket >Affects Versions: 1.5.9, 6.4.0 >Reporter: Martin Grigorov >Assignee: Martin Grigorov >Priority: Minor > Fix For: 1.5.10, 6.5.0 > > > WicketTester#startComponent(Component) doesn't detach the component and > request cycle -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (WICKET-4976) WicketTester#startComponent(Component) doesn't detach the component and request cycle
[ https://issues.apache.org/jira/browse/WICKET-4976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13580541#comment-13580541 ] Hielke Hoeve edited comment on WICKET-4976 at 2/18/13 11:20 AM: This task now breaks one of WiQuery's testcases (as far as I could see, comparing wicket versions in github is impossible): https://github.com/WiQuery/wiquery/blob/c58d518b69bdfc2e481e6a812763f2176753b55c/wiquery-jquery-ui/src/test/java/org/odlabs/wiquery/ui/button/ButtonTestCase.java#L151 tester.startPage(new ButtonTestPage(true)); The exception is: org.apache.wicket.WicketRuntimeException: No RequestCycle is currently set! at org.apache.wicket.Component.getRequest(Component.java:1795) at org.apache.wicket.markup.html.WebPage.dirty(WebPage.java:318) at org.apache.wicket.Page.init(Page.java:715) at org.apache.wicket.Page.(Page.java:182) at org.apache.wicket.Page.(Page.java:136) at org.apache.wicket.markup.html.WebPage.(WebPage.java:76) at org.odlabs.wiquery.ui.button.ButtonTestPage.(ButtonTestPage.java:26) at org.odlabs.wiquery.ui.button.ButtonTestCase.testSetLabelModel(ButtonTestCase.java:151) This works in Wicket 6.2.0 through 6.4.0. When rewriting this test with the following call: tester.startPage(ButtonTestPage.class); The testcase works. was (Author: hielkehoeve): This task now breaks one of WiQuery's testcases (as far as I could see, comparing wicket versions in github is impossible): https://github.com/WiQuery/wiquery/blob/master/wiquery-jquery-ui/src/test/java/org/odlabs/wiquery/ui/button/ButtonTestCase.java#L151 tester.startPage(new ButtonTestPage(true)); The exception is: org.apache.wicket.WicketRuntimeException: No RequestCycle is currently set! at org.apache.wicket.Component.getRequest(Component.java:1795) at org.apache.wicket.markup.html.WebPage.dirty(WebPage.java:318) at org.apache.wicket.Page.init(Page.java:715) at org.apache.wicket.Page.(Page.java:182) at org.apache.wicket.Page.(Page.java:136) at org.apache.wicket.markup.html.WebPage.(WebPage.java:76) at org.odlabs.wiquery.ui.button.ButtonTestPage.(ButtonTestPage.java:26) at org.odlabs.wiquery.ui.button.ButtonTestCase.testSetLabelModel(ButtonTestCase.java:151) This works in Wicket 6.2.0 through 6.4.0. When rewriting this test with the following call: tester.startPage(ButtonTestPage.class); The testcase works. > WicketTester#startComponent(Component) doesn't detach the component and > request cycle > - > > Key: WICKET-4976 > URL: https://issues.apache.org/jira/browse/WICKET-4976 > Project: Wicket > Issue Type: Sub-task > Components: wicket >Affects Versions: 1.5.9, 6.4.0 >Reporter: Martin Grigorov >Assignee: Martin Grigorov >Priority: Minor > Fix For: 1.5.10, 6.5.0 > > > WicketTester#startComponent(Component) doesn't detach the component and > request cycle -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4976) WicketTester#startComponent(Component) doesn't detach the component and request cycle
[ https://issues.apache.org/jira/browse/WICKET-4976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13580541#comment-13580541 ] Hielke Hoeve commented on WICKET-4976: -- This task now breaks one of WiQuery's testcases (as far as I could see, comparing wicket versions in github is impossible): https://github.com/WiQuery/wiquery/blob/master/wiquery-jquery-ui/src/test/java/org/odlabs/wiquery/ui/button/ButtonTestCase.java#L151 tester.startPage(new ButtonTestPage(true)); The exception is: org.apache.wicket.WicketRuntimeException: No RequestCycle is currently set! at org.apache.wicket.Component.getRequest(Component.java:1795) at org.apache.wicket.markup.html.WebPage.dirty(WebPage.java:318) at org.apache.wicket.Page.init(Page.java:715) at org.apache.wicket.Page.(Page.java:182) at org.apache.wicket.Page.(Page.java:136) at org.apache.wicket.markup.html.WebPage.(WebPage.java:76) at org.odlabs.wiquery.ui.button.ButtonTestPage.(ButtonTestPage.java:26) at org.odlabs.wiquery.ui.button.ButtonTestCase.testSetLabelModel(ButtonTestCase.java:151) This works in Wicket 6.2.0 through 6.4.0. When rewriting this test with the following call: tester.startPage(ButtonTestPage.class); The testcase works. > WicketTester#startComponent(Component) doesn't detach the component and > request cycle > - > > Key: WICKET-4976 > URL: https://issues.apache.org/jira/browse/WICKET-4976 > Project: Wicket > Issue Type: Sub-task > Components: wicket >Affects Versions: 1.5.9, 6.4.0 >Reporter: Martin Grigorov >Assignee: Martin Grigorov >Priority: Minor > Fix For: 1.5.10, 6.5.0 > > > WicketTester#startComponent(Component) doesn't detach the component and > request cycle -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4047) WebClientInfo causes NullPointerException when the request header "User-Agent" is null.
[ https://issues.apache.org/jira/browse/WICKET-4047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hielke Hoeve updated WICKET-4047: - Attachment: patchsuggestion.patch an if check should solve the NPE. > WebClientInfo causes NullPointerException when the request header > "User-Agent" is null. > > > Key: WICKET-4047 > URL: https://issues.apache.org/jira/browse/WICKET-4047 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.5.0 > Environment: Windows 7, Jetty 6.1.26, Wicket 1.5.0. >Reporter: Hielke Hoeve >Priority: Minor > Labels: NPE, useragent, wicket > Attachments: patchsuggestion.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > When the value of request header "User-Agent" is null, the class UserAgent > tries to match UserAgent.INTERNET_EXPLORER against null, which results in a > NullPointerException (UserAgent.java:90 and UserAgent.java:102). > The function matches(String) of class UserAgent should check for null values. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4047) WebClientInfo causes NullPointerException when the request header "User-Agent" is null.
[ https://issues.apache.org/jira/browse/WICKET-4047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103609#comment-13103609 ] Hielke Hoeve commented on WICKET-4047: -- Related to WICKET-475, however the NPE is now thrown further down the stack. > WebClientInfo causes NullPointerException when the request header > "User-Agent" is null. > > > Key: WICKET-4047 > URL: https://issues.apache.org/jira/browse/WICKET-4047 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.5.0 > Environment: Windows 7, Jetty 6.1.26, Wicket 1.5.0. >Reporter: Hielke Hoeve >Priority: Minor > Labels: NPE, useragent, wicket > Original Estimate: 1h > Remaining Estimate: 1h > > When the value of request header "User-Agent" is null, the class UserAgent > tries to match UserAgent.INTERNET_EXPLORER against null, which results in a > NullPointerException (UserAgent.java:90 and UserAgent.java:102). > The function matches(String) of class UserAgent should check for null values. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (WICKET-4047) WebClientInfo causes NullPointerException when the request header "User-Agent" is null.
WebClientInfo causes NullPointerException when the request header "User-Agent" is null. Key: WICKET-4047 URL: https://issues.apache.org/jira/browse/WICKET-4047 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.5.0 Environment: Windows 7, Jetty 6.1.26, Wicket 1.5.0. Reporter: Hielke Hoeve Priority: Minor When the value of request header "User-Agent" is null, the class UserAgent tries to match UserAgent.INTERNET_EXPLORER against null, which results in a NullPointerException (UserAgent.java:90 and UserAgent.java:102). The function matches(String) of class UserAgent should check for null values. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (WICKET-3828) QueryStringWithTimestampResourceCachingStrategy#undecorateUrl(ResourceUrl) can causes NPE
QueryStringWithTimestampResourceCachingStrategy#undecorateUrl(ResourceUrl) can causes NPE - Key: WICKET-3828 URL: https://issues.apache.org/jira/browse/WICKET-3828 Project: Wicket Issue Type: Bug Components: wicket-core Affects Versions: 1.5-RC4 Environment: Windows 7, Eclipse 3.6.2, Java 1.6.23 Reporter: Hielke Hoeve Priority: Minor undecorateUrl(ResourceUrl) can sometimes produces a NPE, because the decorateUrl(ResourceUrl, ResourceReference) function contains an if using the value of lastModified(ResourceReference) and the getLastModified(ResourceReference) function may return NULL from the cache (or hypothetically resource). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3674) Provide an interface to allow css resources to be compressed like javascript resources
[ https://issues.apache.org/jira/browse/WICKET-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029963#comment-13029963 ] Hielke Hoeve commented on WICKET-3674: -- While I was checking out sources to make a patch you already made exactly what I wanted :) Fixed! > Provide an interface to allow css resources to be compressed like javascript > resources > -- > > Key: WICKET-3674 > URL: https://issues.apache.org/jira/browse/WICKET-3674 > Project: Wicket > Issue Type: New Feature > Components: wicket-core >Affects Versions: 1.5-RC3 >Reporter: Hielke Hoeve >Assignee: Martin Grigorov >Priority: Minor > Labels: compress, javascript, resource, stylesheet > > Wicket provides a nice interface to compress JavaScript resources. WiQuery > provides the YUICompressor implementation, which works really well. However > there is no way to compress users their CSS resources. Wicket acts if there > can only be JavaScript and no CSS and all JavaScript compressor > implementations will fail when something else than JavaScript is given to > them. In Wicket 1.4 the call happened in JavaScriptPackageResource and CSS > resources were omitted all together, but in 1.5 > JavaScriptPackageResourceReference is just a façade and all resources are > treated the same... -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3675) Usage of JavaScriptCompressor by resources other than PackageTextTemplates is lost!
[ https://issues.apache.org/jira/browse/WICKET-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029964#comment-13029964 ] Hielke Hoeve commented on WICKET-3675: -- While I was checking out sources to make a patch you already made exactly what I wanted :) Fixed! > Usage of JavaScriptCompressor by resources other than PackageTextTemplates is > lost! > --- > > Key: WICKET-3675 > URL: https://issues.apache.org/jira/browse/WICKET-3675 > Project: Wicket > Issue Type: Bug > Components: wicket-core >Affects Versions: 1.5-M1, 1.5-M2.1, 1.5-M3, 1.5-RC1, 1.5-RC2, 1.5-RC3, > 1.5-RC4 >Reporter: Hielke Hoeve >Assignee: Martin Grigorov > Labels: compression, javascript, resource > > With the refactoring of ResourceReferences, Resources and ResourceStreams it > seems that the JavaScriptCompressor is no longer used for resources other > than a PackageTextTemplate. In Wicket 1.4 it used to be in > JavascriptPackageResource but seeing as this class is gone the > JavaScriptCompressor is no longer used. > There should be either a subclass of PackageResource which uses the > JavaScriptCompressor or a way to intercept the length and the bytes which are > written to the stream in PackageResource line 327. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3674) Provide an interface to allow css resources to be compressed like javascript resources
[ https://issues.apache.org/jira/browse/WICKET-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029871#comment-13029871 ] Hielke Hoeve commented on WICKET-3674: -- I know I should provide a patch however the JavaScriptCompressor is currently not even used in Wicket 1.5, so I have no idea where to start... https://issues.apache.org/jira/browse/WICKET-3675 > Provide an interface to allow css resources to be compressed like javascript > resources > -- > > Key: WICKET-3674 > URL: https://issues.apache.org/jira/browse/WICKET-3674 > Project: Wicket > Issue Type: New Feature > Components: wicket-core >Affects Versions: 1.5-RC3 >Reporter: Hielke Hoeve >Priority: Minor > Labels: compress, javascript, resource, stylesheet > > Wicket provides a nice interface to compress JavaScript resources. WiQuery > provides the YUICompressor implementation, which works really well. However > there is no way to compress users their CSS resources. Wicket acts if there > can only be JavaScript and no CSS and all JavaScript compressor > implementations will fail when something else than JavaScript is given to > them. In Wicket 1.4 the call happened in JavaScriptPackageResource and CSS > resources were omitted all together, but in 1.5 > JavaScriptPackageResourceReference is just a façade and all resources are > treated the same... -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (WICKET-3675) Usage of JavaScriptCompressor by resources other than PackageTextTemplates is lost!
Usage of JavaScriptCompressor by resources other than PackageTextTemplates is lost! --- Key: WICKET-3675 URL: https://issues.apache.org/jira/browse/WICKET-3675 Project: Wicket Issue Type: Bug Components: wicket-core Affects Versions: 1.5-RC3, 1.5-RC2, 1.5-RC1, 1.5-M3, 1.5-M2.1, 1.5-M1, 1.5-RC4 Reporter: Hielke Hoeve Priority: Critical With the refactoring of ResourceReferences, Resources and ResourceStreams it seems that the JavaScriptCompressor is no longer used for resources other than a PackageTextTemplate. In Wicket 1.4 it used to be in JavascriptPackageResource but seeing as this class is gone the JavaScriptCompressor is no longer used. There should be either a subclass of PackageResource which uses the JavaScriptCompressor or a way to intercept the length and the bytes which are written to the stream in PackageResource line 327. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (WICKET-3674) Provide an interface to allow css resources to be compressed like javascript resources
Provide an interface to allow css resources to be compressed like javascript resources -- Key: WICKET-3674 URL: https://issues.apache.org/jira/browse/WICKET-3674 Project: Wicket Issue Type: New Feature Components: wicket-core Affects Versions: 1.5-RC3 Reporter: Hielke Hoeve Priority: Minor Wicket provides a nice interface to compress JavaScript resources. WiQuery provides the YUICompressor implementation, which works really well. However there is no way to compress users their CSS resources. Wicket acts if there can only be JavaScript and no CSS and all JavaScript compressor implementations will fail when something else than JavaScript is given to them. In Wicket 1.4 the call happened in JavaScriptPackageResource and CSS resources were omitted all together, but in 1.5 JavaScriptPackageResourceReference is just a façade and all resources are treated the same... -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WICKET-2722) RequestCycle.detach() recreates SessionData after logout
[ https://issues.apache.org/jira/browse/WICKET-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hielke Hoeve updated WICKET-2722: - Affects Version/s: 1.4.11 1.4.10 > RequestCycle.detach() recreates SessionData after logout > > > Key: WICKET-2722 > URL: https://issues.apache.org/jira/browse/WICKET-2722 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.4.6, 1.4.7, 1.4.8, 1.4.9, 1.4.10, 1.4.11 > Environment: Wicket 1.4.6, Spring 2.5.6, Hibernate 3.3.1-GA, AspectJ > 1.6.8, Eclipse 3.5.2, Windows 7 32bit >Reporter: Hielke Hoeve >Assignee: Peter Ertl >Priority: Minor > Attachments: req-logger.patch > > > After every page request the RequestCycle asks the RequestLogger (if any) to > write the time taken etc to the logger (using the SessionData of the current > Session). If none exists then a new SessionData is created (RequestLogger > line 250). However when a user logs out the SessionData is destroyed, but the > page still has to detach and thus creates a new SessionData entity. > When we lookup the live sessions and peak sessions from RequestLogger, > the two numbers are (nearly) always the same. Which is wrong when all users > have logged out or closed their browser (no difference there). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-2722) RequestCycle.detach() recreates SessionData after logout
[ https://issues.apache.org/jira/browse/WICKET-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909668#action_12909668 ] Hielke Hoeve edited comment on WICKET-2722 at 9/15/10 5:28 AM: --- The problem seems to be bigger than just a single function call. When someone opens any page of the application a SessionData entity is fetched or created, this is regardless what kind of page (SecurePage or not) the user visits. When someone logs into the application and logs out, the SessionData entity is destroyed but immediately recreated because he then visits another page (in this example a loginpage, because the user logged out). The number of active sessions and peak sessions will always be the same, because SessionData entities are not cleared for users that have stopped visiting a page. That is either they closed the browser and the SessionData entity is not removed, or they logged out and received a new empty SessionData entity. In order for the 2 count functions (getLiveSessions() and getPeakSessions()) to work the internal workings of the SessionData entity needs to be redone. was (Author: hielkehoeve): The problem seems to be bigger than just a single function call. When someone opens any page of the application a SessionData entity is fetched or created, this is regardless what kind of page (SecurePage or not) the user visits. When someone logs into the application and logs out, the SessionData entity is destroyed but immediately recreated because he then visits another page (in this example a loginpage, because the user logged out). The number of active sessions and peak sessions will always be the same, because SessionData entities are not cleared for users that have stopped visiting a page. That is either they closed the browser and the SessionData entity is not removed, or they logged out and received a new empty SessionData entity. > RequestCycle.detach() recreates SessionData after logout > > > Key: WICKET-2722 > URL: https://issues.apache.org/jira/browse/WICKET-2722 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.4.6, 1.4.7, 1.4.8, 1.4.9, 1.4.10, 1.4.11 > Environment: Wicket 1.4.6, Spring 2.5.6, Hibernate 3.3.1-GA, AspectJ > 1.6.8, Eclipse 3.5.2, Windows 7 32bit >Reporter: Hielke Hoeve >Assignee: Peter Ertl >Priority: Minor > Attachments: req-logger.patch > > > After every page request the RequestCycle asks the RequestLogger (if any) to > write the time taken etc to the logger (using the SessionData of the current > Session). If none exists then a new SessionData is created (RequestLogger > line 250). However when a user logs out the SessionData is destroyed, but the > page still has to detach and thus creates a new SessionData entity. > When we lookup the live sessions and peak sessions from RequestLogger, > the two numbers are (nearly) always the same. Which is wrong when all users > have logged out or closed their browser (no difference there). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Reopened: (WICKET-2722) RequestCycle.detach() recreates SessionData after logout
[ https://issues.apache.org/jira/browse/WICKET-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hielke Hoeve reopened WICKET-2722: -- The problem seems to be bigger than just a single function call. When someone opens any page of the application a SessionData entity is fetched or created, this is regardless what kind of page (SecurePage or not) the user visits. When someone logs into the application and logs out, the SessionData entity is destroyed but immediately recreated because he then visits another page (in this example a loginpage, because the user logged out). The number of active sessions and peak sessions will always be the same, because SessionData entities are not cleared for users that have stopped visiting a page. That is either they closed the browser and the SessionData entity is not removed, or they logged out and received a new empty SessionData entity. > RequestCycle.detach() recreates SessionData after logout > > > Key: WICKET-2722 > URL: https://issues.apache.org/jira/browse/WICKET-2722 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.4.6, 1.4.7, 1.4.8, 1.4.9 > Environment: Wicket 1.4.6, Spring 2.5.6, Hibernate 3.3.1-GA, AspectJ > 1.6.8, Eclipse 3.5.2, Windows 7 32bit >Reporter: Hielke Hoeve >Assignee: Peter Ertl >Priority: Minor > Attachments: req-logger.patch > > > After every page request the RequestCycle asks the RequestLogger (if any) to > write the time taken etc to the logger (using the SessionData of the current > Session). If none exists then a new SessionData is created (RequestLogger > line 250). However when a user logs out the SessionData is destroyed, but the > page still has to detach and thus creates a new SessionData entity. > When we lookup the live sessions and peak sessions from RequestLogger, > the two numbers are (nearly) always the same. Which is wrong when all users > have logged out or closed their browser (no difference there). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2722) RequestCycle.detach() recreates SessionData after logout
[ https://issues.apache.org/jira/browse/WICKET-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hielke Hoeve updated WICKET-2722: - Affects Version/s: 1.4.9 1.4.8 1.4.7 It is impossible to create a subclass or a sibling class for this problem because the interface is hooked to the RequestLogger (why create an interface if its hooked to some impl?). I am uncertain as to how this problem should be tackled, is there a valid way to see if the user is logging out? > RequestCycle.detach() recreates SessionData after logout > > > Key: WICKET-2722 > URL: https://issues.apache.org/jira/browse/WICKET-2722 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.4.6, 1.4.7, 1.4.8, 1.4.9 > Environment: Wicket 1.4.6, Spring 2.5.6, Hibernate 3.3.1-GA, AspectJ > 1.6.8, Eclipse 3.5.2, Windows 7 32bit >Reporter: Hielke Hoeve >Priority: Minor > > After every page request the RequestCycle asks the RequestLogger (if any) to > write the time taken etc to the logger (using the SessionData of the current > Session). If none exists then a new SessionData is created (RequestLogger > line 250). However when a user logs out the SessionData is destroyed, but the > page still has to detach and thus creates a new SessionData entity. > When we lookup the live sessions and peak sessions from RequestLogger, > the two numbers are (nearly) always the same. Which is wrong when all users > have logged out or closed their browser (no difference there). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2871) Component registers feedback messages badly
[
https://issues.apache.org/jira/browse/WICKET-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hielke Hoeve updated WICKET-2871:
-
Attachment: wicket-2871.patch
You are totally right, my bad... That shows that working on holidays is never a
good plan :-)
For the record I uploaded a new patch file with the right changes, I also
noticed that a few methods were missing in Session. It still breaks the tests,
though it shows my original intension.
PS:
The fact that the methods in Session are not compatible for Component strikes
me as odd because Component now completely circumvents the API and gets an
unmodifiable list of messages which it adds a new message to. (??)
> Component registers feedback messages badly
> ---
>
> Key: WICKET-2871
> URL: https://issues.apache.org/jira/browse/WICKET-2871
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
>Affects Versions: 1.4.0, 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.4.6, 1.4.7,
> 1.4.8
> Environment: Windows 7
> Wicket 1.4.7
>Reporter: Hielke Hoeve
>Assignee: Jeremy Thomerson
>Priority: Trivial
> Attachments: Session.patch, wicket-2871.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> Component registers feedback messages by adding them to the FeedbackMessages
> class directly while there are special functions in Session to do this.
> Component should call Session.get().error(message) in the following example.
> I have attached a patch file which fixes this.
> Example:
> Component.class
> public final void error(final Serializable message)
> {
> Session.get().getFeedbackMessages().error(this, message);
> Session.get().dirty();
> }
> Session.class:
> public final void error(final String message)
> {
> addFeedbackMessage(message, FeedbackMessage.ERROR);
> }
> private void addFeedbackMessage(String message, int level)
> {
> getFeedbackMessages().add(null, message, level);
> dirty();
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2871) Component registers feedback messages badly
Component registers feedback messages badly
---
Key: WICKET-2871
URL: https://issues.apache.org/jira/browse/WICKET-2871
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.4.8, 1.4.7, 1.4.6, 1.4.5, 1.4.4, 1.4.3, 1.4.2, 1.4.1,
1.4.0
Environment: Windows 7
Wicket 1.4.7
Reporter: Hielke Hoeve
Priority: Trivial
Attachments: Session.patch
Component registers feedback messages by adding them to the FeedbackMessages
class directly while there are special functions in Session to do this.
Component should call Session.get().error(message) in the following example. I
have attached a patch file which fixes this.
Example:
Component.class
public final void error(final Serializable message)
{
Session.get().getFeedbackMessages().error(this, message);
Session.get().dirty();
}
Session.class:
public final void error(final String message)
{
addFeedbackMessage(message, FeedbackMessage.ERROR);
}
private void addFeedbackMessage(String message, int level)
{
getFeedbackMessages().add(null, message, level);
dirty();
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2871) Component registers feedback messages badly
[
https://issues.apache.org/jira/browse/WICKET-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hielke Hoeve updated WICKET-2871:
-
Attachment: Session.patch
> Component registers feedback messages badly
> ---
>
> Key: WICKET-2871
> URL: https://issues.apache.org/jira/browse/WICKET-2871
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
>Affects Versions: 1.4.0, 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.4.6, 1.4.7,
> 1.4.8
> Environment: Windows 7
> Wicket 1.4.7
>Reporter: Hielke Hoeve
>Priority: Trivial
> Attachments: Session.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> Component registers feedback messages by adding them to the FeedbackMessages
> class directly while there are special functions in Session to do this.
> Component should call Session.get().error(message) in the following example.
> I have attached a patch file which fixes this.
> Example:
> Component.class
> public final void error(final Serializable message)
> {
> Session.get().getFeedbackMessages().error(this, message);
> Session.get().dirty();
> }
> Session.class:
> public final void error(final String message)
> {
> addFeedbackMessage(message, FeedbackMessage.ERROR);
> }
> private void addFeedbackMessage(String message, int level)
> {
> getFeedbackMessages().add(null, message, level);
> dirty();
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-2168) TableTree.html is not XHTML valid
[ https://issues.apache.org/jira/browse/WICKET-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852761#action_12852761 ] Hielke Hoeve edited comment on WICKET-2168 at 4/2/10 9:26 AM: -- it seems the fix is wrong. Looking at the uploaded patch I am wondering what I have been thinking :) I am also wondering why the patch did solve the htmlvalidators error message while the html is obviously wrong...
[jira] Updated: (WICKET-2168) TableTree.html is not XHTML valid
[ https://issues.apache.org/jira/browse/WICKET-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hielke Hoeve updated WICKET-2168: - Attachment: TreeTable.html.2.patch second patch which changes the
[jira] Updated: (WICKET-2168) TableTree.html is not XHTML valid
[ https://issues.apache.org/jira/browse/WICKET-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hielke Hoeve updated WICKET-2168: - Affects Version/s: 1.4.7 > TableTree.html is not XHTML valid > - > > Key: WICKET-2168 > URL: https://issues.apache.org/jira/browse/WICKET-2168 > Project: Wicket > Issue Type: Improvement > Components: wicket-extensions >Affects Versions: 1.3.5, 1.3.6, 1.4.7 >Reporter: Hielke Hoeve >Assignee: Juergen Donnerstag >Priority: Trivial > Fix For: 1.3.7, 1.4-RC3 > > Attachments: TreeTable.html.patch > > Original Estimate: 0.08h > Remaining Estimate: 0.08h > > TableTree.html is not valid XHTML 1.0 Strict markup. This due to a missing > "type" attribute. This is required and must be specified for element type > "script". > I have attached a patch for this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-2168) TableTree.html is not XHTML valid
[ https://issues.apache.org/jira/browse/WICKET-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852761#action_12852761 ] Hielke Hoeve edited comment on WICKET-2168 at 4/2/10 9:16 AM: -- it seems the fix is wrong. Looking at the uploaded patch I am wondering what I have been thinking :) I am also wondering why the patch did solve the htmlvalidators error message while the html is obviously wrong... Obviously
[jira] Issue Comment Edited: (WICKET-2168) TableTree.html is not XHTML valid
[ https://issues.apache.org/jira/browse/WICKET-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852761#action_12852761 ] Hielke Hoeve edited comment on WICKET-2168 at 4/2/10 9:16 AM: -- it seems the fix is wrong. Looking at the uploaded patch I am wondering what I have been thinking :) I am also wondering why the patch did solve the htmlvalidators error message while the html is obviously wrong...
[jira] Reopened: (WICKET-2168) TableTree.html is not XHTML valid
[ https://issues.apache.org/jira/browse/WICKET-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hielke Hoeve reopened WICKET-2168: -- it seems the fix is wrong. Looking at the uploaded patch I am wondering what I have been thinking :) Obviously
[jira] Created: (WICKET-2722) RequestCycle.detach() recreates SessionData after logout
RequestCycle.detach() recreates SessionData after logout Key: WICKET-2722 URL: https://issues.apache.org/jira/browse/WICKET-2722 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.6 Environment: Wicket 1.4.6, Spring 2.5.6, Hibernate 3.3.1-GA, AspectJ 1.6.8, Eclipse 3.5.2, Windows 7 32bit Reporter: Hielke Hoeve Priority: Minor After every page request the RequestCycle asks the RequestLogger (if any) to write the time taken etc to the logger (using the SessionData of the current Session). If none exists then a new SessionData is created (RequestLogger line 250). However when a user logs out the SessionData is destroyed, but the page still has to detach and thus creates a new SessionData entity. When we lookup the live sessionsand peak sessions from RequestLogger, the two numbers are (nearly) always the same. Which is wrong when all users have logged out or closed their browser (no difference there). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-2673) TabbedPanel not generic
[ https://issues.apache.org/jira/browse/WICKET-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hielke Hoeve closed WICKET-2673. Resolution: Invalid Fix Version/s: 1.4.6 My bad, should have used better search keywords. > TabbedPanel not generic > --- > > Key: WICKET-2673 > URL: https://issues.apache.org/jira/browse/WICKET-2673 > Project: Wicket > Issue Type: Improvement > Components: wicket-extensions >Affects Versions: 1.4.5 >Reporter: Hielke Hoeve >Priority: Trivial > Fix For: 1.4.6 > > Original Estimate: 1h > Remaining Estimate: 1h > > It would be nice to have a generic TabbedPanel so you don't have to cast > every ITab to the actual implementing class just to fetch something from the > Panel it generates. > In my case I have overridden newLink(String, int) to generate a > AjaxSubmitLink, this needs a form and I need to fetch it from the appropriate > Panel. But this is impossible without jumping through hoops because > TabbedPanel has a field with List instead of List or > List where T extends ITab. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2673) TabbedPanel not generic
TabbedPanel not generic --- Key: WICKET-2673 URL: https://issues.apache.org/jira/browse/WICKET-2673 Project: Wicket Issue Type: Improvement Components: wicket-extensions Affects Versions: 1.4.5 Reporter: Hielke Hoeve Priority: Trivial It would be nice to have a generic TabbedPanel so you don't have to cast every ITab to the actual implementing class just to fetch something from the Panel it generates. In my case I have overridden newLink(String, int) to generate a AjaxSubmitLink, this needs a form and I need to fetch it from the appropriate Panel. But this is impossible without jumping through hoops because TabbedPanel has a field with List instead of List or List where T extends ITab. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2354) PropertyModel does not support index only property ("[0]")
[
https://issues.apache.org/jira/browse/WICKET-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hielke Hoeve updated WICKET-2354:
-
Fix Version/s: 1.3.7
> PropertyModel does not support index only property ("[0]")
> --
>
> Key: WICKET-2354
> URL: https://issues.apache.org/jira/browse/WICKET-2354
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.3.6
> Environment: Windows XP, Eclipse 1.3.6, Java 1.6.0.13, Wicket 1.3.6
>Reporter: Hielke Hoeve
>Priority: Minor
> Fix For: 1.3.7
>
> Attachments: wicket-bug2354.patch, wicket-bug2354.zip
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> When using a PropertyModel with a list as target and an index ("[0]") as
> property the PropertyModel cannot retreive the object from the list. When
> getObject() is called a IndexOutOfBoundsException is thrown.
> Example:
> List addresses = new List();
> new PropertyModel(addresses, "[0]");
> model.getObject();
> Exception:
> java.lang.StringIndexOutOfBoundsException: String index out of range: 0
> at java.lang.String.charAt(String.java:687)
> at
> org.apache.wicket.util.lang.PropertyResolver.findGetter(PropertyResolver.java:509)
> at
> org.apache.wicket.util.lang.PropertyResolver.getGetAndSetter(PropertyResolver.java:338)
> at
> org.apache.wicket.util.lang.PropertyResolver.getObjectAndGetSetter(PropertyResolver.java:224)
> at
> org.apache.wicket.util.lang.PropertyResolver.getValue(PropertyResolver.java:91)
> at
> org.apache.wicket.model.AbstractPropertyModel.getObject(AbstractPropertyModel.java:113)
> I have attached a QuickStart (with 2 test; 1 with the current
> PropertyResolver and 1 with the patched PropertyResolver) and a patch file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2354) PropertyModel does not support index only property ("[0]")
[
https://issues.apache.org/jira/browse/WICKET-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hielke Hoeve updated WICKET-2354:
-
Comment: was deleted
(was: The QuickStart project with 2 tests.)
> PropertyModel does not support index only property ("[0]")
> --
>
> Key: WICKET-2354
> URL: https://issues.apache.org/jira/browse/WICKET-2354
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.3.6
> Environment: Windows XP, Eclipse 1.3.6, Java 1.6.0.13, Wicket 1.3.6
>Reporter: Hielke Hoeve
>Priority: Minor
> Attachments: wicket-bug2354.patch, wicket-bug2354.zip
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> When using a PropertyModel with a list as target and an index ("[0]") as
> property the PropertyModel cannot retreive the object from the list. When
> getObject() is called a IndexOutOfBoundsException is thrown.
> Example:
> List addresses = new List();
> new PropertyModel(addresses, "[0]");
> model.getObject();
> Exception:
> java.lang.StringIndexOutOfBoundsException: String index out of range: 0
> at java.lang.String.charAt(String.java:687)
> at
> org.apache.wicket.util.lang.PropertyResolver.findGetter(PropertyResolver.java:509)
> at
> org.apache.wicket.util.lang.PropertyResolver.getGetAndSetter(PropertyResolver.java:338)
> at
> org.apache.wicket.util.lang.PropertyResolver.getObjectAndGetSetter(PropertyResolver.java:224)
> at
> org.apache.wicket.util.lang.PropertyResolver.getValue(PropertyResolver.java:91)
> at
> org.apache.wicket.model.AbstractPropertyModel.getObject(AbstractPropertyModel.java:113)
> I have attached a QuickStart (with 2 test; 1 with the current
> PropertyResolver and 1 with the patched PropertyResolver) and a patch file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2354) PropertyModel does not support index only property ("[0]")
[
https://issues.apache.org/jira/browse/WICKET-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hielke Hoeve updated WICKET-2354:
-
Attachment: (was: wicket-bug2354.zip)
> PropertyModel does not support index only property ("[0]")
> --
>
> Key: WICKET-2354
> URL: https://issues.apache.org/jira/browse/WICKET-2354
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.3.6
> Environment: Windows XP, Eclipse 1.3.6, Java 1.6.0.13, Wicket 1.3.6
>Reporter: Hielke Hoeve
>Priority: Minor
> Attachments: wicket-bug2354.patch, wicket-bug2354.zip
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> When using a PropertyModel with a list as target and an index ("[0]") as
> property the PropertyModel cannot retreive the object from the list. When
> getObject() is called a IndexOutOfBoundsException is thrown.
> Example:
> List addresses = new List();
> new PropertyModel(addresses, "[0]");
> model.getObject();
> Exception:
> java.lang.StringIndexOutOfBoundsException: String index out of range: 0
> at java.lang.String.charAt(String.java:687)
> at
> org.apache.wicket.util.lang.PropertyResolver.findGetter(PropertyResolver.java:509)
> at
> org.apache.wicket.util.lang.PropertyResolver.getGetAndSetter(PropertyResolver.java:338)
> at
> org.apache.wicket.util.lang.PropertyResolver.getObjectAndGetSetter(PropertyResolver.java:224)
> at
> org.apache.wicket.util.lang.PropertyResolver.getValue(PropertyResolver.java:91)
> at
> org.apache.wicket.model.AbstractPropertyModel.getObject(AbstractPropertyModel.java:113)
> I have attached a QuickStart (with 2 test; 1 with the current
> PropertyResolver and 1 with the patched PropertyResolver) and a patch file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2354) PropertyModel does not support index only property ("[0]")
[
https://issues.apache.org/jira/browse/WICKET-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hielke Hoeve updated WICKET-2354:
-
Comment: was deleted
(was: The QuickStart project containing 2 tests.)
> PropertyModel does not support index only property ("[0]")
> --
>
> Key: WICKET-2354
> URL: https://issues.apache.org/jira/browse/WICKET-2354
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.3.6
> Environment: Windows XP, Eclipse 1.3.6, Java 1.6.0.13, Wicket 1.3.6
>Reporter: Hielke Hoeve
>Priority: Minor
> Attachments: wicket-bug2354.patch, wicket-bug2354.zip
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> When using a PropertyModel with a list as target and an index ("[0]") as
> property the PropertyModel cannot retreive the object from the list. When
> getObject() is called a IndexOutOfBoundsException is thrown.
> Example:
> List addresses = new List();
> new PropertyModel(addresses, "[0]");
> model.getObject();
> Exception:
> java.lang.StringIndexOutOfBoundsException: String index out of range: 0
> at java.lang.String.charAt(String.java:687)
> at
> org.apache.wicket.util.lang.PropertyResolver.findGetter(PropertyResolver.java:509)
> at
> org.apache.wicket.util.lang.PropertyResolver.getGetAndSetter(PropertyResolver.java:338)
> at
> org.apache.wicket.util.lang.PropertyResolver.getObjectAndGetSetter(PropertyResolver.java:224)
> at
> org.apache.wicket.util.lang.PropertyResolver.getValue(PropertyResolver.java:91)
> at
> org.apache.wicket.model.AbstractPropertyModel.getObject(AbstractPropertyModel.java:113)
> I have attached a QuickStart (with 2 test; 1 with the current
> PropertyResolver and 1 with the patched PropertyResolver) and a patch file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2354) PropertyModel does not support index only property ("[0]")
[
https://issues.apache.org/jira/browse/WICKET-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hielke Hoeve updated WICKET-2354:
-
Attachment: wicket-bug2354.zip
The QuickStart project containing 2 tests.
> PropertyModel does not support index only property ("[0]")
> --
>
> Key: WICKET-2354
> URL: https://issues.apache.org/jira/browse/WICKET-2354
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.3.6
> Environment: Windows XP, Eclipse 1.3.6, Java 1.6.0.13, Wicket 1.3.6
>Reporter: Hielke Hoeve
>Priority: Minor
> Attachments: wicket-bug2354.patch, wicket-bug2354.zip
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> When using a PropertyModel with a list as target and an index ("[0]") as
> property the PropertyModel cannot retreive the object from the list. When
> getObject() is called a IndexOutOfBoundsException is thrown.
> Example:
> List addresses = new List();
> new PropertyModel(addresses, "[0]");
> model.getObject();
> Exception:
> java.lang.StringIndexOutOfBoundsException: String index out of range: 0
> at java.lang.String.charAt(String.java:687)
> at
> org.apache.wicket.util.lang.PropertyResolver.findGetter(PropertyResolver.java:509)
> at
> org.apache.wicket.util.lang.PropertyResolver.getGetAndSetter(PropertyResolver.java:338)
> at
> org.apache.wicket.util.lang.PropertyResolver.getObjectAndGetSetter(PropertyResolver.java:224)
> at
> org.apache.wicket.util.lang.PropertyResolver.getValue(PropertyResolver.java:91)
> at
> org.apache.wicket.model.AbstractPropertyModel.getObject(AbstractPropertyModel.java:113)
> I have attached a QuickStart (with 2 test; 1 with the current
> PropertyResolver and 1 with the patched PropertyResolver) and a patch file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2354) PropertyModel does not support index only property ("[0]")
[
https://issues.apache.org/jira/browse/WICKET-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hielke Hoeve updated WICKET-2354:
-
Attachment: wicket-bug2354.patch
> PropertyModel does not support index only property ("[0]")
> --
>
> Key: WICKET-2354
> URL: https://issues.apache.org/jira/browse/WICKET-2354
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.3.6
> Environment: Windows XP, Eclipse 1.3.6, Java 1.6.0.13, Wicket 1.3.6
>Reporter: Hielke Hoeve
>Priority: Minor
> Attachments: wicket-bug2354.patch, wicket-bug2354.zip
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> When using a PropertyModel with a list as target and an index ("[0]") as
> property the PropertyModel cannot retreive the object from the list. When
> getObject() is called a IndexOutOfBoundsException is thrown.
> Example:
> List addresses = new List();
> new PropertyModel(addresses, "[0]");
> model.getObject();
> Exception:
> java.lang.StringIndexOutOfBoundsException: String index out of range: 0
> at java.lang.String.charAt(String.java:687)
> at
> org.apache.wicket.util.lang.PropertyResolver.findGetter(PropertyResolver.java:509)
> at
> org.apache.wicket.util.lang.PropertyResolver.getGetAndSetter(PropertyResolver.java:338)
> at
> org.apache.wicket.util.lang.PropertyResolver.getObjectAndGetSetter(PropertyResolver.java:224)
> at
> org.apache.wicket.util.lang.PropertyResolver.getValue(PropertyResolver.java:91)
> at
> org.apache.wicket.model.AbstractPropertyModel.getObject(AbstractPropertyModel.java:113)
> I have attached a QuickStart (with 2 test; 1 with the current
> PropertyResolver and 1 with the patched PropertyResolver) and a patch file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2354) PropertyModel does not support index only property ("[0]")
[
https://issues.apache.org/jira/browse/WICKET-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hielke Hoeve updated WICKET-2354:
-
Attachment: wicket-bug2354.zip
The QuickStart project with 2 tests.
> PropertyModel does not support index only property ("[0]")
> --
>
> Key: WICKET-2354
> URL: https://issues.apache.org/jira/browse/WICKET-2354
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.3.6
> Environment: Windows XP, Eclipse 1.3.6, Java 1.6.0.13, Wicket 1.3.6
>Reporter: Hielke Hoeve
>Priority: Minor
> Attachments: wicket-bug2354.zip
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> When using a PropertyModel with a list as target and an index ("[0]") as
> property the PropertyModel cannot retreive the object from the list. When
> getObject() is called a IndexOutOfBoundsException is thrown.
> Example:
> List addresses = new List();
> new PropertyModel(addresses, "[0]");
> model.getObject();
> Exception:
> java.lang.StringIndexOutOfBoundsException: String index out of range: 0
> at java.lang.String.charAt(String.java:687)
> at
> org.apache.wicket.util.lang.PropertyResolver.findGetter(PropertyResolver.java:509)
> at
> org.apache.wicket.util.lang.PropertyResolver.getGetAndSetter(PropertyResolver.java:338)
> at
> org.apache.wicket.util.lang.PropertyResolver.getObjectAndGetSetter(PropertyResolver.java:224)
> at
> org.apache.wicket.util.lang.PropertyResolver.getValue(PropertyResolver.java:91)
> at
> org.apache.wicket.model.AbstractPropertyModel.getObject(AbstractPropertyModel.java:113)
> I have attached a QuickStart (with 2 test; 1 with the current
> PropertyResolver and 1 with the patched PropertyResolver) and a patch file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2354) PropertyModel does not support index only property ("[0]")
PropertyModel does not support index only property ("[0]")
--
Key: WICKET-2354
URL: https://issues.apache.org/jira/browse/WICKET-2354
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.3.6
Environment: Windows XP, Eclipse 1.3.6, Java 1.6.0.13, Wicket 1.3.6
Reporter: Hielke Hoeve
Priority: Minor
When using a PropertyModel with a list as target and an index ("[0]") as
property the PropertyModel cannot retreive the object from the list. When
getObject() is called a IndexOutOfBoundsException is thrown.
Example:
List addresses = new List();
new PropertyModel(addresses, "[0]");
model.getObject();
Exception:
java.lang.StringIndexOutOfBoundsException: String index out of range: 0
at java.lang.String.charAt(String.java:687)
at
org.apache.wicket.util.lang.PropertyResolver.findGetter(PropertyResolver.java:509)
at
org.apache.wicket.util.lang.PropertyResolver.getGetAndSetter(PropertyResolver.java:338)
at
org.apache.wicket.util.lang.PropertyResolver.getObjectAndGetSetter(PropertyResolver.java:224)
at
org.apache.wicket.util.lang.PropertyResolver.getValue(PropertyResolver.java:91)
at
org.apache.wicket.model.AbstractPropertyModel.getObject(AbstractPropertyModel.java:113)
I have attached a QuickStart (with 2 test; 1 with the current PropertyResolver
and 1 with the patched PropertyResolver) and a patch file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (WICKET-2168) TableTree.html is not XHTML valid
[ https://issues.apache.org/jira/browse/WICKET-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hielke Hoeve reopened WICKET-2168: -- > TableTree.html is not XHTML valid > - > > Key: WICKET-2168 > URL: https://issues.apache.org/jira/browse/WICKET-2168 > Project: Wicket > Issue Type: Improvement > Components: wicket-extensions >Affects Versions: 1.3.5 >Reporter: Hielke Hoeve >Assignee: Juergen Donnerstag >Priority: Trivial > Fix For: 1.4-RC3 > > Attachments: TreeTable.html.patch > > Original Estimate: 0.08h > Remaining Estimate: 0.08h > > TableTree.html is not valid XHTML 1.0 Strict markup. This due to a missing > "type" attribute. This is required and must be specified for element type > "script". > I have attached a patch for this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-2168) TableTree.html is not XHTML valid
[ https://issues.apache.org/jira/browse/WICKET-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706755#action_12706755 ] Hielke Hoeve edited comment on WICKET-2168 at 5/7/09 1:08 AM: -- Is it possible to commit this on 1.3 as well? It's a trivial issue, but it's bugging us on quite some pages. was (Author: hielkehoeve): Is it possible to commit this on 1.3 as well? It's quite a trivial issue, but it's bugging us on quite some pages. > TableTree.html is not XHTML valid > - > > Key: WICKET-2168 > URL: https://issues.apache.org/jira/browse/WICKET-2168 > Project: Wicket > Issue Type: Improvement > Components: wicket-extensions >Affects Versions: 1.3.5 >Reporter: Hielke Hoeve >Assignee: Juergen Donnerstag >Priority: Trivial > Fix For: 1.4-RC3 > > Attachments: TreeTable.html.patch > > Original Estimate: 0.08h > Remaining Estimate: 0.08h > > TableTree.html is not valid XHTML 1.0 Strict markup. This due to a missing > "type" attribute. This is required and must be specified for element type > "script". > I have attached a patch for this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2168) TableTree.html is not XHTML valid
[ https://issues.apache.org/jira/browse/WICKET-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706755#action_12706755 ] Hielke Hoeve commented on WICKET-2168: -- Is it possible to commit this on 1.3 as well? It's quite a trivial issue, but it's bugging us on quite some pages. > TableTree.html is not XHTML valid > - > > Key: WICKET-2168 > URL: https://issues.apache.org/jira/browse/WICKET-2168 > Project: Wicket > Issue Type: Improvement > Components: wicket-extensions >Affects Versions: 1.3.5 >Reporter: Hielke Hoeve >Assignee: Juergen Donnerstag >Priority: Trivial > Fix For: 1.4-RC3 > > Attachments: TreeTable.html.patch > > Original Estimate: 0.08h > Remaining Estimate: 0.08h > > TableTree.html is not valid XHTML 1.0 Strict markup. This due to a missing > "type" attribute. This is required and must be specified for element type > "script". > I have attached a patch for this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2168) TableTree.html is not XHTML valid
[ https://issues.apache.org/jira/browse/WICKET-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hielke Hoeve updated WICKET-2168: - Attachment: TreeTable.html.patch > TableTree.html is not XHTML valid > - > > Key: WICKET-2168 > URL: https://issues.apache.org/jira/browse/WICKET-2168 > Project: Wicket > Issue Type: Improvement > Components: wicket-extensions >Affects Versions: 1.3.5 >Reporter: Hielke Hoeve >Priority: Trivial > Attachments: TreeTable.html.patch > > Original Estimate: 0.08h > Remaining Estimate: 0.08h > > TableTree.html is not valid XHTML 1.0 Strict markup. This due to a missing > "type" attribute. This is required and must be specified for element type > "script". > I have attached a patch for this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2168) TableTree.html is not XHTML valid
TableTree.html is not XHTML valid - Key: WICKET-2168 URL: https://issues.apache.org/jira/browse/WICKET-2168 Project: Wicket Issue Type: Improvement Components: wicket-extensions Affects Versions: 1.3.5 Reporter: Hielke Hoeve Priority: Trivial Attachments: TreeTable.html.patch TableTree.html is not valid XHTML 1.0 Strict markup. This due to a missing "type" attribute. This is required and must be specified for element type "script". I have attached a patch for this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2160) application_nl.properties is outdated
[ https://issues.apache.org/jira/browse/WICKET-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hielke Hoeve updated WICKET-2160: - Attachment: application_nl.properties.patch > application_nl.properties is outdated > - > > Key: WICKET-2160 > URL: https://issues.apache.org/jira/browse/WICKET-2160 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.3.5 >Reporter: Hielke Hoeve >Priority: Trivial > Attachments: application_nl.properties.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > The application_nl.properties is a bit outdated. I have attached a patch file > that contains the diff betweeen application.properties and > application_nl.properties @ wicket 1.3.5. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2160) application_nl.properties is outdated
application_nl.properties is outdated - Key: WICKET-2160 URL: https://issues.apache.org/jira/browse/WICKET-2160 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.3.5 Reporter: Hielke Hoeve Priority: Trivial Attachments: application_nl.properties.patch The application_nl.properties is a bit outdated. I have attached a patch file that contains the diff betweeen application.properties and application_nl.properties @ wicket 1.3.5. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
