[jira] [Commented] (WICKET-5178) StopPropagation functionality on link is broken
[
https://issues.apache.org/jira/browse/WICKET-5178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13655933#comment-13655933
]
Sven Meier commented on WICKET-5178:
The fix works fine for me, thanks!
A minor nitpick:
Even if an event is throttled, _handleEventCancelation() should be called
nevertheless. Otherwise an event might trigger the default or bubble up because
the throttled execution is delayed.
---
a/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
+++
b/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
@@ -1797,13 +1797,12 @@
throttler.throttle(throttlingSettings.id, throttlingSettings.d,
Wicket.bind(function () {
call.ajax(attributes);
-
Wicket.Ajax._handleEventCancelation(attributes);
}, this));
}
else {
call.ajax(attributes);
-
Wicket.Ajax._handleEventCancelation(attributes);
}
+
Wicket.Ajax._handleEventCancelation(attributes);
});
});
},
StopPropagation functionality on link is broken
---
Key: WICKET-5178
URL: https://issues.apache.org/jira/browse/WICKET-5178
Project: Wicket
Issue Type: Bug
Affects Versions: 6.7.0
Reporter: Marieke Vandamme
Assignee: Martin Grigorov
Fix For: 6.8.0
Attachments: myproject.zip
In the quickstart I'll add the following is illustrated:
- simple table with AjaxLink on tr
- on that tr there's another AjaxLink with should not propagate the onclick
to the tr
- So when clicking the here link, on the server logging only the following
should appear:
* onclick LNK
but also the logging from the tr link is printed:
* onclick LNK
* onclick TR
In wicket 6.6 this works.
Thanks in advance ! Kind regards, Marieke
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-5178) StopPropagation functionality on link is broken
[ https://issues.apache.org/jira/browse/WICKET-5178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13651774#comment-13651774 ] Sven Haster commented on WICKET-5178: - Seconded. Please fix asap. This broke functionality in an important page for us and we would not like to have to revert to wicket 6.6 for production. StopPropagation functionality on link is broken --- Key: WICKET-5178 URL: https://issues.apache.org/jira/browse/WICKET-5178 Project: Wicket Issue Type: Bug Affects Versions: 6.7.0 Reporter: Marieke Vandamme Attachments: myproject.zip In the quickstart I'll add the following is illustrated: - simple table with AjaxLink on tr - on that tr there's another AjaxLink with should not propagate the onclick to the tr - So when clicking the here link, on the server logging only the following should appear: * onclick LNK but also the logging from the tr link is printed: * onclick LNK * onclick TR In wicket 6.6 this works. Thanks in advance ! Kind regards, Marieke -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-5178) StopPropagation functionality on link is broken
[ https://issues.apache.org/jira/browse/WICKET-5178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13651791#comment-13651791 ] Martin Grigorov commented on WICKET-5178: - It will be improved in 6.8.0. There is no need to revert to 6.6.0 for just this. There is explanation in WICKET-5093 how this can be handled. StopPropagation functionality on link is broken --- Key: WICKET-5178 URL: https://issues.apache.org/jira/browse/WICKET-5178 Project: Wicket Issue Type: Bug Affects Versions: 6.7.0 Reporter: Marieke Vandamme Fix For: 6.8.0 Attachments: myproject.zip In the quickstart I'll add the following is illustrated: - simple table with AjaxLink on tr - on that tr there's another AjaxLink with should not propagate the onclick to the tr - So when clicking the here link, on the server logging only the following should appear: * onclick LNK but also the logging from the tr link is printed: * onclick LNK * onclick TR In wicket 6.6 this works. Thanks in advance ! Kind regards, Marieke -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-5178) StopPropagation functionality on link is broken
[ https://issues.apache.org/jira/browse/WICKET-5178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13651853#comment-13651853 ] Martin Grigorov commented on WICKET-5178: - The new setting for AjaxRequestAttributes is added in master branch. Please have a look and let me know whether it fixes your problems. I'll test soon the attached quickstart with 6.x branch and backport the fix. StopPropagation functionality on link is broken --- Key: WICKET-5178 URL: https://issues.apache.org/jira/browse/WICKET-5178 Project: Wicket Issue Type: Bug Affects Versions: 6.7.0 Reporter: Marieke Vandamme Assignee: Martin Grigorov Fix For: 6.8.0 Attachments: myproject.zip In the quickstart I'll add the following is illustrated: - simple table with AjaxLink on tr - on that tr there's another AjaxLink with should not propagate the onclick to the tr - So when clicking the here link, on the server logging only the following should appear: * onclick LNK but also the logging from the tr link is printed: * onclick LNK * onclick TR In wicket 6.6 this works. Thanks in advance ! Kind regards, Marieke -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-5178) StopPropagation functionality on link is broken
[
https://issues.apache.org/jira/browse/WICKET-5178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13651878#comment-13651878
]
Sven Meier commented on WICKET-5178:
Hi Martin,
now allowDefault and stopPropagation are coupled once again, since you return
false from the function:
var handleStopPropagation = function
(attributes) {
var result = false;
var evt = attributes.event;
if (attributes.sp === stop) {
Wicket.Event.stop(evt);
} else if (attributes.sp ===
stopImmediate) {
Wicket.Event.stop(evt, true);
} else {
result = true;
}
return result;
};
Is that you intention?
StopPropagation functionality on link is broken
---
Key: WICKET-5178
URL: https://issues.apache.org/jira/browse/WICKET-5178
Project: Wicket
Issue Type: Bug
Affects Versions: 6.7.0
Reporter: Marieke Vandamme
Assignee: Martin Grigorov
Fix For: 6.8.0
Attachments: myproject.zip
In the quickstart I'll add the following is illustrated:
- simple table with AjaxLink on tr
- on that tr there's another AjaxLink with should not propagate the onclick
to the tr
- So when clicking the here link, on the server logging only the following
should appear:
* onclick LNK
but also the logging from the tr link is printed:
* onclick LNK
* onclick TR
In wicket 6.6 this works.
Thanks in advance ! Kind regards, Marieke
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-5178) StopPropagation functionality on link is broken
[ https://issues.apache.org/jira/browse/WICKET-5178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13651884#comment-13651884 ] Martin Grigorov commented on WICKET-5178: - I just improved it. Now they are separated. StopPropagation functionality on link is broken --- Key: WICKET-5178 URL: https://issues.apache.org/jira/browse/WICKET-5178 Project: Wicket Issue Type: Bug Affects Versions: 6.7.0 Reporter: Marieke Vandamme Assignee: Martin Grigorov Fix For: 6.8.0 Attachments: myproject.zip In the quickstart I'll add the following is illustrated: - simple table with AjaxLink on tr - on that tr there's another AjaxLink with should not propagate the onclick to the tr - So when clicking the here link, on the server logging only the following should appear: * onclick LNK but also the logging from the tr link is printed: * onclick LNK * onclick TR In wicket 6.6 this works. Thanks in advance ! Kind regards, Marieke -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-5178) StopPropagation functionality on link is broken
[ https://issues.apache.org/jira/browse/WICKET-5178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13651898#comment-13651898 ] Sven Meier commented on WICKET-5178: Separated but still not a fix for WICKET-5093: A delayed ajax call will call _handleEventCancelation() too late to have any effect on the browser's event processing :(. StopPropagation functionality on link is broken --- Key: WICKET-5178 URL: https://issues.apache.org/jira/browse/WICKET-5178 Project: Wicket Issue Type: Bug Affects Versions: 6.7.0 Reporter: Marieke Vandamme Assignee: Martin Grigorov Fix For: 6.8.0 Attachments: myproject.zip In the quickstart I'll add the following is illustrated: - simple table with AjaxLink on tr - on that tr there's another AjaxLink with should not propagate the onclick to the tr - So when clicking the here link, on the server logging only the following should appear: * onclick LNK but also the logging from the tr link is printed: * onclick LNK * onclick TR In wicket 6.6 this works. Thanks in advance ! Kind regards, Marieke -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-5178) StopPropagation functionality on link is broken
[ https://issues.apache.org/jira/browse/WICKET-5178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13651902#comment-13651902 ] Martin Grigorov commented on WICKET-5178: - OK, I'll move back the W.E.stop() call in Wicket.Ajax.ajax(), without the return which messes with #preventDefault(). I don't have time now to properly test your quickstart but I think it is possible to solve the problem with the new setting. StopPropagation functionality on link is broken --- Key: WICKET-5178 URL: https://issues.apache.org/jira/browse/WICKET-5178 Project: Wicket Issue Type: Bug Affects Versions: 6.7.0 Reporter: Marieke Vandamme Assignee: Martin Grigorov Fix For: 6.8.0 Attachments: myproject.zip In the quickstart I'll add the following is illustrated: - simple table with AjaxLink on tr - on that tr there's another AjaxLink with should not propagate the onclick to the tr - So when clicking the here link, on the server logging only the following should appear: * onclick LNK but also the logging from the tr link is printed: * onclick LNK * onclick TR In wicket 6.6 this works. Thanks in advance ! Kind regards, Marieke -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-5178) StopPropagation functionality on link is broken
[ https://issues.apache.org/jira/browse/WICKET-5178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13651933#comment-13651933 ] Sven Meier commented on WICKET-5178: Both preventDefault and stopPropagation have to be handled in Wicket.Ajax.ajax() before the call is possibly queued by the channel. Why not call _handleEventCancelation() from there? StopPropagation functionality on link is broken --- Key: WICKET-5178 URL: https://issues.apache.org/jira/browse/WICKET-5178 Project: Wicket Issue Type: Bug Affects Versions: 6.7.0 Reporter: Marieke Vandamme Assignee: Martin Grigorov Fix For: 6.8.0 Attachments: myproject.zip In the quickstart I'll add the following is illustrated: - simple table with AjaxLink on tr - on that tr there's another AjaxLink with should not propagate the onclick to the tr - So when clicking the here link, on the server logging only the following should appear: * onclick LNK but also the logging from the tr link is printed: * onclick LNK * onclick TR In wicket 6.6 this works. Thanks in advance ! Kind regards, Marieke -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-5178) StopPropagation functionality on link is broken
[
https://issues.apache.org/jira/browse/WICKET-5178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13652000#comment-13652000
]
Igor Vaynberg commented on WICKET-5178:
---
on a side note please rename StopPropagation to Propagation {BUBBLE, STOP,
STOP_IMMEDIATELY}. reading StopPropagation.NO makes my head assplode :)
StopPropagation functionality on link is broken
---
Key: WICKET-5178
URL: https://issues.apache.org/jira/browse/WICKET-5178
Project: Wicket
Issue Type: Bug
Affects Versions: 6.7.0
Reporter: Marieke Vandamme
Assignee: Martin Grigorov
Fix For: 6.8.0
Attachments: myproject.zip
In the quickstart I'll add the following is illustrated:
- simple table with AjaxLink on tr
- on that tr there's another AjaxLink with should not propagate the onclick
to the tr
- So when clicking the here link, on the server logging only the following
should appear:
* onclick LNK
but also the logging from the tr link is printed:
* onclick LNK
* onclick TR
In wicket 6.6 this works.
Thanks in advance ! Kind regards, Marieke
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-5178) StopPropagation functionality on link is broken
[ https://issues.apache.org/jira/browse/WICKET-5178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13648275#comment-13648275 ] Martin Grigorov commented on WICKET-5178: - The change for 6.7 was intentional - WICKET-5093. AjaxRequestAttributes has a setting allowDefault which managed both JS event's preventDefault and stopPropagation. It was a bug that it handled stopPropagation. Maybe we should add a separate setting for stop propagation in AjaxRequestAttributes. StopPropagation functionality on link is broken --- Key: WICKET-5178 URL: https://issues.apache.org/jira/browse/WICKET-5178 Project: Wicket Issue Type: Bug Affects Versions: 6.7.0 Reporter: Marieke Vandamme Attachments: myproject.zip In the quickstart I'll add the following is illustrated: - simple table with AjaxLink on tr - on that tr there's another AjaxLink with should not propagate the onclick to the tr - So when clicking the here link, on the server logging only the following should appear: * onclick LNK but also the logging from the tr link is printed: * onclick LNK * onclick TR In wicket 6.6 this works. Thanks in advance ! Kind regards, Marieke -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-5178) StopPropagation functionality on link is broken
[ https://issues.apache.org/jira/browse/WICKET-5178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13648282#comment-13648282 ] Sven Meier commented on WICKET-5178: An additional setting for stop propagation would be nice, Java devs don't want to write Wicket.Event.stop(attrs.event). We could make that setting true by default, to make this change compatible with the previous behavior. StopPropagation functionality on link is broken --- Key: WICKET-5178 URL: https://issues.apache.org/jira/browse/WICKET-5178 Project: Wicket Issue Type: Bug Affects Versions: 6.7.0 Reporter: Marieke Vandamme Attachments: myproject.zip In the quickstart I'll add the following is illustrated: - simple table with AjaxLink on tr - on that tr there's another AjaxLink with should not propagate the onclick to the tr - So when clicking the here link, on the server logging only the following should appear: * onclick LNK but also the logging from the tr link is printed: * onclick LNK * onclick TR In wicket 6.6 this works. Thanks in advance ! Kind regards, Marieke -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-5178) StopPropagation functionality on link is broken
[ https://issues.apache.org/jira/browse/WICKET-5178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13648284#comment-13648284 ] Martin Grigorov commented on WICKET-5178: - Agree. StopPropagation functionality on link is broken --- Key: WICKET-5178 URL: https://issues.apache.org/jira/browse/WICKET-5178 Project: Wicket Issue Type: Bug Affects Versions: 6.7.0 Reporter: Marieke Vandamme Attachments: myproject.zip In the quickstart I'll add the following is illustrated: - simple table with AjaxLink on tr - on that tr there's another AjaxLink with should not propagate the onclick to the tr - So when clicking the here link, on the server logging only the following should appear: * onclick LNK but also the logging from the tr link is printed: * onclick LNK * onclick TR In wicket 6.6 this works. Thanks in advance ! Kind regards, Marieke -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
