[jira] Commented: (WICKET-2137) Synchronize generics between ListView and DropDownChoice
[ https://issues.apache.org/jira/browse/WICKET-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681622#action_12681622 ] James Carman commented on WICKET-2137: -- The problem was that some of the classes that I had changed (that would have fixed the errors) didn't get included in the patch because I created my patch from a specific "change list" in IDEA. I was working on patches for multiple issues today and I just got a bit confused (blame it on the bronchitis). I'm developing against trunk, so I hope I'm in sync. > Synchronize generics between ListView and DropDownChoice > > > Key: WICKET-2137 > URL: https://issues.apache.org/jira/browse/WICKET-2137 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.4-RC3 > Environment: 1.4-SNAPSHOT as of 2009-01-28 >Reporter: Brill Pappin > Attachments: TestGenerics.java > > > DropDownChoice has a generics definition of List in its > constructor. > This causes trouble with existing models that may be used in a DropDownChoice > and is not consistant with ListView which uses >. > Change DropDownChoice to match the other list type components so that their > models can be used across components. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2137) Synchronize generics between ListView and DropDownChoice
[ https://issues.apache.org/jira/browse/WICKET-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681619#action_12681619 ] Brill Pappin commented on WICKET-2137: -- Oh i agree, I want it is fixed one way or another. Funny your not seeing all those error that were mentioned, but then patching is actually a pain unless everyone doing it is in sync :) Lets give them a bit of time to review and do their dev thing. > Synchronize generics between ListView and DropDownChoice > > > Key: WICKET-2137 > URL: https://issues.apache.org/jira/browse/WICKET-2137 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.4-RC3 > Environment: 1.4-SNAPSHOT as of 2009-01-28 >Reporter: Brill Pappin > Attachments: TestGenerics.java > > > DropDownChoice has a generics definition of List in its > constructor. > This causes trouble with existing models that may be used in a DropDownChoice > and is not consistant with ListView which uses >. > Change DropDownChoice to match the other list type components so that their > models can be used across components. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2137) Synchronize generics between ListView and DropDownChoice
[ https://issues.apache.org/jira/browse/WICKET-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681605#action_12681605 ] James Carman commented on WICKET-2137: -- Well, Brill, that's just the thing. In my IDE right now (I'm working on my patch), I haven't changed one test class at all. The existing test code works with the new API with no changes. All I've done is change some variable/parameter types here and there (there's a weird cast in ListView's . I don't think you want to release the "genericized wicket" version (which is what 1.4 is supposed to be) without getting the generics "right." > Synchronize generics between ListView and DropDownChoice > > > Key: WICKET-2137 > URL: https://issues.apache.org/jira/browse/WICKET-2137 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.4-RC3 > Environment: 1.4-SNAPSHOT as of 2009-01-28 >Reporter: Brill Pappin > Attachments: TestGenerics.java > > > DropDownChoice has a generics definition of List in its > constructor. > This causes trouble with existing models that may be used in a DropDownChoice > and is not consistant with ListView which uses >. > Change DropDownChoice to match the other list type components so that their > models can be used across components. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2137) Synchronize generics between ListView and DropDownChoice
[ https://issues.apache.org/jira/browse/WICKET-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681604#action_12681604 ] Brill Pappin commented on WICKET-2137: -- I have to say that if its easier to regress the generics to the List version, then I think we should do that before 1.4 release... if as is thought there the longer form is better and doesn't break code that uses the short form, then we can add it after the 1.4 release. That doesn't me we should choose one or the other now, I'm just interested in the least possible change to make it right as the committers roll around to releasing 1.4 (i think its essential that this get into the release). As someone pointed out, we're in rc3 or rc4 now, so even the simplest change of this sort is going to force people to do some fixing (better now than later though). So, whoever has to handle this issue, please make a choice for what ever is the least hassle and bring the two components into sync. > Synchronize generics between ListView and DropDownChoice > > > Key: WICKET-2137 > URL: https://issues.apache.org/jira/browse/WICKET-2137 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.4-RC3 > Environment: 1.4-SNAPSHOT as of 2009-01-28 >Reporter: Brill Pappin > Attachments: TestGenerics.java > > > DropDownChoice has a generics definition of List in its > constructor. > This causes trouble with existing models that may be used in a DropDownChoice > and is not consistant with ListView which uses >. > Change DropDownChoice to match the other list type components so that their > models can be used across components. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2137) Synchronize generics between ListView and DropDownChoice
[ https://issues.apache.org/jira/browse/WICKET-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681600#action_12681600 ] James Carman commented on WICKET-2137: -- I've deleted my patch. I guess I didn't have all the necessary files in my "change list" in IDEA for this issue. Sorry for the mix-up. However, I'm working on a more pervasive change to the API that changes *all* instances where we have these issues to adhere to my proposal (the more I kept pulling, the more I had to change!). I'm going to create another issue and attach my patch there. If the core devs don't like my API change ideas, they can scrap it. I will also send an email to the users list asking for feedback on the proposed changes. I understand that my proposal doesn't exactly match what folks voted on, but I don't think all of the options were on the table at the time and the most vocal folks seemed to agree with my idea. Again, Jeremy, sorry for giving you a bad patch and wasting your time. That was totally my bad. > Synchronize generics between ListView and DropDownChoice > > > Key: WICKET-2137 > URL: https://issues.apache.org/jira/browse/WICKET-2137 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.4-RC3 > Environment: 1.4-SNAPSHOT as of 2009-01-28 >Reporter: Brill Pappin > Attachments: TestGenerics.java > > > DropDownChoice has a generics definition of List in its > constructor. > This causes trouble with existing models that may be used in a DropDownChoice > and is not consistant with ListView which uses >. > Change DropDownChoice to match the other list type components so that their > models can be used across components. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2137) Synchronize generics between ListView and DropDownChoice
[ https://issues.apache.org/jira/browse/WICKET-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681464#action_12681464 ] Jeremy Thomerson commented on WICKET-2137: -- I reviewed the attached patch and supplied these comments on the mailing list: Unless I'm seeing double - this patch has two problems: 1 - It is the opposite of what was voted on. The vote was to make IModel> into IModel>. Your patch makes it IModel>. 2 - The patch causes compile errors that were not fixed. I have unassigned myself from the task until those issues are addressed or I have time to create my own patch. The best solution would be for someone to submit a proper patch that fixes the two problems above or explain to me what I missed. Thanks! > Synchronize generics between ListView and DropDownChoice > > > Key: WICKET-2137 > URL: https://issues.apache.org/jira/browse/WICKET-2137 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.4-RC3 > Environment: 1.4-SNAPSHOT as of 2009-01-28 >Reporter: Brill Pappin > Attachments: TestGenerics.java, WICKET-2137.patch > > > DropDownChoice has a generics definition of List in its > constructor. > This causes trouble with existing models that may be used in a DropDownChoice > and is not consistant with ListView which uses >. > Change DropDownChoice to match the other list type components so that their > models can be used across components. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2137) Synchronize generics between ListView and DropDownChoice
[ https://issues.apache.org/jira/browse/WICKET-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679233#action_12679233 ] James Carman commented on WICKET-2137: -- That sounds like a better approach. Good idea! > Synchronize generics between ListView and DropDownChoice > > > Key: WICKET-2137 > URL: https://issues.apache.org/jira/browse/WICKET-2137 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.4-RC3 > Environment: 1.4-SNAPSHOT as of 2009-01-28 >Reporter: Brill Pappin > Attachments: TestGenerics.java > > > DropDownChoice has a generics definition of List in its > constructor. > This causes trouble with existing models that may be used in a DropDownChoice > and is not consistant with ListView which uses >. > Change DropDownChoice to match the other list type components so that their > models can be used across components. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
