[jira] Commented: (WICKET-3354) Improve SerializableChecker message
[ https://issues.apache.org/jira/browse/WICKET-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984159#action_12984159 ] Martin Grigorov commented on WICKET-3354: - The patch looks ok. 'loggerAdapter' variable in the test seems unused. The log assertion logic looks nice. It would be nice to introduce BaseWicketTester.assertLogMessage(level, messageText) but this will work only if all this can be done with slf4j-api, otherwise we will introduce dependency to specific logging framework .. > Improve SerializableChecker message > --- > > Key: WICKET-3354 > URL: https://issues.apache.org/jira/browse/WICKET-3354 > Project: Wicket > Issue Type: Improvement >Affects Versions: 1.4.15, 1.5-M3 >Reporter: Pedro Santos >Priority: Minor > Attachments: WICKET-3354.patch > > > Currently if the object has an problematic implementation of equals method, > the serializable checker will stop its work with an runtime exception. The > best would be just log an warn explaining the the problem on console and > continue the checks until the non serializable source of the problem. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3354) Improve SerializableChecker message
[ https://issues.apache.org/jira/browse/WICKET-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984193#action_12984193 ] Martin Grigorov commented on WICKET-3354: - We use slf4j-api in Wicket. The user application provides the actual logging implementation (log4j, logback, jul, ...). That's why we can't use Log4j classes in core. > Improve SerializableChecker message > --- > > Key: WICKET-3354 > URL: https://issues.apache.org/jira/browse/WICKET-3354 > Project: Wicket > Issue Type: Improvement >Affects Versions: 1.4.15, 1.5-M3 >Reporter: Pedro Santos >Priority: Minor > Attachments: WICKET-3354-2.patch, WICKET-3354.patch > > > Currently if the object has an problematic implementation of equals method, > the serializable checker will stop its work with an runtime exception. The > best would be just log an warn explaining the the problem on console and > continue the checks until the non serializable source of the problem. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3354) Improve SerializableChecker message
[ https://issues.apache.org/jira/browse/WICKET-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984200#action_12984200 ] Pedro Santos commented on WICKET-3354: -- I know, but do test cases get distributed? Log4j is an wicket-parent dependency, it will be available when running test cases. I guess using it under src/test/java is fine, right? > Improve SerializableChecker message > --- > > Key: WICKET-3354 > URL: https://issues.apache.org/jira/browse/WICKET-3354 > Project: Wicket > Issue Type: Improvement >Affects Versions: 1.4.15, 1.5-M3 >Reporter: Pedro Santos >Priority: Minor > Attachments: WICKET-3354-2.patch, WICKET-3354.patch > > > Currently if the object has an problematic implementation of equals method, > the serializable checker will stop its work with an runtime exception. The > best would be just log an warn explaining the the problem on console and > continue the checks until the non serializable source of the problem. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3354) Improve SerializableChecker message
[ https://issues.apache.org/jira/browse/WICKET-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985713#action_12985713 ] Martin Grigorov commented on WICKET-3354: - Sorry. I didn't mean that you cannot use log4j in our tests. With my first comment I said that it would be good to have BaseWicketTester.assertLogMessage() method which can be used by Wicket's users but unfortunately we cannot depend on log4j in BaseWicketTester (because it is in wicket-core). You can depend on log4j in wicket-core/src/test/**. Sorry again for the confusion. > Improve SerializableChecker message > --- > > Key: WICKET-3354 > URL: https://issues.apache.org/jira/browse/WICKET-3354 > Project: Wicket > Issue Type: Improvement >Affects Versions: 1.4.15, 1.5-M3 >Reporter: Pedro Santos >Priority: Minor > Attachments: WICKET-3354-2.patch, WICKET-3354-3.patch, > WICKET-3354.patch > > > Currently if the object has an problematic implementation of equals method, > the serializable checker will stop its work with an runtime exception. The > best would be just log an warn explaining the the problem on console and > continue the checks until the non serializable source of the problem. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3354) Improve SerializableChecker message
[ https://issues.apache.org/jira/browse/WICKET-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985819#action_12985819 ] Hudson commented on WICKET-3354: Integrated in Apache Wicket 1.4.x #399 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/399/]) changing the SerializableChecker to catch runtime exceptions while scanning fields Issue: WICKET-3354 > Improve SerializableChecker message > --- > > Key: WICKET-3354 > URL: https://issues.apache.org/jira/browse/WICKET-3354 > Project: Wicket > Issue Type: Improvement >Affects Versions: 1.4.15, 1.5-M3 >Reporter: Pedro Santos >Assignee: Pedro Santos >Priority: Minor > Fix For: 1.4.16, 1.5-RC2 > > Attachments: WICKET-3354-2.patch, WICKET-3354-3.patch, > WICKET-3354.patch > > > Currently if the object has an problematic implementation of equals method, > the serializable checker will stop its work with an runtime exception. The > best would be just log an warn explaining the the problem on console and > continue the checks until the non serializable source of the problem. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
