[GitHub] [hadoop-thirdparty] ayushtkn commented on a change in pull request #8: HADOOP-17278. Shade guava 27.0-jre in hadoop thirdparty.

2020-09-22 Thread GitBox 


ayushtkn commented on a change in pull request #8:
URL: https://github.com/apache/hadoop-thirdparty/pull/8#discussion_r492440814



##
File path: hadoop-shaded-guava/pom.xml
##
@@ -0,0 +1,125 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+hadoop-thirdparty
+org.apache.hadoop.thirdparty
+1.1.0-SNAPSHOT
+..
+
+4.0.0
+hadoop-shaded-guava
+Apache Hadoop shaded Guava
+jar
+
+
+
+com.google.guava
+guava
+${guava.version}
+

Review comment:
   I excluded these following the way hbase did it, so that they can be 
directly added to the project.
   
   Ref - 
[jira](https://issues.apache.org/jira/browse/HBASE-22130?focusedCommentId=16805574=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16805574)
   
[hbase-thirdpary](https://github.com/apache/hbase-thirdparty/blob/master/hbase-shaded-miscellaneous/pom.xml#L130)
   
   But I think, we can avoid excluding them and remove the exclusions block. if 
anything required to get excluded, that can be done when adding this as 
dependency in the main project. Thoughts?

##
File path: hadoop-shaded-guava/pom.xml
##
@@ -0,0 +1,125 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+hadoop-thirdparty
+org.apache.hadoop.thirdparty
+1.1.0-SNAPSHOT
+..
+
+4.0.0
+hadoop-shaded-guava
+Apache Hadoop shaded Guava
+jar
+
+
+
+com.google.guava
+guava
+${guava.version}
+

Review comment:
   I excluded these following the way hbase did it, so that they can be 
directly added to the project.
   
   Ref - 
[jira](https://issues.apache.org/jira/browse/HBASE-22130?focusedCommentId=16805574=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16805574)
   
[hbase-thirdpary](https://github.com/apache/hbase-thirdparty/blob/master/hbase-shaded-miscellaneous/pom.xml#L130)
   
   But I think, we can avoid excluding them and remove the exclusions 
block.There is no harm, if they are not excluded IMO. I have pushed a change 
removing the exclusions, let me know if that makes sense





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] ayushtkn commented on a change in pull request #8: HADOOP-17278. Shade guava 27.0-jre in hadoop thirdparty.

2020-09-21 Thread GitBox 


ayushtkn commented on a change in pull request #8:
URL: https://github.com/apache/hadoop-thirdparty/pull/8#discussion_r492300681



##
File path: pom.xml
##
@@ -95,6 +95,7 @@
 org.apache.hadoop.thirdparty
 ${shaded.prefix}.protobuf
 3.7.1
+27.0-jre

Review comment:
   upgraded to 29.0-jre

##
File path: hadoop-shaded-guava/pom.xml
##
@@ -0,0 +1,125 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+hadoop-thirdparty
+org.apache.hadoop.thirdparty
+1.1.0-SNAPSHOT
+..
+
+4.0.0
+hadoop-shaded-guava
+Apache Hadoop shaded Guava
+jar
+
+
+
+com.google.guava
+guava
+${guava.version}
+

Review comment:
   I excluded these following the way hbase did it, so that they can be 
directly added to the project.
   
   Ref - 
[jira](https://issues.apache.org/jira/browse/HBASE-22130?focusedCommentId=16805574=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16805574)
   
[hbase-thirdpary](https://github.com/apache/hbase-thirdparty/blob/master/hbase-shaded-miscellaneous/pom.xml#L130)
   
   But I think, we can avoid excluding them and remove the exclusions block. if 
anything required to get excluded, that can be done when adding this as 
dependency in the main project. Thoughts?

##
File path: hadoop-shaded-guava/pom.xml
##
@@ -0,0 +1,125 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+hadoop-thirdparty
+org.apache.hadoop.thirdparty
+1.1.0-SNAPSHOT
+..
+
+4.0.0
+hadoop-shaded-guava
+Apache Hadoop shaded Guava
+jar
+
+
+
+com.google.guava
+guava
+${guava.version}
+

Review comment:
   I excluded these following the way hbase did it, so that they can be 
directly added to the project.
   
   Ref - 
[jira](https://issues.apache.org/jira/browse/HBASE-22130?focusedCommentId=16805574=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16805574)
   
[hbase-thirdpary](https://github.com/apache/hbase-thirdparty/blob/master/hbase-shaded-miscellaneous/pom.xml#L130)
   
   But I think, we can avoid excluding them and remove the exclusions 
block.There is no harm, if they are not excluded IMO. I have pushed a change 
removing the exclusions, let me know if that makes sense





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] ayushtkn commented on a change in pull request #8: HADOOP-17278. Shade guava 27.0-jre in hadoop thirdparty.

2020-09-21 Thread GitBox 


ayushtkn commented on a change in pull request #8:
URL: https://github.com/apache/hadoop-thirdparty/pull/8#discussion_r492440814



##
File path: hadoop-shaded-guava/pom.xml
##
@@ -0,0 +1,125 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+hadoop-thirdparty
+org.apache.hadoop.thirdparty
+1.1.0-SNAPSHOT
+..
+
+4.0.0
+hadoop-shaded-guava
+Apache Hadoop shaded Guava
+jar
+
+
+
+com.google.guava
+guava
+${guava.version}
+

Review comment:
   I excluded these following the way hbase did it, so that they can be 
directly added to the project.
   
   Ref - 
[jira](https://issues.apache.org/jira/browse/HBASE-22130?focusedCommentId=16805574=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16805574)
   
[hbase-thirdpary](https://github.com/apache/hbase-thirdparty/blob/master/hbase-shaded-miscellaneous/pom.xml#L130)
   
   But I think, we can avoid excluding them and remove the exclusions 
block.There is no harm, if they are not excluded IMO. I have pushed a change 
removing the exclusions, let me know if that makes sense





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] ayushtkn commented on a change in pull request #8: HADOOP-17278. Shade guava 27.0-jre in hadoop thirdparty.

2020-09-21 Thread GitBox 


ayushtkn commented on a change in pull request #8:
URL: https://github.com/apache/hadoop-thirdparty/pull/8#discussion_r492440814



##
File path: hadoop-shaded-guava/pom.xml
##
@@ -0,0 +1,125 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+hadoop-thirdparty
+org.apache.hadoop.thirdparty
+1.1.0-SNAPSHOT
+..
+
+4.0.0
+hadoop-shaded-guava
+Apache Hadoop shaded Guava
+jar
+
+
+
+com.google.guava
+guava
+${guava.version}
+

Review comment:
   I excluded these following the way hbase did it, so that they can be 
directly added to the project.
   
   Ref - 
[jira](https://issues.apache.org/jira/browse/HBASE-22130?focusedCommentId=16805574=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16805574)
   
[hbase-thirdpary](https://github.com/apache/hbase-thirdparty/blob/master/hbase-shaded-miscellaneous/pom.xml#L130)
   
   But I think, we can avoid excluding them and remove the exclusions block. if 
anything required to get excluded, that can be done when adding this as 
dependency in the main project. Thoughts?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

[GitHub] [hadoop-thirdparty] ayushtkn commented on a change in pull request #8: HADOOP-17278. Shade guava 27.0-jre in hadoop thirdparty.

2020-09-21 Thread GitBox 


ayushtkn commented on a change in pull request #8:
URL: https://github.com/apache/hadoop-thirdparty/pull/8#discussion_r492300681



##
File path: pom.xml
##
@@ -95,6 +95,7 @@
 org.apache.hadoop.thirdparty
 ${shaded.prefix}.protobuf
 3.7.1
+27.0-jre

Review comment:
   upgraded to 29.0-jre





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org