Thanx Mingliang Liu for starting the thread. I don't have a strong opinion
neither in favour nor against. You have already highlighted the other side,
just pointing out a couple of more facts.
Ideally we have three options that I am aware of:
- The Existing stuff: have these PR comments as part of the Jira
- Have them as part of the WorkLog, everything remains the same but
those comments will come as part of worklog in the Jira, shoot mails and
all similarly with extra time tracking getting enabled, which triggers some
extra mails.
- Completely disable this, Just a link to the PR on the Jira and nothing
else.
I guess you are mostly proposing the third option, Agree to your points
that it is noise, especially the QA reports on the Jira(but I am not aware
of any filtering logic as of now), Sharing some advantages of having the
comments on the Jira.
- Jira Summary has everything: We can see what all is happening at one
place. https://issues.apache.org/jira/projects/HDFS/summary
- Sometime there is too much hopping by folks, Comments on Jira, then a
PR is raised, that fails, more discussion on Jira, a new PR and similar
stuff. So, those comments allows to track everything and get context at the
same place. Can just read the Jira comments without hopping Jira->PR->Jira
and stuffs like that.
- The Linking logic: We usually link only Jira's, like related to,
breaks, and similar stuff, so while tracking those Jiras, we are good with
just Jira, no need to go to the PR, come back and follow the relation
chain. Unless you want to see the code also.
- The Watcher logic: If a jira is raised, and I put myself in the
watcher list, I get all the comments and get to know whatever is happening
like the old days when we used to have patches.
There would be more advantages and obviously more disadvantages as well.
Happy to go whichever way everyone feels good.
-Ayush
On Wed, 4 Jan 2023 at 11:57, Xing Lin wrote:
> If we could get rid of hadoop-yetus reports in jira, that would be great.
> These reports tend to be long and take all the spaces.
>
> No strong opinion regarding disabling actual comments made by humans.
>
> On Tue, Jan 3, 2023 at 3:06 PM Mingliang Liu wrote:
>
> > Hi all,
> >
> > I find for any new comment on a pull request (PR), it will get
> auto-posted
> > to the JIRA as comments. As we are moving to GitHub for code reviews, the
> > JIRA is more about the problem definition, discussion on solution and
> > design. Comments happening in the PR are likely scoped to the
> > implementation and can become stale quickly. Auto-posting those comments
> > back to JIRA makes the JIRA too verbose.
> >
> > I propose we disable this auto-posting along with the QA report by
> > GitHub bot. The comment section in JIRA will be more concise and easier
> to
> > revisit.
> >
> > Thoughts?
> >
>
