[jira] [Commented] (HADOOP-11820) aw jira testing, ignore

2015-04-09 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14488072#comment-14488072
 ] 

Hadoop QA commented on HADOOP-11820:


\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 08m 46s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author | 00m 00s | The patch does not contain any 
@author tags. |
| {color:red}-1{color} | tests included | 00m 00s | The patch doesn't appear to 
include any new or modified tests.  Please justify why no new tests are needed 
for this patch. Also please list what manual steps were performed to verify 
this patch. |
| {color:red}-1{color} | whitespace | 00m 00s | The patch has 1  line(s) that 
end in whitespace. |
| {color:green}+1{color} | javac | 04m 07s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc | 05m 36s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit | 00m 11s | The applied patch does not 
increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 03m 23s | There were no new checkstyle 
issues. |
| {color:green}+1{color} | install | 01m 00s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 00m 23s | The patch built with 
eclipse:eclipse. |
| {color:red}-1{color} | core tests | 01m 21s | Tests failed in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common. |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.yarn.util.TestLog4jWarningErrorMetricsAppender |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12724302/MAPREDUCE-6301-002.patch
 |
| Optional Tests | javadoc javac unit checkstyle |
| git revision | f4b3fc5 / trunk |
| whitespace | /artifact/patchprocess/whitespace.txt |
| hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common test log | 
/artifact/patchprocess/testrun_hadoop-yarn-common.txt |
| Test Results | /testReport/ |
| Console output | /artifact/patchprocess/console |


This message was automatically generated.

 aw jira testing, ignore
 ---

 Key: HADOOP-11820
 URL: https://issues.apache.org/jira/browse/HADOOP-11820
 Project: Hadoop Common
  Issue Type: Task
Reporter: Allen Wittenauer
 Attachments: HADOOP-11746-13.patch, MAPREDUCE-6301-002.patch, 
 apache-yarn-3348.5.patch






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-11815) HttpServer2 should destroy SignerSecretProvider when it stops

2015-04-09 Thread Haohui Mai (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Haohui Mai updated HADOOP-11815:

   Resolution: Fixed
Fix Version/s: 2.7.0
 Hadoop Flags: Reviewed
   Status: Resolved  (was: Patch Available)

I've committed the patch to trunk, branch-2 and branch-2.7. Thanks 
[~rohithsharma] for the contribution.

 HttpServer2 should destroy SignerSecretProvider when it stops
 -

 Key: HADOOP-11815
 URL: https://issues.apache.org/jira/browse/HADOOP-11815
 Project: Hadoop Common
  Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Rohith
Assignee: Rohith
Priority: Blocker
 Fix For: 2.7.0

 Attachments: 0001-HADOOP-11815.patch, 0001-MAPREDUCE-6311.patch, 
 0001-MAPREDUCE-6311.patch, MR_TD.out


 It is observed that MRAppMaster JVM hungs after unregistered with 
 ResourceManager.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (HADOOP-11818) Minor improvements for erasurecode classes

2015-04-09 Thread Kai Zheng (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kai Zheng resolved HADOOP-11818.

   Resolution: Fixed
Fix Version/s: HDFS-7285
 Hadoop Flags: Reviewed

 Minor improvements for erasurecode classes
 --

 Key: HADOOP-11818
 URL: https://issues.apache.org/jira/browse/HADOOP-11818
 Project: Hadoop Common
  Issue Type: Sub-task
  Components: io
Reporter: Rakesh R
Assignee: Rakesh R
 Fix For: HDFS-7285

 Attachments: HADOOP-11818-001.patch, HADOOP-11818-002.patch


 Following are few observations while going through the {{erasurecode}} 
 classes.
 \\
 - Use {{org.slf4j.Logger}} instead of {{org.apache.commons.logging.Log}}
 - {{RSErasureDecoder}}, {{RSErasureEncoder}}, {{RSUtil}} missing Apache 
 License header.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (HADOOP-11816) Remove Apache Xerces dependency

2015-04-09 Thread Brahma Reddy Battula (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brahma Reddy Battula reassigned HADOOP-11816:
-

Assignee: Brahma Reddy Battula

 Remove Apache Xerces dependency
 ---

 Key: HADOOP-11816
 URL: https://issues.apache.org/jira/browse/HADOOP-11816
 Project: Hadoop Common
  Issue Type: Improvement
  Components: build
Reporter: Akira AJISAKA
Assignee: Brahma Reddy Battula
  Labels: newbie

 Apache Xerces is no longer used in trunk and branch-2 but the dependency 
 exists. It can be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HADOOP-11817) A dedicated token authentication handler for Hadoop Web in generic token API

2015-04-09 Thread Kai Zheng (JIRA)
Kai Zheng created HADOOP-11817:
--

 Summary: A dedicated token authentication handler for Hadoop Web 
in generic token API
 Key: HADOOP-11817
 URL: https://issues.apache.org/jira/browse/HADOOP-11817
 Project: Hadoop Common
  Issue Type: Sub-task
Reporter: Kai Zheng
Assignee: Jiajia Li


Similar to and as discussed in HADOOP-11717, this will work on a dedicated 
token authentication handler for Hadoop Web but in generic token 
representation. It will be easy to support concrete token formats like JWT 
token, OAuth2 token and etc. thru configurable and pluggable approach.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11789) NPE in TestCryptoStreamsWithOpensslAesCtrCryptoCodec

2015-04-09 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487483#comment-14487483
 ] 

Hadoop QA commented on HADOOP-11789:


{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12724221/HADOOP-11789.002.patch
  against trunk revision 6495940.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-common.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6086//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6086//console

This message is automatically generated.

 NPE in TestCryptoStreamsWithOpensslAesCtrCryptoCodec 
 -

 Key: HADOOP-11789
 URL: https://issues.apache.org/jira/browse/HADOOP-11789
 Project: Hadoop Common
  Issue Type: Bug
Affects Versions: 3.0.0, 2.8.0
 Environment: ASF Jenkins
Reporter: Steve Loughran
Assignee: Yi Liu
 Attachments: HADOOP-11789.001.patch, HADOOP-11789.002.patch


 NPE surfacing in {{TestCryptoStreamsWithOpensslAesCtrCryptoCodec}} on  Jenkins



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-11818) Minor improvements for erasurecode classes

2015-04-09 Thread Rakesh R (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rakesh R updated HADOOP-11818:
--
Attachment: HADOOP-11818-002.patch

 Minor improvements for erasurecode classes
 --

 Key: HADOOP-11818
 URL: https://issues.apache.org/jira/browse/HADOOP-11818
 Project: Hadoop Common
  Issue Type: Sub-task
  Components: io
Reporter: Rakesh R
Assignee: Rakesh R
 Attachments: HADOOP-11818-001.patch, HADOOP-11818-002.patch


 Following are few observations while going through the {{erasurecode}} 
 classes.
 \\
 - Use {{org.slf4j.Logger}} instead of {{org.apache.commons.logging.Log}}
 - {{RSErasureDecoder}}, {{RSErasureEncoder}}, {{RSUtil}} missing Apache 
 License header.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11820) aw jira testing, ignore

2015-04-09 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487985#comment-14487985
 ] 

Hadoop QA commented on HADOOP-11820:


\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | reexec | 00m 00s | dev-support patch detected. |
| {color:blue}0{color} | pre-patch | 00m 00s | Pre-patch trunk compilation is 
healthy. |
| {color:red}-1{color} | @author | 00m 00s | The patch appears to contain 13 
@author tags which the Hadoop  community has agreed to not allow in code 
contributions. |
| {color:green}+1{color} | whitespace | 00m 00s | The patch has no   lines that 
end in whitespace. |
| {color:green}+1{color} | release audit | 00m 09s | The applied patch does not 
increase the total number of release audit warnings. |
| {color:red}-1{color} | shellcheck | 00m 03s | The applied patch generated  6 
new shellcheck issues (total was 165, now 27). |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12724295/HADOOP-11746-13.patch |
| Optional Tests | shellcheck |
| git revision | f4b3fc5 / trunk |
| shellcheck | /artifact/patchprocess/diffpatchshellcheck.txt |
| Console output | /artifact/patchprocess/console |


This message was automatically generated.

 aw jira testing, ignore
 ---

 Key: HADOOP-11820
 URL: https://issues.apache.org/jira/browse/HADOOP-11820
 Project: Hadoop Common
  Issue Type: Task
Reporter: Allen Wittenauer
 Attachments: HADOOP-11746-13.patch






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11814) Reformat hadoop-annotations, o.a.h.classification.tools

2015-04-09 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487204#comment-14487204
 ] 

Hudson commented on HADOOP-11814:
-

FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #149 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/149/])
HADOOP-11814. Reformat hadoop-annotations, o.a.h.classification.tools. 
Contributed by Li Lu. (wheat9: rev dc0282d64c6528b02aa9f2df49be01223f087081)
* 
hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/StabilityOptions.java
* 
hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/RootDocProcessor.java
* 
hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsJDiffDoclet.java
* hadoop-common-project/hadoop-common/CHANGES.txt
* 
hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsStandardDoclet.java


 Reformat hadoop-annotations, o.a.h.classification.tools
 ---

 Key: HADOOP-11814
 URL: https://issues.apache.org/jira/browse/HADOOP-11814
 Project: Hadoop Common
  Issue Type: Task
Reporter: Li Lu
Assignee: Li Lu
Priority: Minor
  Labels: formatting
 Fix For: 2.8.0

 Attachments: HADOOP-11814-040815.patch


 RootDocProcessor has some indentation problems. It mixes tabs and spaces for 
 indentation. We may want to fix this. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11820) aw jira testing, ignore

2015-04-09 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14488090#comment-14488090
 ] 

Hadoop QA commented on HADOOP-11820:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12724302/MAPREDUCE-6301-002.patch
  against trunk revision 61dc2ea.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6089//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6089//console

This message is automatically generated.

 aw jira testing, ignore
 ---

 Key: HADOOP-11820
 URL: https://issues.apache.org/jira/browse/HADOOP-11820
 Project: Hadoop Common
  Issue Type: Task
Reporter: Allen Wittenauer
 Attachments: HADOOP-11746-13.patch, MAPREDUCE-6301-002.patch, 
 apache-yarn-3348.5.patch






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11781) fix race conditions and add URL support to smart-apply-patch.sh

2015-04-09 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487209#comment-14487209
 ] 

Hudson commented on HADOOP-11781:
-

FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #149 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/149/])
HADOOP-11781. fix race conditions and add URL support to smart-apply-patch.sh 
(Raymie Stata via aw) (aw: rev f4b3fc56210824037344d403f1ad0f033961a2db)
* hadoop-common-project/hadoop-common/CHANGES.txt
* dev-support/smart-apply-patch.sh


 fix race conditions and add URL support to smart-apply-patch.sh
 ---

 Key: HADOOP-11781
 URL: https://issues.apache.org/jira/browse/HADOOP-11781
 Project: Hadoop Common
  Issue Type: Test
  Components: test
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Raymie Stata
 Fix For: 3.0.0

 Attachments: HADOOP-11781-01.patch, HADOOP-11781-02.patch, 
 HADOOP-11781-03.patch


 smart-apply-patch.sh has a few race conditions and is just generally crufty.  
 It should really be rewritten.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11814) Reformat hadoop-annotations, o.a.h.classification.tools

2015-04-09 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487186#comment-14487186
 ] 

Hudson commented on HADOOP-11814:
-

FAILURE: Integrated in Hadoop-Hdfs-trunk #2090 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2090/])
HADOOP-11814. Reformat hadoop-annotations, o.a.h.classification.tools. 
Contributed by Li Lu. (wheat9: rev dc0282d64c6528b02aa9f2df49be01223f087081)
* hadoop-common-project/hadoop-common/CHANGES.txt
* 
hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/StabilityOptions.java
* 
hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/RootDocProcessor.java
* 
hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsStandardDoclet.java
* 
hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsJDiffDoclet.java


 Reformat hadoop-annotations, o.a.h.classification.tools
 ---

 Key: HADOOP-11814
 URL: https://issues.apache.org/jira/browse/HADOOP-11814
 Project: Hadoop Common
  Issue Type: Task
Reporter: Li Lu
Assignee: Li Lu
Priority: Minor
  Labels: formatting
 Fix For: 2.8.0

 Attachments: HADOOP-11814-040815.patch


 RootDocProcessor has some indentation problems. It mixes tabs and spaces for 
 indentation. We may want to fix this. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11789) NPE in TestCryptoStreamsWithOpensslAesCtrCryptoCodec

2015-04-09 Thread Steve Loughran (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487024#comment-14487024
 ] 

Steve Loughran commented on HADOOP-11789:
-

If jenkins is failing with an NPE the
# jenkins needs to be fixed
# the message needs to be improved

Because at the very least we need a better message, i'm re-opening the JIRA

 NPE in TestCryptoStreamsWithOpensslAesCtrCryptoCodec 
 -

 Key: HADOOP-11789
 URL: https://issues.apache.org/jira/browse/HADOOP-11789
 Project: Hadoop Common
  Issue Type: Bug
Affects Versions: 3.0.0, 2.8.0
 Environment: ASF Jenkins
Reporter: Steve Loughran
Assignee: Yi Liu
 Attachments: HADOOP-11789.001.patch


 NPE surfacing in {{TestCryptoStreamsWithOpensslAesCtrCryptoCodec}} on  Jenkins



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11789) NPE in TestCryptoStreamsWithOpensslAesCtrCryptoCodec

2015-04-09 Thread Steve Loughran (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14488101#comment-14488101
 ] 

Steve Loughran commented on HADOOP-11789:
-

I concur with the avoid trying to be clever with openssl. There's windows to 
think about too.

regarding the code, any reason to go 
{{!true.equalsIgnoreCase(System.getProperty(runningWithNative)}} instead of 
just {{Boolean.getBoolean()}}? If it's case-sensitivity, then it'll need to be 
a {{.toLower(LOCALE_EN).equals()}} for global reliability

 NPE in TestCryptoStreamsWithOpensslAesCtrCryptoCodec 
 -

 Key: HADOOP-11789
 URL: https://issues.apache.org/jira/browse/HADOOP-11789
 Project: Hadoop Common
  Issue Type: Bug
Affects Versions: 3.0.0, 2.8.0
 Environment: ASF Jenkins
Reporter: Steve Loughran
Assignee: Yi Liu
 Attachments: HADOOP-11789.001.patch, HADOOP-11789.002.patch


 NPE surfacing in {{TestCryptoStreamsWithOpensslAesCtrCryptoCodec}} on  Jenkins



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11815) AM JVM hungs after job unregister and finished

2015-04-09 Thread Haohui Mai (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487761#comment-14487761
 ] 

Haohui Mai commented on HADOOP-11815:
-

+1. I'll commit it shortly.

 AM JVM hungs after job unregister and finished
 --

 Key: HADOOP-11815
 URL: https://issues.apache.org/jira/browse/HADOOP-11815
 Project: Hadoop Common
  Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Rohith
Assignee: Rohith
Priority: Blocker
 Attachments: 0001-HADOOP-11815.patch, 0001-MAPREDUCE-6311.patch, 
 0001-MAPREDUCE-6311.patch, MR_TD.out


 It is observed that MRAppMaster JVM hungs after unregistered with 
 ResourceManager.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-11819) HttpServerFunctionalTest#prepareTestWebapp should create web app directory if it does not exist.

2015-04-09 Thread Rohith (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohith updated HADOOP-11819:

Status: Patch Available  (was: Open)

 HttpServerFunctionalTest#prepareTestWebapp should create web app directory if 
 it does not exist.
 

 Key: HADOOP-11819
 URL: https://issues.apache.org/jira/browse/HADOOP-11819
 Project: Hadoop Common
  Issue Type: Test
Reporter: Rohith
Assignee: Rohith
 Attachments: 0001-HADOOP-11819.patch


 Test fails if directory does not exist. Ideally Test should create the non 
 existent directory and execute.
 {noformat}
 java.lang.AssertionError: Test webapp dir 
 D:\Hadoop\hadoop-common-project\hadoop-common\build\test\webapps\test can not 
 be created
   at org.junit.Assert.fail(Assert.java:88)
   at 
 org.apache.hadoop.http.HttpServerFunctionalTest.prepareTestWebapp(HttpServerFunctionalTest.java:127)
   at 
 org.apache.hadoop.http.HttpServerFunctionalTest.createTestServer(HttpServerFunctionalTest.java:91)
   at org.apache.hadoop.http.TestHttpServer.setup(TestHttpServer.java:138)
 {noformat}
 And in the {{HttpServerFunctionalTest#prepareTestWebapp}} java doc says that 
 fail if directory can not be created but test is failing if directory does 
 not exist.
 {code}
 /**
* Prepare the test webapp by creating the directory from the test 
 properties
* fail if the directory cannot be created.
* @throws AssertionError if a condition was not met
*/
   protected static void prepareTestWebapp() {
 // some code
 }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-11815) HttpServer2 should destroy SignerSecretProvider when it stops

2015-04-09 Thread Haohui Mai (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Haohui Mai updated HADOOP-11815:

Summary: HttpServer2 should destroy SignerSecretProvider when it stops  
(was: AM JVM hungs after job unregister and finished)

 HttpServer2 should destroy SignerSecretProvider when it stops
 -

 Key: HADOOP-11815
 URL: https://issues.apache.org/jira/browse/HADOOP-11815
 Project: Hadoop Common
  Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Rohith
Assignee: Rohith
Priority: Blocker
 Attachments: 0001-HADOOP-11815.patch, 0001-MAPREDUCE-6311.patch, 
 0001-MAPREDUCE-6311.patch, MR_TD.out


 It is observed that MRAppMaster JVM hungs after unregistered with 
 ResourceManager.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11789) NPE in TestCryptoStreamsWithOpensslAesCtrCryptoCodec

2015-04-09 Thread Xiaoyu Yao (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487731#comment-14487731
 ] 

Xiaoyu Yao commented on HADOOP-11789:
-

[~hitliuyi], the patch v2 looks good to me. I just have a few comments:
1. Is it possible to add additional check in the test for the specific openssl 
version or above that we want to test. for example, parse the 'openssl version 
-v' output.
{code}
$ openssl version -v
OpenSSL 0.9.8za 5 Jun 2014
{code}

2. Can you add an Assert.assertTrue(codec!=null, codec instance should not be 
null!); between the following two lines so that we will get meaningful failure 
message instead of NPE when codec.getClass() is called with a null instance.
 
{code}
codec = CryptoCodec.getInstance(conf);
Assert.assertEquals(OpensslAesCtrCryptoCodec.class.getCanonicalName(), 
codec.getClass().getCanonicalName());
{code}

 NPE in TestCryptoStreamsWithOpensslAesCtrCryptoCodec 
 -

 Key: HADOOP-11789
 URL: https://issues.apache.org/jira/browse/HADOOP-11789
 Project: Hadoop Common
  Issue Type: Bug
Affects Versions: 3.0.0, 2.8.0
 Environment: ASF Jenkins
Reporter: Steve Loughran
Assignee: Yi Liu
 Attachments: HADOOP-11789.001.patch, HADOOP-11789.002.patch


 NPE surfacing in {{TestCryptoStreamsWithOpensslAesCtrCryptoCodec}} on  Jenkins



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-11820) aw jira testing, ignore

2015-04-09 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated HADOOP-11820:
--
Attachment: MAPREDUCE-6301-002.patch

 aw jira testing, ignore
 ---

 Key: HADOOP-11820
 URL: https://issues.apache.org/jira/browse/HADOOP-11820
 Project: Hadoop Common
  Issue Type: Task
Reporter: Allen Wittenauer
 Attachments: HADOOP-11746-13.patch, MAPREDUCE-6301-002.patch






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-11819) HttpServerFunctionalTest#prepareTestWebapp should create web app directory if it does not exist.

2015-04-09 Thread Rohith (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohith updated HADOOP-11819:

Attachment: 0001-HADOOP-11819.patch

Attached the patch with simple fix. Kindly review the patch

 HttpServerFunctionalTest#prepareTestWebapp should create web app directory if 
 it does not exist.
 

 Key: HADOOP-11819
 URL: https://issues.apache.org/jira/browse/HADOOP-11819
 Project: Hadoop Common
  Issue Type: Test
Reporter: Rohith
Assignee: Rohith
 Attachments: 0001-HADOOP-11819.patch


 Test fails if directory does not exist. Ideally Test should create the non 
 existent directory and execute.
 {noformat}
 java.lang.AssertionError: Test webapp dir 
 D:\Hadoop\hadoop-common-project\hadoop-common\build\test\webapps\test can not 
 be created
   at org.junit.Assert.fail(Assert.java:88)
   at 
 org.apache.hadoop.http.HttpServerFunctionalTest.prepareTestWebapp(HttpServerFunctionalTest.java:127)
   at 
 org.apache.hadoop.http.HttpServerFunctionalTest.createTestServer(HttpServerFunctionalTest.java:91)
   at org.apache.hadoop.http.TestHttpServer.setup(TestHttpServer.java:138)
 {noformat}
 And in the {{HttpServerFunctionalTest#prepareTestWebapp}} java doc says that 
 fail if directory can not be created but test is failing if directory does 
 not exist.
 {code}
 /**
* Prepare the test webapp by creating the directory from the test 
 properties
* fail if the directory cannot be created.
* @throws AssertionError if a condition was not met
*/
   protected static void prepareTestWebapp() {
 // some code
 }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11820) aw jira testing, ignore

2015-04-09 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487957#comment-14487957
 ] 

Hadoop QA commented on HADOOP-11820:


(!) A patch to test-patch or smart-apply-patch has been detected.
Re-executing against the patched versions to perform further tests.

 aw jira testing, ignore
 ---

 Key: HADOOP-11820
 URL: https://issues.apache.org/jira/browse/HADOOP-11820
 Project: Hadoop Common
  Issue Type: Task
Reporter: Allen Wittenauer
 Attachments: HADOOP-11746-13.patch






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Reopened] (HADOOP-11789) NPE in TestCryptoStreamsWithOpensslAesCtrCryptoCodec

2015-04-09 Thread Steve Loughran (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Loughran reopened HADOOP-11789:
-

 NPE in TestCryptoStreamsWithOpensslAesCtrCryptoCodec 
 -

 Key: HADOOP-11789
 URL: https://issues.apache.org/jira/browse/HADOOP-11789
 Project: Hadoop Common
  Issue Type: Bug
Affects Versions: 3.0.0, 2.8.0
 Environment: ASF Jenkins
Reporter: Steve Loughran
Assignee: Yi Liu
 Attachments: HADOOP-11789.001.patch


 NPE surfacing in {{TestCryptoStreamsWithOpensslAesCtrCryptoCodec}} on  Jenkins



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11814) Reformat hadoop-annotations, o.a.h.classification.tools

2015-04-09 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487907#comment-14487907
 ] 

Hudson commented on HADOOP-11814:
-

FAILURE: Integrated in Hadoop-Mapreduce-trunk #2108 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2108/])
HADOOP-11814. Reformat hadoop-annotations, o.a.h.classification.tools. 
Contributed by Li Lu. (wheat9: rev dc0282d64c6528b02aa9f2df49be01223f087081)
* 
hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/RootDocProcessor.java
* 
hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsJDiffDoclet.java
* 
hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/StabilityOptions.java
* hadoop-common-project/hadoop-common/CHANGES.txt
* 
hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsStandardDoclet.java


 Reformat hadoop-annotations, o.a.h.classification.tools
 ---

 Key: HADOOP-11814
 URL: https://issues.apache.org/jira/browse/HADOOP-11814
 Project: Hadoop Common
  Issue Type: Task
Reporter: Li Lu
Assignee: Li Lu
Priority: Minor
  Labels: formatting
 Fix For: 2.8.0

 Attachments: HADOOP-11814-040815.patch


 RootDocProcessor has some indentation problems. It mixes tabs and spaces for 
 indentation. We may want to fix this. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-11820) aw jira testing, ignore

2015-04-09 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated HADOOP-11820:
--
Status: Patch Available  (was: Open)

 aw jira testing, ignore
 ---

 Key: HADOOP-11820
 URL: https://issues.apache.org/jira/browse/HADOOP-11820
 Project: Hadoop Common
  Issue Type: Task
Reporter: Allen Wittenauer
 Attachments: HADOOP-11746-13.patch






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11820) aw jira testing, ignore

2015-04-09 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487958#comment-14487958
 ] 

Hadoop QA commented on HADOOP-11820:


\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | reexec | 00m 00s | dev-support patch detected. |
| {color:blue}0{color} | pre-patch | 00m 00s | Pre-patch trunk compilation is 
healthy. |
| {color:red}-1{color} | @author | 00m 00s | The patch appears to contain 13 
@author tags which the Hadoop  community has agreed to not allow in code 
contributions. |
| {color:green}+1{color} | whitespace | 00m 00s | The patch has no   lines that 
end in whitespace. |
| {color:green}+1{color} | release audit | 00m 09s | The applied patch does not 
increase the total number of release audit warnings. |
| {color:red}-1{color} | shellcheck | 00m 03s | The applied patch generated  6 
new shellcheck issues (total was 165, now 27). |
| {color:red}-1{color} | findbugs | 00m 03s | Findbugs is not installed. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12724295/HADOOP-11746-13.patch |
| Optional Tests | shellcheck |
| git revision | f4b3fc5 / trunk |
| shellcheck | /artifact/patchprocess/diffpatchshellcheck.txt |
| Console output | /artifact/patchprocess/console |


This message was automatically generated.

 aw jira testing, ignore
 ---

 Key: HADOOP-11820
 URL: https://issues.apache.org/jira/browse/HADOOP-11820
 Project: Hadoop Common
  Issue Type: Task
Reporter: Allen Wittenauer
 Attachments: HADOOP-11746-13.patch






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11815) HttpServer2 should destroy SignerSecretProvider when it stops

2015-04-09 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487787#comment-14487787
 ] 

Hudson commented on HADOOP-11815:
-

FAILURE: Integrated in Hadoop-trunk-Commit #7548 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/7548/])
HADOOP-11815. HttpServer2 should destroy SignerSecretProvider when it stops. 
Contributed by Rohith. (wheat9: rev 63c659ddd0641227501851dbcd1352064fa9348a)
* 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
* hadoop-common-project/hadoop-common/CHANGES.txt


 HttpServer2 should destroy SignerSecretProvider when it stops
 -

 Key: HADOOP-11815
 URL: https://issues.apache.org/jira/browse/HADOOP-11815
 Project: Hadoop Common
  Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Rohith
Assignee: Rohith
Priority: Blocker
 Fix For: 2.7.0

 Attachments: 0001-HADOOP-11815.patch, 0001-MAPREDUCE-6311.patch, 
 0001-MAPREDUCE-6311.patch, MR_TD.out


 It is observed that MRAppMaster JVM hungs after unregistered with 
 ResourceManager.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11814) Reformat hadoop-annotations, o.a.h.classification.tools

2015-04-09 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487816#comment-14487816
 ] 

Hudson commented on HADOOP-11814:
-

FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #159 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/159/])
HADOOP-11814. Reformat hadoop-annotations, o.a.h.classification.tools. 
Contributed by Li Lu. (wheat9: rev dc0282d64c6528b02aa9f2df49be01223f087081)
* 
hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsJDiffDoclet.java
* hadoop-common-project/hadoop-common/CHANGES.txt
* 
hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/StabilityOptions.java
* 
hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/RootDocProcessor.java
* 
hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsStandardDoclet.java


 Reformat hadoop-annotations, o.a.h.classification.tools
 ---

 Key: HADOOP-11814
 URL: https://issues.apache.org/jira/browse/HADOOP-11814
 Project: Hadoop Common
  Issue Type: Task
Reporter: Li Lu
Assignee: Li Lu
Priority: Minor
  Labels: formatting
 Fix For: 2.8.0

 Attachments: HADOOP-11814-040815.patch


 RootDocProcessor has some indentation problems. It mixes tabs and spaces for 
 indentation. We may want to fix this. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11781) fix race conditions and add URL support to smart-apply-patch.sh

2015-04-09 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487821#comment-14487821
 ] 

Hudson commented on HADOOP-11781:
-

FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #159 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/159/])
HADOOP-11781. fix race conditions and add URL support to smart-apply-patch.sh 
(Raymie Stata via aw) (aw: rev f4b3fc56210824037344d403f1ad0f033961a2db)
* hadoop-common-project/hadoop-common/CHANGES.txt
* dev-support/smart-apply-patch.sh


 fix race conditions and add URL support to smart-apply-patch.sh
 ---

 Key: HADOOP-11781
 URL: https://issues.apache.org/jira/browse/HADOOP-11781
 Project: Hadoop Common
  Issue Type: Test
  Components: test
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Raymie Stata
 Fix For: 3.0.0

 Attachments: HADOOP-11781-01.patch, HADOOP-11781-02.patch, 
 HADOOP-11781-03.patch


 smart-apply-patch.sh has a few race conditions and is just generally crufty.  
 It should really be rewritten.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11781) fix race conditions and add URL support to smart-apply-patch.sh

2015-04-09 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487130#comment-14487130
 ] 

Hudson commented on HADOOP-11781:
-

FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #158 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/158/])
HADOOP-11781. fix race conditions and add URL support to smart-apply-patch.sh 
(Raymie Stata via aw) (aw: rev f4b3fc56210824037344d403f1ad0f033961a2db)
* hadoop-common-project/hadoop-common/CHANGES.txt
* dev-support/smart-apply-patch.sh


 fix race conditions and add URL support to smart-apply-patch.sh
 ---

 Key: HADOOP-11781
 URL: https://issues.apache.org/jira/browse/HADOOP-11781
 Project: Hadoop Common
  Issue Type: Test
  Components: test
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Raymie Stata
 Fix For: 3.0.0

 Attachments: HADOOP-11781-01.patch, HADOOP-11781-02.patch, 
 HADOOP-11781-03.patch


 smart-apply-patch.sh has a few race conditions and is just generally crufty.  
 It should really be rewritten.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11818) Minor improvements for erasurecode classes

2015-04-09 Thread Rakesh R (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487161#comment-14487161
 ] 

Rakesh R commented on HADOOP-11818:
---

Attached new patch where it modifies link  {{ErasureDecoder}} to 
{{ErasureCoder}}. Please have a look at it when you get a chance. Thanks!

 Minor improvements for erasurecode classes
 --

 Key: HADOOP-11818
 URL: https://issues.apache.org/jira/browse/HADOOP-11818
 Project: Hadoop Common
  Issue Type: Sub-task
  Components: io
Reporter: Rakesh R
Assignee: Rakesh R
 Attachments: HADOOP-11818-001.patch, HADOOP-11818-002.patch


 Following are few observations while going through the {{erasurecode}} 
 classes.
 \\
 - Use {{org.slf4j.Logger}} instead of {{org.apache.commons.logging.Log}}
 - {{RSErasureDecoder}}, {{RSErasureEncoder}}, {{RSUtil}} missing Apache 
 License header.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HADOOP-11819) HttpServerFunctionalTest#prepareTestWebapp should create web app directory if it does not exist.

2015-04-09 Thread Rohith (JIRA)
Rohith created HADOOP-11819:
---

 Summary: HttpServerFunctionalTest#prepareTestWebapp should create 
web app directory if it does not exist.
 Key: HADOOP-11819
 URL: https://issues.apache.org/jira/browse/HADOOP-11819
 Project: Hadoop Common
  Issue Type: Test
Reporter: Rohith
Assignee: Rohith


Test fails if directory does not exist. Ideally Test should create the non 
existent directory and execute.
{noformat}
java.lang.AssertionError: Test webapp dir 
D:\Hadoop\hadoop-common-project\hadoop-common\build\test\webapps\test can not 
be created
at org.junit.Assert.fail(Assert.java:88)
at 
org.apache.hadoop.http.HttpServerFunctionalTest.prepareTestWebapp(HttpServerFunctionalTest.java:127)
at 
org.apache.hadoop.http.HttpServerFunctionalTest.createTestServer(HttpServerFunctionalTest.java:91)
at org.apache.hadoop.http.TestHttpServer.setup(TestHttpServer.java:138)
{noformat}

And in the {{HttpServerFunctionalTest#prepareTestWebapp}} java doc says that 
fail if directory can not be created but test is failing if directory does not 
exist.
{code}
/**
   * Prepare the test webapp by creating the directory from the test properties
   * fail if the directory cannot be created.
   * @throws AssertionError if a condition was not met
   */
  protected static void prepareTestWebapp() {
// some code
}
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-11815) AM JVM hungs after job unregister and finished

2015-04-09 Thread Vinod Kumar Vavilapalli (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vinod Kumar Vavilapalli updated HADOOP-11815:
-
Target Version/s: 2.7.0

 AM JVM hungs after job unregister and finished
 --

 Key: HADOOP-11815
 URL: https://issues.apache.org/jira/browse/HADOOP-11815
 Project: Hadoop Common
  Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Rohith
Assignee: Rohith
Priority: Blocker
 Attachments: 0001-HADOOP-11815.patch, 0001-MAPREDUCE-6311.patch, 
 0001-MAPREDUCE-6311.patch, MR_TD.out


 It is observed that MRAppMaster JVM hungs after unregistered with 
 ResourceManager.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Work started] (HADOOP-11818) Minor improvements for erasurecode classes

2015-04-09 Thread Rakesh R (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HADOOP-11818 started by Rakesh R.
-
 Minor improvements for erasurecode classes
 --

 Key: HADOOP-11818
 URL: https://issues.apache.org/jira/browse/HADOOP-11818
 Project: Hadoop Common
  Issue Type: Sub-task
  Components: io
Reporter: Rakesh R
Assignee: Rakesh R
 Attachments: HADOOP-11818-001.patch


 Following are few observations while going through the {{erasurecode}} 
 classes.
 \\
 - Use {{org.slf4j.Logger}} instead of {{org.apache.commons.logging.Log}}
 - {{RSErasureDecoder}}, {{RSErasureEncoder}}, {{RSUtil}} missing Apache 
 License header.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-11818) Minor improvements for erasurecode classes

2015-04-09 Thread Rakesh R (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rakesh R updated HADOOP-11818:
--
Attachment: HADOOP-11818-001.patch

 Minor improvements for erasurecode classes
 --

 Key: HADOOP-11818
 URL: https://issues.apache.org/jira/browse/HADOOP-11818
 Project: Hadoop Common
  Issue Type: Sub-task
  Components: io
Reporter: Rakesh R
Assignee: Rakesh R
 Attachments: HADOOP-11818-001.patch


 Following are few observations while going through the {{erasurecode}} 
 classes.
 \\
 - Use {{org.slf4j.Logger}} instead of {{org.apache.commons.logging.Log}}
 - {{RSErasureDecoder}}, {{RSErasureEncoder}}, {{RSUtil}} missing Apache 
 License header.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11789) NPE in TestCryptoStreamsWithOpensslAesCtrCryptoCodec

2015-04-09 Thread Colin Patrick McCabe (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1448#comment-1448
 ] 

Colin Patrick McCabe commented on HADOOP-11789:
---

bq. 1. Xiaoyu Yao wrote: Is it possible to add additional check in the test for 
the specific openssl version or above that we want to test. for example, parse 
the 'openssl version -v' output.

Please, no.  Openssl versioning is a mess.  For example, Red Hat shipped a 
library labelled 1.0.0 that was actually version 1.0.1e in RHEL6.  With all the 
vendor patching that goes on, it's very difficult to say what the actual 
minimum version is for Hadoop, if it's even possible.  We already handle this 
correctly.  If the library is too old, the dlsym calls will fail and the user 
will get an informative message.  We will only get ourselves into trouble if we 
try to parse version IDs.  (Which aren't even always numeric for openssl, a WTF 
all its own.)

bq. 2. Can you add an Assert.assertTrue(codec!=null, codec instance should not 
be null!); between the following two lines so that we will get meaningful 
failure message instead of NPE when codec.getClass() is called with a null 
instance.

Good idea.  We should just use assertNotNull, though.

+1

 NPE in TestCryptoStreamsWithOpensslAesCtrCryptoCodec 
 -

 Key: HADOOP-11789
 URL: https://issues.apache.org/jira/browse/HADOOP-11789
 Project: Hadoop Common
  Issue Type: Bug
Affects Versions: 3.0.0, 2.8.0
 Environment: ASF Jenkins
Reporter: Steve Loughran
Assignee: Yi Liu
 Attachments: HADOOP-11789.001.patch, HADOOP-11789.002.patch


 NPE surfacing in {{TestCryptoStreamsWithOpensslAesCtrCryptoCodec}} on  Jenkins



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11789) NPE in TestCryptoStreamsWithOpensslAesCtrCryptoCodec

2015-04-09 Thread Yi Liu (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487399#comment-14487399
 ] 

Yi Liu commented on HADOOP-11789:
-

{quote}
but the NPE on Jenkins needs to be fixed on the Jenkins side.
{quote}
Sorry, I missed this comment from Andrew :)   The new patch addresses that, 
thanks.

 NPE in TestCryptoStreamsWithOpensslAesCtrCryptoCodec 
 -

 Key: HADOOP-11789
 URL: https://issues.apache.org/jira/browse/HADOOP-11789
 Project: Hadoop Common
  Issue Type: Bug
Affects Versions: 3.0.0, 2.8.0
 Environment: ASF Jenkins
Reporter: Steve Loughran
Assignee: Yi Liu
 Attachments: HADOOP-11789.001.patch, HADOOP-11789.002.patch


 NPE surfacing in {{TestCryptoStreamsWithOpensslAesCtrCryptoCodec}} on  Jenkins



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11818) Minor improvements for erasurecode classes

2015-04-09 Thread Kai Zheng (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487300#comment-14487300
 ] 

Kai Zheng commented on HADOOP-11818:


I committed it in the branch. Thanks [~rakeshr] for the contribution!

 Minor improvements for erasurecode classes
 --

 Key: HADOOP-11818
 URL: https://issues.apache.org/jira/browse/HADOOP-11818
 Project: Hadoop Common
  Issue Type: Sub-task
  Components: io
Reporter: Rakesh R
Assignee: Rakesh R
 Attachments: HADOOP-11818-001.patch, HADOOP-11818-002.patch


 Following are few observations while going through the {{erasurecode}} 
 classes.
 \\
 - Use {{org.slf4j.Logger}} instead of {{org.apache.commons.logging.Log}}
 - {{RSErasureDecoder}}, {{RSErasureEncoder}}, {{RSUtil}} missing Apache 
 License header.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11820) aw jira testing, ignore

2015-04-09 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487983#comment-14487983
 ] 

Hadoop QA commented on HADOOP-11820:


(!) A patch to test-patch or smart-apply-patch has been detected.
Re-executing against the patched versions to perform further tests.

 aw jira testing, ignore
 ---

 Key: HADOOP-11820
 URL: https://issues.apache.org/jira/browse/HADOOP-11820
 Project: Hadoop Common
  Issue Type: Task
Reporter: Allen Wittenauer
 Attachments: HADOOP-11746-13.patch






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (HADOOP-11746) rewrite test-patch.sh

2015-04-09 Thread Allen Wittenauer (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487749#comment-14487749
 ] 

Allen Wittenauer edited comment on HADOOP-11746 at 4/9/15 5:51 PM:
---

-13:
* fix an issue where a git ref may be in the future vs. the copy on disk.  We 
no longer do a pull --rebase, but a fetch + checkout --force in jenkins mode.
* shellcheck support beefed up, including now failing on new errors, not if the 
total count was higher. Also smarter about picking up on patches that patch 
shell code that are not in the normal places
* cosmetic fixes for the test table
* renamed populate_unit_table to populate_test_table to better reflect what it 
is
* findbugs moved into its own optional test instead of being tied to javac so 
that pom.xml, native code, etc, won't trigger a run. (This does mean that 
testing findbugs itself will get missed now... but that's a very rare 
occurrence...)

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | reexec | 00m 00s | dev-support patch detected. |
| {color:blue}0{color} | pre-patch | 00m 00s | Pre-patch trunk compilation is 
healthy. |
| {color:red}-1{color} | @author | 00m 00s | The patch appears to contain 13 
@author tags which the Hadoop  community has agreed to not allow in code 
contributions. |
| {color:green}+1{color} | whitespace | 00m 00s | The patch has no   lines that 
end in whitespace. |
| {color:green}+1{color} | release audit | 00m 08s | The applied patch does not 
increase the total number of release audit warnings. |
| {color:red}-1{color} | shellcheck | 00m 03s | The applied patch generated  6 
new shellcheck issues (total was 165, now 27). |



was (Author: aw):
-13:
* fix an issue where a git ref may be in the future vs. the copy on disk.  We 
no longer do a pull --rebase, but a fetch + checkout --force in jenkins mode.
* shellcheck support beefed up, including now failing on new errors, not if the 
total count was higher. Also smarter about picking up on patches that patch 
shell code that are not in the normal places
* cosmetic fixes for the test table
* renamed populate_unit_table to populate_test_table to better reflect what it 
is
* findbugs moved into its own optional test instead of being tied to javac so 
that pom.xml, native code, etc, won't trigger a run. (This does mean that 
testing findbugs itself will get missed now... but that's a very rare 
occurrence...)


 rewrite test-patch.sh
 -

 Key: HADOOP-11746
 URL: https://issues.apache.org/jira/browse/HADOOP-11746
 Project: Hadoop Common
  Issue Type: Test
  Components: build, test
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Allen Wittenauer
 Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch, 
 HADOOP-11746-02.patch, HADOOP-11746-03.patch, HADOOP-11746-04.patch, 
 HADOOP-11746-05.patch, HADOOP-11746-06.patch, HADOOP-11746-07.patch, 
 HADOOP-11746-09.patch, HADOOP-11746-10.patch, HADOOP-11746-11.patch, 
 HADOOP-11746-12.patch, HADOOP-11746-13.patch


 This code is bad and you should feel bad.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11819) HttpServerFunctionalTest#prepareTestWebapp should create web app directory if it does not exist.

2015-04-09 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487282#comment-14487282
 ] 

Hadoop QA commented on HADOOP-11819:


{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12724203/0001-HADOOP-11819.patch
  against trunk revision 6495940.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-common.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6085//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6085//console

This message is automatically generated.

 HttpServerFunctionalTest#prepareTestWebapp should create web app directory if 
 it does not exist.
 

 Key: HADOOP-11819
 URL: https://issues.apache.org/jira/browse/HADOOP-11819
 Project: Hadoop Common
  Issue Type: Test
Reporter: Rohith
Assignee: Rohith
 Attachments: 0001-HADOOP-11819.patch


 Test fails if directory does not exist. Ideally Test should create the non 
 existent directory and execute.
 {noformat}
 java.lang.AssertionError: Test webapp dir 
 D:\Hadoop\hadoop-common-project\hadoop-common\build\test\webapps\test can not 
 be created
   at org.junit.Assert.fail(Assert.java:88)
   at 
 org.apache.hadoop.http.HttpServerFunctionalTest.prepareTestWebapp(HttpServerFunctionalTest.java:127)
   at 
 org.apache.hadoop.http.HttpServerFunctionalTest.createTestServer(HttpServerFunctionalTest.java:91)
   at org.apache.hadoop.http.TestHttpServer.setup(TestHttpServer.java:138)
 {noformat}
 And in the {{HttpServerFunctionalTest#prepareTestWebapp}} java doc says that 
 fail if directory can not be created but test is failing if directory does 
 not exist.
 {code}
 /**
* Prepare the test webapp by creating the directory from the test 
 properties
* fail if the directory cannot be created.
* @throws AssertionError if a condition was not met
*/
   protected static void prepareTestWebapp() {
 // some code
 }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-11789) NPE in TestCryptoStreamsWithOpensslAesCtrCryptoCodec

2015-04-09 Thread Yi Liu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yi Liu updated HADOOP-11789:

Status: Patch Available  (was: Reopened)

 NPE in TestCryptoStreamsWithOpensslAesCtrCryptoCodec 
 -

 Key: HADOOP-11789
 URL: https://issues.apache.org/jira/browse/HADOOP-11789
 Project: Hadoop Common
  Issue Type: Bug
Affects Versions: 3.0.0, 2.8.0
 Environment: ASF Jenkins
Reporter: Steve Loughran
Assignee: Yi Liu
 Attachments: HADOOP-11789.001.patch, HADOOP-11789.002.patch


 NPE surfacing in {{TestCryptoStreamsWithOpensslAesCtrCryptoCodec}} on  Jenkins



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11781) fix race conditions and add URL support to smart-apply-patch.sh

2015-04-09 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487248#comment-14487248
 ] 

Hudson commented on HADOOP-11781:
-

SUCCESS: Integrated in Hadoop-Yarn-trunk #892 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk/892/])
HADOOP-11781. fix race conditions and add URL support to smart-apply-patch.sh 
(Raymie Stata via aw) (aw: rev f4b3fc56210824037344d403f1ad0f033961a2db)
* dev-support/smart-apply-patch.sh
* hadoop-common-project/hadoop-common/CHANGES.txt


 fix race conditions and add URL support to smart-apply-patch.sh
 ---

 Key: HADOOP-11781
 URL: https://issues.apache.org/jira/browse/HADOOP-11781
 Project: Hadoop Common
  Issue Type: Test
  Components: test
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Raymie Stata
 Fix For: 3.0.0

 Attachments: HADOOP-11781-01.patch, HADOOP-11781-02.patch, 
 HADOOP-11781-03.patch


 smart-apply-patch.sh has a few race conditions and is just generally crufty.  
 It should really be rewritten.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-11820) aw jira testing, ignore

2015-04-09 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated HADOOP-11820:
--
Attachment: apache-yarn-3348.5.patch

 aw jira testing, ignore
 ---

 Key: HADOOP-11820
 URL: https://issues.apache.org/jira/browse/HADOOP-11820
 Project: Hadoop Common
  Issue Type: Task
Reporter: Allen Wittenauer
 Attachments: HADOOP-11746-13.patch, MAPREDUCE-6301-002.patch, 
 apache-yarn-3348.5.patch






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11814) Reformat hadoop-annotations, o.a.h.classification.tools

2015-04-09 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487125#comment-14487125
 ] 

Hudson commented on HADOOP-11814:
-

FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #158 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/158/])
HADOOP-11814. Reformat hadoop-annotations, o.a.h.classification.tools. 
Contributed by Li Lu. (wheat9: rev dc0282d64c6528b02aa9f2df49be01223f087081)
* 
hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/StabilityOptions.java
* hadoop-common-project/hadoop-common/CHANGES.txt
* 
hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/RootDocProcessor.java
* 
hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsJDiffDoclet.java
* 
hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsStandardDoclet.java


 Reformat hadoop-annotations, o.a.h.classification.tools
 ---

 Key: HADOOP-11814
 URL: https://issues.apache.org/jira/browse/HADOOP-11814
 Project: Hadoop Common
  Issue Type: Task
Reporter: Li Lu
Assignee: Li Lu
Priority: Minor
  Labels: formatting
 Fix For: 2.8.0

 Attachments: HADOOP-11814-040815.patch


 RootDocProcessor has some indentation problems. It mixes tabs and spaces for 
 indentation. We may want to fix this. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11781) fix race conditions and add URL support to smart-apply-patch.sh

2015-04-09 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487912#comment-14487912
 ] 

Hudson commented on HADOOP-11781:
-

FAILURE: Integrated in Hadoop-Mapreduce-trunk #2108 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2108/])
HADOOP-11781. fix race conditions and add URL support to smart-apply-patch.sh 
(Raymie Stata via aw) (aw: rev f4b3fc56210824037344d403f1ad0f033961a2db)
* dev-support/smart-apply-patch.sh
* hadoop-common-project/hadoop-common/CHANGES.txt


 fix race conditions and add URL support to smart-apply-patch.sh
 ---

 Key: HADOOP-11781
 URL: https://issues.apache.org/jira/browse/HADOOP-11781
 Project: Hadoop Common
  Issue Type: Test
  Components: test
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Raymie Stata
 Fix For: 3.0.0

 Attachments: HADOOP-11781-01.patch, HADOOP-11781-02.patch, 
 HADOOP-11781-03.patch


 smart-apply-patch.sh has a few race conditions and is just generally crufty.  
 It should really be rewritten.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11820) aw jira testing, ignore

2015-04-09 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14488067#comment-14488067
 ] 

Hadoop QA commented on HADOOP-11820:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12724295/HADOOP-11746-13.patch
  against trunk revision 61dc2ea.

{color:red}-1 @author{color}.  The patch appears to contain 13 @author tags 
which the Hadoop community has agreed to not allow in code contributions.

{color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6088//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6088//console

This message is automatically generated.

 aw jira testing, ignore
 ---

 Key: HADOOP-11820
 URL: https://issues.apache.org/jira/browse/HADOOP-11820
 Project: Hadoop Common
  Issue Type: Task
Reporter: Allen Wittenauer
 Attachments: HADOOP-11746-13.patch, MAPREDUCE-6301-002.patch, 
 apache-yarn-3348.5.patch






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11818) Minor improvements for erasurecode classes

2015-04-09 Thread Rakesh R (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487140#comment-14487140
 ] 

Rakesh R commented on HADOOP-11818:
---

Thanks [~drankye] for the comment. I hope modify this to below one would be ok, 
right?
{code} It implements {@link ErasureCoder}.{code}

 Minor improvements for erasurecode classes
 --

 Key: HADOOP-11818
 URL: https://issues.apache.org/jira/browse/HADOOP-11818
 Project: Hadoop Common
  Issue Type: Sub-task
  Components: io
Reporter: Rakesh R
Assignee: Rakesh R
 Attachments: HADOOP-11818-001.patch


 Following are few observations while going through the {{erasurecode}} 
 classes.
 \\
 - Use {{org.slf4j.Logger}} instead of {{org.apache.commons.logging.Log}}
 - {{RSErasureDecoder}}, {{RSErasureEncoder}}, {{RSUtil}} missing Apache 
 License header.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HADOOP-11818) Minor improvements for erasurecode classes

2015-04-09 Thread Rakesh R (JIRA)
Rakesh R created HADOOP-11818:
-

 Summary: Minor improvements for erasurecode classes
 Key: HADOOP-11818
 URL: https://issues.apache.org/jira/browse/HADOOP-11818
 Project: Hadoop Common
  Issue Type: Sub-task
Reporter: Rakesh R
Assignee: Rakesh R


Following are few observations while going through the {{erasurecode}} classes.
\\

- Use {{org.slf4j.Logger}} instead of {{org.apache.commons.logging.Log}}
- {{RSErasureDecoder}}, {{RSErasureEncoder}}, {{RSUtil}} missing Apache License 
header.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11818) Minor improvements for erasurecode classes

2015-04-09 Thread Kai Zheng (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487096#comment-14487096
 ] 

Kai Zheng commented on HADOOP-11818:


Hi [~rakeshr],

Thanks for reporting this. The patch looks great. I noticed another issue not 
relevant to the patch, would you fix it by the way?
In {{RSErasureDecoder}} and {{RSErasureEncoder}}, it has comments like below, 
which should be corrected. Thanks.
{code}
It implements {@link ErasureDecoder}.
{code}

 Minor improvements for erasurecode classes
 --

 Key: HADOOP-11818
 URL: https://issues.apache.org/jira/browse/HADOOP-11818
 Project: Hadoop Common
  Issue Type: Sub-task
  Components: io
Reporter: Rakesh R
Assignee: Rakesh R
 Attachments: HADOOP-11818-001.patch


 Following are few observations while going through the {{erasurecode}} 
 classes.
 \\
 - Use {{org.slf4j.Logger}} instead of {{org.apache.commons.logging.Log}}
 - {{RSErasureDecoder}}, {{RSErasureEncoder}}, {{RSUtil}} missing Apache 
 License header.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11781) fix race conditions and add URL support to smart-apply-patch.sh

2015-04-09 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487191#comment-14487191
 ] 

Hudson commented on HADOOP-11781:
-

FAILURE: Integrated in Hadoop-Hdfs-trunk #2090 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2090/])
HADOOP-11781. fix race conditions and add URL support to smart-apply-patch.sh 
(Raymie Stata via aw) (aw: rev f4b3fc56210824037344d403f1ad0f033961a2db)
* hadoop-common-project/hadoop-common/CHANGES.txt
* dev-support/smart-apply-patch.sh


 fix race conditions and add URL support to smart-apply-patch.sh
 ---

 Key: HADOOP-11781
 URL: https://issues.apache.org/jira/browse/HADOOP-11781
 Project: Hadoop Common
  Issue Type: Test
  Components: test
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Raymie Stata
 Fix For: 3.0.0

 Attachments: HADOOP-11781-01.patch, HADOOP-11781-02.patch, 
 HADOOP-11781-03.patch


 smart-apply-patch.sh has a few race conditions and is just generally crufty.  
 It should really be rewritten.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11717) Add Redirecting WebSSO behavior with JWT Token in Hadoop Auth

2015-04-09 Thread Kai Zheng (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14486945#comment-14486945
 ] 

Kai Zheng commented on HADOOP-11717:


Thanks [~lmccay] and [~owen.omalley] for committing this. As I said before, 
it's great to have it. I realized your point only supporting the JWT token 
format here as it's good enough for your case right now.

Let me open another to go for a dedicated token authentication handler for 
Hadoop web in general token API.

 Add Redirecting WebSSO behavior with JWT Token in Hadoop Auth
 -

 Key: HADOOP-11717
 URL: https://issues.apache.org/jira/browse/HADOOP-11717
 Project: Hadoop Common
  Issue Type: Improvement
  Components: security
Reporter: Larry McCay
Assignee: Larry McCay
 Fix For: 2.8.0

 Attachments: HADOOP-11717-1.patch, HADOOP-11717-2.patch, 
 HADOOP-11717-3.patch, HADOOP-11717-4.patch, HADOOP-11717-5.patch, 
 HADOOP-11717-6.patch, HADOOP-11717-7.patch, HADOOP-11717-8.patch, 
 RedirectingWebSSOwithJWTforHadoopWebUIs.pdf


 Extend AltKerberosAuthenticationHandler to provide WebSSO flow for UIs.
 The actual authentication is done by some external service that the handler 
 will redirect to when there is no hadoop.auth cookie and no JWT token found 
 in the incoming request.
 Using JWT provides a number of benefits:
 * It is not tied to any specific authentication mechanism - so buys us many 
 SSO integrations
 * It is cryptographically verifiable for determining whether it can be trusted
 * Checking for expiration allows for a limited lifetime and window for 
 compromised use
 This will introduce the use of nimbus-jose-jwt library for processing, 
 validating and parsing JWT tokens.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11746) rewrite test-patch.sh

2015-04-09 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487858#comment-14487858
 ] 

Hadoop QA commented on HADOOP-11746:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12724277/HADOOP-11746-13.patch
  against trunk revision 1885141.

{color:red}-1 @author{color}.  The patch appears to contain 13 @author tags 
which the Hadoop community has agreed to not allow in code contributions.

{color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6087//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6087//console

This message is automatically generated.

 rewrite test-patch.sh
 -

 Key: HADOOP-11746
 URL: https://issues.apache.org/jira/browse/HADOOP-11746
 Project: Hadoop Common
  Issue Type: Test
  Components: build, test
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Allen Wittenauer
 Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch, 
 HADOOP-11746-02.patch, HADOOP-11746-03.patch, HADOOP-11746-04.patch, 
 HADOOP-11746-05.patch, HADOOP-11746-06.patch, HADOOP-11746-07.patch, 
 HADOOP-11746-09.patch, HADOOP-11746-10.patch, HADOOP-11746-11.patch, 
 HADOOP-11746-12.patch, HADOOP-11746-13.patch


 This code is bad and you should feel bad.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-11820) aw jira testing, ignore

2015-04-09 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated HADOOP-11820:
--
Attachment: HADOOP-11746-13.patch

 aw jira testing, ignore
 ---

 Key: HADOOP-11820
 URL: https://issues.apache.org/jira/browse/HADOOP-11820
 Project: Hadoop Common
  Issue Type: Task
Reporter: Allen Wittenauer
 Attachments: HADOOP-11746-13.patch






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HADOOP-11820) aw jira testing, ignore

2015-04-09 Thread Allen Wittenauer (JIRA)
Allen Wittenauer created HADOOP-11820:
-

 Summary: aw jira testing, ignore
 Key: HADOOP-11820
 URL: https://issues.apache.org/jira/browse/HADOOP-11820
 Project: Hadoop Common
  Issue Type: Task
Reporter: Allen Wittenauer
 Attachments: HADOOP-11746-13.patch





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11818) Minor improvements for erasurecode classes

2015-04-09 Thread Rakesh R (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487069#comment-14487069
 ] 

Rakesh R commented on HADOOP-11818:
---

Attached patch which covers these cases. Please review. Thanks!

 Minor improvements for erasurecode classes
 --

 Key: HADOOP-11818
 URL: https://issues.apache.org/jira/browse/HADOOP-11818
 Project: Hadoop Common
  Issue Type: Sub-task
  Components: io
Reporter: Rakesh R
Assignee: Rakesh R
 Attachments: HADOOP-11818-001.patch


 Following are few observations while going through the {{erasurecode}} 
 classes.
 \\
 - Use {{org.slf4j.Logger}} instead of {{org.apache.commons.logging.Log}}
 - {{RSErasureDecoder}}, {{RSErasureEncoder}}, {{RSUtil}} missing Apache 
 License header.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HADOOP-11816) Remove Apache Xerces dependency

2015-04-09 Thread Akira AJISAKA (JIRA)
Akira AJISAKA created HADOOP-11816:
--

 Summary: Remove Apache Xerces dependency
 Key: HADOOP-11816
 URL: https://issues.apache.org/jira/browse/HADOOP-11816
 Project: Hadoop Common
  Issue Type: Improvement
  Components: build
Reporter: Akira AJISAKA


Apache Xerces is no longer used in trunk and branch-2 but the dependency 
exists. It can be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11814) Reformat hadoop-annotations, o.a.h.classification.tools

2015-04-09 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487243#comment-14487243
 ] 

Hudson commented on HADOOP-11814:
-

SUCCESS: Integrated in Hadoop-Yarn-trunk #892 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk/892/])
HADOOP-11814. Reformat hadoop-annotations, o.a.h.classification.tools. 
Contributed by Li Lu. (wheat9: rev dc0282d64c6528b02aa9f2df49be01223f087081)
* 
hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/RootDocProcessor.java
* 
hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsStandardDoclet.java
* hadoop-common-project/hadoop-common/CHANGES.txt
* 
hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/StabilityOptions.java
* 
hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsJDiffDoclet.java


 Reformat hadoop-annotations, o.a.h.classification.tools
 ---

 Key: HADOOP-11814
 URL: https://issues.apache.org/jira/browse/HADOOP-11814
 Project: Hadoop Common
  Issue Type: Task
Reporter: Li Lu
Assignee: Li Lu
Priority: Minor
  Labels: formatting
 Fix For: 2.8.0

 Attachments: HADOOP-11814-040815.patch


 RootDocProcessor has some indentation problems. It mixes tabs and spaces for 
 indentation. We may want to fix this. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-11746) rewrite test-patch.sh

2015-04-09 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated HADOOP-11746:
--
Attachment: HADOOP-11746-13.patch

-13:
* fix an issue where a git ref may be in the future vs. the copy on disk.  We 
no longer do a pull --rebase, but a fetch + checkout --force in jenkins mode.
* shellcheck support beefed up, including now failing on new errors, not if the 
total count was higher. Also smarter about picking up on patches that patch 
shell code that are not in the normal places
* cosmetic fixes for the test table
* renamed populate_unit_table to populate_test_table to better reflect what it 
is
* findbugs moved into its own optional test instead of being tied to javac so 
that pom.xml, native code, etc, won't trigger a run. (This does mean that 
testing findbugs itself will get missed now... but that's a very rare 
occurrence...)


 rewrite test-patch.sh
 -

 Key: HADOOP-11746
 URL: https://issues.apache.org/jira/browse/HADOOP-11746
 Project: Hadoop Common
  Issue Type: Test
  Components: build, test
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Allen Wittenauer
 Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch, 
 HADOOP-11746-02.patch, HADOOP-11746-03.patch, HADOOP-11746-04.patch, 
 HADOOP-11746-05.patch, HADOOP-11746-06.patch, HADOOP-11746-07.patch, 
 HADOOP-11746-09.patch, HADOOP-11746-10.patch, HADOOP-11746-11.patch, 
 HADOOP-11746-12.patch, HADOOP-11746-13.patch


 This code is bad and you should feel bad.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11818) Minor improvements for erasurecode classes

2015-04-09 Thread Kai Zheng (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487286#comment-14487286
 ] 

Kai Zheng commented on HADOOP-11818:


The patch looks great. Thanks!
+1

 Minor improvements for erasurecode classes
 --

 Key: HADOOP-11818
 URL: https://issues.apache.org/jira/browse/HADOOP-11818
 Project: Hadoop Common
  Issue Type: Sub-task
  Components: io
Reporter: Rakesh R
Assignee: Rakesh R
 Attachments: HADOOP-11818-001.patch, HADOOP-11818-002.patch


 Following are few observations while going through the {{erasurecode}} 
 classes.
 \\
 - Use {{org.slf4j.Logger}} instead of {{org.apache.commons.logging.Log}}
 - {{RSErasureDecoder}}, {{RSErasureEncoder}}, {{RSUtil}} missing Apache 
 License header.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-11789) NPE in TestCryptoStreamsWithOpensslAesCtrCryptoCodec

2015-04-09 Thread Yi Liu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yi Liu updated HADOOP-11789:

Attachment: HADOOP-11789.002.patch

[~ste...@apache.org], good idea, we should have a better message, thanks.

Update the patch to give a better message.


 NPE in TestCryptoStreamsWithOpensslAesCtrCryptoCodec 
 -

 Key: HADOOP-11789
 URL: https://issues.apache.org/jira/browse/HADOOP-11789
 Project: Hadoop Common
  Issue Type: Bug
Affects Versions: 3.0.0, 2.8.0
 Environment: ASF Jenkins
Reporter: Steve Loughran
Assignee: Yi Liu
 Attachments: HADOOP-11789.001.patch, HADOOP-11789.002.patch


 NPE surfacing in {{TestCryptoStreamsWithOpensslAesCtrCryptoCodec}} on  Jenkins



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)