[jira] [Commented] (HADOOP-11357) Print information of the build enviornment in test-patch.sh

2015-04-25 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512797#comment-14512797
 ] 

Hadoop QA commented on HADOOP-11357:


(!) A patch to test-patch or smart-apply-patch has been detected. 
Re-executing against the patched versions to perform further tests. 
The console is at 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6181/console in case of 
problems.

 Print information of the build enviornment in test-patch.sh
 ---

 Key: HADOOP-11357
 URL: https://issues.apache.org/jira/browse/HADOOP-11357
 Project: Hadoop Common
  Issue Type: Improvement
Reporter: Haohui Mai
Assignee: Allen Wittenauer
Priority: Minor
 Attachments: HADOOP-11357-00.patch


 Currently test-patch.sh lacks of information such as java version during the 
 build, thus debugging problem like HADOOP-10530 becomes difficult.
 This jira proposes to print out more information in test-patch.sh to simplify 
 debugging.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (HADOOP-6256) Update comments in test-patch.sh to clarify changes done in HADOOP-6250

2015-04-25 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer resolved HADOOP-6256.
--
Resolution: Won't Fix

HADOOP-11746 removed this code since it hasn't been in use for a while. Closing 
as won't fix, as it is no longer relevant for any modern Hadoop source tree.

 Update comments in test-patch.sh to clarify changes done in HADOOP-6250
 ---

 Key: HADOOP-6256
 URL: https://issues.apache.org/jira/browse/HADOOP-6256
 Project: Hadoop Common
  Issue Type: Bug
  Components: build
Reporter: Hemanth Yamijala
  Labels: newbie
 Attachments: HADOOP-6256.patch


 It will be useful to add comments in test-patch.sh for changes done as part 
 of HADOOP-6250 to explain them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (HADOOP-6282) test-patch should verify that FindBugs version used for verification is correct one

2015-04-25 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer resolved HADOOP-6282.
--
Resolution: Implemented

Closing as FindBugs is now implemented via maven.  However it should be noted 
that the command line tools that the test-patch script depends upon are not 
updated.  

 test-patch should verify that FindBugs version used for verification is 
 correct one
 ---

 Key: HADOOP-6282
 URL: https://issues.apache.org/jira/browse/HADOOP-6282
 Project: Hadoop Common
  Issue Type: Improvement
  Components: build, test
Reporter: Konstantin Boudnik

 There's a possibility that contributors and commiters might be checking their 
 patches against a version of FindBugs which differs from one installed on 
 Hudson.
 test-patch script has to verify if the version of FindBugs is correct.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (HADOOP-6300) Increase maxwarns for javac in test-patch

2015-04-25 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer resolved HADOOP-6300.
--
Resolution: Won't Fix

A different method for dealing with warnings has been implemented instead. 
Closing.

 Increase maxwarns for javac in test-patch
 -

 Key: HADOOP-6300
 URL: https://issues.apache.org/jira/browse/HADOOP-6300
 Project: Hadoop Common
  Issue Type: Improvement
  Components: build
Reporter: Amareshwari Sriramadasu
Assignee: Giridharan Kesavan

 Increase maxwarns for javac in test-patch to a higher number like 10,000. See 
 comment 
 https://issues.apache.org/jira/browse/MAPREDUCE-769?focusedCommentId=12763375page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12763375



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (HADOOP-8344) Improve test-patch to make it easier to find javadoc warnings

2015-04-25 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer resolved HADOOP-8344.
--
Resolution: Implemented

This has been implemented already. Closing.

 Improve test-patch to make it easier to find javadoc warnings
 -

 Key: HADOOP-8344
 URL: https://issues.apache.org/jira/browse/HADOOP-8344
 Project: Hadoop Common
  Issue Type: Improvement
  Components: build, test
Reporter: Todd Lipcon
Priority: Minor
 Attachments: sketch.txt


 Often I have to spend a lot of time digging through logs to find javadoc 
 warnings as the result of a test-patch. Similar to the improvement made in 
 HADOOP-8339, we should do the following:
 - test-patch should only run javadoc on modules that have changed
 - the exclusions OK_JAVADOC should be per-project rather than cross-project
 - rather than just have a number, we should check in the actual list of 
 warnings to ignore and then fuzzy-match the patch warnings against the 
 exclude list.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11590) Update sbin commands and documentation to use new --slaves option

2015-04-25 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512648#comment-14512648
 ] 

Hadoop QA commented on HADOOP-11590:


\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |   2m 48s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | release audit |   0m 20s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | site |   2m 52s | Site still builds. |
| {color:blue}0{color} | shellcheck |   2m 52s | Shellcheck was not available. |
| | |   6m  4s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12728166/HADOOP-11590-03.patch |
| Optional Tests | site shellcheck |
| git revision | trunk / f83c55a |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6179/console |


This message was automatically generated.

 Update sbin commands and documentation to use new --slaves option
 -

 Key: HADOOP-11590
 URL: https://issues.apache.org/jira/browse/HADOOP-11590
 Project: Hadoop Common
  Issue Type: Bug
  Components: documentation, scripts
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Allen Wittenauer
Priority: Blocker
 Attachments: HADOOP-11590-00.patch, HADOOP-11590-01.patch, 
 HADOOP-11590-02.patch, HADOOP-11590-03.patch


 With HADOOP-11565 now committed, we need to remove usages of yarn-daemons.sh 
 and hadoop-daemons.sh from the start and stop scripts, converting them to use 
 the new --slaves option.  Additionally, the documentation should be updated 
 to reflect these new command options.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (HADOOP-7926) Test-patch should have maven.test.failure.ignore,maven.test.error.ignore to run all the tests even in case of failure/error.

2015-04-25 Thread Allen Wittenauer (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-7926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512811#comment-14512811
 ] 

Allen Wittenauer edited comment on HADOOP-7926 at 4/26/15 1:02 AM:
---

This was implemented at some point (via -fae command line option). Closing.


was (Author: aw):
This was implemented at some point. Closing.

 Test-patch should have maven.test.failure.ignore,maven.test.error.ignore to 
 run all the tests even in case of failure/error.
 

 Key: HADOOP-7926
 URL: https://issues.apache.org/jira/browse/HADOOP-7926
 Project: Hadoop Common
  Issue Type: Bug
  Components: build
Affects Versions: 0.23.0
Reporter: Ravi Teja Ch N V
 Attachments: HADOOP-7926.patch


 This approach will help to know all the failures even if some testcase fails.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-7926) Test-patch should have maven.test.failure.ignore,maven.test.error.ignore to run all the tests even in case of failure/error.

2015-04-25 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-7926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated HADOOP-7926:
-
Resolution: Implemented
Status: Resolved  (was: Patch Available)

This was implemented at some point. Closing.

 Test-patch should have maven.test.failure.ignore,maven.test.error.ignore to 
 run all the tests even in case of failure/error.
 

 Key: HADOOP-7926
 URL: https://issues.apache.org/jira/browse/HADOOP-7926
 Project: Hadoop Common
  Issue Type: Bug
  Components: build
Affects Versions: 0.23.0
Reporter: Ravi Teja Ch N V
 Attachments: HADOOP-7926.patch


 This approach will help to know all the failures even if some testcase fails.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (HADOOP-8875) test-patch.sh doesn't test changes to itself

2015-04-25 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer resolved HADOOP-8875.
--
Resolution: Implemented

 test-patch.sh doesn't test changes to itself
 

 Key: HADOOP-8875
 URL: https://issues.apache.org/jira/browse/HADOOP-8875
 Project: Hadoop Common
  Issue Type: Bug
  Components: build
Reporter: Eli Collins

 The test-patch.sh script run by the pre commit jobs doesn't handle patches 
 that modify test-patch.sh itself, let's modify it to do so or at least log a 
 warning in the test-patch output to indicate the submitter should test 
 test-patch themselves.   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-8875) test-patch.sh doesn't test changes to itself

2015-04-25 Thread Allen Wittenauer (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512770#comment-14512770
 ] 

Allen Wittenauer commented on HADOOP-8875:
--

test-patch.sh now tests itself as of HADOOP-11746.

 test-patch.sh doesn't test changes to itself
 

 Key: HADOOP-8875
 URL: https://issues.apache.org/jira/browse/HADOOP-8875
 Project: Hadoop Common
  Issue Type: Bug
  Components: build
Reporter: Eli Collins

 The test-patch.sh script run by the pre commit jobs doesn't handle patches 
 that modify test-patch.sh itself, let's modify it to do so or at least log a 
 warning in the test-patch output to indicate the submitter should test 
 test-patch themselves.   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-9330) Add custom JUnit4 test runner with configurable timeout

2015-04-25 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-9330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512788#comment-14512788
 ] 

Hadoop QA commented on HADOOP-9330:
---

\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |   5m  6s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to 
include 1 new or modified test files. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | javac |   7m 24s | There were no new javac warning 
messages. |
| {color:green}+1{color} | release audit |   0m 19s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   5m 25s | There were no new checkstyle 
issues. |
| {color:green}+1{color} | install |   1m 29s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 32s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 38s | The patch does not introduce 
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | common tests |  23m  4s | Tests passed in 
hadoop-common. |
| | |  45m  0s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12573149/HADOOP-9330-timeouts-1.patch
 |
| Optional Tests | javac unit findbugs checkstyle |
| git revision | trunk / a00e001 |
| hadoop-common test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6180/artifact/patchprocess/testrun_hadoop-common.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6180/testReport/ |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6180/console |


This message was automatically generated.

 Add custom JUnit4 test runner with configurable timeout
 ---

 Key: HADOOP-9330
 URL: https://issues.apache.org/jira/browse/HADOOP-9330
 Project: Hadoop Common
  Issue Type: Test
  Components: test
Affects Versions: 3.0.0
Reporter: Steve Loughran
 Attachments: HADOOP-9330-timeouts-1.patch


 HADOOP-9112 has added a requirement for all new test methods to declare a 
 timeout, so that jenkins/maven builds will have better information on a 
 timeout.
 Hard coding timeouts into tests is dangerous as it will generate spurious 
 failures on slower machines/networks and when debugging a test.
 I propose providing a custom JUnit4 test runner that test cases can declare 
 as their test runner; this can provide timeouts specified at run-time, rather 
 than in-source.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-11457) Correction to BUILDING.txt: Update FindBugs to 3.0.0

2015-04-25 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated HADOOP-11457:
--
Release Note:   (was: Removed references to FindBugs.  The Maven FindBugs 
Plugin automatically downloads this dependency.
)

 Correction to BUILDING.txt: Update FindBugs to 3.0.0
 

 Key: HADOOP-11457
 URL: https://issues.apache.org/jira/browse/HADOOP-11457
 Project: Hadoop Common
  Issue Type: Bug
  Components: documentation
Affects Versions: 2.6.0
Reporter: Rick Kellogg
Assignee: Rick Kellogg
Priority: Minor
  Labels: newbie
 Attachments: HADOOP-11457-1.patch


 Based on Hadoop QA message shown in HADOOP-11402, it appears FindBugs 2.0.3 
 is used.  Latest release is 3.0.0.
 Updating BUILDING.txt to reflect usage of v 2.0.3 instead of 1.3.9.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-11590) Update sbin commands and documentation to use new --slaves option

2015-04-25 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated HADOOP-11590:
--
Attachment: HADOOP-11590-03.patch

-03.
* addresses comments

bq. For '--hostnames' and '--hosts', if not provided, then 'slaves' file will 
be used. This should be mentioned in doc.

It's implied, but I'll make it more explicit.

bq. I doubt whether yarn configurations would be loaded while getting this 
configurations. Because hdfs getconf is a Hdfs tool and loads only Hdfs 
configurations using HdfsConfiguration.init();. have you verified this?

I've been using this since it was added.  Despite getconf being an hdfs 
command, it works for pretty much everything.  It's sort of dumb that it is 
hidden in hdfs, but oh well.

{code}
$ bin/hdfs getconf -confKey yarn.nodemanager.aux-services
mapreduce_shuffle
$ bin/hdfs getconf -confKey mapreduce.framework.name
yarn
$ bin/hdfs getconf -confKey hadoop.security.auth_to_local
RULE:[1:$1@$0]s/([^@]+)@([^\.]+).COM/$2-$1/ 
{code}


 Update sbin commands and documentation to use new --slaves option
 -

 Key: HADOOP-11590
 URL: https://issues.apache.org/jira/browse/HADOOP-11590
 Project: Hadoop Common
  Issue Type: Bug
  Components: documentation, scripts
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Allen Wittenauer
Priority: Blocker
  Labels: BB2015-05-TBR
 Attachments: HADOOP-11590-00.patch, HADOOP-11590-01.patch, 
 HADOOP-11590-02.patch, HADOOP-11590-03.patch


 With HADOOP-11565 now committed, we need to remove usages of yarn-daemons.sh 
 and hadoop-daemons.sh from the start and stop scripts, converting them to use 
 the new --slaves option.  Additionally, the documentation should be updated 
 to reflect these new command options.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-11590) Update sbin commands and documentation to use new --slaves option

2015-04-25 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated HADOOP-11590:
--
Labels:   (was: BB2015-05-TBR)

 Update sbin commands and documentation to use new --slaves option
 -

 Key: HADOOP-11590
 URL: https://issues.apache.org/jira/browse/HADOOP-11590
 Project: Hadoop Common
  Issue Type: Bug
  Components: documentation, scripts
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Allen Wittenauer
Priority: Blocker
 Attachments: HADOOP-11590-00.patch, HADOOP-11590-01.patch, 
 HADOOP-11590-02.patch, HADOOP-11590-03.patch


 With HADOOP-11565 now committed, we need to remove usages of yarn-daemons.sh 
 and hadoop-daemons.sh from the start and stop scripts, converting them to use 
 the new --slaves option.  Additionally, the documentation should be updated 
 to reflect these new command options.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-11357) Print information of the build enviornment in test-patch.sh

2015-04-25 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated HADOOP-11357:
--
Assignee: Allen Wittenauer  (was: Li Lu)
  Status: Patch Available  (was: Open)

 Print information of the build enviornment in test-patch.sh
 ---

 Key: HADOOP-11357
 URL: https://issues.apache.org/jira/browse/HADOOP-11357
 Project: Hadoop Common
  Issue Type: Improvement
Reporter: Haohui Mai
Assignee: Allen Wittenauer
Priority: Minor
 Attachments: HADOOP-11357-00.patch


 Currently test-patch.sh lacks of information such as java version during the 
 build, thus debugging problem like HADOOP-10530 becomes difficult.
 This jira proposes to print out more information in test-patch.sh to simplify 
 debugging.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (HADOOP-7670) test-patch should not -1 for just build changes

2015-04-25 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer resolved HADOOP-7670.
--
Resolution: Implemented

This is pretty much what HADOOP-11746 does.  Closing as implemented.

 test-patch should not -1 for just build changes
 ---

 Key: HADOOP-7670
 URL: https://issues.apache.org/jira/browse/HADOOP-7670
 Project: Hadoop Common
  Issue Type: Improvement
  Components: build
Affects Versions: 3.0.0
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans
Priority: Minor

 If all a patch changed was build scripts then there should be an exemption to 
 the required test changes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (HADOOP-8483) test-patch +1 even there are build failures

2015-04-25 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-8483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer resolved HADOOP-8483.
--
Resolution: Invalid

Closing as stale.

 test-patch +1 even there are build failures
 ---

 Key: HADOOP-8483
 URL: https://issues.apache.org/jira/browse/HADOOP-8483
 Project: Hadoop Common
  Issue Type: Improvement
Reporter: Tsz Wo Nicholas Sze
Priority: Critical

 For example, there are build failures in [build 
 #1062|https://builds.apache.org/job/PreCommit-HADOOP-Build/1062/console] but 
 it still has all +1's.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-7670) test-patch should not -1 for just build changes

2015-04-25 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated HADOOP-7670:
-
Affects Version/s: (was: 0.24.0)
   3.0.0

 test-patch should not -1 for just build changes
 ---

 Key: HADOOP-7670
 URL: https://issues.apache.org/jira/browse/HADOOP-7670
 Project: Hadoop Common
  Issue Type: Improvement
  Components: build
Affects Versions: 3.0.0
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans
Priority: Minor

 If all a patch changed was build scripts then there should be an exemption to 
 the required test changes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-7670) test-patch should not -1 for lack of tests just build changes

2015-04-25 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated HADOOP-7670:
-
Summary: test-patch should not -1 for lack of tests just build changes  
(was: test-patch should not -1 for just build changes)

 test-patch should not -1 for lack of tests just build changes
 -

 Key: HADOOP-7670
 URL: https://issues.apache.org/jira/browse/HADOOP-7670
 Project: Hadoop Common
  Issue Type: Improvement
  Components: build
Affects Versions: 3.0.0
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans
Priority: Minor

 If all a patch changed was build scripts then there should be an exemption to 
 the required test changes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-7670) test-patch should not -1 for just build changes

2015-04-25 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated HADOOP-7670:
-
Target Version/s: 3.0.0  (was: 0.24.0)

 test-patch should not -1 for just build changes
 ---

 Key: HADOOP-7670
 URL: https://issues.apache.org/jira/browse/HADOOP-7670
 Project: Hadoop Common
  Issue Type: Improvement
  Components: build
Affects Versions: 3.0.0
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans
Priority: Minor

 If all a patch changed was build scripts then there should be an exemption to 
 the required test changes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (HADOOP-7107) Ability to retrigger Hudson QA bot without re-uploading patch

2015-04-25 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-7107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer resolved HADOOP-7107.
--
Resolution: Implemented

Cancel+submit pair usually works. Closing as implemented.

 Ability to retrigger Hudson QA bot without re-uploading patch
 -

 Key: HADOOP-7107
 URL: https://issues.apache.org/jira/browse/HADOOP-7107
 Project: Hadoop Common
  Issue Type: Test
  Components: test
Reporter: Todd Lipcon

 Currently to retrigger the test-patch bot you have to upload a new patch. 
 This doesn't work well for a couple cases:
 - sometimes a build fails due to issues on a build machine (eg all tests 
 timed out) and you want to give it another go
 - sometimes a test sits in patch available state for a couple weeks and it 
 would be good to re-verify the patch before committing
 Committers can retrigger from the Hudson UI, but we should have something 
 that any contributor can use. I would suggest a magic string to put in a 
 comment (eg @hudson.build) which the script would watch for and trigger on



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (HADOOP-5628) Create target for 10 minute patch test build

2015-04-25 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer resolved HADOOP-5628.
--
Resolution: Invalid

Closing this as stale.

test-patch.sh is now very smart about what it does.  The problem is now that a 
lot of the tests are out of control in how long they run (hadoop-hdfs, for 
example, is usually 2 hours on its own...)

 Create target for 10 minute patch test build
 

 Key: HADOOP-5628
 URL: https://issues.apache.org/jira/browse/HADOOP-5628
 Project: Hadoop Common
  Issue Type: Bug
  Components: test
Reporter: Owen O'Malley

 I think we should create an ant target that performs a smoke test on the 
 patched system to enable developers to have faster turn around time on 
 developing patches than the 3 hour unit tests that we currently have.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-11590) Update sbin commands and documentation to use new --slaves option

2015-04-25 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated HADOOP-11590:
--
Labels: BB2015-05-TBR  (was: )

 Update sbin commands and documentation to use new --slaves option
 -

 Key: HADOOP-11590
 URL: https://issues.apache.org/jira/browse/HADOOP-11590
 Project: Hadoop Common
  Issue Type: Bug
  Components: documentation, scripts
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Allen Wittenauer
Priority: Blocker
  Labels: BB2015-05-TBR
 Attachments: HADOOP-11590-00.patch, HADOOP-11590-01.patch, 
 HADOOP-11590-02.patch


 With HADOOP-11565 now committed, we need to remove usages of yarn-daemons.sh 
 and hadoop-daemons.sh from the start and stop scripts, converting them to use 
 the new --slaves option.  Additionally, the documentation should be updated 
 to reflect these new command options.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (HADOOP-11320) Submitting a hadoop patch doesn't trigger jenkins test run

2015-04-25 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer resolved HADOOP-11320.
---
Resolution: Fixed

Based upon the previous discussion, it looks as though this should get closed 
as fixed.

 Submitting a hadoop patch doesn't trigger jenkins test run
 --

 Key: HADOOP-11320
 URL: https://issues.apache.org/jira/browse/HADOOP-11320
 Project: Hadoop Common
  Issue Type: Bug
  Components: build
Reporter: Yongjun Zhang
 Attachments: HADOOP-11293.003.patch


 See details in INFRA-8655.
 Per [~abayer] and [~cnauroth]'s feedback there , I'm creating this jira to 
 investigate the possible bug in dev-support/test-patch.sh script.
 Thanks Andrew and Chris.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (HADOOP-7620) All profiles should build the javadoc

2015-04-25 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-7620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer resolved HADOOP-7620.
--
Resolution: Won't Fix

Closing as won't fix. test-patch has been much better about testing the javadoc 
for a while now.

 All profiles should build the javadoc
 -

 Key: HADOOP-7620
 URL: https://issues.apache.org/jira/browse/HADOOP-7620
 Project: Hadoop Common
  Issue Type: Improvement
Reporter: Owen O'Malley

 Currently, the default profile doesn't generate the javadoc, which gives the 
 developer a false sense of security. Leaving the forrest stuff in the doc 
 profile makes sense.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11357) Print information of the build enviornment in test-patch.sh

2015-04-25 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512798#comment-14512798
 ] 

Hadoop QA commented on HADOOP-11357:


\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | reexec |   0m  0s | dev-support patch detected. |
| {color:blue}0{color} | pre-patch |   0m  0s | Pre-patch trunk compilation is 
healthy. |
| {color:blue}0{color} | @author |   0m  0s | Skipping @author checks as 
test-patch has been patched. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | release audit |   0m 15s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:blue}0{color} | shellcheck |   0m 15s | Shellcheck was not available. |
| | |   0m 17s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12728185/HADOOP-11357-00.patch |
| Optional Tests | shellcheck |
| git revision | trunk / a00e001 |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6181/console |


This message was automatically generated.

 Print information of the build enviornment in test-patch.sh
 ---

 Key: HADOOP-11357
 URL: https://issues.apache.org/jira/browse/HADOOP-11357
 Project: Hadoop Common
  Issue Type: Improvement
Reporter: Haohui Mai
Assignee: Allen Wittenauer
Priority: Minor
 Attachments: HADOOP-11357-00.patch


 Currently test-patch.sh lacks of information such as java version during the 
 build, thus debugging problem like HADOOP-10530 becomes difficult.
 This jira proposes to print out more information in test-patch.sh to simplify 
 debugging.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-11457) Correction to BUILDING.txt: Update FindBugs to 3.0.0

2015-04-25 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated HADOOP-11457:
--
Labels: newbie  (was: )

 Correction to BUILDING.txt: Update FindBugs to 3.0.0
 

 Key: HADOOP-11457
 URL: https://issues.apache.org/jira/browse/HADOOP-11457
 Project: Hadoop Common
  Issue Type: Bug
  Components: documentation
Affects Versions: 2.6.0
Reporter: Rick Kellogg
Assignee: Rick Kellogg
Priority: Minor
  Labels: newbie
 Attachments: HADOOP-11457-1.patch


 Based on Hadoop QA message shown in HADOOP-11402, it appears FindBugs 2.0.3 
 is used.  Latest release is 3.0.0.
 Updating BUILDING.txt to reflect usage of v 2.0.3 instead of 1.3.9.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11764) Hadoop should have the option to use directory other than tmp for extracting and loading leveldbjni

2015-04-25 Thread Vinod Kumar Vavilapalli (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512695#comment-14512695
 ] 

Vinod Kumar Vavilapalli commented on HADOOP-11764:
--

bq. ... until it can proven otherwise that this can't be handled via *-site.xml.
This can also mean *-env.sh.

[~adhoot] / [~zjshen], it seems weird that we have an option just for leveldb. 
In the past, we used hadoop.tmp.dir for stuff like this. And if needed, we 
could also use HADOOP_OPTS/ HADOOP_YARN_OPTS etc at each site. Why wouldn't 
that work?

 Hadoop should have the option to use directory other than tmp for extracting 
 and loading leveldbjni
 ---

 Key: HADOOP-11764
 URL: https://issues.apache.org/jira/browse/HADOOP-11764
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Anubhav Dhoot
Assignee: Anubhav Dhoot
 Attachments: YARN-3331.001.patch, YARN-3331.002.patch


 /tmp can be  required to be noexec in many environments. This causes a 
 problem when  nodemanager tries to load the leveldbjni library which can get 
 unpacked and executed from /tmp.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-9330) Add custom JUnit4 test runner with configurable timeout

2015-04-25 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-9330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated HADOOP-9330:
-
Status: Patch Available  (was: Open)

 Add custom JUnit4 test runner with configurable timeout
 ---

 Key: HADOOP-9330
 URL: https://issues.apache.org/jira/browse/HADOOP-9330
 Project: Hadoop Common
  Issue Type: Test
  Components: test
Affects Versions: 3.0.0
Reporter: Steve Loughran
 Attachments: HADOOP-9330-timeouts-1.patch


 HADOOP-9112 has added a requirement for all new test methods to declare a 
 timeout, so that jenkins/maven builds will have better information on a 
 timeout.
 Hard coding timeouts into tests is dangerous as it will generate spurious 
 failures on slower machines/networks and when debugging a test.
 I propose providing a custom JUnit4 test runner that test cases can declare 
 as their test runner; this can provide timeouts specified at run-time, rather 
 than in-source.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-9330) Add custom JUnit4 test runner with configurable timeout

2015-04-25 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-9330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated HADOOP-9330:
-
Status: Open  (was: Patch Available)

 Add custom JUnit4 test runner with configurable timeout
 ---

 Key: HADOOP-9330
 URL: https://issues.apache.org/jira/browse/HADOOP-9330
 Project: Hadoop Common
  Issue Type: Test
  Components: test
Affects Versions: 3.0.0
Reporter: Steve Loughran
 Attachments: HADOOP-9330-timeouts-1.patch


 HADOOP-9112 has added a requirement for all new test methods to declare a 
 timeout, so that jenkins/maven builds will have better information on a 
 timeout.
 Hard coding timeouts into tests is dangerous as it will generate spurious 
 failures on slower machines/networks and when debugging a test.
 I propose providing a custom JUnit4 test runner that test cases can declare 
 as their test runner; this can provide timeouts specified at run-time, rather 
 than in-source.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-11357) Print information of the build enviornment in test-patch.sh

2015-04-25 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated HADOOP-11357:
--
Attachment: HADOOP-11357-00.patch

Revisiting this one.

There is currently some secret info sitting in the env vars on the Jenkins 
hosts that we really shouldn't expose.  But dumping uname -a and java -version 
is pretty simple with the new table-based structure.

 Print information of the build enviornment in test-patch.sh
 ---

 Key: HADOOP-11357
 URL: https://issues.apache.org/jira/browse/HADOOP-11357
 Project: Hadoop Common
  Issue Type: Improvement
Reporter: Haohui Mai
Assignee: Li Lu
Priority: Minor
 Attachments: HADOOP-11357-00.patch


 Currently test-patch.sh lacks of information such as java version during the 
 build, thus debugging problem like HADOOP-10530 becomes difficult.
 This jira proposes to print out more information in test-patch.sh to simplify 
 debugging.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (HADOOP-7790) hadoop-yarn-api - generate-sources build step waits for input

2015-04-25 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer resolved HADOOP-7790.
--
Resolution: Cannot Reproduce

Closing as stale.

 hadoop-yarn-api - generate-sources build step waits for input
 -

 Key: HADOOP-7790
 URL: https://issues.apache.org/jira/browse/HADOOP-7790
 Project: Hadoop Common
  Issue Type: Bug
  Components: build
Affects Versions: 0.23.0
Reporter: Bruno Mahé

 At the step:
 exec-maven-plugin:1.2:exec (generate-sources) @ hadoop-yarn-api ---
 the build will wait for user input and eventually fails after some timeouts.
 It does that twice



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11872) hadoop dfs command prints message about using yarn jar on Windows(branch-2 only)

2015-04-25 Thread Allen Wittenauer (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512852#comment-14512852
 ] 

Allen Wittenauer commented on HADOOP-11872:
---

bq. git revisionbranch-2 / 0ec6e7e 

(hooray! branch detection worked! :D )

 hadoop dfs command prints message about using yarn jar on 
 Windows(branch-2 only)
 

 Key: HADOOP-11872
 URL: https://issues.apache.org/jira/browse/HADOOP-11872
 Project: Hadoop Common
  Issue Type: Bug
  Components: scripts
Affects Versions: 2.7.0
Reporter: Varun Vasudev
Assignee: Varun Vasudev
Priority: Minor
 Fix For: 2.7.1

 Attachments: HADOOP-11872-branch-2.001.patch


 Using the hadoop dfs command on a branch-2 build prints a message about 
 using yarn jar.
 {noformat}
 C:\hadoop\hadoop-common-project\hadoop-common\src\main\bin hadoop.cmd dfs -ls
note: please use yarn jar to launch
  YARN applications, not this command.
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11865) Incorrect path mentioned in document for accessing script files

2015-04-25 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512903#comment-14512903
 ] 

Hadoop QA commented on HADOOP-11865:


\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |   3m 35s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | release audit |   0m 19s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | site |   2m 55s | Site still builds. |
| | |   6m 52s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12728208/HADOOP-11865_Trunk.1.patch
 |
| Optional Tests | site |
| git revision | trunk / 22b70e7 |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6183/console |


This message was automatically generated.

 Incorrect path mentioned in document for accessing script files
 ---

 Key: HADOOP-11865
 URL: https://issues.apache.org/jira/browse/HADOOP-11865
 Project: Hadoop Common
  Issue Type: Bug
  Components: documentation
Reporter: J.Andreina
Assignee: J.Andreina
 Attachments: HADOOP-11865_Trunk.1.patch


 Instead of sbin it is mentioned as bin in path to access script files.
 1. http://hadoop.apache.org/docs/current/hadoop-kms/index.html
   To start/stop KMS use KMS's *bin/kms.sh* script. For example:
 2.http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-hdfs/HdfsUserGuide.html
 Run the new version with -upgrade option *(bin/start-dfs.sh -upgrade).*
 3. start the cluster with rollback option. *(bin/start-dfs.sh -rollback).*
 4.http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-hdfs/Federation.html
 */bin/hadoop-daemon.sh* --config $HADOOP_CONF_DIR --script $bin/hdfs start 
 balancer [-policy policy]
 5.*bin/distributed-exclude.sh* exclude_file
 6.*bin/refresh-namenodes.sh*
 Need to check for any other occurrences and fix the same



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11866) increase readability of the output of white space and checkstyle script

2015-04-25 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512897#comment-14512897
 ] 

Hadoop QA commented on HADOOP-11866:


\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | reexec |   0m  0s | dev-support patch detected. |
| {color:blue}0{color} | pre-patch |   0m  0s | Pre-patch trunk compilation is 
healthy. |
| {color:blue}0{color} | @author |   0m  0s | Skipping @author checks as 
test-patch has been patched. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | release audit |   0m 14s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:blue}0{color} | shellcheck |   0m 14s | Shellcheck was not available. |
| | |   0m 18s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12728212/HADOOP-11866-checkstyle.patch
 |
| Optional Tests | shellcheck |
| git revision | trunk / 22b70e7 |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6182/console |


This message was automatically generated.

 increase readability of the output of white space and checkstyle script
 ---

 Key: HADOOP-11866
 URL: https://issues.apache.org/jira/browse/HADOOP-11866
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Naganarasimha G R
Assignee: Naganarasimha G R
Priority: Minor
 Attachments: HADOOP-11866-checkstyle.patch, 
 HADOOP-11866.20150422-1.patch, HADOOP-11866.20150423-1.patch


 HADOOP-11746 supports listing of the lines which has trailing white spaces 
 but doesn't inform patch line number. Without this report output will not be 
 of much help as in most cases it reports blank lines. Also for the first 
 timers it would be difficult to understand the output check style script 
 hence adding an header



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11866) increase readability of the output of white space and checkstyle script

2015-04-25 Thread Allen Wittenauer (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512900#comment-14512900
 ] 

Allen Wittenauer commented on HADOOP-11866:
---

(p.s., some of the ideas in that thought balloon patch should probably be 
ported over to shellcheck.sh.)

 increase readability of the output of white space and checkstyle script
 ---

 Key: HADOOP-11866
 URL: https://issues.apache.org/jira/browse/HADOOP-11866
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Naganarasimha G R
Assignee: Naganarasimha G R
Priority: Minor
 Attachments: HADOOP-11866-checkstyle.patch, 
 HADOOP-11866.20150422-1.patch, HADOOP-11866.20150423-1.patch


 HADOOP-11746 supports listing of the lines which has trailing white spaces 
 but doesn't inform patch line number. Without this report output will not be 
 of much help as in most cases it reports blank lines. Also for the first 
 timers it would be difficult to understand the output check style script 
 hence adding an header



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11866) increase readability of the output of white space and checkstyle script

2015-04-25 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512896#comment-14512896
 ] 

Hadoop QA commented on HADOOP-11866:


(!) A patch to test-patch or smart-apply-patch has been detected. 
Re-executing against the patched versions to perform further tests. 
The console is at 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6182/console in case of 
problems.

 increase readability of the output of white space and checkstyle script
 ---

 Key: HADOOP-11866
 URL: https://issues.apache.org/jira/browse/HADOOP-11866
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Naganarasimha G R
Assignee: Naganarasimha G R
Priority: Minor
 Attachments: HADOOP-11866-checkstyle.patch, 
 HADOOP-11866.20150422-1.patch, HADOOP-11866.20150423-1.patch


 HADOOP-11746 supports listing of the lines which has trailing white spaces 
 but doesn't inform patch line number. Without this report output will not be 
 of much help as in most cases it reports blank lines. Also for the first 
 timers it would be difficult to understand the output check style script 
 hence adding an header



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-11866) increase readability of the output of white space and checkstyle script

2015-04-25 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated HADOOP-11866:
--
Attachment: HADOOP-11866-checkstyle.patch

-checkstyle.patch:
* Here's a modified version of the checkstyle.sh plug-in. It still needs some 
work, but gets us most of the way there.

A few things:
* It looks like output.file doesn't actually work.  So I opted to play games 
with the console output. 
* New method written in shell to determine if there are actually new issues.  I 
think it works?
* Showing what is actually different is significantly harder than I thought it 
would be because of magically changing line numbers.  An sdiff -s output 
*might* be better here.  

Anyway, some code to play with and fill in the gaps if you want.

 increase readability of the output of white space and checkstyle script
 ---

 Key: HADOOP-11866
 URL: https://issues.apache.org/jira/browse/HADOOP-11866
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Naganarasimha G R
Assignee: Naganarasimha G R
Priority: Minor
 Attachments: HADOOP-11866-checkstyle.patch, 
 HADOOP-11866.20150422-1.patch, HADOOP-11866.20150423-1.patch


 HADOOP-11746 supports listing of the lines which has trailing white spaces 
 but doesn't inform patch line number. Without this report output will not be 
 of much help as in most cases it reports blank lines. Also for the first 
 timers it would be difficult to understand the output check style script 
 hence adding an header



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-11357) Print information of the build enviornment in test-patch.sh

2015-04-25 Thread Chris Nauroth (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-11357:
---
 Component/s: scripts
Target Version/s: 2.8.0
Hadoop Flags: Reviewed

+1 for the patch.  Thank you, Allen.

 Print information of the build enviornment in test-patch.sh
 ---

 Key: HADOOP-11357
 URL: https://issues.apache.org/jira/browse/HADOOP-11357
 Project: Hadoop Common
  Issue Type: Improvement
  Components: scripts
Reporter: Haohui Mai
Assignee: Allen Wittenauer
Priority: Minor
 Attachments: HADOOP-11357-00.patch


 Currently test-patch.sh lacks of information such as java version during the 
 build, thus debugging problem like HADOOP-10530 becomes difficult.
 This jira proposes to print out more information in test-patch.sh to simplify 
 debugging.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-11865) Incorrect path mentioned in document for accessing script files

2015-04-25 Thread J.Andreina (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

J.Andreina updated HADOOP-11865:

Attachment: HADOOP-11865_Trunk.1.patch

Attached a patch for trunk . Please review. 

For this issue ,there are few more changes needs to be done for Branch2 (along 
with changes done for trunk). Shall i provide a separate patch for Branch2 ? 

 Incorrect path mentioned in document for accessing script files
 ---

 Key: HADOOP-11865
 URL: https://issues.apache.org/jira/browse/HADOOP-11865
 Project: Hadoop Common
  Issue Type: Bug
  Components: documentation
Reporter: J.Andreina
Assignee: J.Andreina
 Attachments: HADOOP-11865_Trunk.1.patch


 Instead of sbin it is mentioned as bin in path to access script files.
 1. http://hadoop.apache.org/docs/current/hadoop-kms/index.html
   To start/stop KMS use KMS's *bin/kms.sh* script. For example:
 2.http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-hdfs/HdfsUserGuide.html
 Run the new version with -upgrade option *(bin/start-dfs.sh -upgrade).*
 3. start the cluster with rollback option. *(bin/start-dfs.sh -rollback).*
 4.http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-hdfs/Federation.html
 */bin/hadoop-daemon.sh* --config $HADOOP_CONF_DIR --script $bin/hdfs start 
 balancer [-policy policy]
 5.*bin/distributed-exclude.sh* exclude_file
 6.*bin/refresh-namenodes.sh*
 Need to check for any other occurrences and fix the same



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-11865) Incorrect path mentioned in document for accessing script files

2015-04-25 Thread J.Andreina (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

J.Andreina updated HADOOP-11865:

Status: Patch Available  (was: Open)

 Incorrect path mentioned in document for accessing script files
 ---

 Key: HADOOP-11865
 URL: https://issues.apache.org/jira/browse/HADOOP-11865
 Project: Hadoop Common
  Issue Type: Bug
  Components: documentation
Reporter: J.Andreina
Assignee: J.Andreina
 Attachments: HADOOP-11865_Trunk.1.patch


 Instead of sbin it is mentioned as bin in path to access script files.
 1. http://hadoop.apache.org/docs/current/hadoop-kms/index.html
   To start/stop KMS use KMS's *bin/kms.sh* script. For example:
 2.http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-hdfs/HdfsUserGuide.html
 Run the new version with -upgrade option *(bin/start-dfs.sh -upgrade).*
 3. start the cluster with rollback option. *(bin/start-dfs.sh -rollback).*
 4.http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-hdfs/Federation.html
 */bin/hadoop-daemon.sh* --config $HADOOP_CONF_DIR --script $bin/hdfs start 
 balancer [-policy policy]
 5.*bin/distributed-exclude.sh* exclude_file
 6.*bin/refresh-namenodes.sh*
 Need to check for any other occurrences and fix the same



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11866) increase readability of the output of white space and checkstyle script

2015-04-25 Thread Allen Wittenauer (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512840#comment-14512840
 ] 

Allen Wittenauer commented on HADOOP-11866:
---

A few things:

a) shellcheck is complaining about the multi-line echos redirecting to a file.  
It's generally preferred now to group them into a subshell and then redirect 
the shell.  But I think the message should really be directed to the patch 
author in the footer table via an add_footer_table call.

b) I think it'd be worthwhile to do quite a bit more hacking on the checkstyle 
module.  When I looked at checkstyle, I was clearly asleep. There are actually 
quite a few things we can do to make this much more usable:

* Switch from the aggregate report to a per module report.  (This should also 
reduce the run time and it makes the other things we should do easier.)

* Rip out the python code.  We aren't going to need it anymore.

* Add -Dcheckstyle.output.file=blah and -Dcheckstyle.output.format=plain to 
both mvn command lines, where blah is the file we want for that module for that 
part of the run.  Strip a large chunk of the leading pathname (${BASEDIR} at a 
minimum, but probably all of ${BASEDIR} and modulename, since the file is 
already broken up by module).

* Now we can perform diffs and such like we do for some of the other tests (see 
shellcheck, for example).  This has the advantage of pointing out the exact 
error on the exact line that broke without having to deal with giant HTML 
files. 


 increase readability of the output of white space and checkstyle script
 ---

 Key: HADOOP-11866
 URL: https://issues.apache.org/jira/browse/HADOOP-11866
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Naganarasimha G R
Assignee: Naganarasimha G R
Priority: Minor
 Attachments: HADOOP-11866.20150422-1.patch, 
 HADOOP-11866.20150423-1.patch


 HADOOP-11746 supports listing of the lines which has trailing white spaces 
 but doesn't inform patch line number. Without this report output will not be 
 of much help as in most cases it reports blank lines. Also for the first 
 timers it would be difficult to understand the output check style script 
 hence adding an header



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-7435) Make pre-commit checks run against the correct branch

2015-04-25 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-7435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated HADOOP-7435:
-
Resolution: Implemented
Status: Resolved  (was: Patch Available)

We've had quite a few runs now where the test-patch.sh contained in 
HADOOP-11746 coupled with its addendum patch HADOOP-11861 have switched to 
branch-2 for appropriately named patches.

Closing this out as implemented, as I suspect anything additional will be a bug 
fix, etc, type of thing.

 Make pre-commit checks run against the correct branch
 -

 Key: HADOOP-7435
 URL: https://issues.apache.org/jira/browse/HADOOP-7435
 Project: Hadoop Common
  Issue Type: Improvement
  Components: test
Affects Versions: 0.23.0
Reporter: Aaron T. Myers
Assignee: Matt Foley
 Attachments: HADOOP-7435-branch-0.23--N2.patch, 
 HADOOP-7435-branch-0.23--N3.patch, HADOOP-7435-branch-0.23--N5.patch, 
 HADOOP-7435-branch-0.23--N6.patch, HADOOP-7435-branch-0.23--N7.patch, 
 HADOOP-7435-branch-0.23-patch-from-[branch-0.23-gd]-to-[fb-HADOOP-7435-branch-0.23-gd]-N2-1.patch,
  HADOOP-7435-branch-2--N2.patch, HADOOP-7435-branch-2--N3-1.patch, 
 HADOOP-7435-branch-2--N5.patch, HADOOP-7435-branch-2--N7.patch, 
 HADOOP-7435-branch-2--N8.patch, HADOOP-7435-for-branch-0.23.patch, 
 HADOOP-7435-for-branch-2.patch, 
 HADOOP-7435-for-trunk-do-not-apply-this.patch, HADOOP-7435-trunk--N1.patch, 
 HADOOP-7435-trunk--N5.patch, JenkinsPatchQueueAdmin.py


 The Hudson pre-commit tests are presently only capable of testing a patch 
 against trunk. It'd be nice if this could be extended to automatically run 
 against the correct branch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11876) Refactor code to make it more readable, minor maybePrintStats bug

2015-04-25 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512412#comment-14512412
 ] 

Hudson commented on HADOOP-11876:
-

FAILURE: Integrated in Hadoop-Yarn-trunk #908 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk/908/])
HADOOP-11876. Refactor code to make it more readable, minor maybePrintStats bug 
(Zoran Dimitrijevic via raviprak) (raviprak: rev 
a287d2fb77d9873b61c6ab24134993d784ae8475)
* hadoop-common-project/hadoop-common/CHANGES.txt
* 
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/SimpleCopyListing.java


 Refactor code to make it more readable, minor maybePrintStats bug
 -

 Key: HADOOP-11876
 URL: https://issues.apache.org/jira/browse/HADOOP-11876
 Project: Hadoop Common
  Issue Type: Bug
  Components: tools/distcp
Affects Versions: 3.0.0
Reporter: Zoran Dimitrijevic
Assignee: Zoran Dimitrijevic
Priority: Trivial
 Fix For: 2.8.0

 Attachments: HADOOP-11876.patch


 This is related to HADOOP-11827 patch from few days ago. I've noticed a minor 
 bug in maybePrintStats logic which is called only when new directory is 
 processed, and prints every 100K objects (effectively, there is a very low 
 probability it'll ever print stats). The reason for this bug is that I was 
 previously printing stats for every new directory, and later decided it's 
 nicer to print stats for large number of new objects (files or directories) 
 instead. 
 This is a minor issue - and since I'm refactoring this I've also changed the 
 minor retry logic to make code nicer and more readable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11843) Make setting up the build environment easier

2015-04-25 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512417#comment-14512417
 ] 

Hudson commented on HADOOP-11843:
-

FAILURE: Integrated in Hadoop-Yarn-trunk #908 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk/908/])
HADOOP-11843. Make setting up the build environment easier. Contributed by 
Niels Basjes. (cnauroth: rev 80935268f5fdd358070c6b68f89e8bd699785c54)
* BUILDING.txt
* start-build-env.sh
* dev-support/docker/hadoop_env_checks.sh
* dev-support/docker/Dockerfile
* hadoop-common-project/hadoop-common/CHANGES.txt


 Make setting up the build environment easier
 

 Key: HADOOP-11843
 URL: https://issues.apache.org/jira/browse/HADOOP-11843
 Project: Hadoop Common
  Issue Type: New Feature
  Components: build
Reporter: Niels Basjes
Assignee: Niels Basjes
 Fix For: 2.8.0

 Attachments: HADOOP-11843-2015-04-17-1612.patch, 
 HADOOP-11843-2015-04-17-2226.patch, HADOOP-11843-2015-04-17-2308.patch, 
 HADOOP-11843-2015-04-19-2206.patch, HADOOP-11843-2015-04-19-2232.patch, 
 HADOOP-11843-2015-04-22-1122.patch, HADOOP-11843-2015-04-23-1000.patch


 ( As discussed with [~aw] )
 In AVRO-1537 a docker based solution was created to setup all the tools for 
 doing a full build. This enables much easier reproduction of any issues and 
 getting up and running for new developers.
 This issue is to 'copy/port' that setup into the hadoop project in 
 preparation for the bug squash.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11876) Refactor code to make it more readable, minor maybePrintStats bug

2015-04-25 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512394#comment-14512394
 ] 

Hudson commented on HADOOP-11876:
-

FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #174 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/174/])
HADOOP-11876. Refactor code to make it more readable, minor maybePrintStats bug 
(Zoran Dimitrijevic via raviprak) (raviprak: rev 
a287d2fb77d9873b61c6ab24134993d784ae8475)
* 
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/SimpleCopyListing.java
* hadoop-common-project/hadoop-common/CHANGES.txt


 Refactor code to make it more readable, minor maybePrintStats bug
 -

 Key: HADOOP-11876
 URL: https://issues.apache.org/jira/browse/HADOOP-11876
 Project: Hadoop Common
  Issue Type: Bug
  Components: tools/distcp
Affects Versions: 3.0.0
Reporter: Zoran Dimitrijevic
Assignee: Zoran Dimitrijevic
Priority: Trivial
 Fix For: 2.8.0

 Attachments: HADOOP-11876.patch


 This is related to HADOOP-11827 patch from few days ago. I've noticed a minor 
 bug in maybePrintStats logic which is called only when new directory is 
 processed, and prints every 100K objects (effectively, there is a very low 
 probability it'll ever print stats). The reason for this bug is that I was 
 previously printing stats for every new directory, and later decided it's 
 nicer to print stats for large number of new objects (files or directories) 
 instead. 
 This is a minor issue - and since I'm refactoring this I've also changed the 
 minor retry logic to make code nicer and more readable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11843) Make setting up the build environment easier

2015-04-25 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512399#comment-14512399
 ] 

Hudson commented on HADOOP-11843:
-

FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #174 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/174/])
HADOOP-11843. Make setting up the build environment easier. Contributed by 
Niels Basjes. (cnauroth: rev 80935268f5fdd358070c6b68f89e8bd699785c54)
* dev-support/docker/Dockerfile
* start-build-env.sh
* hadoop-common-project/hadoop-common/CHANGES.txt
* BUILDING.txt
* dev-support/docker/hadoop_env_checks.sh


 Make setting up the build environment easier
 

 Key: HADOOP-11843
 URL: https://issues.apache.org/jira/browse/HADOOP-11843
 Project: Hadoop Common
  Issue Type: New Feature
  Components: build
Reporter: Niels Basjes
Assignee: Niels Basjes
 Fix For: 2.8.0

 Attachments: HADOOP-11843-2015-04-17-1612.patch, 
 HADOOP-11843-2015-04-17-2226.patch, HADOOP-11843-2015-04-17-2308.patch, 
 HADOOP-11843-2015-04-19-2206.patch, HADOOP-11843-2015-04-19-2232.patch, 
 HADOOP-11843-2015-04-22-1122.patch, HADOOP-11843-2015-04-23-1000.patch


 ( As discussed with [~aw] )
 In AVRO-1537 a docker based solution was created to setup all the tools for 
 doing a full build. This enables much easier reproduction of any issues and 
 getting up and running for new developers.
 This issue is to 'copy/port' that setup into the hadoop project in 
 preparation for the bug squash.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11843) Make setting up the build environment easier

2015-04-25 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512464#comment-14512464
 ] 

Hudson commented on HADOOP-11843:
-

FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #165 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/165/])
HADOOP-11843. Make setting up the build environment easier. Contributed by 
Niels Basjes. (cnauroth: rev 80935268f5fdd358070c6b68f89e8bd699785c54)
* start-build-env.sh
* dev-support/docker/hadoop_env_checks.sh
* hadoop-common-project/hadoop-common/CHANGES.txt
* dev-support/docker/Dockerfile
* BUILDING.txt


 Make setting up the build environment easier
 

 Key: HADOOP-11843
 URL: https://issues.apache.org/jira/browse/HADOOP-11843
 Project: Hadoop Common
  Issue Type: New Feature
  Components: build
Reporter: Niels Basjes
Assignee: Niels Basjes
 Fix For: 2.8.0

 Attachments: HADOOP-11843-2015-04-17-1612.patch, 
 HADOOP-11843-2015-04-17-2226.patch, HADOOP-11843-2015-04-17-2308.patch, 
 HADOOP-11843-2015-04-19-2206.patch, HADOOP-11843-2015-04-19-2232.patch, 
 HADOOP-11843-2015-04-22-1122.patch, HADOOP-11843-2015-04-23-1000.patch


 ( As discussed with [~aw] )
 In AVRO-1537 a docker based solution was created to setup all the tools for 
 doing a full build. This enables much easier reproduction of any issues and 
 getting up and running for new developers.
 This issue is to 'copy/port' that setup into the hadoop project in 
 preparation for the bug squash.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11764) Hadoop should have the option to use directory other than tmp for extracting and loading leveldbjni

2015-04-25 Thread Allen Wittenauer (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512494#comment-14512494
 ] 

Allen Wittenauer commented on HADOOP-11764:
---

[~vinodkv], this is the JIRA we were discussing at Hadoop Summit.  Please take 
a look at it.

... and just so it's official, I'm very much a (binding) -1 on pushing this 
into an environment variable until it can proven otherwise that this can't be 
handled via *-site.xml.

 Hadoop should have the option to use directory other than tmp for extracting 
 and loading leveldbjni
 ---

 Key: HADOOP-11764
 URL: https://issues.apache.org/jira/browse/HADOOP-11764
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Anubhav Dhoot
Assignee: Anubhav Dhoot
 Attachments: YARN-3331.001.patch, YARN-3331.002.patch


 /tmp can be  required to be noexec in many environments. This causes a 
 problem when  nodemanager tries to load the leveldbjni library which can get 
 unpacked and executed from /tmp.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11876) Refactor code to make it more readable, minor maybePrintStats bug

2015-04-25 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512536#comment-14512536
 ] 

Hudson commented on HADOOP-11876:
-

FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #175 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/175/])
HADOOP-11876. Refactor code to make it more readable, minor maybePrintStats bug 
(Zoran Dimitrijevic via raviprak) (raviprak: rev 
a287d2fb77d9873b61c6ab24134993d784ae8475)
* hadoop-common-project/hadoop-common/CHANGES.txt
* 
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/SimpleCopyListing.java


 Refactor code to make it more readable, minor maybePrintStats bug
 -

 Key: HADOOP-11876
 URL: https://issues.apache.org/jira/browse/HADOOP-11876
 Project: Hadoop Common
  Issue Type: Bug
  Components: tools/distcp
Affects Versions: 3.0.0
Reporter: Zoran Dimitrijevic
Assignee: Zoran Dimitrijevic
Priority: Trivial
 Fix For: 2.8.0

 Attachments: HADOOP-11876.patch


 This is related to HADOOP-11827 patch from few days ago. I've noticed a minor 
 bug in maybePrintStats logic which is called only when new directory is 
 processed, and prints every 100K objects (effectively, there is a very low 
 probability it'll ever print stats). The reason for this bug is that I was 
 previously printing stats for every new directory, and later decided it's 
 nicer to print stats for large number of new objects (files or directories) 
 instead. 
 This is a minor issue - and since I'm refactoring this I've also changed the 
 minor retry logic to make code nicer and more readable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11843) Make setting up the build environment easier

2015-04-25 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512541#comment-14512541
 ] 

Hudson commented on HADOOP-11843:
-

FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #175 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/175/])
HADOOP-11843. Make setting up the build environment easier. Contributed by 
Niels Basjes. (cnauroth: rev 80935268f5fdd358070c6b68f89e8bd699785c54)
* dev-support/docker/Dockerfile
* start-build-env.sh
* dev-support/docker/hadoop_env_checks.sh
* hadoop-common-project/hadoop-common/CHANGES.txt
* BUILDING.txt


 Make setting up the build environment easier
 

 Key: HADOOP-11843
 URL: https://issues.apache.org/jira/browse/HADOOP-11843
 Project: Hadoop Common
  Issue Type: New Feature
  Components: build
Reporter: Niels Basjes
Assignee: Niels Basjes
 Fix For: 2.8.0

 Attachments: HADOOP-11843-2015-04-17-1612.patch, 
 HADOOP-11843-2015-04-17-2226.patch, HADOOP-11843-2015-04-17-2308.patch, 
 HADOOP-11843-2015-04-19-2206.patch, HADOOP-11843-2015-04-19-2232.patch, 
 HADOOP-11843-2015-04-22-1122.patch, HADOOP-11843-2015-04-23-1000.patch


 ( As discussed with [~aw] )
 In AVRO-1537 a docker based solution was created to setup all the tools for 
 doing a full build. This enables much easier reproduction of any issues and 
 getting up and running for new developers.
 This issue is to 'copy/port' that setup into the hadoop project in 
 preparation for the bug squash.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HADOOP-11877) SnappyDecompressor's Logger class name is wrong

2015-04-25 Thread surendra singh lilhore (JIRA)
surendra singh lilhore created HADOOP-11877:
---

 Summary: SnappyDecompressor's Logger class name is wrong
 Key: HADOOP-11877
 URL: https://issues.apache.org/jira/browse/HADOOP-11877
 Project: Hadoop Common
  Issue Type: Bug
  Components: conf
Affects Versions: 2.6.0
Reporter: surendra singh lilhore
Assignee: surendra singh lilhore


In SnappyDecompressor class logger name configured SnappyCompressor.class.

{code}
   private static final Log LOG =
  LogFactory.getLog(SnappyCompressor.class.getName());
{code}

It should be SnappyDecompressor.class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11866) increase readability of the output of white space and checkstyle script

2015-04-25 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512498#comment-14512498
 ] 

Hadoop QA commented on HADOOP-11866:


\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | reexec |   0m 00s | dev-support patch detected. |
| {color:blue}0{color} | pre-patch |   0m 00s | Pre-patch trunk compilation is 
healthy. |
| {color:blue}0{color} | @author |   0m 00s | Skipping @author checks as 
test-patch has been patched. |
| {color:red}-1{color} | whitespace |   0m 00s | The patch has 1  line(s) that 
end in whitespace. |
| {color:green}+1{color} | release audit |   0m 11s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:red}-1{color} | shellcheck |   0m 02s | The applied patch generated  1 
new shellcheck (v0.3.6) issues (total was 45, now 46). |
| | |   0m 17s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12727663/HADOOP-11866.20150423-1.patch
 |
| Optional Tests | shellcheck |
| git revision | trunk / 78c6b46 |
| whitespace | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/fake/artifact/patchprocess/whitespace.txt
 |
| shellcheck | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/fake/artifact/patchprocess/diffpatchshellcheck.txt
 |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/fake/console |


This message was automatically generated.

 increase readability of the output of white space and checkstyle script
 ---

 Key: HADOOP-11866
 URL: https://issues.apache.org/jira/browse/HADOOP-11866
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Naganarasimha G R
Assignee: Naganarasimha G R
Priority: Minor
 Attachments: HADOOP-11866.20150422-1.patch, 
 HADOOP-11866.20150423-1.patch


 HADOOP-11746 supports listing of the lines which has trailing white spaces 
 but doesn't inform patch line number. Without this report output will not be 
 of much help as in most cases it reports blank lines. Also for the first 
 timers it would be difficult to understand the output check style script 
 hence adding an header



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11866) increase readability of the output of white space and checkstyle script

2015-04-25 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512497#comment-14512497
 ] 

Hadoop QA commented on HADOOP-11866:


(!) A patch to test-patch or smart-apply-patch has been detected. 
Re-executing against the patched versions to perform further tests. 
The console is at 
https://builds.apache.org/job/PreCommit-HADOOP-Build/fake/console in case of 
problems.

 increase readability of the output of white space and checkstyle script
 ---

 Key: HADOOP-11866
 URL: https://issues.apache.org/jira/browse/HADOOP-11866
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Naganarasimha G R
Assignee: Naganarasimha G R
Priority: Minor
 Attachments: HADOOP-11866.20150422-1.patch, 
 HADOOP-11866.20150423-1.patch


 HADOOP-11746 supports listing of the lines which has trailing white spaces 
 but doesn't inform patch line number. Without this report output will not be 
 of much help as in most cases it reports blank lines. Also for the first 
 timers it would be difficult to understand the output check style script 
 hence adding an header



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-11877) SnappyDecompressor's Logger class name is wrong

2015-04-25 Thread surendra singh lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

surendra singh lilhore updated HADOOP-11877:

Status: Patch Available  (was: Open)

Attached patch, please review

 SnappyDecompressor's Logger class name is wrong
 ---

 Key: HADOOP-11877
 URL: https://issues.apache.org/jira/browse/HADOOP-11877
 Project: Hadoop Common
  Issue Type: Bug
  Components: conf
Affects Versions: 2.6.0
Reporter: surendra singh lilhore
Assignee: surendra singh lilhore
 Attachments: HADOOP-11877 .patch


 In SnappyDecompressor class logger name configured SnappyCompressor.class.
 {code}
private static final Log LOG =
   LogFactory.getLog(SnappyCompressor.class.getName());
 {code}
 It should be SnappyDecompressor.class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HADOOP-11877) SnappyDecompressor's Logger class name is wrong

2015-04-25 Thread surendra singh lilhore (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

surendra singh lilhore updated HADOOP-11877:

Attachment: HADOOP-11877 .patch

 SnappyDecompressor's Logger class name is wrong
 ---

 Key: HADOOP-11877
 URL: https://issues.apache.org/jira/browse/HADOOP-11877
 Project: Hadoop Common
  Issue Type: Bug
  Components: conf
Affects Versions: 2.6.0
Reporter: surendra singh lilhore
Assignee: surendra singh lilhore
 Attachments: HADOOP-11877 .patch


 In SnappyDecompressor class logger name configured SnappyCompressor.class.
 {code}
private static final Log LOG =
   LogFactory.getLog(SnappyCompressor.class.getName());
 {code}
 It should be SnappyDecompressor.class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11876) Refactor code to make it more readable, minor maybePrintStats bug

2015-04-25 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512441#comment-14512441
 ] 

Hudson commented on HADOOP-11876:
-

FAILURE: Integrated in Hadoop-Hdfs-trunk #2106 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2106/])
HADOOP-11876. Refactor code to make it more readable, minor maybePrintStats bug 
(Zoran Dimitrijevic via raviprak) (raviprak: rev 
a287d2fb77d9873b61c6ab24134993d784ae8475)
* 
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/SimpleCopyListing.java
* hadoop-common-project/hadoop-common/CHANGES.txt


 Refactor code to make it more readable, minor maybePrintStats bug
 -

 Key: HADOOP-11876
 URL: https://issues.apache.org/jira/browse/HADOOP-11876
 Project: Hadoop Common
  Issue Type: Bug
  Components: tools/distcp
Affects Versions: 3.0.0
Reporter: Zoran Dimitrijevic
Assignee: Zoran Dimitrijevic
Priority: Trivial
 Fix For: 2.8.0

 Attachments: HADOOP-11876.patch


 This is related to HADOOP-11827 patch from few days ago. I've noticed a minor 
 bug in maybePrintStats logic which is called only when new directory is 
 processed, and prints every 100K objects (effectively, there is a very low 
 probability it'll ever print stats). The reason for this bug is that I was 
 previously printing stats for every new directory, and later decided it's 
 nicer to print stats for large number of new objects (files or directories) 
 instead. 
 This is a minor issue - and since I'm refactoring this I've also changed the 
 minor retry logic to make code nicer and more readable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11843) Make setting up the build environment easier

2015-04-25 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512446#comment-14512446
 ] 

Hudson commented on HADOOP-11843:
-

FAILURE: Integrated in Hadoop-Hdfs-trunk #2106 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2106/])
HADOOP-11843. Make setting up the build environment easier. Contributed by 
Niels Basjes. (cnauroth: rev 80935268f5fdd358070c6b68f89e8bd699785c54)
* start-build-env.sh
* dev-support/docker/hadoop_env_checks.sh
* hadoop-common-project/hadoop-common/CHANGES.txt
* BUILDING.txt
* dev-support/docker/Dockerfile


 Make setting up the build environment easier
 

 Key: HADOOP-11843
 URL: https://issues.apache.org/jira/browse/HADOOP-11843
 Project: Hadoop Common
  Issue Type: New Feature
  Components: build
Reporter: Niels Basjes
Assignee: Niels Basjes
 Fix For: 2.8.0

 Attachments: HADOOP-11843-2015-04-17-1612.patch, 
 HADOOP-11843-2015-04-17-2226.patch, HADOOP-11843-2015-04-17-2308.patch, 
 HADOOP-11843-2015-04-19-2206.patch, HADOOP-11843-2015-04-19-2232.patch, 
 HADOOP-11843-2015-04-22-1122.patch, HADOOP-11843-2015-04-23-1000.patch


 ( As discussed with [~aw] )
 In AVRO-1537 a docker based solution was created to setup all the tools for 
 doing a full build. This enables much easier reproduction of any issues and 
 getting up and running for new developers.
 This issue is to 'copy/port' that setup into the hadoop project in 
 preparation for the bug squash.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11876) Refactor code to make it more readable, minor maybePrintStats bug

2015-04-25 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512459#comment-14512459
 ] 

Hudson commented on HADOOP-11876:
-

FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #165 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/165/])
HADOOP-11876. Refactor code to make it more readable, minor maybePrintStats bug 
(Zoran Dimitrijevic via raviprak) (raviprak: rev 
a287d2fb77d9873b61c6ab24134993d784ae8475)
* hadoop-common-project/hadoop-common/CHANGES.txt
* 
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/SimpleCopyListing.java


 Refactor code to make it more readable, minor maybePrintStats bug
 -

 Key: HADOOP-11876
 URL: https://issues.apache.org/jira/browse/HADOOP-11876
 Project: Hadoop Common
  Issue Type: Bug
  Components: tools/distcp
Affects Versions: 3.0.0
Reporter: Zoran Dimitrijevic
Assignee: Zoran Dimitrijevic
Priority: Trivial
 Fix For: 2.8.0

 Attachments: HADOOP-11876.patch


 This is related to HADOOP-11827 patch from few days ago. I've noticed a minor 
 bug in maybePrintStats logic which is called only when new directory is 
 processed, and prints every 100K objects (effectively, there is a very low 
 probability it'll ever print stats). The reason for this bug is that I was 
 previously printing stats for every new directory, and later decided it's 
 nicer to print stats for large number of new objects (files or directories) 
 instead. 
 This is a minor issue - and since I'm refactoring this I've also changed the 
 minor retry logic to make code nicer and more readable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11877) SnappyDecompressor's Logger class name is wrong

2015-04-25 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512477#comment-14512477
 ] 

Hadoop QA commented on HADOOP-11877:


\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 29s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear 
to include any new or modified tests.  Please justify why no new tests are 
needed for this patch. Also please list what manual steps were performed to 
verify this patch. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | javac |   7m 25s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |   9m 33s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   5m 28s | There were no new checkstyle 
issues. |
| {color:green}+1{color} | install |   1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 32s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 39s | The patch does not introduce 
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | common tests |  23m 11s | Tests passed in 
hadoop-common. |
| | |  64m 16s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12728150/HADOOP-11877%20.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 78c6b46 |
| hadoop-common test log | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6178/artifact/patchprocess/testrun_hadoop-common.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6178/testReport/ |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6178/console |


This message was automatically generated.

 SnappyDecompressor's Logger class name is wrong
 ---

 Key: HADOOP-11877
 URL: https://issues.apache.org/jira/browse/HADOOP-11877
 Project: Hadoop Common
  Issue Type: Bug
  Components: conf
Affects Versions: 2.6.0
Reporter: surendra singh lilhore
Assignee: surendra singh lilhore
 Attachments: HADOOP-11877 .patch


 In SnappyDecompressor class logger name configured SnappyCompressor.class.
 {code}
private static final Log LOG =
   LogFactory.getLog(SnappyCompressor.class.getName());
 {code}
 It should be SnappyDecompressor.class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11876) Refactor code to make it more readable, minor maybePrintStats bug

2015-04-25 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512560#comment-14512560
 ] 

Hudson commented on HADOOP-11876:
-

SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2124 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2124/])
HADOOP-11876. Refactor code to make it more readable, minor maybePrintStats bug 
(Zoran Dimitrijevic via raviprak) (raviprak: rev 
a287d2fb77d9873b61c6ab24134993d784ae8475)
* hadoop-common-project/hadoop-common/CHANGES.txt
* 
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/SimpleCopyListing.java


 Refactor code to make it more readable, minor maybePrintStats bug
 -

 Key: HADOOP-11876
 URL: https://issues.apache.org/jira/browse/HADOOP-11876
 Project: Hadoop Common
  Issue Type: Bug
  Components: tools/distcp
Affects Versions: 3.0.0
Reporter: Zoran Dimitrijevic
Assignee: Zoran Dimitrijevic
Priority: Trivial
 Fix For: 2.8.0

 Attachments: HADOOP-11876.patch


 This is related to HADOOP-11827 patch from few days ago. I've noticed a minor 
 bug in maybePrintStats logic which is called only when new directory is 
 processed, and prints every 100K objects (effectively, there is a very low 
 probability it'll ever print stats). The reason for this bug is that I was 
 previously printing stats for every new directory, and later decided it's 
 nicer to print stats for large number of new objects (files or directories) 
 instead. 
 This is a minor issue - and since I'm refactoring this I've also changed the 
 minor retry logic to make code nicer and more readable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-11843) Make setting up the build environment easier

2015-04-25 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512565#comment-14512565
 ] 

Hudson commented on HADOOP-11843:
-

SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2124 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2124/])
HADOOP-11843. Make setting up the build environment easier. Contributed by 
Niels Basjes. (cnauroth: rev 80935268f5fdd358070c6b68f89e8bd699785c54)
* dev-support/docker/hadoop_env_checks.sh
* hadoop-common-project/hadoop-common/CHANGES.txt
* dev-support/docker/Dockerfile
* start-build-env.sh
* BUILDING.txt


 Make setting up the build environment easier
 

 Key: HADOOP-11843
 URL: https://issues.apache.org/jira/browse/HADOOP-11843
 Project: Hadoop Common
  Issue Type: New Feature
  Components: build
Reporter: Niels Basjes
Assignee: Niels Basjes
 Fix For: 2.8.0

 Attachments: HADOOP-11843-2015-04-17-1612.patch, 
 HADOOP-11843-2015-04-17-2226.patch, HADOOP-11843-2015-04-17-2308.patch, 
 HADOOP-11843-2015-04-19-2206.patch, HADOOP-11843-2015-04-19-2232.patch, 
 HADOOP-11843-2015-04-22-1122.patch, HADOOP-11843-2015-04-23-1000.patch


 ( As discussed with [~aw] )
 In AVRO-1537 a docker based solution was created to setup all the tools for 
 doing a full build. This enables much easier reproduction of any issues and 
 getting up and running for new developers.
 This issue is to 'copy/port' that setup into the hadoop project in 
 preparation for the bug squash.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)