[jira] [Commented] (HADOOP-17169) Remove whitelist/blacklist terminology from Hadoop Common
[
https://issues.apache.org/jira/browse/HADOOP-17169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186273#comment-17186273
]
Hadoop QA commented on HADOOP-17169:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
4s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 10 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 3m
25s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 29m
8s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 22m
38s{color} | {color:green} trunk passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 19m
4s{color} | {color:green} trunk passed with JDK Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
9s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 4m
36s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
23m 59s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
21s{color} | {color:green} trunk passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
47s{color} | {color:green} trunk passed with JDK Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m
21s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 8m
51s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
28s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 25m
53s{color} | {color:green} the patch passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 {color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red} 25m 53s{color} |
{color:red} root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 31 new + 132 unchanged -
31 fixed = 163 total (was 163) {color} |
| {color:green}+1{color} | {color:green} golang {color} | {color:green} 25m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 25m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 20m
25s{color} | {color:green} the patch passed with JDK Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 {color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red} 20m 25s{color} |
{color:red} root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 with
JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 23 new + 140
unchanged - 23 fixed = 163 total (was 163) {color} |
| {color:green}+1{color} | {color:green} golang {color} | {color:green} 20m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 20m
25s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
2m 57s{color} | {color:orange} root: The patch generated 8 new + 223 unchanged
- 69 fixed = 231 total (was 292) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 3m
53s{color} | {color:green} the patch passed {color} |
| {
[jira] [Commented] (HADOOP-17232) Erasure Coding: Typo in document
[
https://issues.apache.org/jira/browse/HADOOP-17232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186250#comment-17186250
]
Hadoop QA commented on HADOOP-17232:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 3m
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:blue}0{color} | {color:blue} markdownlint {color} | {color:blue} 0m
1s{color} | {color:blue} markdownlint was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 32m
59s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 26m
48s{color} | {color:green} trunk passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 22m
13s{color} | {color:green} trunk passed with JDK Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
52s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
41s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
18m 55s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} trunk passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
27s{color} | {color:green} trunk passed with JDK Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 2m
29s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
27s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 23m
42s{color} | {color:green} the patch passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 23m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 21m
24s{color} | {color:green} the patch passed with JDK Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 21m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
18m 6s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} the patch passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
56s{color} | {color:green} the patch passed with JDK Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 {color} |
| {color:green}+1{color} | {color:green} findb
[GitHub] [hadoop] ibuenros opened a new pull request #2255: HDFS-15545 - Allow WebHdfsFileSystem to read a new delegation token f…
ibuenros opened a new pull request #2255: URL: https://github.com/apache/hadoop/pull/2255 …rom UGI if the previous one is expired. ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with the corresponding JIRA issue number. (e.g. HADOOP-X. Fix a typo in YYY.) For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17234) Add .asf.yaml to allow github and jira integration
[ https://issues.apache.org/jira/browse/HADOOP-17234?focusedWorklogId=475626&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475626 ] ASF GitHub Bot logged work on HADOOP-17234: --- Author: ASF GitHub Bot Created on: 28/Aug/20 01:20 Start Date: 28/Aug/20 01:20 Worklog Time Spent: 10m Work Description: ayushtkn edited a comment on pull request #2253: URL: https://github.com/apache/hadoop/pull/2253#issuecomment-682270570 @liuml07 Time tracking seems to enabled by jira, To disable that, I think we need Jira Admin rights. https://confluence.atlassian.com/adminjiraserver073/configuring-time-tracking-861253946.html?_ga=2.77528598.2074936245.1598575483-27446335.1598575483 Which I think I don’t have, I can check with infra on this. One probable fix “can be” to remove ‘worklog ‘ from ‘jira_options’ , but that will even disable comments on PR getting notified on the Jira and project summary. Got a response from Infra : A ticket can be raised, if this needs to be disabled and they can check post that [slack response](https://the-asf.slack.com/archives/CBX4TSBQ8/p1598577425446000) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 475626) Time Spent: 1h 40m (was: 1.5h) > Add .asf.yaml to allow github and jira integration > -- > > Key: HADOOP-17234 > URL: https://issues.apache.org/jira/browse/HADOOP-17234 > Project: Hadoop Common > Issue Type: Task >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > As of now the default for github is set only to worklog, To enable link and > label, We need to add this. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] ayushtkn edited a comment on pull request #2253: HADOOP-17234. Add .asf.yaml to allow Github to Jira integration.
ayushtkn edited a comment on pull request #2253: URL: https://github.com/apache/hadoop/pull/2253#issuecomment-682270570 @liuml07 Time tracking seems to enabled by jira, To disable that, I think we need Jira Admin rights. https://confluence.atlassian.com/adminjiraserver073/configuring-time-tracking-861253946.html?_ga=2.77528598.2074936245.1598575483-27446335.1598575483 Which I think I don’t have, I can check with infra on this. One probable fix “can be” to remove ‘worklog ‘ from ‘jira_options’ , but that will even disable comments on PR getting notified on the Jira and project summary. Got a response from Infra : A ticket can be raised, if this needs to be disabled and they can check post that [slack response](https://the-asf.slack.com/archives/CBX4TSBQ8/p1598577425446000) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17234) Add .asf.yaml to allow github and jira integration
[ https://issues.apache.org/jira/browse/HADOOP-17234?focusedWorklogId=475623&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475623 ] ASF GitHub Bot logged work on HADOOP-17234: --- Author: ASF GitHub Bot Created on: 28/Aug/20 01:17 Start Date: 28/Aug/20 01:17 Worklog Time Spent: 10m Work Description: ayushtkn commented on pull request #2253: URL: https://github.com/apache/hadoop/pull/2253#issuecomment-682270570 @liuml07 Time tracking seems to enabled by jira, To disable that, I think we need Jira Admin rights. https://confluence.atlassian.com/adminjiraserver073/configuring-time-tracking-861253946.html?_ga=2.77528598.2074936245.1598575483-27446335.1598575483 Which I think I don’t have, I can check with infra on this. One probable fix “can be” to remove ‘worklog ‘ from ‘jira_options’ , but that will even disable comments on PR getting notified on the Jira and project summary. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 475623) Time Spent: 1.5h (was: 1h 20m) > Add .asf.yaml to allow github and jira integration > -- > > Key: HADOOP-17234 > URL: https://issues.apache.org/jira/browse/HADOOP-17234 > Project: Hadoop Common > Issue Type: Task >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > As of now the default for github is set only to worklog, To enable link and > label, We need to add this. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] ayushtkn commented on pull request #2253: HADOOP-17234. Add .asf.yaml to allow Github to Jira integration.
ayushtkn commented on pull request #2253: URL: https://github.com/apache/hadoop/pull/2253#issuecomment-682270570 @liuml07 Time tracking seems to enabled by jira, To disable that, I think we need Jira Admin rights. https://confluence.atlassian.com/adminjiraserver073/configuring-time-tracking-861253946.html?_ga=2.77528598.2074936245.1598575483-27446335.1598575483 Which I think I don’t have, I can check with infra on this. One probable fix “can be” to remove ‘worklog ‘ from ‘jira_options’ , but that will even disable comments on PR getting notified on the Jira and project summary. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17232) Erasure Coding: Typo in document
[ https://issues.apache.org/jira/browse/HADOOP-17232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186187#comment-17186187 ] Fei Hui commented on HADOOP-17232: -- [~liuml07] Thanks for review ! Upload v002 patch > Erasure Coding: Typo in document > > > Key: HADOOP-17232 > URL: https://issues.apache.org/jira/browse/HADOOP-17232 > Project: Hadoop Common > Issue Type: Improvement > Components: documentation >Affects Versions: 3.3.0 >Reporter: Fei Hui >Assignee: Fei Hui >Priority: Trivial > Attachments: HADOOP-17232.001.patch, HADOOP-17232.002.patch > > > When review ec document and code, find the typo. > Change "a erasure code" to "an erasure code" -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-17232) Erasure Coding: Typo in document
[ https://issues.apache.org/jira/browse/HADOOP-17232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fei Hui updated HADOOP-17232: - Attachment: HADOOP-17232.002.patch > Erasure Coding: Typo in document > > > Key: HADOOP-17232 > URL: https://issues.apache.org/jira/browse/HADOOP-17232 > Project: Hadoop Common > Issue Type: Improvement > Components: documentation >Affects Versions: 3.3.0 >Reporter: Fei Hui >Assignee: Fei Hui >Priority: Trivial > Attachments: HADOOP-17232.001.patch, HADOOP-17232.002.patch > > > When review ec document and code, find the typo. > Change "a erasure code" to "an erasure code" -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-17169) Remove whitelist/blacklist terminology from Hadoop Common
[ https://issues.apache.org/jira/browse/HADOOP-17169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Badger updated HADOOP-17169: - Attachment: HADOOP-17169.003.patch > Remove whitelist/blacklist terminology from Hadoop Common > - > > Key: HADOOP-17169 > URL: https://issues.apache.org/jira/browse/HADOOP-17169 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Eric Badger >Assignee: Eric Badger >Priority: Major > Attachments: HADOOP-17169.001.patch, HADOOP-17169.002.patch, > HADOOP-17169.003.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Resolved] (HADOOP-17159) Make UGI support forceful relogin from keytab ignoring the last login time
[ https://issues.apache.org/jira/browse/HADOOP-17159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu resolved HADOOP-17159. Fix Version/s: 2.10.1 Hadoop Flags: Reviewed Resolution: Fixed Committed to 2.10.1 and 3.1.5+ see "Fix Version/s". Thank you for your contribution, [~sandeep.guggilam] > Make UGI support forceful relogin from keytab ignoring the last login time > -- > > Key: HADOOP-17159 > URL: https://issues.apache.org/jira/browse/HADOOP-17159 > Project: Hadoop Common > Issue Type: Improvement > Components: security >Affects Versions: 2.10.0, 3.3.0, 3.2.1, 3.1.3 >Reporter: Sandeep Guggilam >Assignee: Sandeep Guggilam >Priority: Major > Fix For: 3.2.2, 2.10.1, 3.3.1, 3.4.0, 3.1.5 > > Time Spent: 40m > Remaining Estimate: 0h > > Currently we have a relogin() method in UGI which attempts to login if there > is no login attempted in the last 10 minutes or configured amount of time > We should also have provision for doing a forceful relogin irrespective of > the time window that the client can choose to use it if needed . Consider the > below scenario: > # SASL Server is reimaged and new keytabs are fetched with refreshing the > password > # SASL client connection to the server would fail when it tries with the > cached service ticket > # We should try to logout to clear the service tickets in cache and then try > to login back in such scenarios. But since the current relogin() doesn't > guarantee a login, it could cause an issue > # A forceful relogin in this case would help after logout > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17159) Make UGI support forceful relogin from keytab ignoring the last login time
[ https://issues.apache.org/jira/browse/HADOOP-17159?focusedWorklogId=475572&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475572 ] ASF GitHub Bot logged work on HADOOP-17159: --- Author: ASF GitHub Bot Created on: 27/Aug/20 22:21 Start Date: 27/Aug/20 22:21 Worklog Time Spent: 10m Work Description: liuml07 merged pull request #2245: URL: https://github.com/apache/hadoop/pull/2245 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 475572) Time Spent: 40m (was: 0.5h) > Make UGI support forceful relogin from keytab ignoring the last login time > -- > > Key: HADOOP-17159 > URL: https://issues.apache.org/jira/browse/HADOOP-17159 > Project: Hadoop Common > Issue Type: Improvement > Components: security >Affects Versions: 2.10.0, 3.3.0, 3.2.1, 3.1.3 >Reporter: Sandeep Guggilam >Assignee: Sandeep Guggilam >Priority: Major > Fix For: 3.2.2, 3.3.1, 3.4.0, 3.1.5 > > Time Spent: 40m > Remaining Estimate: 0h > > Currently we have a relogin() method in UGI which attempts to login if there > is no login attempted in the last 10 minutes or configured amount of time > We should also have provision for doing a forceful relogin irrespective of > the time window that the client can choose to use it if needed . Consider the > below scenario: > # SASL Server is reimaged and new keytabs are fetched with refreshing the > password > # SASL client connection to the server would fail when it tries with the > cached service ticket > # We should try to logout to clear the service tickets in cache and then try > to login back in such scenarios. But since the current relogin() doesn't > guarantee a login, it could cause an issue > # A forceful relogin in this case would help after logout > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] liuml07 merged pull request #2245: HADOOP-17159. Make UGI support forceful relogin from keytab ignoring the last login time (branch-2.10)
liuml07 merged pull request #2245: URL: https://github.com/apache/hadoop/pull/2245 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17159) Make UGI support forceful relogin from keytab ignoring the last login time
[ https://issues.apache.org/jira/browse/HADOOP-17159?focusedWorklogId=475570&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475570 ] ASF GitHub Bot logged work on HADOOP-17159: --- Author: ASF GitHub Bot Created on: 27/Aug/20 22:09 Start Date: 27/Aug/20 22:09 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on pull request #2245: URL: https://github.com/apache/hadoop/pull/2245#issuecomment-682215919 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 11m 25s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ branch-2.10 Compile Tests _ | | +1 :green_heart: | mvninstall | 16m 14s | branch-2.10 passed | | +1 :green_heart: | compile | 12m 56s | branch-2.10 passed | | +1 :green_heart: | checkstyle | 0m 45s | branch-2.10 passed | | +1 :green_heart: | mvnsite | 1m 30s | branch-2.10 passed | | +1 :green_heart: | javadoc | 1m 18s | branch-2.10 passed | | +0 :ok: | spotbugs | 2m 30s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 2m 26s | branch-2.10 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 54s | the patch passed | | +1 :green_heart: | compile | 12m 14s | the patch passed | | +1 :green_heart: | javac | 12m 14s | the patch passed | | +1 :green_heart: | checkstyle | 0m 46s | the patch passed | | +1 :green_heart: | mvnsite | 1m 25s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 1m 13s | the patch passed | | +1 :green_heart: | findbugs | 2m 34s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 9m 34s | hadoop-common in the patch passed. | | +1 :green_heart: | asflicense | 0m 53s | The patch does not generate ASF License warnings. | | | | 79m 52s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2245/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/2245 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux ee37392e8ce7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | branch-2.10 / a9f82a1 | | Default Java | Oracle Corporation-1.7.0_95-b00 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2245/3/testReport/ | | Max. process+thread count | 1330 (vs. ulimit of 5500) | | modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2245/3/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.0.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 475570) Time Spent: 0.5h (was: 20m) > Make UGI support forceful relogin from keytab ignoring the last login time > -- > > Key: HADOOP-17159 > URL: https://issues.apache.org/jira/browse/HADOOP-17159 > Project: Hadoop Common > Issue Type: Improvement > Components: security >Affects Versions: 2.10.0, 3.3.0, 3.2.1, 3.1.3 >Reporter: Sandeep Guggilam >Assignee: Sandeep Guggilam >Priority: Major > Fix For: 3.2.2, 3.3.1, 3.4.0, 3.1.5 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Currently we have a relogin() method in UGI which attempts to login if there > is no login attempted in the last 10 minutes or configured amount of time > We should also have provisio
[GitHub] [hadoop] hadoop-yetus commented on pull request #2245: HADOOP-17159 Ability for forceful relogin in UserGroupInformation class
hadoop-yetus commented on pull request #2245: URL: https://github.com/apache/hadoop/pull/2245#issuecomment-682215919 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 11m 25s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ branch-2.10 Compile Tests _ | | +1 :green_heart: | mvninstall | 16m 14s | branch-2.10 passed | | +1 :green_heart: | compile | 12m 56s | branch-2.10 passed | | +1 :green_heart: | checkstyle | 0m 45s | branch-2.10 passed | | +1 :green_heart: | mvnsite | 1m 30s | branch-2.10 passed | | +1 :green_heart: | javadoc | 1m 18s | branch-2.10 passed | | +0 :ok: | spotbugs | 2m 30s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 2m 26s | branch-2.10 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 54s | the patch passed | | +1 :green_heart: | compile | 12m 14s | the patch passed | | +1 :green_heart: | javac | 12m 14s | the patch passed | | +1 :green_heart: | checkstyle | 0m 46s | the patch passed | | +1 :green_heart: | mvnsite | 1m 25s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 1m 13s | the patch passed | | +1 :green_heart: | findbugs | 2m 34s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 9m 34s | hadoop-common in the patch passed. | | +1 :green_heart: | asflicense | 0m 53s | The patch does not generate ASF License warnings. | | | | 79m 52s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2245/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/2245 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux ee37392e8ce7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | branch-2.10 / a9f82a1 | | Default Java | Oracle Corporation-1.7.0_95-b00 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2245/3/testReport/ | | Max. process+thread count | 1330 (vs. ulimit of 5500) | | modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2245/3/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.0.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] liuml07 commented on pull request #2253: HADOOP-17234. Add .asf.yaml to allow Github to Jira integration.
liuml07 commented on pull request #2253: URL: https://github.com/apache/hadoop/pull/2253#issuecomment-682181960 Maybe unrelated to this, but I see everytime we comment on a PR, the robot will update the `Time Tracking` field of the JIRA. Sometimes I see email notifications about tis. However this seems not useful yet to the community. Is it possible to disable it? Thanks! https://user-images.githubusercontent.com/159186/91493091-978d8380-e86b-11ea-8663-19798ef13426.png";> This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17234) Add .asf.yaml to allow github and jira integration
[ https://issues.apache.org/jira/browse/HADOOP-17234?focusedWorklogId=475540&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475540 ] ASF GitHub Bot logged work on HADOOP-17234: --- Author: ASF GitHub Bot Created on: 27/Aug/20 20:45 Start Date: 27/Aug/20 20:45 Worklog Time Spent: 10m Work Description: liuml07 commented on pull request #2253: URL: https://github.com/apache/hadoop/pull/2253#issuecomment-682181960 Maybe unrelated to this, but I see everytime we comment on a PR, the robot will update the `Time Tracking` field of the JIRA. Sometimes I see email notifications about tis. However this seems not useful yet to the community. Is it possible to disable it? Thanks! https://user-images.githubusercontent.com/159186/91493091-978d8380-e86b-11ea-8663-19798ef13426.png";> This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 475540) Time Spent: 1h 20m (was: 1h 10m) > Add .asf.yaml to allow github and jira integration > -- > > Key: HADOOP-17234 > URL: https://issues.apache.org/jira/browse/HADOOP-17234 > Project: Hadoop Common > Issue Type: Task >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > As of now the default for github is set only to worklog, To enable link and > label, We need to add this. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17234) Add .asf.yaml to allow github and jira integration
[ https://issues.apache.org/jira/browse/HADOOP-17234?focusedWorklogId=475538&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475538 ] ASF GitHub Bot logged work on HADOOP-17234: --- Author: ASF GitHub Bot Created on: 27/Aug/20 20:40 Start Date: 27/Aug/20 20:40 Worklog Time Spent: 10m Work Description: liuml07 commented on a change in pull request #2253: URL: https://github.com/apache/hadoop/pull/2253#discussion_r478682876 ## File path: .asf.yaml ## @@ -0,0 +1,25 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +github: + enabled_merge_buttons: +squash: true +merge: false +rebase: false +notifications: + commits: common-comm...@hadoop.apache.org + issues: common-issues@hadoop.apache.org + pullrequests: common-issues@hadoop.apache.org + jira_options: link label worklog Review comment: No it's not required. It's not a blank line newline, but a hidden char. Sharing some thoughts: 1. No end of line char can lead to unexpected behavior when using other tools on the file. For e.g. git diff or external diff tools depend on newlines to generate a correct diff. `wc` command counting lines may also be broken. More can be found at [this discussion](https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline/729795#729795). 2. Next time when someone edits the file, some editors will automatically add a "newline" char at the end of this file - for good intention. If so, seems like they "changed" the last line of this file in their PR which they do not. But that is not a real problem here. We can commit without fixing that, I'm fine with that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 475538) Time Spent: 1h 10m (was: 1h) > Add .asf.yaml to allow github and jira integration > -- > > Key: HADOOP-17234 > URL: https://issues.apache.org/jira/browse/HADOOP-17234 > Project: Hadoop Common > Issue Type: Task >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > As of now the default for github is set only to worklog, To enable link and > label, We need to add this. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] liuml07 commented on a change in pull request #2253: HADOOP-17234. Add .asf.yaml to allow Github to Jira integration.
liuml07 commented on a change in pull request #2253: URL: https://github.com/apache/hadoop/pull/2253#discussion_r478682876 ## File path: .asf.yaml ## @@ -0,0 +1,25 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +github: + enabled_merge_buttons: +squash: true +merge: false +rebase: false +notifications: + commits: common-comm...@hadoop.apache.org + issues: common-issues@hadoop.apache.org + pullrequests: common-issues@hadoop.apache.org + jira_options: link label worklog Review comment: No it's not required. It's not a blank line newline, but a hidden char. Sharing some thoughts: 1. No end of line char can lead to unexpected behavior when using other tools on the file. For e.g. git diff or external diff tools depend on newlines to generate a correct diff. `wc` command counting lines may also be broken. More can be found at [this discussion](https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline/729795#729795). 2. Next time when someone edits the file, some editors will automatically add a "newline" char at the end of this file - for good intention. If so, seems like they "changed" the last line of this file in their PR which they do not. But that is not a real problem here. We can commit without fixing that, I'm fine with that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2211: HDFS-15098. Add SM4 encryption method for HDFS
hadoop-yetus commented on pull request #2211: URL: https://github.com/apache/hadoop/pull/2211#issuecomment-682177101 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 54s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | markdownlint | 0m 1s | markdownlint was not available. | | +0 :ok: | buf | 0m 1s | buf was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 4 new or modified test files. | ||| _ trunk Compile Tests _ | | +0 :ok: | mvndep | 3m 18s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 29m 4s | trunk passed | | +1 :green_heart: | compile | 24m 1s | trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | compile | 21m 56s | trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +1 :green_heart: | checkstyle | 3m 53s | trunk passed | | +1 :green_heart: | mvnsite | 4m 14s | trunk passed | | +1 :green_heart: | shadedclient | 24m 3s | branch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 2m 14s | trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | javadoc | 3m 39s | trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +0 :ok: | spotbugs | 2m 41s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 8m 15s | trunk passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 27s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 58s | the patch passed | | +1 :green_heart: | compile | 21m 58s | the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | -1 :x: | cc | 21m 58s | root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 26 new + 137 unchanged - 26 fixed = 163 total (was 163) | | +1 :green_heart: | golang | 21m 58s | the patch passed | | +1 :green_heart: | javac | 21m 58s | root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 0 new + 2049 unchanged - 4 fixed = 2049 total (was 2053) | | +1 :green_heart: | compile | 18m 54s | the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | -1 :x: | cc | 18m 54s | root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 29 new + 134 unchanged - 29 fixed = 163 total (was 163) | | +1 :green_heart: | golang | 18m 54s | the patch passed | | +1 :green_heart: | javac | 18m 54s | root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 0 new + 1944 unchanged - 4 fixed = 1944 total (was 1948) | | -0 :warning: | checkstyle | 2m 49s | root: The patch generated 3 new + 212 unchanged - 8 fixed = 215 total (was 220) | | +1 :green_heart: | mvnsite | 3m 51s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. | | +1 :green_heart: | shadedclient | 15m 38s | patch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 2m 9s | the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | javadoc | 3m 38s | the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | -1 :x: | findbugs | 2m 34s | hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 9m 53s | hadoop-common in the patch passed. | | +1 :green_heart: | unit | 2m 10s | hadoop-hdfs-client in the patch passed. | | -1 :x: | unit | 131m 7s | hadoop-hdfs in the patch passed. | | +1 :green_heart: | asflicense | 1m 26s | The patch does not generate ASF License warnings. | | | | 349m 0s | | | Reason | Tests | |---:|:--| | FindBugs | module:hadoop-common-project/hadoop-common | | | Return value of getCipherSuite() ignored, but method has no side effect At JceSm4CtrCryptoCodec.java:but method has no side effect At JceSm4CtrCryptoCodec.java:[line 51] | | Failed junit tests | hadoop.hdfs.s
[jira] [Work logged] (HADOOP-17222) Create socket address combined with cache to speed up hdfs client choose DataNode
[ https://issues.apache.org/jira/browse/HADOOP-17222?focusedWorklogId=475525&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475525 ] ASF GitHub Bot logged work on HADOOP-17222: --- Author: ASF GitHub Bot Created on: 27/Aug/20 20:14 Start Date: 27/Aug/20 20:14 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on pull request #2241: URL: https://github.com/apache/hadoop/pull/2241#issuecomment-682167781 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. | ||| _ trunk Compile Tests _ | | +0 :ok: | mvndep | 3m 21s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 28m 4s | trunk passed | | +1 :green_heart: | compile | 19m 28s | trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | compile | 16m 47s | trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +1 :green_heart: | checkstyle | 2m 48s | trunk passed | | +1 :green_heart: | mvnsite | 4m 6s | trunk passed | | +1 :green_heart: | shadedclient | 20m 34s | branch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 2m 42s | trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | javadoc | 4m 6s | trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +0 :ok: | spotbugs | 3m 13s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 10m 10s | trunk passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 29s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 36s | the patch passed | | +1 :green_heart: | compile | 25m 7s | the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | javac | 25m 7s | the patch passed | | +1 :green_heart: | compile | 23m 1s | the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +1 :green_heart: | javac | 23m 1s | the patch passed | | +1 :green_heart: | checkstyle | 3m 23s | root: The patch generated 0 new + 136 unchanged - 2 fixed = 136 total (was 138) | | +1 :green_heart: | mvnsite | 4m 32s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | shadedclient | 18m 15s | patch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 2m 37s | the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | javadoc | 4m 27s | the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +1 :green_heart: | findbugs | 10m 47s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 10m 30s | hadoop-common in the patch passed. | | +1 :green_heart: | unit | 2m 41s | hadoop-hdfs-client in the patch passed. | | -1 :x: | unit | 121m 36s | hadoop-hdfs in the patch passed. | | +1 :green_heart: | asflicense | 1m 7s | The patch does not generate ASF License warnings. | | | | 343m 16s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hdfs.TestErasureCodingPoliciesWithRandomECPolicy | | | hadoop.hdfs.TestDFSClientSocketSize | | | hadoop.hdfs.TestFileChecksumCompositeCrc | | | hadoop.hdfs.TestDecommissionWithBackoffMonitor | | | hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics | | | hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints | | | hadoop.hdfs.TestReadStripedFileWithDNFailure | | | hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped | | | hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy | | | hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader | | | hadoop.hdfs.TestDFSStripedOutputStreamWithRandomECPolicy | | | hadoop.hdfs.TestAppendSnapshotTruncate | | | hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier | | | hadoop.hdfs.TestReadStripedFileWithMissingBlocks | | | hadoop.hdfs.TestFileChecksum | | | hadoop.hdfs.TestAbandonBl
[GitHub] [hadoop] hadoop-yetus commented on pull request #2241: HADOOP-17222. Create socket address combined with cache
hadoop-yetus commented on pull request #2241: URL: https://github.com/apache/hadoop/pull/2241#issuecomment-682167781 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. | ||| _ trunk Compile Tests _ | | +0 :ok: | mvndep | 3m 21s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 28m 4s | trunk passed | | +1 :green_heart: | compile | 19m 28s | trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | compile | 16m 47s | trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +1 :green_heart: | checkstyle | 2m 48s | trunk passed | | +1 :green_heart: | mvnsite | 4m 6s | trunk passed | | +1 :green_heart: | shadedclient | 20m 34s | branch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 2m 42s | trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | javadoc | 4m 6s | trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +0 :ok: | spotbugs | 3m 13s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 10m 10s | trunk passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 29s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 36s | the patch passed | | +1 :green_heart: | compile | 25m 7s | the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | javac | 25m 7s | the patch passed | | +1 :green_heart: | compile | 23m 1s | the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +1 :green_heart: | javac | 23m 1s | the patch passed | | +1 :green_heart: | checkstyle | 3m 23s | root: The patch generated 0 new + 136 unchanged - 2 fixed = 136 total (was 138) | | +1 :green_heart: | mvnsite | 4m 32s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | shadedclient | 18m 15s | patch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 2m 37s | the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | javadoc | 4m 27s | the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +1 :green_heart: | findbugs | 10m 47s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 10m 30s | hadoop-common in the patch passed. | | +1 :green_heart: | unit | 2m 41s | hadoop-hdfs-client in the patch passed. | | -1 :x: | unit | 121m 36s | hadoop-hdfs in the patch passed. | | +1 :green_heart: | asflicense | 1m 7s | The patch does not generate ASF License warnings. | | | | 343m 16s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hdfs.TestErasureCodingPoliciesWithRandomECPolicy | | | hadoop.hdfs.TestDFSClientSocketSize | | | hadoop.hdfs.TestFileChecksumCompositeCrc | | | hadoop.hdfs.TestDecommissionWithBackoffMonitor | | | hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics | | | hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints | | | hadoop.hdfs.TestReadStripedFileWithDNFailure | | | hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped | | | hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy | | | hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader | | | hadoop.hdfs.TestDFSStripedOutputStreamWithRandomECPolicy | | | hadoop.hdfs.TestAppendSnapshotTruncate | | | hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier | | | hadoop.hdfs.TestReadStripedFileWithMissingBlocks | | | hadoop.hdfs.TestFileChecksum | | | hadoop.hdfs.TestAbandonBlock | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/10/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/2241 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml | | uname | Linux 08
[jira] [Commented] (HADOOP-17234) Add .asf.yaml to allow github and jira integration
[ https://issues.apache.org/jira/browse/HADOOP-17234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186081#comment-17186081 ] Ayush Saxena commented on HADOOP-17234: --- ozone,hive,flink are the one where I have seen this. Should be many other The integration is already enabled by Apache with default values. this is just tuning that. As of now we have to explicitly link the Github PR with Jira, that will happen automatically(That used to happen earlier? but isn't happening now) The comments on PR will be shown in worklog in jira aswell and in the jira project summary.(This was by default enabled, I just gave Github Permissions, so it started happening) https://cwiki.apache.org/confluence/display/INFRA/git+-+.asf.yaml+features#git.asf.yamlfeatures-Notificationsettingsforrepositories > Add .asf.yaml to allow github and jira integration > -- > > Key: HADOOP-17234 > URL: https://issues.apache.org/jira/browse/HADOOP-17234 > Project: Hadoop Common > Issue Type: Task >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > As of now the default for github is set only to worklog, To enable link and > label, We need to add this. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17234) Add .asf.yaml to allow github and jira integration
[ https://issues.apache.org/jira/browse/HADOOP-17234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186078#comment-17186078 ] Íñigo Goiri commented on HADOOP-17234: -- What would the integration look like? Do we have examples for other projects? > Add .asf.yaml to allow github and jira integration > -- > > Key: HADOOP-17234 > URL: https://issues.apache.org/jira/browse/HADOOP-17234 > Project: Hadoop Common > Issue Type: Task >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > As of now the default for github is set only to worklog, To enable link and > label, We need to add this. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17159) Make UGI support forceful relogin from keytab ignoring the last login time
[
https://issues.apache.org/jira/browse/HADOOP-17159?focusedWorklogId=475500&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475500
]
ASF GitHub Bot logged work on HADOOP-17159:
---
Author: ASF GitHub Bot
Created on: 27/Aug/20 19:23
Start Date: 27/Aug/20 19:23
Worklog Time Spent: 10m
Work Description: sguggilam commented on a change in pull request #2245:
URL: https://github.com/apache/hadoop/pull/2245#discussion_r478643533
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
##
@@ -1215,23 +1215,43 @@ private void fixKerberosTicketOrder() {
* Re-Login a user in from a keytab file. Loads a user identity from a keytab
* file and logs them in. They become the currently logged-in user. This
* method assumes that {@link #loginUserFromKeytab(String, String)} had
- * happened already.
- * The Subject field of this UserGroupInformation object is updated to have
- * the new credentials.
+ * happened already. The Subject field of this UserGroupInformation object is
+ * updated to have the new credentials.
+ *
* @throws IOException
* @throws KerberosAuthException on a failure
*/
@InterfaceAudience.Public
@InterfaceStability.Evolving
public synchronized void reloginFromKeytab() throws IOException {
+reloginFromKeytab(false);
+ }
+
+ /**
+ * Force re-Login a user in from a keytab file. Loads a user identity from a
+ * keytab file and logs them in. They become the currently logged-in user.
+ * This method assumes that {@link #loginUserFromKeytab(String, String)} had
+ * happened already. The Subject field of this UserGroupInformation object is
+ * updated to have the new credentials.
+ *
+ * @param ignoreTimeElapsed Force re-login irrespective of the time of last
+ * login
+ * @throws IOException
+ * @throws KerberosAuthException on a failure
+ */
+ @InterfaceAudience.Public
+ @InterfaceStability.Evolving
+ public synchronized void reloginFromKeytab(boolean ignoreTimeElapsed)
Review comment:
@liuml07 Yes it makes sense to keep the code consistent for the callers
to avoid such issues with a upgrade
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 475500)
Time Spent: 20m (was: 10m)
> Make UGI support forceful relogin from keytab ignoring the last login time
> --
>
> Key: HADOOP-17159
> URL: https://issues.apache.org/jira/browse/HADOOP-17159
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
>Affects Versions: 2.10.0, 3.3.0, 3.2.1, 3.1.3
>Reporter: Sandeep Guggilam
>Assignee: Sandeep Guggilam
>Priority: Major
> Fix For: 3.2.2, 3.3.1, 3.4.0, 3.1.5
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently we have a relogin() method in UGI which attempts to login if there
> is no login attempted in the last 10 minutes or configured amount of time
> We should also have provision for doing a forceful relogin irrespective of
> the time window that the client can choose to use it if needed . Consider the
> below scenario:
> # SASL Server is reimaged and new keytabs are fetched with refreshing the
> password
> # SASL client connection to the server would fail when it tries with the
> cached service ticket
> # We should try to logout to clear the service tickets in cache and then try
> to login back in such scenarios. But since the current relogin() doesn't
> guarantee a login, it could cause an issue
> # A forceful relogin in this case would help after logout
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] sguggilam commented on a change in pull request #2245: HADOOP-17159 Ability for forceful relogin in UserGroupInformation class
sguggilam commented on a change in pull request #2245:
URL: https://github.com/apache/hadoop/pull/2245#discussion_r478643533
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
##
@@ -1215,23 +1215,43 @@ private void fixKerberosTicketOrder() {
* Re-Login a user in from a keytab file. Loads a user identity from a keytab
* file and logs them in. They become the currently logged-in user. This
* method assumes that {@link #loginUserFromKeytab(String, String)} had
- * happened already.
- * The Subject field of this UserGroupInformation object is updated to have
- * the new credentials.
+ * happened already. The Subject field of this UserGroupInformation object is
+ * updated to have the new credentials.
+ *
* @throws IOException
* @throws KerberosAuthException on a failure
*/
@InterfaceAudience.Public
@InterfaceStability.Evolving
public synchronized void reloginFromKeytab() throws IOException {
+reloginFromKeytab(false);
+ }
+
+ /**
+ * Force re-Login a user in from a keytab file. Loads a user identity from a
+ * keytab file and logs them in. They become the currently logged-in user.
+ * This method assumes that {@link #loginUserFromKeytab(String, String)} had
+ * happened already. The Subject field of this UserGroupInformation object is
+ * updated to have the new credentials.
+ *
+ * @param ignoreTimeElapsed Force re-login irrespective of the time of last
+ * login
+ * @throws IOException
+ * @throws KerberosAuthException on a failure
+ */
+ @InterfaceAudience.Public
+ @InterfaceStability.Evolving
+ public synchronized void reloginFromKeytab(boolean ignoreTimeElapsed)
Review comment:
@liuml07 Yes it makes sense to keep the code consistent for the callers
to avoid such issues with a upgrade
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17227) improve s3guard markers command line tool
[ https://issues.apache.org/jira/browse/HADOOP-17227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186057#comment-17186057 ] Steve Loughran commented on HADOOP-17227: - PR is https://github.com/apache/hadoop/pull/2254 > improve s3guard markers command line tool > - > > Key: HADOOP-17227 > URL: https://issues.apache.org/jira/browse/HADOOP-17227 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 >Affects Versions: 3.4.0 >Reporter: Steve Loughran >Assignee: Steve Loughran >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The s3guard markers audit -expected N command is meant to verify that the > marker count is N, but > * it isn't verified if the #of markers is 0, so you can't use it to assert > that markers have been created > * it doesn't work for tests where you expect a minimum number of markers. > It's essentially setting a max #of markers > Proposed: explicit -min, -max args to declare a specific range of values -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17227) improve s3guard markers -expected
[ https://issues.apache.org/jira/browse/HADOOP-17227?focusedWorklogId=475490&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475490 ] ASF GitHub Bot logged work on HADOOP-17227: --- Author: ASF GitHub Bot Created on: 27/Aug/20 19:07 Start Date: 27/Aug/20 19:07 Worklog Time Spent: 10m Work Description: steveloughran opened a new pull request #2254: URL: https://github.com/apache/hadoop/pull/2254 * move from -expect to -min and -max; easier for CLI testing. Plus works * in -nonauth mode, even when policy == keep, files not in an auth path count as failure. * bucket-info option also prints out the authoritative path, so you have more idea what is happening * reporting of command failure more informative The reason for change #2 is a workflow where you want to audit a dir, even though you are in keep mode, and you don't have any auth path. You'd expect -nonauth to say "no auth path", but instead it treats the whole dir as auth. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 475490) Remaining Estimate: 0h Time Spent: 10m > improve s3guard markers -expected > -- > > Key: HADOOP-17227 > URL: https://issues.apache.org/jira/browse/HADOOP-17227 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 >Affects Versions: 3.4.0 >Reporter: Steve Loughran >Assignee: Steve Loughran >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The s3guard markers audit -expected N command is meant to verify that the > marker count is N, but > * it isn't verified if the #of markers is 0, so you can't use it to assert > that markers have been created > * it doesn't work for tests where you expect a minimum number of markers. > It's essentially setting a max #of markers > Proposed: explicit -min, -max args to declare a specific range of values -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work started] (HADOOP-17227) improve s3guard markers command line tool
[ https://issues.apache.org/jira/browse/HADOOP-17227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HADOOP-17227 started by Steve Loughran. --- > improve s3guard markers command line tool > - > > Key: HADOOP-17227 > URL: https://issues.apache.org/jira/browse/HADOOP-17227 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 >Affects Versions: 3.4.0 >Reporter: Steve Loughran >Assignee: Steve Loughran >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The s3guard markers audit -expected N command is meant to verify that the > marker count is N, but > * it isn't verified if the #of markers is 0, so you can't use it to assert > that markers have been created > * it doesn't work for tests where you expect a minimum number of markers. > It's essentially setting a max #of markers > Proposed: explicit -min, -max args to declare a specific range of values -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-17227) improve s3guard markers command line tool
[ https://issues.apache.org/jira/browse/HADOOP-17227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-17227: Summary: improve s3guard markers command line tool (was: improve s3guard markers -expected ) > improve s3guard markers command line tool > - > > Key: HADOOP-17227 > URL: https://issues.apache.org/jira/browse/HADOOP-17227 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 >Affects Versions: 3.4.0 >Reporter: Steve Loughran >Assignee: Steve Loughran >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The s3guard markers audit -expected N command is meant to verify that the > marker count is N, but > * it isn't verified if the #of markers is 0, so you can't use it to assert > that markers have been created > * it doesn't work for tests where you expect a minimum number of markers. > It's essentially setting a max #of markers > Proposed: explicit -min, -max args to declare a specific range of values -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran opened a new pull request #2254: HADOOP-17227. Marker Tool tuning
steveloughran opened a new pull request #2254: URL: https://github.com/apache/hadoop/pull/2254 * move from -expect to -min and -max; easier for CLI testing. Plus works * in -nonauth mode, even when policy == keep, files not in an auth path count as failure. * bucket-info option also prints out the authoritative path, so you have more idea what is happening * reporting of command failure more informative The reason for change #2 is a workflow where you want to audit a dir, even though you are in keep mode, and you don't have any auth path. You'd expect -nonauth to say "no auth path", but instead it treats the whole dir as auth. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2252: HDFS-15471. TestHDFSContractMultipartUploader failing
hadoop-yetus commented on pull request #2252: URL: https://github.com/apache/hadoop/pull/2252#issuecomment-682123897 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ trunk Compile Tests _ | | +0 :ok: | mvndep | 3m 20s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 25m 36s | trunk passed | | +1 :green_heart: | compile | 20m 55s | trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | compile | 17m 33s | trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +1 :green_heart: | checkstyle | 2m 39s | trunk passed | | +1 :green_heart: | mvnsite | 2m 51s | trunk passed | | +1 :green_heart: | shadedclient | 22m 41s | branch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 1m 47s | trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | javadoc | 3m 36s | trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +0 :ok: | spotbugs | 4m 4s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 6m 52s | trunk passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 30s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 35s | the patch passed | | +1 :green_heart: | compile | 24m 47s | the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | javac | 24m 47s | the patch passed | | +1 :green_heart: | compile | 22m 41s | the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +1 :green_heart: | javac | 22m 41s | the patch passed | | +1 :green_heart: | checkstyle | 3m 25s | the patch passed | | +1 :green_heart: | mvnsite | 3m 28s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedclient | 18m 11s | patch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 1m 38s | the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | javadoc | 3m 36s | the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +1 :green_heart: | findbugs | 7m 32s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 11m 18s | hadoop-common in the patch passed. | | -1 :x: | unit | 27m 14s | hadoop-hdfs in the patch passed. | | +1 :green_heart: | asflicense | 0m 54s | The patch does not generate ASF License warnings. | | | | 236m 2s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.ha.TestZKFailoverController | | | hadoop.hdfs.TestDatanodeLayoutUpgrade | | | hadoop.hdfs.TestFileChecksumCompositeCrc | | | hadoop.hdfs.TestReplaceDatanodeOnFailure | | | hadoop.hdfs.TestFileCreation | | | hadoop.hdfs.TestFileConcurrentReader | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2252/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/2252 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux f5c61fc54d74 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / d1c60a53f60 | | Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2252/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt | | unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2252/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2252/1/testReport/ | | Max. process+thread count | 3416
[GitHub] [hadoop] vivekratnavel merged pull request #2230: HDFS-15531. Namenode UI: List snapshots in separate table for each snapshottable directory
vivekratnavel merged pull request #2230: URL: https://github.com/apache/hadoop/pull/2230 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HADOOP-17232) Erasure Coding: Typo in document
[
https://issues.apache.org/jira/browse/HADOOP-17232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186040#comment-17186040
]
Mingliang Liu edited comment on HADOOP-17232 at 8/27/20, 6:35 PM:
--
The "set" happens twice in the sentence, existing sentence has a simple syntax
error (missing "the", and "use" should be "uses"), and it can be shorter (by
using "Otherwise"). So overall I propose the following revised version:
{code}
The ERASURECODING\_POLICY is name of the policy for the file. If an erasure
coding policy is set on that file, it will return the name of the policy.
Otherwise, it will return \"Replicated\" which means it uses the replication
storage strategy.
{code}
was (Author: liuml07):
Since the "set" happens twice in the sentence and existing sentence has a
simple syntax error (missing "the", and "use" should be "uses), I propose the
following revised version:
{code}
The ERASURECODING\_POLICY is name of the policy for the file. If an erasure
coding policy is set on that file, it will return the name of the policy. If no
erasure coding policy is set, it will return \"Replicated\" which means it uses
the replication storage strategy.
{code}
> Erasure Coding: Typo in document
>
>
> Key: HADOOP-17232
> URL: https://issues.apache.org/jira/browse/HADOOP-17232
> Project: Hadoop Common
> Issue Type: Improvement
> Components: documentation
>Affects Versions: 3.3.0
>Reporter: Fei Hui
>Assignee: Fei Hui
>Priority: Trivial
> Attachments: HADOOP-17232.001.patch
>
>
> When review ec document and code, find the typo.
> Change "a erasure code" to "an erasure code"
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17232) Erasure Coding: Typo in document
[
https://issues.apache.org/jira/browse/HADOOP-17232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186040#comment-17186040
]
Mingliang Liu commented on HADOOP-17232:
Since the "set" happens twice in the sentence and existing sentence has a
simple syntax error (missing "the", and "use" should be "uses), I propose the
following revised version:
{code}
The ERASURECODING\_POLICY is name of the policy for the file. If an erasure
coding policy is set on that file, it will return the name of the policy. If no
erasure coding policy is set, it will return \"Replicated\" which means it uses
the replication storage strategy.
{code}
> Erasure Coding: Typo in document
>
>
> Key: HADOOP-17232
> URL: https://issues.apache.org/jira/browse/HADOOP-17232
> Project: Hadoop Common
> Issue Type: Improvement
> Components: documentation
>Affects Versions: 3.3.0
>Reporter: Fei Hui
>Assignee: Fei Hui
>Priority: Trivial
> Attachments: HADOOP-17232.001.patch
>
>
> When review ec document and code, find the typo.
> Change "a erasure code" to "an erasure code"
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17232) Erasure Coding: Typo in document
[ https://issues.apache.org/jira/browse/HADOOP-17232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186037#comment-17186037 ] Mingliang Liu commented on HADOOP-17232: yeah, other than that I'm +1 4 binding +1 is way more enough for a typo fix. I'll leave it to you guys to commit :) > Erasure Coding: Typo in document > > > Key: HADOOP-17232 > URL: https://issues.apache.org/jira/browse/HADOOP-17232 > Project: Hadoop Common > Issue Type: Improvement > Components: documentation >Affects Versions: 3.3.0 >Reporter: Fei Hui >Assignee: Fei Hui >Priority: Trivial > Attachments: HADOOP-17232.001.patch > > > When review ec document and code, find the typo. > Change "a erasure code" to "an erasure code" -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17234) Add .asf.yaml to allow github and jira integration
[ https://issues.apache.org/jira/browse/HADOOP-17234?focusedWorklogId=475467&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475467 ] ASF GitHub Bot logged work on HADOOP-17234: --- Author: ASF GitHub Bot Created on: 27/Aug/20 18:24 Start Date: 27/Aug/20 18:24 Worklog Time Spent: 10m Work Description: ayushtkn commented on a change in pull request #2253: URL: https://github.com/apache/hadoop/pull/2253#discussion_r478611090 ## File path: .asf.yaml ## @@ -0,0 +1,25 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +github: + enabled_merge_buttons: +squash: true +merge: false +rebase: false +notifications: + commits: common-comm...@hadoop.apache.org + issues: common-issues@hadoop.apache.org + pullrequests: common-issues@hadoop.apache.org + jira_options: link label worklog Review comment: The link was added by me only. But I got this checked from the Infra team on the asfInfra slack channel and they only told, post this things should work. Regarding the newline, I don't know if it is required, Most of the files don't have it. If you say I will push a commit adding one [slack response](https://the-asf.slack.com/archives/CBX4TSBQ8/p1598542764423400) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 475467) Time Spent: 1h (was: 50m) > Add .asf.yaml to allow github and jira integration > -- > > Key: HADOOP-17234 > URL: https://issues.apache.org/jira/browse/HADOOP-17234 > Project: Hadoop Common > Issue Type: Task >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > As of now the default for github is set only to worklog, To enable link and > label, We need to add this. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] ayushtkn commented on a change in pull request #2253: HADOOP-17234. Add .asf.yaml to allow Github to Jira integration.
ayushtkn commented on a change in pull request #2253: URL: https://github.com/apache/hadoop/pull/2253#discussion_r478611090 ## File path: .asf.yaml ## @@ -0,0 +1,25 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +github: + enabled_merge_buttons: +squash: true +merge: false +rebase: false +notifications: + commits: common-comm...@hadoop.apache.org + issues: common-issues@hadoop.apache.org + pullrequests: common-issues@hadoop.apache.org + jira_options: link label worklog Review comment: The link was added by me only. But I got this checked from the Infra team on the asfInfra slack channel and they only told, post this things should work. Regarding the newline, I don't know if it is required, Most of the files don't have it. If you say I will push a commit adding one [slack response](https://the-asf.slack.com/archives/CBX4TSBQ8/p1598542764423400) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17232) Erasure Coding: Typo in document
[ https://issues.apache.org/jira/browse/HADOOP-17232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186034#comment-17186034 ] Wei-Chiu Chuang commented on HADOOP-17232: -- Nice catch [~liuml07]. [~ferhui] could you update the patch? +1 after that. > Erasure Coding: Typo in document > > > Key: HADOOP-17232 > URL: https://issues.apache.org/jira/browse/HADOOP-17232 > Project: Hadoop Common > Issue Type: Improvement > Components: documentation >Affects Versions: 3.3.0 >Reporter: Fei Hui >Assignee: Fei Hui >Priority: Trivial > Attachments: HADOOP-17232.001.patch > > > When review ec document and code, find the typo. > Change "a erasure code" to "an erasure code" -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17234) Add .asf.yaml to allow github and jira integration
[ https://issues.apache.org/jira/browse/HADOOP-17234?focusedWorklogId=475466&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475466 ] ASF GitHub Bot logged work on HADOOP-17234: --- Author: ASF GitHub Bot Created on: 27/Aug/20 18:22 Start Date: 27/Aug/20 18:22 Worklog Time Spent: 10m Work Description: ayushtkn commented on a change in pull request #2253: URL: https://github.com/apache/hadoop/pull/2253#discussion_r478611090 ## File path: .asf.yaml ## @@ -0,0 +1,25 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +github: + enabled_merge_buttons: +squash: true +merge: false +rebase: false +notifications: + commits: common-comm...@hadoop.apache.org + issues: common-issues@hadoop.apache.org + pullrequests: common-issues@hadoop.apache.org + jira_options: link label worklog Review comment: The link was added by me only. But I got this checked from the Infra team on the asfInfra slack channel and they only told, post this things should work. Regarding the newline, I don't know if it is required, Most of the files don't have it. If you say I will push a commit adding one This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 475466) Time Spent: 50m (was: 40m) > Add .asf.yaml to allow github and jira integration > -- > > Key: HADOOP-17234 > URL: https://issues.apache.org/jira/browse/HADOOP-17234 > Project: Hadoop Common > Issue Type: Task >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > As of now the default for github is set only to worklog, To enable link and > label, We need to add this. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] ayushtkn commented on a change in pull request #2253: HADOOP-17234. Add .asf.yaml to allow Github to Jira integration.
ayushtkn commented on a change in pull request #2253: URL: https://github.com/apache/hadoop/pull/2253#discussion_r478611090 ## File path: .asf.yaml ## @@ -0,0 +1,25 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +github: + enabled_merge_buttons: +squash: true +merge: false +rebase: false +notifications: + commits: common-comm...@hadoop.apache.org + issues: common-issues@hadoop.apache.org + pullrequests: common-issues@hadoop.apache.org + jira_options: link label worklog Review comment: The link was added by me only. But I got this checked from the Infra team on the asfInfra slack channel and they only told, post this things should work. Regarding the newline, I don't know if it is required, Most of the files don't have it. If you say I will push a commit adding one This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HADOOP-17232) Erasure Coding: Typo in document
[
https://issues.apache.org/jira/browse/HADOOP-17232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186033#comment-17186033
]
Mingliang Liu edited comment on HADOOP-17232 at 8/27/20, 6:20 PM:
--
Not native English speaker, but set's past participle is also set right?
{code}
If an erasure coding policy is setted on that file,...
{code}
should be
{code}
If an erasure coding policy is set on that file,
{code}
was (Author: liuml07):
Not native English speaker, but set's part participle is also set right?
{code}
If an erasure coding policy is setted on that file,...
{code}
should be
{code}
If an erasure coding policy is set on that file,
{code}
> Erasure Coding: Typo in document
>
>
> Key: HADOOP-17232
> URL: https://issues.apache.org/jira/browse/HADOOP-17232
> Project: Hadoop Common
> Issue Type: Improvement
> Components: documentation
>Affects Versions: 3.3.0
>Reporter: Fei Hui
>Assignee: Fei Hui
>Priority: Trivial
> Attachments: HADOOP-17232.001.patch
>
>
> When review ec document and code, find the typo.
> Change "a erasure code" to "an erasure code"
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17232) Erasure Coding: Typo in document
[
https://issues.apache.org/jira/browse/HADOOP-17232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186033#comment-17186033
]
Mingliang Liu commented on HADOOP-17232:
Not native English speaker, but set's part participle is also set right?
{code}
If an erasure coding policy is setted on that file,...
{code}
should be
{code}
If an erasure coding policy is set on that file,
{code}
> Erasure Coding: Typo in document
>
>
> Key: HADOOP-17232
> URL: https://issues.apache.org/jira/browse/HADOOP-17232
> Project: Hadoop Common
> Issue Type: Improvement
> Components: documentation
>Affects Versions: 3.3.0
>Reporter: Fei Hui
>Assignee: Fei Hui
>Priority: Trivial
> Attachments: HADOOP-17232.001.patch
>
>
> When review ec document and code, find the typo.
> Change "a erasure code" to "an erasure code"
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] liuml07 commented on a change in pull request #2253: HADOOP-17234. Add .asf.yaml to allow Github to Jira integration.
liuml07 commented on a change in pull request #2253: URL: https://github.com/apache/hadoop/pull/2253#discussion_r478608405 ## File path: .asf.yaml ## @@ -0,0 +1,25 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +github: + enabled_merge_buttons: +squash: true +merge: false +rebase: false +notifications: + commits: common-comm...@hadoop.apache.org + issues: common-issues@hadoop.apache.org + pullrequests: common-issues@hadoop.apache.org + jira_options: link label worklog Review comment: nit: do we need newline at the end of file? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17234) Add .asf.yaml to allow github and jira integration
[ https://issues.apache.org/jira/browse/HADOOP-17234?focusedWorklogId=475465&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475465 ] ASF GitHub Bot logged work on HADOOP-17234: --- Author: ASF GitHub Bot Created on: 27/Aug/20 18:17 Start Date: 27/Aug/20 18:17 Worklog Time Spent: 10m Work Description: liuml07 commented on a change in pull request #2253: URL: https://github.com/apache/hadoop/pull/2253#discussion_r478608405 ## File path: .asf.yaml ## @@ -0,0 +1,25 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +github: + enabled_merge_buttons: +squash: true +merge: false +rebase: false +notifications: + commits: common-comm...@hadoop.apache.org + issues: common-issues@hadoop.apache.org + pullrequests: common-issues@hadoop.apache.org + jira_options: link label worklog Review comment: nit: do we need newline at the end of file? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 475465) Time Spent: 40m (was: 0.5h) > Add .asf.yaml to allow github and jira integration > -- > > Key: HADOOP-17234 > URL: https://issues.apache.org/jira/browse/HADOOP-17234 > Project: Hadoop Common > Issue Type: Task >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > As of now the default for github is set only to worklog, To enable link and > label, We need to add this. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] liuml07 commented on a change in pull request #2245: HADOOP-17159 Ability for forceful relogin in UserGroupInformation class
liuml07 commented on a change in pull request #2245:
URL: https://github.com/apache/hadoop/pull/2245#discussion_r478602120
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
##
@@ -1215,23 +1215,43 @@ private void fixKerberosTicketOrder() {
* Re-Login a user in from a keytab file. Loads a user identity from a keytab
* file and logs them in. They become the currently logged-in user. This
* method assumes that {@link #loginUserFromKeytab(String, String)} had
- * happened already.
- * The Subject field of this UserGroupInformation object is updated to have
- * the new credentials.
+ * happened already. The Subject field of this UserGroupInformation object is
+ * updated to have the new credentials.
+ *
* @throws IOException
* @throws KerberosAuthException on a failure
*/
@InterfaceAudience.Public
@InterfaceStability.Evolving
public synchronized void reloginFromKeytab() throws IOException {
+reloginFromKeytab(false);
+ }
+
+ /**
+ * Force re-Login a user in from a keytab file. Loads a user identity from a
+ * keytab file and logs them in. They become the currently logged-in user.
+ * This method assumes that {@link #loginUserFromKeytab(String, String)} had
+ * happened already. The Subject field of this UserGroupInformation object is
+ * updated to have the new credentials.
+ *
+ * @param ignoreTimeElapsed Force re-login irrespective of the time of last
+ * login
+ * @throws IOException
+ * @throws KerberosAuthException on a failure
+ */
+ @InterfaceAudience.Public
+ @InterfaceStability.Evolving
+ public synchronized void reloginFromKeytab(boolean ignoreTimeElapsed)
Review comment:
I'm thinking of the same problem of the same method signature when
potential Hadoop 2 code calling `reloginFromKeytab(false)` upgrades to Hadoop
3. Because of the same method name and a bool parameter, users most likely will
not notice the parameter value is for different meanings: in Hadoop 2 here, the
bool parameter is for `ignoreTimeElapsed` where in Hadoop 3 it is actually for
`checkTGT`.
So is it better to:
1. Make this new API `public synchronized void reloginFromKeytab(boolean
ignoreTimeElapsed)` private
2. AND we also add the new API as in Hadoop 3: `public void
forceReloginFromKeytab()`.
That way, the application code which forces login will have the same code
between Hadoop 2 and 3. And the other new API `reloginFromKeytab(boolean)` is
private in UGI both in Hadoop 2 and 3.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17159) Make UGI support forceful relogin from keytab ignoring the last login time
[
https://issues.apache.org/jira/browse/HADOOP-17159?focusedWorklogId=475460&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475460
]
ASF GitHub Bot logged work on HADOOP-17159:
---
Author: ASF GitHub Bot
Created on: 27/Aug/20 18:05
Start Date: 27/Aug/20 18:05
Worklog Time Spent: 10m
Work Description: liuml07 commented on a change in pull request #2245:
URL: https://github.com/apache/hadoop/pull/2245#discussion_r478602120
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
##
@@ -1215,23 +1215,43 @@ private void fixKerberosTicketOrder() {
* Re-Login a user in from a keytab file. Loads a user identity from a keytab
* file and logs them in. They become the currently logged-in user. This
* method assumes that {@link #loginUserFromKeytab(String, String)} had
- * happened already.
- * The Subject field of this UserGroupInformation object is updated to have
- * the new credentials.
+ * happened already. The Subject field of this UserGroupInformation object is
+ * updated to have the new credentials.
+ *
* @throws IOException
* @throws KerberosAuthException on a failure
*/
@InterfaceAudience.Public
@InterfaceStability.Evolving
public synchronized void reloginFromKeytab() throws IOException {
+reloginFromKeytab(false);
+ }
+
+ /**
+ * Force re-Login a user in from a keytab file. Loads a user identity from a
+ * keytab file and logs them in. They become the currently logged-in user.
+ * This method assumes that {@link #loginUserFromKeytab(String, String)} had
+ * happened already. The Subject field of this UserGroupInformation object is
+ * updated to have the new credentials.
+ *
+ * @param ignoreTimeElapsed Force re-login irrespective of the time of last
+ * login
+ * @throws IOException
+ * @throws KerberosAuthException on a failure
+ */
+ @InterfaceAudience.Public
+ @InterfaceStability.Evolving
+ public synchronized void reloginFromKeytab(boolean ignoreTimeElapsed)
Review comment:
I'm thinking of the same problem of the same method signature when
potential Hadoop 2 code calling `reloginFromKeytab(false)` upgrades to Hadoop
3. Because of the same method name and a bool parameter, users most likely will
not notice the parameter value is for different meanings: in Hadoop 2 here, the
bool parameter is for `ignoreTimeElapsed` where in Hadoop 3 it is actually for
`checkTGT`.
So is it better to:
1. Make this new API `public synchronized void reloginFromKeytab(boolean
ignoreTimeElapsed)` private
2. AND we also add the new API as in Hadoop 3: `public void
forceReloginFromKeytab()`.
That way, the application code which forces login will have the same code
between Hadoop 2 and 3. And the other new API `reloginFromKeytab(boolean)` is
private in UGI both in Hadoop 2 and 3.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 475460)
Remaining Estimate: 0h
Time Spent: 10m
> Make UGI support forceful relogin from keytab ignoring the last login time
> --
>
> Key: HADOOP-17159
> URL: https://issues.apache.org/jira/browse/HADOOP-17159
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
>Affects Versions: 2.10.0, 3.3.0, 3.2.1, 3.1.3
>Reporter: Sandeep Guggilam
>Assignee: Sandeep Guggilam
>Priority: Major
> Fix For: 3.2.2, 3.3.1, 3.4.0, 3.1.5
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently we have a relogin() method in UGI which attempts to login if there
> is no login attempted in the last 10 minutes or configured amount of time
> We should also have provision for doing a forceful relogin irrespective of
> the time window that the client can choose to use it if needed . Consider the
> below scenario:
> # SASL Server is reimaged and new keytabs are fetched with refreshing the
> password
> # SASL client connection to the server would fail when it tries with the
> cached service ticket
> # We should try to logout to clear the service tickets in cache and then try
> to login back in such scenarios. But since the current relogin() doesn't
> guarantee a login, it could cause an issue
> # A forceful relogin in this case would help after logout
>
--
This message was sent by Atlassian Jira
(v8.3
[jira] [Work logged] (HADOOP-17234) Add .asf.yaml to allow github and jira integration
[ https://issues.apache.org/jira/browse/HADOOP-17234?focusedWorklogId=475431&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475431 ] ASF GitHub Bot logged work on HADOOP-17234: --- Author: ASF GitHub Bot Created on: 27/Aug/20 17:21 Start Date: 27/Aug/20 17:21 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on pull request #2253: URL: https://github.com/apache/hadoop/pull/2253#issuecomment-682083938 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 58s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | yamllint | 0m 0s | yamllint was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ trunk Compile Tests _ | | +1 :green_heart: | shadedclient | 23m 52s | branch has no errors when building and testing our client artifacts. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedclient | 17m 19s | patch has no errors when building and testing our client artifacts. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 37s | The patch does not generate ASF License warnings. | | | | 47m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2253/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/2253 | | Optional Tests | dupname asflicense yamllint | | uname | Linux d3b09e41508b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / d1c60a53f60 | | Max. process+thread count | 311 (vs. ulimit of 5500) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2253/2/console | | versions | git=2.17.1 maven=3.6.0 | | Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 475431) Time Spent: 0.5h (was: 20m) > Add .asf.yaml to allow github and jira integration > -- > > Key: HADOOP-17234 > URL: https://issues.apache.org/jira/browse/HADOOP-17234 > Project: Hadoop Common > Issue Type: Task >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > As of now the default for github is set only to worklog, To enable link and > label, We need to add this. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2253: HADOOP-17234. Add .asf.yaml to allow Github to Jira integration.
hadoop-yetus commented on pull request #2253: URL: https://github.com/apache/hadoop/pull/2253#issuecomment-682083938 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 58s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | yamllint | 0m 0s | yamllint was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ trunk Compile Tests _ | | +1 :green_heart: | shadedclient | 23m 52s | branch has no errors when building and testing our client artifacts. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedclient | 17m 19s | patch has no errors when building and testing our client artifacts. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 37s | The patch does not generate ASF License warnings. | | | | 47m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2253/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/2253 | | Optional Tests | dupname asflicense yamllint | | uname | Linux d3b09e41508b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / d1c60a53f60 | | Max. process+thread count | 311 (vs. ulimit of 5500) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2253/2/console | | versions | git=2.17.1 maven=3.6.0 | | Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #2252: HDFS-15471. TestHDFSContractMultipartUploader failing
steveloughran commented on pull request #2252: URL: https://github.com/apache/hadoop/pull/2252#issuecomment-682078871 > Ignore me, I'm just seeing why PRs are not linking to github in this case... no idea -just linked it by hand. Some discussion on common-dev about JIRA permissions This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16795) Java 11 compile support
[ https://issues.apache.org/jira/browse/HADOOP-16795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185951#comment-17185951 ] Davin Chia commented on HADOOP-16795: - [~aajisaka] are you taking volunteers with this effort? This is my first time contributing to Hadoop so I'm clear about etiquette. Let me know if there are official processes for work to get assigned. > Java 11 compile support > --- > > Key: HADOOP-16795 > URL: https://issues.apache.org/jira/browse/HADOOP-16795 > Project: Hadoop Common > Issue Type: Improvement > Components: build >Reporter: Akira Ajisaka >Priority: Major > > Split from HADOOP-15338. > Now Hadoop must be compiled with Java 8. This issue is to support compiling > Hadoop with Java 11. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17234) Add .asf.yaml to allow github and jira integration
[ https://issues.apache.org/jira/browse/HADOOP-17234?focusedWorklogId=475393&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475393 ] ASF GitHub Bot logged work on HADOOP-17234: --- Author: ASF GitHub Bot Created on: 27/Aug/20 16:19 Start Date: 27/Aug/20 16:19 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on pull request #2253: URL: https://github.com/apache/hadoop/pull/2253#issuecomment-682050502 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | yamllint | 0m 0s | yamllint was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ trunk Compile Tests _ | | +1 :green_heart: | shadedclient | 21m 3s | branch has no errors when building and testing our client artifacts. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedclient | 16m 8s | patch has no errors when building and testing our client artifacts. | ||| _ Other Tests _ | | -1 :x: | asflicense | 0m 29s | The patch generated 1 ASF License warnings. | | | | 43m 1s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2253/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/2253 | | Optional Tests | dupname asflicense yamllint | | uname | Linux a2a9a15cb42a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / d1c60a53f60 | | asflicense | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2253/1/artifact/out/patch-asflicense-problems.txt | | Max. process+thread count | 307 (vs. ulimit of 5500) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2253/1/console | | versions | git=2.17.1 maven=3.6.0 | | Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 475393) Time Spent: 20m (was: 10m) > Add .asf.yaml to allow github and jira integration > -- > > Key: HADOOP-17234 > URL: https://issues.apache.org/jira/browse/HADOOP-17234 > Project: Hadoop Common > Issue Type: Task >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > As of now the default for github is set only to worklog, To enable link and > label, We need to add this. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2253: HADOOP-17234. Add .asf.yaml to allow Github to Jira integration.
hadoop-yetus commented on pull request #2253: URL: https://github.com/apache/hadoop/pull/2253#issuecomment-682050502 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | yamllint | 0m 0s | yamllint was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ trunk Compile Tests _ | | +1 :green_heart: | shadedclient | 21m 3s | branch has no errors when building and testing our client artifacts. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedclient | 16m 8s | patch has no errors when building and testing our client artifacts. | ||| _ Other Tests _ | | -1 :x: | asflicense | 0m 29s | The patch generated 1 ASF License warnings. | | | | 43m 1s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2253/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/2253 | | Optional Tests | dupname asflicense yamllint | | uname | Linux a2a9a15cb42a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / d1c60a53f60 | | asflicense | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2253/1/artifact/out/patch-asflicense-problems.txt | | Max. process+thread count | 307 (vs. ulimit of 5500) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2253/1/console | | versions | git=2.17.1 maven=3.6.0 | | Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17232) Erasure Coding: Typo in document
[
https://issues.apache.org/jira/browse/HADOOP-17232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185925#comment-17185925
]
Hadoop QA commented on HADOOP-17232:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 33m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:blue}0{color} | {color:blue} markdownlint {color} | {color:blue} 0m
0s{color} | {color:blue} markdownlint was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 30m
54s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 21m
12s{color} | {color:green} trunk passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 17m
47s{color} | {color:green} trunk passed with JDK Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
45s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
17m 43s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} trunk passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
24s{color} | {color:green} trunk passed with JDK Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 2m
18s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
16s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 20m
34s{color} | {color:green} the patch passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 20m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 17m
46s{color} | {color:green} the patch passed with JDK Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 17m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
15m 23s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
27s{color} | {color:green} the patch passed with JDK Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 {color} |
| {color:green}+1{color} | {color:green} findb
[jira] [Updated] (HADOOP-17234) Add .asf.yaml to allow github and jira integration
[ https://issues.apache.org/jira/browse/HADOOP-17234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena updated HADOOP-17234: -- Status: Patch Available (was: Open) > Add .asf.yaml to allow github and jira integration > -- > > Key: HADOOP-17234 > URL: https://issues.apache.org/jira/browse/HADOOP-17234 > Project: Hadoop Common > Issue Type: Task >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > As of now the default for github is set only to worklog, To enable link and > label, We need to add this. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17234) Add .asf.yaml to allow github and jira integration
[ https://issues.apache.org/jira/browse/HADOOP-17234?focusedWorklogId=475359&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475359 ] ASF GitHub Bot logged work on HADOOP-17234: --- Author: ASF GitHub Bot Created on: 27/Aug/20 15:35 Start Date: 27/Aug/20 15:35 Worklog Time Spent: 10m Work Description: ayushtkn opened a new pull request #2253: URL: https://github.com/apache/hadoop/pull/2253 https://issues.apache.org/jira/browse/HADOOP-17234 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 475359) Remaining Estimate: 0h Time Spent: 10m > Add .asf.yaml to allow github and jira integration > -- > > Key: HADOOP-17234 > URL: https://issues.apache.org/jira/browse/HADOOP-17234 > Project: Hadoop Common > Issue Type: Task >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > As of now the default for github is set only to worklog, To enable link and > label, We need to add this. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] ayushtkn opened a new pull request #2253: HADOOP-17234. Add .asf.yaml to allow Github to Jira integration.
ayushtkn opened a new pull request #2253: URL: https://github.com/apache/hadoop/pull/2253 https://issues.apache.org/jira/browse/HADOOP-17234 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Created] (HADOOP-17234) Add .asf.yaml to allow github and jira integration
Ayush Saxena created HADOOP-17234: - Summary: Add .asf.yaml to allow github and jira integration Key: HADOOP-17234 URL: https://issues.apache.org/jira/browse/HADOOP-17234 Project: Hadoop Common Issue Type: Task Reporter: Ayush Saxena Assignee: Ayush Saxena As of now the default for github is set only to worklog, To enable link and label, We need to add this. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] Humbedooh commented on pull request #2252: HDFS-15471. TestHDFSContractMultipartUploader failing
Humbedooh commented on pull request #2252: URL: https://github.com/apache/hadoop/pull/2252#issuecomment-682010131 Ignore me, I'm just seeing why PRs are not linking to github in this case... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran opened a new pull request #2252: HDFS-15471. TestHDFSContractMultipartUploader failing
steveloughran opened a new pull request #2252: URL: https://github.com/apache/hadoop/pull/2252 Contributed by Steve Loughran (Also: broken by Steve Loughran) PR includes a minor change to the HDFS Code to ensure yetus is happy; main change is that the eventually() clause is skipped on a consistent store, because it is not needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] mukund-thakur commented on pull request #2187: HADOOP-17167 Skipping ITestS3AEncryptionWithDefaultS3Settings.testEncryptionOverRename
mukund-thakur commented on pull request #2187: URL: https://github.com/apache/hadoop/pull/2187#issuecomment-681985916 @steveloughran Gentle Reminder to check this one. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] 1996fanrui commented on a change in pull request #2241: HADOOP-17222. Create socket address combined with cache
1996fanrui commented on a change in pull request #2241:
URL: https://github.com/apache/hadoop/pull/2241#discussion_r478463733
##
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestNetUtils.java
##
@@ -360,6 +360,49 @@ public void testCreateSocketAddress() throws Throwable {
}
}
+ @Test
+ public void testCreateSocketAddressWithURICache() throws Throwable {
+InetSocketAddress addr = NetUtils.createSocketAddr(
+"127.0.0.1:12345", 1000, "myconfig", true);
+assertEquals("127.0.0.1", addr.getAddress().getHostAddress());
+assertEquals(12345, addr.getPort());
+
+addr = NetUtils.createSocketAddr(
+"127.0.0.1:12345", 1000, "myconfig", true);
+assertEquals("127.0.0.1", addr.getAddress().getHostAddress());
+assertEquals(12345, addr.getPort());
+
+//
+
+addr = NetUtils.createSocketAddr(
+"127.0.0.1", 1000, "myconfig", true);
+assertEquals("127.0.0.1", addr.getAddress().getHostAddress());
+assertEquals(1000, addr.getPort());
+
+addr = NetUtils.createSocketAddr(
+"127.0.0.1", 1000, "myconfig", true);
+assertEquals("127.0.0.1", addr.getAddress().getHostAddress());
+assertEquals(1000, addr.getPort());
+
+//
+
+try {
+ addr = NetUtils.createSocketAddr(
Review comment:
@Hexiaoqiao I have done it
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Resolved] (HADOOP-16934) Test failure in TestAbfsOutputStream because of HADOOP-16910
[ https://issues.apache.org/jira/browse/HADOOP-16934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mehakmeet Singh resolved HADOOP-16934. -- Resolution: Duplicate > Test failure in TestAbfsOutputStream because of HADOOP-16910 > > > Key: HADOOP-16934 > URL: https://issues.apache.org/jira/browse/HADOOP-16934 > Project: Hadoop Common > Issue Type: Bug > Components: fs/azure >Affects Versions: 3.2.1 >Reporter: Mehakmeet Singh >Assignee: Mehakmeet Singh >Priority: Major > Labels: release-blocker > > Failure in TestAbfsOutputStream.java due to not passing FileSystem.Statistics > in AbfsOutputstream. > job: > - Passing Statistics through AbfsOutputStream. > - Closing streams in the test -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Resolved] (HADOOP-17065) Adding Network Counters in ABFS
[ https://issues.apache.org/jira/browse/HADOOP-17065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mehakmeet Singh resolved HADOOP-17065. -- Resolution: Fixed > Adding Network Counters in ABFS > --- > > Key: HADOOP-17065 > URL: https://issues.apache.org/jira/browse/HADOOP-17065 > Project: Hadoop Common > Issue Type: Improvement > Components: fs/azure >Affects Versions: 3.3.0 >Reporter: Mehakmeet Singh >Assignee: Mehakmeet Singh >Priority: Major > Fix For: 3.3.1 > > > Network Counters to be added in ABFS: > |CONNECTIONS_MADE|Number of times connection was made with Azure Data Lake| > |SEND_REQUESTS|Number of send requests| > |GET_RESPONSE|Number of response gotten| > |BYTES_SEND|Number of bytes send| > |BYTES_RECEIVED|Number of bytes received| > |READ_THROTTLE|Number of times throttled while read operation| > |WRITE_THROTTLE|Number of times throttled while write operation| > propose: > * Adding these counters as part of AbfsStatistic already made in > HADOOP-17016. > * Increment of counters across Abfs Network services. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Resolved] (HADOOP-17129) Validating storage keys in ABFS correctly
[ https://issues.apache.org/jira/browse/HADOOP-17129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mehakmeet Singh resolved HADOOP-17129. -- Fix Version/s: 3.3.1 Resolution: Fixed > Validating storage keys in ABFS correctly > - > > Key: HADOOP-17129 > URL: https://issues.apache.org/jira/browse/HADOOP-17129 > Project: Hadoop Common > Issue Type: Bug > Components: fs/azure >Affects Versions: 3.3.0 >Reporter: Mehakmeet Singh >Assignee: Mehakmeet Singh >Priority: Major > Fix For: 3.3.1 > > > Storage Keys in ABFS should be validated after the keys have been loaded. > work: > - Remove the previous validation of storage keys. > - Validate at the correct place. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] 1996fanrui commented on a change in pull request #2241: HADOOP-17222. Create socket address combined with cache
1996fanrui commented on a change in pull request #2241:
URL: https://github.com/apache/hadoop/pull/2241#discussion_r478422005
##
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestNetUtils.java
##
@@ -360,6 +360,49 @@ public void testCreateSocketAddress() throws Throwable {
}
}
+ @Test
+ public void testCreateSocketAddressWithURICache() throws Throwable {
+InetSocketAddress addr = NetUtils.createSocketAddr(
+"127.0.0.1:12345", 1000, "myconfig", true);
+assertEquals("127.0.0.1", addr.getAddress().getHostAddress());
+assertEquals(12345, addr.getPort());
+
+addr = NetUtils.createSocketAddr(
+"127.0.0.1:12345", 1000, "myconfig", true);
+assertEquals("127.0.0.1", addr.getAddress().getHostAddress());
+assertEquals(12345, addr.getPort());
+
+//
+
+addr = NetUtils.createSocketAddr(
+"127.0.0.1", 1000, "myconfig", true);
+assertEquals("127.0.0.1", addr.getAddress().getHostAddress());
+assertEquals(1000, addr.getPort());
+
+addr = NetUtils.createSocketAddr(
+"127.0.0.1", 1000, "myconfig", true);
+assertEquals("127.0.0.1", addr.getAddress().getHostAddress());
+assertEquals(1000, addr.getPort());
+
+//
+
+try {
+ addr = NetUtils.createSocketAddr(
Review comment:
ok, I will do it
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #2248: HADOOP-17230. Fix JAVA_HOME with spaces
steveloughran commented on pull request #2248: URL: https://github.com/apache/hadoop/pull/2248#issuecomment-681945141 didn't know you could turn off 8.3 naming in NTFS. Underlying issue here is that JDKs will go under C:\Program Files\ unless you tell the installer not to. I think our docs all say "don't do that", but, well, it's possibly a bit late by then. Maybe look for a " " in the filename and only shortname if there is one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] Hexiaoqiao commented on a change in pull request #2241: HADOOP-17222. Create socket address combined with cache
Hexiaoqiao commented on a change in pull request #2241:
URL: https://github.com/apache/hadoop/pull/2241#discussion_r478402307
##
File path:
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/DfsClientConf.java
##
@@ -211,24 +212,7 @@ public DfsClientConf(Configuration conf) {
Write.MAX_PACKETS_IN_FLIGHT_KEY,
Write.MAX_PACKETS_IN_FLIGHT_DEFAULT);
-final boolean byteArrayManagerEnabled = conf.getBoolean(
-Write.ByteArrayManager.ENABLED_KEY,
-Write.ByteArrayManager.ENABLED_DEFAULT);
-if (!byteArrayManagerEnabled) {
- writeByteArrayManagerConf = null;
-} else {
- final int countThreshold = conf.getInt(
- Write.ByteArrayManager.COUNT_THRESHOLD_KEY,
- Write.ByteArrayManager.COUNT_THRESHOLD_DEFAULT);
- final int countLimit = conf.getInt(
- Write.ByteArrayManager.COUNT_LIMIT_KEY,
- Write.ByteArrayManager.COUNT_LIMIT_DEFAULT);
- final long countResetTimePeriodMs = conf.getLong(
- Write.ByteArrayManager.COUNT_RESET_TIME_PERIOD_MS_KEY,
- Write.ByteArrayManager.COUNT_RESET_TIME_PERIOD_MS_DEFAULT);
- writeByteArrayManagerConf = new ByteArrayManager.Conf(
- countThreshold, countLimit, countResetTimePeriodMs);
-}
+writeByteArrayManagerConf = loadWriteByteArrayManagerConf(conf);
Review comment:
Thanks for your quick response, this is reasonable.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] 1996fanrui commented on a change in pull request #2241: HADOOP-17222. Create socket address combined with cache
1996fanrui commented on a change in pull request #2241:
URL: https://github.com/apache/hadoop/pull/2241#discussion_r478399989
##
File path:
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/DfsClientConf.java
##
@@ -211,24 +212,7 @@ public DfsClientConf(Configuration conf) {
Write.MAX_PACKETS_IN_FLIGHT_KEY,
Write.MAX_PACKETS_IN_FLIGHT_DEFAULT);
-final boolean byteArrayManagerEnabled = conf.getBoolean(
-Write.ByteArrayManager.ENABLED_KEY,
-Write.ByteArrayManager.ENABLED_DEFAULT);
-if (!byteArrayManagerEnabled) {
- writeByteArrayManagerConf = null;
-} else {
- final int countThreshold = conf.getInt(
- Write.ByteArrayManager.COUNT_THRESHOLD_KEY,
- Write.ByteArrayManager.COUNT_THRESHOLD_DEFAULT);
- final int countLimit = conf.getInt(
- Write.ByteArrayManager.COUNT_LIMIT_KEY,
- Write.ByteArrayManager.COUNT_LIMIT_DEFAULT);
- final long countResetTimePeriodMs = conf.getLong(
- Write.ByteArrayManager.COUNT_RESET_TIME_PERIOD_MS_KEY,
- Write.ByteArrayManager.COUNT_RESET_TIME_PERIOD_MS_DEFAULT);
- writeByteArrayManagerConf = new ByteArrayManager.Conf(
- countThreshold, countLimit, countResetTimePeriodMs);
-}
+writeByteArrayManagerConf = loadWriteByteArrayManagerConf(conf);
Review comment:
The constructor of DfsClientConf exceeds 150 lines, and the checkstyle
is not passed. So a simple refactoring was made.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] 1996fanrui commented on a change in pull request #2241: HADOOP-17222. Create socket address combined with cache
1996fanrui commented on a change in pull request #2241:
URL: https://github.com/apache/hadoop/pull/2241#discussion_r478397859
##
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestNetUtils.java
##
@@ -360,6 +360,49 @@ public void testCreateSocketAddress() throws Throwable {
}
}
+ @Test
+ public void testCreateSocketAddressWithURICache() throws Throwable {
+InetSocketAddress addr = NetUtils.createSocketAddr(
+"127.0.0.1:12345", 1000, "myconfig", true);
+assertEquals("127.0.0.1", addr.getAddress().getHostAddress());
+assertEquals(12345, addr.getPort());
+
+addr = NetUtils.createSocketAddr(
+"127.0.0.1:12345", 1000, "myconfig", true);
+assertEquals("127.0.0.1", addr.getAddress().getHostAddress());
+assertEquals(12345, addr.getPort());
+
+//
Review comment:
@Hexiaoqiao , thanks for your review.
To test the Cache, the same case is executed twice. There are a total of
three cases. In order to divide the three cases, these comments are added.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17232) Erasure Coding: Typo in document
[ https://issues.apache.org/jira/browse/HADOOP-17232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185833#comment-17185833 ] Xiaoqiao He commented on HADOOP-17232: -- +1 > Erasure Coding: Typo in document > > > Key: HADOOP-17232 > URL: https://issues.apache.org/jira/browse/HADOOP-17232 > Project: Hadoop Common > Issue Type: Improvement > Components: documentation >Affects Versions: 3.3.0 >Reporter: Fei Hui >Assignee: Fei Hui >Priority: Trivial > Attachments: HADOOP-17232.001.patch > > > When review ec document and code, find the typo. > Change "a erasure code" to "an erasure code" -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] Hexiaoqiao commented on a change in pull request #2241: HADOOP-17222. Create socket address combined with cache
Hexiaoqiao commented on a change in pull request #2241:
URL: https://github.com/apache/hadoop/pull/2241#discussion_r478387611
##
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestNetUtils.java
##
@@ -360,6 +360,49 @@ public void testCreateSocketAddress() throws Throwable {
}
}
+ @Test
+ public void testCreateSocketAddressWithURICache() throws Throwable {
+InetSocketAddress addr = NetUtils.createSocketAddr(
+"127.0.0.1:12345", 1000, "myconfig", true);
+assertEquals("127.0.0.1", addr.getAddress().getHostAddress());
+assertEquals(12345, addr.getPort());
+
+addr = NetUtils.createSocketAddr(
+"127.0.0.1:12345", 1000, "myconfig", true);
+assertEquals("127.0.0.1", addr.getAddress().getHostAddress());
+assertEquals(12345, addr.getPort());
+
+//
Review comment:
nit: delete no meaningless annotation?
##
File path:
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/DfsClientConf.java
##
@@ -211,24 +212,7 @@ public DfsClientConf(Configuration conf) {
Write.MAX_PACKETS_IN_FLIGHT_KEY,
Write.MAX_PACKETS_IN_FLIGHT_DEFAULT);
-final boolean byteArrayManagerEnabled = conf.getBoolean(
-Write.ByteArrayManager.ENABLED_KEY,
-Write.ByteArrayManager.ENABLED_DEFAULT);
-if (!byteArrayManagerEnabled) {
- writeByteArrayManagerConf = null;
-} else {
- final int countThreshold = conf.getInt(
- Write.ByteArrayManager.COUNT_THRESHOLD_KEY,
- Write.ByteArrayManager.COUNT_THRESHOLD_DEFAULT);
- final int countLimit = conf.getInt(
- Write.ByteArrayManager.COUNT_LIMIT_KEY,
- Write.ByteArrayManager.COUNT_LIMIT_DEFAULT);
- final long countResetTimePeriodMs = conf.getLong(
- Write.ByteArrayManager.COUNT_RESET_TIME_PERIOD_MS_KEY,
- Write.ByteArrayManager.COUNT_RESET_TIME_PERIOD_MS_DEFAULT);
- writeByteArrayManagerConf = new ByteArrayManager.Conf(
- countThreshold, countLimit, countResetTimePeriodMs);
-}
+writeByteArrayManagerConf = loadWriteByteArrayManagerConf(conf);
Review comment:
nit: the changes seems no related with this ticket, Should we update it
in another single one?
##
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestNetUtils.java
##
@@ -360,6 +360,49 @@ public void testCreateSocketAddress() throws Throwable {
}
}
+ @Test
+ public void testCreateSocketAddressWithURICache() throws Throwable {
+InetSocketAddress addr = NetUtils.createSocketAddr(
+"127.0.0.1:12345", 1000, "myconfig", true);
+assertEquals("127.0.0.1", addr.getAddress().getHostAddress());
+assertEquals(12345, addr.getPort());
+
+addr = NetUtils.createSocketAddr(
+"127.0.0.1:12345", 1000, "myconfig", true);
+assertEquals("127.0.0.1", addr.getAddress().getHostAddress());
+assertEquals(12345, addr.getPort());
+
+//
+
+addr = NetUtils.createSocketAddr(
+"127.0.0.1", 1000, "myconfig", true);
+assertEquals("127.0.0.1", addr.getAddress().getHostAddress());
+assertEquals(1000, addr.getPort());
+
+addr = NetUtils.createSocketAddr(
+"127.0.0.1", 1000, "myconfig", true);
+assertEquals("127.0.0.1", addr.getAddress().getHostAddress());
+assertEquals(1000, addr.getPort());
+
+//
+
+try {
+ addr = NetUtils.createSocketAddr(
Review comment:
nit: `addr` seems useless? no need to assign to `addr` anymore?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17232) Erasure Coding: Typo in document
[ https://issues.apache.org/jira/browse/HADOOP-17232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185829#comment-17185829 ] Ayush Saxena commented on HADOOP-17232: --- +1 > Erasure Coding: Typo in document > > > Key: HADOOP-17232 > URL: https://issues.apache.org/jira/browse/HADOOP-17232 > Project: Hadoop Common > Issue Type: Improvement > Components: documentation >Affects Versions: 3.3.0 >Reporter: Fei Hui >Assignee: Fei Hui >Priority: Trivial > Attachments: HADOOP-17232.001.patch > > > When review ec document and code, find the typo. > Change "a erasure code" to "an erasure code" -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-17232) Erasure Coding: Typo in document
[ https://issues.apache.org/jira/browse/HADOOP-17232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fei Hui updated HADOOP-17232: - Status: Patch Available (was: Open) > Erasure Coding: Typo in document > > > Key: HADOOP-17232 > URL: https://issues.apache.org/jira/browse/HADOOP-17232 > Project: Hadoop Common > Issue Type: Improvement > Components: documentation >Affects Versions: 3.3.0 >Reporter: Fei Hui >Assignee: Fei Hui >Priority: Trivial > Attachments: HADOOP-17232.001.patch > > > When review ec document and code, find the typo. > Change "a erasure code" to "an erasure code" -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17232) Erasure Coding: Typo in document
[ https://issues.apache.org/jira/browse/HADOOP-17232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185813#comment-17185813 ] Fei Hui commented on HADOOP-17232: -- [~ayushtkn] [~weichiu] Could you please take a look? Thanks > Erasure Coding: Typo in document > > > Key: HADOOP-17232 > URL: https://issues.apache.org/jira/browse/HADOOP-17232 > Project: Hadoop Common > Issue Type: Improvement > Components: documentation >Affects Versions: 3.3.0 >Reporter: Fei Hui >Assignee: Fei Hui >Priority: Trivial > Attachments: HADOOP-17232.001.patch > > > When review ec document and code, find the typo. > Change "a erasure code" to "an erasure code" -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2241: HADOOP-17222. Create socket address combined with cache
hadoop-yetus commented on pull request #2241: URL: https://github.com/apache/hadoop/pull/2241#issuecomment-681908227 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 55s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. | ||| _ trunk Compile Tests _ | | +0 :ok: | mvndep | 3m 20s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 26m 34s | trunk passed | | +1 :green_heart: | compile | 20m 8s | trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | compile | 17m 18s | trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +1 :green_heart: | checkstyle | 2m 47s | trunk passed | | +1 :green_heart: | mvnsite | 4m 7s | trunk passed | | +1 :green_heart: | shadedclient | 21m 26s | branch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 2m 35s | trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | javadoc | 4m 4s | trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +0 :ok: | spotbugs | 2m 35s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 7m 59s | trunk passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 28s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 50s | the patch passed | | +1 :green_heart: | compile | 18m 49s | the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | javac | 18m 49s | the patch passed | | +1 :green_heart: | compile | 17m 34s | the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +1 :green_heart: | javac | 17m 34s | the patch passed | | +1 :green_heart: | checkstyle | 2m 43s | root: The patch generated 0 new + 136 unchanged - 2 fixed = 136 total (was 138) | | +1 :green_heart: | mvnsite | 3m 58s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | shadedclient | 16m 32s | patch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 2m 29s | the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | javadoc | 4m 12s | the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +1 :green_heart: | findbugs | 9m 51s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 10m 50s | hadoop-common in the patch passed. | | +1 :green_heart: | unit | 2m 31s | hadoop-hdfs-client in the patch passed. | | -1 :x: | unit | 146m 28s | hadoop-hdfs in the patch passed. | | +1 :green_heart: | asflicense | 1m 15s | The patch does not generate ASF License warnings. | | | | 353m 14s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.metrics2.source.TestJvmMetrics | | | hadoop.hdfs.TestErasureCodingPolicyWithSnapshot | | | hadoop.hdfs.TestFileChecksumCompositeCrc | | | hadoop.hdfs.TestFileChecksum | | | hadoop.hdfs.TestReconstructStripedFile | | | hadoop.hdfs.server.balancer.TestBalancerRPCDelay | | | hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader | | | hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics | | | hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes | | | hadoop.hdfs.server.namenode.ha.TestPipelinesFailover | | | hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier | | | hadoop.hdfs.server.diskbalancer.command.TestDiskBalancerCommand | | | hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/9/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/2241 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml | | uname | Linux 1629946657fc 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/h
[GitHub] [hadoop] hadoop-yetus commented on pull request #2241: HADOOP-17222. Create socket address combined with cache
hadoop-yetus commented on pull request #2241: URL: https://github.com/apache/hadoop/pull/2241#issuecomment-681879637 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. | ||| _ trunk Compile Tests _ | | +0 :ok: | mvndep | 3m 19s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 26m 15s | trunk passed | | +1 :green_heart: | compile | 19m 24s | trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | compile | 16m 48s | trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +1 :green_heart: | checkstyle | 2m 45s | trunk passed | | +1 :green_heart: | mvnsite | 4m 8s | trunk passed | | +1 :green_heart: | shadedclient | 21m 30s | branch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 2m 35s | trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | javadoc | 4m 5s | trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +0 :ok: | spotbugs | 2m 35s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 7m 55s | trunk passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 51s | the patch passed | | +1 :green_heart: | compile | 18m 47s | the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | javac | 18m 47s | the patch passed | | +1 :green_heart: | compile | 16m 49s | the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +1 :green_heart: | javac | 16m 49s | the patch passed | | +1 :green_heart: | checkstyle | 2m 46s | root: The patch generated 0 new + 136 unchanged - 2 fixed = 136 total (was 138) | | +1 :green_heart: | mvnsite | 4m 8s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | shadedclient | 14m 4s | patch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 2m 34s | the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | javadoc | 4m 9s | the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +1 :green_heart: | findbugs | 8m 20s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 9m 48s | hadoop-common in the patch passed. | | +1 :green_heart: | unit | 2m 18s | hadoop-hdfs-client in the patch passed. | | -1 :x: | unit | 96m 54s | hadoop-hdfs in the patch passed. | | +1 :green_heart: | asflicense | 1m 4s | The patch does not generate ASF License warnings. | | | | 292m 58s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hdfs.server.namenode.ha.TestHAAppend | | | hadoop.hdfs.TestFileChecksum | | | hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader | | | hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics | | | hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped | | | hadoop.hdfs.TestFileChecksumCompositeCrc | | | hadoop.hdfs.server.datanode.TestBPOfferService | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/8/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/2241 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml | | uname | Linux 382b70e7cecd 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / 2ffe00fc46a | | Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | unit | https://ci-hadoop.apache.org/
[jira] [Resolved] (HADOOP-17194) Adding Context class for AbfsClient to pass AbfsConfigurations to limit number of parameters
[ https://issues.apache.org/jira/browse/HADOOP-17194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-17194. - Fix Version/s: 3.3.1 Resolution: Fixed > Adding Context class for AbfsClient to pass AbfsConfigurations to limit > number of parameters > - > > Key: HADOOP-17194 > URL: https://issues.apache.org/jira/browse/HADOOP-17194 > Project: Hadoop Common > Issue Type: Improvement > Components: fs/azure >Affects Versions: 3.3.0 >Reporter: Mehakmeet Singh >Assignee: Mehakmeet Singh >Priority: Major > Fix For: 3.3.1 > > > To limit the growing number of parameters in AbfsClient for > AbfsConfigurations, introducing a context class to pass the > AbfsConfigurations from. > This would help in passing the AbfsConfigurations to further classes like > AbfsRestOperation and AbfsHttpOperation also. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran merged pull request #2216: HADOOP-17194. Adding Context class for AbfsClient in ABFS
steveloughran merged pull request #2216: URL: https://github.com/apache/hadoop/pull/2216 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #2216: HADOOP-17194. Adding Context class for AbfsClient in ABFS
steveloughran commented on pull request #2216: URL: https://github.com/apache/hadoop/pull/2216#issuecomment-681855909 +1, merging This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17233) Fix unit test of HDFS-13934
[
https://issues.apache.org/jira/browse/HADOOP-17233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185757#comment-17185757
]
fanrui commented on HADOOP-17233:
-
[~ayushtkn], thanks for your comment, I have closed
> Fix unit test of HDFS-13934
> ---
>
> Key: HADOOP-17233
> URL: https://issues.apache.org/jira/browse/HADOOP-17233
> Project: Hadoop Common
> Issue Type: Bug
> Components: common
>Reporter: fanrui
>Priority: Major
>
> unit test failed of
> org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest#testConcurrentUploads.
> Exception:
> {code:java}
> java.lang.IllegalArgumentExceptionjava.lang.IllegalArgumentException at
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:127) at
> org.apache.hadoop.test.LambdaTestUtils$ProportionalRetryInterval.(LambdaTestUtils.java:907)
> at
> org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest.testConcurrentUploads(AbstractContractMultipartUploaderTest.java:815){code}
> h3. Reason:
> {code:java}
> public ProportionalRetryInterval(int intervalMillis,
> int maxIntervalMillis) {
> Preconditions.checkArgument(intervalMillis > 0);
> Preconditions.checkArgument(maxIntervalMillis > 0);
> this.intervalMillis = intervalMillis;
> this.current = intervalMillis;
> this.maxIntervalMillis = maxIntervalMillis;
> }{code}
> The constructor of ProportionalRetryInterval requires maxIntervalMillis> 0.
> But TestHDFSContractMultipartUploader does not override the
> timeToBecomeConsistentMillis method, so maxIntervalMillis = 0
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2251: HDFS-15542. Add identified snapshot corruption tests for ordered snapshot deletion
hadoop-yetus commented on pull request #2251: URL: https://github.com/apache/hadoop/pull/2251#issuecomment-681849593 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 29m 2s | trunk passed | | +1 :green_heart: | compile | 1m 20s | trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | compile | 1m 14s | trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +1 :green_heart: | checkstyle | 0m 49s | trunk passed | | +1 :green_heart: | mvnsite | 1m 25s | trunk passed | | +1 :green_heart: | shadedclient | 16m 32s | branch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 0m 53s | trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | javadoc | 1m 24s | trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +0 :ok: | spotbugs | 3m 1s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 2m 59s | trunk passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 1m 8s | the patch passed | | +1 :green_heart: | compile | 1m 9s | the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | javac | 1m 9s | the patch passed | | +1 :green_heart: | compile | 1m 5s | the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +1 :green_heart: | javac | 1m 5s | the patch passed | | -0 :warning: | checkstyle | 0m 39s | hadoop-hdfs-project/hadoop-hdfs: The patch generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0) | | +1 :green_heart: | mvnsite | 1m 10s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedclient | 13m 38s | patch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 0m 46s | the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | javadoc | 1m 24s | the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +1 :green_heart: | findbugs | 3m 2s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 96m 2s | hadoop-hdfs in the patch passed. | | +1 :green_heart: | asflicense | 0m 40s | The patch does not generate ASF License warnings. | | | | 178m 51s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hdfs.server.namenode.ha.TestBootstrapAliasmap | | | hadoop.hdfs.server.datanode.TestBPOfferService | | | hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks | | | hadoop.hdfs.TestFileChecksumCompositeCrc | | | hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped | | | hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader | | | hadoop.hdfs.TestFileChecksum | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2251/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/2251 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux f0018197eeeb 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / d8aaa8c3380 | | Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | checkstyle | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2251/1/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt | | unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2251/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2251/1/testReport/ | | Max. process+thread count |
[jira] [Resolved] (HADOOP-17233) Fix unit test of HDFS-13934
[
https://issues.apache.org/jira/browse/HADOOP-17233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
fanrui resolved HADOOP-17233.
-
Resolution: Duplicate
> Fix unit test of HDFS-13934
> ---
>
> Key: HADOOP-17233
> URL: https://issues.apache.org/jira/browse/HADOOP-17233
> Project: Hadoop Common
> Issue Type: Bug
> Components: common
>Reporter: fanrui
>Priority: Major
>
> unit test failed of
> org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest#testConcurrentUploads.
> Exception:
> {code:java}
> java.lang.IllegalArgumentExceptionjava.lang.IllegalArgumentException at
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:127) at
> org.apache.hadoop.test.LambdaTestUtils$ProportionalRetryInterval.(LambdaTestUtils.java:907)
> at
> org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest.testConcurrentUploads(AbstractContractMultipartUploaderTest.java:815){code}
> h3. Reason:
> {code:java}
> public ProportionalRetryInterval(int intervalMillis,
> int maxIntervalMillis) {
> Preconditions.checkArgument(intervalMillis > 0);
> Preconditions.checkArgument(maxIntervalMillis > 0);
> this.intervalMillis = intervalMillis;
> this.current = intervalMillis;
> this.maxIntervalMillis = maxIntervalMillis;
> }{code}
> The constructor of ProportionalRetryInterval requires maxIntervalMillis> 0.
> But TestHDFSContractMultipartUploader does not override the
> timeToBecomeConsistentMillis method, so maxIntervalMillis = 0
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Assigned] (HADOOP-17233) Fix unit test of HDFS-13934
[
https://issues.apache.org/jira/browse/HADOOP-17233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
fanrui reassigned HADOOP-17233:
---
Assignee: (was: fanrui)
> Fix unit test of HDFS-13934
> ---
>
> Key: HADOOP-17233
> URL: https://issues.apache.org/jira/browse/HADOOP-17233
> Project: Hadoop Common
> Issue Type: Bug
> Components: common
>Reporter: fanrui
>Priority: Major
>
> unit test failed of
> org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest#testConcurrentUploads.
> Exception:
> {code:java}
> java.lang.IllegalArgumentExceptionjava.lang.IllegalArgumentException at
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:127) at
> org.apache.hadoop.test.LambdaTestUtils$ProportionalRetryInterval.(LambdaTestUtils.java:907)
> at
> org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest.testConcurrentUploads(AbstractContractMultipartUploaderTest.java:815){code}
> h3. Reason:
> {code:java}
> public ProportionalRetryInterval(int intervalMillis,
> int maxIntervalMillis) {
> Preconditions.checkArgument(intervalMillis > 0);
> Preconditions.checkArgument(maxIntervalMillis > 0);
> this.intervalMillis = intervalMillis;
> this.current = intervalMillis;
> this.maxIntervalMillis = maxIntervalMillis;
> }{code}
> The constructor of ProportionalRetryInterval requires maxIntervalMillis> 0.
> But TestHDFSContractMultipartUploader does not override the
> timeToBecomeConsistentMillis method, so maxIntervalMillis = 0
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HADOOP-17233) Fix unit test of HDFS-13934
[
https://issues.apache.org/jira/browse/HADOOP-17233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185748#comment-17185748
]
Ayush Saxena edited comment on HADOOP-17233 at 8/27/20, 9:51 AM:
-
Dupes. HDFS-15471?
if so, discussion there are HDFS-13934. Can close this and follow there
was (Author: ayushtkn):
Dupes. HDFS-15471
> Fix unit test of HDFS-13934
> ---
>
> Key: HADOOP-17233
> URL: https://issues.apache.org/jira/browse/HADOOP-17233
> Project: Hadoop Common
> Issue Type: Bug
> Components: common
>Reporter: fanrui
>Assignee: fanrui
>Priority: Major
>
> unit test failed of
> org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest#testConcurrentUploads.
> Exception:
> {code:java}
> java.lang.IllegalArgumentExceptionjava.lang.IllegalArgumentException at
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:127) at
> org.apache.hadoop.test.LambdaTestUtils$ProportionalRetryInterval.(LambdaTestUtils.java:907)
> at
> org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest.testConcurrentUploads(AbstractContractMultipartUploaderTest.java:815){code}
> h3. Reason:
> {code:java}
> public ProportionalRetryInterval(int intervalMillis,
> int maxIntervalMillis) {
> Preconditions.checkArgument(intervalMillis > 0);
> Preconditions.checkArgument(maxIntervalMillis > 0);
> this.intervalMillis = intervalMillis;
> this.current = intervalMillis;
> this.maxIntervalMillis = maxIntervalMillis;
> }{code}
> The constructor of ProportionalRetryInterval requires maxIntervalMillis> 0.
> But TestHDFSContractMultipartUploader does not override the
> timeToBecomeConsistentMillis method, so maxIntervalMillis = 0
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17233) Fix unit test of HDFS-13934
[
https://issues.apache.org/jira/browse/HADOOP-17233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185748#comment-17185748
]
Ayush Saxena commented on HADOOP-17233:
---
Dupes. HDFS-15471
> Fix unit test of HDFS-13934
> ---
>
> Key: HADOOP-17233
> URL: https://issues.apache.org/jira/browse/HADOOP-17233
> Project: Hadoop Common
> Issue Type: Bug
> Components: common
>Reporter: fanrui
>Assignee: fanrui
>Priority: Major
>
> unit test failed of
> org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest#testConcurrentUploads.
> Exception:
> {code:java}
> java.lang.IllegalArgumentExceptionjava.lang.IllegalArgumentException at
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:127) at
> org.apache.hadoop.test.LambdaTestUtils$ProportionalRetryInterval.(LambdaTestUtils.java:907)
> at
> org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest.testConcurrentUploads(AbstractContractMultipartUploaderTest.java:815){code}
> h3. Reason:
> {code:java}
> public ProportionalRetryInterval(int intervalMillis,
> int maxIntervalMillis) {
> Preconditions.checkArgument(intervalMillis > 0);
> Preconditions.checkArgument(maxIntervalMillis > 0);
> this.intervalMillis = intervalMillis;
> this.current = intervalMillis;
> this.maxIntervalMillis = maxIntervalMillis;
> }{code}
> The constructor of ProportionalRetryInterval requires maxIntervalMillis> 0.
> But TestHDFSContractMultipartUploader does not override the
> timeToBecomeConsistentMillis method, so maxIntervalMillis = 0
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Created] (HADOOP-17233) Fix unit tes of HDFS-13934
fanrui created HADOOP-17233:
---
Summary: Fix unit tes of HDFS-13934
Key: HADOOP-17233
URL: https://issues.apache.org/jira/browse/HADOOP-17233
Project: Hadoop Common
Issue Type: Bug
Components: common
Reporter: fanrui
Assignee: fanrui
unit test failed of
org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest#testConcurrentUploads.
Exception:
{code:java}
java.lang.IllegalArgumentExceptionjava.lang.IllegalArgumentException at
com.google.common.base.Preconditions.checkArgument(Preconditions.java:127) at
org.apache.hadoop.test.LambdaTestUtils$ProportionalRetryInterval.(LambdaTestUtils.java:907)
at
org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest.testConcurrentUploads(AbstractContractMultipartUploaderTest.java:815){code}
h3. Reason:
{code:java}
public ProportionalRetryInterval(int intervalMillis,
int maxIntervalMillis) {
Preconditions.checkArgument(intervalMillis > 0);
Preconditions.checkArgument(maxIntervalMillis > 0);
this.intervalMillis = intervalMillis;
this.current = intervalMillis;
this.maxIntervalMillis = maxIntervalMillis;
}{code}
The constructor of ProportionalRetryInterval requires maxIntervalMillis> 0. But
TestHDFSContractMultipartUploader does not override the
timeToBecomeConsistentMillis method, so maxIntervalMillis = 0
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-17233) Fix unit test of HDFS-13934
[
https://issues.apache.org/jira/browse/HADOOP-17233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
fanrui updated HADOOP-17233:
Summary: Fix unit test of HDFS-13934 (was: Fix unit tes of HDFS-13934)
> Fix unit test of HDFS-13934
> ---
>
> Key: HADOOP-17233
> URL: https://issues.apache.org/jira/browse/HADOOP-17233
> Project: Hadoop Common
> Issue Type: Bug
> Components: common
>Reporter: fanrui
>Assignee: fanrui
>Priority: Major
>
> unit test failed of
> org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest#testConcurrentUploads.
> Exception:
> {code:java}
> java.lang.IllegalArgumentExceptionjava.lang.IllegalArgumentException at
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:127) at
> org.apache.hadoop.test.LambdaTestUtils$ProportionalRetryInterval.(LambdaTestUtils.java:907)
> at
> org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest.testConcurrentUploads(AbstractContractMultipartUploaderTest.java:815){code}
> h3. Reason:
> {code:java}
> public ProportionalRetryInterval(int intervalMillis,
> int maxIntervalMillis) {
> Preconditions.checkArgument(intervalMillis > 0);
> Preconditions.checkArgument(maxIntervalMillis > 0);
> this.intervalMillis = intervalMillis;
> this.current = intervalMillis;
> this.maxIntervalMillis = maxIntervalMillis;
> }{code}
> The constructor of ProportionalRetryInterval requires maxIntervalMillis> 0.
> But TestHDFSContractMultipartUploader does not override the
> timeToBecomeConsistentMillis method, so maxIntervalMillis = 0
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] bshashikant merged pull request #2233: HDFS-15500. In-order deletion of snapshots: Diff lists must be update only in the last snapshot
bshashikant merged pull request #2233: URL: https://github.com/apache/hadoop/pull/2233 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2241: HADOOP-17222. Create socket address combined with cache
hadoop-yetus commented on pull request #2241: URL: https://github.com/apache/hadoop/pull/2241#issuecomment-681796610 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. | ||| _ trunk Compile Tests _ | | +0 :ok: | mvndep | 3m 24s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 27m 14s | trunk passed | | +1 :green_heart: | compile | 20m 54s | trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | compile | 19m 26s | trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +1 :green_heart: | checkstyle | 3m 31s | trunk passed | | +1 :green_heart: | mvnsite | 4m 22s | trunk passed | | +1 :green_heart: | shadedclient | 25m 12s | branch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 2m 39s | trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | javadoc | 4m 32s | trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +0 :ok: | spotbugs | 3m 7s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 9m 19s | trunk passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 29s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 12s | the patch passed | | +1 :green_heart: | compile | 23m 4s | the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | javac | 23m 4s | the patch passed | | +1 :green_heart: | compile | 20m 47s | the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +1 :green_heart: | javac | 20m 47s | the patch passed | | +1 :green_heart: | checkstyle | 3m 18s | root: The patch generated 0 new + 136 unchanged - 2 fixed = 136 total (was 138) | | +1 :green_heart: | mvnsite | 4m 10s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | shadedclient | 14m 7s | patch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 2m 33s | the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | javadoc | 3m 58s | the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +1 :green_heart: | findbugs | 8m 21s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 9m 20s | hadoop-common in the patch passed. | | +1 :green_heart: | unit | 2m 21s | hadoop-hdfs-client in the patch passed. | | -1 :x: | unit | 94m 38s | hadoop-hdfs in the patch passed. | | +1 :green_heart: | asflicense | 1m 7s | The patch does not generate ASF License warnings. | | | | 310m 38s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hdfs.TestFileChecksumCompositeCrc | | | hadoop.hdfs.server.namenode.ha.TestHAAppend | | | hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped | | | hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader | | | hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier | | | hadoop.hdfs.TestFileChecksum | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/7/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/2241 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml | | uname | Linux 246df61e9427 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / ca8e7a77256 | | Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/7/artifact/out/patch-uni
[GitHub] [hadoop] iwasakims commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec
iwasakims commented on pull request #2201: URL: https://github.com/apache/hadoop/pull/2201#issuecomment-681687572 Removing the snappy related code from hadoop-mapreduce-client-nativetask breaks existing deployment using the feature? Since imcompatible change is hard to get consensus and takes time to come in, how about fixing only hadoop-common first and keeping hadoop-mapreduce-client-nativetask as is here? BUILDING.txt should refer snappy-dev(el) as optional dependency only used for hadoop-mapreduce-client-nativetask in that case. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] iwasakims commented on pull request #2201: HADOOP-17125. Using snappy-java in SnappyCodec
iwasakims commented on pull request #2201: URL: https://github.com/apache/hadoop/pull/2201#issuecomment-681685716 Thanks for working on this, @dbtsai. Then patch breaks build if snappy(-devel) is installed on the env. hadoop-common-project/hadoop-common/src/CMakeLists.txt must be updated to address this. ``` [WARNING] CMake Error at /srcs/hadoop/hadoop-common-project/hadoop-common/HadoopCommon.cmake:60 (add_library): [WARNING] Cannot find source file: [WARNING] [WARNING] main/native/src/org/apache/hadoop/io/compress/snappy/SnappyCompressor.c ... [ERROR] Failed to execute goal org.apache.hadoop:hadoop-maven-plugins:3.4.0-SNAPSHOT:cmake-compile (cmake-compile) on project hadoop-common: CMake failed with error code 1 -> [Help 1] ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17232) Erasure Coding: Typo in document
[ https://issues.apache.org/jira/browse/HADOOP-17232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185672#comment-17185672 ] Fei Hui commented on HADOOP-17232: -- Upload the small fix. > Erasure Coding: Typo in document > > > Key: HADOOP-17232 > URL: https://issues.apache.org/jira/browse/HADOOP-17232 > Project: Hadoop Common > Issue Type: Improvement > Components: documentation >Affects Versions: 3.3.0 >Reporter: Fei Hui >Assignee: Fei Hui >Priority: Trivial > Attachments: HADOOP-17232.001.patch > > > When review ec document and code, find the typo. > Change "a erasure code" to "an erasure code" -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-17232) Erasure Coding: Typo in document
[ https://issues.apache.org/jira/browse/HADOOP-17232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fei Hui updated HADOOP-17232: - Attachment: HADOOP-17232.001.patch > Erasure Coding: Typo in document > > > Key: HADOOP-17232 > URL: https://issues.apache.org/jira/browse/HADOOP-17232 > Project: Hadoop Common > Issue Type: Improvement > Components: documentation >Affects Versions: 3.3.0 >Reporter: Fei Hui >Assignee: Fei Hui >Priority: Trivial > Attachments: HADOOP-17232.001.patch > > > When review ec document and code, find the typo. > Change "a erasure code" to "an erasure code" -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-17232) Erasure Coding: Typo in document
[ https://issues.apache.org/jira/browse/HADOOP-17232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fei Hui updated HADOOP-17232: - Environment: (was: When review ec document and code, find the typo. Change "a erasure code" to "an erasure code") > Erasure Coding: Typo in document > > > Key: HADOOP-17232 > URL: https://issues.apache.org/jira/browse/HADOOP-17232 > Project: Hadoop Common > Issue Type: Improvement > Components: documentation >Affects Versions: 3.3.0 >Reporter: Fei Hui >Assignee: Fei Hui >Priority: Trivial > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-17232) Erasure Coding: Typo in document
[ https://issues.apache.org/jira/browse/HADOOP-17232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fei Hui updated HADOOP-17232: - Description: When review ec document and code, find the typo. Change "a erasure code" to "an erasure code" > Erasure Coding: Typo in document > > > Key: HADOOP-17232 > URL: https://issues.apache.org/jira/browse/HADOOP-17232 > Project: Hadoop Common > Issue Type: Improvement > Components: documentation >Affects Versions: 3.3.0 >Reporter: Fei Hui >Assignee: Fei Hui >Priority: Trivial > > When review ec document and code, find the typo. > Change "a erasure code" to "an erasure code" -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Created] (HADOOP-17232) Erasure Coding: Typo in document
Fei Hui created HADOOP-17232: Summary: Erasure Coding: Typo in document Key: HADOOP-17232 URL: https://issues.apache.org/jira/browse/HADOOP-17232 Project: Hadoop Common Issue Type: Improvement Components: documentation Affects Versions: 3.3.0 Environment: When review ec document and code, find the typo. Change "a erasure code" to "an erasure code" Reporter: Fei Hui Assignee: Fei Hui -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17229) Test failure as failed request body counted in byte received metric - ITestAbfsNetworkStatistics#testAbfsHttpResponseStatistics
[
https://issues.apache.org/jira/browse/HADOOP-17229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185666#comment-17185666
]
Sneha Vijayarajan commented on HADOOP-17229:
[~mehakmeetSingh] - the scenario mentioned in the description can reproduce
this.
# Create 0 byte file
# Create with overwrite = false on same path. This request will fail.
The second step will end up adding bytes received from the error response body.
> Test failure as failed request body counted in byte received metric -
> ITestAbfsNetworkStatistics#testAbfsHttpResponseStatistics
> ---
>
> Key: HADOOP-17229
> URL: https://issues.apache.org/jira/browse/HADOOP-17229
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/azure, test
>Affects Versions: 3.3.0
>Reporter: Sneha Vijayarajan
>Assignee: Mehakmeet Singh
>Priority: Major
> Labels: abfsactive
>
> Bytes received counter increments for every request response received.
> [https://github.com/apache/hadoop/blob/d23cc9d85d887f01d72180bdf1af87dfdee15c5a/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java#L251]
> This increments even for failed requests.
> Observed during testing done for HADOOP-17215. A request failed with 409
> Conflict contains response body as below:
> {"error":\{"code":"PathAlreadyExists","message":"The specified path already
> exists.\nRequestId:c3b2c55c-b01f-0061-7b31-7b6ee300\nTime:2020-08-25T22:44:07.2356054Z"}}
> The error body of 168 size is incremented in bytes_received counter.
> This also breaks the testcase testAbfsHttpResponseStatistics.
> {code:java}
> [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 22.746 s <<< FAILURE! - in
> org.apache.hadoop.fs.azurebfs.ITestAbfsNetworkStatistics[ERROR] Tests run: 2,
> Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 22.746 s <<< FAILURE! - in
> org.apache.hadoop.fs.azurebfs.ITestAbfsNetworkStatistics[ERROR]
> testAbfsHttpResponseStatistics(org.apache.hadoop.fs.azurebfs.ITestAbfsNetworkStatistics)
> Time elapsed: 13.183 s <<< FAILURE!java.lang.AssertionError: Mismatch in
> bytes_received expected:<143> but was:<311> at
> org.junit.Assert.fail(Assert.java:88) at
> org.junit.Assert.failNotEquals(Assert.java:834) at
> org.junit.Assert.assertEquals(Assert.java:645) at
> org.apache.hadoop.fs.azurebfs.AbstractAbfsIntegrationTest.assertAbfsStatistics(AbstractAbfsIntegrationTest.java:445)
> at
> org.apache.hadoop.fs.azurebfs.ITestAbfsNetworkStatistics.testAbfsHttpResponseStatistics(ITestAbfsNetworkStatistics.java:291)
> {code}
> [~mehakmeetSingh] - is the bytes_received counter increment for failed
> requests an expected behaviour ?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] Amithsha closed pull request #1562: HDFS-14546-Block Placement Policy Doc
Amithsha closed pull request #1562: URL: https://github.com/apache/hadoop/pull/1562 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
