[GitHub] [hadoop] adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests
adoroszlai commented on a change in pull request #1341: HDDS-2022. Add
additional freon tests
URL: https://github.com/apache/hadoop/pull/1341#discussion_r318998112
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/SameKeyReader.java
##
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package org.apache.hadoop.ozone.freon;
+
+import java.io.InputStream;
+import java.security.MessageDigest;
+import java.util.concurrent.Callable;
+
+import org.apache.hadoop.hdds.cli.HddsVersionProvider;
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+import org.apache.hadoop.ozone.client.OzoneBucket;
+import org.apache.hadoop.ozone.client.OzoneClient;
+import org.apache.hadoop.ozone.client.OzoneClientFactory;
+
+import com.codahale.metrics.Timer;
+import org.apache.commons.io.IOUtils;
+import picocli.CommandLine.Command;
+import picocli.CommandLine.Option;
+
+/**
+ * Data generator tool test om performance.
+ */
+@Command(name = "ocokr",
+aliases = "ozone-client-one-key-reader",
+description = "Read the same key from multiple threads.",
+versionProvider = HddsVersionProvider.class,
+mixinStandardHelpOptions = true,
+showDefaultValues = true)
+public class SameKeyReader extends BaseFreonGenerator
+implements Callable {
+
+ @Option(names = {"-v", "--volume"},
+ description = "Name of the bucket which contains the test data. Will be"
+ + " created if missing.",
+ defaultValue = "vol1")
+ private String volumeName;
+
+ @Option(names = {"-b", "--bucket"},
+ description = "Name of the bucket which contains the test data. Will be"
+ + " created if missing.",
+ defaultValue = "bucket1")
+ private String bucketName;
+
+ @Option(names = {"-k", "--key"},
+ description = "Name of the key read from multiple threads",
+ defaultValue = "bucket1")
Review comment:
This test needs an existing key to read. I'm not sure first-time users
would create a key named `bucket1`.
If we assume the most frequent usage will be validating one of the keys
created by `ockg`, then it could default to `/0`, but we'd need some
specific prefix for that. Alternatively, we could pick some existing key from
the given volume/bucket, which works with random prefix, too.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests
adoroszlai commented on a change in pull request #1341: HDDS-2022. Add
additional freon tests
URL: https://github.com/apache/hadoop/pull/1341#discussion_r317673438
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/BaseFreonGenerator.java
##
@@ -0,0 +1,329 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package org.apache.hadoop.ozone.freon;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.InetSocketAddress;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+import org.apache.hadoop.ipc.Client;
+import org.apache.hadoop.ipc.ProtobufRpcEngine;
+import org.apache.hadoop.ipc.RPC;
+import org.apache.hadoop.net.NetUtils;
+import org.apache.hadoop.ozone.OmUtils;
+import org.apache.hadoop.ozone.client.OzoneClient;
+import org.apache.hadoop.ozone.client.OzoneClientFactory;
+import org.apache.hadoop.ozone.client.OzoneVolume;
+import org.apache.hadoop.ozone.om.exceptions.OMException;
+import org.apache.hadoop.ozone.om.exceptions.OMException.ResultCodes;
+import
org.apache.hadoop.ozone.om.protocolPB.OzoneManagerProtocolClientSideTranslatorPB;
+import org.apache.hadoop.ozone.om.protocolPB.OzoneManagerProtocolPB;
+import org.apache.hadoop.security.UserGroupInformation;
+
+import com.codahale.metrics.ConsoleReporter;
+import com.codahale.metrics.MetricRegistry;
+import org.apache.commons.codec.digest.DigestUtils;
+import org.apache.commons.lang3.RandomStringUtils;
+import org.apache.ratis.protocol.ClientId;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import picocli.CommandLine.Option;
+import picocli.CommandLine.ParentCommand;
+
+/**
+ * Base class for simplified performance tests.
+ */
+public class BaseFreonGenerator {
+
+ private static final Logger LOG =
+ LoggerFactory.getLogger(BaseFreonGenerator.class);
+
+ private static final int CHECK_INTERVAL_MILLIS = 1000;
+
+ private static final String DIGEST_ALGORITHM = "MD5";
+
+ private static final Pattern ENV_VARIABLE_IN_PATTERN =
+ Pattern.compile("__(.+?)__");
+
+ @ParentCommand
+ private Freon freonCommand;
+
+ @Option(names = {"-n", "--number-of-tests"},
+ description = "Number of the generated objects.",
+ defaultValue = "1000")
+ private long testNo = 1000;
+
+ @Option(names = {"-t", "--threads", "--thread"},
+ description = "Number of threads used to execute",
+ defaultValue = "10")
+ private int threadNo;
+
+ @Option(names = {"-f", "--fail-at-end"},
+ description = "If turned on, all the tasks will be executed even if "
+ + "there are failures.")
+ private boolean failAtEnd;
+
+ @Option(names = {"-p", "--prefix"},
+ description = "Unique identifier of the test execution. Usually used as"
+ + " a prefix of the generated object names. If empty, a random name"
+ + " will be generated",
+ defaultValue = "")
+ private String prefix = "";
+
+ private MetricRegistry metrics = new MetricRegistry();
+
+ private ExecutorService executor;
+
+ private AtomicLong successCounter;
+
+ private AtomicLong failureCounter;
+
+ private long startTime;
+
+ private PathSchema pathSchema;
+
+ /**
+ * The main logic to execute a test generator.
+ *
+ * @param provider creates the new steps to execute.
+ */
+ public void runTests(TaskProvider provider) {
+
+executor = Executors.newFixedThreadPool(threadNo);
+
+ProgressBar progressBar =
+new ProgressBar(System.out, testNo, successCounter::get);
+progressBar.start();
+
+startTime = System.currentTimeMillis();
+//schedule the execution of all the tasks.
+
+for (long i = 0; i < testNo; i++) {
+
+ final long counter = i;
+
+ executor.execute(() -> {
+try {
+
+ //in case of an other failed test, we shouldn't execute more tasks.
+ if (!failAtEnd && failureCounter.get() > 0) {
+return;
+ }
+
+ provider.executeNextTask(counter);
+ successCou
[GitHub] [hadoop] adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests
adoroszlai commented on a change in pull request #1341: HDDS-2022. Add
additional freon tests
URL: https://github.com/apache/hadoop/pull/1341#discussion_r317672618
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/BaseFreonGenerator.java
##
@@ -0,0 +1,329 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package org.apache.hadoop.ozone.freon;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.InetSocketAddress;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+import org.apache.hadoop.ipc.Client;
+import org.apache.hadoop.ipc.ProtobufRpcEngine;
+import org.apache.hadoop.ipc.RPC;
+import org.apache.hadoop.net.NetUtils;
+import org.apache.hadoop.ozone.OmUtils;
+import org.apache.hadoop.ozone.client.OzoneClient;
+import org.apache.hadoop.ozone.client.OzoneClientFactory;
+import org.apache.hadoop.ozone.client.OzoneVolume;
+import org.apache.hadoop.ozone.om.exceptions.OMException;
+import org.apache.hadoop.ozone.om.exceptions.OMException.ResultCodes;
+import
org.apache.hadoop.ozone.om.protocolPB.OzoneManagerProtocolClientSideTranslatorPB;
+import org.apache.hadoop.ozone.om.protocolPB.OzoneManagerProtocolPB;
+import org.apache.hadoop.security.UserGroupInformation;
+
+import com.codahale.metrics.ConsoleReporter;
+import com.codahale.metrics.MetricRegistry;
+import org.apache.commons.codec.digest.DigestUtils;
+import org.apache.commons.lang3.RandomStringUtils;
+import org.apache.ratis.protocol.ClientId;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import picocli.CommandLine.Option;
+import picocli.CommandLine.ParentCommand;
+
+/**
+ * Base class for simplified performance tests.
+ */
+public class BaseFreonGenerator {
+
+ private static final Logger LOG =
+ LoggerFactory.getLogger(BaseFreonGenerator.class);
+
+ private static final int CHECK_INTERVAL_MILLIS = 1000;
+
+ private static final String DIGEST_ALGORITHM = "MD5";
+
+ private static final Pattern ENV_VARIABLE_IN_PATTERN =
+ Pattern.compile("__(.+?)__");
+
+ @ParentCommand
+ private Freon freonCommand;
+
+ @Option(names = {"-n", "--number-of-tests"},
+ description = "Number of the generated objects.",
+ defaultValue = "1000")
+ private long testNo = 1000;
+
+ @Option(names = {"-t", "--threads", "--thread"},
+ description = "Number of threads used to execute",
+ defaultValue = "10")
+ private int threadNo;
+
+ @Option(names = {"-f", "--fail-at-end"},
+ description = "If turned on, all the tasks will be executed even if "
+ + "there are failures.")
+ private boolean failAtEnd;
+
+ @Option(names = {"-p", "--prefix"},
+ description = "Unique identifier of the test execution. Usually used as"
+ + " a prefix of the generated object names. If empty, a random name"
+ + " will be generated",
+ defaultValue = "")
+ private String prefix = "";
+
+ private MetricRegistry metrics = new MetricRegistry();
+
+ private ExecutorService executor;
+
+ private AtomicLong successCounter;
+
+ private AtomicLong failureCounter;
+
+ private long startTime;
+
+ private PathSchema pathSchema;
+
+ /**
+ * The main logic to execute a test generator.
+ *
+ * @param provider creates the new steps to execute.
+ */
+ public void runTests(TaskProvider provider) {
+
+executor = Executors.newFixedThreadPool(threadNo);
+
+ProgressBar progressBar =
+new ProgressBar(System.out, testNo, successCounter::get);
+progressBar.start();
+
+startTime = System.currentTimeMillis();
+//schedule the execution of all the tasks.
+
+for (long i = 0; i < testNo; i++) {
+
+ final long counter = i;
+
+ executor.execute(() -> {
+try {
+
+ //in case of an other failed test, we shouldn't execute more tasks.
+ if (!failAtEnd && failureCounter.get() > 0) {
+return;
+ }
+
+ provider.executeNextTask(counter);
+ successCou
[GitHub] [hadoop] adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests
adoroszlai commented on a change in pull request #1341: HDDS-2022. Add
additional freon tests
URL: https://github.com/apache/hadoop/pull/1341#discussion_r317563960
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/SameKeyReader.java
##
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package org.apache.hadoop.ozone.freon;
+
+import java.io.InputStream;
+import java.security.MessageDigest;
+import java.util.concurrent.Callable;
+
+import org.apache.hadoop.hdds.cli.HddsVersionProvider;
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+import org.apache.hadoop.ozone.client.OzoneBucket;
+import org.apache.hadoop.ozone.client.OzoneClient;
+import org.apache.hadoop.ozone.client.OzoneClientFactory;
+
+import com.codahale.metrics.Timer;
+import org.apache.commons.io.IOUtils;
+import picocli.CommandLine.Command;
+import picocli.CommandLine.Option;
+
+/**
+ * Data generator tool test om performance.
+ */
+@Command(name = "ocokr",
+aliases = "ozone-client-one-key-reader",
+description = "Read the same key from multiple threads.",
+versionProvider = HddsVersionProvider.class,
+mixinStandardHelpOptions = true,
+showDefaultValues = true)
+public class SameKeyReader extends BaseFreonGenerator
+implements Callable {
+
+ @Option(names = {"-v", "--volume"},
+ description = "Name of the bucket which contains the test data. Will be"
+ + " created if missing.",
+ defaultValue = "vol1")
+ private String volumeName;
+
+ @Option(names = {"-b", "--bucket"},
+ description = "Name of the bucket which contains the test data. Will be"
+ + " created if missing.",
+ defaultValue = "bucket1")
+ private String bucketName;
+
+ @Option(names = {"-k", "--key"},
+ description = "Name of the key read from multiple threads",
+ defaultValue = "bucket1")
+ private String keyName;
+
+ private Timer timer;
+
+ private OzoneBucket bucket;
+
+ private ContentGenerator contentGenerator;
+
+ private byte[] referenceDigest;
+
+ private OzoneClient rpcClient;
+
+ @Override
+ public Void call() throws Exception {
+
+init();
+
+OzoneConfiguration ozoneConfiguration = createOzoneConfiguration();
+
+rpcClient = OzoneClientFactory.getRpcClient(ozoneConfiguration);
+
+try (InputStream stream = rpcClient.getObjectStore().getVolume(volumeName)
+.getBucket(bucketName).readKey(keyName)) {
+ referenceDigest = getDigest(stream);
+}
+
+timer = getMetrics().timer("key-create");
Review comment:
```suggestion
timer = getMetrics().timer("key-validate");
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests
adoroszlai commented on a change in pull request #1341: HDDS-2022. Add
additional freon tests
URL: https://github.com/apache/hadoop/pull/1341#discussion_r317652114
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/HadoopFsValidator.java
##
@@ -0,0 +1,100 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package org.apache.hadoop.ozone.freon;
+
+import java.net.URI;
+import java.security.MessageDigest;
+import java.util.concurrent.Callable;
+
+import org.apache.hadoop.fs.FSDataInputStream;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hdds.cli.HddsVersionProvider;
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+
+import com.codahale.metrics.Timer;
+import org.apache.commons.io.IOUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import picocli.CommandLine.Command;
+import picocli.CommandLine.Option;
+
+/**
+ * Data generator tool test om performance.
+ */
+@Command(name = "dfsv",
+aliases = "dfs-file-validator",
+description = "Validate if the generated files have the same hash.",
+versionProvider = HddsVersionProvider.class,
+mixinStandardHelpOptions = true,
+showDefaultValues = true)
+public class HadoopFsValidator extends BaseFreonGenerator
+implements Callable {
+
+ private static final Logger LOG =
+ LoggerFactory.getLogger(HadoopFsValidator.class);
+
+ @Option(names = {"--path"},
+ description = "Hadoop FS file system path",
+ defaultValue = "o3fs://bucket1.vol1")
+ private String rootPath;
+
+ private ContentGenerator contentGenerator;
+
+ private Timer timer;
+
+ private FileSystem fileSystem;
+
+ private byte[] referenceDigest;
+
+ @Override
+ public Void call() throws Exception {
+
+init();
+
+OzoneConfiguration configuration = createOzoneConfiguration();
+
+fileSystem = FileSystem.get(URI.create(rootPath), configuration);
+
+Path file = new Path(rootPath + "/" + generateObjectName(0));
+try (FSDataInputStream stream = fileSystem.open(file)) {
+ referenceDigest = getDigest(stream);
+}
+
+timer = getMetrics().timer("gile-read");
Review comment:
```suggestion
timer = getMetrics().timer("file-read");
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests
adoroszlai commented on a change in pull request #1341: HDDS-2022. Add
additional freon tests
URL: https://github.com/apache/hadoop/pull/1341#discussion_r317648557
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/BaseFreonGenerator.java
##
@@ -0,0 +1,329 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package org.apache.hadoop.ozone.freon;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.InetSocketAddress;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+import org.apache.hadoop.ipc.Client;
+import org.apache.hadoop.ipc.ProtobufRpcEngine;
+import org.apache.hadoop.ipc.RPC;
+import org.apache.hadoop.net.NetUtils;
+import org.apache.hadoop.ozone.OmUtils;
+import org.apache.hadoop.ozone.client.OzoneClient;
+import org.apache.hadoop.ozone.client.OzoneClientFactory;
+import org.apache.hadoop.ozone.client.OzoneVolume;
+import org.apache.hadoop.ozone.om.exceptions.OMException;
+import org.apache.hadoop.ozone.om.exceptions.OMException.ResultCodes;
+import
org.apache.hadoop.ozone.om.protocolPB.OzoneManagerProtocolClientSideTranslatorPB;
+import org.apache.hadoop.ozone.om.protocolPB.OzoneManagerProtocolPB;
+import org.apache.hadoop.security.UserGroupInformation;
+
+import com.codahale.metrics.ConsoleReporter;
+import com.codahale.metrics.MetricRegistry;
+import org.apache.commons.codec.digest.DigestUtils;
+import org.apache.commons.lang3.RandomStringUtils;
+import org.apache.ratis.protocol.ClientId;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import picocli.CommandLine.Option;
+import picocli.CommandLine.ParentCommand;
+
+/**
+ * Base class for simplified performance tests.
+ */
+public class BaseFreonGenerator {
+
+ private static final Logger LOG =
+ LoggerFactory.getLogger(BaseFreonGenerator.class);
+
+ private static final int CHECK_INTERVAL_MILLIS = 1000;
+
+ private static final String DIGEST_ALGORITHM = "MD5";
+
+ private static final Pattern ENV_VARIABLE_IN_PATTERN =
+ Pattern.compile("__(.+?)__");
+
+ @ParentCommand
+ private Freon freonCommand;
+
+ @Option(names = {"-n", "--number-of-tests"},
+ description = "Number of the generated objects.",
+ defaultValue = "1000")
+ private long testNo = 1000;
+
+ @Option(names = {"-t", "--threads", "--thread"},
+ description = "Number of threads used to execute",
+ defaultValue = "10")
+ private int threadNo;
+
+ @Option(names = {"-f", "--fail-at-end"},
+ description = "If turned on, all the tasks will be executed even if "
+ + "there are failures.")
+ private boolean failAtEnd;
+
+ @Option(names = {"-p", "--prefix"},
+ description = "Unique identifier of the test execution. Usually used as"
+ + " a prefix of the generated object names. If empty, a random name"
+ + " will be generated",
+ defaultValue = "")
+ private String prefix = "";
+
+ private MetricRegistry metrics = new MetricRegistry();
+
+ private ExecutorService executor;
+
+ private AtomicLong successCounter;
+
+ private AtomicLong failureCounter;
+
+ private long startTime;
+
+ private PathSchema pathSchema;
+
+ /**
+ * The main logic to execute a test generator.
+ *
+ * @param provider creates the new steps to execute.
+ */
+ public void runTests(TaskProvider provider) {
+
+executor = Executors.newFixedThreadPool(threadNo);
+
+ProgressBar progressBar =
+new ProgressBar(System.out, testNo, successCounter::get);
+progressBar.start();
+
+startTime = System.currentTimeMillis();
+//schedule the execution of all the tasks.
+
+for (long i = 0; i < testNo; i++) {
+
+ final long counter = i;
+
+ executor.execute(() -> {
+try {
+
+ //in case of an other failed test, we shouldn't execute more tasks.
+ if (!failAtEnd && failureCounter.get() > 0) {
+return;
+ }
+
+ provider.executeNextTask(counter);
+ successCou
[GitHub] [hadoop] adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests
adoroszlai commented on a change in pull request #1341: HDDS-2022. Add
additional freon tests
URL: https://github.com/apache/hadoop/pull/1341#discussion_r317121604
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/OzoneClientKeyValidator.java
##
@@ -0,0 +1,105 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package org.apache.hadoop.ozone.freon;
+
+import java.io.InputStream;
+import java.security.MessageDigest;
+import java.util.concurrent.Callable;
+
+import org.apache.hadoop.hdds.cli.HddsVersionProvider;
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+import org.apache.hadoop.ozone.client.OzoneBucket;
+import org.apache.hadoop.ozone.client.OzoneClient;
+import org.apache.hadoop.ozone.client.OzoneClientFactory;
+
+import com.codahale.metrics.Timer;
+import org.apache.commons.io.IOUtils;
+import picocli.CommandLine.Command;
+import picocli.CommandLine.Option;
+
+/**
+ * Data generator tool test om performance.
+ */
+@Command(name = "ockv",
+aliases = "ozone-client-key-validator",
+description = "Generate keys with the help of the ozone clients.",
+versionProvider = HddsVersionProvider.class,
+mixinStandardHelpOptions = true,
+showDefaultValues = true)
+public class OzoneClientKeyValidator extends BaseFreonGenerator
+implements Callable {
+
+ @Option(names = {"-v", "--volume"},
+ description = "Name of the bucket which contains the test data. Will be"
+ + " created if missing.",
+ defaultValue = "vol1")
+ private String volumeName;
+
+ @Option(names = {"-b", "--bucket"},
+ description = "Name of the bucket which contains the test data. Will be"
+ + " created if missing.",
+ defaultValue = "bucket1")
+ private String bucketName;
+
+ private Timer timer;
+
+ private OzoneBucket bucket;
+
+ private ContentGenerator contentGenerator;
+
+ private byte[] referenceDigest;
+
+ private OzoneClient rpcClient;
+
+ @Override
+ public Void call() throws Exception {
+
+init();
+
+OzoneConfiguration ozoneConfiguration = createOzoneConfiguration();
+
+rpcClient = OzoneClientFactory.getRpcClient(ozoneConfiguration);
+
+try (InputStream stream = rpcClient.getObjectStore().getVolume(volumeName)
+.getBucket(bucketName).readKey(generateObjectName(0))) {
+ referenceDigest = getDigest(stream);
+}
+
+timer = getMetrics().timer("key-create");
Review comment:
```suggestion
timer = getMetrics().timer("key-validate");
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests
adoroszlai commented on a change in pull request #1341: HDDS-2022. Add
additional freon tests
URL: https://github.com/apache/hadoop/pull/1341#discussion_r317121487
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/OzoneClientKeyValidator.java
##
@@ -0,0 +1,105 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package org.apache.hadoop.ozone.freon;
+
+import java.io.InputStream;
+import java.security.MessageDigest;
+import java.util.concurrent.Callable;
+
+import org.apache.hadoop.hdds.cli.HddsVersionProvider;
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+import org.apache.hadoop.ozone.client.OzoneBucket;
+import org.apache.hadoop.ozone.client.OzoneClient;
+import org.apache.hadoop.ozone.client.OzoneClientFactory;
+
+import com.codahale.metrics.Timer;
+import org.apache.commons.io.IOUtils;
+import picocli.CommandLine.Command;
+import picocli.CommandLine.Option;
+
+/**
+ * Data generator tool test om performance.
+ */
+@Command(name = "ockv",
+aliases = "ozone-client-key-validator",
+description = "Generate keys with the help of the ozone clients.",
+versionProvider = HddsVersionProvider.class,
+mixinStandardHelpOptions = true,
+showDefaultValues = true)
+public class OzoneClientKeyValidator extends BaseFreonGenerator
+implements Callable {
+
+ @Option(names = {"-v", "--volume"},
+ description = "Name of the bucket which contains the test data. Will be"
+ + " created if missing.",
Review comment:
The validator does not create missing volume/bucket (nor should it), so
`Will be created if missing.` should be removed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests
adoroszlai commented on a change in pull request #1341: HDDS-2022. Add
additional freon tests
URL: https://github.com/apache/hadoop/pull/1341#discussion_r317563795
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/SameKeyReader.java
##
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package org.apache.hadoop.ozone.freon;
+
+import java.io.InputStream;
+import java.security.MessageDigest;
+import java.util.concurrent.Callable;
+
+import org.apache.hadoop.hdds.cli.HddsVersionProvider;
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+import org.apache.hadoop.ozone.client.OzoneBucket;
+import org.apache.hadoop.ozone.client.OzoneClient;
+import org.apache.hadoop.ozone.client.OzoneClientFactory;
+
+import com.codahale.metrics.Timer;
+import org.apache.commons.io.IOUtils;
+import picocli.CommandLine.Command;
+import picocli.CommandLine.Option;
+
+/**
+ * Data generator tool test om performance.
+ */
+@Command(name = "ocokr",
+aliases = "ozone-client-one-key-reader",
+description = "Read the same key from multiple threads.",
+versionProvider = HddsVersionProvider.class,
+mixinStandardHelpOptions = true,
+showDefaultValues = true)
+public class SameKeyReader extends BaseFreonGenerator
+implements Callable {
+
+ @Option(names = {"-v", "--volume"},
+ description = "Name of the bucket which contains the test data. Will be"
+ + " created if missing.",
+ defaultValue = "vol1")
+ private String volumeName;
+
+ @Option(names = {"-b", "--bucket"},
+ description = "Name of the bucket which contains the test data. Will be"
+ + " created if missing.",
+ defaultValue = "bucket1")
+ private String bucketName;
+
+ @Option(names = {"-k", "--key"},
+ description = "Name of the key read from multiple threads",
+ defaultValue = "bucket1")
Review comment:
`bucket1` doesn't seem to be a good default value for a key. :) I think
this should default to `""`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests
adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests URL: https://github.com/apache/hadoop/pull/1341#discussion_r317092258 ## File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/OzoneClientKeyValidator.java ## @@ -0,0 +1,105 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with this + * work for additional information regarding copyright ownership. The ASF + * licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.hadoop.ozone.freon; + +import java.io.InputStream; +import java.security.MessageDigest; +import java.util.concurrent.Callable; + +import org.apache.hadoop.hdds.cli.HddsVersionProvider; +import org.apache.hadoop.hdds.conf.OzoneConfiguration; +import org.apache.hadoop.ozone.client.OzoneBucket; +import org.apache.hadoop.ozone.client.OzoneClient; +import org.apache.hadoop.ozone.client.OzoneClientFactory; + +import com.codahale.metrics.Timer; +import org.apache.commons.io.IOUtils; +import picocli.CommandLine.Command; +import picocli.CommandLine.Option; + +/** + * Data generator tool test om performance. + */ +@Command(name = "ockv", +aliases = "ozone-client-key-validator", +description = "Generate keys with the help of the ozone clients.", Review comment: ```suggestion description = "Validate keys with the help of the ozone clients.", ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests
adoroszlai commented on a change in pull request #1341: HDDS-2022. Add
additional freon tests
URL: https://github.com/apache/hadoop/pull/1341#discussion_r317095088
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/BaseFreonGenerator.java
##
@@ -0,0 +1,325 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package org.apache.hadoop.ozone.freon;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.InetSocketAddress;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+import org.apache.hadoop.ipc.Client;
+import org.apache.hadoop.ipc.ProtobufRpcEngine;
+import org.apache.hadoop.ipc.RPC;
+import org.apache.hadoop.net.NetUtils;
+import org.apache.hadoop.ozone.OmUtils;
+import org.apache.hadoop.ozone.client.OzoneClient;
+import org.apache.hadoop.ozone.client.OzoneClientFactory;
+import org.apache.hadoop.ozone.client.OzoneVolume;
+import org.apache.hadoop.ozone.om.exceptions.OMException;
+import org.apache.hadoop.ozone.om.exceptions.OMException.ResultCodes;
+import
org.apache.hadoop.ozone.om.protocolPB.OzoneManagerProtocolClientSideTranslatorPB;
+import org.apache.hadoop.ozone.om.protocolPB.OzoneManagerProtocolPB;
+import org.apache.hadoop.security.UserGroupInformation;
+
+import com.codahale.metrics.ConsoleReporter;
+import com.codahale.metrics.MetricRegistry;
+import org.apache.commons.codec.digest.DigestUtils;
+import org.apache.commons.lang3.RandomStringUtils;
+import org.apache.ratis.protocol.ClientId;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import picocli.CommandLine.Option;
+import picocli.CommandLine.ParentCommand;
+
+/**
+ * Base class for simplified performance tests.
+ */
+public class BaseFreonGenerator {
+
+ private static final Logger LOG =
+ LoggerFactory.getLogger(BaseFreonGenerator.class);
+
+ private static final int CHECK_INTERVAL_MILLIS = 1000;
+
+ private static final String DIGEST_ALGORITHM = "MD5";
+
+ private static final Pattern ENV_VARIABLE_IN_PATTERN =
+ Pattern.compile("__(.+?)__");
+
+ @ParentCommand
+ private Freon freonCommand;
+
+ @Option(names = {"-n", "--number-of-tests"},
+ description = "Number of the generated objects.",
+ defaultValue = "1000")
+ private long testNo = 1000;
+
+ @Option(names = {"-t", "--threads", "--thread"},
+ description = "Number of threads used to execute",
+ defaultValue = "10")
+ private int threadNo;
+
+ @Option(names = {"-f", "--fail-at-end"},
+ description = "If turned on, all the tasks will be executed even if "
+ + "there are failures.")
+ private boolean failAtEnd;
+
+ @Option(names = {"-p", "--prefix"},
+ description = "Unique identifier of the test execution. Usually used as"
+ + " a prefix of the generated object names. If empty, a random name"
+ + " will be generated",
+ defaultValue = "")
+ private String prefix = "";
+
+ private MetricRegistry metrics = new MetricRegistry();
+
+ private ExecutorService executor;
+
+ private AtomicLong successCounter;
+
+ private AtomicLong failureCounter;
+
+ private long startTime;
+
+ private PathSchema pathSchema;
+
+ /**
+ * The main logic to execute a test generator.
+ *
+ * @param provider creates the new steps to execute.
+ */
+ public void runTests(TaskProvider provider) {
+
+executor = Executors.newFixedThreadPool(threadNo);
+
+ProgressBar progressBar =
+new ProgressBar(System.out, testNo, successCounter::get);
+progressBar.start();
+
+startTime = System.currentTimeMillis();
+//schedule the execution of all the tasks.
+for (int i = 0; i < testNo; i++) {
+ executor.execute(() -> {
+try {
+
+ //in case of an other failed test, we shouldn't execute more tasks.
+ if (!failAtEnd && failureCounter.get() > 0) {
+return;
+ }
+
+ provider.executeNextTask(successCounter.get());
+ successCounter.incrementAndGet();
+
[GitHub] [hadoop] adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests
adoroszlai commented on a change in pull request #1341: HDDS-2022. Add
additional freon tests
URL: https://github.com/apache/hadoop/pull/1341#discussion_r317094938
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/BaseFreonGenerator.java
##
@@ -0,0 +1,325 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package org.apache.hadoop.ozone.freon;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.InetSocketAddress;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+import org.apache.hadoop.ipc.Client;
+import org.apache.hadoop.ipc.ProtobufRpcEngine;
+import org.apache.hadoop.ipc.RPC;
+import org.apache.hadoop.net.NetUtils;
+import org.apache.hadoop.ozone.OmUtils;
+import org.apache.hadoop.ozone.client.OzoneClient;
+import org.apache.hadoop.ozone.client.OzoneClientFactory;
+import org.apache.hadoop.ozone.client.OzoneVolume;
+import org.apache.hadoop.ozone.om.exceptions.OMException;
+import org.apache.hadoop.ozone.om.exceptions.OMException.ResultCodes;
+import
org.apache.hadoop.ozone.om.protocolPB.OzoneManagerProtocolClientSideTranslatorPB;
+import org.apache.hadoop.ozone.om.protocolPB.OzoneManagerProtocolPB;
+import org.apache.hadoop.security.UserGroupInformation;
+
+import com.codahale.metrics.ConsoleReporter;
+import com.codahale.metrics.MetricRegistry;
+import org.apache.commons.codec.digest.DigestUtils;
+import org.apache.commons.lang3.RandomStringUtils;
+import org.apache.ratis.protocol.ClientId;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import picocli.CommandLine.Option;
+import picocli.CommandLine.ParentCommand;
+
+/**
+ * Base class for simplified performance tests.
+ */
+public class BaseFreonGenerator {
+
+ private static final Logger LOG =
+ LoggerFactory.getLogger(BaseFreonGenerator.class);
+
+ private static final int CHECK_INTERVAL_MILLIS = 1000;
+
+ private static final String DIGEST_ALGORITHM = "MD5";
+
+ private static final Pattern ENV_VARIABLE_IN_PATTERN =
+ Pattern.compile("__(.+?)__");
+
+ @ParentCommand
+ private Freon freonCommand;
+
+ @Option(names = {"-n", "--number-of-tests"},
+ description = "Number of the generated objects.",
+ defaultValue = "1000")
+ private long testNo = 1000;
+
+ @Option(names = {"-t", "--threads", "--thread"},
+ description = "Number of threads used to execute",
+ defaultValue = "10")
+ private int threadNo;
+
+ @Option(names = {"-f", "--fail-at-end"},
+ description = "If turned on, all the tasks will be executed even if "
+ + "there are failures.")
+ private boolean failAtEnd;
+
+ @Option(names = {"-p", "--prefix"},
+ description = "Unique identifier of the test execution. Usually used as"
+ + " a prefix of the generated object names. If empty, a random name"
+ + " will be generated",
+ defaultValue = "")
+ private String prefix = "";
+
+ private MetricRegistry metrics = new MetricRegistry();
+
+ private ExecutorService executor;
+
+ private AtomicLong successCounter;
Review comment:
I think we need a separate `attemptCounter` to uniquely identify tasks and
avoid duplicate keys by multiple threads.
```suggestion
private AtomicLong successCounter;
private AtomicLong attemptCounter;
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] adoroszlai commented on a change in pull request #1341: HDDS-2022. Add additional freon tests
adoroszlai commented on a change in pull request #1341: HDDS-2022. Add
additional freon tests
URL: https://github.com/apache/hadoop/pull/1341#discussion_r317094661
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/BaseFreonGenerator.java
##
@@ -0,0 +1,325 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package org.apache.hadoop.ozone.freon;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.InetSocketAddress;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+import org.apache.hadoop.ipc.Client;
+import org.apache.hadoop.ipc.ProtobufRpcEngine;
+import org.apache.hadoop.ipc.RPC;
+import org.apache.hadoop.net.NetUtils;
+import org.apache.hadoop.ozone.OmUtils;
+import org.apache.hadoop.ozone.client.OzoneClient;
+import org.apache.hadoop.ozone.client.OzoneClientFactory;
+import org.apache.hadoop.ozone.client.OzoneVolume;
+import org.apache.hadoop.ozone.om.exceptions.OMException;
+import org.apache.hadoop.ozone.om.exceptions.OMException.ResultCodes;
+import
org.apache.hadoop.ozone.om.protocolPB.OzoneManagerProtocolClientSideTranslatorPB;
+import org.apache.hadoop.ozone.om.protocolPB.OzoneManagerProtocolPB;
+import org.apache.hadoop.security.UserGroupInformation;
+
+import com.codahale.metrics.ConsoleReporter;
+import com.codahale.metrics.MetricRegistry;
+import org.apache.commons.codec.digest.DigestUtils;
+import org.apache.commons.lang3.RandomStringUtils;
+import org.apache.ratis.protocol.ClientId;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import picocli.CommandLine.Option;
+import picocli.CommandLine.ParentCommand;
+
+/**
+ * Base class for simplified performance tests.
+ */
+public class BaseFreonGenerator {
+
+ private static final Logger LOG =
+ LoggerFactory.getLogger(BaseFreonGenerator.class);
+
+ private static final int CHECK_INTERVAL_MILLIS = 1000;
+
+ private static final String DIGEST_ALGORITHM = "MD5";
+
+ private static final Pattern ENV_VARIABLE_IN_PATTERN =
+ Pattern.compile("__(.+?)__");
+
+ @ParentCommand
+ private Freon freonCommand;
+
+ @Option(names = {"-n", "--number-of-tests"},
+ description = "Number of the generated objects.",
+ defaultValue = "1000")
+ private long testNo = 1000;
+
+ @Option(names = {"-t", "--threads", "--thread"},
+ description = "Number of threads used to execute",
+ defaultValue = "10")
+ private int threadNo;
+
+ @Option(names = {"-f", "--fail-at-end"},
+ description = "If turned on, all the tasks will be executed even if "
+ + "there are failures.")
+ private boolean failAtEnd;
+
+ @Option(names = {"-p", "--prefix"},
+ description = "Unique identifier of the test execution. Usually used as"
+ + " a prefix of the generated object names. If empty, a random name"
+ + " will be generated",
+ defaultValue = "")
+ private String prefix = "";
+
+ private MetricRegistry metrics = new MetricRegistry();
+
+ private ExecutorService executor;
+
+ private AtomicLong successCounter;
+
+ private AtomicLong failureCounter;
+
+ private long startTime;
+
+ private PathSchema pathSchema;
+
+ /**
+ * The main logic to execute a test generator.
+ *
+ * @param provider creates the new steps to execute.
+ */
+ public void runTests(TaskProvider provider) {
+
+executor = Executors.newFixedThreadPool(threadNo);
+
+ProgressBar progressBar =
+new ProgressBar(System.out, testNo, successCounter::get);
+progressBar.start();
+
+startTime = System.currentTimeMillis();
+//schedule the execution of all the tasks.
+for (int i = 0; i < testNo; i++) {
+ executor.execute(() -> {
+try {
+
+ //in case of an other failed test, we shouldn't execute more tasks.
+ if (!failAtEnd && failureCounter.get() > 0) {
+return;
+ }
+
+ provider.executeNextTask(successCounter.get());
Review comment:
```suggestion
