[jira] [Commented] (HADOOP-11393) Revert HADOOP_PREFIX, go back to HADOOP_HOME
[ https://issues.apache.org/jira/browse/HADOOP-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14534939#comment-14534939 ] Roman Shaposhnik commented on HADOOP-11393: --- [~aw] first of all, I'm very much +1 on the idea of going back to HADOOP_HOME. I'm reviewing the patch right now. The question I have is this though: how do we advertise that the winter is coming? There's a suspicious lack of activity on this JIRA. Should we blast to a ML that this may be going in? > Revert HADOOP_PREFIX, go back to HADOOP_HOME > > > Key: HADOOP-11393 > URL: https://issues.apache.org/jira/browse/HADOOP-11393 > Project: Hadoop Common > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Allen Wittenauer > Labels: BB2015-05-TBR > Attachments: HADOOP-11393-00.patch > > > Today, Windows and parts of the Hadoop source code still use HADOOP_HOME. > The switch to HADOOP_PREFIX back in 0.21 or so didn't really accomplish what > it was intended to do and only helped confuse the situation. > _HOME is a much more standard suffix and is, in fact, used for everything in > Hadoop except for the top level project home. I think it would be beneficial > to use HADOOP_HOME in the shell code as the Official(tm) variable, still > honoring HADOOP_PREFIX if it is set. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11393) Revert HADOOP_PREFIX, go back to HADOOP_HOME
[ https://issues.apache.org/jira/browse/HADOOP-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535071#comment-14535071 ] Allen Wittenauer commented on HADOOP-11393: --- Given that this would be trunk only, I think their is a high expectation that people will be reviewing their shell code and call outs anyway given the amount of change already present. Plus, now that we have deprecation code, we can handle HADOOP_PREFIX so that a) it is still honored but with a warning and b) so that we can actually remove it in hadoop 4.x (!) in a safe way. > Revert HADOOP_PREFIX, go back to HADOOP_HOME > > > Key: HADOOP-11393 > URL: https://issues.apache.org/jira/browse/HADOOP-11393 > Project: Hadoop Common > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Allen Wittenauer > Labels: BB2015-05-TBR > Attachments: HADOOP-11393-00.patch > > > Today, Windows and parts of the Hadoop source code still use HADOOP_HOME. > The switch to HADOOP_PREFIX back in 0.21 or so didn't really accomplish what > it was intended to do and only helped confuse the situation. > _HOME is a much more standard suffix and is, in fact, used for everything in > Hadoop except for the top level project home. I think it would be beneficial > to use HADOOP_HOME in the shell code as the Official(tm) variable, still > honoring HADOOP_PREFIX if it is set. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11393) Revert HADOOP_PREFIX, go back to HADOOP_HOME
[ https://issues.apache.org/jira/browse/HADOOP-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535161#comment-14535161 ] Roman Shaposhnik commented on HADOOP-11393: --- The patch is pretty straightforward and in general looks good to me. A couple of comments still: * the parts that patch documentation need to be rebased on the current state of trunk * the hadoop-functions.sh part needs to be rebased as well * httpfs-env.sh httpfs-config.sh httpfs.sh mapred-config.sh rumen2sls.sh still use HADOOP_PREFIX even after applying the patch The biggest question I have is re: overriding HADOOP_HOME with HADOOP_PREFIX unconditionally. Shouldn't we at least start issuing a deprecation warning for use of HADOOP_PREFIX ? [~aw] do you want to take care of the above? > Revert HADOOP_PREFIX, go back to HADOOP_HOME > > > Key: HADOOP-11393 > URL: https://issues.apache.org/jira/browse/HADOOP-11393 > Project: Hadoop Common > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Allen Wittenauer > Labels: BB2015-05-TBR > Attachments: HADOOP-11393-00.patch > > > Today, Windows and parts of the Hadoop source code still use HADOOP_HOME. > The switch to HADOOP_PREFIX back in 0.21 or so didn't really accomplish what > it was intended to do and only helped confuse the situation. > _HOME is a much more standard suffix and is, in fact, used for everything in > Hadoop except for the top level project home. I think it would be beneficial > to use HADOOP_HOME in the shell code as the Official(tm) variable, still > honoring HADOOP_PREFIX if it is set. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11393) Revert HADOOP_PREFIX, go back to HADOOP_HOME
[
https://issues.apache.org/jira/browse/HADOOP-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535363#comment-14535363
]
Hadoop QA commented on HADOOP-11393:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | patch | 0m 0s | The patch command could not apply
the patch during dryrun. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12690607/HADOOP-11393-00.patch |
| Optional Tests | javadoc javac unit shellcheck site findbugs checkstyle |
| git revision | trunk / 8f7c236 |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6548/console |
This message was automatically generated.
> Revert HADOOP_PREFIX, go back to HADOOP_HOME
>
>
> Key: HADOOP-11393
> URL: https://issues.apache.org/jira/browse/HADOOP-11393
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Allen Wittenauer
> Labels: BB2015-05-TBR
> Attachments: HADOOP-11393-00.patch
>
>
> Today, Windows and parts of the Hadoop source code still use HADOOP_HOME.
> The switch to HADOOP_PREFIX back in 0.21 or so didn't really accomplish what
> it was intended to do and only helped confuse the situation.
> _HOME is a much more standard suffix and is, in fact, used for everything in
> Hadoop except for the top level project home. I think it would be beneficial
> to use HADOOP_HOME in the shell code as the Official(tm) variable, still
> honoring HADOOP_PREFIX if it is set.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11393) Revert HADOOP_PREFIX, go back to HADOOP_HOME
[
https://issues.apache.org/jira/browse/HADOOP-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539008#comment-14539008
]
Hadoop QA commented on HADOOP-11393:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 17m 34s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 4 new or modified test files. |
| {color:green}+1{color} | javac | 7m 28s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 34s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | site | 3m 0s | Site still builds. |
| {color:red}-1{color} | checkstyle | 5m 57s | The applied patch generated 1
new checkstyle issues (total was 18, now 18). |
| {color:red}-1{color} | checkstyle | 6m 45s | The applied patch generated 2
new checkstyle issues (total was 160, now 156). |
| {color:green}+1{color} | shellcheck | 0m 5s | There were no new shellcheck
(v0.3.3) issues. |
| {color:red}-1{color} | whitespace | 0m 5s | The patch has 4 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 37s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:red}-1{color} | findbugs | 10m 41s | The patch appears to introduce 2
new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | common tests | 23m 13s | Tests passed in
hadoop-common. |
| {color:green}+1{color} | common tests | 1m 37s | Tests passed in
hadoop-kms. |
| {color:green}+1{color} | mapreduce tests | 1m 33s | Tests passed in
hadoop-mapreduce-client-core. |
| {color:green}+1{color} | mapreduce tests | 102m 49s | Tests passed in
hadoop-mapreduce-client-jobclient. |
| {color:green}+1{color} | tools/hadoop tests | 0m 27s | Tests passed in
hadoop-datajoin. |
| {color:green}+1{color} | tools/hadoop tests | 0m 57s | Tests passed in
hadoop-sls. |
| {color:green}+1{color} | tools/hadoop tests | 6m 12s | Tests passed in
hadoop-streaming. |
| {color:green}+1{color} | yarn tests | 6m 4s | Tests passed in
hadoop-yarn-server-nodemanager. |
| {color:red}-1{color} | hdfs tests | 164m 43s | Tests failed in hadoop-hdfs. |
| {color:red}-1{color} | hdfs tests | 13m 14s | Tests failed in
hadoop-hdfs-httpfs. |
| | | 378m 57s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-datajoin |
| | Unread public/protected field:At DataJoinMapperBase.java:[line 52] |
| | Unread public/protected field:At DataJoinMapperBase.java:[line 50] |
| Failed unit tests | hadoop.tracing.TestTraceAdmin |
| | hadoop.hdfs.tools.TestHdfsConfigFields |
| | hadoop.fs.http.client.TestHttpFSWithHttpFSFileSystem |
| | hadoop.fs.http.client.TestHttpFSFWithWebhdfsFileSystem |
| | hadoop.fs.http.client.TestHttpFSFWithSWebhdfsFileSystem |
| Timed out tests |
org.apache.hadoop.fs.http.client.TestHttpFSFileSystemLocalFileSystem |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12731641/HADOOP-11393.01.patch |
| Optional Tests | javadoc javac unit shellcheck site findbugs checkstyle |
| git revision | trunk / b9cebfc |
| checkstyle |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6589/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-core.txt
https://builds.apache.org/job/PreCommit-HADOOP-Build/6589/artifact/patchprocess/diffcheckstylehadoop-streaming.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6589/artifact/patchprocess/whitespace.txt
|
| Findbugs warnings |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6589/artifact/patchprocess/newPatchFindbugsWarningshadoop-datajoin.html
|
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6589/artifact/patchprocess/testrun_hadoop-common.txt
|
| hadoop-kms test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6589/artifact/patchprocess/testrun_hadoop-kms.txt
|
| hadoop-mapreduce-client-core test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6589/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt
|
| hadoop-mapreduce-client-jobclient test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6589/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt
|
| hadoop-datajoin test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6589/artifact/patchprocess/testrun_hadoop-datajoin.txt
|
| hadoop-sls test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6589/artifac
[jira] [Commented] (HADOOP-11393) Revert HADOOP_PREFIX, go back to HADOOP_HOME
[
https://issues.apache.org/jira/browse/HADOOP-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15210442#comment-15210442
]
Hadoop QA commented on HADOOP-11393:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 9s {color}
| {color:red} HADOOP-11393 does not apply to trunk. Rebase required? Wrong
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12731641/HADOOP-11393.01.patch
|
| JIRA Issue | HADOOP-11393 |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/8914/console |
| Powered by | Apache Yetus 0.2.0 http://yetus.apache.org |
This message was automatically generated.
> Revert HADOOP_PREFIX, go back to HADOOP_HOME
>
>
> Key: HADOOP-11393
> URL: https://issues.apache.org/jira/browse/HADOOP-11393
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
> Attachments: HADOOP-11393-00.patch, HADOOP-11393.01.patch
>
>
> Today, Windows and parts of the Hadoop source code still use HADOOP_HOME.
> The switch to HADOOP_PREFIX back in 0.21 or so didn't really accomplish what
> it was intended to do and only helped confuse the situation.
> _HOME is a much more standard suffix and is, in fact, used for everything in
> Hadoop except for the top level project home. I think it would be beneficial
> to use HADOOP_HOME in the shell code as the Official(tm) variable, still
> honoring HADOOP_PREFIX if it is set.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11393) Revert HADOOP_PREFIX, go back to HADOOP_HOME
[ https://issues.apache.org/jira/browse/HADOOP-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211059#comment-15211059 ] Allen Wittenauer commented on HADOOP-11393: --- A local run w/out unit tests resulted in the these failures: | Vote | Subsystem | Runtime | Comment | -1 |checkstyle | 1m 21s| root: patch generated 4 new + 172 | | ||| unchanged - 8 fixed = 176 total (was 180) | | -1 |whitespace | 0m 0s | The patch has 2 line(s) that end in | | ||| whitespace. Use git apply | | ||| --whitespace=fix. | Checkstyle issues are all line length problems. I suspect the 8 fixed are also line length as well. I'll fire off unit tests tonight. > Revert HADOOP_PREFIX, go back to HADOOP_HOME > > > Key: HADOOP-11393 > URL: https://issues.apache.org/jira/browse/HADOOP-11393 > Project: Hadoop Common > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Attachments: HADOOP-11393-00.patch, HADOOP-11393.01.patch, > HADOOP-11393.02.patch > > > Today, Windows and parts of the Hadoop source code still use HADOOP_HOME. > The switch to HADOOP_PREFIX back in 0.21 or so didn't really accomplish what > it was intended to do and only helped confuse the situation. > _HOME is a much more standard suffix and is, in fact, used for everything in > Hadoop except for the top level project home. I think it would be beneficial > to use HADOOP_HOME in the shell code as the Official(tm) variable, still > honoring HADOOP_PREFIX if it is set. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11393) Revert HADOOP_PREFIX, go back to HADOOP_HOME
[
https://issues.apache.org/jira/browse/HADOOP-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211372#comment-15211372
]
Hadoop QA commented on HADOOP-11393:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 16s
{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m 3s
{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 12 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 19s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
51s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 8s
{color} | {color:green} trunk passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 47s
{color} | {color:green} trunk passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
8s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 10m
44s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m
50s {color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s
{color} | {color:blue} Skipped branch modules with no Java source:
hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site hadoop-tools/hadoop-pipes
hadoop-mapreduce-project {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 24s
{color} | {color:red} hadoop-tools/hadoop-datajoin in trunk has 2 extant
Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 7m 14s
{color} | {color:green} trunk passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 11m
29s {color} | {color:green} trunk passed with JDK v1.7.0_95 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 15s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
51s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 4s
{color} | {color:green} the patch passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m 4s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 54s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m 54s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 7s
{color} | {color:red} root: patch generated 4 new + 171 unchanged - 8 fixed =
175 total (was 179) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 10m
35s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m
47s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
10s {color} | {color:green} There were no new shellcheck issues. {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s
{color} | {color:red} The patch has 2 line(s) that end in whitespace. Use git
apply --whitespace=fix. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s
{color} | {color:blue} Skipped patch modules with no Java source:
hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site hadoop-tools/hadoop-pipes
hadoop-mapreduce-project {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 10m
56s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 7m 21s
{color} | {color:green} the patch passed with JDK v1.8.0_74 {color} |
| {color:green}+1{co
[jira] [Commented] (HADOOP-11393) Revert HADOOP_PREFIX, go back to HADOOP_HOME
[ https://issues.apache.org/jira/browse/HADOOP-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212574#comment-15212574 ] Allen Wittenauer commented on HADOOP-11393: --- Other than the usual flaky tests, tests finally passed locally. > Revert HADOOP_PREFIX, go back to HADOOP_HOME > > > Key: HADOOP-11393 > URL: https://issues.apache.org/jira/browse/HADOOP-11393 > Project: Hadoop Common > Issue Type: Improvement > Components: scripts, tracing >Affects Versions: 3.0.0 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Attachments: HADOOP-11393-00.patch, HADOOP-11393.01.patch, > HADOOP-11393.02.patch, HADOOP-11393.03.patch > > > Today, Windows and parts of the Hadoop source code still use HADOOP_HOME. > The switch to HADOOP_PREFIX back in 0.21 or so didn't really accomplish what > it was intended to do and only helped confuse the situation. > _HOME is a much more standard suffix and is, in fact, used for everything in > Hadoop except for the top level project home. I think it would be beneficial > to use HADOOP_HOME in the shell code as the Official(tm) variable, still > honoring HADOOP_PREFIX if it is set. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11393) Revert HADOOP_PREFIX, go back to HADOOP_HOME
[
https://issues.apache.org/jira/browse/HADOOP-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213243#comment-15213243
]
Hadoop QA commented on HADOOP-11393:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 17s
{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m 4s
{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 12 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 22s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 3m 21s
{color} | {color:red} root in trunk failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 1m 53s
{color} | {color:red} root in trunk failed with JDK v1.8.0_74. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 2m 11s
{color} | {color:red} root in trunk failed with JDK v1.7.0_95. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
38s {color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m 37s
{color} | {color:red} hadoop-hdfs in trunk failed. {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m
35s {color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s
{color} | {color:blue} Skipped branch modules with no Java source:
hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site hadoop-tools/hadoop-pipes
hadoop-mapreduce-project {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 25s
{color} | {color:red} hadoop-hdfs in trunk failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 27s
{color} | {color:red} hadoop-tools/hadoop-datajoin in trunk has 2 extant
Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 14m
23s {color} | {color:green} trunk passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 26m
41s {color} | {color:green} trunk passed with JDK v1.7.0_95 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 15s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 25s
{color} | {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 2m 37s
{color} | {color:red} root in the patch failed with JDK v1.8.0_74. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 2m 37s {color}
| {color:red} root in the patch failed with JDK v1.8.0_74. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 2m 11s
{color} | {color:red} root in the patch failed with JDK v1.7.0_95. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 2m 11s {color}
| {color:red} root in the patch failed with JDK v1.7.0_95. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 14s
{color} | {color:red} root: patch generated 4 new + 171 unchanged - 8 fixed =
175 total (was 179) {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m 29s
{color} | {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m
40s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
10s {color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s
{color} | {color:blue} Skipped patch modules with no Java source:
hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site hadoop-tools/hadoop-pipes
hadoop-mapreduce-project {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 24s
{color} | {color:red} hadoop-hdfs in the patch failed. {colo
[jira] [Commented] (HADOOP-11393) Revert HADOOP_PREFIX, go back to HADOOP_HOME
[ https://issues.apache.org/jira/browse/HADOOP-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213277#comment-15213277 ] Allen Wittenauer commented on HADOOP-11393: --- Unit test failures shouldn't be a surprise. hadoop-hdfs compilation failure is from since reverted source commit for HDFS-9694. ASF license warning is from HDFS-9005. > Revert HADOOP_PREFIX, go back to HADOOP_HOME > > > Key: HADOOP-11393 > URL: https://issues.apache.org/jira/browse/HADOOP-11393 > Project: Hadoop Common > Issue Type: Improvement > Components: scripts, tracing >Affects Versions: 3.0.0 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Attachments: HADOOP-11393-00.patch, HADOOP-11393.01.patch, > HADOOP-11393.02.patch, HADOOP-11393.03.patch, HADOOP-11393.04.patch > > > Today, Windows and parts of the Hadoop source code still use HADOOP_HOME. > The switch to HADOOP_PREFIX back in 0.21 or so didn't really accomplish what > it was intended to do and only helped confuse the situation. > _HOME is a much more standard suffix and is, in fact, used for everything in > Hadoop except for the top level project home. I think it would be beneficial > to use HADOOP_HOME in the shell code as the Official(tm) variable, still > honoring HADOOP_PREFIX if it is set. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11393) Revert HADOOP_PREFIX, go back to HADOOP_HOME
[
https://issues.apache.org/jira/browse/HADOOP-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213323#comment-15213323
]
Hadoop QA commented on HADOOP-11393:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 11s
{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m 4s
{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 12 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 2m 34s
{color} | {color:red} root in trunk failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 1m 4s
{color} | {color:red} root in trunk failed with JDK v1.8.0_74. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 1m 13s
{color} | {color:red} root in trunk failed with JDK v1.7.0_95. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
4s {color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m 26s
{color} | {color:red} hadoop-hdfs in trunk failed. {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m
40s {color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s
{color} | {color:blue} Skipped branch modules with no Java source:
hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site hadoop-tools/hadoop-pipes
hadoop-mapreduce-project {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 23s
{color} | {color:red} hadoop-hdfs in trunk failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 23s
{color} | {color:red} hadoop-tools/hadoop-datajoin in trunk has 2 extant
Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m 53s
{color} | {color:green} trunk passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 11m
13s {color} | {color:green} trunk passed with JDK v1.7.0_95 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 22s
{color} | {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 1m 5s
{color} | {color:red} root in the patch failed with JDK v1.8.0_74. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 1m 5s {color}
| {color:red} root in the patch failed with JDK v1.8.0_74. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 1m 14s
{color} | {color:red} root in the patch failed with JDK v1.7.0_95. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 1m 14s {color}
| {color:red} root in the patch failed with JDK v1.7.0_95. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 4s
{color} | {color:red} root: patch generated 4 new + 171 unchanged - 8 fixed =
175 total (was 179) {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m 26s
{color} | {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m
40s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
9s {color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s
{color} | {color:blue} Skipped patch modules with no Java source:
hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site hadoop-tools/hadoop-pipes
hadoop-mapreduce-project {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 22s
{color} | {color:red} hadoop-hdfs in the patch failed. {color} |
|
[jira] [Commented] (HADOOP-11393) Revert HADOOP_PREFIX, go back to HADOOP_HOME
[
https://issues.apache.org/jira/browse/HADOOP-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213859#comment-15213859
]
Akira AJISAKA commented on HADOOP-11393:
Mostly looks good to me. Minor nit:
* Duplicate {{unset HADOOP_HOME}} in hadoop-functions_test_helper.bash.
> Revert HADOOP_PREFIX, go back to HADOOP_HOME
>
>
> Key: HADOOP-11393
> URL: https://issues.apache.org/jira/browse/HADOOP-11393
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts, tracing
>Affects Versions: 3.0.0
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
> Attachments: HADOOP-11393-00.patch, HADOOP-11393.01.patch,
> HADOOP-11393.02.patch, HADOOP-11393.03.patch, HADOOP-11393.04.patch
>
>
> Today, Windows and parts of the Hadoop source code still use HADOOP_HOME.
> The switch to HADOOP_PREFIX back in 0.21 or so didn't really accomplish what
> it was intended to do and only helped confuse the situation.
> _HOME is a much more standard suffix and is, in fact, used for everything in
> Hadoop except for the top level project home. I think it would be beneficial
> to use HADOOP_HOME in the shell code as the Official(tm) variable, still
> honoring HADOOP_PREFIX if it is set.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11393) Revert HADOOP_PREFIX, go back to HADOOP_HOME
[
https://issues.apache.org/jira/browse/HADOOP-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215478#comment-15215478
]
Hadoop QA commented on HADOOP-11393:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 17s
{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m 4s
{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 12 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 20s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
34s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 12m 0s
{color} | {color:green} trunk passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 51s
{color} | {color:green} trunk passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
5s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 12m
36s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 4m
17s {color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s
{color} | {color:blue} Skipped branch modules with no Java source:
hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site hadoop-tools/hadoop-pipes
hadoop-mapreduce-project {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 30s
{color} | {color:red} hadoop-tools/hadoop-datajoin in trunk has 2 extant
Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 13m
13s {color} | {color:green} trunk passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 13m
49s {color} | {color:green} trunk passed with JDK v1.7.0_95 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 18s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 11m
18s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 13m 2s
{color} | {color:green} the patch passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 13m 2s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m 30s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 9m 30s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 14s
{color} | {color:red} root: patch generated 4 new + 171 unchanged - 8 fixed =
175 total (was 179) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 13m
13s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 4m
31s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
9s {color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s
{color} | {color:blue} Skipped patch modules with no Java source:
hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site hadoop-tools/hadoop-pipes
hadoop-mapreduce-project {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 14m
41s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 12m
27s {color} | {color:green} the patch passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javadoc {color
[jira] [Commented] (HADOOP-11393) Revert HADOOP_PREFIX, go back to HADOOP_HOME
[
https://issues.apache.org/jira/browse/HADOOP-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15217252#comment-15217252
]
Akira AJISAKA commented on HADOOP-11393:
Thanks [~aw] for the update! I have one question: where is the definition of
deprecate_env_var? Am I missing something?
{code:title=hadoop-config.sh}
deprecate_env_var HADOOP_PREFIX HADOOP_HOME
{code}
> Revert HADOOP_PREFIX, go back to HADOOP_HOME
>
>
> Key: HADOOP-11393
> URL: https://issues.apache.org/jira/browse/HADOOP-11393
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts, tracing
>Affects Versions: 3.0.0
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
> Attachments: HADOOP-11393-00.patch, HADOOP-11393.01.patch,
> HADOOP-11393.02.patch, HADOOP-11393.03.patch, HADOOP-11393.04.patch,
> HADOOP-11393.05.patch
>
>
> Today, Windows and parts of the Hadoop source code still use HADOOP_HOME.
> The switch to HADOOP_PREFIX back in 0.21 or so didn't really accomplish what
> it was intended to do and only helped confuse the situation.
> _HOME is a much more standard suffix and is, in fact, used for everything in
> Hadoop except for the top level project home. I think it would be beneficial
> to use HADOOP_HOME in the shell code as the Official(tm) variable, still
> honoring HADOOP_PREFIX if it is set.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11393) Revert HADOOP_PREFIX, go back to HADOOP_HOME
[ https://issues.apache.org/jira/browse/HADOOP-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15217257#comment-15217257 ] Akira AJISAKA commented on HADOOP-11393: I got it. "deprecate_env_var" should be "hadoop_deprecate_envvar". > Revert HADOOP_PREFIX, go back to HADOOP_HOME > > > Key: HADOOP-11393 > URL: https://issues.apache.org/jira/browse/HADOOP-11393 > Project: Hadoop Common > Issue Type: Improvement > Components: scripts, tracing >Affects Versions: 3.0.0 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Attachments: HADOOP-11393-00.patch, HADOOP-11393.01.patch, > HADOOP-11393.02.patch, HADOOP-11393.03.patch, HADOOP-11393.04.patch, > HADOOP-11393.05.patch > > > Today, Windows and parts of the Hadoop source code still use HADOOP_HOME. > The switch to HADOOP_PREFIX back in 0.21 or so didn't really accomplish what > it was intended to do and only helped confuse the situation. > _HOME is a much more standard suffix and is, in fact, used for everything in > Hadoop except for the top level project home. I think it would be beneficial > to use HADOOP_HOME in the shell code as the Official(tm) variable, still > honoring HADOOP_PREFIX if it is set. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11393) Revert HADOOP_PREFIX, go back to HADOOP_HOME
[
https://issues.apache.org/jira/browse/HADOOP-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15218858#comment-15218858
]
Hadoop QA commented on HADOOP-11393:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 19s
{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m 7s
{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 12 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 50s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
45s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 12m 4s
{color} | {color:green} trunk passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 10m
12s {color} | {color:green} trunk passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
34s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 14m
38s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 5m
20s {color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s
{color} | {color:blue} Skipped branch modules with no Java source:
hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site hadoop-tools/hadoop-pipes
hadoop-mapreduce-project {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 34s
{color} | {color:red} hadoop-tools/hadoop-datajoin in trunk has 2 extant
Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 12m
48s {color} | {color:green} trunk passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 16m
18s {color} | {color:green} trunk passed with JDK v1.7.0_95 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 19s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 12m
44s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 11m
54s {color} | {color:green} the patch passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 11m 54s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 10m
15s {color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 10m 15s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 32s
{color} | {color:red} root: patch generated 4 new + 171 unchanged - 8 fixed =
175 total (was 179) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 14m
57s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 5m
39s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
13s {color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s
{color} | {color:blue} Skipped patch modules with no Java source:
hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site hadoop-tools/hadoop-pipes
hadoop-mapreduce-project {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 14m
43s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 12m
46s {color} | {color:green} the patch passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javadoc
[jira] [Commented] (HADOOP-11393) Revert HADOOP_PREFIX, go back to HADOOP_HOME
[ https://issues.apache.org/jira/browse/HADOOP-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15219494#comment-15219494 ] Akira AJISAKA commented on HADOOP-11393: +1, thanks Allen. > Revert HADOOP_PREFIX, go back to HADOOP_HOME > > > Key: HADOOP-11393 > URL: https://issues.apache.org/jira/browse/HADOOP-11393 > Project: Hadoop Common > Issue Type: Improvement > Components: scripts, tracing >Affects Versions: 3.0.0 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Attachments: HADOOP-11393-00.patch, HADOOP-11393.01.patch, > HADOOP-11393.02.patch, HADOOP-11393.03.patch, HADOOP-11393.04.patch, > HADOOP-11393.05.patch, HADOOP-11393.06.patch > > > Today, Windows and parts of the Hadoop source code still use HADOOP_HOME. > The switch to HADOOP_PREFIX back in 0.21 or so didn't really accomplish what > it was intended to do and only helped confuse the situation. > _HOME is a much more standard suffix and is, in fact, used for everything in > Hadoop except for the top level project home. I think it would be beneficial > to use HADOOP_HOME in the shell code as the Official(tm) variable, still > honoring HADOOP_PREFIX if it is set. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11393) Revert HADOOP_PREFIX, go back to HADOOP_HOME
[ https://issues.apache.org/jira/browse/HADOOP-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220006#comment-15220006 ] Hudson commented on HADOOP-11393: - FAILURE: Integrated in Hadoop-trunk-Commit #9533 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/9533/]) HADOOP-11393. Revert HADOOP_PREFIX, go back to HADOOP_HOME (aw) (aw: rev 0a74610d1c7c7f183d2b2d0b7a775add53cf6c94) * hadoop-common-project/hadoop-common/src/main/bin/stop-all.sh * hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/DumpTypedBytes.java * hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-balancer.sh * hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/Federation.md * hadoop-common-project/hadoop-kms/src/main/conf/kms-env.sh * hadoop-yarn-project/hadoop-yarn/bin/yarn * hadoop-common-project/hadoop-common/src/main/bin/slaves.sh * hadoop-common-project/hadoop-common/src/site/markdown/ClusterSetup.md * hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh * hadoop-common-project/hadoop-common/src/site/markdown/UnixShellGuide.md * hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs * hadoop-tools/hadoop-datajoin/src/test/java/org/apache/hadoop/contrib/utils/join/README.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestDockerContainerExecutorWithMocks.java * hadoop-common-project/hadoop-common/src/main/bin/start-all.sh * hadoop-common-project/hadoop-common/src/main/bin/hadoop * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/fs/DFSCIOTest.java * hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-secure-dns.sh * hadoop-yarn-project/hadoop-yarn/bin/yarn-daemon.sh * hadoop-hdfs-project/hadoop-hdfs/src/main/bin/distribute-exclude.sh * hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/conf/httpfs-env.sh * hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/DockerContainerExecutor.md.vm * hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/libexec/httpfs-config.sh * hadoop-tools/hadoop-sls/src/main/bin/slsrun.sh * hadoop-mapreduce-project/bin/mapred-config.sh * hadoop-common-project/hadoop-common/src/site/markdown/CommandsManual.md * hadoop-yarn-project/hadoop-yarn/bin/start-yarn.sh * hadoop-hdfs-project/hadoop-hdfs/src/main/bin/refresh-namenodes.sh * hadoop-common-project/hadoop-common/src/test/scripts/hadoop_basic_init.bats * hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/doc/README * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/ReliabilityTest.java * hadoop-yarn-project/hadoop-yarn/bin/yarn-config.sh * hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemons.sh * hadoop-common-project/hadoop-common/src/main/bin/hadoop-layout.sh.example * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracingShortCircuitLocalRead.java * hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/HadoopStreaming.java * hadoop-common-project/hadoop-common/src/test/scripts/hadoop_confdir.bats * hadoop-tools/hadoop-pipes/src/main/native/pipes/debug/pipes-default-script * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTraceAdmin.java * hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsNfsGateway.md * hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/LoadTypedBytes.java * hadoop-mapreduce-project/bin/mr-jobhistory-daemon.sh * hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java * hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs-config.sh * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/TraceUtils.java * hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemon.sh * hadoop-mapreduce-project/bin/mapred * hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/StreamJob.java * hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSHighAvailabilityWithQJM.md * hadoop-common-project/hadoop-common/src/test/scripts/hadoop_finalize.bats * hadoop-common-project/hadoop-common/src/test/scripts/hadoop_bootstrap.bats * hadoop-common-project/hadoop-common/src/main/bin/hadoop-config.sh * hadoop-yarn-project/hadoop-yarn/bin/stop-yarn.sh * hadoop-yarn-project/hadoop-yarn/bin/yarn-daemons.sh * hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/sbin/httpfs.sh * hadoop-common-project/hadoop-kms/src/main/sbin/kms.sh * hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-balancer.sh * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/pipes/Submitter.java * hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_dfs_wrapper.sh * hadoop-too
[jira] [Commented] (HADOOP-11393) Revert HADOOP_PREFIX, go back to HADOOP_HOME
[ https://issues.apache.org/jira/browse/HADOOP-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14268170#comment-14268170 ] Allen Wittenauer commented on HADOOP-11393: --- It should be noted that Windows still uses HADOOP_HOME, which leads to interesting contortions when trying to use cygwin. See HADOOP-11464 . > Revert HADOOP_PREFIX, go back to HADOOP_HOME > > > Key: HADOOP-11393 > URL: https://issues.apache.org/jira/browse/HADOOP-11393 > Project: Hadoop Common > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Allen Wittenauer > Attachments: HADOOP-11393-00.patch > > > Today, Windows and parts of the Hadoop source code still use HADOOP_HOME. > The switch to HADOOP_PREFIX back in 0.21 or so didn't really accomplish what > it was intended to do and only helped confuse the situation. > _HOME is a much more standard suffix and is, in fact, used for everything in > Hadoop except for the top level project home. I think it would be beneficial > to use HADOOP_HOME in the shell code as the Official(tm) variable, still > honoring HADOOP_PREFIX if it is set. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11393) Revert HADOOP_PREFIX, go back to HADOOP_HOME
[
https://issues.apache.org/jira/browse/HADOOP-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14268708#comment-14268708
]
Hadoop QA commented on HADOOP-11393:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12690607/HADOOP-11393-00.patch
against trunk revision 3ed0aed.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 15 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms
hadoop-hdfs-project/hadoop-hdfs
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
hadoop-tools/hadoop-datajoin hadoop-tools/hadoop-streaming
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5377//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5377//artifact/patchprocess/newPatchFindbugsWarningshadoop-datajoin.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5377//artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5377//console
This message is automatically generated.
> Revert HADOOP_PREFIX, go back to HADOOP_HOME
>
>
> Key: HADOOP-11393
> URL: https://issues.apache.org/jira/browse/HADOOP-11393
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Allen Wittenauer
> Attachments: HADOOP-11393-00.patch
>
>
> Today, Windows and parts of the Hadoop source code still use HADOOP_HOME.
> The switch to HADOOP_PREFIX back in 0.21 or so didn't really accomplish what
> it was intended to do and only helped confuse the situation.
> _HOME is a much more standard suffix and is, in fact, used for everything in
> Hadoop except for the top level project home. I think it would be beneficial
> to use HADOOP_HOME in the shell code as the Official(tm) variable, still
> honoring HADOOP_PREFIX if it is set.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
