[jira] [Commented] (HADOOP-13588) ConfServlet doesn't set response content type according to the Accept header
[
https://issues.apache.org/jira/browse/HADOOP-13588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15480869#comment-15480869
]
Hadoop QA commented on HADOOP-13588:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
29s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
29s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
24s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
0s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
31s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
47s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 9m
26s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 42m 29s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Issue | HADOOP-13588 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12827915/HADOOP-13588.002.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 696a6cb13f12 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / a99bf26 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/10477/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/10477/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> ConfServlet doesn't set response content type according to the Accept header
> -
>
> Key: HADOOP-13588
> URL: https://issues.apache.org/jira/browse/HADOOP-13588
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
> Attachments: HADOOP-13588.001.patch, HADOOP-13588.002.patch
>
>
> ConfServlet provides a general service to retrieve daemon configurations.
> However it doesn't set
[jira] [Commented] (HADOOP-13588) ConfServlet doesn't set response content type according to the Accept header
[
https://issues.apache.org/jira/browse/HADOOP-13588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15480829#comment-15480829
]
Weiwei Yang commented on HADOOP-13588:
--
Hello [~liuml07]
Thank you for reviewing this, I added @VisibleForTesting like you suggested and
uploaded v2 patch.
Well this is an incompatible change but I think it's more like a bug fix. I
checked the history of this file, I can't see any particular reason why to use
that approach. Probably safe to fix :).
Thank you.
> ConfServlet doesn't set response content type according to the Accept header
> -
>
> Key: HADOOP-13588
> URL: https://issues.apache.org/jira/browse/HADOOP-13588
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
> Attachments: HADOOP-13588.001.patch, HADOOP-13588.002.patch
>
>
> ConfServlet provides a general service to retrieve daemon configurations.
> However it doesn't set response content-type according to *Accept* header.
> For example, by issuing following command,
> {code}
> curl --header "Accept:application/json"
> http://${resourcemanager_host}:8088/conf
> {code}
> I am expecting the response would be in JSON format, however it is still in
> XML. I can only get JSON if I issue
> {code}
> curl http://${resourcemanager_host}:8088/conf?format="json;
> {code}
> This is not the common way how clients set content-type.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13588) ConfServlet doesn't set response content type according to the Accept header
[
https://issues.apache.org/jira/browse/HADOOP-13588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15478811#comment-15478811
]
Mingliang Liu commented on HADOOP-13588:
Can you add @VisibleForTesting annotation to parseAccecptHeader() method?
Otherwise +1 for the patch. I'll leave this open for 2nd opinion as it's
incompatible change.
> ConfServlet doesn't set response content type according to the Accept header
> -
>
> Key: HADOOP-13588
> URL: https://issues.apache.org/jira/browse/HADOOP-13588
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
> Attachments: HADOOP-13588.001.patch
>
>
> ConfServlet provides a general service to retrieve daemon configurations.
> However it doesn't set response content-type according to *Accept* header.
> For example, by issuing following command,
> {code}
> curl --header "Accept:application/json"
> http://${resourcemanager_host}:8088/conf
> {code}
> I am expecting the response would be in JSON format, however it is still in
> XML. I can only get JSON if I issue
> {code}
> curl http://${resourcemanager_host}:8088/conf?format="json;
> {code}
> This is not the common way how clients set content-type.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13588) ConfServlet doesn't set response content type according to the Accept header
[
https://issues.apache.org/jira/browse/HADOOP-13588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15474360#comment-15474360
]
Hadoop QA commented on HADOOP-13588:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
38s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
52s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
56s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
46s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 10m
52s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
21s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 42m 33s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Issue | HADOOP-13588 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12827606/HADOOP-13588.001.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 263b5be03a41 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 2d1bf53 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/10462/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/10462/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> ConfServlet doesn't set response content type according to the Accept header
> -
>
> Key: HADOOP-13588
> URL: https://issues.apache.org/jira/browse/HADOOP-13588
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
> Attachments: HADOOP-13588.001.patch
>
>
> ConfServlet provides a general service to retrieve daemon configurations.
> However it doesn't set response content-type
[jira] [Commented] (HADOOP-13588) ConfServlet doesn't set response content type according to the Accept header
[
https://issues.apache.org/jira/browse/HADOOP-13588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15474129#comment-15474129
]
Weiwei Yang commented on HADOOP-13588:
--
Mark this one as incompatible change because it changes way of how clients send
http request to get different content types from http response.
> ConfServlet doesn't set response content type according to the Accept header
> -
>
> Key: HADOOP-13588
> URL: https://issues.apache.org/jira/browse/HADOOP-13588
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
>
> ConfServlet provides a general service to retrieve daemon configurations.
> However it doesn't set response content-type according to *Accept* header.
> For example, by issuing following command,
> {code}
> curl --header "Accept:application/json"
> http://${resourcemanager_host}:8088/conf
> {code}
> I am expecting the response would be in JSON format, however it is still in
> XML. I can only get JSON if I issue
> {code}
> curl http://${resourcemanager_host}:8088/conf?format="json;
> {code}
> This is not the common way how clients set content-type.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
