[jira] [Commented] (HADOOP-16559) [HDFS] use protobuf-maven-plugin to generate protobuf classes
[
https://issues.apache.org/jira/browse/HADOOP-16559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935388#comment-16935388
]
Vinayakumar B commented on HADOOP-16559:
{quote}And here, since this is not a trivial change, I suggest we revert
HADOOP-16557 first? Now it is a pain for developpers as we need protobuf 3.7.1
to compile trunk and then 2.5.0 to compile other branches...
{quote}
Need not switch back and forth to build separate branches. protobuf 3.7.1 can
be installed in a separate location (ex: /opt/protobuf-3.7.1) and "protoc.path"
system property pointing to absolute path of 3.7.1 protoc (ex:
-Dprotoc.path=/opt/protobuf-3.7.1/bin/protoc) can be used to build trunk until
we replace protobuf-maven-plugin.
> [HDFS] use protobuf-maven-plugin to generate protobuf classes
> -
>
> Key: HADOOP-16559
> URL: https://issues.apache.org/jira/browse/HADOOP-16559
> Project: Hadoop Common
> Issue Type: Sub-task
>Reporter: Vinayakumar B
>Priority: Major
>
> Use "protoc-maven-plugin" to dynamically download protobuf executable to
> generate protobuf classes from proto file
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16559) [HDFS] use protobuf-maven-plugin to generate protobuf classes
[ https://issues.apache.org/jira/browse/HADOOP-16559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935196#comment-16935196 ] Duo Zhang commented on HADOOP-16559: OK, got your point why we can not do it at once. Maybe it is time to separate the hadoop project to several sub projects, another story. Left some comments on the PR for HADOOP-16558. PTAL. And here, since this is not a trivial change, I suggest we revert HADOOP-16557 first? Now it is a pain for developpers as we need protobuf 3.7.1 to compile trunk and then 2.5.0 to compile other branches... Once we get the new plugin done for all active branches, we can re apply HADOOP-16557, and we do not need to install protoc compiler in the docker image any more. What do you think? [~vinayakumarb] Thanks. > [HDFS] use protobuf-maven-plugin to generate protobuf classes > - > > Key: HADOOP-16559 > URL: https://issues.apache.org/jira/browse/HADOOP-16559 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Vinayakumar B >Assignee: Duo Zhang >Priority: Major > > Use "protoc-maven-plugin" to dynamically download protobuf executable to > generate protobuf classes from proto file -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16559) [HDFS] use protobuf-maven-plugin to generate protobuf classes
[ https://issues.apache.org/jira/browse/HADOOP-16559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935118#comment-16935118 ] Vinayakumar B commented on HADOOP-16559: Thanks [~zhangduo] for pitching in. I too have tried updating all instances hadoop-maven-plugin in one PR. But with this, precommit jenkins result will never come as its needs to verify all modules with unit tests. It will always gets timedout. So only decided do in 4 patches. Since HADOOP-16558 combines both COMMON+HDFS, total 3 patches required. YARN and MAPREDUCE together also may timeout. So it needs to be kept separately. And morever, default protoc-maven-plugin adds all proto files to jars. This was not earlier behavior. So I had excluded them from getting added. Please check PR for HADOOP-16558. > [HDFS] use protobuf-maven-plugin to generate protobuf classes > - > > Key: HADOOP-16559 > URL: https://issues.apache.org/jira/browse/HADOOP-16559 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Vinayakumar B >Assignee: Duo Zhang >Priority: Major > > Use "protoc-maven-plugin" to dynamically download protobuf executable to > generate protobuf classes from proto file -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16559) [HDFS] use protobuf-maven-plugin to generate protobuf classes
[ https://issues.apache.org/jira/browse/HADOOP-16559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935057#comment-16935057 ] Duo Zhang commented on HADOOP-16559: Actually I;ve created a patch which removes all old protoc plugin in the hadoop poms... > [HDFS] use protobuf-maven-plugin to generate protobuf classes > - > > Key: HADOOP-16559 > URL: https://issues.apache.org/jira/browse/HADOOP-16559 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Vinayakumar B >Assignee: Duo Zhang >Priority: Major > > Use "protoc-maven-plugin" to dynamically download protobuf executable to > generate protobuf classes from proto file -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16559) [HDFS] use protobuf-maven-plugin to generate protobuf classes
[ https://issues.apache.org/jira/browse/HADOOP-16559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935055#comment-16935055 ] Ayush Saxena commented on HADOOP-16559: --- Seems this has been already covered as part of : https://github.com/apache/hadoop/pull/1494/ > [HDFS] use protobuf-maven-plugin to generate protobuf classes > - > > Key: HADOOP-16559 > URL: https://issues.apache.org/jira/browse/HADOOP-16559 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Vinayakumar B >Assignee: Duo Zhang >Priority: Major > > Use "protoc-maven-plugin" to dynamically download protobuf executable to > generate protobuf classes from proto file -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
