subject:"\[jira\] \[Commented\] \(HADOOP\-18360\) Update commons\-csv from 1.0 to 1.9.0."

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

2022-10-16 Thread Ayush Saxena (Jira)



[ 
https://issues.apache.org/jira/browse/HADOOP-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17618420#comment-17618420
 ] 

Ayush Saxena commented on HADOOP-18360:
---

I cherry-picked to 3.3 & 3.3.5. Thanx Everyone!!!

> Update commons-csv from 1.0 to 1.9.0.
> -
>
> Key: HADOOP-18360
> URL: https://issues.apache.org/jira/browse/HADOOP-18360
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: common
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.4.0, 3.3.5
>
>
> commons-csv 1.0 is a very old jar, mvnrepository shows this jar as the 2014 
> version, I have compiled and tested locally, I think this jar can be upgraded 
> to commons-csv 1.9 version.
> The link to the release note is as follows:
> [https://commons.apache.org/proper/commons-csv/changes-report.html]
> We can see that the new version fixes some issues.
> I read the code used, we use header related methods. We found that many 
> header-related methods have been upgraded.
> *Release 1.1 – 2014-11-16*
> CSVFormat#withHeader doesn't work well with #printComment, add 
> withHeaderComments(String...).
> CSVFormat.EXCEL should ignore empty header names.
> *Release 1.2 – 2015-08-24*
> CSVFormat.with* methods clear the header comments.
> *Release 1.3 – 2016-05-09*
> Add shortcut method for using first record as header to CSVFormat.
> Add withHeader(Class) to CSVFormat.
> CSVPrinter doesn't skip creation of header record if skipHeaderRecord is set 
> to true.
> Add IgnoreCase option for accessing header names.
> *Release 1.5 – 2017-09-03*
> Fix incorrect method name 'withFirstRowAsHeader' in user guide.
> *Release 1.7 – 2019-06-01*
> Cannot get headers in column order from CSVRecord.
> *Release 1.8 – 2020-02-01*
> CSVFormat#validate() does not account for allowDuplicateHeaderNames.
> A single empty header is allowed when not allowing empty column headers.
> *Release 1.9.0 – 2020-07-24*
> Add possibility to use ResultSet header meta data as CSV header.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

2022-10-13 Thread Ayush Saxena (Jira)



[ 
https://issues.apache.org/jira/browse/HADOOP-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617421#comment-17617421
 ] 

Ayush Saxena commented on HADOOP-18360:
---

Nopes, [~slfan1989] can you raise a backport PR to trigger the tests?

> Update commons-csv from 1.0 to 1.9.0.
> -
>
> Key: HADOOP-18360
> URL: https://issues.apache.org/jira/browse/HADOOP-18360
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: common
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.4.0
>
>
> commons-csv 1.0 is a very old jar, mvnrepository shows this jar as the 2014 
> version, I have compiled and tested locally, I think this jar can be upgraded 
> to commons-csv 1.9 version.
> The link to the release note is as follows:
> [https://commons.apache.org/proper/commons-csv/changes-report.html]
> We can see that the new version fixes some issues.
> I read the code used, we use header related methods. We found that many 
> header-related methods have been upgraded.
> *Release 1.1 – 2014-11-16*
> CSVFormat#withHeader doesn't work well with #printComment, add 
> withHeaderComments(String...).
> CSVFormat.EXCEL should ignore empty header names.
> *Release 1.2 – 2015-08-24*
> CSVFormat.with* methods clear the header comments.
> *Release 1.3 – 2016-05-09*
> Add shortcut method for using first record as header to CSVFormat.
> Add withHeader(Class) to CSVFormat.
> CSVPrinter doesn't skip creation of header record if skipHeaderRecord is set 
> to true.
> Add IgnoreCase option for accessing header names.
> *Release 1.5 – 2017-09-03*
> Fix incorrect method name 'withFirstRowAsHeader' in user guide.
> *Release 1.7 – 2019-06-01*
> Cannot get headers in column order from CSVRecord.
> *Release 1.8 – 2020-02-01*
> CSVFormat#validate() does not account for allowDuplicateHeaderNames.
> A single empty header is allowed when not allowing empty column headers.
> *Release 1.9.0 – 2020-07-24*
> Add possibility to use ResultSet header meta data as CSV header.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

2022-10-13 Thread Steve Loughran (Jira)



[ 
https://issues.apache.org/jira/browse/HADOOP-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616921#comment-17616921
 ] 

Steve Loughran commented on HADOOP-18360:
-

any reason not to pull into 3.3.5; im trying to get it up to date with as much 
of the transitive versions as possible, without breaking too much

> Update commons-csv from 1.0 to 1.9.0.
> -
>
> Key: HADOOP-18360
> URL: https://issues.apache.org/jira/browse/HADOOP-18360
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: common
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.4.0
>
>
> commons-csv 1.0 is a very old jar, mvnrepository shows this jar as the 2014 
> version, I have compiled and tested locally, I think this jar can be upgraded 
> to commons-csv 1.9 version.
> The link to the release note is as follows:
> [https://commons.apache.org/proper/commons-csv/changes-report.html]
> We can see that the new version fixes some issues.
> I read the code used, we use header related methods. We found that many 
> header-related methods have been upgraded.
> *Release 1.1 – 2014-11-16*
> CSVFormat#withHeader doesn't work well with #printComment, add 
> withHeaderComments(String...).
> CSVFormat.EXCEL should ignore empty header names.
> *Release 1.2 – 2015-08-24*
> CSVFormat.with* methods clear the header comments.
> *Release 1.3 – 2016-05-09*
> Add shortcut method for using first record as header to CSVFormat.
> Add withHeader(Class) to CSVFormat.
> CSVPrinter doesn't skip creation of header record if skipHeaderRecord is set 
> to true.
> Add IgnoreCase option for accessing header names.
> *Release 1.5 – 2017-09-03*
> Fix incorrect method name 'withFirstRowAsHeader' in user guide.
> *Release 1.7 – 2019-06-01*
> Cannot get headers in column order from CSVRecord.
> *Release 1.8 – 2020-02-01*
> CSVFormat#validate() does not account for allowDuplicateHeaderNames.
> A single empty header is allowed when not allowing empty column headers.
> *Release 1.9.0 – 2020-07-24*
> Add possibility to use ResultSet header meta data as CSV header.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

2022-10-13 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/HADOOP-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616832#comment-17616832
 ] 

ASF GitHub Bot commented on HADOOP-18360:
-

slfan1989 commented on PR #4928:
URL: https://github.com/apache/hadoop/pull/4928#issuecomment-1277156262

   @ayushtkn Thank you very much for your help to review the code and merge the 
code!




> Update commons-csv from 1.0 to 1.9.0.
> -
>
> Key: HADOOP-18360
> URL: https://issues.apache.org/jira/browse/HADOOP-18360
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: common
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.4.0
>
>
> commons-csv 1.0 is a very old jar, mvnrepository shows this jar as the 2014 
> version, I have compiled and tested locally, I think this jar can be upgraded 
> to commons-csv 1.9 version.
> The link to the release note is as follows:
> [https://commons.apache.org/proper/commons-csv/changes-report.html]
> We can see that the new version fixes some issues.
> I read the code used, we use header related methods. We found that many 
> header-related methods have been upgraded.
> *Release 1.1 – 2014-11-16*
> CSVFormat#withHeader doesn't work well with #printComment, add 
> withHeaderComments(String...).
> CSVFormat.EXCEL should ignore empty header names.
> *Release 1.2 – 2015-08-24*
> CSVFormat.with* methods clear the header comments.
> *Release 1.3 – 2016-05-09*
> Add shortcut method for using first record as header to CSVFormat.
> Add withHeader(Class) to CSVFormat.
> CSVPrinter doesn't skip creation of header record if skipHeaderRecord is set 
> to true.
> Add IgnoreCase option for accessing header names.
> *Release 1.5 – 2017-09-03*
> Fix incorrect method name 'withFirstRowAsHeader' in user guide.
> *Release 1.7 – 2019-06-01*
> Cannot get headers in column order from CSVRecord.
> *Release 1.8 – 2020-02-01*
> CSVFormat#validate() does not account for allowDuplicateHeaderNames.
> A single empty header is allowed when not allowing empty column headers.
> *Release 1.9.0 – 2020-07-24*
> Add possibility to use ResultSet header meta data as CSV header.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

2022-10-12 Thread Ayush Saxena (Jira)



[ 
https://issues.apache.org/jira/browse/HADOOP-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616807#comment-17616807
 ] 

Ayush Saxena commented on HADOOP-18360:
---

Committed to trunk.

Thanx [~slfan1989] for the contribution!!!

> Update commons-csv from 1.0 to 1.9.0.
> -
>
> Key: HADOOP-18360
> URL: https://issues.apache.org/jira/browse/HADOOP-18360
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: common
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Minor
>  Labels: pull-request-available
>
> commons-csv 1.0 is a very old jar, mvnrepository shows this jar as the 2014 
> version, I have compiled and tested locally, I think this jar can be upgraded 
> to commons-csv 1.9 version.
> The link to the release note is as follows:
> [https://commons.apache.org/proper/commons-csv/changes-report.html]
> We can see that the new version fixes some issues.
> I read the code used, we use header related methods. We found that many 
> header-related methods have been upgraded.
> *Release 1.1 – 2014-11-16*
> CSVFormat#withHeader doesn't work well with #printComment, add 
> withHeaderComments(String...).
> CSVFormat.EXCEL should ignore empty header names.
> *Release 1.2 – 2015-08-24*
> CSVFormat.with* methods clear the header comments.
> *Release 1.3 – 2016-05-09*
> Add shortcut method for using first record as header to CSVFormat.
> Add withHeader(Class) to CSVFormat.
> CSVPrinter doesn't skip creation of header record if skipHeaderRecord is set 
> to true.
> Add IgnoreCase option for accessing header names.
> *Release 1.5 – 2017-09-03*
> Fix incorrect method name 'withFirstRowAsHeader' in user guide.
> *Release 1.7 – 2019-06-01*
> Cannot get headers in column order from CSVRecord.
> *Release 1.8 – 2020-02-01*
> CSVFormat#validate() does not account for allowDuplicateHeaderNames.
> A single empty header is allowed when not allowing empty column headers.
> *Release 1.9.0 – 2020-07-24*
> Add possibility to use ResultSet header meta data as CSV header.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

2022-10-12 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/HADOOP-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616806#comment-17616806
 ] 

ASF GitHub Bot commented on HADOOP-18360:
-

ayushtkn merged PR #4928:
URL: https://github.com/apache/hadoop/pull/4928




> Update commons-csv from 1.0 to 1.9.0.
> -
>
> Key: HADOOP-18360
> URL: https://issues.apache.org/jira/browse/HADOOP-18360
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: common
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Minor
>  Labels: pull-request-available
>
> commons-csv 1.0 is a very old jar, mvnrepository shows this jar as the 2014 
> version, I have compiled and tested locally, I think this jar can be upgraded 
> to commons-csv 1.9 version.
> The link to the release note is as follows:
> [https://commons.apache.org/proper/commons-csv/changes-report.html]
> We can see that the new version fixes some issues.
> I read the code used, we use header related methods. We found that many 
> header-related methods have been upgraded.
> *Release 1.1 – 2014-11-16*
> CSVFormat#withHeader doesn't work well with #printComment, add 
> withHeaderComments(String...).
> CSVFormat.EXCEL should ignore empty header names.
> *Release 1.2 – 2015-08-24*
> CSVFormat.with* methods clear the header comments.
> *Release 1.3 – 2016-05-09*
> Add shortcut method for using first record as header to CSVFormat.
> Add withHeader(Class) to CSVFormat.
> CSVPrinter doesn't skip creation of header record if skipHeaderRecord is set 
> to true.
> Add IgnoreCase option for accessing header names.
> *Release 1.5 – 2017-09-03*
> Fix incorrect method name 'withFirstRowAsHeader' in user guide.
> *Release 1.7 – 2019-06-01*
> Cannot get headers in column order from CSVRecord.
> *Release 1.8 – 2020-02-01*
> CSVFormat#validate() does not account for allowDuplicateHeaderNames.
> A single empty header is allowed when not allowing empty column headers.
> *Release 1.9.0 – 2020-07-24*
> Add possibility to use ResultSet header meta data as CSV header.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

2022-10-12 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/HADOOP-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616784#comment-17616784
 ] 

ASF GitHub Bot commented on HADOOP-18360:
-

slfan1989 commented on PR #4928:
URL: https://github.com/apache/hadoop/pull/4928#issuecomment-1277066147

   @ayushtkn Thanks a lot for your help reviewing the code, I double checked 
the commons-csv version upgrade (1.0 to 1.9.0) and it should work. The junit 
test error has nothing to do with the upgrade.




> Update commons-csv from 1.0 to 1.9.0.
> -
>
> Key: HADOOP-18360
> URL: https://issues.apache.org/jira/browse/HADOOP-18360
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: common
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Minor
>  Labels: pull-request-available
>
> commons-csv 1.0 is a very old jar, mvnrepository shows this jar as the 2014 
> version, I have compiled and tested locally, I think this jar can be upgraded 
> to commons-csv 1.9 version.
> The link to the release note is as follows:
> [https://commons.apache.org/proper/commons-csv/changes-report.html]
> We can see that the new version fixes some issues.
> I read the code used, we use header related methods. We found that many 
> header-related methods have been upgraded.
> *Release 1.1 – 2014-11-16*
> CSVFormat#withHeader doesn't work well with #printComment, add 
> withHeaderComments(String...).
> CSVFormat.EXCEL should ignore empty header names.
> *Release 1.2 – 2015-08-24*
> CSVFormat.with* methods clear the header comments.
> *Release 1.3 – 2016-05-09*
> Add shortcut method for using first record as header to CSVFormat.
> Add withHeader(Class) to CSVFormat.
> CSVPrinter doesn't skip creation of header record if skipHeaderRecord is set 
> to true.
> Add IgnoreCase option for accessing header names.
> *Release 1.5 – 2017-09-03*
> Fix incorrect method name 'withFirstRowAsHeader' in user guide.
> *Release 1.7 – 2019-06-01*
> Cannot get headers in column order from CSVRecord.
> *Release 1.8 – 2020-02-01*
> CSVFormat#validate() does not account for allowDuplicateHeaderNames.
> A single empty header is allowed when not allowing empty column headers.
> *Release 1.9.0 – 2020-07-24*
> Add possibility to use ResultSet header meta data as CSV header.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

2022-10-12 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/HADOOP-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616748#comment-17616748
 ] 

ASF GitHub Bot commented on HADOOP-18360:
-

hadoop-yetus commented on PR #4928:
URL: https://github.com/apache/hadoop/pull/4928#issuecomment-1276932902

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 53s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  1s |  |  xmllint was not available.  |
   | +0 :ok: |  shelldocs  |   0m  1s |  |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  15m 19s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  32m 30s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  31m 46s |  |  trunk passed with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  compile  |  22m 11s |  |  trunk passed with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  checkstyle  |   4m 25s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |  20m 31s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   8m 29s |  |  trunk passed with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   7m 32s |  |  trunk passed with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07  |
   | +0 :ok: |  spotbugs  |   0m 24s |  |  branch/hadoop-project no spotbugs 
output file (spotbugsXml.xml)  |
   | +1 :green_heart: |  shadedclient  |  58m 31s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 27s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  25m 49s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  25m  0s |  |  the patch passed with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javac  |  25m  0s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  22m  1s |  |  the patch passed with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  javac  |  22m  1s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   4m 15s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |  20m 53s |  |  the patch passed  |
   | +1 :green_heart: |  shellcheck  |   0m  0s |  |  No new issues.  |
   | +1 :green_heart: |  javadoc  |   8m 53s |  |  the patch passed with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   8m  0s |  |  the patch passed with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07  |
   | +0 :ok: |  spotbugs  |   0m 23s |  |  hadoop-project has no data from 
spotbugs  |
   | +1 :green_heart: |  shadedclient  |  59m  5s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | -1 :x: |  unit  | 1021m 25s | 
[/patch-unit-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4928/5/artifact/out/patch-unit-root.txt)
 |  root in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   2m  2s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 1408m  7s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hdfs.rbfbalance.TestRouterDistCpProcedure |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4928/5/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/4928 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle 
shellcheck shelldocs |
   | uname | Linux 4fe0f10ef2db 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 
01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / bb866f1daba1e8af40316d7bb7101eb5712ccaba |
   | Default Java | Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-o

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

2022-10-09 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/HADOOP-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17614879#comment-17614879
 ] 

ASF GitHub Bot commented on HADOOP-18360:
-

slfan1989 commented on PR #4928:
URL: https://github.com/apache/hadoop/pull/4928#issuecomment-1272784477

   > 
   
   Thank you very much for your help reviewing the code!




> Update commons-csv from 1.0 to 1.9.0.
> -
>
> Key: HADOOP-18360
> URL: https://issues.apache.org/jira/browse/HADOOP-18360
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: common
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Minor
>  Labels: pull-request-available
>
> commons-csv 1.0 is a very old jar, mvnrepository shows this jar as the 2014 
> version, I have compiled and tested locally, I think this jar can be upgraded 
> to commons-csv 1.9 version.
> The link to the release note is as follows:
> [https://commons.apache.org/proper/commons-csv/changes-report.html]
> We can see that the new version fixes some issues.
> I read the code used, we use header related methods. We found that many 
> header-related methods have been upgraded.
> *Release 1.1 – 2014-11-16*
> CSVFormat#withHeader doesn't work well with #printComment, add 
> withHeaderComments(String...).
> CSVFormat.EXCEL should ignore empty header names.
> *Release 1.2 – 2015-08-24*
> CSVFormat.with* methods clear the header comments.
> *Release 1.3 – 2016-05-09*
> Add shortcut method for using first record as header to CSVFormat.
> Add withHeader(Class) to CSVFormat.
> CSVPrinter doesn't skip creation of header record if skipHeaderRecord is set 
> to true.
> Add IgnoreCase option for accessing header names.
> *Release 1.5 – 2017-09-03*
> Fix incorrect method name 'withFirstRowAsHeader' in user guide.
> *Release 1.7 – 2019-06-01*
> Cannot get headers in column order from CSVRecord.
> *Release 1.8 – 2020-02-01*
> CSVFormat#validate() does not account for allowDuplicateHeaderNames.
> A single empty header is allowed when not allowing empty column headers.
> *Release 1.9.0 – 2020-07-24*
> Add possibility to use ResultSet header meta data as CSV header.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

2022-10-08 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/HADOOP-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17614499#comment-17614499
 ] 

ASF GitHub Bot commented on HADOOP-18360:
-

slfan1989 commented on PR #4928:
URL: https://github.com/apache/hadoop/pull/4928#issuecomment-1272339219

   @ayushtkn Can you help review this pr? I think an upgrade is still 
necessary. For the deprecated method, I also made a replacement.




> Update commons-csv from 1.0 to 1.9.0.
> -
>
> Key: HADOOP-18360
> URL: https://issues.apache.org/jira/browse/HADOOP-18360
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: common
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Minor
>  Labels: pull-request-available
>
> commons-csv 1.0 is a very old jar, mvnrepository shows this jar as the 2014 
> version, I have compiled and tested locally, I think this jar can be upgraded 
> to commons-csv 1.9 version.
> The link to the release note is as follows:
> [https://commons.apache.org/proper/commons-csv/changes-report.html]
> We can see that the new version fixes some issues.
> I read the code used, we use header related methods. We found that many 
> header-related methods have been upgraded.
> *Release 1.1 – 2014-11-16*
> CSVFormat#withHeader doesn't work well with #printComment, add 
> withHeaderComments(String...).
> CSVFormat.EXCEL should ignore empty header names.
> *Release 1.2 – 2015-08-24*
> CSVFormat.with* methods clear the header comments.
> *Release 1.3 – 2016-05-09*
> Add shortcut method for using first record as header to CSVFormat.
> Add withHeader(Class) to CSVFormat.
> CSVPrinter doesn't skip creation of header record if skipHeaderRecord is set 
> to true.
> Add IgnoreCase option for accessing header names.
> *Release 1.5 – 2017-09-03*
> Fix incorrect method name 'withFirstRowAsHeader' in user guide.
> *Release 1.7 – 2019-06-01*
> Cannot get headers in column order from CSVRecord.
> *Release 1.8 – 2020-02-01*
> CSVFormat#validate() does not account for allowDuplicateHeaderNames.
> A single empty header is allowed when not allowing empty column headers.
> *Release 1.9.0 – 2020-07-24*
> Add possibility to use ResultSet header meta data as CSV header.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

2022-10-07 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/HADOOP-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17614208#comment-17614208
 ] 

ASF GitHub Bot commented on HADOOP-18360:
-

hadoop-yetus commented on PR #4928:
URL: https://github.com/apache/hadoop/pull/4928#issuecomment-1271949625

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 35s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  1s |  |  xmllint was not available.  |
   | +0 :ok: |  shelldocs  |   0m  1s |  |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  15m 35s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  25m 55s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  23m 10s |  |  trunk passed with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  compile  |  20m 39s |  |  trunk passed with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  checkstyle  |   4m 28s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |  19m 33s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   8m  3s |  |  trunk passed with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   7m 28s |  |  trunk passed with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07  |
   | +0 :ok: |  spotbugs  |   0m 30s |  |  branch/hadoop-project no spotbugs 
output file (spotbugsXml.xml)  |
   | +1 :green_heart: |  shadedclient  |  53m 14s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 33s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  23m  0s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  22m 49s |  |  the patch passed with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javac  |  22m 49s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  20m 48s |  |  the patch passed with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  javac  |  20m 48s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   4m  1s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |  19m  5s |  |  the patch passed  |
   | +1 :green_heart: |  shellcheck  |   0m  0s |  |  No new issues.  |
   | +1 :green_heart: |  javadoc  |   7m 54s |  |  the patch passed with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   7m 25s |  |  the patch passed with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07  |
   | +0 :ok: |  spotbugs  |   0m 25s |  |  hadoop-project has no data from 
spotbugs  |
   | +1 :green_heart: |  shadedclient  |  52m 41s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | -1 :x: |  unit  | 801m  9s | 
[/patch-unit-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4928/4/artifact/out/patch-unit-root.txt)
 |  root in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   2m 13s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 1152m 33s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hdfs.TestRollingUpgrade |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4928/4/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/4928 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle 
shellcheck shelldocs |
   | uname | Linux 62b81715be3f 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 
01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / f2a97c745430363efb0b06352ca32f8b82797ce3 |
   | Default Java | Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

2022-10-05 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/HADOOP-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17613167#comment-17613167
 ] 

ASF GitHub Bot commented on HADOOP-18360:
-

hadoop-yetus commented on PR #4928:
URL: https://github.com/apache/hadoop/pull/4928#issuecomment-1265088527

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   1m  4s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  1s |  |  xmllint was not available.  |
   | +0 :ok: |  shelldocs  |   0m  1s |  |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  15m 28s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  29m 47s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  25m 37s |  |  trunk passed with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  compile  |  22m  2s |  |  trunk passed with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  checkstyle  |   4m 23s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |  20m 36s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   8m 34s |  |  trunk passed with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   7m 39s |  |  trunk passed with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07  |
   | +0 :ok: |  spotbugs  |   0m 24s |  |  branch/hadoop-project no spotbugs 
output file (spotbugsXml.xml)  |
   | +1 :green_heart: |  shadedclient  |  70m  0s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 29s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  26m  9s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  24m 58s |  |  the patch passed with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javac  |  24m 58s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  22m 12s |  |  the patch passed with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  javac  |  22m 12s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   4m 15s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |  20m  7s |  |  the patch passed  |
   | +1 :green_heart: |  shellcheck  |   0m  0s |  |  No new issues.  |
   | +1 :green_heart: |  javadoc  |   8m 23s |  |  the patch passed with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   7m 45s |  |  the patch passed with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07  |
   | +0 :ok: |  spotbugs  |   0m 23s |  |  hadoop-project has no data from 
spotbugs  |
   | +1 :green_heart: |  shadedclient  |  59m 13s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | -1 :x: |  unit  | 1017m  3s | 
[/patch-unit-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4928/3/artifact/out/patch-unit-root.txt)
 |  root in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   2m  1s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 1405m 33s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hdfs.server.mover.TestMover |
   |   | hadoop.hdfs.server.namenode.ha.TestObserverNode |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4928/3/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/4928 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle 
shellcheck shelldocs |
   | uname | Linux 2afb681928bf 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 
01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 1d839b6724a934007d48cbc0881464fff1abd8cf |
   | Default Java | Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 |
   |

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

2022-10-05 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/HADOOP-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17613148#comment-17613148
 ] 

ASF GitHub Bot commented on HADOOP-18360:
-

slfan1989 commented on PR #4928:
URL: https://github.com/apache/hadoop/pull/4928#issuecomment-1264773924

   @ayushtkn Can you help review this pr? I think an upgrade is still 
necessary.  For the deprecated method, I also made a replacement.




> Update commons-csv from 1.0 to 1.9.0.
> -
>
> Key: HADOOP-18360
> URL: https://issues.apache.org/jira/browse/HADOOP-18360
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: common
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Minor
>  Labels: pull-request-available
>
> commons-csv 1.0 is a very old jar, mvnrepository shows this jar as the 2014 
> version, I have compiled and tested locally, I think this jar can be upgraded 
> to commons-csv 1.9 version.
> The link to the release note is as follows:
> [https://commons.apache.org/proper/commons-csv/changes-report.html]
> We can see that the new version fixes some issues.
> I read the code used, we use header related methods. We found that many 
> header-related methods have been upgraded.
> *Release 1.1 – 2014-11-16*
> CSVFormat#withHeader doesn't work well with #printComment, add 
> withHeaderComments(String...).
> CSVFormat.EXCEL should ignore empty header names.
> *Release 1.2 – 2015-08-24*
> CSVFormat.with* methods clear the header comments.
> *Release 1.3 – 2016-05-09*
> Add shortcut method for using first record as header to CSVFormat.
> Add withHeader(Class) to CSVFormat.
> CSVPrinter doesn't skip creation of header record if skipHeaderRecord is set 
> to true.
> Add IgnoreCase option for accessing header names.
> *Release 1.5 – 2017-09-03*
> Fix incorrect method name 'withFirstRowAsHeader' in user guide.
> *Release 1.7 – 2019-06-01*
> Cannot get headers in column order from CSVRecord.
> *Release 1.8 – 2020-02-01*
> CSVFormat#validate() does not account for allowDuplicateHeaderNames.
> A single empty header is allowed when not allowing empty column headers.
> *Release 1.9.0 – 2020-07-24*
> Add possibility to use ResultSet header meta data as CSV header.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

2022-09-26 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/HADOOP-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609765#comment-17609765
 ] 

ASF GitHub Bot commented on HADOOP-18360:
-

hadoop-yetus commented on PR #4928:
URL: https://github.com/apache/hadoop/pull/4928#issuecomment-1258829578

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 48s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +0 :ok: |  shelldocs  |   0m  0s |  |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  15m 18s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  28m 44s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  25m 31s |  |  trunk passed with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  compile  |  22m  8s |  |  trunk passed with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  mvnsite  |  20m 34s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   8m 36s |  |  trunk passed with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   7m 34s |  |  trunk passed with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  shadedclient  |  39m 32s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 26s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  25m 35s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  24m 56s |  |  the patch passed with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04  |
   | -1 :x: |  javac  |  24m 56s | 
[/results-compile-javac-root-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4928/2/artifact/out/results-compile-javac-root-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt)
 |  root-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 2 new + 2840 unchanged - 0 
fixed = 2842 total (was 2840)  |
   | +1 :green_heart: |  compile  |  22m  1s |  |  the patch passed with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07  |
   | -1 :x: |  javac  |  22m  1s | 
[/results-compile-javac-root-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4928/2/artifact/out/results-compile-javac-root-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt)
 |  root-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 generated 2 new + 2638 
unchanged - 0 fixed = 2640 total (was 2638)  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  mvnsite  |  20m  7s |  |  the patch passed  |
   | +1 :green_heart: |  shellcheck  |   0m  0s |  |  No new issues.  |
   | +1 :green_heart: |  javadoc  |   8m 21s |  |  the patch passed with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   7m 41s |  |  the patch passed with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  shadedclient  |  40m 23s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  | 1086m 17s |  |  root in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   2m 36s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 1378m  5s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4928/2/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/4928 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs |
   | uname | Linux bacb93d35973 4.15.0-191-generic #202-Ubuntu SMP Thu Aug

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

2022-09-23 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/HADOOP-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608941#comment-17608941
 ] 

ASF GitHub Bot commented on HADOOP-18360:
-

hadoop-yetus commented on PR #4928:
URL: https://github.com/apache/hadoop/pull/4928#issuecomment-1256846247

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 53s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  1s |  |  xmllint was not available.  |
   | +0 :ok: |  shelldocs  |   0m  1s |  |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  15m  2s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  29m  0s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  25m 35s |  |  trunk passed with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  compile  |  22m  4s |  |  trunk passed with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  mvnsite  |  20m 26s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   8m 34s |  |  trunk passed with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   7m 40s |  |  trunk passed with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  shadedclient  |  39m 16s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 27s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  25m 32s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  24m 52s |  |  the patch passed with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04  |
   | -1 :x: |  javac  |  24m 52s | 
[/results-compile-javac-root-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4928/1/artifact/out/results-compile-javac-root-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt)
 |  root-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 2 new + 2840 unchanged - 0 
fixed = 2842 total (was 2840)  |
   | +1 :green_heart: |  compile  |  22m 48s |  |  the patch passed with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07  |
   | -1 :x: |  javac  |  22m 48s | 
[/results-compile-javac-root-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4928/1/artifact/out/results-compile-javac-root-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt)
 |  root-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 generated 2 new + 2638 
unchanged - 0 fixed = 2640 total (was 2638)  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  mvnsite  |  20m 31s |  |  the patch passed  |
   | +1 :green_heart: |  shellcheck  |   0m  0s |  |  No new issues.  |
   | +1 :green_heart: |  javadoc  |   8m 46s |  |  the patch passed with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   7m 41s |  |  the patch passed with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  shadedclient  |  40m 48s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | -1 :x: |  unit  | 1000m 23s | 
[/patch-unit-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4928/1/artifact/out/patch-unit-root.txt)
 |  root in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   2m 10s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 1292m 47s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hdfs.server.namenode.ha.TestObserverNode |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4928/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hado

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

2022-09-22 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/HADOOP-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608553#comment-17608553
 ] 

ASF GitHub Bot commented on HADOOP-18360:
-

slfan1989 opened a new pull request, #4928:
URL: https://github.com/apache/hadoop/pull/4928

   JIRA: HADOOP-18360. Update commons-csv from 1.0 to 1.9.0.




> Update commons-csv from 1.0 to 1.9.0.
> -
>
> Key: HADOOP-18360
> URL: https://issues.apache.org/jira/browse/HADOOP-18360
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: common
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

16 matches

Site Navigation

Mail list logo

Footer information