[jira] [Commented] (HADOOP-8624) ProtobufRpcEngine should log all RPCs if TRACE logging is enabled
[ https://issues.apache.org/jira/browse/HADOOP-8624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449042#comment-13449042 ] Eli Collins commented on HADOOP-8624: - This can be closed right? > ProtobufRpcEngine should log all RPCs if TRACE logging is enabled > - > > Key: HADOOP-8624 > URL: https://issues.apache.org/jira/browse/HADOOP-8624 > Project: Hadoop Common > Issue Type: Improvement > Components: ipc >Affects Versions: 3.0.0, 2.2.0-alpha >Reporter: Todd Lipcon >Assignee: Todd Lipcon >Priority: Minor > Attachments: hadoop-8624.txt > > > Since all RPC requests/responses are now ProtoBufs, it's easy to add a TRACE > level logging output for ProtobufRpcEngine that actually shows the full > content of all calls. This is very handy especially when writing/debugging > unit tests, but might also be useful to enable at runtime for short periods > of time to debug certain production issues. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8624) ProtobufRpcEngine should log all RPCs if TRACE logging is enabled
[ https://issues.apache.org/jira/browse/HADOOP-8624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423321#comment-13423321 ] Todd Lipcon commented on HADOOP-8624: - The javadoc output must be unrelated - it says I fixed 2 warnings, but I didn't modify any javadoc in this patch at all. I'll commit this momentarily. > ProtobufRpcEngine should log all RPCs if TRACE logging is enabled > - > > Key: HADOOP-8624 > URL: https://issues.apache.org/jira/browse/HADOOP-8624 > Project: Hadoop Common > Issue Type: Improvement > Components: ipc >Affects Versions: 3.0.0, 2.2.0-alpha >Reporter: Todd Lipcon >Assignee: Todd Lipcon >Priority: Minor > Attachments: hadoop-8624.txt > > > Since all RPC requests/responses are now ProtoBufs, it's easy to add a TRACE > level logging output for ProtobufRpcEngine that actually shows the full > content of all calls. This is very handy especially when writing/debugging > unit tests, but might also be useful to enable at runtime for short periods > of time to debug certain production issues. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8624) ProtobufRpcEngine should log all RPCs if TRACE logging is enabled
[ https://issues.apache.org/jira/browse/HADOOP-8624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422937#comment-13422937 ] Aaron T. Myers commented on HADOOP-8624: +1, the patch looks good to me. I'm confident that the test failure is unrelated. The javadoc warning is a little curious, though. Any explanation for that? > ProtobufRpcEngine should log all RPCs if TRACE logging is enabled > - > > Key: HADOOP-8624 > URL: https://issues.apache.org/jira/browse/HADOOP-8624 > Project: Hadoop Common > Issue Type: Improvement > Components: ipc >Affects Versions: 3.0.0, 2.2.0-alpha >Reporter: Todd Lipcon >Assignee: Todd Lipcon >Priority: Minor > Attachments: hadoop-8624.txt > > > Since all RPC requests/responses are now ProtoBufs, it's easy to add a TRACE > level logging output for ProtobufRpcEngine that actually shows the full > content of all calls. This is very handy especially when writing/debugging > unit tests, but might also be useful to enable at runtime for short periods > of time to debug certain production issues. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8624) ProtobufRpcEngine should log all RPCs if TRACE logging is enabled
[ https://issues.apache.org/jira/browse/HADOOP-8624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422813#comment-13422813 ] Hadoop QA commented on HADOOP-8624: --- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12537936/hadoop-8624.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 javadoc. The javadoc tool appears to have generated -2 warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.ha.TestZKFailoverController +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1221//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1221//console This message is automatically generated. > ProtobufRpcEngine should log all RPCs if TRACE logging is enabled > - > > Key: HADOOP-8624 > URL: https://issues.apache.org/jira/browse/HADOOP-8624 > Project: Hadoop Common > Issue Type: Improvement > Components: ipc >Affects Versions: 3.0.0, 2.2.0-alpha >Reporter: Todd Lipcon >Assignee: Todd Lipcon >Priority: Minor > Attachments: hadoop-8624.txt > > > Since all RPC requests/responses are now ProtoBufs, it's easy to add a TRACE > level logging output for ProtobufRpcEngine that actually shows the full > content of all calls. This is very handy especially when writing/debugging > unit tests, but might also be useful to enable at runtime for short periods > of time to debug certain production issues. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
