[jira] [Updated] (HADOOP-13112) Change CredentialShell to use CommandShell base class

2016-05-23 Thread Allen Wittenauer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HADOOP-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated HADOOP-13112:
--
   Resolution: Fixed
Fix Version/s: 3.0.0-alpha1
   Status: Resolved  (was: Patch Available)

+1 committed to trunk

Thanks!

> Change CredentialShell to use CommandShell base class
> -
>
> Key: HADOOP-13112
> URL: https://issues.apache.org/jira/browse/HADOOP-13112
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Matthew Paduano
>Assignee: Matthew Paduano
>Priority: Minor
> Fix For: 3.0.0-alpha1
>
> Attachments: HADOOP-13112.01.patch, HADOOP-13112.02.patch, 
> HADOOP-13112.03.patch, HADOOP-13112.04.patch, HADOOP-13112.05.patch, 
> HADOOP-13112.06.patch
>
>
> org.apache.hadoop.tools.CommandShell is a base class created for use by 
> DtUtilShell.  It was inspired by CredentialShell and much of it was taken 
> verbatim.  It should be a simple change to get CredentialShell to use the 
> base class and simplify its code without changing its functionality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Updated] (HADOOP-13112) Change CredentialShell to use CommandShell base class

2016-05-23 Thread Matthew Paduano (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HADOOP-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matthew Paduano updated HADOOP-13112:
-
Attachment: HADOOP-13112.06.patch

patch #06 addresses findbugs.


for patch #06
{code}
---
T E S T S
---
Running org.apache.hadoop.crypto.key.TestKeyShell
 Tests run: 10, Failures: 0, Errors: 0, Skipped: 0
Running org.apache.hadoop.security.alias.TestCredShell
 Tests run: 12, Failures: 0, Errors: 0, Skipped: 0
Running org.apache.hadoop.security.token.TestDtUtilShell
 Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
Running org.apache.hadoop.tools.TestCommandShell
 Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
{code}

> Change CredentialShell to use CommandShell base class
> -
>
> Key: HADOOP-13112
> URL: https://issues.apache.org/jira/browse/HADOOP-13112
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Matthew Paduano
>Assignee: Matthew Paduano
>Priority: Minor
> Attachments: HADOOP-13112.01.patch, HADOOP-13112.02.patch, 
> HADOOP-13112.03.patch, HADOOP-13112.04.patch, HADOOP-13112.05.patch, 
> HADOOP-13112.06.patch
>
>
> org.apache.hadoop.tools.CommandShell is a base class created for use by 
> DtUtilShell.  It was inspired by CredentialShell and much of it was taken 
> verbatim.  It should be a simple change to get CredentialShell to use the 
> base class and simplify its code without changing its functionality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Updated] (HADOOP-13112) Change CredentialShell to use CommandShell base class

2016-05-19 Thread Matthew Paduano (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HADOOP-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matthew Paduano updated HADOOP-13112:
-
Attachment: HADOOP-13112.05.patch

for patch #05
{code}
---
 T E S T S
---
Running org.apache.hadoop.crypto.key.TestKeyShell
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.604 sec - in 
org.apache.hadoop.crypto.key.TestKeyShell
Running org.apache.hadoop.security.alias.TestCredShell
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.793 sec - in 
org.apache.hadoop.security.alias.TestCredShell
Running org.apache.hadoop.security.token.TestDtUtilShell
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.992 sec - in 
org.apache.hadoop.security.token.TestDtUtilShell
Running org.apache.hadoop.tools.TestCommandShell
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.112 sec - in 
org.apache.hadoop.tools.TestCommandShell
{code}

> Change CredentialShell to use CommandShell base class
> -
>
> Key: HADOOP-13112
> URL: https://issues.apache.org/jira/browse/HADOOP-13112
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Matthew Paduano
>Assignee: Matthew Paduano
>Priority: Minor
> Attachments: HADOOP-13112.01.patch, HADOOP-13112.02.patch, 
> HADOOP-13112.03.patch, HADOOP-13112.04.patch, HADOOP-13112.05.patch
>
>
> org.apache.hadoop.tools.CommandShell is a base class created for use by 
> DtUtilShell.  It was inspired by CredentialShell and much of it was taken 
> verbatim.  It should be a simple change to get CredentialShell to use the 
> base class and simplify its code without changing its functionality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Updated] (HADOOP-13112) Change CredentialShell to use CommandShell base class

2016-05-16 Thread Matthew Paduano (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HADOOP-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matthew Paduano updated HADOOP-13112:
-
Attachment: HADOOP-13112.04.patch

Patch 04 addresses the merge issue from HADOOP-12942

{code}
for patch #04:
 .../org/apache/hadoop/crypto/key/KeyShell.java |  180 +++-
 .../hadoop/security/alias/CredentialShell.java |  176 
 .../java/org/apache/hadoop/tools/CommandShell.java |4 
 3 files changed, 136 insertions(+), 224 deletions(-)
---
T E S T S
---
Running org.apache.hadoop.crypto.key.TestKeyShell
 Tests run: 10, Failures: 0, Errors: 0, Skipped: 0
Running org.apache.hadoop.security.alias.TestCredShell
 Tests run: 12, Failures: 0, Errors: 0, Skipped: 0
Running org.apache.hadoop.security.token.TestDtUtilShell
 Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
Running org.apache.hadoop.tools.TestCommandShell
 Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
Results: Tests run: 31, Failures: 0, Errors: 0, Skipped: 0
{code}

> Change CredentialShell to use CommandShell base class
> -
>
> Key: HADOOP-13112
> URL: https://issues.apache.org/jira/browse/HADOOP-13112
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Matthew Paduano
>Assignee: Matthew Paduano
>Priority: Minor
> Attachments: HADOOP-13112.01.patch, HADOOP-13112.02.patch, 
> HADOOP-13112.03.patch, HADOOP-13112.04.patch
>
>
> org.apache.hadoop.tools.CommandShell is a base class created for use by 
> DtUtilShell.  It was inspired by CredentialShell and much of it was taken 
> verbatim.  It should be a simple change to get CredentialShell to use the 
> base class and simplify its code without changing its functionality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Updated] (HADOOP-13112) Change CredentialShell to use CommandShell base class

2016-05-10 Thread Matthew Paduano (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HADOOP-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matthew Paduano updated HADOOP-13112:
-
Attachment: HADOOP-13112.03.patch

for patch #03
 .../org/apache/hadoop/crypto/key/KeyShell.java | 230 -
 .../hadoop/security/alias/CredentialShell.java | 155 +-
 .../java/org/apache/hadoop/tools/CommandShell.java |   4 +-
 3 files changed, 144 insertions(+), 245 deletions(-)
---
 T E S T S
---
Running org.apache.hadoop.crypto.key.TestKeyShell
  Tests run: 9, Failures: 0, Errors: 0, Skipped: 0
  Time elapsed: 1.308 sec
Running org.apache.hadoop.security.alias.TestCredShell
  Tests run: 9, Failures: 0, Errors: 0, Skipped: 0
  Time elapsed: 0.841 sec
Running org.apache.hadoop.security.token.TestDtUtilShell
  Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
  Time elapsed: 1.012 sec
Running org.apache.hadoop.tools.TestCommandShell
  Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
  Time elapsed: 0.128 sec
Results: Tests run: 27, Failures: 0, Errors: 0, Skipped: 0

> Change CredentialShell to use CommandShell base class
> -
>
> Key: HADOOP-13112
> URL: https://issues.apache.org/jira/browse/HADOOP-13112
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Matthew Paduano
>Assignee: Matthew Paduano
>Priority: Minor
> Attachments: HADOOP-13112.01.patch, HADOOP-13112.02.patch, 
> HADOOP-13112.03.patch
>
>
> org.apache.hadoop.tools.CommandShell is a base class created for use by 
> DtUtilShell.  It was inspired by CredentialShell and much of it was taken 
> verbatim.  It should be a simple change to get CredentialShell to use the 
> base class and simplify its code without changing its functionality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Updated] (HADOOP-13112) Change CredentialShell to use CommandShell base class

2016-05-08 Thread Matthew Paduano (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HADOOP-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matthew Paduano updated HADOOP-13112:
-
Attachment: HADOOP-13112.02.patch

this patch addresses check style warnings.

there are no unit tests b/c there is no new functionality
and existing tests pass and validate the functionality.

> Change CredentialShell to use CommandShell base class
> -
>
> Key: HADOOP-13112
> URL: https://issues.apache.org/jira/browse/HADOOP-13112
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Matthew Paduano
>Assignee: Matthew Paduano
>Priority: Minor
> Attachments: HADOOP-13112.01.patch, HADOOP-13112.02.patch
>
>
> org.apache.hadoop.tools.CommandShell is a base class created for use by 
> DtUtilShell.  It was inspired by CredentialShell and much of it was taken 
> verbatim.  It should be a simple change to get CredentialShell to use the 
> base class and simplify its code without changing its functionality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Updated] (HADOOP-13112) Change CredentialShell to use CommandShell base class

2016-05-06 Thread Matthew Paduano (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HADOOP-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matthew Paduano updated HADOOP-13112:
-
Status: Patch Available  (was: Open)


.../hadoop/security/alias/CredentialShell.java | 159 -
.../java/org/apache/hadoop/tools/CommandShell.java |   2 +-
2 files changed, 63 insertions(+), 98 deletions(-)

---
 T E S T S
---
Running org.apache.hadoop.security.alias.TestCredShell
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.22 sec - in 
org.apache.hadoop.security.alias.TestCredShell

Running org.apache.hadoop.security.token.TestDtUtilShell
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.014 sec - in 
org.apache.hadoop.security.token.TestDtUtilShell

Running org.apache.hadoop.tools.TestCommandShell
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.122 sec - in 
org.apache.hadoop.tools.TestCommandShell


> Change CredentialShell to use CommandShell base class
> -
>
> Key: HADOOP-13112
> URL: https://issues.apache.org/jira/browse/HADOOP-13112
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Matthew Paduano
>Assignee: Matthew Paduano
>Priority: Minor
> Attachments: HADOOP-13112.01.patch
>
>
> org.apache.hadoop.tools.CommandShell is a base class created for use by 
> DtUtilShell.  It was inspired by CredentialShell and much of it was taken 
> verbatim.  It should be a simple change to get CredentialShell to use the 
> base class and simplify its code without changing its functionality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Updated] (HADOOP-13112) Change CredentialShell to use CommandShell base class

2016-05-06 Thread Matthew Paduano (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HADOOP-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matthew Paduano updated HADOOP-13112:
-
Attachment: HADOOP-13112.01.patch

> Change CredentialShell to use CommandShell base class
> -
>
> Key: HADOOP-13112
> URL: https://issues.apache.org/jira/browse/HADOOP-13112
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Matthew Paduano
>Assignee: Matthew Paduano
>Priority: Minor
> Attachments: HADOOP-13112.01.patch
>
>
> org.apache.hadoop.tools.CommandShell is a base class created for use by 
> DtUtilShell.  It was inspired by CredentialShell and much of it was taken 
> verbatim.  It should be a simple change to get CredentialShell to use the 
> base class and simplify its code without changing its functionality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org