[Jelly] [Proposal] Jelly mailing list
Isn't it time Jelly got its own mailing list /now/, since traffic is more than high already? -- Nicola Ken Barozzi [EMAIL PROTECTED] - verba volant, scripta manent - (discussions get forgotten, just code remains) - -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [Jelly] [Proposal] Jelly mailing list
+1 I added filters locally only yesterday for this reason ;-) (And as I've said before, it should be jakarta-jelly, not commons-jelly...) Stephen - Original Message - From: robert burrell donkin [EMAIL PROTECTED] To: Jakarta Commons Developers List [EMAIL PROTECTED] Sent: Sunday, January 19, 2003 10:54 AM Subject: Re: [Jelly] [Proposal] Jelly mailing list +1 - robert On Sunday, January 19, 2003, at 10:44 AM, Nicola Ken Barozzi wrote: Isn't it time Jelly got its own mailing list /now/, since traffic is more than high already? -- Nicola Ken Barozzi [EMAIL PROTECTED] - verba volant, scripta manent - (discussions get forgotten, just code remains) - -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]. org For additional commands, e-mail: mailto:[EMAIL PROTECTED]. org -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: LinkedFastHashMap?
From: Henri Yandell [EMAIL PROTECTED] I've not looked at the code in question yet, but it feels like the wrong solution. Is it not possible for the existing SequencedHashMap to be able to wrap a FastHashMap? ie) SequencedHashMap.wrap(new FastHashMap()) which would override the map used internally by sequenced hash map. Essentially, that is what the code submitted tries to do. However, it often causes difficulties, because of the multitude of views that collections provide. 1) java.util.Map 2) org.apache.commons.collections.ProxyMap 3) java.util.HashMap 4) org.apache.commons.collections.FastHashMap [The hash denoting that it uses hashing for its mapping internally, and not some other structure] 5) org.apache.commons.collections.SequencedMap SequencedMap decorates any other map, so doesn''t matter if it's HashMap or FastHashMap or TreeMap. Same for any other 5)s. To some degree, I agree with what you're saying. However, the main problem is with backwards compatability in [collections]. FastHashMap currently extends HashMap FastTreeMap currently extends TreeMap SequencedHashMap currently implements Map directly, and stores data in a HashMap and LinkedList Both FastHashMap and FastTreeMap are essentially the same class, and _should_ be implemented as minimal subclasses extending an abstract AbstractFastMap. FastSequencedHashMap would then extend the abstract class too and take 5 seconds to implement. Unfortunately, the original designers of these classes chose to make them extend HashMap and TreeMap even though they make no use of the implementation. This is bad for memory use (unused variables) and bad for code reuse. Presumeably, it was deemed important to have the classes as drop in replacements that would function if someone used a cast to a HashMap/TreeMap. So, we could fix the design to have an AbstractFastMap (I did this yesterday, only to realise the problem...). But this breaks backwards compatability for some users. My comments on FastSequencedHashMap were thus based on consistency with the place we are in. Stephen -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Re:Re: [Betwixt] complex recursion
Thanx I'll have a look at it..
Mvgr,
Martin
On Sun, 2003-01-19 at 10:21, Emmanuel Venisse wrote:
Hi Martin,
I modify the test case, Element class and add Subelement.java and
recursion3.xml
Index: Element.java
===
RCS file:
/home/cvs/jakarta-commons/betwixt/src/test/org/apache/commons/betwixt/re
cursion/Element.java,v
retrieving revision 1.3
diff -r1.3 Element.java
75a76
ArrayList subelements;
84a86
subelements = new ArrayList();
112a115,124
public void addSubelement(Subelement subelement)
{
subelements.add(subelement);
}
public List getSubelements()
{
return subelements;
}
Index: TestRecursion.java
===
RCS file:
/home/cvs/jakarta-commons/betwixt/src/test/org/apache/commons/betwixt/re
cursion/TestRecursion.java,v
retrieving revision 1.6
diff -r1.6 TestRecursion.java
133a134,150
* This will test reading a complex recursive xml file
*/
public void testComplexReadWithoutCollectionsInElementRoundTrip()
throws Exception
{
System.out.println(\ntestComplexReadWithoutCollectionsInElement()\n);
XMLIntrospector intro = createXMLIntrospector();
BeanReader reader = new BeanReader();
reader.registerBeanClass(ElementBean.class);
reader.setXMLIntrospector(intro);
Object object =
reader.parse(getTestFileURL(src/test/org/apache/commons/betwixt/recursi
on/recursion3.xml));
StringWriter buffer = new StringWriter();
write (object, buffer, false);
System.out.println(buffer : +buffer);
}
/**
Emmanuel
-Message d'origine-
De: Martin van den Bemt [EMAIL PROTECTED]
A: Jakarta Commons Developers List [EMAIL PROTECTED]
Date: 17/01/03
Objet: Re: [Betwixt] complex recursion
Emmanuel,
Could you sent over the sources (preferrably with testcase, saves time),
so I can have a look at it (everything is working here, with the
testcase
o.a.commons.betwixt.io.TestRecursion (your example does resemble the
test that is done on recursion2.xml a lot).
The current cvs version of the test is not up-to-date btw (it's not even
checking on content), but I fixed that locally.
I will see if I can commit them in cvs seperately from the other changes
I've made, so you can have a look yourself at the testcase.
btw
You can also send a diff for the bean you use compared to the bean that
is currently is cvs (ElementBean and children), so I can change the
current recursion2.xml and add the subelement element to the testcase.
(please use cvs diff -u )
Mvgr,
Martin
On Wed, 2003-01-15 at 10:58, Emmanuel Venisse wrote:
Hi,
I try to use betwixt with a complex recursive xml like this :
?xml version=1.0?
ElementBean
element name=element1
subelement name=sub1/
element name=element11
subelement name=sub11/
element name=element111/
element name=element112
subelement name=sub112/
/element
/element
element name=element12/
/element
element name=element2
subelement name=sub2/
/element
/ElementBean
All element are created but only subelements sub1 and sub2 are
created. Other subelements are ignored.
any ideas?
Thanks
Emmanuel
_
Envie de discuter en live avec vos amis ? Télécharger MSN Messenger
http://www.ifrance.com/_reloc/m la 1ère messagerie instantanée de
France
--
To unsubscribe, e-mail:
mailto:[EMAIL PROTECTED]
For additional commands, e-mail:
mailto:[EMAIL PROTECTED]
--
To unsubscribe, e-mail:
mailto:[EMAIL PROTECTED]
For additional commands, e-mail:
mailto:[EMAIL PROTECTED]
_
Envie de discuter en live avec vos amis ? Télécharger MSN Messenger
http://www.ifrance.com/_reloc/m la 1ère messagerie instantanée de France
_
GRAND JEU SMS : Pour gagner un NOKIA 7650, envoyez le mot IF au 61321
(prix d'un SMS + 0.35 euro). Un SMS vous dira si vous avez gagné.
Règlement : http://www.ifrance.com/_reloc/sign.sms
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-commons/httpclient/src/java/org/apache/commons/httpclient HttpConnection.java
oglueck 2003/01/19 07:05:15 Modified:httpclient/src/java/org/apache/commons/httpclient HttpConnection.java Log: disable Nagles Algorithm Requested by: Juergen Pill Patch by: Oleg Kalnichevski bloody Sunday Revision ChangesPath 1.32 +14 -4 jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpConnection.java Index: HttpConnection.java === RCS file: /home/cvs/jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpConnection.java,v retrieving revision 1.31 retrieving revision 1.32 diff -u -r1.31 -r1.32 --- HttpConnection.java 16 Jan 2003 13:28:39 - 1.31 +++ HttpConnection.java 19 Jan 2003 15:05:15 - 1.32 @@ -456,6 +456,16 @@ } } + +/* +Nagling has been broadly implemented across networks, +including the Internet, and is generally performed by default +- although it is sometimes considered to be undesirable in +highly interactive environments, such as some client/server +situations. In such cases, nagling may be turned off through +use of the TCP_NODELAY sockets option. */ + +_socket.setTcpNoDelay(true); _socket.setSoTimeout(_so_timeout); _input = _socket.getInputStream(); _output = _socket.getOutputStream(); -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/jelly/jelly-tags/util/src/java/org/apache/commons/jelly/tags/util FileTag.java
dion2003/01/19 07:14:26
Modified:jelly/jelly-tags/util/src/java/org/apache/commons/jelly/tags/util
FileTag.java
Log:
remove check in file tag for file existence and readability
Revision ChangesPath
1.2 +1 -8
jakarta-commons-sandbox/jelly/jelly-tags/util/src/java/org/apache/commons/jelly/tags/util/FileTag.java
Index: FileTag.java
===
RCS file:
/home/cvs/jakarta-commons-sandbox/jelly/jelly-tags/util/src/java/org/apache/commons/jelly/tags/util/FileTag.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- FileTag.java 11 Jan 2003 08:59:46 - 1.1
+++ FileTag.java 19 Jan 2003 15:14:26 - 1.2
@@ -92,14 +92,7 @@
}
File newFile = new File(name);
-available = newFile.exists() newFile.canRead();
-if (available) {
-getContext().setVariable(var, newFile);
-} else {
-throw new IllegalArgumentException(file '+ name
-+ ' is not readable);
-}
-
+getContext().setVariable(var, newFile);
}
/**
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-commons/betwixt/xdocs todo.xml
rdonkin 2003/01/19 07:31:15 Modified:betwixt/xdocs todo.xml Log: Updated todo list to reflect fact that 1.0-alpha-1 release has been branched. Revision ChangesPath 1.31 +2 -65 jakarta-commons/betwixt/xdocs/todo.xml Index: todo.xml === RCS file: /home/cvs/jakarta-commons/betwixt/xdocs/todo.xml,v retrieving revision 1.30 retrieving revision 1.31 diff -u -r1.30 -r1.31 --- todo.xml 18 Jan 2003 18:58:13 - 1.30 +++ todo.xml 19 Jan 2003 15:31:15 - 1.31 @@ -13,23 +13,6 @@ Betwixt. Contributions are welcome! /p -subsection name='For 1.0 Alpha 1 Release' -ul -li -strongCreate DTD for .betwixt files./strong -/li - -li -strongTest Against Powered By Projects. /strong -Make sure release works with maven (done) and scarab. -/li -li -strongInvestigate Swing XML'ization Issues/strong -Investigate and document. em(MVDB will probably need to handle this.)/em -/li -/ul -/subsection - subsection name=High priority ul li @@ -189,56 +172,10 @@ /ul /subsection -subsection name='Completed (Since Last Release)' +subsection name='Completed (Since 1.0-Alpha-1 Release)' ul li -Using \n as default and now shows a warning when an invalid space character is used.br/ -Adding a check to only accept valid characters as lineEndings, so parsers actually -won't choke on the output xml. - BeanWriter should have a setEndOfLine() method to allow configurable EOL strings, defaulting to \n -/li -li - Create a SAXWriter class in the io package that takes a bean and writes to a SAX ContentHandler - rather that outputting textual XML like BeanWriter does. - This will allow Betwixt to work nicely in XML pipelining environments like Cocoon and Jelly. -/li -li digester.peek() was giving warning. Now checking if it still has something to peek. - Currently betwixt causes digester to output a warning '[WARN] Digester - -Empty stack (returning null)'. - We should patch the way betwixt uses digester to avoid this warning message. -/li -li -strongAdd description of digester-related limitation to FAQ/strong -/li -li -strongUpgrade To Latest Dependencies/strong -Check that betwixt works with the latest versions of the dependent -Replace all references to deprecated methods. -/li -li -strongAdd read and write examples/strong -Add simple read and write examples to getting started section. -/li -li -strongAdd strategy documentation. /strong -This needs to be added to the main documentation. -Example code needs to be created. -This code can also be used for more test cases. -/li -li -strongAdd XMLRegistry documentation. /strong -Add documentation about XMLRegistry to main documentation. -/li -li -strongAdd XMLIntrospector Setting Documentation. /strong -Add documentation about the XMLIntrospector settings to main documentation. -Make sure that warnings are added about consequences of changing settings. -/li -li -strongImprove Java Docs. /strong -Go through java docs, add any which are missing, correct any mistakes etc. -/li -li -strongCreate DTD for .betwixt files./strong +strongCreated DTD for .betwixt files./strong /li /ul /subsection -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-commons/betwixt/xdocs community.xml
rdonkin 2003/01/19 07:39:52 Modified:betwixt/xdocs community.xml Log: Corrected some small formatting issues. Revision ChangesPath 1.2 +5 -7 jakarta-commons/betwixt/xdocs/community.xml Index: community.xml === RCS file: /home/cvs/jakarta-commons/betwixt/xdocs/community.xml,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- community.xml 2 Jan 2003 11:44:32 - 1.1 +++ community.xml 19 Jan 2003 15:39:52 - 1.2 @@ -16,13 +16,11 @@ To access the IRC server, point an appropriate IRC client at: /p - blockquote -pre - server: birc.werken.com/b - port: b6667/b -channel: b#betwixt/b -/pre - /blockquote + source + server: irc.werken.com + port: 6667 +channel: #betwixt + /source p For those who use a href=http://www.mozilla.org/;Mozilla/a, here's a -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-commons/betwixt/xdocs faq.xml
rdonkin 2003/01/19 07:40:00 Modified:betwixt/xdocs faq.xml Log: Corrected some small formatting issues. Revision ChangesPath 1.4 +4 -4 jakarta-commons/betwixt/xdocs/faq.xml Index: faq.xml === RCS file: /home/cvs/jakarta-commons/betwixt/xdocs/faq.xml,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- faq.xml 30 Dec 2002 19:13:09 - 1.3 +++ faq.xml 19 Jan 2003 15:40:00 - 1.4 @@ -151,9 +151,9 @@ /dt dd Yes! Call -pre +source beanWriter.enablePrettyPrint(); -/pre +/source (For those who are extra picky, how this is done can also be adjusted. See java docs for details.) /dd @@ -181,9 +181,9 @@ /dt dd This is controlled by a property on codeBeanWriter/code. Call -pre +source beanWriter.setWriteIDs(false); -/pre +/source and then Betwixt will no longer automatically add codeID/code attributes. Once this property is set (to false), BeanWroter will throw a codeCyclicReferenceException/code when any cyclic references which are -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-commons/betwixt/xdocs tasks.xml navigation.xml todo.xml
rdonkin 2003/01/19 07:46:56 Modified:betwixt/xdocs navigation.xml Added: betwixt/xdocs tasks.xml Removed: betwixt/xdocs todo.xml Log: Maven links to a file named tasks.xml for it's task list. i've renamed the todo.xml document to task.xml so that it's linked correctly from the generated documentation. Revision ChangesPath 1.4 +1 -1 jakarta-commons/betwixt/xdocs/navigation.xml Index: navigation.xml === RCS file: /home/cvs/jakarta-commons/betwixt/xdocs/navigation.xml,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- navigation.xml2 Jan 2003 11:44:32 - 1.3 +++ navigation.xml19 Jan 2003 15:46:56 - 1.4 @@ -10,7 +10,7 @@ item name=FAQ href=/faq.html/ item name=Detail href=/overview.html/ item name=Community href=/community.html/ - item name=To Do List href=/todo.html/ + item name=To Do List href=/tasks.html/ item name=Powered By href=/powered.html/ /menu /body 1.1 jakarta-commons/betwixt/xdocs/tasks.xml Index: tasks.xml === ?xml version=1.0? document properties titleTODO/title author email=[EMAIL PROTECTED]James Strachan/author /properties body section name=TODO list p The following is a list of items that need to be completed in Betwixt. Contributions are welcome! /p subsection name=High priority ul li BeanWriter is writing too sloppy (empty elements, etc). Fixing it in a clean way is almost impossible. Probably a refactor is best anyway to have a less sloppy api.. /li li Get an overview of what .betwixt files should really do. Especially more complicated examples will cause very strange and unexpected results. /li li If an addFoo() method is found with no matching getFoos() then a warning should be generated. /li li Consider allowing the parsing of XML to order the properties/elements in the XMLBeanInfo so that when the XML is output again it follows the same XML ordering again. There is an example describing this a href=http://nagoya.apache.org/eyebrowse/ReadMsg?[EMAIL PROTECTED]amp;msgNo=8488;here/a. For example we could add a feature to parse the DTD and order the XMLBeanInfo according to the order in the DTD. /li li Improved documentation! Improve package level documentation so that new developers can get up to speed more quickly. Ensure all betwixt features have good user documentation. More good code examples. /li li Add support for IDREF's to BeanReader. At the moment, round tripping break when cycles exist. /li li Add testcase for the BeanReader(SAXParser) and BeanReader(XMLReader). They should behave the same in all cases. /li li strongCreate test cases based on real xml examples./strong This should help to shake out any problems and help to find out how the design can be improved. These should also be used as a basis for improved documentation. /li li strongImprove internal design./strong Betwixt is hard to understand and hard to create patches for. An improved internal design would help more people to contribute. /li li strongImprove test coverage./strong Run test coverage tool and improve coverage of key functionality. /li li strongAllow customization for update from .betwixt file/strong Add updater attribute that allows the updater to be specified for an elements. This should also allow updaters to be ignored for certain properties. /li li strongAdd dynabeans support./strong Dynabeans are a feature of codecommons-beanutils/code that allows data in non-beans to be wrapped into pseudo-beans. If betwixt supported dynabeans then you could do cool stuff like SQL -gt; DynaBeans -gt; XML. Probably a good way to do this would be to ensure that all property intrspection is done by dyanbeans-aware methods of beanutils. /li li strongUpdate RSS example application./strong The original betwixt documentation
Re: [Jelly] [Proposal] Jelly mailing list
-1. I don't expect Jelly to generate this much traffic typically. We had a spike while we reorganized the build, but that's coming to a close. - Morgan --- Nicola Ken Barozzi [EMAIL PROTECTED] wrote: Isn't it time Jelly got its own mailing list /now/, since traffic is more than high already? -- Nicola Ken Barozzi [EMAIL PROTECTED] - verba volant, scripta manent - (discussions get forgotten, just code remains) - -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] = Morgan Delagrange http://jakarta.apache.org/taglibs http://jakarta.apache.org/commons http://axion.tigris.org http://jakarta.apache.org/watchdog __ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 16227] - Added class hierachy support to CompareToBuilder.reflectionCompare()
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16227. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16227 Added class hierachy support to CompareToBuilder.reflectionCompare() [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-01-19 17:51 --- Patches applied, thank you ;-) Stephen -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-commons/lang/src/java/org/apache/commons/lang/builder CompareToBuilder.java
scolebourne2003/01/19 09:51:42
Modified:lang/src/java/org/apache/commons/lang/builder
CompareToBuilder.java
Log:
Fix javadoc where wrong method name specified
from Michael Schulze
Revision ChangesPath
1.11 +2 -2
jakarta-commons/lang/src/java/org/apache/commons/lang/builder/CompareToBuilder.java
Index: CompareToBuilder.java
===
RCS file:
/home/cvs/jakarta-commons/lang/src/java/org/apache/commons/lang/builder/CompareToBuilder.java,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- CompareToBuilder.java 19 Jan 2003 17:35:21 - 1.10
+++ CompareToBuilder.java 19 Jan 2003 17:51:42 - 1.11
@@ -76,7 +76,7 @@
*
* pTypical use for the code is as follows:/p
* pre
- * public int comapareTo(Object o) {
+ * public int compareTo(Object o) {
*MyClass rhs = (MyClass) o;
*return new CompareToBuilder()
* .appendSuper(super.compareTo(o)
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 16202] - typo in the javadoc example code
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16202. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16202 typo in the javadoc example code [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-01-19 17:53 --- Change made, thanks. Stephen -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 15438] - ArrayUtils.contains()
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15438. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15438 ArrayUtils.contains() --- Additional Comments From [EMAIL PROTECTED] 2003-01-19 17:58 --- I agree with the intent behind this proposed addition to ArrayUtils. However, I would prefer a broader solution: int ArrayUtils.indexOf(Object[] array, Object objectToFind) int ArrayUtils.indexOf(Object[] array, Object objectToFind, int startIndex) int ArrayUtils.lastIndexOf(Object[] array, Object objectToFind) int ArrayUtils.lastIndexOf(Object[] array, Object objectToFind, int startIndex) int ArrayUtils.contains(Object[] array, Object objectToFind) ie. the contains method would be built upon a full set of index methods. Are you interested in providing a patch? I would apply one as described above with test cases ;-) Stephen -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-commons/lang/src/java/org/apache/commons/lang StringUtils.java
scolebourne2003/01/19 10:15:38
Modified:lang/src/test/org/apache/commons/lang StringUtilsTest.java
lang/src/java/org/apache/commons/lang StringUtils.java
Log:
Fix infinite recursion in replace() when blank string used
from Holger Krauth
Revision ChangesPath
1.12 +26 -25
jakarta-commons/lang/src/test/org/apache/commons/lang/StringUtilsTest.java
Index: StringUtilsTest.java
===
RCS file:
/home/cvs/jakarta-commons/lang/src/test/org/apache/commons/lang/StringUtilsTest.java,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- StringUtilsTest.java 7 Dec 2002 21:50:30 - 1.11
+++ StringUtilsTest.java 19 Jan 2003 18:15:38 - 1.12
@@ -1,5 +1,3 @@
-package org.apache.commons.lang;
-
/*
* The Apache Software License, Version 1.1
*
@@ -53,6 +51,7 @@
* information on the Apache Software Foundation, please see
* http://www.apache.org/.
*/
+package org.apache.commons.lang;
import java.util.Arrays;
@@ -65,13 +64,14 @@
*
* @author a href=mailto:[EMAIL PROTECTED];Daniel Rall/a
* @author a href=mailto:[EMAIL PROTECTED];Henri Yandell/a
- * @author a href=mailto:[EMAIL PROTECTED];Stephen Colebourne/a
+ * @author Stephen Colebourne
* @author a href=mailto:[EMAIL PROTECTED];Ringo De Smet/a
* @author a href=mailto:[EMAIL PROTECTED]Fredrik Westermarck/a
+ * @author Holger Krauth
* @version $Id$
*/
-public class StringUtilsTest extends TestCase
-{
+public class StringUtilsTest extends TestCase {
+
private static final String[] ARRAY_LIST = { foo, bar, baz };
private static final String SEPARATOR = ,;
@@ -108,8 +108,7 @@
//---
-public void testCaseFunctions()
-{
+public void testCaseFunctions() {
assertEquals(capitalise(String) failed,
CAP_FOO, StringUtils.capitalise(FOO) );
assertEquals(capitalise(empty-string) failed,
@@ -144,8 +143,7 @@
Hello aPACHE, StringUtils.swapCase(hELLO Apache) );
}
-public void testJoin()
-{
+public void testJoin() {
assertEquals(concatenate(Object[]) failed,
foobarbaz, StringUtils.concatenate(ARRAY_LIST));
assertEquals(join(Object[], String) failed, TEXT_LIST,
@@ -155,8 +153,7 @@
SEPARATOR));
}
-public void testSplit()
-{
+public void testSplit() {
String[] result = StringUtils.split(TEXT_LIST, SEPARATOR, 2);
String[] expected = { foo, bar,baz };
assertEquals(split(Object[], String, int) yielded unexpected length,
@@ -193,8 +190,7 @@
assertEquals(split(Object[], null, int)[2] failed, three four five six,
result[2]);
}
-public void testReplaceFunctions()
-{
+public void testReplaceFunctions() {
assertEquals(replace(String, String, String, int) failed,
FOO, StringUtils.replace(oo + FOO, o, , 2));
assertEquals(replace(String, String, String) failed,
@@ -203,29 +199,35 @@
FOO, StringUtils.replaceOnce(FOO + FOO, FOO, ));
assertEquals(carriage-return replace(String,String,String) failed,
test123, StringUtils.replace(test\r1\r2\r3, \r, ));
+
+assertEquals(replace(String, String, String) failed,
+FOO, StringUtils.replace(FOO, , any));
+assertEquals(replace(String, String, String) failed,
+FOO, StringUtils.replace(FOO, null, any));
+assertEquals(replace(String, String, String) failed,
+FOO, StringUtils.replace(FOO, F, null));
+assertEquals(replace(String, String, String) failed,
+FOO, StringUtils.replace(FOO, null, null));
+assertEquals(replace(String, String, String) failed,
+null, StringUtils.replace(null, , any));
}
-public void testOverlayString()
-{
+public void testOverlayString() {
assertEquals(overlayString(String, String, int, int) failed,
foo foor baz, StringUtils.overlayString(SENTENCE, FOO, 4, 6)
);
}
-public void testRepeat()
-{
+public void testRepeat() {
assertEquals(repeat(String, int) failed,
FOO + FOO + FOO, StringUtils.repeat(FOO, 3) );
}
-public void testCenter()
-{
+public void testCenter() {
assertEquals(center(String, int) failed,
+FOO+ , StringUtils.center(FOO, 9) );
}
-public void testChompFunctions()
DO NOT REPLY [Bug 16204] - Infinite loop in StringUtils.replace(text, repl, with) + FIX
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16204. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16204 Infinite loop in StringUtils.replace(text, repl, with) + FIX [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-01-19 18:17 --- Changes made as suggested, thanks Stephen -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [PATCH] CLI using relection.
Nick thanks for the submission. I will review it and post my comments
back to
you as soon as I get a chance.
Thanks again,
-John K
On Saturday, Jan 18, 2003, at 09:40 Europe/Dublin, Nick Chalko wrote:
I have been doing CLI using reflection for aobut 2 years. I converted
my code from getopts to commons-cli, and would like to donate it to
Jakarta.
The beauty of this approach is that it requres ZERO confiuration. All
Option objects are created by reflection.
for example
public void main (String [] args ) {
MyClass me = new MyClass();
ReflectionCLI cli = new ReflectionCLI(me);
cli.applyCommandLine(args);
}
Is all it takes.
If there is a BeanInfo class additional properties are set.
argName is from the Display Name
description is from the Short Description.
I also override the meaning of preferred to set the Option to
required.
I have included a simple JUnit test.
Please let me know what you think, and what else I need to do to get
it accepted.
R,
Nick
Index: java/com/chalko/tools/batch/Batch.java
===
RCS file:
/cvsroot/chalktools/batch/src/java/com/chalko/tools/batch/Batch.java,v
retrieving revision 1.19
diff -u -r1.19 Batch.java
--- java/com/chalko/tools/batch/Batch.java 18 Jan 2003 08:46:42
- 1.19
+++ java/com/chalko/tools/batch/Batch.java 18 Jan 2003 09:29:22 -
@@ -22,8 +22,9 @@
import javax.mail.internet.MimeMultipart;
import javax.mail.internet.MimePart;
+import org.apache.commons.cli.ReflectionCLI;
+
import com.chalko.tools.batch.clp.BatchCLI;
-import com.chalko.tools.batch.clp.ReflectionCLI;
import com.chalko.tools.rt.BuildVersion;
/**
Index: java/com/chalko/tools/batch/clp/BatchCLI.java
===
RCS file:
/cvsroot/chalktools/batch/src/java/com/chalko/tools/batch/clp/
BatchCLI.java,v
retrieving revision 1.3
diff -u -r1.3 BatchCLI.java
--- java/com/chalko/tools/batch/clp/BatchCLI.java 18 Jan 2003 09:14:37
- 1.3
+++ java/com/chalko/tools/batch/clp/BatchCLI.java 18 Jan 2003 09:29:22
-
@@ -2,6 +2,7 @@
import java.io.IOException;
+import org.apache.commons.cli.*;
import org.apache.commons.cli.ParseException;
import com.chalko.tools.batch.Batchable;
Index: java/com/chalko/tools/batch/clp/ReflectionCLI.java
===
RCS file: java/com/chalko/tools/batch/clp/ReflectionCLI.java
diff -N java/com/chalko/tools/batch/clp/ReflectionCLI.java
--- java/com/chalko/tools/batch/clp/ReflectionCLI.java 18 Jan 2003
09:14:37 - 1.4
+++ /dev/null 1 Jan 1970 00:00:00 -
@@ -1,390 +0,0 @@
-package com.chalko.tools.batch.clp;
-/*
- * $Header:
/cvsroot/chalktools/batch/src/java/com/chalko/tools/batch/clp/
ReflectionCLI.java,v 1.4 2003/01/18 09:14:37 chalko Exp $
- */
-
-import java.beans.BeanInfo;
-import java.beans.IntrospectionException;
-import java.beans.Introspector;
-import java.beans.PropertyDescriptor;
-import java.io.IOException;
-import java.lang.reflect.InvocationTargetException;
-import java.lang.reflect.Method;
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.Iterator;
-import java.util.List;
-import java.util.Map;
-import java.util.Properties;
-
-import org.apache.commons.cli.CommandLine;
-import org.apache.commons.cli.HelpFormatter;
-import org.apache.commons.cli.Option;
-import org.apache.commons.cli.OptionBuilder;
-import org.apache.commons.cli.Options;
-import org.apache.commons.cli.ParseException;
-import org.apache.commons.cli.Parser;
-import org.apache.commons.cli.PosixParser;
-
-/**
- *
- * Used to apply command line paramters, setting properties and
options.
- *
- * @author Nick Chalko ([EMAIL PROTECTED])
- * @author $Author: chalko $
- * @version $Revision: 1.4 $
- */
-public class ReflectionCLI {
-public final static String PROPERTY_FILE_OPTION_NAME = prop;
-private final Properties prop = new Properties();
-private Object obj;
-private final Parser parser;
-
-private final Map writeableFields = new HashMap();
-
-private final Options options = new Options();
-
-/**
- * All propeties that are set as empPreffered/emp in the
client classes beaninfo.
- *
- * @return List of PropertyDescriptor that where isExpert = true
- */
-protected List getExpertPropertiesList() throws ParseException {
-
-List requiredPropetiesList = new
ArrayList(writeableFields.size());
-
-for (Iterator i = writeableFields.values().iterator();
i.hasNext();) {
-PropertyDescriptor p = (PropertyDescriptor) i.next();
-if (p.isExpert()) {
-requiredPropetiesList.add(p);
-}
-}
-return requiredPropetiesList;
-}
-
-/**
- * All propeties that are set as empexpert/emp
- * in the client classes beaninfo.
- *
- * @return List of PropertyDescriptor that where isExpert = false.
- */
-protected
Re: [jelly] Taglib split out - done?
I think my priorities would be: 1) Stabilize GUMP builds for all taglibs. 2) Raise and resolve remaining release issues. 3) Release Jelly 1.0. I think websites and documentation for the taglibs are a nice-to-have until Jelly is released. - Morgan --- [EMAIL PROTECTED] wrote: Things to do AFAICT: 1) The splitting of taglibs from core is now complete. 2) The dependencies of all tags look ok. 3) New snapshots of Jelly and the taglibs up on ibiblio. 4) Regen some ant build.xml and some gump descriptors. 5) Create web sites for all taglibs 6) Doco for all taglibs 7) Fix either the reactor in Maven, or remove the commonDependencies.ent Volunteers? -- dIon Gillard, Multitask Consulting Blog: http://www.freeroller.net/page/dion/Weblog Work: http://www.multitask.com.au -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] = Morgan Delagrange http://jakarta.apache.org/taglibs http://jakarta.apache.org/commons http://axion.tigris.org http://jakarta.apache.org/watchdog __ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-commons/lang/src/test/org/apache/commons/lang/builder ToStringBuilderTest.java
scolebourne2003/01/19 10:49:05
Modified:lang/src/java/org/apache/commons/lang/builder
CompareToBuilder.java ToStringBuilder.java
HashCodeBuilder.java EqualsBuilder.java
lang/src/test/org/apache/commons/lang/builder
ToStringBuilderTest.java
Log:
Fix infinite recursion in inner classes reflection methods
from Per Velschow
Revision ChangesPath
1.12 +10 -9
jakarta-commons/lang/src/java/org/apache/commons/lang/builder/CompareToBuilder.java
Index: CompareToBuilder.java
===
RCS file:
/home/cvs/jakarta-commons/lang/src/java/org/apache/commons/lang/builder/CompareToBuilder.java,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- CompareToBuilder.java 19 Jan 2003 17:51:42 - 1.11
+++ CompareToBuilder.java 19 Jan 2003 18:49:05 - 1.12
@@ -247,14 +247,15 @@
Field.setAccessible(fields, true);
for (int i = 0; i fields.length builder.comparison == 0; i++) {
Field f = fields[i];
-if (useTransients || !Modifier.isTransient(f.getModifiers())) {
-if (!Modifier.isStatic(f.getModifiers())) {
-try {
-builder.append(f.get(lhs), f.get(rhs));
-} catch (IllegalAccessException e) {
-//this can't happen. Would get a Security exception instead
-//throw a runtime exception in case the impossible happens.
-}
+if ((f.getName().indexOf('$') == -1)
+(useTransients || !Modifier.isTransient(f.getModifiers()))
+(!Modifier.isStatic(f.getModifiers( {
+try {
+builder.append(f.get(lhs), f.get(rhs));
+} catch (IllegalAccessException e) {
+//this can't happen. Would get a Security exception instead
+//throw a runtime exception in case the impossible happens.
+throw new InternalError(Unexpected IllegalAccessException);
}
}
}
1.14 +10 -9
jakarta-commons/lang/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
Index: ToStringBuilder.java
===
RCS file:
/home/cvs/jakarta-commons/lang/src/java/org/apache/commons/lang/builder/ToStringBuilder.java,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -r1.13 -r1.14
--- ToStringBuilder.java 19 Jan 2003 17:35:21 - 1.13
+++ ToStringBuilder.java 19 Jan 2003 18:49:05 - 1.14
@@ -373,14 +373,15 @@
Field.setAccessible(fields, true);
for (int i = 0; i fields.length; i++) {
Field f = fields[i];
-if (useTransients || !Modifier.isTransient(f.getModifiers())) {
-if (!Modifier.isStatic(f.getModifiers())) {
-try {
-builder.append(f.getName(), f.get(object));
-} catch (IllegalAccessException ex) {
-//this can't happen. Would get a Security exception instead
-//throw a runtime exception in case the impossible happens.
-}
+if ((f.getName().indexOf('$') == -1)
+(useTransients || !Modifier.isTransient(f.getModifiers()))
+(!Modifier.isStatic(f.getModifiers( {
+try {
+builder.append(f.getName(), f.get(object));
+} catch (IllegalAccessException ex) {
+//this can't happen. Would get a Security exception instead
+//throw a runtime exception in case the impossible happens.
+throw new InternalError(Unexpected IllegalAccessException);
}
}
}
1.10 +10 -9
jakarta-commons/lang/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java
Index: HashCodeBuilder.java
===
RCS file:
/home/cvs/jakarta-commons/lang/src/java/org/apache/commons/lang/builder/HashCodeBuilder.java,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- HashCodeBuilder.java 19 Jan 2003 17:35:21 - 1.9
+++ HashCodeBuilder.java 19 Jan 2003 18:49:05 - 1.10
@@ -337,14 +337,15 @@
Field.setAccessible(fields, true);
for (int i = 0; i fields.length; i++) {
Field f = fields[i];
-if (useTransients || !Modifier.isTransient(f.getModifiers())) {
-if (!Modifier.isStatic(f.getModifiers())) {
DO NOT REPLY [Bug 15986] - Infinite loop in ToStringBuilder.reflectionToString for inner classes
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15986. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15986 Infinite loop in ToStringBuilder.reflectionToString for inner classes [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-01-19 18:51 --- Change made which should deal with this situation. Thanks for the report and test. Stephen -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [lang] Bug #14357 Stack trace order
I would like to treat this as a bug, and just reverse the order to the 'correct' one (compliant with JDK 1.4 and others). Otherwise, I think that a static setStackOrderHighestToLowest(boolean) method is better than a system property. Stephen - Original Message - From: Max Rydahl Andersen [EMAIL PROTECTED] To: Jakarta Commons Developers List [EMAIL PROTECTED] Sent: Friday, January 17, 2003 2:21 PM Subject: Re: [lang] Bug #14357 I'm the bug-creator and if the usage of system property is unacceptable, then i'll suggest NestableException should be changed to conform better to how JDK 1.4 prints exception - not just to be complaint, but just to do the most reasonably expected thing...which is: Print the top-most exception first, and print the lowest last. /max - Original Message - From: Henri Yandell [EMAIL PROTECTED] To: Jakarta Commons Developers List [EMAIL PROTECTED] Sent: Thursday, January 16, 2003 9:16 PM Subject: [lang] Bug #14357 I'd like to get this bug/issue dealt with. http://issues.apache.org/bugzilla/show_bug.cgi?id=14357 NestableException [in Beta 1 apparantly] prints the stack trace with the most relevant error at the bottom and not the top, as is common in most app's. Does anyone know if this was fixed and the bug not closed, or if it's still an issue? The bug-creator's suggestion is a system property. Obviously this has serious issues and probably isn't acceptable. How else can it be solved? Hen -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 15986] - Infinite loop in ToStringBuilder.reflectionToString for inner classes
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15986. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15986 Infinite loop in ToStringBuilder.reflectionToString for inner classes --- Additional Comments From [EMAIL PROTECTED] 2003-01-19 19:10 --- I just checked the changes in CVS. If I read the code correctly, it will now discard any field name containing a '$' character. This may be too restrictive since '$' is a legal identifier part AFAIK. Also, I have thought a bit more about the problem. It is actually a more general problem than the one I reported. Inner classes are not the only way you could have mutually recursive data structures. So perhaps we should think of a more general way of preventing this infinite loop. I have not made any solution yet, but I think it might be solved using a Set of references to already traversed instances and then avoid traversing an instance if it has already been traversed. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [Jelly] [Proposal] Jelly mailing list
Scary. When I got to the bottom of my email list, I was going to suggest the same thing. +1 Also, as Jelly is thinking of leaving Commons [afaik], this would be a good test. Leaving the mailing list is to the developer akin to leaving the community. Hen On Sun, 19 Jan 2003, Nicola Ken Barozzi wrote: Isn't it time Jelly got its own mailing list /now/, since traffic is more than high already? -- Nicola Ken Barozzi [EMAIL PROTECTED] - verba volant, scripta manent - (discussions get forgotten, just code remains) - -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [lang] Bug #14357 Stack trace order
From: Henri Yandell [EMAIL PROTECTED] On Sun, 19 Jan 2003, Stephen Colebourne wrote: I would like to treat this as a bug, and just reverse the order to the 'correct' one (compliant with JDK 1.4 and others). +1, though I expect the deprecation police to throw a tizzy. We should release as 2.0 and list the changes. Doing this, we should go through and check the NullPointerExceptions etc. thrown by our classes, especially StringUtils. (I changed one today in replace()). If we handle nulls better then we will increase the value of using [lang]. Otherwise, I think that a static setStackOrderHighestToLowest(boolean) method is better than a system property. Acceptable [as is the property one] but I'd still want to reverse the default even if we did add some kind of way to modify the order. So it's more a question of: Should we keep the current way in anyway? Not in my view ;-) Stephen -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/email/src/java/org/apache/commons/mail GenerateUniqueID.java HtmlEmail.java
scolebourne2003/01/19 12:03:11 Modified:emailgump.xml project.xml LICENSE.txt email/src/java/org/apache/commons/mail HtmlEmail.java Added: email/src/java/org/apache/commons/mail GenerateUniqueID.java Log: Remove dependency on [util] and [lang] Fix licence Revision ChangesPath 1.3 +0 -1 jakarta-commons-sandbox/email/gump.xml Index: gump.xml === RCS file: /home/cvs/jakarta-commons-sandbox/email/gump.xml,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- gump.xml 25 Jul 2002 01:54:27 - 1.2 +++ gump.xml 19 Jan 2003 20:03:11 - 1.3 @@ -22,7 +22,6 @@ depend project=jakarta-ant inherit=runtime/ depend project=xml-xerces/ -depend project=commons-util/ depend project=javamail/ depend project=jaf/ 1.8 +1 -11 jakarta-commons-sandbox/email/project.xml Index: project.xml === RCS file: /home/cvs/jakarta-commons-sandbox/email/project.xml,v retrieving revision 1.7 retrieving revision 1.8 diff -u -r1.7 -r1.8 --- project.xml 17 Dec 2002 07:00:20 - 1.7 +++ project.xml 19 Jan 2003 20:03:11 - 1.8 @@ -69,17 +69,6 @@ dependencies dependency - idcommons-util/id - version1.0-rc2-dev/version -/dependency - -!-- needed as util now depends on lang -- -dependency - idcommons-lang/id - versionSNAPSHOT/version -/dependency - -dependency idjavamail/id version1.2/version /dependency @@ -88,6 +77,7 @@ version1.0.2/version /dependency /dependencies + build sourceDirectorysrc/java/sourceDirectory unitTestSourceDirectorysrc/test/unitTestSourceDirectory 1.2 +3 -3 jakarta-commons-sandbox/email/LICENSE.txt Index: LICENSE.txt === RCS file: /home/cvs/jakarta-commons-sandbox/email/LICENSE.txt,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- LICENSE.txt 11 May 2002 14:29:43 - 1.1 +++ LICENSE.txt 19 Jan 2003 20:03:11 - 1.2 @@ -1,7 +1,7 @@ -/* +/* * The Apache Software License, Version 1.1 * - * Copyright (c) 2001 The Apache Software Foundation. All rights + * Copyright (c) 2001-2003 The Apache Software Foundation. All rights * reserved. * * Redistribution and use in source and binary forms, with or without @@ -30,7 +30,7 @@ * * 5. Products derived from this software may not be called Apache *nor may Apache appear in their names without prior written - *permission of the Apache Group. + *permission of the Apache Software Foundation. * * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES 1.5 +16 -18 jakarta-commons-sandbox/email/src/java/org/apache/commons/mail/HtmlEmail.java Index: HtmlEmail.java === RCS file: /home/cvs/jakarta-commons-sandbox/email/src/java/org/apache/commons/mail/HtmlEmail.java,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- HtmlEmail.java17 Dec 2002 06:51:37 - 1.4 +++ HtmlEmail.java19 Jan 2003 20:03:11 - 1.5 @@ -1,9 +1,7 @@ -package org.apache.commons.mail; - /* * The Apache Software License, Version 1.1 * - * Copyright (c) 2001 The Apache Software Foundation. All rights + * Copyright (c) 2001-2003 The Apache Software Foundation. All rights * reserved. * * Redistribution and use in source and binary forms, with or without @@ -18,21 +16,21 @@ *the documentation and/or other materials provided with the *distribution. * - * 3. The end-user documentation included with the redistribution, - *if any, must include the following acknowledgment: + * 3. The end-user documentation included with the redistribution, if + *any, must include the following acknowlegement: * This product includes software developed by the *Apache Software Foundation (http://www.apache.org/). - *Alternately, this acknowledgment may appear in the software itself, - *if and wherever such third-party acknowledgments normally appear. + *Alternately, this acknowlegement may appear in the software itself, + *if and wherever such third-party acknowlegements normally appear. * - * 4. The names Apache and Apache Software Foundation
cvs commit: jakarta-commons-sandbox/email/src/java/org/apache/commons/mail MailMessage.java MultiPartEmail.java SimpleEmail.java Email.java ByteArrayDataSource.java EmailAttachment.java
scolebourne2003/01/19 12:06:18 Modified:email/src/java/org/apache/commons/mail MailMessage.java MultiPartEmail.java SimpleEmail.java Email.java ByteArrayDataSource.java EmailAttachment.java Log: Fix licence to be commons version Revision ChangesPath 1.2 +15 -16 jakarta-commons-sandbox/email/src/java/org/apache/commons/mail/MailMessage.java Index: MailMessage.java === RCS file: /home/cvs/jakarta-commons-sandbox/email/src/java/org/apache/commons/mail/MailMessage.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- MailMessage.java 9 Aug 2001 22:50:48 - 1.1 +++ MailMessage.java 19 Jan 2003 20:06:17 - 1.2 @@ -1,9 +1,7 @@ -package org.apache.commons.mail; - /* * The Apache Software License, Version 1.1 * - * Copyright (c) 2001 The Apache Software Foundation. All rights + * Copyright (c) 2001-2003 The Apache Software Foundation. All rights * reserved. * * Redistribution and use in source and binary forms, with or without @@ -18,21 +16,21 @@ *the documentation and/or other materials provided with the *distribution. * - * 3. The end-user documentation included with the redistribution, - *if any, must include the following acknowledgment: + * 3. The end-user documentation included with the redistribution, if + *any, must include the following acknowlegement: * This product includes software developed by the *Apache Software Foundation (http://www.apache.org/). - *Alternately, this acknowledgment may appear in the software itself, - *if and wherever such third-party acknowledgments normally appear. + *Alternately, this acknowlegement may appear in the software itself, + *if and wherever such third-party acknowlegements normally appear. * - * 4. The names Apache and Apache Software Foundation and - *Apache Turbine must not be used to endorse or promote products - *derived from this software without prior written permission. For - *written permission, please contact [EMAIL PROTECTED] - * - * 5. Products derived from this software may not be called Apache, - *Apache Turbine, nor may Apache appear in their name, without - *prior written permission of the Apache Software Foundation. + * 4. The names The Jakarta Project, Commons, and Apache Software + *Foundation must not be used to endorse or promote products derived + *from this software without prior written permission. For written + *permission, please contact [EMAIL PROTECTED] + * + * 5. Products derived from this software may not be called Apache + *nor may Apache appear in their names without prior written + *permission of the Apache Software Foundation. * * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES @@ -53,6 +51,7 @@ * information on the Apache Software Foundation, please see * http://www.apache.org/. */ +package org.apache.commons.mail; import java.io.PrintStream; import java.io.UnsupportedEncodingException; 1.2 +15 -16 jakarta-commons-sandbox/email/src/java/org/apache/commons/mail/MultiPartEmail.java Index: MultiPartEmail.java === RCS file: /home/cvs/jakarta-commons-sandbox/email/src/java/org/apache/commons/mail/MultiPartEmail.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- MultiPartEmail.java 9 Aug 2001 22:50:48 - 1.1 +++ MultiPartEmail.java 19 Jan 2003 20:06:17 - 1.2 @@ -1,9 +1,7 @@ -package org.apache.commons.mail; - /* * The Apache Software License, Version 1.1 * - * Copyright (c) 2001 The Apache Software Foundation. All rights + * Copyright (c) 2001-2003 The Apache Software Foundation. All rights * reserved. * * Redistribution and use in source and binary forms, with or without @@ -18,21 +16,21 @@ *the documentation and/or other materials provided with the *distribution. * - * 3. The end-user documentation included with the redistribution, - *if any, must include the following acknowledgment: + * 3. The end-user documentation included with the redistribution, if + *any, must include the following acknowlegement: * This product includes software developed by the *Apache Software Foundation (http://www.apache.org/). - *Alternately, this acknowledgment may appear in the software itself, - *if and wherever such third-party
[email] Removed dependency
I'm about to delete [util], so I have updated [email] to remove the dependency. While I was at it, I updated the licence to be the commons licence, not the turbine one. Stephen -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/util/src/test/org/apache/commons/util/identifier TestIdentifierUtils.java TestIdentifierFactories.java IdentifierTestSuite.java
scolebourne2003/01/19 12:14:56 Modified:util STATUS.html Removed: util/src/java/org/apache/commons/util/identifier IdentifierUtils.java LongIncrementingIdentifierFactory.java StringAlphanumeric15IdentifierFactory.java StringAlphanumeric10IdentifierFactory.java StringIncrementingLongIdentifierFactory.java IdentifierFactoryException.java StringIncrementingVLongIdentifierFactory.java LongRandomIdentifierFactory.java StringRMIIdentifierFactory.java util project.properties PROPOSAL gump.xml project.xml build.xml RELEASE-NOTES.txt build-gump.xml util/src/java/org/apache/commons/util/lru ILRUElement.java LRUStore.java LRUElement.java LRUElementDescriptor.java LRUElementImp.java LRUStoreImp.java util/src/conf MANIFEST.MF util/src/test/org/apache/commons/util/identifier TestIdentifierUtils.java TestIdentifierFactories.java IdentifierTestSuite.java Log: Util project closed Revision ChangesPath 1.3 +3 -90 jakarta-commons-sandbox/util/STATUS.html Index: STATUS.html === RCS file: /home/cvs/jakarta-commons-sandbox/util/STATUS.html,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- STATUS.html 22 Dec 2002 23:03:27 - 1.2 +++ STATUS.html 19 Jan 2003 20:14:56 - 1.3 @@ -1,98 +1,11 @@ html head -titleStatus File for Jakarta Commons Util Component/title +titleStatus for Util Package/title /head body bgcolor=white - -div align=center -h1The Jakarta Commons emUtil/em Component/h1 -$Id$br / -a href=#Introduction[Introduction]/a -a href=#Dependencies[Dependencies]/a -a href=#Release Info[Release Info]/a -a href=#Known Issues[Known Issues]/a -a href=#Action Items[Action Items]/a -a href=#Committers[Committers]/a -br /br / -/div - - -a name=Introduction/a -h31. INTRODUCTION/h3 - -pbDecember 2002/b. It is intended that the Util component will be closed in -the near future as it has no prospect of release. Code is being migrated to other -locations./p - -pThe emUtil/em Component contains a set of Java classes that provide -utility methods and classes to enhance the standard Java classes./p - - -a name=Dependencies/a -h32. DEPENDENCIES/h3 - -pThe emUtil/em component is dependent upon the following external -components for development and use:/p -ul -liApache Jakarta Commons Lang/li -lia href=http://java.sun.com/j2se;Java Development Kit/a -(Version 1.2 or later)/li -lia href=http://www.junit.org;JUnit Testing Framework/a -(Version 3.7 or later) - for unit tests only, not required -for deployment/li -/ul - - -a name=Release Info/a -h33. RELEASE INFO/h3 - -pCurrent Release: -No current release -/p - -pPlanned Next Release: -No current release plans -/p - - -a name=Known Issues/a -h34. KNOWN ISSUES/h3 -p -ul -/ul -/p - - -a name=Action Items/a -h35. ACTION ITEMS/h3 - -pWant to help? Here's some to do items the team has identified. Note that all are -still under discussion, so please mail the list before actioning./p -ul -liTesting/li -/ul - - -a name=Committers/a -h36. COMMITTERS/h3 - -pThe following individuals are the primary developers and maintainers of this -component. Developers who plan to use emLang/em in their own -projects are encouraged to collaborate on the future development of this -component to ensure that it continues to meet a variety of needs./p -ul -liGeir Magnusson, Jr. (geir) -liHenri Yandell (bayard) -liScott Sanders (sanders) -liDaniel Rall (dlr) -liAaron Smuts (asmuts) -liJason van Zyl (jvanzyl) -liLeonard Richardson (leonardr) -liKasper Nielsen (knielsen) -liJon Stevens (jon) -liStephen Colebourne (scolebourne) -/ul +h1CLOSED PROJECT/h1 +pThe pattern project has now been closed. Code has moved to [lang] and [collections] projects./p /body /html -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-commons/xdocs/stylesheets project.xml
bayard 2003/01/19 12:23:43 Modified:docs beanutils.html charter.html collections.html commons.html components.html contributors.html dbcp.html digester.html directory.html discovery.html index.html lang.html license.html logging.html modeler.html patches.html pool.html releases.html sandbox.html versioning.html volunteering.html xdocscomponents.xml sandbox.xml xdocs/stylesheets project.xml Log: Removed the sandbox'd util project from the website. Revision ChangesPath 1.63 +0 -2 jakarta-commons/docs/beanutils.html Index: beanutils.html === RCS file: /home/cvs/jakarta-commons/docs/beanutils.html,v retrieving revision 1.62 retrieving revision 1.63 diff -u -r1.62 -r1.63 --- beanutils.html10 Jan 2003 03:48:50 - 1.62 +++ beanutils.html19 Jan 2003 20:23:42 - 1.63 @@ -140,8 +140,6 @@ /li lia href=http://jakarta.apache.org/commons/sandbox/threadpool/index.html;ThreadPool/a /li -lia href=http://jakarta.apache.org/commons/sandbox/util/index.html;Util/a -/li lia href=http://jakarta.apache.org/commons/sandbox/vfs/index.html;VFS/a /li lia href=http://cvs.apache.org/viewcvs/jakarta-commons-sandbox/workflow/;Workflow/a 1.60 +0 -2 jakarta-commons/docs/charter.html Index: charter.html === RCS file: /home/cvs/jakarta-commons/docs/charter.html,v retrieving revision 1.59 retrieving revision 1.60 diff -u -r1.59 -r1.60 --- charter.html 10 Jan 2003 03:48:51 - 1.59 +++ charter.html 19 Jan 2003 20:23:42 - 1.60 @@ -140,8 +140,6 @@ /li lia href=http://jakarta.apache.org/commons/sandbox/threadpool/index.html;ThreadPool/a /li -lia href=http://jakarta.apache.org/commons/sandbox/util/index.html;Util/a -/li lia href=http://jakarta.apache.org/commons/sandbox/vfs/index.html;VFS/a /li lia href=http://cvs.apache.org/viewcvs/jakarta-commons-sandbox/workflow/;Workflow/a 1.51 +0 -2 jakarta-commons/docs/collections.html Index: collections.html === RCS file: /home/cvs/jakarta-commons/docs/collections.html,v retrieving revision 1.50 retrieving revision 1.51 diff -u -r1.50 -r1.51 --- collections.html 10 Jan 2003 03:48:51 - 1.50 +++ collections.html 19 Jan 2003 20:23:42 - 1.51 @@ -140,8 +140,6 @@ /li lia href=http://jakarta.apache.org/commons/sandbox/threadpool/index.html;ThreadPool/a /li -lia href=http://jakarta.apache.org/commons/sandbox/util/index.html;Util/a -/li lia href=http://jakarta.apache.org/commons/sandbox/vfs/index.html;VFS/a /li lia href=http://cvs.apache.org/viewcvs/jakarta-commons-sandbox/workflow/;Workflow/a 1.65 +0 -2 jakarta-commons/docs/commons.html Index: commons.html === RCS file: /home/cvs/jakarta-commons/docs/commons.html,v retrieving revision 1.64 retrieving revision 1.65 diff -u -r1.64 -r1.65 --- commons.html 10 Jan 2003 03:48:51 - 1.64 +++ commons.html 19 Jan 2003 20:23:42 - 1.65 @@ -140,8 +140,6 @@ /li lia href=http://jakarta.apache.org/commons/sandbox/threadpool/index.html;ThreadPool/a /li -lia href=http://jakarta.apache.org/commons/sandbox/util/index.html;Util/a -/li lia href=http://jakarta.apache.org/commons/sandbox/vfs/index.html;VFS/a /li lia href=http://cvs.apache.org/viewcvs/jakarta-commons-sandbox/workflow/;Workflow/a 1.75 +0 -11 jakarta-commons/docs/components.html Index: components.html === RCS file: /home/cvs/jakarta-commons/docs/components.html,v retrieving revision 1.74 retrieving revision 1.75 diff -u -r1.74 -r1.75 --- components.html 10 Jan 2003 03:48:51 - 1.74 +++ components.html 19 Jan 2003 20:23:42 - 1.75 @@ -140,8 +140,6 @@ /li lia href=http://jakarta.apache.org/commons/sandbox/threadpool/index.html;ThreadPool/a /li -lia href=http://jakarta.apache.org/commons/sandbox/util/index.html;Util/a -/li lia
[util] Project closed
I have deleted all the remaining files in [util]. http://www.mail-archive.com/commons-dev@jakarta.apache.org/msg15369.html http://www.mail-archive.com/commons-dev@jakarta.apache.org/msg13612.html They've had deprecation warnings for some time, and nobody has objected. The [email] dependency has been taken care of. Stephen -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [util] Project closed
[util] project's entry on the Commons website is now removed. Hen On Sun, 19 Jan 2003, Stephen Colebourne wrote: I have deleted all the remaining files in [util]. http://www.mail-archive.com/commons-dev@jakarta.apache.org/msg15369.html http://www.mail-archive.com/commons-dev@jakarta.apache.org/msg13612.html They've had deprecation warnings for some time, and nobody has objected. The [email] dependency has been taken care of. Stephen -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [util] Project closed
One question. Should anything be done about: http://www.ibiblio.org/maven/commons-util/jars/ ie) a request to kill it? as far as I know, there was never any official release candidate of commons-util, but the fact it is there implies someone is using it [possibly only commons-email though]. Hen On Sun, 19 Jan 2003, Henri Yandell wrote: [util] project's entry on the Commons website is now removed. Hen On Sun, 19 Jan 2003, Stephen Colebourne wrote: I have deleted all the remaining files in [util]. http://www.mail-archive.com/commons-dev@jakarta.apache.org/msg15369.html http://www.mail-archive.com/commons-dev@jakarta.apache.org/msg13612.html They've had deprecation warnings for some time, and nobody has objected. The [email] dependency has been taken care of. Stephen -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [Jelly] [Proposal] Jelly mailing list
FWIW, at this point, there's no proposal for Jelly to move out of Commons. It may happen long term, but currently we're here. -- dIon Gillard, Multitask Consulting Blog: http://www.freeroller.net/page/dion/Weblog Work: http://www.multitask.com.au Henri Yandell [EMAIL PROTECTED] wrote on 20/01/2003 06:11:50 AM: Scary. When I got to the bottom of my email list, I was going to suggest the same thing. +1 Also, as Jelly is thinking of leaving Commons [afaik], this would be a good test. Leaving the mailing list is to the developer akin to leaving the community. Hen On Sun, 19 Jan 2003, Nicola Ken Barozzi wrote: Isn't it time Jelly got its own mailing list /now/, since traffic is more than high already? -- Nicola Ken Barozzi [EMAIL PROTECTED] - verba volant, scripta manent - (discussions get forgotten, just code remains) - -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] ForwardSourceID:NT000A550E -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [jelly] Taglib split out - done?
Morgan Delagrange [EMAIL PROTECTED] wrote on 20/01/2003 05:45:53 AM: I think my priorities would be: 1) Stabilize GUMP builds for all taglibs. 2) Raise and resolve remaining release issues. 3) Release Jelly 1.0. I think websites and documentation for the taglibs are a nice-to-have until Jelly is released. Obviously not a user :) -- dIon Gillard, Multitask Consulting Blog: http://www.freeroller.net/page/dion/Weblog Work: http://www.multitask.com.au -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [util] Project closed
maven still has commons-util as a dependency for it's bootstrap build. i don't find any references in the maven source (when i grep them) so it's possible that it's no longer used. - robert On Sunday, January 19, 2003, at 08:28 PM, Henri Yandell wrote: One question. Should anything be done about: http://www.ibiblio.org/maven/commons-util/jars/ ie) a request to kill it? as far as I know, there was never any official release candidate of commons-util, but the fact it is there implies someone is using it [possibly only commons-email though]. Hen On Sun, 19 Jan 2003, Henri Yandell wrote: [util] project's entry on the Commons website is now removed. Hen On Sun, 19 Jan 2003, Stephen Colebourne wrote: I have deleted all the remaining files in [util]. http://www.mail-archive.com/commons-dev@jakarta.apache.org/msg15369.html http://www.mail-archive.com/commons- [EMAIL PROTECTED]/msg13612.html They've had deprecation warnings for some time, and nobody has objected. The [email] dependency has been taken care of. Stephen -- To unsubscribe, e-mail: mailto:commons-dev- [EMAIL PROTECTED] For additional commands, e-mail: mailto:commons-dev- [EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]. org For additional commands, e-mail: mailto:[EMAIL PROTECTED]. org -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]. org For additional commands, e-mail: mailto:[EMAIL PROTECTED]. org -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [util] Project closed
Leave it on ibiblio, and ask them to add a message that it is no longer maintained so to say. If it is on ibiblio it could be that still some other projects (outside of jakarta) depend on it.. Mvgr, Martin On Sun, 2003-01-19 at 21:28, Henri Yandell wrote: One question. Should anything be done about: http://www.ibiblio.org/maven/commons-util/jars/ ie) a request to kill it? -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
[Jelly] BCEL Taglibrary Beginnings
I started writting the beginnings of a BCEL taglibrary. Although it may
be a bit different than others may anticipate.
Basically I've built two tags and a supporting BeanExtender class to
support them.
bcel:extends
baseClass=java.lang.Object
packageName=org.foo
className=Test
bcel:add-property name=bar propertyType=int write=false/
bcel:add-property name=bam propertyType=java.lang.String/
/bcel:extends
Basically creates a new Class (org.foo.Test) that has:
package org.foo;
public Test extends java.lang.Object {
private int bar;
private String bam;
public Test(){}
public int getBar(){
return bar;
}
public String getBam(){
return bam;
}
public void setBam(String bam){
this.bam = bam;
}
}
It then changes the Security access on the ClassLoader define
method. Allowing the class to be added into the current loader. Once the
class is available it can then be instantiated by useBean or new.
I'm sure there are some more flexible ways to design the Taglibrary, I
consider this to be a first blush over the idea. I'd be glad to donate
the code if others are interested in developing it too.
-Mark Diggory
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/jelly/src/java/org/apache/commons/jelly jelly.properties
dion2003/01/19 15:13:34 Modified:jelly/src/java/org/apache/commons/jelly jelly.properties Log: Reflect current core and taglibs Revision ChangesPath 1.35 +7 -7 jakarta-commons-sandbox/jelly/src/java/org/apache/commons/jelly/jelly.properties Index: jelly.properties === RCS file: /home/cvs/jakarta-commons-sandbox/jelly/src/java/org/apache/commons/jelly/jelly.properties,v retrieving revision 1.34 retrieving revision 1.35 diff -u -r1.34 -r1.35 --- jelly.properties 16 Jan 2003 16:22:02 - 1.34 +++ jelly.properties 19 Jan 2003 23:13:34 - 1.35 @@ -1,19 +1,15 @@ # register the default tag libraries with an abbreviated name core= org.apache.commons.jelly.tags.core.CoreTagLibrary -define = org.apache.commons.jelly.tags.define.DefineTagLibrary -log = org.apache.commons.jelly.tags.log.LogTagLibrary -junit= org.apache.commons.jelly.tags.junit.JUnitTagLibrary -bean = org.apache.commons.jelly.tags.bean.BeanTagLibrary -dynabean = org.apache.commons.jelly.tags.dynabean.DynabeanTagLibrary -threads = org.apache.commons.jelly.tags.threads.ThreadsTagLibrary -xml = org.apache.commons.jelly.tags.xml.XMLTagLibrary # optional taglibs ant = org.apache.commons.jelly.tags.ant.AntTagLibrary antlr = org.apache.commons.jelly.tags.antlr.AntlrTagLibrary +bean = org.apache.commons.jelly.tags.bean.BeanTagLibrary beanshell = org.apache.commons.jelly.tags.beanshell.BeanShellTagLibrary betwixt = org.apache.commons.jelly.tags.betwixt.BetwixtTagLibrary bsf = org.apache.commons.jelly.tags.bsf.BSFTagLibrary +define = org.apache.commons.jelly.tags.define.DefineTagLibrary +dynabean = org.apache.commons.jelly.tags.dynabean.DynabeanTagLibrary email= org.apache.commons.jelly.tags.email.EmailTagLibrary fmt = org.apache.commons.jelly.tags.fmt.FmtTagLibrary html = org.apache.commons.jelly.tags.html.HTMLTagLibrary @@ -24,6 +20,8 @@ jms = org.apache.commons.jelly.tags.jms.JMSTagLibrary jpython = org.apache.commons.jelly.tags.bsf.JPythonTagLibrary jsl = org.apache.commons.jelly.tags.jsl.JSLTagLibrary +junit= org.apache.commons.jelly.tags.junit.JUnitTagLibrary +log = org.apache.commons.jelly.tags.log.LogTagLibrary ojb = org.apache.commons.jelly.tags.ojb.OjbTagLibrary pnuts = org.apache.commons.jelly.tags.bsf.PNutsTagLibrary quartz = org.apache.commons.jelly.tags.quartz.QuartzTagLibrary @@ -31,7 +29,9 @@ sql = org.apache.commons.jelly.tags.sql.SqlTagLibrary swing= org.apache.commons.jelly.tags.swing.SwingTagLibrary swt = org.apache.commons.jelly.tags.swt.SwtTagLibrary +threads = org.apache.commons.jelly.tags.threads.ThreadsTagLibrary util= org.apache.commons.jelly.tags.util.UtilTagLibrary validate= org.apache.commons.jelly.tags.validate.ValidateTagLibrary velocity= org.apache.commons.jelly.tags.velocity.VelocityTagLibrary +xml = org.apache.commons.jelly.tags.xml.XMLTagLibrary xmlunit = org.apache.commons.jelly.tags.xmlunit.XMLUnitTagLibrary -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-commons/betwixt/src/java/org/apache/commons/betwixt XMLUtils.java
rdonkin 2003/01/19 15:20:44
Added: betwixt/src/java/org/apache/commons/betwixt XMLUtils.java
Log:
Created new utility class for basic XML operations.
Revision ChangesPath
1.1
jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/XMLUtils.java
Index: XMLUtils.java
===
/*
* $Header:
/home/cvs/jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/XMLUtils.java,v
1.1 2003/01/19 23:20:44 rdonkin Exp $
* $Revision: 1.1 $
* $Date: 2003/01/19 23:20:44 $
*
*
*
* The Apache Software License, Version 1.1
*
* Copyright (c) 1999-2003 The Apache Software Foundation. All rights
* reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* 1. Redistributions of source code must retain the above copyright
*notice, this list of conditions and the following disclaimer.
*
* 2. Redistributions in binary form must reproduce the above copyright
*notice, this list of conditions and the following disclaimer in
*the documentation and/or other materials provided with the
*distribution.
*
* 3. The end-user documentation included with the redistribution, if
*any, must include the following acknowlegement:
* This product includes software developed by the
*Apache Software Foundation (http://www.apache.org/).
*Alternately, this acknowlegement may appear in the software itself,
*if and wherever such third-party acknowlegements normally appear.
*
* 4. The names The Jakarta Project, Commons, and Apache Software
*Foundation must not be used to endorse or promote products derived
*from this software without prior written permission. For written
*permission, please contact [EMAIL PROTECTED]
*
* 5. Products derived from this software may not be called Apache
*nor may Apache appear in their names without prior written
*permission of the Apache Group.
*
* THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
* WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
* ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
* USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
* ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
* OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*
*
* This software consists of voluntary contributions made by many
* individuals on behalf of the Apache Software Foundation. For more
* information on the Apache Software Foundation, please see
* http://www.apache.org/.
*
* $Id: XMLUtils.java,v 1.1 2003/01/19 23:20:44 rdonkin Exp $
*/
package org.apache.commons.betwixt;
/**
* pcodeXMLUtils/code contains basic utility methods for XML./p
*
* pThe code for {@link #isWellFormedXMLName} is based on code in
* codeorg.apache.xerces.util.XMLChar/code
* in a href='http://xml.apache.org/xerces2-j/index.html'Apache Xerces/a.
* The authors of this class are credited below./p
*
* @author Glenn Marcy, IBM
* @author Andy Clark, IBM
* @author Eric Ye, IBM
* @author Arnaud Le Hors, IBM
* @author Rahul Srivastava, Sun Microsystems Inc.
*
* @author Robert Burrell Donkin
* @version $Revision: 1.1 $
*/
public class XMLUtils {
// Constants
//-
/** Escaped codelt;/code entity */
public static final String LESS_THAN_ENTITY = lt;;
/** Escaped codegt;/code entity */
public static final String GREATER_THAN_ENTITY = gt;;
/** Escaped codeamp;/code entity */
public static final String AMPERSAND_ENTITY = amp;;
/** Escaped code'/code entity */
public static final String APOSTROPHE_ENTITY = apos;;
/** Escaped code/code entity */
public static final String QUOTE_ENTITY = quot;;
// Used by isWellFormedXMLName
/** Name start character mask. */
private static final int MASK_NAME_START = 0x01;
/** Name character mask. */
private static final int MASK_NAME = 0x02;
// Class attributes
cvs commit: jakarta-commons/betwixt/src/test/org/apache/commons/betwixt TestXMLUtils.java
rdonkin 2003/01/19 15:21:31
Added: betwixt/src/test/org/apache/commons/betwixt
TestXMLUtils.java
Log:
Unit tests for XMLUtil utility class.
Revision ChangesPath
1.1
jakarta-commons/betwixt/src/test/org/apache/commons/betwixt/TestXMLUtils.java
Index: TestXMLUtils.java
===
/*
* $Header:
/home/cvs/jakarta-commons/betwixt/src/test/org/apache/commons/betwixt/TestXMLUtils.java,v
1.1 2003/01/19 23:21:31 rdonkin Exp $
* $Revision: 1.1 $
* $Date: 2003/01/19 23:21:31 $
*
*
*
* The Apache Software License, Version 1.1
*
* Copyright (c) 1999-2002 The Apache Software Foundation. All rights
* reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* 1. Redistributions of source code must retain the above copyright
*notice, this list of conditions and the following disclaimer.
*
* 2. Redistributions in binary form must reproduce the above copyright
*notice, this list of conditions and the following disclaimer in
*the documentation and/or other materials provided with the
*distribution.
*
* 3. The end-user documentation included with the redistribution, if
*any, must include the following acknowlegement:
* This product includes software developed by the
*Apache Software Foundation (http://www.apache.org/).
*Alternately, this acknowlegement may appear in the software itself,
*if and wherever such third-party acknowlegements normally appear.
*
* 4. The names The Jakarta Project, Commons, and Apache Software
*Foundation must not be used to endorse or promote products derived
*from this software without prior written permission. For written
*permission, please contact [EMAIL PROTECTED]
*
* 5. Products derived from this software may not be called Apache
*nor may Apache appear in their names without prior written
*permission of the Apache Group.
*
* THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
* WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
* ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
* USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
* ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
* OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*
*
* This software consists of voluntary contributions made by many
* individuals on behalf of the Apache Software Foundation. For more
* information on the Apache Software Foundation, please see
* http://www.apache.org/.
*
* $Id: TestXMLUtils.java,v 1.1 2003/01/19 23:21:31 rdonkin Exp $
*/
package org.apache.commons.betwixt;
import junit.framework.Test;
import junit.framework.TestSuite;
import junit.textui.TestRunner;
/** Test harness for the XMLUtils
*
* @author Robert Burrell Donkin
* @version $Revision: 1.1 $
*/
public class TestXMLUtils extends AbstractTestCase {
public static void main( String[] args ) {
TestRunner.run( suite() );
}
public static Test suite() {
return new TestSuite(TestXMLUtils.class);
}
public TestXMLUtils(String testName) {
super(testName);
}
/**
* Test for some common xml naming
*/
public void testXMLNameTest() {
// just go through some common cases to make sure code is working
assertEquals(Testing name 'Name', false,
XMLUtils.isWellFormedXMLName(Name));
assertEquals(Testing name 'Name', false,
XMLUtils.isWellFormedXMLName(Name));
assertEquals(Testing name 'Name'', false,
XMLUtils.isWellFormedXMLName(Name'));
assertEquals(Testing name 'Name_:-.', true,
XMLUtils.isWellFormedXMLName(Name_:-.));
assertEquals(Testing name '.Name', false,
XMLUtils.isWellFormedXMLName(.Name));
assertEquals(Testing name '-Name', false,
XMLUtils.isWellFormedXMLName(-Name));
assertEquals(Testing name ':Name', true,
XMLUtils.isWellFormedXMLName(:Name));
assertEquals(Testing name '_Name', true,
XMLUtils.isWellFormedXMLName(_Name));
assertEquals(Testing name
cvs commit: jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/io BeanWriter.java
rdonkin 2003/01/19 15:22:48
Modified:betwixt/src/java/org/apache/commons/betwixt/io
BeanWriter.java
Log:
Moved utility methods into XMLUtils. Deprecated methods that were moved.
Revision ChangesPath
1.14 +9 -65
jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/io/BeanWriter.java
Index: BeanWriter.java
===
RCS file:
/home/cvs/jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/io/BeanWriter.java,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -r1.13 -r1.14
--- BeanWriter.java 7 Jan 2003 22:32:57 - 1.13
+++ BeanWriter.java 19 Jan 2003 23:22:47 - 1.14
@@ -72,6 +72,8 @@
import org.apache.commons.logging.LogFactory;
import org.xml.sax.SAXException;
+import org.apache.commons.betwixt.XMLUtils;
+
/** pcodeBeanWriter/code outputs beans as XML to an io stream./p
*
* pThe output for each bean is an xml fragment
@@ -121,17 +123,6 @@
*/
public class BeanWriter extends AbstractBeanWriter {
-/** Escaped codelt;/code entity */
-private static final String LESS_THAN_ENTITY = lt;;
-/** Escaped codegt;/code entity */
-private static final String GREATER_THAN_ENTITY = gt;;
-/** Escaped codeamp;/code entity */
-private static final String AMPERSAND_ENTITY = amp;;
-/** Escaped code'/code entity */
-private static final String APOSTROPHE_ENTITY = apos;;
-/** Escaped code/code entity */
-private static final String QUOTE_ENTITY = quot;;
-
/** Where the output goes */
private Writer writer;
/** text used for end of lines. Defaults to code\n/code*/
@@ -364,7 +355,7 @@
log.error( [expressBodyText]Body text is null );
} else {
-writer.write( escapeBodyValue(text) );
+writer.write( XMLUtils.escapeBodyValue(text) );
}
}
@@ -395,7 +386,7 @@
writer.write( ' ' );
writer.write( qualifiedName );
writer.write( =\ );
-writer.write( escapeAttributeValue(value) );
+writer.write( XMLUtils.escapeAttributeValue(value) );
writer.write( '\' );
}
@@ -433,29 +424,10 @@
*
* @param value escape codevalue.toString()/code
* @return text with escaped delimiters
+ * @deprecated After 1.0-Alpha-1 moved into utility class {@link
XMLUtils#escapeBodyValue}
*/
protected String escapeBodyValue(Object value) {
-StringBuffer buffer = new StringBuffer(value.toString());
-for (int i=0, size = buffer.length(); i size; i++) {
-switch (buffer.charAt(i)) {
-case '':
-buffer.replace(i, i+1, LESS_THAN_ENTITY);
-size += 3;
-i+=3;
-break;
- case '':
-buffer.replace(i, i+1, GREATER_THAN_ENTITY);
-size += 3;
-i += 3;
-break;
- case '':
-buffer.replace(i, i+1, AMPERSAND_ENTITY);
-size += 4;
-i += 4;
-break;
-}
-}
-return buffer.toString();
+return XMLUtils.escapeBodyValue(value);
}
/**
@@ -464,39 +436,11 @@
*
* @param value escape codevalue.toString()/code
* @return text with characters restricted (for use in attributes) escaped
+ *
+ * @deprecated After 1.0-Alpha-1 moved into utility class {@link
XMLUtils#escapeAttributeValue}
*/
protected String escapeAttributeValue(Object value) {
-StringBuffer buffer = new StringBuffer(value.toString());
-for (int i=0, size = buffer.length(); i size; i++) {
-switch (buffer.charAt(i)) {
-case '':
-buffer.replace(i, i+1, LESS_THAN_ENTITY);
-size += 3;
-i+=3;
-break;
- case '':
-buffer.replace(i, i+1, GREATER_THAN_ENTITY);
-size += 3;
-i += 3;
-break;
- case '':
-buffer.replace(i, i+1, AMPERSAND_ENTITY);
-size += 4;
-i += 4;
-break;
- case '\'':
-buffer.replace(i, i+1, APOSTROPHE_ENTITY);
-size += 4;
-i += 4;
-break;
- case '\':
-buffer.replace(i, i+1, QUOTE_ENTITY);
-size += 5;
-i += 5;
-
cvs commit: jakarta-commons/betwixt/xdocs tasks.xml
rdonkin 2003/01/19 15:25:53
Modified:betwixt/src/java/org/apache/commons/betwixt/digester
AttributeRule.java ElementRule.java
betwixt/src/test/org/apache/commons/betwixt/dotbetwixt
TestBeanToXml.java
betwixt/xdocs tasks.xml
Added: betwixt/src/test/org/apache/commons/betwixt/dotbetwixt
BadDotBetwixtNamesBean.betwixt
BadDotBetwixtNamesBean.java
Log:
Added validity check for element and attribute names in .betwixt files. Only certain
names are allowed by the XML specification. Now when the name specified in a .betwixt
will be checked to make sure it complied with these rules.
Revision ChangesPath
1.6 +9 -1
jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/digester/AttributeRule.java
Index: AttributeRule.java
===
RCS file:
/home/cvs/jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/digester/AttributeRule.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- AttributeRule.java7 Jan 2003 22:32:57 - 1.5
+++ AttributeRule.java19 Jan 2003 23:25:52 - 1.6
@@ -61,6 +61,7 @@
import org.apache.commons.betwixt.AttributeDescriptor;
import org.apache.commons.betwixt.ElementDescriptor;
+import org.apache.commons.betwixt.XMLUtils;
import org.apache.commons.betwixt.expression.ConstantExpression;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
@@ -95,12 +96,19 @@
* Process the beginning of this element.
*
* @param attributes The attribute list of this element
- * @throws SAXException if the attribute tag is not inside an element tag
+ * @throws SAXException 1. If the attribute tag is not inside an element tag.
+ * 2. If the name attribute is not valid XML attribute name.
*/
public void begin(Attributes attributes) throws SAXException {
AttributeDescriptor descriptor = new AttributeDescriptor();
String name = attributes.getValue( name );
+
+// check that name is well formed
+if ( !XMLUtils.isWellFormedXMLName( name ) ) {
+throw new SAXException(' + name + ' would not be a well formed xml
attribute name.);
+}
+
descriptor.setQualifiedName( name );
descriptor.setLocalName( name );
String uri = attributes.getValue( uri );
1.7 +8 -1
jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/digester/ElementRule.java
Index: ElementRule.java
===
RCS file:
/home/cvs/jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/digester/ElementRule.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- ElementRule.java 7 Jan 2003 22:32:57 - 1.6
+++ ElementRule.java 19 Jan 2003 23:25:52 - 1.7
@@ -63,6 +63,7 @@
import org.apache.commons.betwixt.ElementDescriptor;
import org.apache.commons.betwixt.XMLBeanInfo;
+import org.apache.commons.betwixt.XMLUtils;
import org.apache.commons.betwixt.expression.ConstantExpression;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
@@ -96,10 +97,16 @@
* Process the beginning of this element.
*
* @param attributes The attribute list of this element
- * @throws SAXException when this tag's parent is not either an info or element
tag
+ * @throws SAXException 1. If this tag's parent is not either an info or
element tag.
+ * 2. If the name attribute is not valid XML element name.
*/
public void begin(Attributes attributes) throws SAXException {
String name = attributes.getValue( name );
+
+// check that name is well formed
+if ( !XMLUtils.isWellFormedXMLName( name ) ) {
+throw new SAXException(' + name + ' would not be a well formed xml
element name.);
+}
ElementDescriptor descriptor = new ElementDescriptor();
descriptor.setQualifiedName( name );
1.8 +21 -4
jakarta-commons/betwixt/src/test/org/apache/commons/betwixt/dotbetwixt/TestBeanToXml.java
Index: TestBeanToXml.java
===
RCS file:
/home/cvs/jakarta-commons/betwixt/src/test/org/apache/commons/betwixt/dotbetwixt/TestBeanToXml.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- TestBeanToXml.java30 Dec 2002 22:45:05 - 1.7
+++ TestBeanToXml.java19 Jan 2003 23:25:52 - 1.8
@@ -148,5 +148,22 @@
parseString(xml));
*/
}
Re: [Jelly] BCEL Taglibrary Beginnings
Cool. We almost have a CodeDOM :)
--
dIon Gillard, Multitask Consulting
Blog: http://www.freeroller.net/page/dion/Weblog
Work: http://www.multitask.com.au
Mark R. Diggory [EMAIL PROTECTED] wrote on 20/01/2003
10:06:03 AM:
I started writting the beginnings of a BCEL taglibrary. Although it may
be a bit different than others may anticipate.
Basically I've built two tags and a supporting BeanExtender class to
support them.
bcel:extends
baseClass=java.lang.Object
packageName=org.foo
className=Test
bcel:add-property name=bar propertyType=int write=false/
bcel:add-property name=bam propertyType=java.lang.String/
/bcel:extends
Basically creates a new Class (org.foo.Test) that has:
package org.foo;
public Test extends java.lang.Object {
private int bar;
private String bam;
public Test(){}
public int getBar(){
return bar;
}
public String getBam(){
return bam;
}
public void setBam(String bam){
this.bam = bam;
}
}
It then changes the Security access on the ClassLoader define
method. Allowing the class to be added into the current loader. Once the
class is available it can then be instantiated by useBean or new.
I'm sure there are some more flexible ways to design the Taglibrary, I
consider this to be a first blush over the idea. I'd be glad to donate
the code if others are interested in developing it too.
-Mark Diggory
--
To unsubscribe, e-mail:
mailto:[EMAIL PROTECTED]
For additional commands, e-mail:
mailto:[EMAIL PROTECTED]
ForwardSourceID:NT000A55CE
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-commons/jxpath/src/java/org/apache/commons/jxpath/ri/model VariablePointer.java
dmitri 2003/01/19 15:58:27
Modified:jxpath/src/java/org/apache/commons/jxpath/ri/model
VariablePointer.java
Log:
Fixed issues with variables: qualified names and indexing
Revision ChangesPath
1.12 +13 -18
jakarta-commons/jxpath/src/java/org/apache/commons/jxpath/ri/model/VariablePointer.java
Index: VariablePointer.java
===
RCS file:
/home/cvs/jakarta-commons/jxpath/src/java/org/apache/commons/jxpath/ri/model/VariablePointer.java,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- VariablePointer.java 12 Jan 2003 01:52:56 - 1.11
+++ VariablePointer.java 19 Jan 2003 23:58:27 - 1.12
@@ -68,7 +68,6 @@
import org.apache.commons.jxpath.Variables;
import org.apache.commons.jxpath.ri.QName;
import org.apache.commons.jxpath.ri.compiler.NodeTest;
-import org.apache.commons.jxpath.ri.model.beans.NullPointer;
import org.apache.commons.jxpath.util.ValueUtils;
/**
@@ -108,7 +107,7 @@
if (!actual) {
throw new JXPathException(Undefined variable: + name);
}
-return variables.getVariable(name.getName());
+return variables.getVariable(name.toString());
}
public boolean isLeaf() {
@@ -129,7 +128,7 @@
}
return value;
}
-
+
public void setValue(Object value) {
if (!actual) {
throw new JXPathException(Cannot set undefined variable: + name);
@@ -140,30 +139,26 @@
ValueUtils.setValue(collection, index, value);
}
else {
-variables.declareVariable(name.getName(), value);
+variables.declareVariable(name.toString(), value);
}
}
public boolean isActual() {
return actual;
}
+
+public void setIndex(int index) {
+super.setIndex(index);
+valuePointer = null;
+}
public NodePointer getImmediateValuePointer() {
if (valuePointer == null) {
Object value = null;
if (actual) {
value = getImmediateNode();
-valuePointer =
-NodePointer.newChildNodePointer(this, null, value);
-}
-else {
-return new NullPointer(this, getName()) {
-public Object getImmediateNode() {
-throw new JXPathException(
-Undefined variable: + name);
-}
-};
}
+valuePointer = NodePointer.newChildNodePointer(this, null, value);
}
return valuePointer;
}
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-commons/jxpath/src/java/org/apache/commons/jxpath/ri/model VariablePointer.java
dmitri 2003/01/19 16:07:53
Modified:jxpath/src/java/org/apache/commons/jxpath/ri/model
VariablePointer.java
Log:
Refix: accidentally undid a previous fix
Revision ChangesPath
1.13 +16 -6
jakarta-commons/jxpath/src/java/org/apache/commons/jxpath/ri/model/VariablePointer.java
Index: VariablePointer.java
===
RCS file:
/home/cvs/jakarta-commons/jxpath/src/java/org/apache/commons/jxpath/ri/model/VariablePointer.java,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- VariablePointer.java 19 Jan 2003 23:58:27 - 1.12
+++ VariablePointer.java 20 Jan 2003 00:07:52 - 1.13
@@ -68,6 +68,7 @@
import org.apache.commons.jxpath.Variables;
import org.apache.commons.jxpath.ri.QName;
import org.apache.commons.jxpath.ri.compiler.NodeTest;
+import org.apache.commons.jxpath.ri.model.beans.NullPointer;
import org.apache.commons.jxpath.util.ValueUtils;
/**
@@ -157,12 +158,21 @@
Object value = null;
if (actual) {
value = getImmediateNode();
+valuePointer =
+NodePointer.newChildNodePointer(this, null, value);
+}
+else {
+return new NullPointer(this, getName()) {
+public Object getImmediateNode() {
+throw new JXPathException(
+Undefined variable: + name);
+}
+};
}
-valuePointer = NodePointer.newChildNodePointer(this, null, value);
}
return valuePointer;
}
-
+
public int getLength() {
if (actual) {
Object value = getBaseValue();
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/resources project.xml
craigmcc2003/01/19 16:37:07 Modified:resources project.xml Log: Updated the project.xml dependencies so that Maven can build commons-resources again. I also fixed the pattern for the unit test cases, but don't know the magic incantation needed to get Maven to actually run them. PR: Bugzilla #13621 Submitted by: Joe Germuska joe at germuska.com Revision ChangesPath 1.3 +15 -18jakarta-commons-sandbox/resources/project.xml Index: project.xml === RCS file: /home/cvs/jakarta-commons-sandbox/resources/project.xml,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- project.xml 17 Jul 2002 19:46:15 - 1.2 +++ project.xml 20 Jan 2003 00:37:07 - 1.3 @@ -88,50 +88,47 @@ /developers dependencies + dependency idxml-apis/id version2.0.2/version /dependency dependency - idcommons-logging/id - version1.0/version -/dependency - -dependency idcommons-beanutils/id - version1.4-dev/version + version1.5/version /dependency dependency idcommons-collections/id - version2.0/version + version2.1/version /dependency dependency idcommons-digester/id - version1.2/version + version1.3/version /dependency dependency - idservletapi/id - version2.3/version + idcommons-discovery/id + version0.1/version /dependency - !-- for testing -- dependency - idcommons-httpclient/id - version2.0-dev/version + idcommons-logging/id + version1.0.2/version /dependency dependency - idjunit/id - version3.7/version + idservletapi/id + version2.3/version /dependency + !-- for testing -- + dependency - idcactus/id - version1.2/version + idjunit/id + version3.8.1/version /dependency /dependencies @@ -148,7 +145,7 @@ !-- Unit test classes -- unitTest includes -include**/Test*.java/include +include**/*TestCase.java/include /includes /unitTest -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 13621] - [resources] fixes to Maven project.xml
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13621. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13621 [resources] fixes to Maven project.xml [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-01-20 00:38 --- Updated the dependencies so that Maven can build commons-resources. I also fixed the pattern for the unit test classes, but don't know what magic incantation is to get Maven to actually run them. The updated project.xml file is available as of the 20030120 nightly build. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [jelly] Taglib split out - done?
--- [EMAIL PROTECTED] wrote: Morgan Delagrange [EMAIL PROTECTED] wrote on 20/01/2003 05:45:53 AM: I think my priorities would be: 1) Stabilize GUMP builds for all taglibs. 2) Raise and resolve remaining release issues. 3) Release Jelly 1.0. I think websites and documentation for the taglibs are a nice-to-have until Jelly is released. Obviously not a user :) -- dIon Gillard, Multitask Consulting I'm reaching for the low-hanging fruit. Release early, release often, right? How many users care about the core taglib and Jelly* interfaces (nearly all), and how many care about any individual taglib (relatively few). If we work on all the taglibs simultaneously, that pushed the Jelly release further off. Of course, I'm not telling anybody what to do, go to town. I'm just saying what I think is the most important milestone. - Morgan = Morgan Delagrange http://jakarta.apache.org/taglibs http://jakarta.apache.org/commons http://axion.tigris.org http://jakarta.apache.org/watchdog __ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-commons/collections/src/java/org/apache/commons/collections CollectionUtils.java
scolebourne2003/01/19 17:29:30
Modified:collections/src/java/org/apache/commons/collections
CollectionUtils.java
Log:
Improve speed of countMatches()
from Peter KoBek
Revision ChangesPath
1.26 +14 -5
jakarta-commons/collections/src/java/org/apache/commons/collections/CollectionUtils.java
Index: CollectionUtils.java
===
RCS file:
/home/cvs/jakarta-commons/collections/src/java/org/apache/commons/collections/CollectionUtils.java,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -r1.25 -r1.26
--- CollectionUtils.java 11 Jan 2003 01:07:13 - 1.25
+++ CollectionUtils.java 20 Jan 2003 01:29:30 - 1.26
@@ -33,7 +33,7 @@
*
* 5. Products derived from this software may not be called Apache
*nor may Apache appear in their names without prior written
- *permission of the Apache Group.
+ *permission of the Apache Software Foundation.
*
* THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
* WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
@@ -84,7 +84,7 @@
* @author Stephen Colebourne
* @author Steve Downey
* @author a href=[EMAIL PROTECTED]Herve Quiroz/a
- * @author [EMAIL PROTECTED] (Peter)
+ * @author Peter KoBek
*/
public class CollectionUtils {
@@ -443,7 +443,16 @@
* @throws NullPointerException if the input collection is null
*/
public static int countMatches(Collection inputCollection, Predicate predicate)
{
-return select(inputCollection, predicate).size();
+int count = 0;
+if (inputCollection != null predicate != null) {
+for (Iterator it = inputCollection.iterator(); it.hasNext();) {
+Object item = it.next();
+if (predicate.evaluate(item)) {
+count++;
+}
+}
+}
+return count;
}
/**
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [collections] performance enhancement for CollectionUtils#countMatches
Your proposed change to countMatches makes sense and I have applied it.
Your proposed addition of exists is more troublesome. I agree that it will
halve the average time to retrieve the result. But it does widen the public
API. I think overall it probably is justified.
Would you like to create a patch for the exists and a suitable test case?
Stephen
From: Peter Koßek [EMAIL PROTECTED]
1. I recommend to change the code of the new method
CollectionUtils#countMatches. It unnecessarily creates an ArrayList and adds
elements from the input collection to it.
public static int countMatches(Collection inputCollection, Predicate
predicate) {
int count = 0;
if (inputCollection != null predicate != null) {
for (Iterator iter = inputCollection.iterator();
iter.hasNext();) {
Object item = iter.next();
if (predicate.evaluate(item)) {
count++;
}
}
}
return count;
}
2. Furthermore, I suggest to introduce a new method CollectionUtils#exists,
which tells the caller whether at least one element of a collection fulfills
a given predicate. I suggest this because it would cost twice the time to
compute #exists with the help of #countMatches.
/** Answers true if a predicate is true for at least one element of a
collection
* @return whether at least one element of the collection matches the
* predicate or false if none could be found
*/
public static boolean exists(Collection collection, Predicate predicate)
{
if (collection != null predicate != null) {
for (Iterator iter = collection.iterator(); iter.hasNext();) {
Object item = iter.next();
if (predicate.evaluate(item)) {
return true;
}
}
}
return false;
}
To illustrate this, I have programmed a small benchmark test which compares
4 different kinds of #exists
- using #select over the momentary implementation of #countMatches
- using the recommended implementation of #countMatches
- using the suggested implementation of #exists
- using a traditional solution without the flexibility of predicates
The test output is shown at the bottom of this mail.
Greetings
Peter Koßek
--
Tests with different #exist methods to iterate through a class collection
using predicate #isInterface
The test will be tried out 1 times, the size of the collection is 1000.
The test machine is a Pentium like processor with 800 MHz on W2K with JDK
1.3.1_06.
To execute aClass.isInterface() 1000 times, this processor needs 1572
milliseconds.
A - The element fulfilling the predicate is at the beginning of the
collection.
A-1 Testing the existence of a predicate using 'CollectionUtils.select()'.
size 1000 difference 2974
A-2 Testing the existence of a predicate using
'ExperimentalCollectionUtils.countHits()'.
size 1000 difference 2824
A-3 Testing the existence of a predicate using
'ExperimentalCollectionUtils.exists()'.
size 1000 difference 10
A-4 Testing the existence of a predicate in the traditional way.
size 1000 difference 10
B - The element fulfilling the predicate is before the middle of the
collection.
B-1 Testing the existence of a predicate using 'CollectionUtils.select()'.
size 1000 difference 2954
B-2 Testing the existence of a predicate using
'ExperimentalCollectionUtils.countHits()'.
size 1000 difference 2814
B-3 Testing the existence of a predicate using
'ExperimentalCollectionUtils.exists()'.
size 1000 difference 1382
B-4 Testing the existence of a predicate in the traditional way.
size 1000 difference 1321
C - The element fulfilling the predicate is at the end of the collection.
C-1 Testing the existence of a predicate using 'CollectionUtils.select()'.
size 1000 difference 2984
C-2 Testing the existence of a predicate using
'ExperimentalCollectionUtils.countHits()'.
size 1000 difference 2754
C-3 Testing the existence of a predicate using
'ExperimentalCollectionUtils.exists()'.
size 1000 difference 2764
C-4 Testing the existence of a predicate in the traditional way.
size 1000 difference 2643
__
Werden Sie kreativ! Bei WEB.DE FreeMail hei?t es jetzt nicht nur schreiben,
sondern auch gestalten. http://freemail.web.de/features/?mc=021142
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
[dom4jconfiguration] Improved save()
Added a little fault-tolerance into save() method, saving to temp
file, then renaming if no errors thrown.
See attached for patch.
Index: DOM4JConfiguration.java
===
RCS file:
/home/cvspublic/jakarta-commons-sandbox/configuration/src/java/org/apache/commons/configuration/DOM4JConfiguration.java,v
retrieving revision 1.1
diff -u -r1.1 DOM4JConfiguration.java
--- DOM4JConfiguration.java 14 Jan 2003 03:53:12 - 1.1
+++ DOM4JConfiguration.java 20 Jan 2003 02:38:48 -
@@ -56,7 +56,9 @@
import java.io.BufferedOutputStream;
import java.io.File;
+import java.io.FileInputStream;
import java.io.FileOutputStream;
+import java.io.InputStream;
import java.io.IOException;
import java.io.OutputStream;
import java.net.URL;
@@ -305,7 +307,7 @@
}
/**
- * @throws
+ * @throws
*/
private void possiblySave()
{
@@ -336,10 +338,15 @@
{
XMLWriter writer = null;
OutputStream out = null;
+// write to a temp file in case of errors
+File temp = null;
try
{
+temp = new File(file.getParentFile(), file.getName() + .tmp);
+// in case an exception is thrown, let JVM clean up
+temp.deleteOnExit();
OutputFormat outputter = OutputFormat.createPrettyPrint();
-out = new BufferedOutputStream(new FileOutputStream(file));
+out = new BufferedOutputStream(new FileOutputStream(temp));
writer = new XMLWriter(out, outputter);
writer.write(document);
}
@@ -353,6 +360,40 @@
if (writer != null)
{
writer.close();
+}
+}
+
+// no exceptions are thrown, so its safe to overwrite
+file.delete();
+if (temp.renameTo(file) == false)
+{
+InputStream in = null;
+/**
+ * fails if the temporary storage directory was on
+ * different volume than the target directory;
+ * attempt a raw copy.
+ */
+try
+{
+out = new FileOutputStream(file);
+in = new FileInputStream(temp);
+byte[] data = new byte[1];
+int len;
+while ((len = in.read(data)) != -1)
+{
+out.write(data, 0, len);
+}
+}
+finally
+{
+if (out != null)
+{
+out.close();
+}
+if (in != null)
+{
+in.close();
+}
}
}
}
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
[dom4jconfiguration] Improved save()
Added a little fault-tolerance into save() method, saving to temp
file, then renaming if no errors thrown.
See attached for patch.
Index: DOM4JConfiguration.java
===
RCS file:
/home/cvspublic/jakarta-commons-sandbox/configuration/src/java/org/apache/commons/configuration/DOM4JConfiguration.java,v
retrieving revision 1.1
diff -u -r1.1 DOM4JConfiguration.java
--- DOM4JConfiguration.java 14 Jan 2003 03:53:12 - 1.1
+++ DOM4JConfiguration.java 20 Jan 2003 02:38:48 -
@@ -56,7 +56,9 @@
import java.io.BufferedOutputStream;
import java.io.File;
+import java.io.FileInputStream;
import java.io.FileOutputStream;
+import java.io.InputStream;
import java.io.IOException;
import java.io.OutputStream;
import java.net.URL;
@@ -305,7 +307,7 @@
}
/**
- * @throws
+ * @throws
*/
private void possiblySave()
{
@@ -336,10 +338,15 @@
{
XMLWriter writer = null;
OutputStream out = null;
+// write to a temp file in case of errors
+File temp = null;
try
{
+temp = new File(file.getParentFile(), file.getName() + .tmp);
+// in case an exception is thrown, let JVM clean up
+temp.deleteOnExit();
OutputFormat outputter = OutputFormat.createPrettyPrint();
-out = new BufferedOutputStream(new FileOutputStream(file));
+out = new BufferedOutputStream(new FileOutputStream(temp));
writer = new XMLWriter(out, outputter);
writer.write(document);
}
@@ -353,6 +360,40 @@
if (writer != null)
{
writer.close();
+}
+}
+
+// no exceptions are thrown, so its safe to overwrite
+file.delete();
+if (temp.renameTo(file) == false)
+{
+InputStream in = null;
+/**
+ * fails if the temporary storage directory was on
+ * different volume than the target directory;
+ * attempt a raw copy.
+ */
+try
+{
+out = new FileOutputStream(file);
+in = new FileInputStream(temp);
+byte[] data = new byte[1];
+int len;
+while ((len = in.read(data)) != -1)
+{
+out.write(data, 0, len);
+}
+}
+finally
+{
+if (out != null)
+{
+out.close();
+}
+if (in != null)
+{
+in.close();
+}
}
}
}
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [Jelly] BCEL Taglibrary Beginnings
On Sun, 2003-01-19 at 18:06, Mark R. Diggory wrote:
I started writting the beginnings of a BCEL taglibrary. Although it may
be a bit different than others may anticipate.
Basically I've built two tags and a supporting BeanExtender class to
support them.
bcel:extends
baseClass=java.lang.Object
packageName=org.foo
className=Test
bcel:add-property name=bar propertyType=int write=false/
bcel:add-property name=bam propertyType=java.lang.String/
/bcel:extends
Basically creates a new Class (org.foo.Test) that has:
package org.foo;
public Test extends java.lang.Object {
private int bar;
private String bam;
public Test(){}
public int getBar(){
return bar;
}
public String getBam(){
return bam;
}
public void setBam(String bam){
this.bam = bam;
}
}
It then changes the Security access on the ClassLoader define
method. Allowing the class to be added into the current loader. Once the
class is available it can then be instantiated by useBean or new.
I'm sure there are some more flexible ways to design the Taglibrary, I
consider this to be a first blush over the idea. I'd be glad to donate
the code if others are interested in developing it too.
+1
I think that's nifty neato! What I'm really interested in is the Java
code backing the Jelly. I've always wanted to make a simple API for BCEL
for creating bytecode and it looks like you've got a awesome start to
one.
-Mark Diggory
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
--
jvz.
Jason van Zyl
[EMAIL PROTECTED]
http://tambora.zenplex.org
In short, man creates for himself a new religion of a rational
and technical order to justify his work and to be justified in it.
-- Jacques Ellul, The Technological Society
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Rep:Re: Re:Re: [Betwixt] complex recursion
Thanks, it seems to work correctly.
Emmanuel
-Message d'origine-
De: Martin van den Bemt [EMAIL PROTECTED]
A: Jakarta Commons Developers List [EMAIL PROTECTED]
Date: 19/01/03
Objet: Re: Re:Re: [Betwixt] complex recursion
Fixed in cvs HEAD and in the alpha release branch.
I'll wait for an update on the testcases a bit, since I updated the
recursion testcases quite a bit. (actually checking content now). Since
I have a refactor going on of BeanWriter at the same time, I must be
positive that any fixes to the testcases still are working when I
finished the refactor :)
Mvgr,
Martin
On Sun, 2003-01-19 at 10:21, Emmanuel Venisse wrote:
Hi Martin,
I modify the test case, Element class and add Subelement.java and
recursion3.xml
Index: Element.java
===
RCS file:
/home/cvs/jakarta-commons/betwixt/src/test/org/apache/commons/betwixt/re
cursion/Element.java,v
retrieving revision 1.3
diff -r1.3 Element.java
75a76
ArrayList subelements;
84a86
subelements = new ArrayList();
112a115,124
public void addSubelement(Subelement subelement)
{
subelements.add(subelement);
}
public List getSubelements()
{
return subelements;
}
Index: TestRecursion.java
===
RCS file:
/home/cvs/jakarta-commons/betwixt/src/test/org/apache/commons/betwixt/re
cursion/TestRecursion.java,v
retrieving revision 1.6
diff -r1.6 TestRecursion.java
133a134,150
* This will test reading a complex recursive xml file
*/
public void
testComplexReadWithoutCollectionsInElementRoundTrip()
throws Exception
{
System.out.println(\ntestComplexReadWithoutCollectionsInElement()\n);
XMLIntrospector intro = createXMLIntrospector();
BeanReader reader = new BeanReader();
reader.registerBeanClass(ElementBean.class);
reader.setXMLIntrospector(intro);
Object object =
reader.parse(getTestFileURL(src/test/org/apache/commons/betwixt/recursi
on/recursion3.xml));
StringWriter buffer = new StringWriter();
write (object, buffer, false);
System.out.println(buffer : +buffer);
}
/**
Emmanuel
-Message d'origine-
De: Martin van den Bemt [EMAIL PROTECTED]
A: Jakarta Commons Developers List [EMAIL PROTECTED]
Date: 17/01/03
Objet: Re: [Betwixt] complex recursion
Emmanuel,
Could you sent over the sources (preferrably with testcase, saves
time),
so I can have a look at it (everything is working here, with the
testcase
o.a.commons.betwixt.io.TestRecursion (your example does resemble the
test that is done on recursion2.xml a lot).
The current cvs version of the test is not up-to-date btw (it's not
even
checking on content), but I fixed that locally.
I will see if I can commit them in cvs seperately from the other
changes
I've made, so you can have a look yourself at the testcase.
btw
You can also send a diff for the bean you use compared to the bean
that
is currently is cvs (ElementBean and children), so I can change the
current recursion2.xml and add the subelement element to the testcase.
(please use cvs diff -u )
Mvgr,
Martin
On Wed, 2003-01-15 at 10:58, Emmanuel Venisse wrote:
Hi,
I try to use betwixt with a complex recursive xml like this :
?xml version=1.0?
ElementBean
element name=element1
subelement name=sub1/
element name=element11
subelement name=sub11/
element name=element111/
element name=element112
subelement name=sub112/
/element
/element
element name=element12/
/element
element name=element2
subelement name=sub2/
/element
/ElementBean
All element are created but only subelements sub1 and sub2 are
created. Other subelements are ignored.
any ideas?
Thanks
Emmanuel
_
Envie de discuter en live avec vos amis ? Télécharger MSN
Messenger
http://www.ifrance.com/_reloc/m la 1ère messagerie instantanée de
France
--
To unsubscribe, e-mail:
mailto:[EMAIL PROTECTED]
For additional commands, e-mail:
mailto:[EMAIL PROTECTED]
--
To unsubscribe, e-mail:
mailto:[EMAIL PROTECTED]
For additional commands, e-mail:
mailto:[EMAIL PROTECTED]
_
Envie de discuter en live avec vos amis ? Télécharger MSN Messenger
http://www.ifrance.com/_reloc/m la 1ère messagerie instantanée de
France
_
GRAND JEU SMS : Pour gagner un NOKIA 7650, envoyez le mot IF au 61321
(prix d'un SMS + 0.35 euro). Un SMS vous dira si vous avez gagné.
Règlement :
cvs commit: jakarta-commons/validator/src/test/org/apache/commons/validator LocaleTest.java validator-locale.xml ValidatorTestSuite.java
turner 2003/01/19 22:15:06 Modified:validator/src/share/org/apache/commons/validator ValidatorResources.java ValidatorResourcesInitializer.java validator/src/test/org/apache/commons/validator ValidatorTestSuite.java Added: validator/conf/share validator_1_0_1.dtd validator/src/test/org/apache/commons/validator LocaleTest.java validator-locale.xml Log: Fixes bug 16073. Makes variant work for formsets, and adds it back into the DTD. Moves a few info statements to debug statements to clear up log clutter Revision ChangesPath 1.1 jakarta-commons/validator/conf/share/validator_1_0_1.dtd Index: validator_1_0_1.dtd === !-- DTD for the Validator Rules Configuration File, Version 1.0 To allow for XML validation of your rules configuration file, include the following DOCTYPE element at the beginning (after the xml declaration): !DOCTYPE form-validation PUBLIC -//Apache Software Foundation//DTD Commons Validator Rules Configuration 1.0.1//EN http://jakarta.apache.org/commons/dtds/validator_1_0_1.dtd; $Id: validator_1_0_1.dtd,v 1.1 2003/01/20 06:15:06 turner Exp $ -- !-- === Top Level Elements -- !-- The form-validation element is the root of the configuration file hierarchy, and contains nested elements for all of the other configuration settings. -- !ELEMENT form-validation (global*, formset*) !-- The elements defined here are all global and must be nested within a global element. -- !ELEMENT global (validator*, constant*) !-- The validator element defines what validators objects can be used with the fields referenced by the formset elements. The validator element can accept 4 properties: name, classname, method, methodparams, msg, depends, and jsFunctionName. -- !ELEMENT validator (javascript?) !ATTLIST validator name CDATA #REQUIRED classname CDATA #REQUIRED method CDATA #REQUIRED methodParams CDATA #REQUIRED msgCDATA #REQUIRED dependsCDATA #IMPLIED jsFunctionName CDATA #IMPLIED !-- The javascript element defines a JavaScript that can be used to perform client-side validators. -- !ELEMENT javascript (#PCDATA) !-- The constant element defines a static value that can be used as replacement parameters within field elements. The constant-name and constant-value elements define the constant's reference id and replacement value. -- !ELEMENT constant (constant-name, constant-value) !ELEMENT constant-name (#PCDATA) !ELEMENT constant-value (#PCDATA) !-- The formset element defines a set of forms for a locale. Formsets for specific locales can override only those fields that change. The localization is properly scoped, so that a formset can override just the language, or just the country, or both. -- !ELEMENT formset (constant*, form+) !ATTLIST formset language CDATA #IMPLIED country CDATA #IMPLIED variant CDATA #IMPLIED !-- The form element defines a set of fields to be validated. The name corresponds to the identifer the application assigns to the form. -- !ELEMENT form(field+ ) !ATTLIST formname CDATA #REQUIRED !-- The field element defines the properties to be validated. In a web application, a field would also correspond to a control on a HTML form. To validate the properties, the validator works through a JavaBean representation. The field element can accept up to 4 attributes: propertyThe property on the JavaBean corresponding to this field element. depends The comma-delimited list of validators to apply against this field. For the field to succeed, all the validators must succeed. pageThe JavaBean corresponding to this form may include a page property. Only fields with a page attribute value that is equal to or less than the page property on the form JavaBean are processed. This is useful when using a wizard approach to completing a large form, to ensure that a page is not skipped. [0] indexedListProperty The
Re: [PATCH] CLI using relection.
John Keyes wrote: Nick thanks for the submission. I will review it and post my comments back to you as soon as I get a chance. Thanks again, -John K Things I know I need to do: * Use commons beanutils for setting properties. * Use a custom BeanInfo property to set required. * let primitive boolean fields have optional arg. * handle array properties. * add getOptions() method. R, Nick -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 14146] - Support for preconditions
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14146. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14146 Support for preconditions [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||LATER --- Additional Comments From [EMAIL PROTECTED] 2003-01-20 06:22 --- Something to think about for 1.1 -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-commons/validator/src/test/org/apache/commons/validator EmailTest.java
turner 2003/01/19 22:28:37
Modified:validator/src/share/org/apache/commons/validator
GenericValidator.java
validator/src/test/org/apache/commons/validator
EmailTest.java
Log:
Fixes bug 15898
Dots at the end of domain names
Revision ChangesPath
1.9 +9 -4
jakarta-commons/validator/src/share/org/apache/commons/validator/GenericValidator.java
Index: GenericValidator.java
===
RCS file:
/home/cvs/jakarta-commons/validator/src/share/org/apache/commons/validator/GenericValidator.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- GenericValidator.java 16 Oct 2002 22:17:31 - 1.8
+++ GenericValidator.java 20 Jan 2003 06:28:37 - 1.9
@@ -424,8 +424,13 @@
// Check the whole email address structure
bValid = matchEmailPat.match(emailPat, value);
+if (value.endsWith(.)) {
+bValid = false;
+}
+
// Check the user component of the email address
if (bValid) {
+
String user = matchEmailPat.group(1);
// See if user is valid
1.5 +17 -4
jakarta-commons/validator/src/test/org/apache/commons/validator/EmailTest.java
Index: EmailTest.java
===
RCS file:
/home/cvs/jakarta-commons/validator/src/test/org/apache/commons/validator/EmailTest.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- EmailTest.java15 Dec 2002 21:46:41 - 1.4
+++ EmailTest.java20 Jan 2003 06:28:37 - 1.5
@@ -200,6 +200,19 @@
}
/**
+* pTests the e-mail validation with a dot at the end of
+* the address./p
+ */
+ public void testEmailWithDotEnd() throws ValidatorException {
+ // Create bean to run test on.
+ ValueBean info = new ValueBean();
+
+ info.setValue([EMAIL PROTECTED]);
+ valueTest(info, false);
+
+ }
+
+ /**
* Utlity class to run a test on a value.
*
* @param infoValue to run test on.
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 15898] - GenericValidaor.isEmail bug
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15898. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15898 GenericValidaor.isEmail bug [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-01-20 06:30 --- Fixed in nightly build, nice catch and fix. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 15396] - Indexed properties not being set in ValidatorResults
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15396. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15396 Indexed properties not being set in ValidatorResults [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||LATER --- Additional Comments From [EMAIL PROTECTED] 2003-01-20 06:33 --- We'll look at the issue for 1.1 -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 14278] - add link/info for Struts Console to website
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14278. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14278 add link/info for Struts Console to website [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|commons-|[EMAIL PROTECTED] |[EMAIL PROTECTED] | -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 16045] - null pointer in Validator.java after upgrading to Struts 1.1-b3
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16045. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16045 null pointer in Validator.java after upgrading to Struts 1.1-b3 --- Additional Comments From [EMAIL PROTECTED] 2003-01-20 06:36 --- Yes, but how do you fix it? I can certainly add a more descriptive error message, but if getDepends returns null, something was seriously broken in the parsing of the xml files. You certainly don't want to continue as if nothing happened. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-commons/validator/src/test/org/apache/commons/validator EmailTest.java
turner 2003/01/19 22:50:27
Modified:validator/src/share/org/apache/commons/validator
GenericValidator.java
validator/src/test/org/apache/commons/validator
EmailTest.java
Log:
Fixes bug 16198 , non-ascii characters are now blocked in e-Mail addresses
Revision ChangesPath
1.10 +10 -4
jakarta-commons/validator/src/share/org/apache/commons/validator/GenericValidator.java
Index: GenericValidator.java
===
RCS file:
/home/cvs/jakarta-commons/validator/src/share/org/apache/commons/validator/GenericValidator.java,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- GenericValidator.java 20 Jan 2003 06:28:37 - 1.9
+++ GenericValidator.java 20 Jan 2003 06:50:26 - 1.10
@@ -406,6 +406,7 @@
String word = ( + atom + | + quotedUser + );
// Each pattern must be surrounded by /
+String legalAsciiPat = getDelimittedRegexp(^[\\000-\\177]+$);
String emailPat = getDelimittedRegexp(^(.+)@(.+)$);
String ipDomainPat =
getDelimittedRegexp(^(\\d{1,3})[.](\\d{1,3})[.](\\d{1,3})[.](\\d{1,3})$);
String userPat = getDelimittedRegexp(^ + word + (\\. + word + )*$);
@@ -417,10 +418,15 @@
Perl5Util matchIPPat = new Perl5Util();
Perl5Util matchDomainPat = new Perl5Util();
Perl5Util matchAtomPat = new Perl5Util();
+ Perl5Util matchAsciiPat = new Perl5Util();
boolean ipAddress = false;
boolean symbolic = false;
+if (!matchAsciiPat.match(legalAsciiPat, value)) {
+return false;
+}
+
// Check the whole email address structure
bValid = matchEmailPat.match(emailPat, value);
1.6 +17 -4
jakarta-commons/validator/src/test/org/apache/commons/validator/EmailTest.java
Index: EmailTest.java
===
RCS file:
/home/cvs/jakarta-commons/validator/src/test/org/apache/commons/validator/EmailTest.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- EmailTest.java20 Jan 2003 06:28:37 - 1.5
+++ EmailTest.java20 Jan 2003 06:50:26 - 1.6
@@ -213,6 +213,19 @@
}
/**
+* pTests the e-mail validation with an RCS-noncompliant character in
+* the address./p
+ */
+ public void testEmailWithBogusCharacter() throws ValidatorException {
+ // Create bean to run test on.
+ ValueBean info = new ValueBean();
+
+ info.setValue(andy.noble@\u008fdata-workshop.com);
+ valueTest(info, false);
+
+ }
+
+ /**
* Utlity class to run a test on a value.
*
* @param infoValue to run test on.
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 16198] - isEmail accepts Umlauts and other non-ASCII characters
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16198. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16198 isEmail accepts Umlauts and other non-ASCII characters [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-01-20 06:52 --- Fixed in nightly build Thanks for the catch, James -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
